⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 16, 2007:

11:49 PM Changeset in webkit [25123] by rwlbuis
  • 4 edits
    4 adds in branches/feature-branch

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=14927
use element in SVG does not render after parent is displayed off and on

Also detach the shadow tree when detaching the <use>.

10:29 PM Changeset in webkit [25122] by bdash
  • 4 edits in trunk

Versioning.

10:20 PM Changeset in webkit [25121] by bdash
  • 2 edits in tags/Safari-5523.1/JavaScriptCore

Merge r25078.

Reviewed by Sam.

  • fix <rdar://problem/5410570> Global initializer introduced by use of std::numeric_limits in r24919
  • kjs/ustring.cpp: (KJS::overflowIndicator): Turned into a function. (KJS::maxUChars): Ditto. (KJS::allocChars): Use the functions. (KJS::reallocChars): Ditto. (KJS::UString::expandedSize): Ditto.
10:20 PM Changeset in webkit [25120] by bdash
  • 5 edits
    4 adds in tags/Safari-5523.1

Merge r25076.

LayoutTests:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • editing/deleting/5408255.html: Added.
  • editing/deleting/5408255-expected.checksum: Added.
  • editing/deleting/5408255-expected.png: Added.
  • editing/deleting/5408255-expected.txt: Added.

WebCore:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Use -webkit-user-select:ignore for the deletion UI.

WebKitTools:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES only for elements with the class needsDeletionUI.
10:19 PM Changeset in webkit [25119] by bdash
  • 27 edits in tags/Safari-5523.1/WebCore

Merge r25098.

Reviewed by Hyatt.

Rolling back in. I made a silly mistake in XMLTokenizer that caused
this patch to crash SVG tests. It's fixed now!

Refactor of change for <rdar://problem/5404899> REGRESSION: Mail
crash in WebCore::FontFallbackList::fontDataAt() after dragging
image into text multiple times

The original fix that I made last night prevents the pending style
sheet count from being incremented until the element is in the
document. This fix prevents the style sheet from loading at all
until it is in the document.

Here is the fix.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): Call process. (WebCore::StyleElement::removedFromDocument): This can be reverted to its original state before my patch last night. (WebCore::StyleElement::process): childrenChanged is now called process. Return early if your not in the document. (WebCore::StyleElement::createSheet): Revert change from last night. The inDocument check is now in caller childrenChanged.
  • dom/StyleElement.h: insertedIntoDocument() must now accept an element in addition to a document.

This is an optimization to prevent calling updateStyleSelector()
too frequently.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::finishedParsing): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded):
  • html/HTMLStyleElement.h:
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement): (WebCore::SVGStyleElement::finishedParsing): (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::childrenChanged): (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h: (WebCore::SVGStyleElement::setCreatedByParser):

This is a name change. Document::stylesheetLoaded()
is now Document::removePendingSheet()

  • dom/Document.cpp: (WebCore::Document::removePendingSheet):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::sheetLoaded):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):

This is another name change. closeRenderer() is now
finishedParsing()

  • dom/Node.h: (WebCore::Node::finishedParsing):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::finishedParsing):
  • html/HTMLAppletElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishedParsing):
  • html/HTMLGenericFormElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::finishedParsing):
  • html/HTMLObjectElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popOneBlockCommon):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishedParsing):
  • html/HTMLScriptElement.h: (WebCore::HTMLStyleElement::setCreatedByParser):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishedParsing):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::finishedParsing):
  • ksvg2/svg/SVGElement.h:
10:19 PM Changeset in webkit [25118] by bdash
  • 4 edits in tags/Safari-5523.1/WebCore

Merge r25068.

Reviewed by Maciej.

Fix for <rdar://problem/5404899> REGRESSION: Mail crash in
WebCore::FontFallbackList::fontDataAt() after dragging image into
text multiple times

We were crashing because style information was not up-to-date. This
patch fixes the problem in two ways:

Style information was not up to date at the time of the crash
because the document thought there was still a pending style sheet.
The pending style sheet counter was incremented when a call to
cloneNode from Mail cloned a style node with an imported style
sheet. Because Mail disables the cache, the style sheet did not
load immediately for the cloned node, and we do not check again to
see if it has loaded in time to decrement the pending style sheet
counter before the crash point. The fix here is only to increment
the pending style sheet counter for elements that are already in
the document.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): If we have a CSS style sheet that is currently loading, increment the pending style sheet counter. This should keep the counter accurate in the case where a style node is cloned and then immediately inserted into the document. (WebCore::StyleElement::removedFromDocument): If we have a CSS style sheet that is currently loading, decrement the pending style sheet count. This is required to keep the correct balance, given the change above. (WebCore::StyleElement::createSheet): Only addPendingSheet() and checkLoaded() if we are in the document.

Here is Darin's original fix. It seems worth keeping this fix too.
Font style information should not cause a crash if there are still
pending style sheets. This is good belt-and-suspenders in case
there is another way to run into this bug with a wacky timing
issue.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Update the font.
10:08 PM Changeset in webkit [25117] by bdash
  • 1 copy in tags/Safari-5523.1

New tag.

8:10 PM Changeset in webkit [25116] by ggaren
  • 2 edits in trunk/WebCore

Build fix. (Maybe?)


  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
5:29 PM Changeset in webkit [25115] by justing
  • 5 edits
    6 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5378473> Undoing a deletion that is part of an open typing command fails to reinsert the caret

  • editing/undo/5378473.html: Added.
  • platform/mac/editing: Added.
  • platform/mac/editing/undo: Added.
  • platform/mac/editing/undo/5378473-expected.checksum: Added.
  • platform/mac/editing/undo/5378473-expected.png: Added.
  • platform/mac/editing/undo/5378473-expected.txt: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/5378473>
REGRESSION: Undoing a deletion that is part of an open typing command fails to reinsert the caret


We recently made Undo of a series of deletes select all of the
characters that were deleted, not just the most recently deleted
character. But the code that did this set a new starting selection
after every delete, even those that were part of an open typing
command that started with character insertions or forward deletes,
operations that when undone, remove the starting selection being
set from the document.


After this change we only set a new starting selection if the open typing
command was opened by a backward delete. The new behavior matches TextEdit.
We don't do something similar or forward deletes because TextEdit opens
and closes a new typing command on forward delete (added a FIXME about this).

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): Initialize m_openedByBackwardDelete. (WebCore::TypingCommand::forwardDeleteKeyPressed): Added a FIXME about how in TextEdit, forward deletes open and close a new typing command. (WebCore::TypingCommand::doApply): Set m_openedByBackwardDelete appropriately. (WebCore::TypingCommand::deleteKeyPressed): Only set the starting selection if this delete is the first one in an open typing command or one in a series of deletes that opened the typing command.
  • editing/TypingCommand.h: Added m_openedByBackwardDelete.
4:43 PM Changeset in webkit [25114] by ggaren
  • 12 edits in trunk

WebCore:

Reviewed by Dave Hyatt.


Tweaked the cache eviction model to better balance between live and
dead resources.


For the sake of avoiding evictions during the PLT, the old model
required the sum of dead and live resources to grow to twice the cache
capacity before evicting, and would then evict dead or live down to 0
if necessary. This was a too-high high water mark, which would nullify
much of the value of eviction, and a too-low low water mark, which
would nullify much of the value of the LRU-SP strategy.


This patch changes the model in 3 ways.


  1. The new model for dead resources is a flexible window with a fixed minimum and maximum. The dead resource window is big when live resource pressure is small, and vice versa. This has the immediate advantage of cutting the high water mark by up to 50%. It also enables the following tunable optimizations in future patches:
    1. A dead resource limit of 0 for clients who want that. (Just set the fixed maximum to 0.)
    2. A much higher low water mark. (Just set the fixed minimum to, say, 25% of the cache's capacity.)
    3. A much lower high water mark for users who browse simple pages in one tab. (Just set the fixed maximum to, say, 50% of the cache's capacity.)


I plan to make the changes that actually take advantage of these
tunable optimizations in another check-in.

The new model won't hurt the PLT because it will notice the PLT's low
live resource size, and up the dead resource capacity in response. For
the same reason, the new model should establish a good balance in
real-world use.


  1. Live resource eviction is now based on size(), not encodedSize(). So, a page with lots of large, encoded images will start evicting resources, if necessary, even before all the images paint. This allows you to more accurately stipulate an exact high water mark.


  1. When pruning, prune to a small percentage below capacity, to avoid just having to prune again immediately.

Layout tests pass. PLT shows no regression.

  • history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow): Updated for rename.
  • loader/Cache.cpp: Implemented the algorithm explained above.
  • loader/Cache.h: Removed explicit tracking of decoded data size, since it was unused.
  • loader/CachedResource.cpp: ditto on tracking of decoded data size

WebKit:

Reviewed by Dave Hyatt.


WebKit changes to support new cache eviction model in WebCore.

  • WebView/WebPreferences.m: (+[WebPreferences initialize]): Modified to reflect new API in WebCore.
  • WebView/WebView.mm: (+[WebView _initializeCacheSizesIfNecessary]): Slightly increased cache size on low memory systems to avoid affecting the PLT for now.

win:

Reviewed by Dave Hyatt.

WebKit changes to support new cache eviction model in WebCore.

  • WebPreferences.cpp: (WebPreferences::initialize):
  • WebView/WebPreferences.m: Modified to reflect new API in WebCore.
  • WebView.cpp: (WebView::initializeCacheSizesIfNecessary): Slightly increased cache size on low memory systems to avoid affecting the PLT for now.
4:12 PM Changeset in webkit [25113] by aliceli1
  • 2 edits in trunk/LayoutTests

Removed a fixed test from the skip list. r25112 fixed this test.

  • platform/mac-leopard/Skipped:
4:09 PM Changeset in webkit [25112] by aliceli1
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail

  • DumpRenderTree/DumpRenderTree.m: (createWebView): Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow. (dumpRenderTree): Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
1:50 PM Changeset in webkit [25111] by bdakin
  • 2 edits in trunk/LayoutTests

Reviewed by Hyatt.

Changing this test to get it to pass again after ​http://
trac.webkit.org/projects/webkit/changeset/25098

The test is changing because our new behavior seems correct, though
not completely consistent. ​http://bugs.webkit.org/show_bug.cgi?
id=14979 is tracking the fact that the behavior is not consistent
regarding style elements that are not in the document.

  • fast/css/css-selector-text.html:
12:05 PM Changeset in webkit [25110] by kmccullo
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Adam.

  • Added tests for regressions in other components. In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
  • fast/cookies: Added.
  • fast/cookies/local-file-can-set-cookies-expected.txt: Added.
  • fast/cookies/local-file-can-set-cookies.html: Added.
  • platform/mac-tiger: Added.
  • platform/mac-tiger/Skipped: Added.

WebKitTools:

Reviewed by Adam.

  • Added tests for regressions in other components. In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
  • Scripts/run-webkit-tests:
11:52 AM Changeset in webkit [25109] by darin
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5415029> In Mail, a crash occurs at WebCore::Node::isDescendantOf() when attempting to delete a selection in a table

The bug was caused by createMarkup trying to operate on a range that
has an endpoint in the delete button DOM, because it removes that DOM
during its operation! Still working on a regression test -- it's hard
to make the kind of bad selection that's needed with the DOM, so I might
have to use the eventSender.

  • editing/DeleteButtonController.h: Made some of the identifiers private. We can make them public if we need to use them. Added a getter function for the container element so we can figure out if a given node is inside the DOM added for the delete button.
  • editing/markup.cpp: (WebCore::moveEndpointsBeforeNode): Added. General purpose helper function that moves endpoints of a range to before a given node -- we do this before removing the delete button, so the endpoint is where the delete button was, rather than having an endpoint that's not in the document. (WebCore::createMarkup): Always return empty string, not null string. Get the document by calling ownerDocument on the range rather than getting the document of the commonAncestorContainer. That's because we need to get at the delete button before calling commonAncestorContainer. Call moveEndpointsBeforeNode to move the range endpoints out of the delete button interface before calling disable() which will remove it from the DOM if it's in there. Added an early return for the case where commonAncestor is non-0. If this happens, we would crash later because pastEndNode would not be in the tree. This change alone would prevent the crash, but we'd get bad markup, so we need the moveEndpointsBeforeNode fix. Added null checks for the frame to the range version as in the single-node version so this won't crash immediately on documents that are not in a frame. For the single-node version, added a check if a ndoe of 0 and a node inside the delete button user interface, and return the empty string for those cases.
11:51 AM Changeset in webkit [25108] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.


<rdar://problem/5378847>
After creating and removing a ToDo, the caret disappears as soon as I start to type

  • editing/inserting/5378847-expected.txt: Added.
  • editing/inserting/5378847.html: Added.

WebCore:

Reviewed by Maciej.


<rdar://problem/5378847> After creating and removing a ToDo, the caret disappears as soon as I start to type


  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): A whitespace text node inserted by Mail when a ToDo is removed is completely removed by deleteInsignificantWhitespace, and since it contains the text insertion position, insertion fails. Save the position before the node where text insertion will occur, and if that node is removed, use the saved position for insertion.
9:29 AM Changeset in webkit [25107] by darin
  • 11 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/5413488> REGRESSION: every DOM element is about 40 bytes bigger because it has a Timer

Moved the timer to the document from the element.

  • dom/Document.h: Made frame() inline. Added updateFocusApperanceSoon(), cancelFocusAppearanceUpdate(), m_updateFocusAppearanceTimer, clearXMLVersion(), and updateFocusAppearanceTimerFired(). Also made everything that was previously protected be private instead.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_updateFocusAppearanceTimer. (WebCore::Document::updateFocusAppearanceSoon): Added. Starts timer. (WebCore::Document::cancelFocusAppearanceUpdate): Added. Stops timer. (WebCore::Document::updateFocusAppearanceTimerFired): Added. If the focused node is a focusable element, then calls updateFocusAppearance(false) on it.
  • dom/Element.h: Removed default value of the boolean parameter to updateFocusAppareance. Removed needsFocusAppearanceUpdate(), setNeedsFocusAppearanceUpdate(), updateFocusAppearanceTimerFired(), stopUpdateFocusAppearanceTimer(), m_updateFocusAppearanceTimer, and m_needsFocusAppearanceUpdate. Added updateFocusAppearanceSoonAfterAttach() and cancelFocusAppearanceUpdate().
  • dom/Element.cpp: (WebCore::ElementRareData::ElementRareData): Added initializer for m_needsFocusAppearanceUpdateSoonAfterAttach. (WebCore::Element::Element): Removed initializers for m_updateFocusAppearanceTimer and m_needsFocusAppearanceUpdate. (WebCore::Element::attach): Updated code that starts the focus appearance timer to instead call updateFocusAppearanceSoon() on the document. (WebCore::Element::detach): Replaced call to stopUpdateFocusAppearanceTimer with call to cancelFocusAppearanceUpdate. (WebCore::Element::focus): Added check for node that's already focused, to match the logic that's in the derived classes. This makes it safe for us to remove the override in the derived classes. Also replaced the code that called setNeedsFocusAppearanceUpdate(true) with code to set the rare data flag m_needsFocusAppearanceUpdateSoonAfterAttach and added a call to cancelFocusAppearanceUpdate() in the case where there's no focus appearance update. (WebCore::Element::blur): Replaced call to stopUpdateFocusAppearanceTimer with call to cancelFocusAppearanceUpdate. (WebCore::Element::cancelFocusAppearanceUpdate): Added. Sets m_needsFocusAppearanceUpdateSoonAfterAttach to false, and then calls cancelFocusAppearanceUpdate() on the document, but only if the element is the focused node of the document.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): Replaced code that sets m_xmlVersion directly with a call to a new inline clearXMLVersion() function. (WebCore::HTMLDocument::setCookie): Replaced use of m_policyBaseURL with policyBaseURL(). (WebCore::HTMLDocument::createTokenizer): Replaced uses of m_frame with frame(). (WebCore::HTMLDocument::determineParseMode): Replaced code that sets pMode and hMode directly with calls to setParseMode and setHTMLMode. Replaced use of m_styleSelector with styleSelector().
  • html/HTMLInputElement.h: Removed now-unneed override of focus(). Removed default value of the boolean parameter to updateFocusAppareance.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): Pass the restorePreviousSelection boolean through -- while it's ignored, it no longer has a default value.
  • html/HTMLTextAreaElement.h: Removed now-unneed override of focus(). Removed default value of the boolean parameter to updateFocusAppareance.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • WebCore.exp: Removed the Document::frame() symbol, since it's now inline.
9:13 AM Changeset in webkit [25106] by antti
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for <rdar://problem/5388936>
Crash while setting display:none for a table cell with selection

  • fast/table/destroy-cell-with-selection-crash-expected.txt: Added.
  • fast/table/destroy-cell-with-selection-crash.html: Added.

WebCore:

Reviewed by Maciej.


Fix <rdar://problem/5388936>
Crash while setting display:none for a table cell with selection


Super class destroy() could (through some selection code in removeChild()) trigger section recalc
in middle of RenderTableCell::destroy(), cleaning section dirty bit. This would later crash in
layout since cell grid would still have refence to the dead cell.


Ensure table sections are dirty when leaving destroy method.


I can't figure out tests for row and section changes but they look like
they could crash in similar way as cell.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::destroy):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::destroy):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::destroy):

Aug 15, 2007:

10:17 PM BuildingOnWindows edited by kevino@theolliviers.com
Added note about copying dlls to get tests running. (diff)
9:34 PM Changeset in webkit [25105] by mjs
  • 2 edits in trunk/WebCore/platform/graphics

2007-08-15 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.

<rdar://problem/5389696> leak of 32-byte NSData object (and more?) in WebIconDatabase code path with each refresh of ​http://www.apple.com


  • platform/graphics/BitmapImage.h: Use RetainPtr for m_nsImage and m_tiffRep
  • platform/graphics/mac/ImageMac.mm: (WebCore::BitmapImage::initPlatformData): No need to do anything now (WebCore::BitmapImage::invalidatePlatformData): Simplify (WebCore::BitmapImage::getTIFFRepresentation): Use RetainPtr to avoid leaks (WebCore::BitmapImage::getNSImage): Use RetainPtr to avoid leaks
8:56 PM Changeset in webkit [25104] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Geoff.

<rdar://problem/5389696> leak of 32-byte NSData object (and more?) in WebIconDatabase code path with each refresh of ​http://www.apple.com


  • platform/graphics/BitmapImage.h: Use RetainPtr for m_nsImage and m_tiffRep
  • platform/graphics/mac/ImageMac.mm: (WebCore::BitmapImage::initPlatformData): No need to do anything now (WebCore::BitmapImage::invalidatePlatformData): Simplify (WebCore::BitmapImage::getTIFFRepresentation): Use RetainPtr to avoid leaks (WebCore::BitmapImage::getNSImage): Use RetainPtr to avoid leaks
8:10 PM Changeset in webkit [25103] by darin
  • 7 edits in trunk/WebCore

Reviewed by Anders.

  • fix <rdar://problem/5094895> REGRESSION (r19094): JavaScript timers don't work inside showModalDialog; caret also doesn't blink
  • platform/Timer.h: Added fireTimersInNestedEventLoop.
  • platform/Timer.cpp: (WebCore::TimerBase::fireTimers): Added code to exit if the timersReadyToFire is cleared. This indicates that someone fired the timers in the nested event loop, so we should not fire any more timers ourselves. (WebCore::TimerBase::fireTimersInNestedEventLoop): Added. Sets timersReadyToFire to 0 so we won't return early and do nothing if the shared timer first. Then calls updateSharedTimer() so the shared timer will get scheduled as needed based on any pending timers.
  • page/Chrome.cpp: (WebCore::Chrome::runModal): Call fireTimersInNestedEventLoop before calling runModal on the client.
  • manual-tests/modal-dialog.html: Added a test that uses a timeout.
  • manual-tests/show-modal-dialog-test.html: Fixed a typo.
4:27 PM Changeset in webkit [25102] by thatcher
  • 12 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

HIWebViewCreate now just returns a HIViewRef created with HICocoaViewCreate. This eliminates lots of old code and
makes HIWebView a better citizen starting with Leopard. The old code paths are still needed for Tiger, so now
most of the files in the WebKit/Carbon directory are #ifdef BUILDING_ON_TIGER.

The Tiger code is unchanged and dosen't exhibit the invalidation problem when the window resizes.

  • Carbon/CarbonUtils.m: (WebInitForCarbon): #ifdef BUILDING_ON_TIGER portions of this code that is not needed on Leopard.
  • Carbon/CarbonWindowAdapter.h: #ifdef BUILDING_ON_TIGER
  • Carbon/CarbonWindowAdapter.m: Ditto.
  • Carbon/CarbonWindowContentView.h: Ditto.
  • Carbon/CarbonWindowContentView.m: Ditto.
  • Carbon/CarbonWindowFrame.h: Ditto.
  • Carbon/CarbonWindowFrame.m: Ditto.
  • Carbon/HIViewAdapter.h: Ditto.
  • Carbon/HIViewAdapter.m: Ditto.
  • Carbon/HIWebView.h: Consolidate two #ifdef OBJC blocks into one.
  • Carbon/HIWebView.m: Implement Leopard specific HIWebViewCreate, HIWebViewCreateWithClass and HIWebViewGetWebView. (HIWebViewCreate): Call HIWebViewCreateWithClass passing [WebView class]. (HIWebViewCreateWithClass): Call HICocoaViewCreate with an instance of the class passed in. (HIWebViewGetWebView): Call HICocoaViewGetView.
2:29 PM Changeset in webkit [25101] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14971
REGRESSION: cannot select reporter's e-mail in bugzilla


  • editing/selection/14971-expected.checksum: Added.
  • editing/selection/14971-expected.png: Added.
  • editing/selection/14971-expected.txt: Added.
  • editing/selection/14971.html: Added.

WebCore:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14971
REGRESSION: cannot select reporter's e-mail in bugzilla

  • page/EventHandler.cpp: (WebCore::EventHandler::canMouseDragExtendSelect): Allow drag-selecting inside a -webkit-user-select:ignore region.
1:47 PM Changeset in webkit [25100] by darin
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.make

Clear a stray executable bit.

1:10 PM Changeset in webkit [25099] by bdakin
  • 1 edit
    2 adds in trunk/LayoutTests

Test for new support of empty style sheets.

  • fast/css/emptyStyleTag-expected.txt: Added.
  • fast/css/emptyStyleTag.html: Added.
1:04 PM Changeset in webkit [25098] by bdakin
  • 27 edits in trunk/WebCore

Reviewed by Hyatt.

Rolling back in. I made a silly mistake in XMLTokenizer that caused
this patch to crash SVG tests. It's fixed now!

Refactor of change for <rdar://problem/5404899> REGRESSION: Mail
crash in WebCore::FontFallbackList::fontDataAt() after dragging
image into text multiple times

The original fix that I made last night prevents the pending style
sheet count from being incremented until the element is in the
document. This fix prevents the style sheet from loading at all
until it is in the document.

Here is the fix.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): Call process. (WebCore::StyleElement::removedFromDocument): This can be reverted to its original state before my patch last night. (WebCore::StyleElement::process): childrenChanged is now called process. Return early if your not in the document. (WebCore::StyleElement::createSheet): Revert change from last night. The inDocument check is now in caller childrenChanged.
  • dom/StyleElement.h: insertedIntoDocument() must now accept an element in addition to a document.

This is an optimization to prevent calling updateStyleSelector()
too frequently.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::finishedParsing): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded):
  • html/HTMLStyleElement.h:
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement): (WebCore::SVGStyleElement::finishedParsing): (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::childrenChanged): (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h: (WebCore::SVGStyleElement::setCreatedByParser):

This is a name change. Document::stylesheetLoaded()
is now Document::removePendingSheet()

  • dom/Document.cpp: (WebCore::Document::removePendingSheet):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::sheetLoaded):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):

This is another name change. closeRenderer() is now
finishedParsing()

  • dom/Node.h: (WebCore::Node::finishedParsing):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::finishedParsing):
  • html/HTMLAppletElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishedParsing):
  • html/HTMLGenericFormElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::finishedParsing):
  • html/HTMLObjectElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popOneBlockCommon):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishedParsing):
  • html/HTMLScriptElement.h: (WebCore::HTMLStyleElement::setCreatedByParser):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishedParsing):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::finishedParsing):
  • ksvg2/svg/SVGElement.h:
11:45 AM Changeset in webkit [25097] by thatcher
  • 2 edits in trunk/WebKitTools

Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.

Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
this prevents making "build" directories in each project folder.

  • Scripts/webkitdirs.pm:
11:41 AM Changeset in webkit [25096] by darin
  • 2 edits in trunk

Add trailing newlines.

11:37 AM Changeset in webkit [25095] by darin
  • 2 adds in trunk

Add a copy of the ICU license to the copy of ICU headers that's there for
building on Mac OS X 10.4, for clarity. We might want to move these icu
directories inside a "mac/tiger" subdirectory at some point to make sure
people don't get confused about why these are here.

8:06 AM Changeset in webkit [25094] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Antti Koivisto.

<rdar://problem/5411803> Bumpercar crashes when loading a partial URL (FrameLoader::receivedMainResourceError())

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError): Nil check for the FrameLoader.
7:11 AM Changeset in webkit [25093] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2007-08-13 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin (​sachin.padma@nokia.com).
DESC: Fast display mode must be turned OFF for widgets
​http://bugs.webkit.org/show_bug.cgi?id=14966

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateChildFrameNamed):
7:07 AM Changeset in webkit [25092] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2007-08-03 asong

Reviewed by sachin.
DESC: [S60]: Title area displayed in Security Confirmation querries even though there is no title TSWID: ELTA-75H9ZB
​http://bugs.webkit.org/show_bug.cgi?id=14870

  • BrowserView/src/FormDataLoginStore.cpp: Add KEmtpyTitle Literal

(CFormDataLoginStore::SaveDialogL): Pass the new literal to DialogConfirm method

  • BrowserView/src/HttpLoaderEventToUiListener.cpp:Add KEmtpyTitle Literal

(CHttpLoaderEventToUiListener::AboutToLoadPage): Pass the new literal to DialogConfirm method
(CHttpLoaderEventToUiListener::GetUserAuthenticationDataL): Pass the new literal to DialogConfirm method

  • ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
7:06 AM Changeset in webkit [25091] by spadma
  • 3 edits in S60/trunk/WebKit

asong, reviewed by sachin

DESC: [S60]: Title area displayed in Security Confirmation querries even though there is no title TSWID: ELTA-75H9ZB
​http://bugs.webkit.org/show_bug.cgi?id=14870

  • BrowserView/src/FormDataLoginStore.cpp: Add KEmtpyTitle Literal

(CFormDataLoginStore::SaveDialogL): Pass the new literal to DialogConfirm method

  • BrowserView/src/HttpLoaderEventToUiListener.cpp: Add KEmtpyTitle Literal

(CHttpLoaderEventToUiListener::AboutToLoadPage): Pass the new literal to DialogConfirm me
(CHttpLoaderEventToUiListener::GetUserAuthenticationDataL): Pass the new literal to DialogConfirm me

  • ChangeLog: Using _L(" ") as an argument to DialogConfirm was incorrect. _L is deprecated and _LIT should be used instead. _L does not contain length information necessary to determine whether or not the descriptor passed in as a title is empty or not.
12:48 AM Changeset in webkit [25090] by bdash
  • 28 edits
    2 deletes in trunk

Roll out r25082 and the associated tests in r25083 as it introduced crashes in the SVG layout tests.

Note: See TracTimeline for information about the timeline view.