Context Navigation

← Previous Period
Next Period →

Timeline

Aug 19, 2007:

5:04 PM Changeset in webkit [25153] by aroben

2 edits in trunk/WebCore

Gtk+ build fix.

platform/gdk/TemporaryLinkStubs.cpp: Removed const.

3:07 PM Changeset in webkit [25152] by aroben

7 edits in trunk/WebCore

Fix <rdar://5395835> REGRESSION (r24527): Context menu for edit fields is missing "Font & Writing Direction"

The problem was that ContextMenuItem::setSubMenu was just copying the
HMENU from the ContextMenu passed in on Windows, but that HMENU was
later getting destroyed when the ContextMenu went out of scope.

I added a new ContextMenu::releasePlatformDescription method that is
used in setSubMenu instead. I think an ultimately better design would
be for setSubMenu to take ownership of the ContextMenu that's passed in
(as should insertItem and appendItem), but I decided to be conservative
and just make the changes needed to fix the bug.

Reviewed by Darin.

No test possible.

platform/ContextMenu.h: Added releasePlatformDescription.
platform/gdk/TemporaryLinkStubs.cpp: Added stub implementation.
platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::releasePlatformDescription): Implemented, though it's never called on this platform.
platform/qt/ContextMenuQt.cpp: (WebCore::ContextMenu::releasePlatformDescription): Ditto.
platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::setSubMenu): Call releasePlatformDescription since we need to take ownership of the HMENU.
platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::releasePlatformDescription): Implemented.

2:40 PM Changeset in webkit [25151] by mjs

11 edits in trunk

LayoutTests:

Reviewed by Darin.

update for fix to <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

No longer expect windowScriptObject delegate method in frames that never
use script.

http/tests/loading/bad-scheme-subframe-expected.txt:
http/tests/loading/bad-server-subframe-expected.txt:
http/tests/loading/empty-subframe-expected.txt:
http/tests/loading/slow-parsing-subframe-expected.txt:

WebCore:

Reviewed by Darin.

fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

There were three main cuases of extra time due to creating the initial empty document:

1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.

The WebCore part of the fixes addresses 2 and 3.

loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Don't parse "<html><body>" for the initial empty document; it turns out not to be needed. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Don't dispatch the delegate if we haven't created a ScriptInterpreter yet.
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded): Dispatch the window object delegate when we first create the interpreter, since that is now done lazily.
loader/FrameLoader.h: (WebCore::FrameLoader::committingFirstRealLoad): Helper for WebKit to know when to reuse a WebHTMLView.

WebKit:

Reviewed by Darin.

fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

There were three main cuases of extra time due to creating the initial empty document:

1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.

The WebKit part of the fixes addresses 1.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): When switching from the initial empty document to the first real document, reuse the WebHTMLView.

It might actually be a significant performance improvement to always
reuse the WebHTMLView, but that is a much riskier change and not
needed to fix the regression right now.

11:26 AM Changeset in webkit [25150] by pewtermoose

3 edits
2 adds in trunk

LayoutTests:

2007-08-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam Roben.

test for http://bugs.webkit.org/show_bug.cgi?id=15008 ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content on image

fast/images/text-content-crash-2-expected.txt: Added.
fast/images/text-content-crash-2.html: Added.

WebCore:

2007-08-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=15008 ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content on image

Test: fast/images/text-content-crash-2.html

html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): Added a check that the renderer is an image. (WebCore::HTMLImageLoader::updateFromElement): Ditto. (WebCore::HTMLImageLoader::notifyFinished): Ditto.

10:10 AM Changeset in webkit [25149] by staikos