Context Navigation

← Previous Period
Next Period →

Timeline

Aug 20, 2007:

6:37 PM Changeset in webkit [25168] by pewtermoose

3 edits
6 adds in trunk

WebCore:

2007-08-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=15023 REGRESSION (r21113-r21143): JavaScript tooltip rendering bug

Test: fast/repaint/layer-visibility.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): Cache the layer's rects when it changes to visible.

LayoutTests:

2007-08-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=15023 REGRESSION (r21113-r21143): JavaScript tooltip rendering bug

fast/repaint/layer-visibility.html: Added.
platform/mac/fast: Added.
platform/mac/fast/repaint: Added.
platform/mac/fast/repaint/layer-visibility-expected.checksum: Added.
platform/mac/fast/repaint/layer-visibility-expected.png: Added.
platform/mac/fast/repaint/layer-visibility-expected.txt: Added.

5:14 PM Changeset in webkit [25167] by aroben

2 edits in trunk/WebKitSite

Remove any mention of drwtsn32.log, as it is almost never useful for tracking down crashes

Reviewed by Oliver.

quality/crashlogs.html:

5:08 PM Changeset in webkit [25166] by kdecker

2 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/5325262> REGRESSION (Tiger-Leopard): PictureTalk plug-in doesn't work

The problem was that this particular plug-in handles "text/ptf", but WebCore wasn't giving the plug-in a chance to load
any type with "text/"

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Allow plug-ins to once again use "text/" MIME types, but only if the MIME type is not "text/plain". Disallowing plug-ins to use text/plain prevents plug-ins from hijacking a fundamental type that the browser is expected to handle, and also serves as an optimization to prevent loading the plug-in database in the common case.

4:46 PM Changeset in webkit [25165] by aroben

2 edits in trunk/LayoutTests

Removed a now-working test from the Windows Skipped file

platform/win/Skipped:

4:36 PM Changeset in webkit [25164] by aroben

2 edits in trunk/WebKitTools

Put LayoutTests after all other ChangeLogs in commit logs

We use "~" to sort LayoutTests after all the other ChangeLogs because
"~" is the last ASCII character (other than "DEL").

Reviewed by Sam.

Scripts/commit-log-editor:

4:18 PM Changeset in webkit [25163] by aroben

2 edits in trunk/WebKitTools

Detect that DRT crashed even if a crash dialog is running

On Windows, when DRT crashes a crash dialog commonly appears. The DRT
process is still running at this point, so run-webkit-tests wouldn't
detect that DRT had crashed. We now record the crash in our SIGPIPE
handler so that we know if DRT crashed even if the crash dialog is up.

Reviewed by Sam.

Scripts/run-webkit-tests: (sub catch_pipe): Set the crashed bit. (sub openDumpTool): Reset the crashed bit. (sub dumpToolDidCrash): Check the crashed bit.

4:04 PM Changeset in webkit [25162] by aroben

3 edits
4 adds in trunk

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

WebCore:

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

Reviewed by Darin.

Tests: fast/loader/local-svg-parsed-as-svg.svg

fast/loader/local-xhtml-parsed-as-xhtml.xhtml

platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Removed hackish workaround.

LayoutTests:

Tests to ensure that local .xhtml and .svg files end up being parsed as XHTML and SVG, respectively

Reviewed by Darin.

fast/loader/local-svg-parsed-as-svg-expected.txt: Added.
fast/loader/local-svg-parsed-as-svg.svg: Added.
fast/loader/local-xhtml-parsed-as-xhtml-expected.txt: Added.
fast/loader/local-xhtml-parsed-as-xhtml.xhtml: Added.

3:05 PM Changeset in webkit [25161] by kmccullo

3 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Geoff and Adam.

Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045)

kjs/object.cpp:

LayoutTests:

Reviewed by Geoff and Adam.

Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045).

fast/js/deep-recursion-test-expected.txt: Added.
fast/js/deep-recursion-test.html: Added.

2:41 PM Changeset in webkit [25160] by aroben

2 edits in trunk/WebKitTools

Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog

http://bugs.webkit.org/show_bug.cgi?id=15026

Reviewed by NOBODY (OOPS!).

Scripts/prepare-ChangeLog: (sub isModifiedStatus): Split out from isModifiedOrAddedStatus. (sub isAddedStatus): Ditto. (sub testListForChangeLog): Added.

1:32 PM Changeset in webkit [25159] by andersca

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5412988>
Crash when visiting http://www.rockonflash.com/blog/?p=58

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Just return if the plugin view hasn't been inserted in the hierarchy yet.

11:10 AM Changeset in webkit [25158] by antti

2 edits in trunk/WebKit

Reviewed by John.

Fix <rdar://problem/5378390>
Crash at Range::startContainer() when creating multiple ToDos on the same line

Null check range.

No layout test, this only happens with ObjC API.

WebView/WebHTMLView.mm: (-[WebHTMLView _expandSelectionToGranularity:]):

6:30 AM Changeset in webkit [25157] by zecke

2 edits in trunk/WebCore

2007-08-20 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Zack.

Do not define svg as ImageMIMEType if we can use ksvg2.

platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):

12:11 AM Changeset in webkit [25156] by mjs

2 edits in trunk/WebKit

Not reviewed, fix for crash on launch bug in last patch.

WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): Remove an assertion, fix code to work right in the face of that condition.

12:04 AM Changeset in webkit [25155] by rwlbuis

3 edits
4 adds in branches/feature-branch

Reviewed by Nikolas.

http://bugs.webkit.org/show_bug.cgi?id=14924
rotated rect with pattern draws incorrectly

Use the bounding box before transformation.

12:01 AM Changeset in webkit [25154] by mjs

6 edits in trunk/LayoutTests

Not reviewed - test case fixes.

fix some test cases where expected results were altered by the last change (I reviewed all the new results.)

fast/events/focusingUnloadedFrame-expected.txt:
http/tests/loading/simple-subframe-expected.txt:
tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:
webarchive/loading/test-loading-archive-expected.txt:

Aug 19, 2007:

5:04 PM Changeset in webkit [25153] by aroben

2 edits in trunk/WebCore

Gtk+ build fix.

platform/gdk/TemporaryLinkStubs.cpp: Removed const.

3:07 PM Changeset in webkit [25152] by aroben

7 edits in trunk/WebCore

Fix <rdar://5395835> REGRESSION (r24527): Context menu for edit fields is missing "Font & Writing Direction"

The problem was that ContextMenuItem::setSubMenu was just copying the
HMENU from the ContextMenu passed in on Windows, but that HMENU was
later getting destroyed when the ContextMenu went out of scope.

I added a new ContextMenu::releasePlatformDescription method that is
used in setSubMenu instead. I think an ultimately better design would
be for setSubMenu to take ownership of the ContextMenu that's passed in
(as should insertItem and appendItem), but I decided to be conservative
and just make the changes needed to fix the bug.

Reviewed by Darin.

No test possible.

platform/ContextMenu.h: Added releasePlatformDescription.
platform/gdk/TemporaryLinkStubs.cpp: Added stub implementation.
platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::releasePlatformDescription): Implemented, though it's never called on this platform.
platform/qt/ContextMenuQt.cpp: (WebCore::ContextMenu::releasePlatformDescription): Ditto.
platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::setSubMenu): Call releasePlatformDescription since we need to take ownership of the HMENU.
platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::releasePlatformDescription): Implemented.

2:40 PM Changeset in webkit [25151] by mjs

11 edits in trunk

LayoutTests:

Reviewed by Darin.

update for fix to <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

No longer expect windowScriptObject delegate method in frames that never
use script.

http/tests/loading/bad-scheme-subframe-expected.txt:
http/tests/loading/bad-server-subframe-expected.txt:
http/tests/loading/empty-subframe-expected.txt:
http/tests/loading/slow-parsing-subframe-expected.txt:

WebCore:

Reviewed by Darin.

fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

There were three main cuases of extra time due to creating the initial empty document:

1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.

The WebCore part of the fixes addresses 2 and 3.

loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Don't parse "<html><body>" for the initial empty document; it turns out not to be needed. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Don't dispatch the delegate if we haven't created a ScriptInterpreter yet.
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded): Dispatch the window object delegate when we first create the interpreter, since that is now done lazily.
loader/FrameLoader.h: (WebCore::FrameLoader::committingFirstRealLoad): Helper for WebKit to know when to reuse a WebHTMLView.

WebKit:

Reviewed by Darin.

fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

There were three main cuases of extra time due to creating the initial empty document:

1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.

The WebKit part of the fixes addresses 1.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): When switching from the initial empty document to the first real document, reuse the WebHTMLView.

It might actually be a significant performance improvement to always
reuse the WebHTMLView, but that is a much riskier change and not
needed to fix the regression right now.

11:26 AM Changeset in webkit [25150] by pewtermoose

3 edits
2 adds in trunk

LayoutTests:

2007-08-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam Roben.

test for http://bugs.webkit.org/show_bug.cgi?id=15008 ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content on image

fast/images/text-content-crash-2-expected.txt: Added.
fast/images/text-content-crash-2.html: Added.

WebCore:

2007-08-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=15008 ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content on image

Test: fast/images/text-content-crash-2.html

html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): Added a check that the renderer is an image. (WebCore::HTMLImageLoader::updateFromElement): Ditto. (WebCore::HTMLImageLoader::notifyFinished): Ditto.

10:10 AM Changeset in webkit [25149] by staikos