⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 21, 2007:

11:33 PM Changeset in webkit [25183] by rwlbuis
  • 10 edits in branches/feature-branch

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12059
SVG colors have two separate parsing paths (one CSS and one SVGColor::setRGBColor)

Reuse the css parser as much as possible in setRGBColor.

6:35 PM Changeset in webkit [25182] by aroben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added a couple more failures.
4:40 PM Changeset in webkit [25181] by aroben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some more failing tests.
3:32 PM Changeset in webkit [25180] by adachan
  • 2 edits in trunk/WebKit/win

Fix <rdar://problem/5416630> Accelerator to open link in window in background opens window in foreground instead
Placing tooltip window at the topmost in z-order brought windows that were opened in the
background to the front. Use HWND_TOP instead.

Reviewed by Adam.


  • WebView.cpp: (WebView::initializeToolTipWindow):
3:08 PM Changeset in webkit [25179] by aroben
  • 3 edits in trunk/WebCore

Build fix for Mac

Keep FrameView::layoutIfNeededRecursive Windows- and Gtk-only for now
(sadly). This will have to wait until we merge ScrollView and FrameView.

Reviewed by NOBODY.

  • page/FrameView.cpp:
  • page/FrameView.h:
2:49 PM Changeset in webkit [25178] by aroben
  • 2 edits in trunk/WebCore

Fix an ASSERT when using Find in Page

Reviewed by Darin.

No test possible.

  • bridge/win/FrameWin.cpp: (WebCore::imageFromSelection): Make sure to update layout before painting so we don't hit an ASSERT in painting code (Frame::selectionImage in FrameMac.mm does this as well).
2:49 PM Changeset in webkit [25177] by aroben
  • 7 edits in trunk

Switch Windows to using FrameView::layoutIfNeededRecursive

WebCore:

Made FrameView::layoutIfNeededRecursive available to all platforms

Currently it's only used on Gtk+ and Windows.

Reviewed by Darin.

  • page/FrameView.cpp: Removed #ifdef.
  • page/FrameView.h: Ditto.

WebKit/win:

Switch Windows to using FrameView::layoutIfNeededRecursive

Reviewed by Darin.

  • WebFrame.cpp: Removed layoutIfNeededRecursive.
  • WebFrame.h: Ditto.
  • WebView.cpp: (WebView::updateBackingStore): Call FrameView::layoutIfNeededRecursive.
2:44 PM Changeset in webkit [25176] by zimmermann
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Allow to pass a filename to dumpOutputImage via debugger.
Make it only available in debug builds and remove the runtime define: DEBUG_OUTPUT_IMAGE.

2:28 PM Changeset in webkit [25175] by zimmermann
  • 195 edits in branches/feature-branch

Reviewed by Oliver.

Large SVG filter rework. Bring it back in a useable state.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5527 (Filters need subregion support)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5579 (WebKit+SVG renders full-filters-example incorrectly)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5976 (filterUnits="userSpaceOnUse" is broken (breaking feTile test case))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12064 (Need function for manual style-resolution for things like gradient stops)

filters-blend-01-b.svg & filters-example-01-b.svg & filters-displace-01-b.svg & filters-diffuse-01-f.svg are fixed now.

In detail:

  • flood-color & flood-opacity have been incorrectly resolved on the <feBlend> parent element!
  • sizing of filter region was truncated in some cases, as the bbox was used to resolve the needed filter region instead of the filter rect
  • add subregion support to all filter primitives (primitiveUnits & filterUnits handled in all cases)
  • WKDisplacmentMap.cikernel incorrectly flipped the y-axis.
  • Correctly specify default values for all filter primitives in ksvg2/svg!
  • Initialize all variables of the SVGFE* classes in platform/graphics/svg/filters.
  • Fix 'flood-color' initial value (was set to the _stop_ color initial value)

-> both initial values were pointing to 'black' though, so it was no visible problem.

  • Parse 'lighting-color' css property, no more hacking in SVGFEDiffuseLighting.

-> Correct it's initial from black to white value fixes SVG lighting filters!

  • Add diffuseConstant support to feDiffuseLighting filter.
  • Centralize manual style resolution (needed for stop-color, flood-color & flood-opacity, lighting-color)
12:12 PM Changeset in webkit [25174] by adele
  • 2 edits in trunk/WebCore

Build fix for release build.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
11:01 AM Changeset in webkit [25173] by spadma
  • 2 edits in S60/trunk/WebKit

2007-08-02 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: ZBUS-744GX5 - No key events for text input
​http://bugs.webkit.org/show_bug.cgi?id=13877

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):
10:59 AM Changeset in webkit [25172] by spadma
  • 3 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin>

DESC: Fast display mode must be turned OFF for widgets
​http://bugs.webkit.org/show_bug.cgi?id=14966

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateChildFrameNamed):
10:57 AM Changeset in webkit [25171] by adele
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/table/max-width-integer-overflow.html

Avoid integer overflows when dealing with maximum widths by
1) using floating point arithmetic when summing or multiplying column max widths
2) capping max widths at INT_MAX / 2

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):

LayoutTests:

Reviewed by Darin.

  • fast/table/max-width-integer-overflow.html: Added.
  • platform/mac/fast/table: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.checksum: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.txt: Added.
9:28 AM Changeset in webkit [25170] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

7:32 AM Changeset in webkit [25169] by sullivan
  • 17 edits
    1 add in trunk

WebCore:

Reviewed by Adam Roben

WebCore part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings


Adele wrote the first version of this patch. No test cases added because I made sure the
layout tests are unaffected. Two additional bug fixes were made in passing, but neither
of them had any effect on any known real-world case, and both were too difficult to write
test cases for to be worthwhile.

  • WebCore.exp: added symbols for these new functions so WebKit can call them


  • WebCore.xcodeproj/project.pbxproj: updated for new file


  • platform/graphics/mac/ColorMac.h: Added. New file to hold the increasing amount of Mac-specific color stuff.


  • platform/graphics/Color.h: removed #if PLATFORM(MAC) code, which is now in ColorMac.h


  • platform/graphics/mac/ColorMac.mm: (WebCore::makeRGBAFromNSColor): new static function to convert an NSColor object to an RGBA32 struct (WebCore::colorFromNSColor): new public function to convert an NSColor object to a WebCore-style Color object (WebCore::focusRingColor): Uses (cached) systemFocusRingColor instead of hardwired values, unless usesTestModeFocusRingColor is true, in which case it uses the old hardwired color (WebCore::usesTestModeFocusRingColor): returns value of global var (WebCore::setUsesTestModeFocusRingColor): sets value of global var (+[WebCoreControlTintObserver controlTintDidChange]): Uses [NSColor keyboardFocusIndicatorColor] to set systemFocusRingColor; don't compile if COLORMATCH_EVERYTHING is set since we don't know what it would take to satisfy this state.
  • bindings/objc/DOMRGBColor.mm: now includes ColorMac.h to account for moved declarations
  • bridge/mac/WebCoreAXObject.mm: ditto


  • page/mac/FrameMac.mm: (WebCore::convertAttributesToUnderlines): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only used to convert the color of an input manager's marked text underline, which is always black


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only called with a grayscale color perhaps containing an alpha value


  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): just updated a comment

WebKit:

Reviewed by Adam Roben


WebKit part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings

  • Misc/WebNSAttributedStringExtras.mm: now includes <WebCore/ColorMac.h> to account for moved declaration
  • WebView/WebFrame.mm: ditto


  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (+[WebView _setUsesTestModeFocusRingColor:]): new SPI, calls through to new WebCore function. This is used by DumpRenderTree to make sure the focus ring color is always the same when performing layout tests, regardless of OS X version. (+[WebView _usesTestModeFocusRingColor]): new SPI, calls through to new WebCore function

WebKitTools:

Reviewed by Adam Roben

  • DumpRenderTree/DumpRenderTree.m: (runTest): call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors in layout tests on Tiger and Leopard

Aug 20, 2007:

6:37 PM Changeset in webkit [25168] by pewtermoose
  • 3 edits
    6 adds in trunk

WebCore:

2007-08-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/repaint/layer-visibility.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): Cache the layer's rects when it changes to visible.

LayoutTests:

2007-08-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/layer-visibility.html: Added.
  • platform/mac/fast: Added.
  • platform/mac/fast/repaint: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.checksum: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.png: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.txt: Added.
5:14 PM Changeset in webkit [25167] by aroben
  • 2 edits in trunk/WebKitSite

Remove any mention of drwtsn32.log, as it is almost never useful for tracking down crashes

Reviewed by Oliver.

  • quality/crashlogs.html:
5:08 PM Changeset in webkit [25166] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/5325262> REGRESSION (Tiger-Leopard): PictureTalk plug-in doesn't work

The problem was that this particular plug-in handles "text/ptf", but WebCore wasn't giving the plug-in a chance to load
any type with "text/"

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Allow plug-ins to once again use "text/" MIME types, but only if the MIME type is not "text/plain". Disallowing plug-ins to use text/plain prevents plug-ins from hijacking a fundamental type that the browser is expected to handle, and also serves as an optimization to prevent loading the plug-in database in the common case.
4:46 PM Changeset in webkit [25165] by aroben
  • 2 edits in trunk/LayoutTests

Removed a now-working test from the Windows Skipped file

  • platform/win/Skipped:
4:36 PM Changeset in webkit [25164] by aroben
  • 2 edits in trunk/WebKitTools

Put LayoutTests after all other ChangeLogs in commit logs

We use "~" to sort LayoutTests after all the other ChangeLogs because
"~" is the last ASCII character (other than "DEL").

Reviewed by Sam.

  • Scripts/commit-log-editor:
4:18 PM Changeset in webkit [25163] by aroben
  • 2 edits in trunk/WebKitTools

Detect that DRT crashed even if a crash dialog is running

On Windows, when DRT crashes a crash dialog commonly appears. The DRT
process is still running at this point, so run-webkit-tests wouldn't
detect that DRT had crashed. We now record the crash in our SIGPIPE
handler so that we know if DRT crashed even if the crash dialog is up.

Reviewed by Sam.

  • Scripts/run-webkit-tests: (sub catch_pipe): Set the crashed bit. (sub openDumpTool): Reset the crashed bit. (sub dumpToolDidCrash): Check the crashed bit.
4:04 PM Changeset in webkit [25162] by aroben
  • 3 edits
    4 adds in trunk

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

WebCore:

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

Reviewed by Darin.

Tests: fast/loader/local-svg-parsed-as-svg.svg

fast/loader/local-xhtml-parsed-as-xhtml.xhtml

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Removed hackish workaround.

LayoutTests:

Tests to ensure that local .xhtml and .svg files end up being parsed as XHTML and SVG, respectively

Reviewed by Darin.

  • fast/loader/local-svg-parsed-as-svg-expected.txt: Added.
  • fast/loader/local-svg-parsed-as-svg.svg: Added.
  • fast/loader/local-xhtml-parsed-as-xhtml-expected.txt: Added.
  • fast/loader/local-xhtml-parsed-as-xhtml.xhtml: Added.
3:05 PM Changeset in webkit [25161] by kmccullo
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff and Adam.

  • Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045)
  • kjs/object.cpp:

LayoutTests:

Reviewed by Geoff and Adam.

  • Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045).
  • fast/js/deep-recursion-test-expected.txt: Added.
  • fast/js/deep-recursion-test.html: Added.
2:41 PM Changeset in webkit [25160] by aroben
  • 2 edits in trunk/WebKitTools

Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog

​http://bugs.webkit.org/show_bug.cgi?id=15026

Reviewed by NOBODY (OOPS!).

  • Scripts/prepare-ChangeLog: (sub isModifiedStatus): Split out from isModifiedOrAddedStatus. (sub isAddedStatus): Ditto. (sub testListForChangeLog): Added.
1:32 PM Changeset in webkit [25159] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5412988>
Crash when visiting ​http://www.rockonflash.com/blog/?p=58


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Just return if the plugin view hasn't been inserted in the hierarchy yet.
11:10 AM Changeset in webkit [25158] by antti
  • 2 edits in trunk/WebKit

Reviewed by John.


Fix <rdar://problem/5378390>
Crash at Range::startContainer() when creating multiple ToDos on the same line


Null check range.


No layout test, this only happens with ObjC API.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _expandSelectionToGranularity:]):
6:30 AM Changeset in webkit [25157] by zecke
  • 2 edits in trunk/WebCore

2007-08-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Zack.

Do not define svg as ImageMIMEType if we can use ksvg2.

  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
12:11 AM Changeset in webkit [25156] by mjs
  • 2 edits in trunk/WebKit

Not reviewed, fix for crash on launch bug in last patch.

  • WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): Remove an assertion, fix code to work right in the face of that condition.
12:04 AM Changeset in webkit [25155] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=14924
rotated rect with pattern draws incorrectly

Use the bounding box before transformation.

12:01 AM Changeset in webkit [25154] by mjs
  • 6 edits in trunk/LayoutTests

Not reviewed - test case fixes.


  • fix some test cases where expected results were altered by the last change (I reviewed all the new results.)
  • fast/events/focusingUnloadedFrame-expected.txt:
  • http/tests/loading/simple-subframe-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
Note: See TracTimeline for information about the timeline view.