⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 22, 2007:

10:02 PM Changeset in webkit [25196] by oliver
  • 2 edits in trunk/WebKitTools

Reviewed by John and Adam.


WebDataSource::response can legitimately have a null response, so we
must check that case.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump):
5:31 PM Changeset in webkit [25195] by honeycutt
  • 4 edits in trunk/WebKit/win

2007-08-22 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Refactoring of <radr://problem/5220598> Dragging URL out and back
inserts a second copy of the URL

  • Interfaces/IWebViewPrivate.idl: Added setCustomDropTarget and removeCustomDropTarget
  • WebView.cpp: (WebView::WebView): Initialize m_hasCustomDropTarget (WebView::setCustomDropTarget): Revoke any existing drop target and set the incoming drop target. (WebView::removeCustomDropTarget): Revoke any existing drop target and set the default drop target.
  • WebView.h:
5:22 PM Changeset in webkit [25194] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin and Oliver.

<rdar://problem/5422410>
​http://bugs.webkit.org/show_bug.cgi?id=15019
REGRESSION (r25124-r25140): New posts and hot topics won't show at mobile01.com

Remove the call to checkCallImplicitClose(). Calling it in loadPlugin is bad for two reasons:


  1. It could cause onload to be dispatched even when the page has subresources that are still loading, such as images.


  1. Now that loadPlugin is called during layout, it could cause onload to be dispatched during layout, which can execute javascript and do pretty much anything while the render tree is in an inconsistent state.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):
4:56 PM Changeset in webkit [25193] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5430584>
​http://bugs.webkit.org/show_bug.cgi?id=15053
WebKit does not check Windows Registry HKEY_CURRENT_USER for NPAPI plugin locations


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginsFromRegistry): (WebCore::PluginDatabaseWin::getPluginsInPaths):
2:56 PM Changeset in webkit [25192] by justing
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Adam.


<rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): We're reusing the topBlockquote variable. Null it out first. If there is no new topBlockquote and we don't null it out first, we'll assume that there was a new one and crash.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]

  • editing/inserting/5418891.html: Added.
  • platform/mac/editing/inserting: Added.
  • platform/mac/editing/inserting/5418891-expected.checksum: Added.
  • platform/mac/editing/inserting/5418891-expected.png: Added.
  • platform/mac/editing/inserting/5418891-expected.txt: Added.
2:23 PM Changeset in webkit [25191] by thatcher
  • 12 edits in trunk/WebKit

Rolling out r25102 for <rdar://problem/5410937> until
<rdar://problem/5429920> is resolved.

  • Carbon/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
  • Carbon/CarbonWindowAdapter.h:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.h:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.h:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.h:
  • Carbon/HIViewAdapter.m:
  • Carbon/HIWebView.h:
  • Carbon/HIWebView.m:
1:38 PM Changeset in webkit [25190] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

malaiya, reviewed by <​zbujtas@gmail.com>

DESC: TSW Id: ESMS-766JBW - Browser goes back in history when leaving input field
​http://bugs.webkit.org/show_bug.cgi?id=15050

1:36 PM Changeset in webkit [25189] by zbujtas
  • 2 edits in S60/trunk/WebCore

malaiya, reviewed by <​zbujtas@gmail.com>

DESC: TSW Id: ESMS-766JBW - Browser goes back in history when leaving input field
​http://bugs.webkit.org/show_bug.cgi?id=15050

1:10 PM Changeset in webkit [25188] by kmccullo
  • 5 edits in trunk

LayoutTests:

Reviewed by Adele.

  • rdar:5423067 Reapplying the change but only when the text area is in focus.
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

Reviewed by Adele.

  • rdar:5423067 Reapplyingthe change but only when the text area is in focus.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
12:58 PM Changeset in webkit [25187] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5249757> Painting of JPGs in WebKit is too slow.

Use a new Leopard API for fast tiling of images. We only use this API
when the whole image is being tiled and when the current CGImageRef to tile
has a size that matches the size of the whole image.

We can optimize border-image in the future by adding a cache of the 9
sub-images.

Reviewed by darin

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
11:12 AM Changeset in webkit [25186] by kmccullo
  • 5 edits in trunk

LayoutTests:

  • Rolling back since I neeed to update some layouttests this change broke.
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

  • Rolling back since I need to update some layouttests this change breaks.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
10:43 AM Changeset in webkit [25185] by kmccullo
  • 5 edits in trunk

LayoutTests:

Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.

  • In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
  • <rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.

  • In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
  • <rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
10:40 AM Changeset in webkit [25184] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by Geof.

  • Changing the usage to be more clear.
  • Scripts/run-testkjs:

Aug 21, 2007:

11:33 PM Changeset in webkit [25183] by rwlbuis
  • 10 edits in branches/feature-branch

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12059
SVG colors have two separate parsing paths (one CSS and one SVGColor::setRGBColor)

Reuse the css parser as much as possible in setRGBColor.

6:35 PM Changeset in webkit [25182] by aroben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added a couple more failures.
4:40 PM Changeset in webkit [25181] by aroben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some more failing tests.
3:32 PM Changeset in webkit [25180] by adachan
  • 2 edits in trunk/WebKit/win

Fix <rdar://problem/5416630> Accelerator to open link in window in background opens window in foreground instead
Placing tooltip window at the topmost in z-order brought windows that were opened in the
background to the front. Use HWND_TOP instead.

Reviewed by Adam.


  • WebView.cpp: (WebView::initializeToolTipWindow):
3:08 PM Changeset in webkit [25179] by aroben
  • 3 edits in trunk/WebCore

Build fix for Mac

Keep FrameView::layoutIfNeededRecursive Windows- and Gtk-only for now
(sadly). This will have to wait until we merge ScrollView and FrameView.

Reviewed by NOBODY.

  • page/FrameView.cpp:
  • page/FrameView.h:
2:49 PM Changeset in webkit [25178] by aroben
  • 2 edits in trunk/WebCore

Fix an ASSERT when using Find in Page

Reviewed by Darin.

No test possible.

  • bridge/win/FrameWin.cpp: (WebCore::imageFromSelection): Make sure to update layout before painting so we don't hit an ASSERT in painting code (Frame::selectionImage in FrameMac.mm does this as well).
2:49 PM Changeset in webkit [25177] by aroben
  • 7 edits in trunk

Switch Windows to using FrameView::layoutIfNeededRecursive

WebCore:

Made FrameView::layoutIfNeededRecursive available to all platforms

Currently it's only used on Gtk+ and Windows.

Reviewed by Darin.

  • page/FrameView.cpp: Removed #ifdef.
  • page/FrameView.h: Ditto.

WebKit/win:

Switch Windows to using FrameView::layoutIfNeededRecursive

Reviewed by Darin.

  • WebFrame.cpp: Removed layoutIfNeededRecursive.
  • WebFrame.h: Ditto.
  • WebView.cpp: (WebView::updateBackingStore): Call FrameView::layoutIfNeededRecursive.
2:44 PM Changeset in webkit [25176] by zimmermann
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Allow to pass a filename to dumpOutputImage via debugger.
Make it only available in debug builds and remove the runtime define: DEBUG_OUTPUT_IMAGE.

2:28 PM Changeset in webkit [25175] by zimmermann
  • 195 edits in branches/feature-branch

Reviewed by Oliver.

Large SVG filter rework. Bring it back in a useable state.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5527 (Filters need subregion support)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5579 (WebKit+SVG renders full-filters-example incorrectly)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5976 (filterUnits="userSpaceOnUse" is broken (breaking feTile test case))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12064 (Need function for manual style-resolution for things like gradient stops)

filters-blend-01-b.svg & filters-example-01-b.svg & filters-displace-01-b.svg & filters-diffuse-01-f.svg are fixed now.

In detail:

  • flood-color & flood-opacity have been incorrectly resolved on the <feBlend> parent element!
  • sizing of filter region was truncated in some cases, as the bbox was used to resolve the needed filter region instead of the filter rect
  • add subregion support to all filter primitives (primitiveUnits & filterUnits handled in all cases)
  • WKDisplacmentMap.cikernel incorrectly flipped the y-axis.
  • Correctly specify default values for all filter primitives in ksvg2/svg!
  • Initialize all variables of the SVGFE* classes in platform/graphics/svg/filters.
  • Fix 'flood-color' initial value (was set to the _stop_ color initial value)

-> both initial values were pointing to 'black' though, so it was no visible problem.

  • Parse 'lighting-color' css property, no more hacking in SVGFEDiffuseLighting.

-> Correct it's initial from black to white value fixes SVG lighting filters!

  • Add diffuseConstant support to feDiffuseLighting filter.
  • Centralize manual style resolution (needed for stop-color, flood-color & flood-opacity, lighting-color)
12:12 PM Changeset in webkit [25174] by adele
  • 2 edits in trunk/WebCore

Build fix for release build.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
11:01 AM Changeset in webkit [25173] by spadma
  • 2 edits in S60/trunk/WebKit

2007-08-02 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: ZBUS-744GX5 - No key events for text input
​http://bugs.webkit.org/show_bug.cgi?id=13877

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):
10:59 AM Changeset in webkit [25172] by spadma
  • 3 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin>

DESC: Fast display mode must be turned OFF for widgets
​http://bugs.webkit.org/show_bug.cgi?id=14966

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateChildFrameNamed):
10:57 AM Changeset in webkit [25171] by adele
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/table/max-width-integer-overflow.html

Avoid integer overflows when dealing with maximum widths by
1) using floating point arithmetic when summing or multiplying column max widths
2) capping max widths at INT_MAX / 2

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):

LayoutTests:

Reviewed by Darin.

  • fast/table/max-width-integer-overflow.html: Added.
  • platform/mac/fast/table: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.checksum: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.txt: Added.
9:28 AM Changeset in webkit [25170] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

7:32 AM Changeset in webkit [25169] by sullivan
  • 17 edits
    1 add in trunk

WebCore:

Reviewed by Adam Roben

WebCore part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings


Adele wrote the first version of this patch. No test cases added because I made sure the
layout tests are unaffected. Two additional bug fixes were made in passing, but neither
of them had any effect on any known real-world case, and both were too difficult to write
test cases for to be worthwhile.

  • WebCore.exp: added symbols for these new functions so WebKit can call them


  • WebCore.xcodeproj/project.pbxproj: updated for new file


  • platform/graphics/mac/ColorMac.h: Added. New file to hold the increasing amount of Mac-specific color stuff.


  • platform/graphics/Color.h: removed #if PLATFORM(MAC) code, which is now in ColorMac.h


  • platform/graphics/mac/ColorMac.mm: (WebCore::makeRGBAFromNSColor): new static function to convert an NSColor object to an RGBA32 struct (WebCore::colorFromNSColor): new public function to convert an NSColor object to a WebCore-style Color object (WebCore::focusRingColor): Uses (cached) systemFocusRingColor instead of hardwired values, unless usesTestModeFocusRingColor is true, in which case it uses the old hardwired color (WebCore::usesTestModeFocusRingColor): returns value of global var (WebCore::setUsesTestModeFocusRingColor): sets value of global var (+[WebCoreControlTintObserver controlTintDidChange]): Uses [NSColor keyboardFocusIndicatorColor] to set systemFocusRingColor; don't compile if COLORMATCH_EVERYTHING is set since we don't know what it would take to satisfy this state.
  • bindings/objc/DOMRGBColor.mm: now includes ColorMac.h to account for moved declarations
  • bridge/mac/WebCoreAXObject.mm: ditto


  • page/mac/FrameMac.mm: (WebCore::convertAttributesToUnderlines): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only used to convert the color of an input manager's marked text underline, which is always black


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only called with a grayscale color perhaps containing an alpha value


  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): just updated a comment

WebKit:

Reviewed by Adam Roben


WebKit part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings

  • Misc/WebNSAttributedStringExtras.mm: now includes <WebCore/ColorMac.h> to account for moved declaration
  • WebView/WebFrame.mm: ditto


  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (+[WebView _setUsesTestModeFocusRingColor:]): new SPI, calls through to new WebCore function. This is used by DumpRenderTree to make sure the focus ring color is always the same when performing layout tests, regardless of OS X version. (+[WebView _usesTestModeFocusRingColor]): new SPI, calls through to new WebCore function

WebKitTools:

Reviewed by Adam Roben

  • DumpRenderTree/DumpRenderTree.m: (runTest): call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors in layout tests on Tiger and Leopard
Note: See TracTimeline for information about the timeline view.