⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 23, 2007:

5:41 PM Changeset in webkit [25212] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Dave Hyatt.

<rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

The Carbon HIWebView was relying on layout happening when displayIfNeededInRect: was called on the WebView.
This would happen on Tiger because _recursiveDisplayRectIfNeededIgnoringOpacity: would always do a layout if needed.
Doing a layout in _recursiveDisplayRectIfNeededIgnoringOpacity was removed in Leopard in favor of viewWillDraw, and
the fact that adding new dirty rects inside _recursiveDisplayRectIfNeededIgnoringOpacity on Leopard will not
cause a drawRect in the same display loop.

So any client on Leopard calling displayIfNeeded* on the WebView would get a layout and any new dirty rects. So
_web_layoutIfNeededRecursive needs to be called on the main frame's WebHTMLView to make sure we layout and
display anything that is really needed.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _layoutIfNeeded]): (-[WebHTMLView _web_layoutIfNeededRecursive]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebView displayIfNeeded]): Call _web_layoutIfNeededRecursive on the main WebHTMLView. (-[WebView displayIfNeededIgnoringOpacity]): Ditto. (-[WebView displayIfNeededInRect:]): Ditto. (-[WebView displayIfNeededInRectIgnoringOpacity:]): Ditto.
4:31 PM Changeset in webkit [25211] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by .

  • window-resize.html now passes.
  • platform/win/Skipped:
3:41 PM Changeset in webkit [25210] by sfalken
  • 1 copy in tags/Safari-523.1.2b

New tag.

3:41 PM Changeset in webkit [25209] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

2:25 PM Changeset in webkit [25208] by weinig
  • 14 edits in trunk

Make life on Windows a little better by adding generated VS files to svn:ignore list

1:18 PM Changeset in webkit [25207] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Steve.

If necessary, re-set the window proc after each call to NPP_SetWindow. This is to ensure that
our window proc is always run even if a plug-in subclasses the window and replaces the window proc.


Also, make sure that the default window proc is of type ASCII so we can eliminate the

  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::pluginWndProc):
1:13 PM Changeset in webkit [25206] by ddkilzer
  • 6 edits
    5 adds in trunk

WebCore:

Updated old ChangeLog entry with bug title and test information.

WebKitTools:

Reviewed by Darin and Adam.

Use a frame group name for all WebViews created by DumpRenderTree to
allow testing of cross-page frame lookup.

  • DumpRenderTree/DumpRenderTree.m: (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).

LayoutTests:

Reviewed by Adam.

  • http/tests/navigation/resources/target-frame-from-window-end.html: Added.
  • http/tests/navigation/resources/target-frame-from-window-popup.html: Added.
  • http/tests/navigation/resources/target-frame-from-window-start.html: Added.
  • http/tests/navigation/target-frame-from-window-expected.txt: Added.
  • http/tests/navigation/target-frame-from-window.html: Added.
  • platform/win/Skipped: Added http/tests/navigation/target-frame-from-window.html to skip list.
12:14 PM Changeset in webkit [25205] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-08-23 w3liu <​wei.liu@nokia.com>

Reviewed by <​sriram.yadavalli@nokia.com>.
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly (extra fix to handle js disable)
​http://bugs.webkit.org/show_bug.cgi?id=15049

12:09 PM Changeset in webkit [25204] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-08-23 w3liu <​wei.liu@nokia.com>

Reviewed by <​sriram.yadavalli@nokia.com>.
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly (extra fix to handle js disable)
​http://bugs.webkit.org/show_bug.cgi?id=15049

11:11 AM Changeset in webkit [25203] by justing
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Adele.

<rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for node. If the node to be removed contains the selection, and if the next node to be removed (nextNode) is inside the deletion UI, removing node will remove nextNode from the document. nextNode is a RefPtr, but node isn't and when nextNode falls out of scope the node that node points to will be destroyed and we'll end up using a stale pointer. Long term we should probably just disable the deletion UI before editing operations because the undo of the removal of node in the situation described above relies on the presence of the deletion UI, but it isn't present because its added and removed in a non-undoable way.

LayoutTests:

Reviewed by Adele.


<rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content

  • editing/deleting/5156801-2.html: Added.
  • platform/mac/editing/deleting: Added.
  • platform/mac/editing/deleting/5156801-2-expected.checksum: Added.
  • platform/mac/editing/deleting/5156801-2-expected.png: Added.
  • platform/mac/editing/deleting/5156801-2-expected.txt: Added.
10:20 AM Changeset in webkit [25202] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Quote the $sslCertificate path in case it contains a space.

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
9:47 AM Changeset in webkit [25201] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-08-22 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin.
DESC: TSW ID: SJUN-73XBVC. Text appears overlapped with document.write in onload
​http://bugs.webkit.org/show_bug.cgi?id=14915


  • BrowserView/src/WebKitView.cpp: (CWebKitView::SyncRepaint):
9:46 AM Changeset in webkit [25200] by spadma
  • 2 edits in S60/trunk/WebKit

rathnasa, reviewed by spadma

DESC: TSW ID: SJUN-73XBVC. Text appears overlapped with document.write in onload
​http://bugs.webkit.org/show_bug.cgi?id=14915


  • BrowserView/src/WebKitView.cpp: (CWebKitView::SyncRepaint):


5:37 AM Changeset in webkit [25199] by zbujtas
  • 4 edits in S60/trunk/WebCore

2007-08-22 w3liu <​wei.liu@nokia.com>

Reviewed by <​sriram.yadavalli@nokia.com>
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly

5:34 AM Changeset in webkit [25198] by zbujtas
  • 4 edits in S60/branches/3.1m/WebCore

2007-08-22 w3liu <​wei.liu@nokia.com>

Reviewed by <​sriram.yadavalli@nokia.com>
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly

12:44 AM Changeset in webkit [25197] by andrew
  • 4 edits
    1 add in trunk/WebCore

2007-08-23 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

WebKit copies the width and height attributes of an <embed> to its
nearest <object> ancestor. This used to be done in updateWidget(), but
that could lead to the document being dirty right after layout and
before painting. The patch moves the copying of the attributes to when
the <embed> is inserted into the document or its attributes change.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::attributeChanged):
  • html/HTMLEmbedElement.h:
  • manual-tests/bugzilla-14899.html: Added.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):

Aug 22, 2007:

10:02 PM Changeset in webkit [25196] by oliver
  • 2 edits in trunk/WebKitTools

Reviewed by John and Adam.


WebDataSource::response can legitimately have a null response, so we
must check that case.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump):
5:31 PM Changeset in webkit [25195] by honeycutt
  • 4 edits in trunk/WebKit/win

2007-08-22 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Refactoring of <radr://problem/5220598> Dragging URL out and back
inserts a second copy of the URL

  • Interfaces/IWebViewPrivate.idl: Added setCustomDropTarget and removeCustomDropTarget
  • WebView.cpp: (WebView::WebView): Initialize m_hasCustomDropTarget (WebView::setCustomDropTarget): Revoke any existing drop target and set the incoming drop target. (WebView::removeCustomDropTarget): Revoke any existing drop target and set the default drop target.
  • WebView.h:
5:22 PM Changeset in webkit [25194] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin and Oliver.

<rdar://problem/5422410>
​http://bugs.webkit.org/show_bug.cgi?id=15019
REGRESSION (r25124-r25140): New posts and hot topics won't show at mobile01.com

Remove the call to checkCallImplicitClose(). Calling it in loadPlugin is bad for two reasons:


  1. It could cause onload to be dispatched even when the page has subresources that are still loading, such as images.


  1. Now that loadPlugin is called during layout, it could cause onload to be dispatched during layout, which can execute javascript and do pretty much anything while the render tree is in an inconsistent state.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):
4:56 PM Changeset in webkit [25193] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5430584>
​http://bugs.webkit.org/show_bug.cgi?id=15053
WebKit does not check Windows Registry HKEY_CURRENT_USER for NPAPI plugin locations


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginsFromRegistry): (WebCore::PluginDatabaseWin::getPluginsInPaths):
2:56 PM Changeset in webkit [25192] by justing
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Adam.


<rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): We're reusing the topBlockquote variable. Null it out first. If there is no new topBlockquote and we don't null it out first, we'll assume that there was a new one and crash.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]

  • editing/inserting/5418891.html: Added.
  • platform/mac/editing/inserting: Added.
  • platform/mac/editing/inserting/5418891-expected.checksum: Added.
  • platform/mac/editing/inserting/5418891-expected.png: Added.
  • platform/mac/editing/inserting/5418891-expected.txt: Added.
2:23 PM Changeset in webkit [25191] by thatcher
  • 12 edits in trunk/WebKit

Rolling out r25102 for <rdar://problem/5410937> until
<rdar://problem/5429920> is resolved.

  • Carbon/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
  • Carbon/CarbonWindowAdapter.h:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.h:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.h:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.h:
  • Carbon/HIViewAdapter.m:
  • Carbon/HIWebView.h:
  • Carbon/HIWebView.m:
1:38 PM Changeset in webkit [25190] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

malaiya, reviewed by <​zbujtas@gmail.com>

DESC: TSW Id: ESMS-766JBW - Browser goes back in history when leaving input field
​http://bugs.webkit.org/show_bug.cgi?id=15050

1:36 PM Changeset in webkit [25189] by zbujtas
  • 2 edits in S60/trunk/WebCore

malaiya, reviewed by <​zbujtas@gmail.com>

DESC: TSW Id: ESMS-766JBW - Browser goes back in history when leaving input field
​http://bugs.webkit.org/show_bug.cgi?id=15050

1:10 PM Changeset in webkit [25188] by kmccullo
  • 5 edits in trunk

LayoutTests:

Reviewed by Adele.

  • rdar:5423067 Reapplying the change but only when the text area is in focus.
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

Reviewed by Adele.

  • rdar:5423067 Reapplyingthe change but only when the text area is in focus.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
12:58 PM Changeset in webkit [25187] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5249757> Painting of JPGs in WebKit is too slow.

Use a new Leopard API for fast tiling of images. We only use this API
when the whole image is being tiled and when the current CGImageRef to tile
has a size that matches the size of the whole image.

We can optimize border-image in the future by adding a cache of the 9
sub-images.

Reviewed by darin

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
11:12 AM Changeset in webkit [25186] by kmccullo
  • 5 edits in trunk

LayoutTests:

  • Rolling back since I neeed to update some layouttests this change broke.
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

  • Rolling back since I need to update some layouttests this change breaks.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
10:43 AM Changeset in webkit [25185] by kmccullo
  • 5 edits in trunk

LayoutTests:

Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.

  • In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
  • <rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.

  • In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
  • <rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
10:40 AM Changeset in webkit [25184] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by Geof.

  • Changing the usage to be more clear.
  • Scripts/run-testkjs:
Note: See TracTimeline for information about the timeline view.