⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 26, 2007:

11:40 PM Changeset in webkit [25258] by darin
  • 2 edits in trunk/JavaScriptCore
  • quick follow on to that last check-in
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): Need to initialize m_class to 0.
11:17 PM Changeset in webkit [25257] by bdash
  • 5 edits in trunk/JavaScriptCore

2007-08-26 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/4949002> JSGlobalContextCreate can cause crashes because it passes a NULL JSContextRef to the globalObjectClass's initialize callback

JSCallbackObject now tracks whether it was constructed with a null ExecState. This will happen when the object is being used as the global object,
as the Interpreter needs to be created after the global object. In this situation the initialization is deferred until after the Interpreter's
ExecState is available to be passed down to the initialize callbacks.

  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): Track whether we successfully initialized. (KJS::JSCallbackObject::initializeIfNeeded): Attempt to initialize with the new ExecState.
  • API/JSCallbackObject.h:
  • API/JSContextRef.cpp: (JSGlobalContextCreate): Initialize the JSCallbackObject with the Interpreter's ExecState.
  • API/testapi.c: (testInitializeOfGlobalObjectClassHasNonNullContext): (main): Verify that the context passed to the initialize callback is non-null.
11:02 PM Changeset in webkit [25256] by bdash
  • 3 edits in trunk/JavaScriptCore

2007-08-26 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5438496> JSGlobalContextCreate crashes when passed a custom class

  • API/JSContextRef.cpp: (JSGlobalContextCreate): Specify jsNull() as the prototype and let Interpreter's constructor fix it up to point at builtinObjectPrototype().
  • API/testapi.c: (main): Use an instance of a custom class as the global object to ensure the code path is exercised in the test.
5:11 PM Changeset in webkit [25255] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.


Fix for <rdar://problem/5433726>
Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (​http://www.yahoo.com/)

Test: editing/style/temporary-span-crash.html

  • page/Frame.cpp: (WebCore::Frame::styleForSelectionStart): Temporary span created here might not have renderer if document has style sheet that makes it display:none. Set display:inline explicitly in spans style attribute. This temporary span does not need to get its display value from actual document style sheets. Null check the renderer too to be sure.

LayoutTests:

Reviewed by Darin.


Test for <rdar://problem/5433726>
Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (​http://www.yahoo.com/)

  • editing/style/temporary-span-crash-expected.txt: Added.
  • editing/style/temporary-span-crash.html: Added.
6:39 AM Changeset in webkit [25254] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Mark Rowe.

Update prepare-ChangeLog to generate the datestamp in the correct timezone.

  • Scripts/prepare-ChangeLog: (changeLogDate): Added.
6:20 AM Changeset in webkit [25253] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Mark Rowe and David Kilzer.

Fix build failure on arm.

  • wtf/Platform.h: Also test if arm is defined.
5:46 AM Changeset in webkit [25252] by zimmermann
  • 1 edit
    5 adds in branches/feature-branch/LayoutTests

Rubberstamped by Mark.
Add missing SVG filter testcase (forgot to include in last commit).

Aug 25, 2007:

7:16 PM Changeset in webkit [25251] by oliver
  • 2 edits in trunk/WebKit/win

Reviewed by Adam and Sam


<rdar://problem/5269732> Safari 3.0 for Windows cuts off text in textarea boxes during sending forms (14562)
<​http://bugs.webkit.org/show_bug.cgi?id=14562> [Win] Textarea contents partially eaten on submit/copy


WebView::handleEditingKeyboardEvent assumed all keycodes that did not trigger a named command were
to be inserted. This could cause unexpected behaviour when control characters (eg. escape) are sent,
or could cause data loss when sent a null character (as happens when dead keys are used for international
input).


This patch corrects WebView::handleEditingKeyboardEvent to prevent such characters from being sent
to Editor::insertText. This behaviour matches Firefox.

  • WebView.cpp: (WebView::handleEditingKeyboardEvent):
1:42 PM Changeset in webkit [25250] by ddkilzer
  • 2 edits in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (fixes layout tests).

Don't pass any options to window.open() in target-frame-from-window.html, specifically
those that cause the window to be resized. This caused a downstream failure in
cross-frame-access-put.html because the window.outerHeight and window.outerWidth
properties were sometimes affected by the new window size used in the popup window.

  • http/tests/navigation/target-frame-from-window.html:
12:08 PM Changeset in webkit [25249] by weinig
  • 4 edits
    16 adds in trunk

WebCore:

Reviewed by Adele.

Fix for <rdar://problem/5426142>

Use the EventTarget's frame when creating the EventListener.

Tests: http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html

http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html
http/tests/security/listener/xss-window-onclick-addEventListener.html
http/tests/security/listener/xss-window-onclick-shortcut.html

  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):

LayoutTests:

Reviewed by Adele.

Tests for <rdar://problem/5426142>

  • http/tests/security/listener: Added.
  • http/tests/security/listener/resources: Added.
  • http/tests/security/listener/resources/childWindow.html: Added.
  • http/tests/security/listener/resources/childWithButton.html: Added.
  • http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-shortcut.html: Added.
  • http/tests/security/listener/resources/targetChild-window-onclick-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-window-onclick-shortcut.html: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html: Added.
  • http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-window-onclick-addEventListener.html: Added.
  • http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-window-onclick-shortcut.html: Added.
12:02 PM Changeset in webkit [25248] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

  • manual-tests/drag-out-of-background-window.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): Added missing coordinate conversion.
11:12 AM Changeset in webkit [25247] by bdash
  • 1 copy in tags/Safari-4523.2

New tag.

9:57 AM Changeset in webkit [25246] by rwlbuis
  • 3 edits
    8 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14848
DOM table rules are not updated when changed

On a dynamic rules attr change, mark the table cells and
their ancestors (up to and including the table tag) as
changed.

9:35 AM Changeset in webkit [25245] by adele
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15073
<rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas


Test: fast/forms/drag-out-of-textarea.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint): Only restricts hit testing if the placeholder text is visible.
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::placeholderIsVisible): Added.

LayoutTests:

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=15073
<rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas

  • fast/forms/drag-out-of-textarea-expected.txt: Added.
  • fast/forms/drag-out-of-textarea.html: Added.
9:08 AM Changeset in webkit [25244] by bdash
  • 21 edits
    2 deletes in tags/Safari-5523.2

Roll out r25128 to prevent <rdar://5424866>.

8:49 AM Changeset in webkit [25243] by bdash
  • 4 edits in trunk

Versioning.

8:48 AM Changeset in webkit [25242] by bdash
  • 1 copy in tags/Safari-5523.2

New tag.

7:03 AM Changeset in webkit [25241] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Maciej Stachowiak.

Part 3 of ​http://bugs.webkit.org/show_bug.cgi?id=14967
Bug 14967: Reduce wtf::Vector::operator[]() overloads

  • wtf/Vector.h: (WTF::Vector::operator[]): Only provide versions of operator[] that takes a size_t argument.
7:00 AM Changeset in webkit [25240] by bdash
  • 7 edits in trunk

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Sam Weinig.

Part 2 of ​http://bugs.webkit.org/show_bug.cgi?id=14967.
Eliminate all remaining implicit conversions of wtf::Vector<T> to T*. Where code was
previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
instead.

  • wtf/Vector.h: (WTF::Vector::data):

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Sam Weinig.

Part 2 of ​http://bugs.webkit.org/show_bug.cgi?id=14967.
Eliminate all remaining implicit conversions of wtf::Vector<T> to T*. Where code was
previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
instead.

  • bindings/js/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary):
  • loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType):
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): (WebCore::FrameView::dispatchScheduledEvents):
  • platform/mac/PlugInInfoStoreMac.mm: (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
5:58 AM Changeset in webkit [25239] by bdash
  • 1 edit
    1 move in trunk/LayoutTests

2007-08-25 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Mitz.

Disable fast/js/string-concatenate-outofmemory.html until <​http://bugs.webkit.org/show_bug.cgi?id=15046> is resolved.

  • fast/js/string-concatenate-outofmemory.html: Removed.
  • fast/js/string-concatenate-outofmemory.html-disabled: Copied from LayoutTests/fast/js/string-concatenate-outofmemory.html.
5:37 AM Changeset in webkit [25238] by bdash
  • 1 edit
    1 delete in trunk/WebCore

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Rubber-stamped by Adam Roben

  • remove unused file
  • platform/win/MouseEventWin.cpp: Removed.
5:35 AM Changeset in webkit [25237] by bdash
  • 2 edits in trunk/WebCore

2007-08-25 Jasper Bryant-Greene <​m@ni.ac.nz>

Reviewed by Oliver Hunt.

Set paintingDisabled to true in Cairo's GraphicsContext constructor
when passed a null PlatformGraphicsContext.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext):
5:30 AM Changeset in webkit [25236] by bdash
  • 6 edits in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Covered by fast/parser/residual-style-close-across-n-blocks.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): If the residual style was closed before anything else in the block (so it does not apply to anything inside the block) avoid creating an empty element for it inside the block.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/parser/residual-style-close-across-n-blocks-expected.txt:
  • fast/parser/residual-style-close-across-n-blocks.html:
  • tables/mozilla/other/wa_table_tr_align-expected.txt:
5:26 AM Changeset in webkit [25235] by bdash
  • 3 edits
    2 adds in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: editing/selection/move-by-line-003.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed hit testing so that each line is tested for hits between its overflow top and the next line's overflow top. This matches RenderBlock::positionForCoordinates.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • editing/selection/move-by-line-003-expected.txt: Added.
  • editing/selection/move-by-line-003.html: Added.
5:21 AM Changeset in webkit [25234] by bdash
  • 13 edits
    2 adds in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Justin.

Test: editing/pasteboard/newlines-around-floating-or-positioned.html

  • editing/TextIterator.cpp: (WebCore::shouldEmitNewlinesBeforeAndAfterNode): Do not emit newlines around floating or positioned blocks. This behavior seems to match WinIE's.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Justin.

  • editing/pasteboard/newlines-around-floating-or-positioned-expected.txt: Added.
  • editing/pasteboard/newlines-around-floating-or-positioned.html: Added.
  • fast/events/capture-on-target-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/events/mouseover-mouseout-expected.txt:
  • fast/events/mouseover-mouseout2-expected.txt:
  • fast/events/window-events-bubble-expected.txt:
  • fast/events/window-events-bubble2-expected.txt:
  • fast/events/window-events-capture-expected.txt:
  • fast/forms/input-appearance-elementFromPoint-expected.txt:
  • fast/forms/onselect-textarea-expected.txt:
  • fast/forms/onselect-textfield-expected.txt:
Note: See TracTimeline for information about the timeline view.