Context Navigation

← Previous Period
Next Period →

Timeline

Aug 27, 2007:

11:35 PM Changeset in webkit [25269] by oliver

2 edits in trunk/LayoutTests

Reviewed by NOBODY (layout test result fix).

Output of layoutTestController.dumpChildFramesAsText changes in non-relevant way
when running this test on its own vs. running as part of the full suite.

Correcting test result for the output produced while running the full suite.

fast/encoding/frame-default-enc-expected.txt:

10:59 PM Changeset in webkit [25268] by oliver

10 edits
2 adds
6 deletes in trunk/LayoutTests

rs=brady

Convert all the encoding tests to plain text dumps.

fast/encoding/char-decoding-expected.txt:
fast/encoding/char-decoding-mac-expected.txt: Added.
fast/encoding/char-decoding-mac.html: Added. char-decoding-mac tests the ability to decode the mac specific legacy x-nextstep charset.
fast/encoding/char-decoding.html:
fast/encoding/frame-default-enc-expected.checksum: Removed.
fast/encoding/frame-default-enc-expected.png: Removed.
fast/encoding/frame-default-enc-expected.txt:
fast/encoding/frame-default-enc.html:
fast/encoding/mispositioned-meta-expected.checksum: Removed.
fast/encoding/mispositioned-meta-expected.png: Removed.
fast/encoding/mispositioned-meta-expected.txt:
fast/encoding/mispositioned-meta.html:
fast/encoding/tag-in-title-expected.checksum: Removed.
fast/encoding/tag-in-title-expected.png: Removed.
fast/encoding/tag-in-title-expected.txt:
fast/encoding/tag-in-title.html:
platform/win/Skipped: Skip char-decoding-mac

4:09 PM Changeset in webkit [25267] by antti

3 edits
2 adds in trunk

WebCore:

Reviewed by Maciej.

Fix <rdar://problem/5433144>
REGRESSION: Unable to click "Select" link at Expedia for car rentals

javascript: URLs need special handling when serializing. Escaping them like
normal attribute values can do bad things. Try hard to not escape anything,
escape quote characters only if really necessary. Try to match Firefox.

Test: fast/innerHTML/javascript-url.html

editing/markup.cpp: (WebCore::urlAttributeToQuotedString): (WebCore::startMarkup):

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5433144>
REGRESSION: Unable to click "Select" link at Expedia for car rentals

fast/innerHTML/javascript-url-expected.txt: Added.
fast/innerHTML/javascript-url.html: Added.

3:46 PM Changeset in webkit [25266] by oliver

2 edits in trunk/LayoutTests

rs=adam

Remove tests effected by <rdar://problem/5317287> from the windows skiplist

platform/win/Skipped:

2:57 PM Changeset in webkit [25265] by hyatt

1 edit in trunk/WebCore/rendering/RenderInline.cpp

2:57 PM Changeset in webkit [25264] by hyatt

5 edits in trunk/WebCore

Fix for 5441224, micro-optimizations to improve the PLT by 1%.

Reviewed by Darin

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
platform/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
rendering/RenderInline.cpp: (WebCore::RenderInline::requiresLayer):
rendering/RenderObject.cpp: (WebCore::RenderObject::isBody):
rendering/RenderObject.h: (WebCore::RenderObject::renderArena): (WebCore::RenderObject::isRoot):

1:43 PM Changeset in webkit [25263] by kmccullo

2 edits in trunk/WebKitTools

Reviewed by John.

Removed Leopard leaks list since all of those radars were fixed.

Scripts/run-webkit-tests:

10:57 AM Changeset in webkit [25262] by bdash

3 edits
5 adds in trunk

2007-08-27 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=15091 Crash in RenderBlock::skipWhitespace during layout <rdar://problem/5439631>

Test: fast/replaced/applet-disabled-positioned.html

html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Changed to call RenderObject::createObject(), which accounts for style.

2007-08-27 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=15091 Crash in RenderBlock::skipWhitespace during layout <rdar://problem/5439631>

fast/replaced/applet-disabled-positioned.html: Added.
platform/mac/fast/replaced: Added.
platform/mac/fast/replaced/applet-disabled-positioned-expected.checksum: Added.
platform/mac/fast/replaced/applet-disabled-positioned-expected.png: Added.
platform/mac/fast/replaced/applet-disabled-positioned-expected.txt: Added.

6:36 AM Changeset in webkit [25261] by zimmermann

9 edits in branches/feature-branch/WebCore

Reviewed by Mitz.

Expose unitsPerEm() in Font classes.
This is needed to implement SVG's advanced text decorations. We won't draw lines for text-decorations
but fillable & strokable rectangles with a certain height, computed through unitsPerEm & font size.

1:13 AM Changeset in webkit [25260] by oliver

2 edits in branches/feature-branch/WebCore

Reviewed by NOBODY (Build fix).

Initialise iterators to appease gcc

rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::closestCharacterToPosition):

1:13 AM Changeset in webkit [25259] by aroben

2 edits in trunk/WebKitTools

Rubberstamped by Mark.

Scripts/pdevenv: Pass arguments along to devenv.com.

Aug 26, 2007:

11:40 PM Changeset in webkit [25258] by darin

2 edits in trunk/JavaScriptCore

quick follow on to that last check-in

API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): Need to initialize m_class to 0.

11:17 PM Changeset in webkit [25257] by bdash

5 edits in trunk/JavaScriptCore

2007-08-26 Mark Rowe <mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/4949002> JSGlobalContextCreate can cause crashes because it passes a NULL JSContextRef to the globalObjectClass's initialize callback

JSCallbackObject now tracks whether it was constructed with a null ExecState. This will happen when the object is being used as the global object,
as the Interpreter needs to be created after the global object. In this situation the initialization is deferred until after the Interpreter's
ExecState is available to be passed down to the initialize callbacks.

API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): Track whether we successfully initialized. (KJS::JSCallbackObject::initializeIfNeeded): Attempt to initialize with the new ExecState.
API/JSCallbackObject.h:
API/JSContextRef.cpp: (JSGlobalContextCreate): Initialize the JSCallbackObject with the Interpreter's ExecState.
API/testapi.c: (testInitializeOfGlobalObjectClassHasNonNullContext): (main): Verify that the context passed to the initialize callback is non-null.

11:02 PM Changeset in webkit [25256] by bdash

3 edits in trunk/JavaScriptCore

2007-08-26 Mark Rowe <mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5438496> JSGlobalContextCreate crashes when passed a custom class

API/JSContextRef.cpp: (JSGlobalContextCreate): Specify jsNull() as the prototype and let Interpreter's constructor fix it up to point at builtinObjectPrototype().
API/testapi.c: (main): Use an instance of a custom class as the global object to ensure the code path is exercised in the test.

5:11 PM Changeset in webkit [25255] by antti

3 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5433726>
Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (http://www.yahoo.com/)

Test: editing/style/temporary-span-crash.html

page/Frame.cpp: (WebCore::Frame::styleForSelectionStart): Temporary span created here might not have renderer if document has style sheet that makes it display:none. Set display:inline explicitly in spans style attribute. This temporary span does not need to get its display value from actual document style sheets. Null check the renderer too to be sure.

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5433726>
Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (http://www.yahoo.com/)