⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 28, 2007:

7:51 PM Changeset in webkit [25286] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Removed test files in /resources/ subdirectories.

7:49 PM Changeset in webkit [25285] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej.

Ignore files in /resources/ subdirectories when creating a list of added tests.

  • Scripts/prepare-ChangeLog: (generateFileList):
5:32 PM Changeset in webkit [25284] by weinig
  • 4 edits
    7 adds in trunk

WebCore:

Reviewed by Darin.

Update fix landed in r25249 to account for XMLHttpRequest, which can also be EventTargets.

Tests: http/tests/security/listener/resources/childWithXMLHttpRequest.html

http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html
http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html
http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html
http/tests/security/listener/xss-XMLHttpRequest-shortcut.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::putValueProperty): Use the Window object associated with document's frame, not the active Window. (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): ditto
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::document): Expose Document member so bindings can access the correct frame.

LayoutTests:

Reviewed by Darin.

Additional tests for <rdar://problem/5426142>

  • http/tests/security/listener/resources/childWithXMLHttpRequest.html: Added.
  • http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut.html: Added.
5:15 PM Changeset in webkit [25283] by andersca
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

Restore the previous behavior, creating plug-ins on attach, for WebKit plug-ins. Netscape plug-ins
are still created during the first layout.


  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance): Only call layout if the renderer doesn't have a widget.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance): Likewise.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin): Update for enum change.


  • loader/FrameLoaderTypes.h: Add ObjectContentNetscapePlugin and ObjectContentOtherPlugin.


  • page/mac/WebCoreFrameBridge.h: Get rid of the enum here, we can use the one in FrameLoaderTypes.h


  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Only create the plug-in if it's not a Netscape plug-in.


(WebCore::RenderPartObject::layout):
Fix indentation.

WebKit:

Reviewed by Darin.

<rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent


  • WebCoreSupport/WebFrameBridge.mm: Use the enum from FrameLoaderTypes.h.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): Return ObjectContentNetscapePlugin and ObjectContentOtherPlugin depending on the plug-in type.
4:36 PM Changeset in webkit [25282] by honeycutt
  • 2 edits in trunk/WebKit/win

2007-08-28 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

<rdar://problem/5444457>: Content is cut when page orientation changed
in print preview
Fix: Don't return WebFrame::m_pageRects if it exists; let
computePageRectsForFrame clear and rewrite it.

  • WebFrame.cpp: (WebFrame::computePageRects): Removed an early-return case. Added a space.
3:08 PM Changeset in webkit [25281] by harrison
  • 1 edit
    9 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/5415006> Command Left in a To Do causes caret to disappear

  • editing/selection/mixed-editability-8.html: Added.
  • editing/selection/mixed-editability-9.html: Added.
  • platform/mac/editing/selection: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.checksum: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.png: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.txt: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.checksum: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.png: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.txt: Added.
3:06 PM Changeset in webkit [25280] by harrison
  • 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5415006> Command Left in a To Do causes caret to disappear

The selection was ending up inside non-editable content at the To Do Options
arrow image, rather then at the editable position just to the left of that image.
The problem was that startPositionForLine looked only at line boxes, and there
is no linebox for the editable position at the far left of a To Do, which is
a table. Addressed by having startPositionForLine use table offset 0 instead
of the first VisiblePosition inside the table.


Found and fixed the similar case with option-left (move by word position).


Test cases:

  • editing/selection/mixed-editability-8.html: Added.
  • editing/selection/mixed-editability-9.html: Added.

Source changes:

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyMovingLeftBackward):


  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::stayInEditableContentLeft): (WebCore::VisiblePosition::stayInEditableContentRight): Factored stayInEditableContentLeft() and stayInEditableContentRight() out of previous() and next().


  • editing/VisiblePosition.h: Declare stayInEditableContentLeft() and stayInEditableContentRight().
  • editing/visible_units.cpp: (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Call stayInEditableContentLeft() or stayInEditableContentRight(), as appropriate, so prevent crossing from editable content into uneditable content.


(WebCore::startPositionForLine):
Use table offset 0 instead of the first VisiblePosition in the table.

1:24 PM Changeset in webkit [25279] by bdash
  • 2 edits in trunk/WebKit

2007-08-28 Mark Rowe <​mrowe@apple.com>

Fix the buildbot build.

  • History/WebHistory.mm: (timeIntervalForBeginningOfDay): Explicitly cast to silence compiler warning.
1:12 PM Changeset in webkit [25278] by bdash
  • 2 edits in trunk/WebCore

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5443453> Decreasing history expiration time from 1 year to 1 week can lead to long hang while icon database syncs

Perform the sync inside a SQLite transaction. This drops the time taken for the sync from over 90s to under half a second in the
extreme case of over 90,000 URLs being pruned.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncDatabase):
1:06 PM Changeset in webkit [25277] by andersca
  • 3 edits in trunk/LayoutTests

Use the correct test paths.


  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:55 PM Changeset in webkit [25276] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Put ChangeLog back to UTF-8 after FileMerge went and mangled it for my last commit.

12:48 PM Changeset in webkit [25275] by bdash
  • 10 edits
    2 deletes in trunk

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

Move WebHistoryItemPrivate from using a sorted array of NSCalendarDate's that map to a sorted array of arrays
of WebHistoryItem's over to using a HashMap of NSTimeIntervals and arrays of WebHistoryItems. NSTimeInterval
uses less memory and is substantially cheaper during comparisons than NSCalendarDate. The use of the HashMap
avoids the needs to repeatedly search within an array to locate the array that corresponds to the given days
history items.

The result of these changes is that loading 100,000 history items drops from around 25s to 1.6s. Loading
100 items drops from 0.003s to 0.002s.

  • History/WebHistory.mm: (-[WebHistoryPrivate init]): (-[WebHistoryPrivate dealloc]): (timeIntervalForBeginningOfDay): Return the NSTimeInterval representing the beginning of the specified day. (-[WebHistoryPrivate findKey:forDay:]): (-[WebHistoryPrivate insertItem:forDateKey:]): Perform a binary search within the day's history items rather than a linear search. (-[WebHistoryPrivate _removeItemFromDateCaches:]): (-[WebHistoryPrivate _addItemToDateCaches:]): (-[WebHistoryPrivate removeAllItems]): (-[WebHistoryPrivate orderedLastVisitedDays]): Generate and cache the sorted NSArray of NSCalendarDate's exposed in the API. This cache is invalidated by _removeItemFromDateCaches: and _addItemToDateCaches: when needed. (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]): (-[WebHistoryPrivate arrayRepresentation]): (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Use an autorelease pool to keep the number of live autoreleased objects generated to a reasonable level.
  • History/WebHistoryItem.mm: (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): Use the new HistoryItem constructor that accepts the alternate title rather than setting it after construction. This prevents a modification notification from being sent for each WebHistoryItem that is loaded.
  • History/WebHistoryItemInternal.h:
  • History/WebHistoryPrivate.h:
  • Misc/WebNSCalendarDateExtras.h: Removed as _webkit_compareDay: is no longer used.
  • Misc/WebNSCalendarDateExtras.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

Add a new constructor for HistoryItem that initializes the alternate title. This prevents WebHistoryItem
in WebKit from having explicitly set the display title, which triggers a history item changed notification
to be posted, for each history item loaded.

  • WebCore.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h:
12:05 PM Changeset in webkit [25274] by andersca
  • 20 edits
    3 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


Add a shouldContentSniff flag to ResourceLoader and ResourceHandle and have XMLHttpRequest
pass in false when creating its subresource loader.


  • WebCore.exp:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::loadNow):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::load):
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):

WebKit:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


Expose WKSetNSURLRequestShouldContentSniff to WebCore.


  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


  • http/tests/xmlhttprequest/resources/small-chunks.cgi: Added.
  • http/tests/xmlhttprequest/small-chunks-response-text-expected.txt: Added.
  • http/tests/xmlhttprequest/small-chunks-response-text.html: Added.
  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:03 PM Changeset in webkit [25273] by andersca
  • 3 edits in trunk/WebKitLibraries

Add WKSetNSURLRequestShouldContentSniff.


  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
10:23 AM Changeset in webkit [25272] by adachan
  • 5 edits
    1 add in trunk/WebKit/win

<rdar://problem/4876242> Added SPI to fetch SSL certificate information.

Reviewed by Adam and Steve.

  • Interfaces/IWebURLResponsePrivate.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): (WebURLResponse::sslPeerCertificate): gets peer certificate context from CFNetwork (WebURLResponse::certificateDictionary): gets the dictionary that contains SSL certificate info from CFNetwork. We retain the dictionary to ensure the certificate context is valid throughout the lifetime of the WebURLResponse.
  • WebURLResponse.h:


10:20 AM Changeset in webkit [25271] by adachan
  • 4 edits in trunk/WebKitLibraries

<rdar://problem/4876242> Added SPI to fetch SSL certificate information.
Updated libraries.


Reviewed by Adam.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:


9:29 AM Changeset in webkit [25270] by sfalken
  • 4 edits in trunk

<rdar://problem/5424801> REGRESSION (r25151): Web page area of window doesn't redraw if page isn't loaded


Don't bypass WebView WM_PAINT if the WebView has never committed a page.
Added getter for committedFirstRealDocumentLoad.


Reviewed by Maciej.

  • WebView.cpp: (WebViewWndProc): Don't skip painting if we haven't committed any pages in this view.
  • loader/FrameLoader.h: Added committedFirstRealDocumentLoad. (WebCore::FrameLoader::committedFirstRealDocumentLoad): Added.

Aug 27, 2007:

11:35 PM Changeset in webkit [25269] by oliver
  • 2 edits in trunk/LayoutTests

Reviewed by NOBODY (layout test result fix).

Output of layoutTestController.dumpChildFramesAsText changes in non-relevant way
when running this test on its own vs. running as part of the full suite.


Correcting test result for the output produced while running the full suite.

  • fast/encoding/frame-default-enc-expected.txt:
10:59 PM Changeset in webkit [25268] by oliver
  • 10 edits
    2 adds
    6 deletes in trunk/LayoutTests

rs=brady


Convert all the encoding tests to plain text dumps.

  • fast/encoding/char-decoding-expected.txt:
  • fast/encoding/char-decoding-mac-expected.txt: Added.
  • fast/encoding/char-decoding-mac.html: Added. char-decoding-mac tests the ability to decode the mac specific legacy x-nextstep charset.
  • fast/encoding/char-decoding.html:
  • fast/encoding/frame-default-enc-expected.checksum: Removed.
  • fast/encoding/frame-default-enc-expected.png: Removed.
  • fast/encoding/frame-default-enc-expected.txt:
  • fast/encoding/frame-default-enc.html:
  • fast/encoding/mispositioned-meta-expected.checksum: Removed.
  • fast/encoding/mispositioned-meta-expected.png: Removed.
  • fast/encoding/mispositioned-meta-expected.txt:
  • fast/encoding/mispositioned-meta.html:
  • fast/encoding/tag-in-title-expected.checksum: Removed.
  • fast/encoding/tag-in-title-expected.png: Removed.
  • fast/encoding/tag-in-title-expected.txt:
  • fast/encoding/tag-in-title.html:
  • platform/win/Skipped: Skip char-decoding-mac
4:09 PM Changeset in webkit [25267] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.


Fix <rdar://problem/5433144>
REGRESSION: Unable to click "Select" link at Expedia for car rentals


javascript: URLs need special handling when serializing. Escaping them like
normal attribute values can do bad things. Try hard to not escape anything,
escape quote characters only if really necessary. Try to match Firefox.

Test: fast/innerHTML/javascript-url.html

  • editing/markup.cpp: (WebCore::urlAttributeToQuotedString): (WebCore::startMarkup):

LayoutTests:

Reviewed by Maciej.


Test for <rdar://problem/5433144>
REGRESSION: Unable to click "Select" link at Expedia for car rentals

  • fast/innerHTML/javascript-url-expected.txt: Added.
  • fast/innerHTML/javascript-url.html: Added.
3:46 PM Changeset in webkit [25266] by oliver
  • 2 edits in trunk/LayoutTests

rs=adam

Remove tests effected by <rdar://problem/5317287> from the windows skiplist

  • platform/win/Skipped:
2:57 PM Changeset in webkit [25265] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderInline.cpp
2:57 PM Changeset in webkit [25264] by hyatt
  • 5 edits in trunk/WebCore

Fix for 5441224, micro-optimizations to improve the PLT by 1%.

Reviewed by Darin

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
  • platform/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::requiresLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isBody):
  • rendering/RenderObject.h: (WebCore::RenderObject::renderArena): (WebCore::RenderObject::isRoot):
1:43 PM Changeset in webkit [25263] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by John.

  • Removed Leopard leaks list since all of those radars were fixed.
  • Scripts/run-webkit-tests:
10:57 AM Changeset in webkit [25262] by bdash
  • 3 edits
    5 adds in trunk

2007-08-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/replaced/applet-disabled-positioned.html

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Changed to call RenderObject::createObject(), which accounts for style.

2007-08-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/replaced/applet-disabled-positioned.html: Added.
  • platform/mac/fast/replaced: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.checksum: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.png: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.txt: Added.
6:36 AM Changeset in webkit [25261] by zimmermann
  • 9 edits in branches/feature-branch/WebCore

Reviewed by Mitz.

Expose unitsPerEm() in Font classes.
This is needed to implement SVG's advanced text decorations. We won't draw lines for text-decorations
but fillable & strokable rectangles with a certain height, computed through unitsPerEm & font size.

1:13 AM Changeset in webkit [25260] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by NOBODY (Build fix).

Initialise iterators to appease gcc

  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1:13 AM Changeset in webkit [25259] by aroben
  • 2 edits in trunk/WebKitTools

Rubberstamped by Mark.

  • Scripts/pdevenv: Pass arguments along to devenv.com.
Note: See TracTimeline for information about the timeline view.