Timeline

Sep 1, 2007:

9:44 PM Changeset in webkit [25346] by darin

• 3 edits
  1 delete in trunk

WebCore:

• rolled out fix for bug 12988 because it broke getElementById in a layout test I'm working on a new fix.

• dom/Document.cpp: Rolled out.

LayoutTests:

• rolled out the test case for 12988 until we re-fix it

• fast/dom/duplicate-ids-document-order.html: Removed.

4:04 PM Changeset in webkit [25345] by oliver

• 24 edits in trunk

gtk:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

EditorClient::setInputMethodState stub

• WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState):
• WebCoreSupport/EditorClientGtk.h:

WebCore:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

Adding a new EditorClient method so it is possible to inform WebKit of focus changes.
Also added new virtual method Node::shouldUseInputMethod to allow us to trivially check
whether an input method should be used when processing input for the currently focused
Node.

• bridge/EditorClient.h:
• dom/Node.cpp: (WebCore::Node::shouldUseInputMethod):
• dom/Node.h:
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldUseInputMethod):
• html/HTMLInputElement.h:
• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::shouldUseInputMethod):
• html/HTMLTextAreaElement.h:
• page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::setInputMethodState):

WebKit:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

EditorClient::setInputMethodState stub

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setInputMethodState):

WebKitQt:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

EditorClient::setInputMethodState stub

• WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
• WebCoreSupport/EditorClientQt.h:

win:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

When focusing a password field or a non-editable element we disassociate any IME that may have
been active, and reassociate should a non-password editable element is focused.

This makes password input with an IME active simpler, and brings our IME behaviour in line with
IE.

• WebEditorClient.cpp: (WebEditorClient::setInputMethodState):
• WebEditorClient.h:
• WebView.cpp: (IMMDict::IMMDict): (WebView::setInputMethodState):
• WebView.h:

7:05 AM Changeset in webkit [25344] by bdash

• 1 edit in tags/Safari-5523.3.1/WebKit/Configurations/Version.xcconfig

Versioning.

7:05 AM Changeset in webkit [25343] by bdash

• 2 edits in tags/Safari-5523.3.1/WebKit

Merge r25300.

2007-08-29 Anders Carlsson <​andersca@apple.com>

Fix 64-bit build.

• WebCoreSupport/WebFrameBridge.mm:

6:55 AM Changeset in webkit [25342] by bdash

• 1 copy in tags/Safari-5523.3.1

New tag.

1:08 AM Changeset in webkit [25341] by rwlbuis

• 3 edits
  2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first

Reset the element id cache when id's are added or removed and there
are duplicates for that id.

12:43 AM Changeset in webkit [25340] by rwlbuis

• 9 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15083
Some symbols in WebKit do not need to be exported

Do not export these symbols.

Aug 31, 2007:

10:44 PM Changeset in webkit [25339] by sfalken

• 2 edits in trunk/WebKit/win

<rdar://problem/5432594> Safari quits when hovering over mailto links on a webpage

In addition to substituting %@ with %s, we also need to substitute %{1-9}$@ with %{1-9}$s.

7:11 PM Changeset in webkit [25338] by bdash

• 1 copy in tags/Safari-4523.3

New tag.

5:56 PM Changeset in webkit [25337] by sfalken

• 1 copy in tags/Safari-523.3b

New tag.

5:56 PM Changeset in webkit [25336] by sfalken

• 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

4:02 PM Changeset in webkit [25335] by aliceli1

• 5 edits
  4 adds in trunk

WebCore:

Reviewed by Tim Hatcher.

Fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

• editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Factored out the code in ::show() that created and styled the elements of the Deletion UI

(WebCore::DeleteButtonController::createDeletionUI):
Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a
bloated table deletion UI which was slow to show and hide.

• editing/DeleteButtonController.h: (WebCore::DeleteButtonController::enabled): Restore this function to how it used to be pre-r25305, sans asserts

• editing/EditCommand.cpp: Add disable/enable sandwich when undoing/redoing commands too (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):

LayoutTests:

Reviewed by Tim Hatcher.

Test for <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

• editing/deleting/deletionUI-single-instance.html: Added.
• platform/mac/editing/deleting/deletionUI-single-instance-expected.checksum: Added.
• platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Added.
• platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Added.

3:09 PM Changeset in webkit [25334] by antti

• 3 edits in trunk/WebCore

Reviewed by Anders.

Fix <rdar://problem/5452943>
REGRESSION (r25283): Reproducible crash in HTMLObjectElement::getInstance under guard malloc

Calling updateLayoutIgnorePendingStylesheets() may do arbitrary things to render tree so
no RenderObjects can be cached over it.

• html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer): (WebCore::HTMLEmbedElement::getInstance):
• html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance):

2:57 PM Changeset in webkit [25333] by andersca

• 2 edits in trunk/WebCore

Reviewed by Mitz.

<rdar://problem/5443936>
Crash after QT movie completes playback at apple.com/imac

If the plug-in or one of its children have focus, set it to NULL to prevent the web view window from getting the focus,
which can cause a layout to happen while in HTMLObjectElement::detach. (This is what we do on the Mac).

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setParent):

11:51 AM Changeset in webkit [25332] by adele

• 4 edits
  2 adds in trunk

WebCore:

Reviewed by Justin.

Fix for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

Test: editing/pasteboard/paste-plaintext-user-select-none.html

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering): Copy the user-select style from the current selection node and apply it so it is considered during the test rendering. This is important since we recently changed user-select to be inherited. When we consider valid VisiblePositions for the test rendering, we need to have the correct user-select value that will actually be used for the real insertion.

LayoutTests:

Reviewed by Justin.

Test for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

• editing/pasteboard/paste-plaintext-user-select-none-expected.txt: Added.
• editing/pasteboard/paste-plaintext-user-select-none.html: Added.
• fast/forms/textarea-paste-newline.html: Updated to escape '\n' in failure description.

11:16 AM Changeset in webkit [25331] by andersca

• 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5423939>
​http://bugs.webkit.org/show_bug.cgi?id=15013
ASSERTION FAILED !m_inDestructor in WebCore::Shared<WebCore::PluginStreamWin>::ref() on Windows

Protect the stream in case it's destroyed by the plug-in.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):

9:13 AM Changeset in webkit [25330] by darin

• 2 edits in trunk/WebCore

Reviewed by Anders.

• ​http://bugs.webkit.org/show_bug.cgi?id=15122

• editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode): Change assertion so that it only fires when actually modifying the selection. This isn't nearly as helpful, because the old assertion could catch potential problems in more cases, but it's not obvious how to do better.