⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 11, 2007:

8:16 PM Changeset in webkit [25505] by kdecker
  • 8 edits
    2 adds in trunk

Reviewed by Oliver Hunt.

Fixed: <rdar://problem/5472402> crash due to infinite recursion in expandUseElementsInShadowTree on SVG from wikipedia

  • ksvg2/svg/SVGUseElement.cpp: Added SVG_EXPERIMENTAL #ifdef for expandUseElementsInShadowTree(). (WebCore::SVGUseElement::buildPendingResource): Ditto. (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements): Tweaked an ASSERT to not fire on non-experimental builds.
  • ksvg2/svg/SVGUseElement.h: Added SVG_EXPERIMENTAL #ifdef for expandUseElementsInShadowTree().
6:51 PM Changeset in webkit [25504] by sfalken
  • 1 copy in tags/Safari-523.5b

New tag.

4:32 PM Known incompatibilities between open-source WebKit and Safari edited by beidson@apple.com
(diff)
3:44 PM Changeset in webkit [25503] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Maciej

Fix for <rdar://problem/5473046> - Crash when resetting all icons

Originally I'd written the "reset all icons" to be synchronous on the main thread, but it
was decided that it should be async since it involved I/O. Turns out it needs to be... both!
Synchronous removal of all in-memory records of icons, and then continue and clean up the
on-disk database on the background thread.

Also, it turns out that resetting all the page url retain counts should *not* be part of
"reset all icons" because it breaks various contracts the API makes about maintaining retain counts.

The problem that occured here was removing all the icons, then all the history items that were
removed as part of "Reset Safari..." would try to release their icon, but their icon doesn't exist
anymore.

We get around this by simply leaving the in-memory page url records and retain counts alone - they
are still wiped from disk.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::removeAllIcons): Clear in-memory records of all icons then tell the thread to wipe the on-disk tables (WebCore::IconDatabase::removeAllIconsOnThread): Only do the disk cleanup - in-memory maintenance is handled on the main thread (WebCore::IconDatabase::cleanupSyncThread): Now that it's possible for new "icons to be written to disk" to appear while on-disk deleting is occuring, let the cleanup procedure perform 1 final write *after* it does the remove all icons
  • loader/icon/IconDatabase.h: Removed unused lock and condition
  • loader/icon/PageURLRecord.cpp: (WebCore::PageURLRecord::setIconRecord): Allow setting a NULL icon record, so a PageURLRecord can be cleared as part of removeAllIcons()
3:13 PM Changeset in webkit [25502] by tristan
  • 2 edits in trunk/WebCore

Reviewed by David Harrison.


<rdar://problem/5467203> CrashTracer: [USER] 1 crash in Mail at <unknown binary>: WebCore::Range::startContainer const

  • editing/SelectionController.cpp: (WebCore::SelectionController::addRange): (WebCore::SelectionController::setSelectedRange): Added a check to make sure the passed in Range* value is not null before performing operations on it.
2:50 PM Changeset in webkit [25501] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Remove the unused class_getMethodImplementation function.

  • Misc/WebNSObjectExtras.h:
1:59 PM Changeset in webkit [25500] by justing
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.


<rdar://problem/5458246>
GoogleDocs: A hang occurs when applying list styling to selection that contains a <HR>


List insertion moves selected paragraphs into list items, and relies on the selection
preservation code inside moveParagraphs to iterate over the selected paragraphs.
When list insertion would try to listify a paragraph that came after a list item
containing an <hr>, the selection preservation code would set an incorrect ending
selection because of a TextIterator bug, and we would try to listify the same
paragraph over and over.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Pass range compliant equivalents to the Range constructor here. The position [hr, 0] is not a valid DOM Range endpoint for example.
  • editing/TextIterator.cpp: (WebCore::shouldEmitSpaceForNode): Added. (WebCore::TextIterator::handleNonTextNode): Emit a space to represent a horizontal rule, since it has VisiblePositions before and after it, but only for TextIterators used for selection preservation, so innerText will be unaffected.

LayoutTests:

Reviewed by Maciej.

  • editing/execCommand/5458246-expected.txt: Added.
  • editing/execCommand/5458246.html: Added.
1:57 PM Changeset in webkit [25499] by kmccullo
  • 2 edits
    2 moves in trunk/WebKitTools

Reviewed by Adam.

  • Just doing the moves in a separate patch so the changes are easier to see.
  • Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
  • Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
  • Drosera/win/DebuggerDocumentWin.cpp: Removed.
  • Drosera/win/DebuggerDocumentWin.h: Removed.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
11:53 AM Changeset in webkit [25498] by ggaren
  • 3 edits in trunk/WebKit

Reviewed by Oliver Hunt.


Fixed CFNetwork version check so it actually works.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (+[WebView _setCacheModel:]): Don't use NSVersionOfLinkTimeLibrary because we don't link against CFNetwork directly, so it returns -1. Also, use the proper hex encoding instead of decimal numbers.
11:29 AM Changeset in webkit [25497] by adachan
  • 3 edits in trunk/WebCore

<rdar://problem/5472130> Support NTLM authentication via CFNetwork.

Reviewed by Darin.

  • platform/network/ProtectionSpace.h: (WebCore::):
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::createCF): (WebCore::core):
11:11 AM Changeset in webkit [25496] by darin
  • 1 edit in trunk/WebKit/win/WebView.cpp

Roll out accidentally-checked in change.

11:10 AM Changeset in webkit [25495] by darin
  • 3 edits in trunk/WebKit
  • redo fix for <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery
  • WebView/WebView.mm: (getMethod): Added. (-[WebView _cacheResourceLoadDelegateImplementations]): Use getMethod. (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
10:47 AM Changeset in webkit [25494] by darin
  • 5 edits in trunk

WebCore:

Rubber-stamped by Dave Harrison.

  • fixed pasteboard types here to match WebKit and use constants instead of WebKitSystemInterface
  • platform/mac/PasteboardMac.mm: Use constants for all pasteboard type strings.
  • platform/mac/WebCoreSystemInterface.h: Removed wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.

WebKit:

Rubber-stamped by Dave Harrison.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Removed wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.
9:41 AM Changeset in webkit [25493] by darin
  • 5 edits in trunk/WebKit

Reviewed by Mark Rowe.

  • fix <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery
  • Misc/WebNSObjectExtras.h: (class_getMethodImplementation): Added. (method_setImplementation): Added.
  • WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]):
  • Carbon/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]): Remove old-ObjC code path, since WebNSObjectExtras.h now implements everything we need.
  • WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): Don't bother doing a separate respondsToSelector call, since class_getMethodImplementation will return 0 for selectors that we don't respond to. The bug fix is to actually set the cached pointer to 0. Also get rid of the unnecessary use of a macro; instead use the functions from WebNSObjectExtras.h on Tiger and the appropriate function directly on Leopard. (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
9:35 AM Changeset in webkit [25492] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
​http://bugs.webkit.org/show_bug.cgi?id=15176

  • Scripts/run-launcher: don't replace LD_LIBRARY_PATH with $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve other paths eg. from jhbuild)
9:33 AM Changeset in webkit [25491] by darin
  • 2 edits in trunk/WebKit

Reviewed by Sam, Ollie.

  • WebView/WebView.mm: (+[WebView _setCacheModel:]): A slightly cleaner 64-bit fix for the NSURLCache capacity code in this file.
9:00 AM Changeset in webkit [25490] by darin
  • 2 edits in trunk/WebKit

Rubber-stamped by Mark Rowe.

  • Misc/WebNSPasteboardExtras.mm: Fix incorrect strings in my last check-in. The strings I checked in were wrong and were breaking layout tests too. These new ones match what WebKitSystemInterface was returning.
8:03 AM Changeset in webkit [25489] by bdash
  • 4 edits in trunk/WebCore

2007-09-11 Sven Herzberg <​sven@imendio.com>

Reviewed by Mark.

Remove unnecessary fields in FontPlatformData
​http://bugs.webkit.org/show_bug.cgi?id=15177

  • platform/gdk/FontDataGdk.cpp: removed the destroy code of the fields that have been removed
  • platform/gdk/FontPlatformData.h: removed m_fontFace, m_fontMatrix and m_options; hask on m_scaledFont
  • platform/gdk/FontPlatformDataGdk.cpp: simplified setFont() by using m_scaledFont only; turned the former struct members into local variables

Sep 10, 2007:

10:33 PM Changeset in webkit [25488] by staikos
  • 2 edits in trunk/WebCore

2007-09-11 George Staikos <​staikos@kde.org>

Reviewed by Anders.

Work around gcc bug with some old gcc versions.

  • platform/qt/WidgetQt.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):
10:19 PM Changeset in webkit [25487] by bdash
  • 3 edits
    4 adds in trunk

2007-09-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej Stachowiak.

Test: fast/repaint/body-background-image.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Refined the logic for when the root takes over painting the background, to match paintBoxDecorations(). In particular, if the root has defined a background, the body should paint its own background.

2007-09-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej Stachowiak.

  • fast/repaint/body-background-image.html: Added.
  • platform/mac/fast/repaint/body-background-image-expected.checksum: Added.
  • platform/mac/fast/repaint/body-background-image-expected.png: Added.
  • platform/mac/fast/repaint/body-background-image-expected.txt: Added.
10:17 PM Changeset in webkit [25486] by bdash
  • 2 edits in trunk/WebKit/gtk

2007-09-10 Nigel Tao <​nigeltao@gnome.org>

Reviewed by Mark Rowe.

Fix a typo where webkit_gtk_page_can_copy was declared twice,
rather than webkit_gtk_page_can_paste.

  • Api/webkitgtkpage.h:
8:53 PM Changeset in webkit [25485] by ggaren
  • 2 edits in trunk/WebKit

Fixed 64-bit build (I think).

  • WebView/WebView.mm: (max): Added. In 64-bit land, -diskCapacity magically starts returning unsigned long instead of unsigned, so we define a custom max() that's willing to compare unsigned to unsigned long.
6:03 PM Changeset in webkit [25484] by harrison
  • 9 edits
    8 adds in trunk

WebCore:

Reviewed by Kevin and Tristan.

Tests added:

  • editing/pasteboard/paste-into-anchor-text.html: Added.
  • editing/pasteboard/paste-table-cells.html: Added.

Source changes:

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Nil check enclosingAnchor.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeNodeAndPruneAncestors): New. Keeps m_firstNodeInserted and m_lastLeafInserted updated.


(WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
Added a comment.


(WebCore::ReplaceSelectionCommand::removeRedundantStyles):
Let ReplaceSelectionCommand::removeNodeAndPruneAncestors() update the nodes.


(WebCore::ReplaceSelectionCommand::doApply):
Pass originalVisPosBeforeEndBR to shouldRemoveEndBR()


(WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):
Don't remove the br if nothing was inserted.


  • editing/ReplaceSelectionCommand.h: Add VisiblePosition parameter to shouldRemoveEndBR()


  • editing/markup.cpp: (WebCore::createMarkup): Wrap orphan tr element with a table element, just like we were doing for tobody elements.

LayoutTests:

Reviewed by Kevin and Tristan.

<rdar://problem/5456800> Mail crashes at WebCore::nextCandidate() after pasting back into a <table> multiple times

  • editing/pasteboard/paste-into-anchor-text.html: Added.
  • editing/pasteboard/paste-table-cells.html: Added.
  • editing/pasteboard/quirks-mode-br-1-expected.checksum:
  • editing/pasteboard/quirks-mode-br-1-expected.txt:
  • editing/pasteboard/quirks-mode-br-1.html:
  • platform/mac/editing/pasteboard/paste-into-anchor-text-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-into-anchor-text-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-into-anchor-text-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-table-cells-expected.txt: Added.
5:16 PM Changeset in webkit [25483] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

<rdar://problem/5456224> CrashTracer: [USER] 2 crashes in Toast Titanium at com.apple.CoreServices.CarbonCore: CSMemDisposePtr + 37

Removed the implementation of these malloc zone functions. We do not have the ability to
check if a pointer is valid or not, so we can't correctly implement them. The system free
does not fail if you pass in a bad pointer.

  • wtf/FastMalloc.cpp: (WTF::FastMallocZone::size): (WTF::FastMallocZone::zoneMalloc): (WTF::FastMallocZone::zoneCalloc): (WTF::FastMallocZone::zoneFree): (WTF::FastMallocZone::zoneRealloc):
4:29 PM Changeset in webkit [25482] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by Oliver.

  • Updated Skipped list to remove tests that are now passing.
  • platform/win/Skipped:
4:13 PM Changeset in webkit [25481] by kmccullo
  • 4 edits
    3 deletes in trunk/WebKitTools

Reviewed by Adam.

  • Made an order-of-deletion mistake.
  • Drosera/DebuggerDocument.h:
  • Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
  • Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
  • Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
  • Drosera/mac/DebuggerClient.mm: (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3:59 PM Changeset in webkit [25480] by kmccullo
  • 5 edits
    2 moves
    3 adds in trunk/WebKitTools

Reviewed by Darin.

  • Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::DebuggerDocument):
  • Drosera/DebuggerDocument.h:
  • Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
  • Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
  • Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
  • Drosera/mac/DebuggerApplication.mm: (-[DebuggerApplication attach:]):
  • Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
  • Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
  • Drosera/mac/DebuggerDocumentMac.h: Removed.
  • Drosera/mac/DebuggerDocumentMac.mm: Removed.
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3:53 PM Changeset in webkit [25479] by thatcher
  • 1 edit in tags/Safari-5523.5.1/WebKit/Configurations/Version.xcconfig

Versioning

3:49 PM Changeset in webkit [25478] by thatcher
  • 7 edits in tags/Safari-5523.5.1/WebKit

Merge r25476.

3:41 PM Changeset in webkit [25477] by thatcher
  • 1 copy in tags/Safari-5523.5.1

New tag.

3:39 PM Changeset in webkit [25476] by darin
  • 7 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • <rdar://problem/5471082> Removing WebURLPboardType from headers broke SPI-using applications

Rolled out my fix for bug 4582212 and fixed it in a much simpler way.

  • Misc/WebNSPasteboardExtras.h:
  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebPasteboardHelper.mm:
  • WebKit.exp:
  • WebView/WebHTMLView.mm:
  • WebView/WebView.mm: Rolled out the new PasteboardType functions and changed the PboardType globals to be initialized with constant values.
2:47 PM Changeset in webkit [25475] by sfalken
  • 2 edits in trunk/WebKit/win

Remove site-specific hacks that we don't need anymore.

Reviewed by Adam.

  • WebView.cpp: (WebView::userAgentForKURL):
2:32 PM Changeset in webkit [25474] by sfalken
  • 3 edits in trunk/WebKit/win

Prevent WebKit version numbers from containing "4" in Windows.

Reviewed by Darin.

  • WebKit.vcproj/VERSION: Bump version since our current version ends in 4.
  • WebKit.vcproj/auto-version.sh: Add version checking code.
2:23 PM Changeset in webkit [25473] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Rubberstamped by Kevin Decker.

No test required since there is no change in functionality.

  • history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList): Fix misspelling of DefaultCapacitiy to DefaultCapacity.
2:21 PM Changeset in webkit [25472] by staikos
  • 2 edits in trunk/WebKitQt

Don't double-encode URL fragments

2:15 PM Changeset in webkit [25471] by tristan
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Adele Peterson.

Test: fast/forms/menulist-clip.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect): Use correct coordinates for the inner block's content rect.

LayoutTests:

Reviewed by Adele Peterson.

  • fast/forms/menulist-clip.html: Added.
  • platform/mac/fast/forms/menulist-clip-expected.checksum: Added.
  • platform/mac/fast/forms/menulist-clip-expected.png: Added.
  • platform/mac/fast/forms/menulist-clip-expected.txt: Added.
2:08 PM Changeset in webkit [25470] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Darin, Sam, Oliver, Geoff, probably others - what a fun one to review!

<rdar://problem/5471641> - URLs get the wrong icon

Turns out sqlite3_reset() doesn't clear bindings, so previously bound icons were being
written out for pages without icons. Easy fix!

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): For null icons, manually bind NULL - otherwise, the previously bound icon will be written out to disk
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::bindNull): Access to sqlite3_bind_null
  • loader/icon/SQLStatement.h:
2:05 PM Changeset in webkit [25469] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver and Darin.

<rdar://problem/5468613>
Using shockwave pages first time after plugin install crashed safari in PluginPing.


Only restore the window proc if the plugin didn't override it.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::stop):
1:55 PM Changeset in webkit [25468] by justing
  • 14 edits
    2 adds
    2 deletes in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5467405>
Revert back behavior of -webkit-user-select to fix widget selection problems


Rolled out r25086 and r25057. I will be re-opening:
<rdar://problem/5333725> -webkit-user-select: none makes selection difficult
Which we will either to defer or fix by introducing a new value of -webkit-user-select.
<rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
Which we will either defer or fix with Adele's patch that doesn't involve making
-webkit-user-select inherited.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::canMouseDownStartSelect):
  • page/EventHandler.h:
  • rendering/RenderObject.cpp: (WebCore::selectStartNode): (WebCore::RenderObject::canSelect): (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::draggableNode):
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::userSelect): (WebCore::RenderStyle::setUserSelect): (WebCore::RenderStyle::initialUserSelect):

LayoutTests:

Reviewed by Darin.


<rdar://problem/5467405>
Revert back behavior of -webkit-user-select to fix widget selection problems

  • editing/selection/5333725.html: Removed.
  • editing/selection/5333725.html-disabled: Added.
  • editing/selection/user-select-text-inside-user-select-ignore.html: Removed.
  • editing/selection/user-select-text-inside-user-select-ignore.html-disabled: Added.
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
10:51 AM Changeset in webkit [25467] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Always animate when calling _scrollTo.

  • WebView/WebFrameView.mm: (-[WebFrameView _scrollVerticallyBy:]): (-[WebFrameView _scrollHorizontallyBy:]):
7:55 AM Changeset in webkit [25466] by antti
  • 6 edits
    3 adds in trunk

WebCore:

Reviewed by Kevin.

Fix <rdar://problem/5444866>
REGRESSION: missing text in Acrobat "Getting Started" screen due to change in load ordering of large resources


Make external scripts loaded using file: wait until all style sheet loads have completed before executing.
Fixes a class of problems where there is a dependency between script and stylesheet and results would effectively
get randomized based on which order the resources arrived. In Tiger file loads were effectively serialized by
lower level components, which is why this regressed.

Test: http/tests/local/stylesheet-and-script-load-order.html

  • dom/Document.cpp: (WebCore::Document::removePendingSheet):
  • dom/Tokenizer.h: (WebCore::Tokenizer::executeScriptsWaitingForStylesheets):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::executeScriptsWaitingForStylesheets): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:

LayoutTests:

Reviewed by Kevin.


Test for <rdar://problem/5444866>
REGRESSION: missing text in Acrobat "Getting Started" screen due to change in load ordering of large resources

  • http/tests/local/stylesheet-and-script-load-order-expected.txt: Added.
  • http/tests/local/stylesheet-and-script-load-order.html: Added.
  • http/tests/local/stylesheet-dependent.js: Added.
Note: See TracTimeline for information about the timeline view.