Context Navigation

platform/Cursor.h: (WebCore::SharedCursor::SharedCursor): (WebCore::SharedCursor::~SharedCursor): (WebCore::SharedCursor::nativeCursor):
platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): (WebCore::loadCursorByName): (WebCore::loadSharedCursor): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::progressCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor):

8:10 PM Changeset in webkit [25529] by weinig

5 edits in trunk/WebKitTools

Reviewed by Stephanie.

Fix leaks in mac DumpRenderTree.

DumpRenderTree/FrameLoadDelegate.mm: (-[FrameLoadDelegate init]): Initalize in the correct order. (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
DumpRenderTree/LayoutTestController.cpp: (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released. (encodeHostNameCallback): ditto.
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/LayoutTestControllerMac.mm: (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule. (LayoutTestController::copyEncodedHostName): ditto (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.

7:29 PM Changeset in webkit [25528] by aroben

3 edits in trunk/WebKit/win

Initialize SafariTheme early in WebKit's instantiation

New versions of SafariTheme will require this initialization. We have
to use GetProcAddress for now since the initialize method doesn't
exist in any released SafariTheme.

Reviewed by Ada.

WebKit.vcproj/debug_internal.vsprops: Pick up the debug SafariTheme.
WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Call STInitialize.

7:16 PM Changeset in webkit [25527] by weinig

2 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

<rdar://problem/5478717> JSStringCreateWithCFString leaks when passed a zero length CFStringRef

API/JSStringRefCF.cpp: (JSStringCreateWithCFString): Special case the zero length string and remove the UTF16 optimized path since it will always leak due to the fact that we won't be able to free the backing store that the CFStringRef provides.

7:08 PM Changeset in webkit [25526] by beidson

3 edits in trunk/WebCore

Reviewed by Geoff Garen

<rdar://problem/5478577> - Further improve cold launch time with Icon Database changes

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Store the directory and full path for later usage and access in the API, respectively Move the makeAllDirectories() call to the background thread. (WebCore::IconDatabase::IconDatabase): Don't set up the timer here... (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Create the timer on demand (WebCore::IconDatabase::iconDatabaseSyncThread): makeAllDirectories() here where it's not as expensive (WebCore::IconDatabase::cleanupSyncThread): Cleanup the directory as well as full path

loader/icon/IconDatabase.h: m_syncTimer becomes an OwnPtr, and we add the database directory as a member to set it on the main thread and act with it on the background thread

6:53 PM Changeset in webkit [25525] by adachan

2 edits in trunk/WebKit/win

<rdar://problem/5478690> Regression: printing: footer only appears on the first page of print

Reviewed by Adam.

WebFrame.cpp: (WebFrame::spoolPages): the footer rect is relative to the top left of the current page. So instead of passing pageRect.bottom() as the top of the footer rect (which is relative to the document), we should pass in headerHeight plus the height of the pageRect.

6:31 PM Changeset in webkit [25524] by kmccullo

5 edits
1 add in trunk/WebKitTools

Reviewed by Darin.

Simplified code paths and extracted out functions to increase encapsulation.

Drosera/DebuggerDocument.cpp: (DebuggerDocument::breakpointEditorHTMLCallback): (DebuggerDocument::isPausedCallback): (DebuggerDocument::pauseCallback): (DebuggerDocument::resumeCallback): (DebuggerDocument::stepIntoCallback): (DebuggerDocument::evaluateScriptCallback): (DebuggerDocument::currentFunctionStackCallback): (DebuggerDocument::localScopeVariableNamesForCallFrameCallback): (DebuggerDocument::valueForScopeVariableNamedCallback): (DebuggerDocument::logCallback):
Drosera/DebuggerDocument.h: (DebuggerDocument::getPaused):
Drosera/mac/DebuggerClient.mm: (-[DebuggerClient pause:]): (-[DebuggerClient resume:]): (-[DebuggerClient stepInto:]): (-[DebuggerClient stepOver:]): (-[DebuggerClient stepOut:]): (-[DebuggerClient showConsole:]): (-[DebuggerClient closeCurrentFile:]): (-[DebuggerClient validateUserInterfaceItem:]):
Drosera/mac/DebuggerDocumentPlatform.mm: Added. (+[NSString stringOrNilFromWebScriptResult:]): (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
Drosera/mac/Drosera.xcodeproj/project.pbxproj:

5:23 PM Changeset in webkit [25523] by andersca

2 edits in trunk/WebKit/win

Reviewed by Darin (reluctantly).

<rdar://problem/5320461>
http://bugs.webkit.org/show_bug.cgi?id=14548
REGRESSION (r23987-r24061) : Reproducible crash with a local stylesheet file

Add a workaround which converts the string passed in to an URL if it's a path.

WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):

5:04 PM Changeset in webkit [25522] by justing

7 edits
6 adds
3 deletes in trunk

WebCore:

Reviewed by Tristan.

<rdar://problem/5469868>
GoogleDocs: A hang occurs when applying list styling to a selection in a <table>

When list insertion moves selected paragraphs into list items, it relies on
the selection preservation code inside moveParagraphs to iterate over the
selected paragraphs. If a selection is ever restored incorrectly (before
the original, or inside the original) list insertion will go into an infinite loop.

In this hang, a table was selected and the selection preservation code incorrectly
restored a selection, placing it inside the table.

The bug was that a TextIterator, when being used for selection preservation, must
emit a character between every VisiblePosition in the Range used to create the
iterator.

editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Renamed the boolean that we use for selection preservation. It used to be m_emitForReplacedElements because we believed that replaced elements were the only case where TextIterators should have emitted differently when used for selection preservation. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Represent the position before block tables, but only if we are emitting for selection preservation. (WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode): We should emit a space before and after block tables if we are emitting for selection preservation (because we have VisiblePositions before and after them). (WebCore::TextIterator::handleNonTextNode): Use a renamed variable.
editing/TextIterator.h: Made shouldEmitSpaceBeforeAndAfterNode a member function, because whether or not we emit spaces before and after a block table depends we're emitting for selection preservation.

LayoutTests:

Reviewed by Tristan.

Demonstrates bug:

editing/execCommand/5469868-expected.txt: Added.
editing/execCommand/5469868.html: Added.

Fixed (and moved expected results to platform/mac):

editing/style/table-selection-expected.checksum: Removed.
editing/style/table-selection-expected.png: Removed.
editing/style/table-selection-expected.txt: Removed.
platform/mac/editing/style: Added.
platform/mac/editing/style/table-selection-expected.checksum: Added.
platform/mac/editing/style/table-selection-expected.png: Added.
platform/mac/editing/style/table-selection-expected.txt: Added.

Fixed:

platform/mac/editing/execCommand/5432254-2-expected.checksum:
platform/mac/editing/execCommand/5432254-2-expected.png:
platform/mac/editing/execCommand/5432254-2-expected.txt:

4:53 PM Changeset in webkit [25521] by bdakin

9 edits
4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5464998> REGRESSION (9A543): Using Sort
options takes you back to search screen on zappos.com

The current mechanism for preserving form elements across removes
did not work in the case where the input was moved by the parser to
be out of scope of the form. This fixes that problem by having the
parser keep track of the preserve boolean rather than the current
form element.

dom/Tokenizer.h: (WebCore::Tokenizer::isHTMLTokenizer): New function.
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Get rid of m_preserveAcrossRemove.
html/HTMLFormElement.h: (WebCore::HTMLFormElement::isMalformed): Get rid of m_preserveAcrossRemove.
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removedFromTree): Ask the parser if it is currently handling residual style rather than asking the form if it wants to preserveAcrossRemove.
html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): New boolean to initialize. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Set m_handlingResidualStyleAcrossBlocks to true at the beginning and false at the end.
html/HTMLParser.h: (WebCore::HTMLParser::isHandlingResidualStyleAcrossBlocks):
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::isHTMLTokenizer): (WebCore::HTMLTokenizer::htmlParser):

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5464998> REGRESSION (9A543): Using Sort
options takes you back to search screen on zappos.com

fast/forms/preserveFormDuringResidualStyle.html: Added.
platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Added.
platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.

4:43 PM Changeset in webkit [25520] by hyatt

1 edit in trunk/WebCore/platform/win/KeyEventWin.cpp

LAnd piece of alt patch I forgot to.

3:23 PM Changeset in webkit [25519] by ddkilzer

2 edits in trunk/WebKit

WebKit:

Rubber-stamped by Darin and reviewed by Adam.

Removed import of unused icon database headers.

WebCoreSupport/WebFrameBridge.mm:

2:12 PM Changeset in webkit [25518] by thatcher

1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Add back the -Wno-deprecated-declarations flag to DumpRenderTree.mm. Fixes the build on Leopard.

1:11 PM Changeset in webkit [25517] by weinig

2 edits in trunk/WebKitTools

Build fix for Buildbot.

DumpRenderTree/DumpRenderTree.mm: (dump):

1:00 PM Changeset in webkit [25516] by kmccullo

2 edits in trunk/WebKitTools

Reviewed by Geof.

Updated the leaks list for leopard to help identify regressions.

Scripts/run-webkit-tests:

12:51 PM Changeset in webkit [25515] by weinig

19 edits
3 copies
3 moves
4 adds
1 delete in trunk

WebKitTools:

Rubber stamped by Darin.

Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.

DumpRenderTree/DumpRenderTree.h: Re-order variables.
DumpRenderTree/DumpRenderTree.m: Removed.
DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m. (stopJavaScriptThreads): Fix initialization. (setDefaultColorProfileToRGB): Add explicit cast from void*. (dumpRenderTree): Ditto. (runTest): Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
DumpRenderTree/FrameLoadDelegate.m: Removed.
DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m. (-[FrameLoadDelegate init]): (-[FrameLoadDelegate dealloc]): (-[FrameLoadDelegate processWork:]): (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): Convert to use the new JSCore based LayoutTestController and the new WorkQueue.

DumpRenderTree/LayoutTestController.cpp: Added. (LayoutTestController::LayoutTestController): (LayoutTestController::~LayoutTestController): (dumpAsTextCallback): (dumpBackForwardListCallback): (dumpChildFramesAsTextCallback): (dumpChildFrameScrollPositionsCallback): (dumpDOMAsWebArchiveCallback): (dumpEditingCallbacksCallback): (dumpFrameLoadCallbacksCallback): (dumpResourceLoadCallbacksCallback): (dumpSelectionRectCallback): (dumpSourceAsWebArchiveCallback): (dumpTitleChangesCallback): (repaintSweepHorizontallyCallback): (setCallCloseOnWebViewsCallback): (setCanOpenWindowsCallback): (setCloseRemainingWindowsWhenCompleteCallback): (testRepaintCallback): (addFileToPasteboardOnDragCallback): (addDisallowedURLCallback): (clearBackForwardListCallback): (decodeHostNameCallback): (displayCallback): (encodeHostNameCallback): (keepWebHistoryCallback): (notifyDoneCallback): (queueBackNavigationCallback): (queueForwardNavigationCallback): (queueLoadCallback): (queueReloadCallback): (queueScriptCallback): (setAcceptsEditingCallback): (setCustomPolicyDelegateCallback): (setMainFrameIsFirstResponderCallback): (setTabKeyCyclesThroughElementsCallback): (setUseDashboardCompatibilityModeCallback): (setUserStyleSheetEnabledCallback): (setUserStyleSheetLocationCallback): (setWindowIsKeyCallback): (waitUntilDoneCallback): (windowCountCallback): (LayoutTestController::makeWindowObject): (LayoutTestController::getLayoutTestControllerJSClass): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h: Replaced.
DumpRenderTree/LayoutTestController.m: Removed.
DumpRenderTree/LayoutTestControllerMac.mm: Added. (LayoutTestController::dumpAsText): (LayoutTestController::dumpBackForwardList): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::dumpChildFrameScrollPositions): (LayoutTestController::dumpDOMAsWebArchive): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpFrameLoadCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::dumpSelectionRect): (LayoutTestController::dumpSourceAsWebArchive): (LayoutTestController::dumpTitleChanges): (LayoutTestController::repaintSweepHorizontally): (LayoutTestController::setCallCloseOnWebViews): (LayoutTestController::setCanOpenWindows): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::testRepaint): (LayoutTestController::addFileToPasteboardOnDrag): (LayoutTestController::addDisallowedURL): (LayoutTestController::clearBackForwardList): (LayoutTestController::decodeHostName): (LayoutTestController::encodeHostName): (LayoutTestController::display): (LayoutTestController::keepWebHistory): (LayoutTestController::notifyDone): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setCustomPolicyDelegate): (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setTabKeyCyclesThroughElements): (LayoutTestController::setUseDashboardCompatibilityMode): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setWindowIsKey): (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]): (LayoutTestController::waitUntilDone): (LayoutTestController::windowCount): Use the JSCore API to implement the LayoutTestController.

DumpRenderTree/ObjCController.h:
DumpRenderTree/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController accessStoredWebScriptObject]): (-[ObjCController storeWebScriptObject:]): (-[ObjCController dealloc]): (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]): Move WebScriptObject tests to ObjCController.

DumpRenderTree/UIDelegate.m: Removed.
DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.

DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h. (WorkQueueItem::~WorkQueueItem): (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script):
DumpRenderTree/WorkQueueItemMac.mm: Added. (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings to avoid conversion until the last possible moment. These changes will be merged with the windows DRT when we start sharing code.

LayoutTests:

Rubber stamped by Darin.

Fix layout tests for new JSCore API based LayoutTestController.

fast/dom/resources/wrapper-identity-base.js: Use ObjCController for objective-c tests.
http/tests/local/file-url-sent-as-referer.html: Remove unused illegal call that now causes controller to fail due to not allowing undefined method calls.
http/tests/xmlhttprequest/default-content-type-dashboard.html: Fix typo in function name.
http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html: Fix typo in function name.
plugins/call-as-function-test-expected.txt:
plugins/call-as-function-test.html: Use ObjCController to test WebScriptObject.
plugins/root-object-premature-delete-crash.html: Use ObjCController to test WebScriptObject
plugins/undefined-property-crash.html: Use ObjCController to test WebScriptObject.
svg/custom/embedded-svg-disallowed-in-dashboard.xml: Fix typo in function name.
svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html: Fix typo in function name.
svg/custom/manually-parsed-svg-disallowed-in-dashboard.html: Fix typo in function name.
svg/custom/svg-disallowed-in-dashboard-object.html: Fix typo in function name.

11:46 AM Changeset in webkit [25514] by staikos

2 edits in trunk/WebCore

2007-09-12 George Staikos <staikos@kde.org>

Fix compilation in some configurations for patch I reviewed and missed
this option on.

platform/qt/CursorQt.cpp: (WebCore::Cursor::Cursor):

11:45 AM Changeset in webkit [25513] by kmccullo

8 edits in trunk/WebKitTools

Reviewed by Maciej.

Updated Win side to take advantage of the platform separating changes.

Drosera/DebuggerDocument.cpp: (DebuggerDocument::localScopeVariableNamesForCallFrame):
Drosera/DebuggerDocument.h:
Drosera/win/DebuggerClient.cpp: (DebuggerClient::pause): (DebuggerClient::resume): (DebuggerClient::stepInto): (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
Drosera/win/DebuggerClient.h:
Drosera/win/Drosera.cpp: (Drosera::Drosera): (Drosera::windowScriptObjectAvailable): (Drosera::initWithServerName): (Drosera::switchToServerNamed):
Drosera/win/Drosera.h:
Drosera/win/Drosera.vcproj/Drosera.vcproj:

11:39 AM Changeset in webkit [25512] by beidson

3 edits
1 delete in trunk/WebCore

Reviewed by Tim Hatcher and Kevin Decker

<rdar://problem/5367045> - Launch time regression due to accessing resource from a different bundle

When the default icon was moved from WebKit to WebCore, we had to access an entirely new bundle on launch which
measurably increased time during launch accessing the disk.

Instead of moving it back to the WebKit bundle, lets make launch time even faster by compiling in the icon.

Resources/urlIcon.tiff: Removed.

WebCore.xcodeproj/project.pbxproj: Removed urlIcon.tiff

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): Compile in the icon data here.

11:15 AM Changeset in webkit [25511] by aroben

2 edits in trunk/WebCore

Always specify that slider thumbs are small when painting with SafariTheme

This is the only size we support.

Reviewed by Sam.

rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):

11:03 AM Changeset in webkit [25510] by beidson

2 edits in trunk/WebCore

Reviewed by Darin

<rdar://problem/5474753> - ASSERT in IconDatabase ReadySQLStatement

loader/icon/IconDatabase.cpp: (WebCore::readySQLStatement): This is a LOG_ERROR situation, not really an ASSERT situation

10:52 AM Changeset in webkit [25509] by aroben

2 edits in trunk/WebCore

Don't ask SafariTheme to draw focus rings around text controls

We do this ourselves.

Reviewed by Oliver.

rendering/RenderThemeSafari.cpp:

10:48 AM Changeset in webkit [25508] by beidson

2 edits in trunk/WebCore

Reviewed by Darin

<rdar://problem/5475639> and http://bugs.webkit.org/show_bug.cgi?id=15185 -
Prevent two WebKits from fighting over the database schema in the future in case it ever changes again

By telling the "older schema" WebKit to simply close itself and not bother to do any icon related stuff
if the database schema is newer, we prevent the possibility of an older webkit run side-by-side with a newer
WebKit causing icon database issues.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Rev the icon database filename to be "WebpageIcons.db" The name is more appropriate for what is actually stored in the file, and since we're already not converting v5 to v6 icons, making this leap now makes sense and gives us a good "future-proof" baseline (WebCore::isValidDatabase): Change the validity check to be "less then" instead of "not equal to" - the "greater than" case is now handled in performOpenInitialization() (WebCore::IconDatabase::performOpenInitialization): If the schema version is greater than the current, then close the database as to not conflict with the newer version. Also noted that the integrity check failure should actually close the sql database, not the icondatabase (WebCore::IconDatabase::syncThreadMainLoop): If termination has already been requested, skip straight to cleanup (WebCore::IconDatabase::cleanupSyncThread): More correctly set the "sync thread running" flag to false here, as the thread can now decide to exit on its own

10:16 AM Changeset in webkit [25507] by treat

2 edits in trunk/WebCore

Patch from Mike Fenton to allow custom cursors.

10:12 AM Changeset in webkit [25506] by oliver

10 edits in trunk/LayoutTests

Rubber stamped by Kevin D.

Fix layout test results effected by turning off <use> entirely

svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
svg/W3C-SVG-1.1/text-text-05-t-expected.png:
svg/W3C-SVG-1.1/text-text-05-t-expected.txt:

Sep 11, 2007:

8:16 PM Changeset in webkit [25505] by kdecker

8 edits
2 adds in trunk

Reviewed by Oliver Hunt.

Fixed: <rdar://problem/5472402> crash due to infinite recursion in expandUseElementsInShadowTree on SVG from wikipedia

ksvg2/svg/SVGUseElement.cpp: Added SVG_EXPERIMENTAL #ifdef for expandUseElementsInShadowTree(). (WebCore::SVGUseElement::buildPendingResource): Ditto. (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements): Tweaked an ASSERT to not fire on non-experimental builds.
ksvg2/svg/SVGUseElement.h: Added SVG_EXPERIMENTAL #ifdef for expandUseElementsInShadowTree().

6:51 PM Changeset in webkit [25504] by sfalken

1 copy in tags/Safari-523.5b

New tag.

4:32 PM Known incompatibilities between open-source WebKit and Safari edited by beidson@apple.com

(diff)

3:44 PM Changeset in webkit [25503] by beidson

4 edits in trunk/WebCore

Reviewed by Maciej

Fix for <rdar://problem/5473046> - Crash when resetting all icons

Originally I'd written the "reset all icons" to be synchronous on the main thread, but it
was decided that it should be async since it involved I/O. Turns out it needs to be... both!
Synchronous removal of all in-memory records of icons, and then continue and clean up the
on-disk database on the background thread.

Also, it turns out that resetting all the page url retain counts should *not* be part of
"reset all icons" because it breaks various contracts the API makes about maintaining retain counts.

The problem that occured here was removing all the icons, then all the history items that were
removed as part of "Reset Safari..." would try to release their icon, but their icon doesn't exist
anymore.

We get around this by simply leaving the in-memory page url records and retain counts alone - they
are still wiped from disk.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::removeAllIcons): Clear in-memory records of all icons then tell the thread to wipe the on-disk tables (WebCore::IconDatabase::removeAllIconsOnThread): Only do the disk cleanup - in-memory maintenance is handled on the main thread (WebCore::IconDatabase::cleanupSyncThread): Now that it's possible for new "icons to be written to disk" to appear while on-disk deleting is occuring, let the cleanup procedure perform 1 final write *after* it does the remove all icons
loader/icon/IconDatabase.h: Removed unused lock and condition

loader/icon/PageURLRecord.cpp: (WebCore::PageURLRecord::setIconRecord): Allow setting a NULL icon record, so a PageURLRecord can be cleared as part of removeAllIcons()

3:13 PM Changeset in webkit [25502] by tristan

2 edits in trunk/WebCore

Reviewed by David Harrison.

<rdar://problem/5467203> CrashTracer: [USER] 1 crash in Mail at <unknown binary>: WebCore::Range::startContainer const

editing/SelectionController.cpp: (WebCore::SelectionController::addRange): (WebCore::SelectionController::setSelectedRange): Added a check to make sure the passed in Range* value is not null before performing operations on it.

2:50 PM Changeset in webkit [25501] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

Remove the unused class_getMethodImplementation function.

Misc/WebNSObjectExtras.h:

1:59 PM Changeset in webkit [25500] by justing

4 edits
2 adds in trunk

WebCore:

Reviewed by Maciej.

<rdar://problem/5458246>
GoogleDocs: A hang occurs when applying list styling to selection that contains a <HR>

List insertion moves selected paragraphs into list items, and relies on the selection
preservation code inside moveParagraphs to iterate over the selected paragraphs.
When list insertion would try to listify a paragraph that came after a list item
containing an <hr>, the selection preservation code would set an incorrect ending
selection because of a TextIterator bug, and we would try to listify the same
paragraph over and over.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Pass range compliant equivalents to the Range constructor here. The position [hr, 0] is not a valid DOM Range endpoint for example.
editing/TextIterator.cpp: (WebCore::shouldEmitSpaceForNode): Added. (WebCore::TextIterator::handleNonTextNode): Emit a space to represent a horizontal rule, since it has VisiblePositions before and after it, but only for TextIterators used for selection preservation, so innerText will be unaffected.

LayoutTests:

Reviewed by Maciej.

editing/execCommand/5458246-expected.txt: Added.
editing/execCommand/5458246.html: Added.

1:57 PM Changeset in webkit [25499] by kmccullo

2 edits
2 moves in trunk/WebKitTools

Reviewed by Adam.

Just doing the moves in a separate patch so the changes are easier to see.

Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
Drosera/win/DebuggerDocumentWin.cpp: Removed.
Drosera/win/DebuggerDocumentWin.h: Removed.
Drosera/win/Drosera.vcproj/Drosera.vcproj:

11:53 AM Changeset in webkit [25498] by ggaren

3 edits in trunk/WebKit

Reviewed by Oliver Hunt.

Fixed CFNetwork version check so it actually works.

Misc/WebKitVersionChecks.h:
WebView/WebView.mm: (+[WebView _setCacheModel:]): Don't use NSVersionOfLinkTimeLibrary because we don't link against CFNetwork directly, so it returns -1. Also, use the proper hex encoding instead of decimal numbers.

11:29 AM Changeset in webkit [25497] by adachan

3 edits in trunk/WebCore

<rdar://problem/5472130> Support NTLM authentication via CFNetwork.

Reviewed by Darin.

platform/network/ProtectionSpace.h: (WebCore::):
platform/network/cf/AuthenticationCF.cpp: (WebCore::createCF): (WebCore::core):

11:11 AM Changeset in webkit [25496] by darin

1 edit in trunk/WebKit/win/WebView.cpp

Roll out accidentally-checked in change.

11:10 AM Changeset in webkit [25495] by darin

3 edits in trunk/WebKit

redo fix for <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery

WebView/WebView.mm: (getMethod): Added. (-[WebView _cacheResourceLoadDelegateImplementations]): Use getMethod. (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.

10:47 AM Changeset in webkit [25494] by darin

5 edits in trunk

WebCore:

Rubber-stamped by Dave Harrison.

fixed pasteboard types here to match WebKit and use constants instead of WebKitSystemInterface

platform/mac/PasteboardMac.mm: Use constants for all pasteboard type strings.

platform/mac/WebCoreSystemInterface.h: Removed wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.

WebKit:

Rubber-stamped by Dave Harrison.

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Removed wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.

9:41 AM Changeset in webkit [25493] by darin

5 edits in trunk/WebKit

Reviewed by Mark Rowe.

fix <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery

Misc/WebNSObjectExtras.h: (class_getMethodImplementation): Added. (method_setImplementation): Added.

WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]):
Carbon/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]): Remove old-ObjC code path, since WebNSObjectExtras.h now implements everything we need.

WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): Don't bother doing a separate respondsToSelector call, since class_getMethodImplementation will return 0 for selectors that we don't respond to. The bug fix is to actually set the cached pointer to 0. Also get rid of the unnecessary use of a macro; instead use the functions from WebNSObjectExtras.h on Tiger and the appropriate function directly on Leopard. (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.

9:35 AM Changeset in webkit [25492] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
http://bugs.webkit.org/show_bug.cgi?id=15176

Scripts/run-launcher: don't replace LD_LIBRARY_PATH with $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve other paths eg. from jhbuild)

9:33 AM Changeset in webkit [25491] by darin

2 edits in trunk/WebKit

Reviewed by Sam, Ollie.

WebView/WebView.mm: (+[WebView _setCacheModel:]): A slightly cleaner 64-bit fix for the NSURLCache capacity code in this file.

9:00 AM Changeset in webkit [25490] by darin

2 edits in trunk/WebKit

Rubber-stamped by Mark Rowe.

Misc/WebNSPasteboardExtras.mm: Fix incorrect strings in my last check-in. The strings I checked in were wrong and were breaking layout tests too. These new ones match what WebKitSystemInterface was returning.

8:03 AM Changeset in webkit [25489] by bdash

4 edits in trunk/WebCore

2007-09-11 Sven Herzberg <sven@imendio.com>

Reviewed by Mark.

Remove unnecessary fields in FontPlatformData
http://bugs.webkit.org/show_bug.cgi?id=15177

platform/gdk/FontDataGdk.cpp: removed the destroy code of the fields that have been removed
platform/gdk/FontPlatformData.h: removed m_fontFace, m_fontMatrix and m_options; hask on m_scaledFont
platform/gdk/FontPlatformDataGdk.cpp: simplified setFont() by using m_scaledFont only; turned the former struct members into local variables

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed