Context Navigation

← Previous Period
Next Period →

Timeline

Sep 15, 2007:

1:45 PM Changeset in webkit [25585] by darin

2 edits in trunk/WebKit

Reviewed by John Sullivan.

fix <rdar://problem/5391540> REGRESSION: Can't drag images from Safari to applications in the dock (Tiger Preview, others in Leopard)

Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): Re-implement code here that has been missing for the last couple of years since we did some image refactoring. Was pretty easy now that we can freely call C++ code in WebKit.

10:58 AM Changeset in webkit [25584] by darin

2 edits in trunk/JavaScriptCore

fix Mac build

JavaScriptCore.exp: Export WTFLogVerbose.

8:34 AM Changeset in webkit [25583] by bdash

2 edits in trunk/WebKitTools

2007-09-15 Mark Rowe <mrowe@apple.com>

Build fix for DumpRenderTree.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.

Sep 14, 2007:

7:41 PM Changeset in webkit [25582] by oliver

2 edits in trunk/WebCore

Reviewed by Adam.

Mac doesn't have any kind of not implemented macro, so we'll actually implement
fileSize.

platform/mac/FileSystemMac.mm: (WebCore::fileSize):

7:26 PM Changeset in webkit [25581] by weinig

5 edits
2 adds in trunk/WebKitTools

Rubber stamped by Adam Roben.

Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.

The UIDelegate was put into a new file while the FrameLoadDelegate was kept in the WaitUntilDoneDelegate file for the time being.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added. (UIDelegate::QueryInterface): (UIDelegate::AddRef): (UIDelegate::Release): (UIDelegate::hasCustomMenuImplementation): (UIDelegate::setFrame): (UIDelegate::webViewFrame): (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::webViewAddMessageToConsole): (UIDelegate::doDragDrop): (UIDelegate::webViewGetDlgCode):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added. (UIDelegate::UIDelegate): (UIDelegate::createWebViewWithRequest): (UIDelegate::webViewShow): (UIDelegate::webViewClose): (UIDelegate::webViewFocus): (UIDelegate::webViewUnfocus): (UIDelegate::webViewFirstResponder): (UIDelegate::makeFirstResponder): (UIDelegate::setStatusText): (UIDelegate::webViewStatusText): (UIDelegate::webViewAreToolbarsVisible): (UIDelegate::setToolbarsVisible): (UIDelegate::webViewIsStatusBarVisible): (UIDelegate::setStatusBarVisible): (UIDelegate::webViewIsResizable): (UIDelegate::setResizable): (UIDelegate::setContentRect): (UIDelegate::webViewContentRect): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): (UIDelegate::runOpenPanelForFileButtonWithResultListener): (UIDelegate::mouseDidMoveOverElement): (UIDelegate::contextMenuItemsForElement): (UIDelegate::validateUserInterfaceItem): (UIDelegate::shouldPerformAction): (UIDelegate::dragDestinationActionMaskForDraggingInfo): (UIDelegate::willPerformDragDestinationAction): (UIDelegate::dragSourceActionMaskForPoint): (UIDelegate::willPerformDragSourceAction): (UIDelegate::contextMenuItemSelected): (UIDelegate::trackCustomPopupMenu): (UIDelegate::measureCustomMenuItem): (UIDelegate::drawCustomMenuItem): (UIDelegate::addCustomMenuDrawingData): (UIDelegate::cleanUpCustomMenuDrawingData): (UIDelegate::canTakeFocus): (UIDelegate::takeFocus): (UIDelegate::registerUndoWithTarget): (UIDelegate::removeAllActionsWithTarget): (UIDelegate::setActionTitle): (UIDelegate::undo): (UIDelegate::redo): (UIDelegate::canUndo): (UIDelegate::canRedo): (UIDelegate::webViewResizerRect): (UIDelegate::webViewDrawResizer): (UIDelegate::webViewScrolled): (UIDelegate::webViewShouldInterruptJavaScript): (UIDelegate::webViewReceivedFocus): (UIDelegate::webViewLostFocus):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::AddRef): (FrameLoadDelegate::Release): (FrameLoadDelegate::didStartProvisionalLoadForFrame): (FrameLoadDelegate::didCommitLoadForFrame): (FrameLoadDelegate::didReceiveTitle): (FrameLoadDelegate::processWork): (processWorkTimer): (FrameLoadDelegate::locationChangeDone): (FrameLoadDelegate::didFinishLoadForFrame): (FrameLoadDelegate::didFailLoadWithError): (FrameLoadDelegate::windowScriptObjectAvailable):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (FrameLoadDelegate::FrameLoadDelegate):

6:43 PM Changeset in webkit [25580] by thatcher

2 edits in trunk/WebCore

Initialize m_dialogArguments to 0. Fixes the newly crashing layout tests.

bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate):

6:25 PM Changeset in webkit [25579] by oliver

3 edits in trunk/WebCore

<rdar://problem/5483632> File system operation wrappers are unimplemented on windows

Implement Windows versions of fileExists and deleteFile.
Also corrects fileSize to use a 64-bit version of stat.

platform/win/FileSystemWin.cpp: (WebCore::fileSize): Renamed argument to be more consistent with others. And converted to _stat32i64 to allow 64-bit filesizes (WebCore::fileExists): (WebCore::deleteFile):
platform/win/TemporaryLinkStubs.cpp:

6:01 PM Changeset in webkit [25578] by weinig

3 edits
1 move
1 add in trunk/WebKitTools

Reviewed by Kevin McCullough.

Move mac specific globals in to mac/DumpRenderTreeMac.h

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.mm: Removed.
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
DumpRenderTree/mac/DumpRenderTreeMac.h: Added.

5:10 PM Changeset in webkit [25577] by oliver

7 edits
1 copy in trunk/WebCore

Need to use _wstat instead of _stat to stat files on windows

_stat doesn't handle multibyte character sequences, unless (afaict)
the current codepage supports them, and then it uses the current
codepage. In order to correctly handle multibyte characters in a
file path we have to use _wstat.

In deference to the fact that the CF implementation may be used on
platforms other than windows i've added fileSize to the FileSystem
helper functions, and added a windows impl.

4:53 PM Changeset in webkit [25576] by thatcher

6 edits
4 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5472970> REGRESSION (r24276): TinyMCE popups show an empty window with no content

Accessing the document of a window before the load finished would cause the window
object to hold onto the initial empty document, and never switch over to the real document
once the load finished. This regression was caused by r24276 which added a check to prevent
clearing the window object when the load finished. The absence of this clear allowed the
dialogArguments set with showModalDialog to persist on the window after the load. However,
not clearing the window would keep other properties (and the empty document object) around.

So the fix is to store away the dialog arguments that were passed to showModalDialog and
put them back on the window object in the dialogArguments property each time
the window is cleared.

bindings/js/kjs_window.cpp: (KJS::createWindow): No longer put dialogArguments on the window here. (KJS::showModalDialog): Put dialogArguments on the window and call setDialogArgumentsAndReturnValueSlot to remember the arguments. (KJS::Window::clear): Put m_dialogArguments back on the window as dialogArguments. (KJS::WindowFunc::callAsFunction): Call the new setDialogArgumentsAndReturnValue. (KJS::Window::setDialogArgumentsAndReturnValue): Store the arguments in m_dialogArguments.
bindings/js/kjs_window.h: Rename setReturnValueSlot to setDialogArgumentsAndReturnValueSlot.
manual-tests/modal-dialog-arguments.html: Confirmed that this test still passes.

Reverted r24276 which was all the changes in FrameLoader.cpp and FrameLoader.h.

loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Remove m_shouldClearWindowProperties. (WebCore::FrameLoader::createWindow): Remove the call to setShouldClearWindowProperties. (WebCore::FrameLoader::clear): No longer check m_shouldClearWindowProperties, clear the window whenever clearWindowProperties is set. (WebCore::FrameLoader::begin): Remove m_shouldClearWindowProperties. (WebCore::FrameLoader::open): Ditto.
loader/FrameLoader.h: Remove m_shouldClearWindowProperties.

LayoutTests:

Reviewed by Sam.

<rdar://problem/5472970> REGRESSION (r24276): TinyMCE popups show an empty window with no content

fast/dom/Document/early-document-access.html: Added.
fast/dom/Document/resources: Added.
fast/dom/Document/resources/early-document-access-popup.html: Added.

3:48 PM Changeset in webkit [25575] by beidson

2 edits in trunk/WebCore

Build fixes work best when they fix *all* platforms

3:40 PM Changeset in webkit [25574] by beidson

3 edits in trunk/WebKitTools

Rubberstamped by Weinig

You know, Sam, some of us use case-sensitve filesystems...

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/mac/UIDelegate.mm:

3:13 PM Changeset in webkit [25573] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by Sam.

Copy JSRetainPtr to include folder.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

2:39 PM Changeset in webkit [25572] by beidson

5 edits in trunk/WebCore

Roll out my previous build fix and just make the stupid thing inline
(I knew there was something easier but oh boy, no coffee yet... weinig?)

2:27 PM Changeset in webkit [25571] by bdash

4 edits in trunk/WebKit

2007-09-14 Mark Rowe <mrowe@apple.com>

Build fix for Tiger.

WebView/WebArchive.m: (-[WebArchive initWithCoder:]): Use @catch(id) rather than @catch(...).
WebView/WebPreferences.m: (-[WebPreferences initWithCoder:]): Ditto.
WebView/WebResource.mm: (-[WebResource initWithCoder:]): Ditto. (-[WebResource _initWithPropertyList:]): Ditto.

2:09 PM Changeset in webkit [25570] by beidson

2 edits in trunk/WebCore

Rubberstamped by Mark Rowe

Add the logging channel I just created to the initialize list on Mac

platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):

2:04 PM Changeset in webkit [25569] by beidson

5 edits in trunk/WebCore

Build fix

That method can't go in the header, apparently

platform/Threading.h:
platform/gdk/TemporaryLinkStubs.cpp: (WebCore::initializeThreading):
platform/mac/Threading.mm: (WebCore::initializeThreading):
platform/qt/TemporaryLinkStubs.cpp: (WebCore::initializeThreading):

1:43 PM Changeset in webkit [25568] by beidson

7 edits
1 add in trunk/WebCore

Reviewed by Darin

-Add callOnMainThread() implementation to Windows

WebCore.vcproj/WebCore.vcproj:

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Call initializeThreading() from the main thread before kicking off the secondary thread

platform/Logging.cpp: Added Threading logging channel (WebCore::):
platform/Logging.h: Ditto

platform/Threading.h: (WebCore::initializeThreading): Added - only needs Windows impl for now
platform/win/ThreadingWin.cpp: Added. (WebCore::callFunctionsOnMainThread): Calls each function currently in the main-thread queue (WebCore::ThreadingWindowWndProc): (WebCore::initializeThreading): Creates a message-only window to use for callOnMainThread() (WebCore::callOnMainThread): Queues the function to be called and posts a message to the threading window such that the function-call-queue can be addressed

platform/win/TemporaryLinkStubs.cpp: (WebCore::signedPublicKeyAndChallengeString):

1:42 PM Changeset in webkit [25567] by darin

5 edits in trunk/WebKit

Reviewed by Geoff Garen and Tim Hatcher.

fixed <rdar://problem/5482745> initFromCoder: and initWithPropertyList: functions should guard against incorrect types

WebView/WebArchive.m: (isArrayOfClass): Added helper function. (-[WebArchive _initWithPropertyList:]): Tweaked function to remove the need for a type cast. (-[WebArchive initWithCoder:]): Added type checking for the main resource, subresources array, and subframe archives array. Also replaced NS_DURING with @try.
WebView/WebPreferences.m: (-[WebPreferences initWithCoder:]): Added type checking for the identifier and the values dictionary, including ensuring that it's a mutable dictionary.
WebView/WebResource.mm: (-[WebResource initWithCoder:]): Added type checking for all the fields. (-[WebResource _initWithPropertyList:]): Added type checking for the NSURLResponse.

WebKit.exp: Removed accidentally exported internal symbol; I checked and it's not used anywhere.

12:37 PM Changeset in webkit [25566] by weinig

6 edits
30 moves
1 add in trunk/WebKitTools

Rubber stamped by Adam Roben.

Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
Move mac specific DumpRenderTree files to DumpRenderTree/mac

DumpRenderTree/AppleScriptController.h: Removed.
DumpRenderTree/AppleScriptController.m: Removed.
DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.mm: (startJavaScriptThreads): (stopJavaScriptThreads): (activateAhemFont): (setDefaultColorProfileToRGB): (makeLargeMallocFailSilently): (dumpFrameScrollPosition): (dumpFramesAsText): (dump): (runTest): (-[DumpRenderTreeWindow isKeyWindow]):
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
DumpRenderTree/EditingDelegate.h: Removed.
DumpRenderTree/EditingDelegate.m: Removed.
DumpRenderTree/EventSendingController.h: Removed.
DumpRenderTree/EventSendingController.m: Removed.
DumpRenderTree/FrameLoadDelegate.h: Removed.
DumpRenderTree/FrameLoadDelegate.mm: Removed.
DumpRenderTree/GCController.mm: Removed.
DumpRenderTree/ImageDiff.m: Removed.
DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpAsTextCallback): (dumpBackForwardListCallback): (dumpChildFramesAsTextCallback): (dumpChildFrameScrollPositionsCallback): (dumpDOMAsWebArchiveCallback): (dumpEditingCallbacksCallback): (dumpFrameLoadCallbacksCallback): (dumpResourceLoadCallbacksCallback): (dumpSelectionRectCallback): (dumpSourceAsWebArchiveCallback): (dumpTitleChangesCallback): (repaintSweepHorizontallyCallback): (setCallCloseOnWebViewsCallback): (setCanOpenWindowsCallback): (setCloseRemainingWindowsWhenCompleteCallback): (testRepaintCallback): (addFileToPasteboardOnDragCallback): (waitUntilDoneCallback):
DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpAsText): (LayoutTestController::setDumpAsText): (LayoutTestController::dumpBackForwardList): (LayoutTestController::setDumpBackForwardList): (LayoutTestController::dumpChildFrameScrollPositions): (LayoutTestController::setDumpChildFrameScrollPositions): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::setDumpChildFramesAsText): (LayoutTestController::dumpDOMAsWebArchive): (LayoutTestController::setDumpDOMAsWebArchive): (LayoutTestController::dumpSelectionRect): (LayoutTestController::setDumpSelectionRect): (LayoutTestController::dumpSourceAsWebArchive): (LayoutTestController::setDumpSourceAsWebArchive): (LayoutTestController::dumpTitleChanges): (LayoutTestController::setDumpTitleChanges): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::setDumpEditingCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::setDumpResourceLoadCallbacks): (LayoutTestController::dumpFrameLoadCallbacks): (LayoutTestController::setDumpFrameLoadCallbacks): (LayoutTestController::addFileToPasteboardOnDrag): (LayoutTestController::setAddFileToPasteboardOnDrag): (LayoutTestController::callCloseOnWebViews): (LayoutTestController::setCallCloseOnWebViews): (LayoutTestController::canOpenWindows): (LayoutTestController::setCanOpenWindows): (LayoutTestController::closeRemainingWindowsWhenComplete): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::testRepaint): (LayoutTestController::setTestRepaint): (LayoutTestController::testRepaintSweepHorizontally): (LayoutTestController::setTestRepaintSweepHorizontally): (LayoutTestController::waitToDump): (LayoutTestController::windowIsKey):
DumpRenderTree/LayoutTestControllerMac.mm: Removed.
DumpRenderTree/NavigationController.h: Removed.
DumpRenderTree/NavigationController.m: Removed.
DumpRenderTree/ObjCController.h: Removed.
DumpRenderTree/ObjCController.m: Removed.
DumpRenderTree/ObjCPlugin.h: Removed.
DumpRenderTree/ObjCPlugin.m: Removed.
DumpRenderTree/ObjCPluginFunction.h: Removed.
DumpRenderTree/ObjCPluginFunction.m: Removed.
DumpRenderTree/PolicyDelegate.h: Removed.
DumpRenderTree/PolicyDelegate.m: Removed.
DumpRenderTree/ResourceLoadDelegate.h: Removed.
DumpRenderTree/ResourceLoadDelegate.m: Removed.
DumpRenderTree/TextInputController.h: Removed.
DumpRenderTree/TextInputController.m: Removed.
DumpRenderTree/UIDelegate.h: Removed.
DumpRenderTree/UIDelegate.mm: Removed.
DumpRenderTree/WorkQueueItemMac.mm: Removed.
DumpRenderTree/mac: Added.
DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m. (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm. (-[FrameLoadDelegate init]): (-[FrameLoadDelegate dealloc]): (-[FrameLoadDelegate processWork:]): (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm. (LayoutTestController::notifyDone): (LayoutTestController::setWindowIsKey): (LayoutTestController::setWaitToDump):
DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m. (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm. (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): (-[UIDelegate webViewFocus:]): (-[UIDelegate webView:createWebViewWithRequest:]): (-[UIDelegate webViewClose:]):
DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.

11:04 AM Changeset in webkit [25565] by andersca

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5316743>
Safari does not handle filename parameter of content-disposition

Use CFURLResponseCopySuggestedFilename instead of our own hand-rolled implementation.

While we do return the correct filename in all cases I've tried, using CFNetwork is better because
it might handle corner cases that we don't.

platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):

11:02 AM Changeset in webkit [25564] by kmccullo

6 edits in trunk/WebKitTools

Reviewed by Adam.

Changing Win version of Drosera work with recent changes.

Drosera/DebuggerDocument.cpp:
Drosera/DebuggerDocument.h:
Drosera/mac/DebuggerDocumentPlatform.mm: (NSStringCreateWithJSStringRef): (JSValueRefCreateWithNSString):
Drosera/win/DebuggerClient.cpp: (DebuggerClient::stepInto):
Drosera/win/Drosera.vcproj/Drosera.vcproj:

10:06 AM Changeset in webkit [25563] by ggaren

6 edits
2 adds in trunk

WebCore:

Reviewed by Adam Roben.

Fixed http://bugs.webkit.org/show_bug.cgi?id=15209
Sometimes removing an iframe from the DOM does not remove its frame
from the page

loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use the contentFrame pointer directly instead of searching for a frame by the frame element's name, because the frame element's name may have changed. (Another reason to do this is that it's just plain more straight-forward and efficient.)

LayoutTests:

Reviewed by Adam Roben.

Layout test for http://bugs.webkit.org/show_bug.cgi?id=15209
Sometimes removing an iframe from the DOM does not remove its frame
from the page.

fast/frames/iframe-remove-after-id-change-expected.txt: Added.
fast/frames/iframe-remove-after-id-change.html: Added.

Updated results in this test. New results indicate that the frame's
contents are preserved between removal and reinsertion, which matches
Firefox.

fast/frames/iframe-option-crash-expected.checksum:
fast/frames/iframe-option-crash-expected.png:
fast/frames/iframe-option-crash-expected.txt:
fast/frames/iframe-option-crash.xhtml:

8:38 AM Changeset in webkit [25562] by darin

3 edits
4 adds in trunk

WebCore:

Reviewed by Mitz and Kevin Decker.

fix http://bugs.webkit.org/show_bug.cgi?id=15197 <rdar://problem/5478271> REGRESSION: Some Yahoo text entry fields render as lines rather than text entry boxes

Test: fast/forms/textarea-rows-cols.html

html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Use constants for the default number of rows and columns. (WebCore::HTMLTextAreaElement::parseMappedAttribute): If rows/cols attribute has a value that's missing, non-numeric, or zero, then use the default value. Also check for the case where the effective value of the attribute isn't changing.

LayoutTests:

Reviewed by Mitz and Kevin Decker.

test for http://bugs.webkit.org/show_bug.cgi?id=15197 <rdar://problem/5478271> REGRESSION: Some Yahoo text entry fields render as lines rather than text entry boxes