⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 16, 2007:

5:09 PM Changeset in webkit [25591] by weinig
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14693
document.width/height doesn't force layout

Test: fast/dom/document-width-height-force-layout.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::width): Force layout. (WebCore::HTMLDocument::height): ditto.
  • html/HTMLDocument.h:

LayoutTests:

Reviewed by Maciej.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14693

  • fast/dom/document-width-height-force-layout-expected.txt: Added.
  • fast/dom/document-width-height-force-layout.html: Added.
1:52 PM Changeset in webkit [25590] by zecke
  • 3 edits in trunk/WebCore

2007-09-14 Sven Herzberg <​sven@imendio.com>

Reviewed by George.

Don't maintain obsolete code, fixes:
​http://bugs.webkit.org/show_bug.cgi?id=15215

  • platform/gdk/FontPlatformData.cpp: remove static FontPlatformData::list() (isn't used at any place)
12:58 PM Changeset in webkit [25589] by zecke
  • 4 edits in trunk

WebCore:

2007-09-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Use the new WebCore::String::fromUTF8 function to create
the labels.

  • platform/gdk/LocalizedStringsGdk.cpp: (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText):

WebKit:
2007-09-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Use the new WebCore::String::fromUTF8 function to convert
from the Gtk+ representation of a string to WebCore::String.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runJavaScriptPrompt):
12:58 PM Changeset in webkit [25588] by zecke
  • 3 edits in trunk/WebCore

2007-09-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Add WebCore::String::fromUTF8 to convert from UTF-8
to a WebCore::String. This is meant to be used by
the Gtk+ port and the signature and implementation
is similiar to the one of DeprecatedString.

  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::fromUTF8):
12:58 PM Changeset in webkit [25587] by zecke
  • 3 edits
    1 add in trunk/WebCore

2007-09-13 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Anders.

Implement the fileExists and deleteFile functions
using glib.

  • WebCore.pro:
  • platform/gdk/FileSystemGdk.cpp: Added. (WebCore::fileExists):
  • platform/gdk/TemporaryLinkStubs.cpp:
10:04 AM Changeset in webkit [25586] by harrison
  • 14 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5472125> REGRESSION (9A535-9A548): No VO cursor shown when navigating in a mail message body

The problem was that the visible units code was mishandling non-editable content, generating null
VisiblePositions instead of the actual boundary VisiblePositions.


Updated tests:

  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/dom/plugin-attributes-enumeration-expected.txt:
  • fast/events/onerror-bubbling-expected.txt:
  • fast/events/related-target-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/table/incomplete-table-in-fragment-2-expected.txt:
  • fast/table/incomplete-table-in-fragment-hang-expected.txt:
  • fast/table/large-rowspan-crash-expected.txt:
  • plugins/embed-attributes-setting-expected.txt:


Source Changes:

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::honorEditableBoundaryAtOrBefore): (WebCore::VisiblePosition::honorEditableBoundaryAtOrAfter): Rename firstEditablePositionAtOrAfter to honorEditableBoundaryAtOrAfter. Rename firstEditablePositionAtOrBefore to honorEditableBoundaryAtOrBefore. Changed these two functions to handle non-editable positions.


  • editing/VisiblePosition.h:
  • editing/visible_units.cpp: (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::positionAvoidingFirstPositionInTable): (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Rename firstEditablePositionAtOrAfter to honorEditableBoundaryAtOrAfter. Rename firstEditablePositionAtOrBefore to honorEditableBoundaryAtOrBefore. Also, startOfLine() now calls positionAvoidingFirstPositionInTable() in the empty block early return case. positionAvoidingFirstPositionInTable() was the logic startOfLine() used in the normal case. Now in a reusable function.

LayoutTests:

Reviewed by Darin.

Updated for
<rdar://problem/5472125> REGRESSION (9A535-9A548): No VO cursor shown when navigating in a mail message body


Newlines are now emitted when the first content of document is block element without text (like an empty table
or an HR), followed by text.


  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/dom/plugin-attributes-enumeration-expected.txt:
  • fast/events/onerror-bubbling-expected.txt:
  • fast/events/related-target-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/table/incomplete-table-in-fragment-2-expected.txt:
  • fast/table/incomplete-table-in-fragment-hang-expected.txt:
  • fast/table/large-rowspan-crash-expected.txt:
  • plugins/embed-attributes-setting-expected.txt:

Sep 15, 2007:

1:45 PM Changeset in webkit [25585] by darin
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • fix <rdar://problem/5391540> REGRESSION: Can't drag images from Safari to applications in the dock (Tiger Preview, others in Leopard)
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): Re-implement code here that has been missing for the last couple of years since we did some image refactoring. Was pretty easy now that we can freely call C++ code in WebKit.
10:58 AM Changeset in webkit [25584] by darin
  • 2 edits in trunk/JavaScriptCore
  • fix Mac build
8:34 AM Changeset in webkit [25583] by bdash
  • 2 edits in trunk/WebKitTools

2007-09-15 Mark Rowe <​mrowe@apple.com>

Build fix for DumpRenderTree.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
Note: See TracTimeline for information about the timeline view.