⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 18, 2007:

11:14 PM Changeset in webkit [25635] by beidson
  • 9 edits in trunk/WebKit/win

Reviewed by Adam

Final part of <rdar://problem/5471308> - Hook up async icon database on Windows

  • CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Took the opportunity to rewrite with a RetainPtr since it became available after the initial implementation (CFDictionaryPropertyBag::setDictionary): (CFDictionaryPropertyBag::dictionary): Added accessor to the CFDictionaryRef to ease use within WebKit (CFDictionaryPropertyBag::QueryInterface): Added IID_CFDictionaryPropertyBag accessor (CFDictionaryPropertyBag::Read): (CFDictionaryPropertyBag::Write):
  • CFDictionaryPropertyBag.h: Added IID_CFDictionaryPropertyBag


  • WebFrame.cpp: (WebFrame::url): Added accessor, gets the current URL from WebCore (WebFrame::dispatchDidReceiveIcon): Calls through to the WebView (WebFrame::registerForIconNotification): Ditto
  • WebFrame.h:
  • WebIconDatabase.cpp: (WebIconDatabase::iconDatabaseDidAddIconNotification): (WebIconDatabase::iconDatabaseNotificationUserInfoURLKey): (WebIconDatabase::iconDatabaseDidRemoveAllIconsNotification): (postDidRemoveAllIconsNotification): (postDidAddIconNotification):
  • WebIconDatabase.h:
  • WebView.cpp: (WebView::close): Unregister for the notification, just in case (WebView::notifyDidAddIcon): Called when the webview gets the didAddIcon notification, compares the url in the notification to the current main frame URL. If they match, calls to dispatchDidReceiveIconFromWebFrame (WebView::registerForIconNotification): (WebView::dispatchDidReceiveIconFromWebFrame): Dispatches the FrameLoadDelegate call. Once the delegate call is dispatched, either via the FrameLoaderClient interface of by listening for a notification, we know that our info is up to date in the IconDatabase and we don't need to listen for the generic notification any long, so we unregister for it here, as well. (WebView::onNotify): The WebView listens for two notifications now, so make the decision which was received
  • WebView.h:
6:39 PM Changeset in webkit [25634] by thatcher
  • 8 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5478250> REGRESSION: After pasting text copied from Mail subject and typing return, the cursor disappears because of negative left margin

When pasting text from the Mail subject line, the RTF pasteboard contains text that has a first line negative indent along with a
paragraph indent that has a counteracting positive indent. This results in the first line being flush left justified, and the remaining
wrapped lines being indented. When this is converted to a DOM fragment, AppKit makes a block element with a margin-left and a negative
text-indent that matches the RTF. So far this is all correct behavior.

When this content is pasted on the line of an existing paragraph that has content, ReplaceSelectionCommand will decided to merge the paragraphs.
This will convert the block element to a style span that has all inherited style properties. These inherited properties will still contain block
properties that have no affect on inline elements. These block properties will hang around on the style span and will get cloned to new block
elements if the user hit return on that line. The new block elements would then have the text-indent but not the margin-left, so the text would be
hidden off the left edge of the page.

In the end, we should never hang on to block-only properties in our style spans. This cuts out meaningless properties and prevents properties
from magically affecting blocks later if the style is cloned for a new block element during a future editing operation.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Remove any inherited block properties that are now in the span's style.
  • editing/markup.cpp: (WebCore::createMarkup): Ditto.

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5478250> REGRESSION: After pasting text copied from Mail subject and typing return, the cursor disappears because of negative left margin

  • editing/pasteboard/5478250.html: Added.
  • platform/mac/editing/pasteboard/5478250-expected.txt: Added.

Updated results that are affected by the style span being removed or added with different style properties.

  • editing/execCommand/5144139-1-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/styled-element-markup-expected.txt:
5:04 PM Changeset in webkit [25633] by ggaren
  • 2 edits in trunk/WebKitLibraries

Build fix. Ran update-webkitsysteminterface script on Tiger, because
the resulting binary differs when built on Tiger. See
<rdar://problem/5490613>.

  • libWebKitSystemInterface.a:
4:47 PM Changeset in webkit [25632] by hyatt
  • 2 edits
    2 adds in trunk/WebCore

Land a new UnicodeRange helper class that will be used to determine languages for fonts.

4:12 PM Changeset in webkit [25631] by beidson
  • 3 edits in trunk/WebKit/win

Reviewed by Ada and Geoff

Part of <rdar://problem/5471308> - Get async Icon Database fully hooked up on Windows


Hook up main thread delivery of Icon Database notifications from the secondary thread


  • WebIconDatabase.cpp: (WebIconDatabase::WebIconDatabase): Initialize m_deliveryRequested (WebIconDatabase::init): Set the IconDatabaseClient to the shared WebIconDatabase (WebIconDatabase::dispatchDidRemoveAllIcons): Queue the notification to be delivered on the main thread then ask for the delivery (WebIconDatabase::dispatchDidAddIconForPageURL): Ditto (WebIconDatabase::scheduleNotificationDelivery): If the m_deliveryRequested hasn't been set, then set it and perform the callOnMainThread() for WebIconDatabase::deliverNotifications (postDidRemoveAllIconsNotification): (postDidAddIconNotification): (WebIconDatabase::deliverNotifications): Deliver all notifications in the current queue
  • WebIconDatabase.h:
3:59 PM Changeset in webkit [25630] by weinig
  • 1 edit in trunk/WebKitTools/DumpRenderTree/win/GCControllerWin.cpp

Touch file in DRT to recompile it now. Frowny-face.

3:54 PM Changeset in webkit [25629] by ggaren
  • 3 edits in trunk/WebKitLibraries

Build fix. Ran update-webkitsysteminterface script.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
3:25 PM Changeset in webkit [25628] by aroben
  • 1 copy in tags/Safari-523.6.1b

New tag.

3:25 PM Changeset in webkit [25627] by aroben
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

3:23 PM Changeset in webkit [25626] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.


Fixed <rdar://problem/5490204> In some cases, WebKit can make the
Foundation disk cache way too big or way too small


Use the actual location of the foundation disk cache, rather than
the user's home directory, when determining how big to make it.

  • WebView/WebView.mm: (+[WebView _setCacheModel:]):
3:16 PM Changeset in webkit [25625] by weinig
  • 1 edit in trunk/JavaScriptCore/kjs/CommonIdentifiers.cpp

Touch JavaScriptCore file to force rebuild.

2:34 PM Changeset in webkit [25624] by hyatt
  • 2 edits in trunk/WebCore

Fix some HDC badness with my previous checkin.

2:32 PM Changeset in webkit [25623] by weinig
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Patch for <rdar://problem/5488478> Safari crashes when passing null to Range.insertNode()

Test: fast/dom/Range-insertNode-crash.html

  • dom/Range.cpp: (WebCore::Range::insertNode): Null check the passed in node to insert.

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5488478> Safari crashes when passing null to Range.insertNode()

  • fast/dom/Range-insertNode-crash-expected.txt: Added.
  • fast/dom/Range-insertNode-crash.html: Added.
1:59 PM Changeset in webkit [25622] by weinig
  • 2 edits in trunk/WebKitTools

Add JSRetainPtr.h #include to fix some builds.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
1:58 PM Changeset in webkit [25621] by staikos
  • 2 edits in trunk/WebCore

2007-09-18 Mike Fenton <​mike@staikos.net>

Reviewed by George Staikos.

Retain the pen properties when changing one aspect of the pen.

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor):
1:55 PM Changeset in webkit [25620] by staikos
  • 2 edits in trunk/WebCore

2007-09-18 Mike Fenton <​mike@staikos.net>

Reviewed by George Staikos.

Make <canvas> work in more cases by restarting the painter after we
finish painting, and restoring the pen and opacity.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
11:33 AM Changeset in webkit [25619] by weinig
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/dom/CSSStyleDeclaration-empty-string-property.html

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName): Added an early return if the property name is the empty string, thus avoiding a loop that is not prepared for that case.

LayoutTests:

Reviewed by Darin.

  • fast/dom/CSSStyleDeclaration-empty-string-property-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration-empty-string-property.html: Added.
10:52 AM Changeset in webkit [25618] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • fix <rdar://problem/5415734> <select> dras incorrectly if size of menu options is changed after it pops up once
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Removed unnecessary initialization of IntRect. (WebCore::PopupMenu::show): Check that the clientRect is empty instead of checking the entire windowRect -- this fixes a bug where we pop up a tiny 2-pixel high black box when you click on an empty menu. (WebCore::PopupMenu::visibleItems): Base the number of items on the client rect instead of the window rect. Rounding down means this would have worked anyway, but it's more correct to do it this way. (WebCore::PopupMenu::paint): Deallocate the bitmap so it gets reallocated if it has the wrong width or height (or if GetObject returns false, which should not happen in practice).
10:23 AM Changeset in webkit [25617] by harrison
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5486974> REGRESSION(r25373): 1/4 second to doubleclick word in GMail when using Kotoeri IM, also slow in other IMs (15163)

Updated tests:

  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/dom/plugin-attributes-enumeration-expected.txt:
  • fast/events/onerror-bubbling-expected.txt:
  • fast/events/related-target-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/table/incomplete-table-in-fragment-2-expected.txt:
  • fast/table/incomplete-table-in-fragment-hang-expected.txt:
  • fast/table/large-rowspan-crash-expected.txt:
  • plugins/embed-attributes-setting-expected.txt:
  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Avoid VisiblePosition check if the current node is a descendant of the start container and the start offset was 0. In that case we already had enough context to correctly decide whether to emit a newline after a preceding block. We chose not to emit (m_haveEmitted is false), so don't second guess that.


(WebCore::TextIterator::exitNode):
Changed some comments.

LayoutTests:

Reviewed by Darin.

Updated for:
<rdar://problem/5486974> REGRESSION(r25373): 1/4 second to doubleclick word in GMail when using Kotoeri IM, also slow in other IMs (15163)

NOTE: This reverts the test result changes I made for rdar://5472125, back to not emitting
a newline for collapsed block or hr at start of range.


  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/dom/plugin-attributes-enumeration-expected.txt:
  • fast/events/onerror-bubbling-expected.txt:
  • fast/events/related-target-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/table/incomplete-table-in-fragment-2-expected.txt:
  • fast/table/incomplete-table-in-fragment-hang-expected.txt:
  • fast/table/large-rowspan-crash-expected.txt:
  • plugins/embed-attributes-setting-expected.txt:
6:55 AM Changeset in webkit [25616] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

  • Scripts/prepare-ChangeLog:
  • Properly parse GECOS field.
  • Use git configuration for user name and email when appropriate.

Sep 17, 2007:

11:08 PM Changeset in webkit [25615] by weinig
  • 2 edits in trunk/WebKitTools

Build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
10:56 PM Changeset in webkit [25614] by weinig
  • 4 edits
    3 moves
    1 delete in trunk/WebKitTools

Reviewed by Adam Roben.

Share more code between mac and windows DRT.

  • GCController is now shared.
  • Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
  • DumpRenderTree/GCController.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp. (FrameLoadDelegate::FrameLoadDelegate): (FrameLoadDelegate::~FrameLoadDelegate): (FrameLoadDelegate::windowScriptObjectAvailable):
  • DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
  • DumpRenderTree/win/GCController.cpp: Removed.
  • DumpRenderTree/win/GCController.h: Removed.
  • DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp. (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
  • DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
  • DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
7:44 PM Changeset in webkit [25613] by weinig
  • 7 edits
    3 moves
    4 deletes in trunk/WebKitTools

Reviewed by Adam Roben.

Begin sharing code between mac and windows DRT.

  • both now share LayoutTestController.h/cpp and implement platform dependant operations in LayoutTestControllerMac/Win.
  • DumpRenderTree.h is now shared.
  • WorkQueue and WorkQueueItem are also shared.
  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp: (displayWebView): (dumpFrameScrollPosition): (dumpFramesAsText): (dump): (runTest):
  • DumpRenderTree/win/DumpRenderTree.h: Removed.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
  • DumpRenderTree/win/EditingDelegate.cpp: (EditingDelegate::shouldBeginEditingInDOMRange): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): (EditingDelegate::shouldInsertText): (EditingDelegate::shouldDeleteDOMRange): (EditingDelegate::shouldChangeSelectedDOMRange): (EditingDelegate::shouldApplyStyle): (EditingDelegate::shouldChangeTypingStyle): (EditingDelegate::doPlatformCommand): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
  • DumpRenderTree/win/LayoutTestController.cpp: Removed.
  • DumpRenderTree/win/LayoutTestController.h: Removed.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp. (LayoutTestController::addDisallowedURL): (LayoutTestController::clearBackForwardList): (LayoutTestController::copyDecodedHostName): (LayoutTestController::copyEncodedHostName): (LayoutTestController::display): (LayoutTestController::keepWebHistory): (LayoutTestController::notifyDone): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (jsStringRefToWString): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setCustomPolicyDelegate): (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setTabKeyCyclesThroughElements): (LayoutTestController::setUseDashboardCompatibilityMode): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setWindowIsKey): (waitUntilDoneWatchdogFired): (LayoutTestController::setWaitToDump): (LayoutTestController::windowCount):
  • DumpRenderTree/win/WaitUntilDoneDelegate.cpp: (FrameLoadDelegate::didReceiveTitle): (FrameLoadDelegate::processWork): (FrameLoadDelegate::locationChangeDone): (FrameLoadDelegate::windowScriptObjectAvailable):
  • DumpRenderTree/win/WorkQueue.cpp: Removed.
  • DumpRenderTree/win/WorkQueue.h: Removed.
  • DumpRenderTree/win/WorkQueueItem.cpp: Removed.
  • DumpRenderTree/win/WorkQueueItem.h: Removed.
  • DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp. (jsStringRefToWString): (LoadItem::invoke): (ScriptItem::invoke):
7:11 PM Changeset in webkit [25612] by ggaren
  • 8 edits in trunk

WebCore:

Reviewed by Darin Adler.

Speculative fix for <rdar://problem/5479443> REGRESSION: Hang due to
infinite JS recursion on close @ engadget.com (onunload-based ad)


If page is NULL, shouldInterruptScript now returns true, so you can't
get stuck in a state in which a script executes forever without putting
up a UI to ask if it should stop.

  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):

WebKit:

Reviewed by Darin Adler.

Fixed a hang due to an infinite script running in the window's unload
event handler, which may be the cause of <rdar://problem/5479443>
REGRESSION: Hang due to infinite JS recursion on close @ engadget.com
(onunload-based ad)

  • WebView/WebUIDelegatePrivate.h: Added FIXME.


  • WebView/WebView.h: Clarified headerdoc ambiguity about when delegate methods stop firing.
  • WebView/WebView.mm: (-[WebView _close]): The fix: don't nil out our delegates until after detaching the FrameLoader, because the act of detaching the FrameLoader might fire important delegate methods, like webViewShouldInterruptJavaScript:. Don't do other tear-down either, because the unload event handler needs to run in a fully constructed page.


This change is fairly low risk because niling out our delegates is a
very recent, never-shipped feature in WebKit, so it's unlikely that any
apps rely on it in a crazy way.

win:

Reviewed by Darin Adler.

Fixed a hang due to an infinite script running in the window's unload
event handler, which may be the cause of <rdar://problem/5479443>
REGRESSION: Hang due to infinite JS recursion on close @ engadget.com
(onunload-based ad)


Added a bunch of WebKitMac's close features, and reordered others to
match WebKitMac.

  • WebView.cpp: (WebView::close): (WebView::removeDragCaret):
5:36 PM Changeset in webkit [25611] by hyatt
  • 5 edits in trunk/WebCore

Fix for 14743, missing glyphs because of mlang's tiny font cache.

5:30 PM Changeset in webkit [25610] by aroben
  • 3 edits
    1 add in trunk/WebCore

Fix <rdar://5423441> Should get focus ring color from SafariTheme

Reviewed by Hyatt.

No regression test possible.

  • WebCore.vcproj/WebCore.vcproj: Added ColorSafari.cpp.
  • platform/graphics/win/ColorSafari.cpp: Added. (WebCore::makeRGBAFromCGColor): Added. (WebCore::focusRingColor): Added. Gets the focus ring color from SafariTheme if SafariTheme has support for it. (WebCore::setFocusRingColorChangeFunction): Added.
  • platform/win/TemporaryLinkStubs.cpp: Removed focus ring color functions.
5:27 PM Changeset in webkit [25609] by andersca
  • 3 edits in trunk/WebCore

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
  • loader/NetscapePlugInStreamLoader.h:
5:22 PM Changeset in webkit [25608] by andersca
  • 3 edits
    1 copy in trunk/WebCore

Fix Mac build.


  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/win/NetscapePlugInStreamLoaderWin.cpp: Copied from loader/NetscapePlugInStreamLoader.cpp.
5:11 PM Changeset in webkit [25607] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5483346>
crash at vw.com WebCore::PluginViewWin::disconnectStream.


The following events would lead to this crash:


  1. a plug-in stream finishes loading and calls NPP_DestroyStream.
  2. the DestroyStream handler calls NPN_Evaluate, submitting a form through JavaScript.
  3. A new page is going to be loaded and DocumentLoader::stopLoading is called.
  4. DocumentLoader::stopLoading will stop all loader, including the one that is done loading!


The fix is to port NetscapePluginStreamLoader over from the Mac code and use it instead. This fixes the crash
because it disassociates the stream loader with the document loader _before_ calling NPP_DestroyStream, whereas
SubresourceLoader does this _after_ calling NPP_DestroyStream.


  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::~NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::create): (WebCore::NetscapePlugInStreamLoader::isDone): (WebCore::NetscapePlugInStreamLoader::releaseResources): (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): (WebCore::NetscapePlugInStreamLoader::didReceiveData): (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
  • loader/NetscapePlugInStreamLoader.h: (WebCore::NetscapePlugInStreamLoaderClient::didFinishLoading):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFail): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load):
5:06 PM Changeset in webkit [25606] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5483839>
Crash loading ​http://www.microsoft.com if Silverlight 1.0 is installed.


Work around a problem in our NPRuntime implementation by never unloading the silverlight plug-in dll.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::determineQuirks):
  • plugins/win/PluginViewWin.h: (WebCore::):
4:41 PM Changeset in webkit [25605] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Having bad Changelog composition issues today

4:38 PM Changeset in webkit [25604] by beidson
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15178
and
<rdar://problem/5474001>

The stress test proves that this was an overzealous ASSERT. It is very possible to mark and icon
for addition to the on-disk database and then mark it for removal before it is ever added. This
is not an error and was already handled gracefully

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::removeIconFromSQLDatabase): Don't ASSERT of log if the icon wasn't on disk
3:59 PM Changeset in webkit [25603] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Oliver

<rdar://problem/5487048> - ASSERT in stress test in IconDatabase

If a PageURLRecord went away, it never clears its URL from the IconRecord it retained.

  • loader/icon/PageURLRecord.cpp: (WebCore::PageURLRecord::~PageURLRecord): Set the icon record to 0, clearing the page url
  • loader/icon/PageURLRecord.h: Add the destructor
3:55 PM Changeset in webkit [25602] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

That Changelog was HORRIBLE

3:54 PM Changeset in webkit [25601] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Oliver

<rdar://problem/5487048> - ASSERT in stress test in IconDatabase

If a PageURLRecord went away, it never clear it's URL from the IconRecord it retained.

  • loader/icon/PageURLRecord.cpp: (WebCore::PageURLRecord::~PageURLRecord): Set the icon record to 0, clearing the page url
  • loader/icon/PageURLRecord.h: Add the destructor
2:34 PM Changeset in webkit [25600] by aroben
  • 2 edits in trunk/WebKit/win

Fix <rdar://4979801> overflow divs don't respond to keyboard scrolling (affects RSS pages)

Reviewed by Hyatt.

  • WebView.cpp: (WebView::keyDown): Attempt to scroll an overflow area before scrolling the whole frame.
1:43 PM Changeset in webkit [25599] by beidson
  • 1 edit in trunk/WebKit/win/WebKitDLL.cpp

Didn't save this line before checking in *sigh*

1:42 PM Changeset in webkit [25598] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5480050>
Leopard9A551 with Dashcode 112: Dashcode crash when dragging image into canvas.


If @import stylesheet was modified through CSS DOM style selector would not get updated. This
could lead to crashes.

Test: fast/css/import-style-update.html

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::styleSheetChanged):

LayoutTests:

Reviewed by Darin.


Test for <rdar://problem/5480050>
Leopard9A551 with Dashcode 112: Dashcode crash when dragging image into canvas.


Non-crashing test case, but it demonstrates the same problem that would crash
under some circumstances.

  • fast/css/import-style-update-expected.txt: Added.
  • fast/css/import-style-update.html: Added.
1:41 PM Changeset in webkit [25597] by beidson
  • 2 edits in trunk/WebKit/win

Reviewed by Adam


<rdar://problem/5471308> - Get async Icon Database fully hooked up on Windows


Add a global "shut down WebKit" procedure to do cleanup at the engine level on quit.
Critical now for the IconDatabase and might be for other things in the future.

  • WebKitDLL.cpp: (shutDownWebKit): For now, just close the IconDatabase (DllMain): On DLL_PROCESS_DETACH, call shutDownWebKit
11:53 AM Changeset in webkit [25596] by weinig
  • 2 edits in trunk/WebKitTools/DumpRenderTree

Add svn:ignore for moved directories

11:48 AM Changeset in webkit [25595] by weinig
  • 3 edits
    25 copies
    1 add
    1 delete in trunk/WebKitTools

Reviewed by Adam Roben.

  • Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
  • DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
  • DumpRenderTree/DumpRenderTree.vcproj: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
  • DumpRenderTree/win: Added.
  • DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
  • DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
  • DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
  • DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
  • DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
  • DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
  • DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
  • DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
  • DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
  • DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
  • DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
  • DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
  • DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
  • DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
  • DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
  • DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
  • DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
  • DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
  • DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
  • DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
  • DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
  • DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
  • Scripts/run-webkit-tests: Update to point to the new location of the sln.
11:01 AM Changeset in webkit [25594] by andersca
  • 9 edits in trunk

WebCore:

Reviewed by Adam.

<rdar://problem/5421997>
​http://bugs.webkit.org/show_bug.cgi?id=14247
Display problem with Flash - image does not stop changing


Port the manual load code over from the Mac version.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView):
  • plugins/win/PluginDatabaseWin.h: Add load manually parameter.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::stop): If we're loading manually, cancel the main resource load.


(WebCore::PluginStreamWin::destroyStream):
Don't disconnect the stream if we're loading manually.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry): Always call updateWindow()


(WebCore::PluginViewWin::PluginViewWin):
Initialize loadManually.


(WebCore::PluginViewWin::init):
Don't set the width and height of the window here since it will make the plug-in HWND show briefly
before it's been positioned.


(WebCore::PluginViewWin::didReceiveResponse):
Create the manual stream.


(WebCore::PluginViewWin::didReceiveData):
(WebCore::PluginViewWin::didFinishLoading):
(WebCore::PluginViewWin::didFail):
Call through to the manual stream.


  • plugins/win/PluginViewWin.h:

win:

Reviewed by Adam.

<rdar://problem/5421997>
​http://bugs.webkit.org/show_bug.cgi?id=14247
Display problem with Flash - image does not stop changing

Port the manual load code over from the Mac version.

  • WebFrame.cpp: (WebFrame::WebFramePrivate::WebFramePrivate): Initialize the plugin pointer.


(WebFrame::finishedLoading):
(WebFrame::setMainDocumentError):
(WebFrame::committedLoad):
Feed the data to the plug-in.


(WebFrame::redirectDataToPlugin):
Store the plug-in widget.

7:57 AM Changeset in webkit [25593] by zecke
  • 4 edits in trunk/WebKit/gtk

2007-09-17 Cyril Brulebois <​cyril.brulebois@enst-bretagne.fr>

Reviewed by Mark, some Coding Style changes by Holger.

This is from ​http://bugs.webkit.org/show_bug.cgi?id=14812.

Add title and location to WebKitGtkFramePrivate, add
webkit_gtk_frame_get_location to the WebKitGtkFrame API as well
as a title_changed callback, implement
webkit_gtk_frame_get_title and webkit_gtk_frame_get_location.

Initial patch by Diego Escalante Urrelo.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkprivate.h:
7:56 AM Changeset in webkit [25592] by zecke
  • 2 edits in trunk/WebCore

2007-09-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Convert the filenames from WebCore::String to the filesystem encoding
and vice versa using g_filename_{from,to}_utf8 functions. Also add the needed NULL
checks for the return values where glib and gtk+ can return NULL.

  • platform/gdk/FileChooserGdk.cpp: (WebCore::convertToStringByAdoptingTheFilesystemRepresentation): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth):
Note: See TracTimeline for information about the timeline view.