Timeline

Sep 20, 2007:

5:48 PM Changeset in webkit [25679] by kmccullo

• 2 edits in trunk/WebKit/win

Reviewed by Oliver.

• Added the ability to ask if scrollbars are visible
• <rdar://problem/5496211> scrollbarsVisible in WebChromeClient is not implemented

• WebChromeClient.cpp: (WebChromeClient::scrollbarsVisible):

5:28 PM Changeset in webkit [25678] by darin

• 1 edit in trunk/WebKitLibraries/win/lib

Ignore WebKitAuxiliaryLibraries files put here by update-webkit.

5:27 PM Changeset in webkit [25677] by darin

• 1 edit in trunk/WebKitLibraries/win/include

Ignore WebKitAuxiliaryLibraries files put here by the update-webkit script.

5:19 PM Changeset in webkit [25676] by adachan

• 6 edits in trunk

<rdar://problem/5477240> Regression: Footer is too high in print preview

Reviewed by Steve.

WebCore:

Make computePageRectsForFrame() return the height of the page adjusted for margins.

• bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
• bridge/win/FrameWin.h:

WebKit/win:

• WebFrame.cpp: (WebFrame::WebFrame): initialize new data member m_pageHeight, which is the height of the page adjusted for margins. (WebFrame::computePageRects): get the height of the page adjusted for margins by passing m_pageHeight to computePageRectsForFrame(). (WebFrame::spoolPages): footer rect's top is the max of the bottom of the page content and the bottom of the page minus footer height.
• WebFrame.h:

4:26 PM Changeset in webkit [25675] by kmccullo

• 8 edits in trunk

WebCore:

Reviewed by Hyatt.

• <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
• Implementing missing scrollbar functionality to allow turning off scrollbars correctly.

• platform/ScrollView.h:
• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling): (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::setAllowsScrolling): (WebCore::ScrollView::allowsScrolling):

win:

Reviewed by Hyatt.

• <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
• Implementing missing scrollbar functionality to allow turning off scrollbars correctly.

• Interfaces/IWebFrame.idl:
• Interfaces/IWebFrameView.idl:
• WebChromeClient.cpp: (WebChromeClient::setScrollbarsVisible):
• WebFrame.cpp: (WebFrame::setAllowsScrolling): (WebFrame::allowsScrolling): (WebFrame::frameView):
• WebFrame.h:

4:13 PM Changeset in webkit [25674] by beidson

• 6 edits in trunk

WebCore:

Reviewed by Dave Hyatt

<rdar://problem/5245981> - No favicon shows up for cnet.com

CNet's favicon has two images in it - a 32x32 white square, and a 16x16 image that is their actual icon
Till now on Windows we've always gone straight for the first image in an icon for the favicon, now we
actually do proper size matching

• platform/graphics/BitmapImage.h:

• platform/graphics/Image.h: (WebCore::Image::getHBITMAPOfSize): (WebCore::Image::drawFrameMatchingSourceSize): Search through the frames of the image for the correct size

• platform/graphics/win/ImageWin.cpp: (WebCore::BitmapImage::getHBITMAP): (WebCore::BitmapImage::getHBITMAPOfSize): (WebCore::BitmapImage::drawFrameMatchingSourceSize):

WebKit/win:

Reviewed by Dave Hyatt

<rdar://problem/5245981> - No favicon shows up for cnet.com

• WebIconDatabase.cpp: (WebIconDatabase::iconForURL): Call getHBITMAPOfSize (WebIconDatabase::getOrCreateDefaultIconBitmap): Ditto

2:58 PM Changeset in webkit [25673] by sfalken

• 2 edits in trunk/WebCore

Reviewed by Brady.

Call ascii() instead of utf8() from debug logging code to avoid threading
issues associated w/ converting to UTF8.

11:53 AM Changeset in webkit [25672] by staikos

• 4 edits in trunk/WebCore

2007-09-20 Mike Fenton <​mike@staikos.net>

Reviewed by George Staikos.

Implement gradients and more of canvas for Qt. Style changes and some
of the stroking fixes by George.

• html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::platformShading):
• html/CanvasGradient.h:
• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::applyFillPattern):

10:26 AM Changeset in webkit [25671] by sullivan

• 2 edits in trunk/WebKit

Build fix for stoooopid old PPC gcc compiler

• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingOfString): replace perfectly valid ?: syntax with if/else

4:05 AM Changeset in webkit [25670] by ddkilzer

• 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Fix: ​http://bugs.webkit.org/show_bug.cgi?id=15223
webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt

Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
Now isQt() and isGdk() use global variables that are only set once.

An array of all the parameters is now given to build-dumprender which includes
the platform on linux.

• Scripts/build-dumprendertree:
• Scripts/run-webkit-tests:
• Scripts/webkitdirs.pm:

3:53 AM Changeset in webkit [25669] by ddkilzer

• 1 edit in trunk/WebCore/ChangeLog

Added radar.

1:52 AM Changeset in webkit [25668] by rwlbuis

• 3 edits
  2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=15235
Options can not be removed from a Select element with OptGroup's using JavaScript

Remove HTMLOptionElement children against the proper parent node.

Sep 19, 2007:

11:44 PM Changeset in webkit [25667] by sfalken

• 1 copy in tags/Safari-523.7b

New tag.

11:44 PM Changeset in webkit [25666] by sfalken

• 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

10:56 PM Changeset in webkit [25665] by weinig

• 2 edits in trunk/WebKit/win

Rubber stamped by Adam Roben.

• WebKit.vcproj/WebKit.sln: Update location of DumpRenderTree and TestNetscapePlugin to point to their new locations.

7:03 PM Changeset in webkit [25664] by bdash

• 4 edits in trunk

Versioning.

7:03 PM Changeset in webkit [25663] by bdash

• 1 copy in tags/Safari-4523.7

New tag.

7:02 PM Changeset in webkit [25662] by bdash

• 1 copy in tags/Safari-5523.7

New tag.

5:43 PM Changeset in webkit [25661] by sullivan

• 4 edits in trunk

WebCore:

Reviewed by Darin Adler.

• WebCore part of speculative fix for <rdar://problem/5490627>, about crashes constructing a String using the values filled in by checkSpellingOfString()

• editing/Editor.cpp: (WebCore::findFirstMisspellingInRange): initialize out parameters the way we do elsewhere; add many assertions for improper results from checkSpellingOfString(); don't create a String at all until we've checked all the ways that checkSpellingOfString() results could indicate invalid string, even the unexpected ones; as an optimization, don't construct a String at all when looping through to mark all instances.

WebKit:

Reviewed by Darin Adler.

• WebKit part of speculative fix for <rdar://problem/5490627>, about crashes constructing a String using the values filled in by checkSpellingOfString()

• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingOfString): convert NSNotFound to -1, since WebCore code expects -1 for this purpose. We already do this in checkGrammarOfString.

5:17 PM Changeset in webkit [25660] by aroben

• 1 edit
  1 delete in trunk/WebKitTools

Rubberstamped by Hyatt.

• Spinneret: Removed.

5:13 PM Changeset in webkit [25659] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebKit

2007-09-19 Mark Rowe <​mrowe@apple.com>

Merge r18567 from trunk to Safari-2.0-dashboard.

2007-01-03 John Sullivan <​sullivan@apple.com>

• WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]

4:55 PM Changeset in webkit [25658] by zecke

• 2 edits in trunk/JavaScriptCore

2007-09-19 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

Make the guard/#if use the same name (ENABLE_FTPDIR) as the #define. This follows
the ENABLE_ICONDATABASE example from a couple of lines above.

• wtf/Platform.h:

4:14 PM Changeset in webkit [25657] by zecke

• 1 edit in trunk/WebCore/ChangeLog

Restore the ChangeLog entries accidently removed by r25646 which was spotted by Mark.

4:00 PM Changeset in webkit [25656] by zecke

• 4 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

There is no need to have FTPDirectoryDocument stubs. We can
compile FTPDirectoryDocument.cpp and FTPDirectoryTokenizer.cpp
instead.

• WebCore.pro:
• platform/gdk/TemporaryLinkStubs.cpp:
• platform/qt/TemporaryLinkStubs.cpp:

4:00 PM Changeset in webkit [25655] by zecke

• 2 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Remove includes that are not needed.

• platform/gdk/TemporaryLinkStubs.cpp:

3:59 PM Changeset in webkit [25654] by zecke

• 3 edits
  1 add in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Move the Pasteboard stubs to PasteboardGdk.cpp.

• WebCore.pro:
• platform/gdk/PasteboardGdk.cpp: Added. (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::Pasteboard):
• platform/gdk/TemporaryLinkStubs.cpp:

3:57 PM Changeset in webkit [25653] by zecke

• 3 edits
  1 add in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Move the Icon stubs to IconGdk.cpp

• WebCore.pro:
• platform/gdk/TemporaryLinkStubs.cpp:
• platform/graphics/gdk/IconGdk.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile):

3:48 PM Changeset in webkit [25652] by zecke

• 3 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Move the Font stubs to FontGdk.cpp

• platform/gdk/FontGdk.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
• platform/gdk/TemporaryLinkStubs.cpp:

3:45 PM Changeset in webkit [25651] by zecke

• 3 edits
  1 add in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Move the SearchPopupMenu stubs to SearchPopupMenuGdk.cpp

• WebCore.pro:
• platform/gdk/SearchPopupMenuGdk.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
• platform/gdk/TemporaryLinkStubs.cpp:

3:39 PM Changeset in webkit [25650] by zecke

• 3 edits
  2 adds in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Move the ContextMenu and ContextMenuItem stubs to
ContextMenuGdk.cpp and ContextMenuItemGdk.cpp.

• WebCore.pro:
• platform/gdk/ContextMenuGdk.cpp: Added. (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription): (WebCore::ContextMenu::releasePlatformDescription):
• platform/gdk/ContextMenuItemGdk.cpp: Added. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked):
• platform/gdk/TemporaryLinkStubs.cpp:

3:36 PM Changeset in webkit [25649] by zecke

• 3 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Implement the WebCore::fileSize function using g_stat.

• platform/gdk/FileSystemGdk.cpp: (WebCore::fileSize):
• platform/gdk/TemporaryLinkStubs.cpp:

3:33 PM Changeset in webkit [25648] by zecke

• 4 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Move the ResourceHandle stubs from TemporaryLinkStubs
to the ResourceHandleCurl.cpp file. This affects the
Gtk+ and wx port as they share the curl implementation.

• platform/gdk/TemporaryLinkStubs.cpp:
• platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::willLoadFromCache): (WebCore::ResourceHandle::loadsBlocked):
• platform/wx/TemporaryLinkStubs.cpp:

3:26 PM Changeset in webkit [25647] by zecke

• 4 edits in trunk/WebKit/gtk

2007-09-17 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

WebKitGtkPage and WebKitGtkFrame have a dependency on each other. To
allow client code to include both headers the typedef's for
WebKitGtkFrame, WebKitGtkPage, WebKitGtkFrameData and WebKitGtkNetworkRequest
are moved into webkitgtkdefines.h and included by both webkitgtkpage.h and
webkitgtkframe.h

• Api/webkitgtkdefines.h:
• Api/webkitgtkframe.h:
• Api/webkitgtkpage.h:

3:17 PM Changeset in webkit [25646] by zecke

• 2 edits in trunk/WebCore

2007-09-17 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Take ​http://bugs.webkit.org/show_bug.cgi?id=15221 into account
and change the variable names from nameSystem to systemName and
change the name of the function to stringByAdoptingFileSystemRepresentation.

• platform/gdk/FileChooserGdk.cpp: (WebCore::stringByAdoptingFileSystemRepresentation): (WebCore::FileChooser::basenameForWidth):

3:02 PM Changeset in webkit [25645] by kmccullo

• 2 edits in trunk/LayoutTests

Reviewed by.

• Layout Test fixe

• fast/dom/Window/new-window-opener.html:

2:25 PM Changeset in webkit [25644] by kmccullo

• 1 edit
  2 adds in trunk/LayoutTests

Reviewed by Geoff and Sam.

• Added test cases for the different features of a new opened window.

• fast/dom/Window/new-window-opener-expected.txt: Added.
• fast/dom/Window/new-window-opener.html: Added.

1:51 PM Changeset in webkit [25643] by weinig

• 3 edits
  2 adds in trunk

WebCore:

Reviewed by Geoff Garen.

Fix <rdar://problem/5492141> Assertion in isdigit() on windows Safari

Test: fast/css/hexColor-isDigit-assert.html

• platform/DeprecatedString.cpp: (WebCore::isCharacterAllowedInBase): Check that the character is ascii to avoid an assertions on Windows.

LayoutTests:

Reviewed by Geoff Garen.

Test for <rdar://problem/5492141> Assertion in isdigit() on windows Safari

• fast/css/hexColor-isDigit-assert-expected.txt: Added.
• fast/css/hexColor-isDigit-assert.html: Added.

1:17 PM Changeset in webkit [25642] by andersca

• 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5489879>
Combination of real player with high connection quality in selecting player makes Safari quit.

Prevent the Real Player plug-in from calling the window proc recursively.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::wndProc): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::PluginViewWin):
• plugins/win/PluginViewWin.h: (WebCore::):

11:04 AM Changeset in webkit [25641] by adele

• 25 edits
  1 move
  2 adds
  2 deletes in trunk

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

Tests:

This fix has a few steps:
1) Removes the ignore value for the -webkit-user-select property. We now decide when to prevent selection from starting by calling canStartSelection on the node.
2) Implements canStartSelection which returns false for all elements that used to have -webkit-user-select:ignore set, true for content editable nodes,

and walks up the tree to ask the parent before allowing selection to be started on any other nodes.

3) We used to disallow selection from starting within -webkit-user-select:none blocks, but now we only use canStartSelection for that. This will allow easy selections

in cases like iChat where there's a mix of selectable and non-selectable content.

4) Makes -webkit-user-select inherited. After removing the "ignore" value, -webkit-user-select would behave like it was inherited anyways since we already allowed the text value to override the none value.

• css/html4.css: Removed all usage of -webkit-user-select: ignore. This is now handled internally with canStartSelection(). Now -webkit-user-select won't be unintentionally overridden by nodes that don't want to allow selection to be started, but do want to honor the -webkit-user-select to determine whether or not selection is allowed at all.

• editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Don't try to determine whether selection is allowed inside the root node here. VisiblePosition and Selection creation will keep Selection endpoints out of -webkit-user-select:none regions.

• dom/Node.h:
• dom/Node.cpp: (WebCore::Node::canStartSelection): Added. Always allows selection to be started in a content editable node. If there's a parent, ask the parent if starting a selection is allowed. If there's no parent, default to allowing selection.
• html/HTMLAnchorElement.h:
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::canStartSelection): Added. If its not a link, then calls the base class. Disallows selection for non-editable links. Allows selection for editable links. This logic used to be done in CSSStyleSelector by changing the user-select property.
• html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canStartSelection): Added. Disallows selection from starting in buttons.
• html/HTMLImageElement.h: (WebCore::HTMLImageElement::canStartSelection): Added. Disallows selection from starting in images.
• html/HTMLInputElement.h:
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canStartSelection): Added. Disallows selection from anything that's not a text field. Text fields call up to the base class. When they're editable, text controls will always be selectable because of the case for content editable content. Otherwise, they'll respect their parent element's decision about starting a selection.
• html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::canStartSelection): Added. Disallows selection from starting in popup buttons.

• page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect instead of the ambiguously named shouldSelect(). (WebCore::EventHandler::handleMousePressEventTripleClick): ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect. (WebCore::EventHandler::selectCursor): Paint an ibeam in any region that allows you to click to create a selection. (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and calls canStartSelection instead of checking the user-select property. (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to canMouseDownStartSelect because of 12823, even though it seems strange that we would fire the selectStart event here.
• page/EventHandler.h:
• page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Calls canStartSelection instead of checking the user-select property to decide when to prevent selection creation.
• rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): ditto.
• rendering/RenderObject.h: Removed helper methods that are no longer needed.

• rendering/RenderStyle.h: Made userSelect inherited. After removing the "ignore" value, -webkit-user-select would behave like it was inherited anyways since we already allowed the text value to override the none value. Removed the SELECT_AUTO and SELECT_IGNORE values since they're no longer used. (WebCore::): (WebCore::RenderStyle::userSelect): (WebCore::RenderStyle::setUserSelect): (WebCore::RenderStyle::initialUserSelect):
• rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):

• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Remove case for SELECT_AUTO and SELECT_IGNORE
• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Remove adjustment for links. This is now handled in HTMLAnchorElement::canStartSelection. (WebCore::CSSStyleSelector::applyProperty): Map CSS_VAL_AUTO to SELECT_TEXT. Remove CSS_VAL_IGNORE.

LayoutTests:

Reviewed by Maciej.

Tests for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

• fast/css/computed-style-expected.txt: Updated for default -webkit-user-select value.
• fast/css/computed-style-without-renderer-expected.txt: ditto.

• editing/selection/5333725.html: Re-enabled.
• editing/selection/5333725.html-disabled: Removed.

• editing/selection/user-select-text-inside-user-select-ignore.html-disabled: Removed. Adjusted this test to be more specific and renamed it to textfield-inside-anchor.
• editing/selection/user-select-text-inside-user-select-ignore-expected.txt: Removed.
• fast/forms/textfield-inside-anchor-expected.txt: Added.
• fast/forms/textfield-inside-anchor.html: Added.

10:59 AM Changeset in webkit [25640] by kdecker

• 3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/5491066> soft link Accelerate.framework

• Misc/WebGraphicsExtras.c: (WebConvertBGRAToARGB): Improve launch time performance and reduce vsize footprint by soft linking the Accelerate.framework.
• WebKit.xcodeproj/project.pbxproj: Remove no longer needed frameworks.

9:11 AM Changeset in webkit [25639] by ddkilzer

• 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by David Kilzer.

• Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.

7:40 AM Changeset in webkit [25638] by staikos

• 2 edits in trunk/WebCore

2007-09-19 George Staikos <​staikos@kde.org>

As discussed with Brady and Maciej, on platforms without pthreads, use
IconDatabaseNone for now and don't use pthreads. Fixes Qt Win32 build
for now.

• loader/icon/IconDatabase.h:

3:07 AM Changeset in webkit [25637] by bdash

• 2 edits in trunk/JavaScriptCore

2007-09-19 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

<rdar://problem/5487107> NULL dereference crash in FastMallocZone::enumerate when running leaks against Safari

Storing remote pointers to their local equivalents in mapped memory was leading to the local pointer being
interpreted as a remote pointer. This caused a crash when using the result of mapping this invalid remote pointer.
The fix is to follow the pattern used elsewhere in FastMallocZone by always doing the mapping after reading and
never storing the mapped pointer.

• wtf/FastMalloc.cpp: (WTF::FastMallocZone::enumerate):

2:45 AM Changeset in webkit [25636] by antti

• 4 edits
  2 adds in trunk

WebCore:

Reviewed by Maciej.

Fix <rdar://problem/5488539>
(9A550) iPhone Banner on O2.UK site not clickable with Safari due to styled noscript element

Don't create renderer for noscript if scripts are enabled.

Test: fast/dom/noscript-style.html

• html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): (WebCore::HTMLElement::parseMappedAttribute): (WebCore::HTMLElement::checkDTD): (WebCore::HTMLElement::rendererIsNeeded): (WebCore::HTMLElement::createRenderer):
• html/HTMLElement.h:

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5488539>
(9A550) iPhone Banner on O2.UK site not clickable with Safari due to styled noscript element

• fast/dom/noscript-style-expected.txt: Added.
• fast/dom/noscript-style.html: Added.