Context Navigation

← Previous Period
Next Period →

Timeline

Sep 22, 2007:

9:03 PM Changeset in webkit [25701] by aroben

3 edits
2 adds in trunk

Fix Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value

WebCore:

Fix Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value

http://bugs.webkit.org/show_bug.cgi?id=15251
<rdar://5498169>

Reviewed by Maciej.

Test: fast/forms/range-reset.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): <input type=range> should be storing its value separately from the value attribute, as do all of our variable-input input types.

LayoutTests:

Test for Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value

http://bugs.webkit.org/show_bug.cgi?id=15251
<rdar://5498169>

Reviewed by Maciej.

fast/forms/range-reset-expected.txt: Added.
fast/forms/range-reset.html: Added.

2:21 PM Changeset in webkit [25700] by oliver

3 edits in branches/feature-branch/WebCore

Reviewed by NOBODY (Build fix).

platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::renderPath):
rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):

Sep 21, 2007:

9:20 PM Changeset in webkit [25699] by bdash

5 edits in trunk/WebCore

2007-09-21 Mark Rowe <mrowe@apple.com>

Build fix for non-Mac platforms after r25697.

Rename Frame::cleanupPlatformScriptObjects to Frame::clearPlatformScriptObjects.

bridge/win/FrameWin.cpp:
page/gdk/FrameGdk.cpp:
page/qt/FrameQt.cpp:
platform/wx/TemporaryLinkStubs.cpp:

8:56 PM Changeset in webkit [25698] by adele

3 edits
2 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page

Test: fast/dom/HTMLSelectElement/options-collection-set-string-length.html

bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): Convert the value to a number. We already have code here to check if the value is not a number. This matches other browsers, which allow a string value to be used to set the length.

LayoutTests:

Reviewed by Sam.

Test for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page

fast/dom/HTMLSelectElement/options-collection-set-string-length-expected.txt: Added.
fast/dom/HTMLSelectElement/options-collection-set-string-length.html: Added.

5:49 PM Changeset in webkit [25697] by thatcher

12 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded

Calling -[WebView windowScriptObject] before the page loads would give you nil. This behavior didn't match Tiger.
The API behavior in Tiger let you get the window script object once and keep ahold of it as long as you needed it.
The window object would remain valid even after page loads. This change restores the Tiger behavior.

<rdar://problem/5495790> NULL dereference crash beneath Bindings::RootObject::interpreter when saving Dashcode document

The changes to WebScriptObject's _isSafeScript call also fixed the crash in Dashcode.

bindings/objc/WebScriptObject.mm: (-[WebScriptObject _setOriginRootObject:andRootObject:]): New method used to update the the root objects, so the WebScriptObject can still be used after a page load. (-[WebScriptObject _isSafeScript]): Call [self _rootObject] instead of accessing the data member directly. DOMNode has an override for the _rootObject method, and it can return 0 when _private->_rootObject is non-zero. We would return YES here when it wasn't safe and later crash with my modified layout tests. Checking _rootObject first prevents other calls sites from needing to check for a valid root object, this fixed the Dashcode crash. (-[WebScriptObject _imp]): Ditto.

bindings/objc/WebScriptObjectPrivate.h: Add _setOriginRootObject:andRootObject:.

loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Call the renamed clearScriptObjects function. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Some gratuitous code cleanup.

page/Frame.cpp: (WebCore::Frame::clearScriptObjects): Renamed cleanupScriptObject to clearScriptObjects. Call clearPlatformScriptObjects last so m_bindingRootObject is already NULL. (WebCore::Frame::windowScriptNPObject): Hold a JSLock before accessing the window. This change is unrelated to the bug, but should be fixed.

page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Return a script object even if the interpreter is NULL. This resotres the Tiger behavior of always being able to access the window object. (WebCore::Frame::clearPlatformScriptObjects): Keep the window script object around, and update the root objects for the window script object.

page/Frame.h: Rename cleanupScriptObject to clearScriptObjects.
page/FramePrivate.h: Use a RetainPtr for m_windowScriptObject.

WebKitTools:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)

Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
This is tested by plugins/root-object-premature-delete-crash.html.

DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)

Updated results to show the didClearWindowScriptObject delegate call. Tweaked plugins/root-object-premature-delete-crash.html
to test a non-window script object half the time. This change works with a change to DumpRenderTree.

http/tests/loading/empty-subframe-expected.txt:
http/tests/loading/simple-subframe-expected.txt:
plugins/root-object-premature-delete-crash.html:
webarchive/loading/test-loading-archive-expected.txt:

5:30 PM Changeset in webkit [25696] by staikos

2 edits in trunk/WebCore

2007-09-21 Mike Fenton <mike@staikos.net>

Reviewed by George Staikos.

Fix styled pen support by not clobbering QPen properties.

html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):

5:00 PM Changeset in webkit [25695] by oliver

1 edit in trunk/WebCore/ChangeLog

Darin reviewed as well, and pointed out mistake in ChangeLog

4:51 PM Changeset in webkit [25694] by oliver

2 edits in trunk/WebCore

Reviewed by Tristan.

http://bugs.webkit.org/show_bug.cgi?id=15239
<rdar://problem/5491955> REGRESSION (r25547): With Hanin IME, one cannot input characters into forms (15239)

This problem was caused by the setComposition method failing to clearing
the composition markers in the presence of an empty string. This would
result in the caret being locked within the 0 length bounds of the "composition"
and so preventing basic keyboard interaction.

editing/Editor.cpp: (WebCore::Editor::setComposition):

4:29 PM Changeset in webkit [25693] by adele

3 edits in trunk/WebCore

Reviewed by Tristan.

Fix for <rdar://problem/5497346> "Check spelling when I click Send" crashes on stationery messages every time

No test. I wasn't able to find a way to get this to occur with Safari or DumpRenderTree.

editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): Updated comment.
editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Only return the root position if its editable. (WebCore::maxDeepOffset): Added nil check & assert.

4:18 PM Changeset in webkit [25692] by andersca

2 edits in trunk/WebCore

Reviewed by Steve.

<rdar://problem/5404339>
Site redirects continuosly, starving UI thread, causing app to hang.

Use GetQueueStatus to see if there are input messages in the queue that aren't being processed.
If so, use a low-priority timer instead of PostMessage.

platform/win/SharedTimerWin.cpp: (WebCore::setSharedTimerFireTime):

4:11 PM Changeset in webkit [25691] by tristan

8 edits in branches/Safari-2.0-dashboard/WebCore

Merge r24938 and r24946 from ToT to Safari-2.0-dashboard.

2007-08-08 Sam Weinig <sam@webkit.org>

Reviewed by Geoff Garen.

Fix for <rdar://problem/5354635>

Match Firefox's model for data: URLs by not allowing them script access
to any frames other then itself.

bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
dom/Document.cpp: (WebCore::Document::initSecurityPolicyURL):

2007-08-08 Sam Weinig <sam@webkit.org>

Reviewed by Brady.

Make protocol and host compares case-insensitive.

bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
dom/Document.cpp: (WebCore::Document::initSecurityPolicyURL):
platform/DeprecatedString.cpp: (WebCore::equalIgnoringCase):
platform/DeprecatedString.h: (WebCore::equalIgnoringCase):

3:47 PM Changeset in webkit [25690] by darin

4 edits in trunk/WebCore

Reviewed by Anders.

add QueryInterface capabilities to COMPtr

platform/win/COMPtr.h: (COMPtr::COMPtr): Added constructor that takes a Query tag and does an appropriate QueryInterface. (COMPtr::query): Added function to do a queryInterface. (COMPtr::copyQueryInterfaceRef): Added private helper used by both of the above. Note that when the query fails you get a 0, which is the same thing you get if a 0 pointer is passed in.

platform/win/FontCacheWin.cpp: (WebCore::FontCache::getFontLinkInterface): Convert to using the new query as a test case. Also eliminate the unnecessary second global variable and use COMPtr objects rather than just leaking references.

platform/win/WCDataObject.h: Removed unneeded include and using statements.

2:58 PM Changeset in webkit [25689] by andersca

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5494790>
clicking any link in the Flash regions at bananarepublic.com results in bad page

Don't replace the frame contents, the Mac version doesn't do this.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

1:15 PM Changeset in webkit [25688] by andersca

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5496700>
Repro crash loading http://www.tivo.com/whatistivo/tivohd/index.html

Don't continue if the plug-in cancelled the stream.

loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):

1:12 PM Changeset in webkit [25687] by kmccullo

2 edits in trunk/WebKitTools

Reviewed by Oliver.

We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)

DumpRenderTree/win/FrameLoaderDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate):

12:48 PM Changeset in webkit [25686] by kdecker

2 edits in trunk/WebKit

Plugins/WebBaseNetscapePluginView.mm: Build fix. The first argument of aglChoosePixelFormat() has changed from const AGLDevice *gdevs on Tiger to const void *gdevs on Leopard.

12:15 PM Changeset in webkit [25685] by kdecker

3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/5493093>

Reduced launch time by lazily linking both the AGL and OpenGL frameworks until they are really needed.

Plugins/WebBaseNetscapePluginView.mm: Soft link all AGL and OpenGL functions used by WebBaseNetscapePluginView.

WebKit.xcodeproj/project.pbxproj: Removed AGL and OpenGL from the project.

12:14 PM Changeset in webkit [25684] by kdecker

2 edits in trunk/WebCore

platform/mac/SoftLinking.h: Build fix; added necessary #imports.

12:06 PM Changeset in webkit [25683] by kdecker

2 edits
1 add in trunk/WebCore

Reviewed by Darin Adler.

WebCore.xcodeproj/project.pbxproj: Added SoftLinking.h to the project.
platform/mac/SoftLinking.h: Contains a new macro; useful in helping to lazily load frameworks.

10:15 AM Changeset in webkit [25682] by kmccullo

2 edits in trunk/WebKit/win

Fixed a syntax guideline mistake.

WebChromeClient.cpp: (WebChromeClient::scrollbarsVisible):

4:06 AM Changeset in webkit [25681] by bdash

2 edits in trunk/JavaScriptCore

2007-09-21 Mark Rowe <mrowe@apple.com>

Reviewed by Antti Koivisto.

http://bugs.webkit.org/show_bug.cgi?id=15250
<rdar://problem/5496942> REGRESSION: Reproducible crash in Safari when evaluating script in Drosera console (15250)

kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction): Null-check thisObj before passing it to interpreterForGlobalObject.

12:02 AM Changeset in webkit [25680] by oliver

3 edits in trunk/WebKit/win

2007-09-20 Oliver Hunt <oliver@apple.com>

Reviewed by Steve.

<rdar://problem/5487153> Korean characters are displayed as garbage with default encoding in some Korean web sites

Context Navigation

Timeline

Sep 22, 2007:

Sep 21, 2007:

Download in other formats: