⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 24, 2007:

5:53 PM Changeset in webkit [25720] by sfalken
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • fix <rdar://problem/5502513>
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::getFontLinkInterface): Roll back this file; the old code leaked a global COM object, but that's no big deal and the new code caused a crash on quit.
5:01 PM Changeset in webkit [25719] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5494608>
Seed: Safari will follow links in Flash movies without clicking.

Make sure to handle mouseover and mouseout so the plug-in can track when the mouse is over it.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):
4:37 PM Changeset in webkit [25718] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5498016> Photoshop CS3: Adobe Help Viewer 1.1 crashes in 9A553

WebKit started calling the mouseDidMoveOverElement delegate method with a nil dictionary in r14982.
We originally intended to call this delegate method sometimes with a nil dictionary, but due to
a bug dating back to WebKit 1.0 this delegate was never called with nil! Unfortunately we can't
start calling this with nil since it will break Adobe Help Viewer, and possibly other clients.

  • WebView/WebView.mm: (-[WebView _mouseDidMoveOverElement:modifierFlags:]):
3:45 PM Changeset in webkit [25717] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Adam Roben.

  • platform/win/Skipped: Comment out currently disabled tests.
2:36 PM Changeset in webkit [25716] by darin
  • 8 edits in trunk/WebKit/win

Reviewed by Steve.

  • fix <rdar://problem/5095701> Download requring HTTP auth fails (progress bar forever)

The functions in WebDownload relating to authentication challenges needed
to be implemented.

  • WebDownload.cpp: (WebDownload::cancelAuthenticationChallenge): Implement. (WebDownload::continueWithoutCredentialForAuthenticationChallenge): Ditto. (WebDownload::useCredential): Ditto. (WebDownload::willSendRequest): Fix storage leak by adopting request and response after creating them. Also retain the result before returning it, since that's the API contract with CFNetwork. (WebDownload::didReceiveAuthenticationChallenge): Implement. (WebDownload::didReceiveResponse): Fix storage leak by adopting response. (WebDownload::willResumeWithResponse): Ditto. (WebDownload::didFail): Ditto.
  • WebURLAuthenticationChallenge.h: Get rid of the IID #define, instead using declspec(uuid). Added a sender parameter to the create function and an m_sender data member.
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::WebURLAuthenticationChallenge): Added an explicit sender parameter so this can be used with a WebDownload, which does not involve a ResourceHandle. Later we should clean this up and not involve WebCore or ResourceHandle directly even for the non-download case. (WebURLAuthenticationChallenge::createInstance): Added an overload for the case with an explicit sender parameter. (WebURLAuthenticationChallenge::QueryInterface): Use uuidof for the ID of this class. In general, we should move to uuidof as much as possible and keep the separate macros to a minimum -- but we should do this for all uses of each class at one time to make sure we don't run into problems with two different UUIDs for the same class. This patch does it for three classes. (WebURLAuthenticationChallenge::initWithProtectionSpace): Use the query constructor instead of an explicit QueryInterface for WebURLCredential. This is another class where I'm switching from CLSID/IID macros to the use of uuidof, but in this case the use of uuidof is implicit. (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): Ditto, but for WebURLAuthenticationChallenge and WebURLAuthenticationChallengeSender. (WebURLAuthenticationChallenge::sender): Use the new m_sender member to cache the sender object and also use the one that was passed into the constructor, if any.
  • WebURLAuthenticationChallengeSender.h: Get rid of the IID #define, instead using declspec(uuid). Also minimize includes and make data members private instead of protected.
  • WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::QueryInterface): Use uuidof instead of IID macro. (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): Use query constructor instead of QueryInterface. (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): Ditto. (WebURLAuthenticationChallengeSender::useCredential): Ditto.
  • WebURLCredential.cpp: (WebURLCredential::QueryInterface): Use uuidof instead of CLSID_WebURLCredential.
  • tangentially-related cleanup
  • WebFrame.cpp: (WebFrame::dispatchDidReceiveAuthenticationChallenge): Use the adopt constructor instead of a separate adoptRef call. (WebFrame::dispatchDidCancelAuthenticationChallenge): Ditto.
1:58 PM Changeset in webkit [25715] by kmccullo
  • 1 edit
    1 delete in trunk/WebKitTools
  • Reverted an accidentally checked in file.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
1:10 PM Changeset in webkit [25714] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Sam.

  • Continued to update project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
11:25 AM Changeset in webkit [25713] by staikos
  • 5 edits in trunk/WebCore

2007-09-24 Mike Fenton <​mike@staikos.net>

Reviewed by George Staikos.

Switch to using a QImage instead of a QPixmap to make transparency work.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext): (WebCore::HTMLCanvasElement::createPlatformImage):
  • html/HTMLCanvasElement.h:
10:04 AM Changeset in webkit [25712] by kmccullo
  • 8 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Sam.

  • Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.

WebCore:

Reviewed by Sam.

  • Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
  • WebCore.vcproj/WebCore.vcproj:

WebKitTools:

Reviewed by Sam.

  • Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
9:59 AM Changeset in webkit [25711] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by Sam.

  • Added a new test that will not pass until DRT supports new windows.
  • platform/win/Skipped:
9:34 AM Changeset in webkit [25710] by beidson
  • 4 edits in trunk

WebKit/win:

Reviewed by John Sullivan

Fix for <rdar://5493371> - Crash in Icon Database on Windows


  • WebIconDatabase.cpp: (WebIconDatabase::iconForURL): If the URL is NULL, fallback to the default icon without asking WebCore

WebCore:

Reviewed by John Sullivan

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): Assert the page url is non-null
9:26 AM Changeset in webkit [25709] by aroben
  • 2 edits in trunk/WebKit/win

Fix <rdar://5499507> FrameView will always have size (0,0) if its parent WebView is never resized

Reviewed by Darin.

  • WebView.cpp: (WebView::initWithFrame): Set the main FrameView's size to the size of the WebView.

Sep 23, 2007:

6:23 PM Changeset in webkit [25708] by mjs
  • 9 edits in trunk/WebKitSite

Reviewed by Mark Rowe.


  • Limit custom list bullets to ordered lists only
  • css/blue.css:
  • css/gray.css:
  • css/green.css:
  • css/ie.css:
  • css/main.css:
  • css/pink.css:
  • css/purple.css:
  • css/yellow.css:
5:21 PM Changeset in webkit [25707] by bdash
  • 4 edits in trunk

Versioning.

5:21 PM Changeset in webkit [25706] by bdash
  • 1 copy in tags/Safari-4523.8

New tag.

5:20 PM Changeset in webkit [25705] by bdash
  • 1 copy in tags/Safari-5523.8

New tag.

11:24 AM BuildingGtk edited by freyther@gmit-gmbh.de
(diff)
9:38 AM Changeset in webkit [25704] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by Adam.

  • coding/coding-style.html:
    • in section Other Punctuation
      • syntax instead of synatax
      • fix sample code alignment
8:11 AM BuildingOnLinux edited by freyther@gmit-gmbh.de
(diff)
8:10 AM WikiStart edited by freyther@gmit-gmbh.de
(diff)
8:09 AM BuildingGdk edited by freyther@gmit-gmbh.de
(diff)
8:05 AM BuildingGtk created by freyther@gmit-gmbh.de
2:50 AM Changeset in webkit [25703] by zecke
  • 37 edits
    38 copies
    5 moves
    38 deletes in trunk

/:
2007-09-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

Renamed files from *Gdk to *Gtk (see #14732) using the
work of Juan A. Suarez Romero as a base.

GDK -> GTK

  • WebKit.pri:
  • WebKit.pro:

JavaScriptCore:
2007-09-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

Renamed files from *Gdk to *Gtk (see #14732) using the
work of Juan A. Suarez Romero as a base.

GDK -> GTK

  • JavaScriptCore.pri:
  • kjs/testkjs.pro:
  • pcre/dftables.pro:
  • wtf/Platform.h: PLATFORM(GDK) to PLATFORM(GTK)

WebCore:
2007-09-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

Renamed files from *Gdk to *Gtk (see #14732) using the
work of Juan A. Suarez Romero as a base.

GDK -> GTK

  • Projects/gdk/webcore-gdk.bkl:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • loader/gdk: Removed.
  • loader/gdk/DocumentLoaderGdk.cpp: Removed.
  • loader/gtk: Added.
  • loader/gtk/DocumentLoaderGdk.cpp: Removed.
  • loader/gtk/DocumentLoaderGtk.cpp: Added.
  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/gdk: Removed.
  • page/gdk/DragControllerGdk.cpp: Removed.
  • page/gdk/EventHandlerGdk.cpp: Removed.
  • page/gdk/FrameGdk.cpp: Removed.
  • page/gtk: Added.
  • page/gtk/DragControllerGdk.cpp: Removed.
  • page/gtk/DragControllerGtk.cpp: Added.
  • page/gtk/EventHandlerGdk.cpp: Removed.
  • page/gtk/EventHandlerGtk.cpp: Added. (WebCore::EventHandler::createDraggingClipboard):
  • page/gtk/FrameGdk.cpp: Removed.
  • page/gtk/FrameGtk.cpp: Added.
  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/FontData.h:
  • platform/NotImplemented.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMenuDescription.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/gdk: Removed.
  • platform/gdk/ClipboardGdk.cpp: Removed.
  • platform/gdk/ClipboardGdk.h: Removed.
  • platform/gdk/ContextMenuGdk.cpp: Removed.
  • platform/gdk/ContextMenuItemGdk.cpp: Removed.
  • platform/gdk/CookieJarGdk.cpp: Removed.
  • platform/gdk/CursorGdk.cpp: Removed.
  • platform/gdk/DragDataGdk.cpp: Removed.
  • platform/gdk/DragImageGdk.cpp: Removed.
  • platform/gdk/FileChooserGdk.cpp: Removed.
  • platform/gdk/FileSystemGdk.cpp: Removed.
  • platform/gdk/FontCacheGdk.cpp: Removed.
  • platform/gdk/FontDataGdk.cpp: Removed.
  • platform/gdk/FontGdk.cpp: Removed.
  • platform/gdk/FontPlatformData.h: Removed.
  • platform/gdk/FontPlatformDataGdk.cpp: Removed.
  • platform/gdk/GlyphPageTreeNodeGdk.cpp: Removed.
  • platform/gdk/KeyEventGdk.cpp: Removed.
  • platform/gdk/KeyboardCodes.h: Removed.
  • platform/gdk/LocalizedStringsGdk.cpp: Removed.
  • platform/gdk/LoggingGdk.cpp: Removed.
  • platform/gdk/MIMETypeRegistryGdk.cpp: Removed.
  • platform/gdk/MouseEventGdk.cpp: Removed.
  • platform/gdk/PasteboardGdk.cpp: Removed.
  • platform/gdk/PlatformScreenGdk.cpp: Removed.
  • platform/gdk/PlatformScrollBar.h: Removed.
  • platform/gdk/PlatformScrollBarGdk.cpp: Removed.
  • platform/gdk/PopupMenuGdk.cpp: Removed.
  • platform/gdk/RenderThemeGdk.cpp: Removed.
  • platform/gdk/RenderThemeGdk.h: Removed.
  • platform/gdk/ScrollViewGdk.cpp: Removed.
  • platform/gdk/SearchPopupMenuGdk.cpp: Removed.
  • platform/gdk/SharedTimerLinux.cpp: Removed.
  • platform/gdk/SoundGdk.cpp: Removed.
  • platform/gdk/SystemTimeLinux.cpp: Removed.
  • platform/gdk/TemporaryLinkStubs.cpp: Removed.
  • platform/gdk/WheelEventGdk.cpp: Removed.
  • platform/gdk/WidgetGdk.cpp: Removed.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setPlatformFont):
  • platform/graphics/gdk: Removed.
  • platform/graphics/gdk/IconGdk.cpp: Removed.
  • platform/graphics/gdk/ImageGdk.cpp: Removed.
  • platform/graphics/gtk: Added.
  • platform/graphics/gtk/IconGdk.cpp: Removed.
  • platform/graphics/gtk/IconGtk.cpp: Added.
  • platform/graphics/gtk/ImageGdk.cpp: Removed.
  • platform/graphics/gtk/ImageGtk.cpp: Added.
  • platform/gtk: Added.
  • platform/gtk/ClipboardGdk.cpp: Removed.
  • platform/gtk/ClipboardGdk.h: Removed.
  • platform/gtk/ClipboardGtk.cpp: Added. (WebCore::ClipboardGtk::ClipboardGtk): (WebCore::ClipboardGtk::~ClipboardGtk): (WebCore::ClipboardGtk::clearData): (WebCore::ClipboardGtk::clearAllData): (WebCore::ClipboardGtk::getData): (WebCore::ClipboardGtk::setData): (WebCore::ClipboardGtk::types): (WebCore::ClipboardGtk::dragLocation): (WebCore::ClipboardGtk::dragImage): (WebCore::ClipboardGtk::setDragImage): (WebCore::ClipboardGtk::dragImageElement): (WebCore::ClipboardGtk::setDragImageElement): (WebCore::ClipboardGtk::createDragImage): (WebCore::ClipboardGtk::declareAndWriteDragImage): (WebCore::ClipboardGtk::writeURL): (WebCore::ClipboardGtk::writeRange): (WebCore::ClipboardGtk::hasData):
  • platform/gtk/ClipboardGtk.h: Added.
  • platform/gtk/ContextMenuGdk.cpp: Removed.
  • platform/gtk/ContextMenuGtk.cpp: Added.
  • platform/gtk/ContextMenuItemGdk.cpp: Removed.
  • platform/gtk/ContextMenuItemGtk.cpp: Added.
  • platform/gtk/CookieJarGdk.cpp: Removed.
  • platform/gtk/CookieJarGtk.cpp: Added.
  • platform/gtk/CursorGdk.cpp: Removed.
  • platform/gtk/CursorGtk.cpp: Added.
  • platform/gtk/DragDataGdk.cpp: Removed.
  • platform/gtk/DragDataGtk.cpp: Added.
  • platform/gtk/DragImageGdk.cpp: Removed.
  • platform/gtk/DragImageGtk.cpp: Added.
  • platform/gtk/FileChooserGdk.cpp: Removed.
  • platform/gtk/FileChooserGtk.cpp: Added.
  • platform/gtk/FileSystemGdk.cpp: Removed.
  • platform/gtk/FileSystemGtk.cpp: Added.
  • platform/gtk/FontCacheGdk.cpp: Removed.
  • platform/gtk/FontCacheGtk.cpp: Added.
  • platform/gtk/FontDataGdk.cpp: Removed.
  • platform/gtk/FontDataGtk.cpp: Added.
  • platform/gtk/FontGdk.cpp: Removed.
  • platform/gtk/FontGtk.cpp: Added.
  • platform/gtk/FontPlatformDataGdk.cpp: Removed.
  • platform/gtk/FontPlatformDataGtk.cpp: Added.
  • platform/gtk/GlyphPageTreeNodeGdk.cpp: Removed.
  • platform/gtk/GlyphPageTreeNodeGtk.cpp: Added.
  • platform/gtk/KeyEventGdk.cpp: Removed.
  • platform/gtk/KeyEventGtk.cpp: Added.
  • platform/gtk/LocalizedStringsGdk.cpp: Removed.
  • platform/gtk/LocalizedStringsGtk.cpp: Added.
  • platform/gtk/LoggingGdk.cpp: Removed.
  • platform/gtk/LoggingGtk.cpp: Added.
  • platform/gtk/MIMETypeRegistryGdk.cpp: Removed.
  • platform/gtk/MIMETypeRegistryGtk.cpp: Added.
  • platform/gtk/MouseEventGdk.cpp: Removed.
  • platform/gtk/MouseEventGtk.cpp: Added.
  • platform/gtk/PasteboardGdk.cpp: Removed.
  • platform/gtk/PasteboardGtk.cpp: Added.
  • platform/gtk/PlatformScreenGdk.cpp: Removed.
  • platform/gtk/PlatformScreenGtk.cpp: Added.
  • platform/gtk/PlatformScrollBarGdk.cpp: Removed.
  • platform/gtk/PlatformScrollBarGtk.cpp: Added.
  • platform/gtk/PopupMenuGdk.cpp: Removed.
  • platform/gtk/PopupMenuGtk.cpp: Added.
  • platform/gtk/RenderThemeGdk.cpp: Removed.
  • platform/gtk/RenderThemeGdk.h: Removed.
  • platform/gtk/RenderThemeGtk.cpp: Added. (WebCore::theme): (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::close): (WebCore::RenderThemeGtk::addIntrinsicMargins): (WebCore::RenderThemeGtk::supportsFocus): (WebCore::RenderThemeGtk::determineState): (WebCore::RenderThemeGtk::determineShadow): (WebCore::RenderThemeGtk::getThemeData): (WebCore::RenderThemeGtk::setCheckboxSize): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::setRadioSize): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::adjustTextFieldStyle): (WebCore::RenderThemeGtk::paintTextField): (WebCore::RenderThemeGtk::paintTextArea): (WebCore::RenderThemeGtk::adjustButtonStyle): (WebCore::RenderThemeGtk::systemFont): (WebCore::RenderThemeGtk::gtkButton): (WebCore::RenderThemeGtk::gtkCheckbox): (WebCore::RenderThemeGtk::gtkRadioButton): (WebCore::RenderThemeGtk::gtkWindowContainer):
  • platform/gtk/RenderThemeGtk.h: Added.
  • platform/gtk/ScrollViewGdk.cpp: Removed.
  • platform/gtk/ScrollViewGtk.cpp: Added.
  • platform/gtk/SearchPopupMenuGdk.cpp: Removed.
  • platform/gtk/SearchPopupMenuGtk.cpp: Added.
  • platform/gtk/SoundGdk.cpp: Removed.
  • platform/gtk/SoundGtk.cpp: Added.
  • platform/gtk/WheelEventGdk.cpp: Removed.
  • platform/gtk/WheelEventGtk.cpp: Added.
  • platform/gtk/WidgetGdk.cpp: Removed.
  • platform/gtk/WidgetGtk.cpp: Added.
  • platform/network/ResourceHandle.h:

WebKitTools:
2007-09-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

  • GdkLauncher: Removed.
  • GdkLauncher/Bakefiles.bkgen: Removed.
  • GdkLauncher/ENV: Removed.
  • GdkLauncher/GdkLauncher.pro: Removed.
  • GdkLauncher/gdklauncher.bkl: Removed.
  • GdkLauncher/main.cpp: Removed.
  • GdkLauncher/mk: Removed.
  • GdkLauncher/simple.svg: Removed.
  • GdkLauncher/text.html: Removed.
  • GtkLauncher: Added.
  • GtkLauncher/GdkLauncher.pro: Removed.
  • GtkLauncher/GtkLauncher.pro: Added.
  • GtkLauncher/main.cpp: (updateWindowTitle): (main):
  • Scripts/build-webkit:
  • Scripts/regenerate-makefiles:
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-launcher:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
1:55 AM Changeset in webkit [25702] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=15025
Background repeat css property is not inherited from parent if unspecified

Don't let invalid url specification in background shorthand make
the entire shorthand invalid.

Note: See TracTimeline for information about the timeline view.