⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 28, 2007:

8:58 PM Changeset in webkit [25803] by aroben
  • 2 edits in trunk/WebCore

Fix <rdar://4965715> Horizontal scrollwheel scrolling moves in opposite direction on Vista

Reviewed by Sam.

No regression test possible.

  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use a negative delta when scrolling right to match EventHandler's expectations (which are based on AppKit).
8:26 PM Changeset in webkit [25802] by eseidel
  • 3 edits
    2 adds in branches/feature-branch

2007-09-28 Eric Seidel <​eric@webkit.org>

Reviewed by Sam Wenig.

ASSERT when dragging <svg:image> with non-null prefix
​http://bugs.webkit.org/show_bug.cgi?id=15308

  • bindings/objc/DOM.mm: (WebCore::lookupElementClass): added (WebCore::elementClass): use new lookupElementClass function
5:38 PM Changeset in webkit [25801] by bdash
  • 4 edits in trunk

Versioning.

5:37 PM Changeset in webkit [25800] by bdash
  • 1 copy in tags/Safari-4523.10

New tag.

5:36 PM Changeset in webkit [25799] by bdash
  • 1 copy in tags/Safari-5523.10

New tag.

2:56 PM Changeset in webkit [25798] by kdecker
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe

Build fix for Mac Gtk+ and Qt builds.


  • xml/XSLStyleSheet.cpp: Use PLATFORM(MAC) instead of PLATFORM(DARWIN)
  • xml/XSLTExtensions.cpp: Ditto.
2:49 PM Changeset in webkit [25797] by harrison
  • 6 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5511128> Crash closing or reloading this SVG

  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents): Use DocPtr instead of RefPtr, since these events are dispatched when the Document is being being torn down by removedLastRef().
  • dom/DocPtr.h: (WebCore::DocPtr::DocPtr): Fix longstanding typo in template so that the DocPtr(DocPtr) constructor can be used.
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::removedLastRef):
  • dom/Document.h: (WebCore::Document::selfOnlyRef): (WebCore::Document::selfOnlyDeref):
  • platform/Shared.h: (WebCore::Shared::Shared): (WebCore::Shared::ref): (WebCore::Shared::deref): (WebCore::Shared::hasOneRef): (WebCore::TreeShared::TreeShared): (WebCore::TreeShared::ref): (WebCore::TreeShared::deref): (WebCore::TreeShared::hasOneRef): (WebCore::TreeShared::refCount): Add debug-only checks for a document being ref-counted while being deleted.
11:31 AM Changeset in webkit [25796] by kmccullo
  • 8 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

  • <rdar://5261371> Nothing downloaded when exporting bookmarks from iGoogle web history
  • Implemented IWebHTTPURLResponse::allHeaderFields so that if the content disposition is "attachment" we will download the file instead of display it. Also implemented some missing functionality.
  • platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::isAttachment):
  • platform/network/ResourceResponse.h:

win:

Reviewed by Darin.

  • <rdar://5261371> Nothing downloaded when exporting bookmarks from iGoogle web history
  • Implemented IWebHTTPURLResponse::allHeaderFields so that if the content disposition is "attachment" we will download the file instead of display it. Also implemented some missing functionality.
  • HTTPHeaderPropertyBag.cpp: Added. (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag): (HTTPHeaderPropertyBag::createInstance): (HTTPHeaderPropertyBag::setResponse): (HTTPHeaderPropertyBag::response): (HTTPHeaderPropertyBag::QueryInterface): (HTTPHeaderPropertyBag::AddRef): (HTTPHeaderPropertyBag::Release): (ConvertFromLPCOLESTR): (ConvertToVariant): (ConvertFromVariant): (HTTPHeaderPropertyBag::Read): (HTTPHeaderPropertyBag::Write):
  • HTTPHeaderPropertyBag.h: Added.
  • Interfaces/IWebHTTPURLResponse.idl:
  • WebKit.vcproj/WebKit.vcproj:
  • WebURLResponse.cpp: (WebURLResponse::allHeaderFields): (WebURLResponse::isAttachment):
  • WebURLResponse.h:
8:37 AM Changeset in webkit [25795] by zecke
  • 3 edits in trunk/WebCore

2007-09-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Anders.

Implement PopupMenu using GtkMenu.

  • platform/PopupMenu.h:
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural): (WebCore::PopupMenu::menuItemActivated): (WebCore::PopupMenu::menuUnmapped): (WebCore::PopupMenu::menuPositionFunction): (WebCore::PopupMenu::menuRemoveItem):
8:36 AM Changeset in webkit [25794] by zecke
  • 2 edits in trunk/WebCore

2007-09-23 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Mark.

Obey the Coding-Style and move the asterisk to the
left to be part of the type.

  • platform/gtk/RenderThemeGtk.h:
6:45 AM Changeset in webkit [25793] by antti
  • 9 edits in trunk/LayoutTests

Reviewed by bdash.


Use frames instead windows for these tests. Closing windows reliably is difficult in DRT.

  • http/tests/security/resources/has-custom-property.html:
  • http/tests/security/resources/no-custom-property.html:
  • http/tests/security/window-properties-clear-domain-expected.txt:
  • http/tests/security/window-properties-clear-domain.html:
  • http/tests/security/window-properties-clear-port-expected.txt:
  • http/tests/security/window-properties-clear-port.html:
  • http/tests/security/window-properties-pass-expected.txt:
  • http/tests/security/window-properties-pass.html:

Sep 27, 2007:

10:56 PM Changeset in webkit [25792] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Ollie


  • fixed <rdar://problem/5408186> REGRESSION (5522-5523.9): Safari leaks every browser window


The leak started occurring when we removed the code to clear the delegates and the host window
from Safari as part of the fix for 5479443. But it turns out that Safari code was masking a
bug here in WebView: setHostWindow:nil needs to be called before setting _private->closed to
YES, or it will do nothing at all, causing a world leak due to a circular reference between
the window and the WebView.


I toyed with a more complex fix, but this is the simplest one that retains the fix for 5479443
while otherwise restoring the code order to be as close as possible to what it was before
5479443 was fixed.

  • WebView/WebView.mm: (-[WebView _close]): Moved the call that sets _private->closed to YES to be after the code that clears the delegates and the host window. Added a comment about this order.
10:50 PM Changeset in webkit [25791] by sfalken
  • 1 edit
    1 add in trunk/JavaScriptCore/JavaScriptCore.vcproj

Internal build fix

10:20 PM Changeset in webkit [25790] by sfalken
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore.make

Internal build fix

6:28 PM Changeset in webkit [25789] by antti
  • 4 edits in trunk/LayoutTests

Reviewed by NOBODY.


Update tests to hopefully fix occasional failures

  • fast/dom/Window/window-early-properties.html:
  • http/tests/security/resources/has-custom-property.html:
  • http/tests/security/resources/no-custom-property.html:
6:01 PM Changeset in webkit [25788] by bdash
  • 12 edits in trunk

2007-09-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Reflected in existing tests.

  • css/html4.css: Changed listboxes to use border-box sizing, to match Firefox, WinIE and apparently also Safari 2.

2007-09-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/forms/listbox-clip-expected.checksum:
  • fast/forms/listbox-clip-expected.png:
  • fast/forms/listbox-clip-expected.txt:
  • fast/forms/listbox-selection-2.html:
  • fast/forms/select-item-background-clip.html:
  • fast/forms/select-list-box-with-height-expected.checksum:
  • fast/forms/select-list-box-with-height-expected.png:
  • fast/forms/select-list-box-with-height-expected.txt:
  • fast/text/drawBidiText.html:
5:06 PM Changeset in webkit [25787] by kdecker
  • 1 edit in trunk/WebKit/ChangeLog

Tweaked ChangeLog comment..

5:04 PM Changeset in webkit [25786] by kdecker
  • 2 edits
    1 add in trunk/JavaScriptCore

Rubber stamped by John Sullivan.

<rdar://problem/5493093>


  • JavaScriptCore.order: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj: We're changing from using an order file built by another team to using one we actually check into our project repository. Linker settings for Symbol Ordering Flags have been updated accordingly.
5:03 PM Changeset in webkit [25785] by kdecker
  • 2 edits
    1 add in trunk/WebCore

<rdar://problem/5493093>


Rubber stamped by John Sullivan.


  • WebCore.order: Added.
  • WebCore.xcodeproj/project.pbxproj: We're changing from using an order file built by another team to using one we actually check into our project repository. Linker settings for Symbol Ordering Flags have been updated accordingly.
5:01 PM Changeset in webkit [25784] by adachan
  • 3 edits in trunk/WebKit/win

<rdar://problem/5507481> Added a delegate method to inform the client
app that WebView has painted.

Reviewed by Steve.

  • Interfaces/IWebUIDelegatePrivate.idl:
  • WebView.cpp: (WebView::updateBackingStore):


4:56 PM Changeset in webkit [25783] by antti
  • 8 edits
    10 adds in trunk

WebCore:

Reviewed by Geoff.


Fix for <rdar://problem/5499125>
REGRESSION (r21367): After launching Kidzui beta, a webview frame fails to appear in its main window


If window object properties were modified when it had initial empty document (synchronously after
window.open() for example) those modifications were lost when the real document was switched in.


Match Firefox behavior where window properties are not cleared if the inital document and the loaded one
have matching security domains.

Tests: fast/dom/Window/window-early-properties.html

http/tests/security/window-properties-clear-domain.html
http/tests/security/window-properties-clear-port.html
http/tests/security/window-properties-pass.html

  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::isSecureTransition): (WebCore::FrameLoader::begin):
  • loader/FrameLoader.h: If we are transitioning from initial empty document to the final one, do a domain security check between old security policy URL and new URL. If that passes don't clear script proxy and script objects.


  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper):
  • bindings/js/kjs_proxy.h:
  • page/Frame.cpp: (WebCore::Frame::setDocument): Since we don't always clear window properties anymore, we need to update the document property to point to the newly created one.

LayoutTests:

Reviewed by Geoff.


Tests for <rdar://problem/5499125>
REGRESSION (r21359-21368): After launching Kidzui beta, a webview frame fails to appear in its main window

  • fast/dom/Window/window-early-properties-expected.txt: Added.
  • fast/dom/Window/window-early-properties.html: Added.
  • http/tests/security/resources/has-custom-property.html: Added.
  • http/tests/security/resources/no-custom-property.html: Added.
  • http/tests/security/window-properties-clear-domain-expected.txt: Added.
  • http/tests/security/window-properties-clear-domain.html: Added.
  • http/tests/security/window-properties-clear-port-expected.txt: Added.
  • http/tests/security/window-properties-clear-port.html: Added.
  • http/tests/security/window-properties-pass-expected.txt: Added.
  • http/tests/security/window-properties-pass.html: Added.
4:53 PM Changeset in webkit [25782] by kdecker
  • 2 edits
    1 add in trunk/WebKit

Rubber stamped by Darin.

<rdar://problem/5493093>

  • WebKit.order: Added.
  • WebKit.xcodeproj/project.pbxproj: Altered build settings to use the new order file project instead of AppleInternal.
4:18 PM Changeset in webkit [25781] by kdecker
  • 6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5493093>


  • WebCore.xcodeproj/project.pbxproj: Removed libxslt from statically linked frameworks.
  • platform/mac/SoftLinking.h: Formatting tweakes, added SOFT_LINK_LIBRARY, and if'def for PLATFORM(DARWIN)
  • xml/XSLStyleSheet.cpp: Soft-linked libxslt.
  • xml/XSLTExtensions.cpp: Removed the call to xsltGenericError, and added a FIXME comment stating that it might be helpful to push any errors from xmlXPathNewValueTree up to the Javascript Console.
  • xml/XSLTProcessor.cpp: Soft-linked libxslt.
3:55 PM Changeset in webkit [25780] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by John.

  • Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
  • Scripts/run-webkit-tests:
3:06 PM Changeset in webkit [25779] by adele
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Fix for <rdar://problem/5453350> REGRESSION (r18541, Tiger only): Refreshing a cached https page does not reload CSS and JavaScript resources
​http://bugs.webkit.org/show_bug.cgi?id=15121

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Now sets the cache policy to ReloadIgnoringCacheData. Without setting the cache policy, the default policy in this case was ReturnCacheDataElseLoad. If we're in a situation where the resource is in the cache, we want to make sure to avoid loading from the cache in this case.
2:26 PM Changeset in webkit [25778] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Correction, NSURLConnection not CFURLConnection.

2:24 PM Changeset in webkit [25777] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5199546> CrashTracer: [REGRESSION] 8216 crashes in Safari at com.apple.WebCore: WebCore::ResourceHandle::client const + 6

On Tiger CFURLConnection can sometimes call the connection:willCacheResponse: delegate method on
a secondary thread instead of the main thread. This was never an issue before, since the implementation
of this method was very simple and thread safe.

The fix is to block during connection:willCacheResponse: and perform the work on the main thread.
We need to block since this delegate method needs to return a result. If we are already on the
main thread (which sometimes we are), the method does nothing different. If we are on a secondary
thread, we make a mutable dictionary to hold all the arguments and later the result object.
Then performSelectorOnMainThread:withObject: using the _callConnectionWillCacheResponseWithInfo:
selector. This new method just pulls the arguments out for the dictionary and calls the real
connection:willCacheResponse: delegate method (this time on the main thread). The result is stored
in the dictionary, and when performSelectorOnMainThread:withObject: finishes the result is pulled
out and returned.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate _callConnectionWillCacheResponseWithInfo:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
9:57 AM Changeset in webkit [25776] by weinig
  • 2 edits in trunk/WebKitLibraries

Build fix. Ran update-webkitsysteminterface script on Tiger, because
the resulting binary differs when built on Tiger.

  • libWebKitSystemInterface.a:
9:18 AM Changeset in webkit [25775] by hyatt
  • 3 edits in trunk/WebKitLibraries

Update WebKitSYstemInterface for @font-face changes.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
9:10 AM Changeset in webkit [25774] by hyatt
  • 4 edits in trunk/WebCore

Update to reflect the minimal WebKitSystemInterface changes required
to support @font-face.

Reviewed by john

  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit): (WebCore::FontData::platformWidthForGlyph):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
Note: See TracTimeline for information about the timeline view.