Timeline

Oct 1, 2007:

11:46 PM Changeset in webkit [25910] by lars

• 4 edits in trunk

Fix a wrong extension mapping in the MIMETypeRegistry and identify about: url's as frames in the FrameLoaderClient.

11:12 PM Changeset in webkit [25909] by oliver

• 3 edits in branches/feature-branch/LayoutTests

Correcting expected layout test results

RS = Eric

• fast/dom/Window/window-properties-expected.txt:
• fast/images/svg-as-image-expected.txt:

10:36 PM Changeset in webkit [25908] by eseidel

• 4 edits
  10 adds in branches/feature-branch

2007-10-01 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver Hunt.

SVG Subresources will not be saved when creating WebArchives
​http://bugs.webkit.org/show_bug.cgi?id=15280

Implement _subresourceURLs methods for more SVGElement types
more such methods will be needed as we add support for other
external references (such as use, mpath, tref, etc.)

• DOM/WebDOMOperations.mm: (-[DOMSVGScriptElement _subresourceURLs]): added. (-[DOMSVGCursorElement _subresourceURLs]): added. (-[DOMSVGFEImageElement _subresourceURLs]): added.

10:28 PM Changeset in webkit [25907] by eseidel

• 3 edits
  3 adds in branches/feature-branch

2007-10-01 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver Hunt.

WebArchives do not embed stylesheets referenced by xml-stylesheeet
​http://bugs.webkit.org/show_bug.cgi?id=15320

• DOM/WebDOMOperations.mm: (-[DOMProcessingInstruction _stylesheetURL]): needed to access [[self sheet] href] (-[DOMProcessingInstruction _subresourceURLs]): call and return _stylesheetURL

10:19 PM Changeset in webkit [25906] by eseidel

• 9 edits
  2 moves
  2 adds in branches/feature-branch

2007-10-01 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver Hunt.

This only affects Debug builds, and the ability to save SVGs as WebArchives
neither are testable via DumpRenderTree.

• Configurations/WebCore.xcconfig: change where Xcode looks for WebCore.exp
• DerivedSources.make: adds SVG symbols to WebCore.exp when necessary
• WebCore.SVG.exp: Added.
• WebCore.exp: moved to WebCore.base.exp
• WebCore.xcodeproj/project.pbxproj: updated to reflect moved files
• bindings/objc/DOMSVGExecption.h: moved to DOMSVGException.h

10:07 PM Changeset in webkit [25905] by bdash

• 2 edits in branches/feature-branch/WebKitTools

2007-10-01 Mark Rowe <​mrowe@apple.com>

• BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.

10:06 PM Changeset in webkit [25904] by bdash

• 2 edits in trunk/WebKitTools

2007-10-01 Mark Rowe <​mrowe@apple.com>

• BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.

9:53 PM Changeset in webkit [25903] by oliver

• 6 edits in branches/feature-branch

Enable Experimental SVG features by default when building from Xcode

Reviewed by Mark

• Configurations/JavaScriptCore.xcconfig:
• Configurations/WebCore.xcconfig:
• Configurations/WebKit.xcconfig:

9:43 PM Changeset in webkit [25902] by eseidel

• 19 edits in branches/feature-branch/WebCore

2007-10-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Make feature-branch build again with ENABLE_SVG_EXPERIMENTAL_FEATURES
Needed a double -> float change to make the new filter types build.

Build fix, no test cases.

• ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
• ksvg2/svg/SVGComponentTransferFunctionElement.h:
• ksvg2/svg/SVGFECompositeElement.cpp:
• ksvg2/svg/SVGFECompositeElement.h:
• ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
• ksvg2/svg/SVGFEDiffuseLightingElement.h:
• ksvg2/svg/SVGFEDisplacementMapElement.cpp:
• ksvg2/svg/SVGFEDisplacementMapElement.h:
• ksvg2/svg/SVGFEGaussianBlurElement.cpp:
• ksvg2/svg/SVGFEGaussianBlurElement.h:
• ksvg2/svg/SVGFELightElement.cpp:
• ksvg2/svg/SVGFELightElement.h:
• ksvg2/svg/SVGFEOffsetElement.cpp:
• ksvg2/svg/SVGFEOffsetElement.h:
• ksvg2/svg/SVGFESpecularLightingElement.cpp:
• ksvg2/svg/SVGFESpecularLightingElement.h:
• ksvg2/svg/SVGFETurbulenceElement.cpp:
• ksvg2/svg/SVGFETurbulenceElement.h:

6:53 PM Changeset in webkit [25901] by oliver

• 1 move in branches/feature-branch

Rebased feature-branch is now the primary feature-branch

6:53 PM Changeset in webkit [25900] by oliver

• 1 move in branches/feature-branch-2007-10-01

Renaming old feature branch to allow rebased feature-branch to take over

6:49 PM Changeset in webkit [25899] by justing

• 7 edits
  1 add
  1 delete in trunk

WebCore:

Reviewed by Harrison.

<rdar://problem/5516183> REGRESSION: Creating a ToDo on an incoming message fails

Rolling out r25721.

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
• editing/ReplaceSelectionCommand.h:

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5516183> REGRESSION: Creating a ToDo on an incoming message fails

• editing/pasteboard/5483567.html: Removed.
• editing/pasteboard/5483567.html-disabled: Added.
• editing/pasteboard/nested-blocks-with-text-area-expected.txt:
• editing/pasteboard/nested-blocks-with-text-field-expected.txt:
• editing/pasteboard/paste-RTFD-expected.txt:

6:47 PM Changeset in webkit [25898] by oliver

• 3 edits in branches/rebased-feature-branch

Adding merge markers to feature branch changelog

5:59 PM Changeset in webkit [25897] by oliver

• 3 edits
  2 adds in branches/rebased-feature-branch

2007-09-30 Julien <​julien.chaffraix@gmail.com>

Reviewed by aroben & eseidel.

fix ​http://bugs.webkit.org/show_bug.cgi?id=14898

getAllResponseHeaders() separates each header with a CR LF according to the specification

Test: http/tests/xmlhttprequest/xmlhttprequest-crlf-getAllResponseHeader.html

• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders):

5:59 PM Changeset in webkit [25896] by oliver

• 5 edits in branches/rebased-feature-branch

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=13472
Misparsing date in javascript leads to year value of -1
​http://bugs.webkit.org/show_bug.cgi?id=14176
Some date values not handled consistently with IE/Firefox

Allow an optional comma between month and year, and year and time.

5:58 PM Changeset in webkit [25895] by oliver

• 3 edits
  2 adds in branches/rebased-feature-branch

2007-09-28 Eric Seidel <​eric@webkit.org>

Reviewed by Sam Wenig.

ASSERT when dragging <svg:image> with non-null prefix
​http://bugs.webkit.org/show_bug.cgi?id=15308

• bindings/objc/DOM.mm: (WebCore::lookupElementClass): added (WebCore::elementClass): use new lookupElementClass function

5:58 PM Changeset in webkit [25894] by oliver

• 2 edits in branches/rebased-feature-branch/WebCore

2007-09-25 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

I managed to break the SVG build when fixing the --no-svg build for
​http://bugs.webkit.org/show_bug.cgi?id=15281
This adds the appropriate DOMSVG headers to the copy headers phase
(in fixing the no-svg build I mistakenly re-marked them project-only)

• WebCore.xcodeproj/project.pbxproj:

5:58 PM Changeset in webkit [25893] by oliver

• 2 edits in branches/rebased-feature-branch/WebKitTools

2007-09-25 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

DerivedSources.make was finding "ENABLE_SVG" in the string
"ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
quite correctly.

• Scripts/build-webkit: make --no-svg imply --no-svg-experimental

5:58 PM Changeset in webkit [25892] by oliver

• 2 edits in branches/rebased-feature-branch/WebCore

2007-09-25 Eric Seidel <​eric@webkit.org>

Reviewed by Rob Bius.

Already tested by SVG/W3C-SVG-1.1/linking-a-07-t.svg

• ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): properly pass along target values

Correct the spelling of Rob's name

5:58 PM Changeset in webkit [25891] by oliver

• 1 edit in branches/rebased-feature-branch/WebKitTools/ChangeLog

2007-09-25 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Eric.

• BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line. This makes it possible to automate nightly builds for the feature-branch.

5:57 PM Changeset in webkit [25890] by oliver

• 14 edits
  24 adds in branches/rebased-feature-branch

Reviewed by Oliver.

Rework <pattern> support to take overflow & viewBox into account.
Also fix all possible combinations of patternUnits/patternContentUnits, tested by several batik testcases.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12221 (Webkit ToT fails to render this pattern example)

Reviewed by NOBODY (Build fix).

• platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::renderPath):
• rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):

5:57 PM Changeset in webkit [25889] by oliver

• 8 edits
  1 move
  8 adds in branches/rebased-feature-branch

Reviewed by Oliver.
Fix <mask> in userSpaceOnUse coordinates. Verified by new testcase taken from Batik.

Reviewed by Anders.

Fix paths to css style sheets in the last added files. Enable smallFonts.svg as it doesn't crash anymore.
Fix paths to external <use> element reference, to make Batik happy. (We don't support it, yet.)

5:57 PM Changeset in webkit [25888] by oliver

• 20 edits in branches/rebased-feature-branch/WebCore

Reviewed by Oliver.

Rewrite text painting code path, to be based on "text chunks" instead of using the InlineBox* hierarchy.
This allows us to reuse paint servers as long as possible - and to actually paint in the way didacted by the spec.

This also implements advanced SVG text decorations (ie. stroked/filled decos with gradient/pattern).
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=7200 (Gradient appears and disappears in SVG when text is off screen)

Fixes paint server usage on text paths. (ie. styled text paths, with gradients/filters).

(Oops, forgot to commit WebCore/ changes!)
Reviewed by Oliver.

Rewrite text painting code path, to be based on "text chunks" instead of using the InlineBox* hierarchy.
This allows us to reuse paint servers as long as possible - and to actually paint in the way didacted by the spec.

This also implements advanced SVG text decorations (ie. stroked/filled decos with gradient/pattern).
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=7200 (Gradient appears and disappears in SVG when text is off screen)

Fixes paint server usage on text paths. (ie. styled text paths, with gradients/filters).

5:56 PM Changeset in webkit [25887] by oliver

• 7 edits in branches/rebased-feature-branch/WebCore

Reviewed by Mitz.

Expose unitsPerEm() in Font classes.
This is needed to implement SVG's advanced text decorations. We won't draw lines for text-decorations
but fillable & strokable rectangles with a certain height, computed through unitsPerEm & font size.

5:56 PM Changeset in webkit [25886] by oliver

• 1 edit in branches/rebased-feature-branch/WebCore/ChangeLog

Reviewed by NOBODY (Build fix).

Initialise iterators to appease gcc

• rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::closestCharacterToPosition):

5:56 PM Changeset in webkit [25885] by oliver

• 10 edits
  5 adds in branches/rebased-feature-branch

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12059
SVG colors have two separate parsing paths (one CSS and one SVGColor::setRGBColor)

Reuse the css parser as much as possible in setRGBColor.

Rubberstamped by Mark.
Add missing SVG filter testcase (forgot to include in last commit).

5:55 PM Changeset in webkit [25884] by oliver

• 195 edits in branches/rebased-feature-branch

Reviewed by Oliver.

Large SVG filter rework. Bring it back in a useable state.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5527 (Filters need subregion support)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5579 (WebKit+SVG renders full-filters-example incorrectly)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5976 (filterUnits="userSpaceOnUse" is broken (breaking feTile test case))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12064 (Need function for manual style-resolution for things like gradient stops)

filters-blend-01-b.svg & filters-example-01-b.svg & filters-displace-01-b.svg & filters-diffuse-01-f.svg are fixed now.

In detail:

• flood-color & flood-opacity have been incorrectly resolved on the <feBlend> parent element!
• sizing of filter region was truncated in some cases, as the bbox was used to resolve the needed filter region instead of the filter rect
• add subregion support to all filter primitives (primitiveUnits & filterUnits handled in all cases)
• WKDisplacmentMap.cikernel incorrectly flipped the y-axis.
• Correctly specify default values for all filter primitives in ksvg2/svg!
• Initialize all variables of the SVGFE* classes in platform/graphics/svg/filters.
• Fix 'flood-color' initial value (was set to the _stop_ color initial value)

-> both initial values were pointing to 'black' though, so it was no visible problem.

• Parse 'lighting-color' css property, no more hacking in SVGFEDiffuseLighting.

-> Correct it's initial from black to white value fixes SVG lighting filters!

• Add diffuseConstant support to feDiffuseLighting filter.
• Centralize manual style resolution (needed for stop-color, flood-color & flood-opacity, lighting-color)

5:55 PM Changeset in webkit [25883] by oliver

• 3 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=14924
rotated rect with pattern draws incorrectly

Use the bounding box before transformation.

5:54 PM Changeset in webkit [25882] by oliver

• 33 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=14926
WebKit has 'em' length handling problems related to CSS properties

Parse the properties in inline style attributes non-strict for SVG.

5:54 PM Changeset in webkit [25881] by oliver

• 4 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=14927
use element in SVG does not render after parent is displayed off and on

Also detach the shadow tree when detaching the <use>.

5:53 PM Changeset in webkit [25880] by oliver

• 67 edits
  2 adds in branches/rebased-feature-branch

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14153

Final, long-awaited RenderSVGContainer split. Make RenderSVGContainer really a simple
container without special cases for inner <svg> elements or <marker>. Create a new
RenderSVGViewportContainer class handling these cases now.

5:53 PM Changeset in webkit [25879] by oliver

• 50 edits
  8 adds in branches/rebased-feature-branch

Reviewed by Oliver & Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12501 (SVG Text fails to respect opacity, fill-opacity and stroke-opacity)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14045 (Incorrect support for opacity, fill-opacity and stroke-opacity)

Based on an older patch from Rob, this fixes SVG text opacity as well as group opacity for solid fills & gradients.
The pattern changes are still missing a testcase (need to wait for Antoine Quint for that).

5:52 PM Changeset in webkit [25878] by oliver

• 21 edits
  8 adds in branches/rebased-feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=11909
Regression: large SVG from Illustrator comes out blank

Fix last issue with the Illustrator file by making relativeBBox
calculation take into account viewBox.

5:52 PM Changeset in webkit [25877] by oliver

• 128 edits in branches/rebased-feature-branch

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14896 (SVG InlineText/Flow box sizes don't take rotated glyphs into account)

Introduce new helper function calculateGlyphBoundaries, which takes into account any per-character transformation.
This fixes box size calculations in svg/W3C-SVG-1.1/text-text-07-t.svg, svg/batik/text/textEffect3.svg (rotated glyphs)
-> These strings can be properly selected now, just as well as text path elements.

5:51 PM Changeset in webkit [25876] by oliver

• 96 edits in branches/rebased-feature-branch

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13909 (SVG text selection doesn't work with RTL text)

Use drawHighlightForText() to draw the selection, instead of my home-brewn solution.
Affected code in SVGRootInlineBox::paintSelectionForTextBox. Removed not anymore needed
helper function cummulatedWidthOfSelectionRange.

Dump all contained InlineTextBox(es) in SVGRenderTreeAsText, take into account multiple
child text boxes in ie. a RenderSVGInlineText objects (which happens for RTL text and
LTR text cases where newlines were involved - see changed testcase results.)
This affects a lot of LTR tests which actually had more than one child text box, that
wasn't taken properly into account before (in terms of selection, not rendering.)

Fix selection for RTL text by taking box start offsets into account in closestCharacterToPosition()
and by offering RTL text selection special cases in svgCharacterHitsPosition().

Centralized the creation of a TextStyle object for text selection/painting in a new helper function
svgTextStyleForInlineTextBox. Add new helper functions calculateGlyphWidth/calculateGlyphHeight to
centralize these calculations -> use these new helpers everywhere to avoid code duplication.

A single fix in bidi.cpp was needed to fix SVG's unicode-bidi/direction handling, to fix text-intro-02-b.svg.
SVG didacts that the 'direction' attribute is ignored if unicode-bidi is set to 'normal' (default).
Discussed with Mitz.

5:50 PM Changeset in webkit [25875] by oliver

• 2 edits in branches/rebased-feature-branch/WebCore

Reviewed by Oliver.

Do not export some symbols for internal functions, saves some bytes.

5:49 PM Changeset in webkit [25874] by oliver

• 72 edits in branches/rebased-feature-branch

Reviewed by Oliver & Rob.

Enable SVG textPath selection. Actually build chunks for them instead of
ignoring them - was easier than I thought. Respect per-character transformation
when calculating the chunk boundaries for the selection rectangles. Also fixes
selection rect drawing of rotated characters.

Next thing todo is to unify the glyph size calculations, as per-glyph transformations
are not respected when calculating flow box sizes in SVGRootInlineBox.

5:49 PM Changeset in webkit [25873] by oliver

• 4 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=14312
Removing an attribute has no effect on SVG

Update the transform matrix also when transform attribute is empty.

5:48 PM Changeset in webkit [25872] by oliver

• 3 edits in branches/rebased-feature-branch/WebCore

Reviewed by Oliver.

Unify absoluteRects() of RenderSVGTSpan & RenderSVGTextPath.
The RenderSVGTextPath one was still using the old, wrong concept.

5:47 PM Changeset in webkit [25871] by oliver

• 4 edits in branches/rebased-feature-branch/WebCore

Reviewed by Sam.

Let <textPath> be recognized within the ObjC bindings.
Forgot to add that months ago.

5:46 PM Changeset in webkit [25870] by oliver

• 12 edits
  105 adds in branches/rebased-feature-branch

Reviewed by Oliver.
Fix all known bugs regarding to SVG text selection, when embedded in XHTML.
Also fix inspecting <text> elements when embedded in XHTML. (WebInspector)

5:46 PM Changeset in webkit [25869] by oliver

• 28 edits
  31 adds in branches/rebased-feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=5996
SVG <view> is unimplemented

Implement <view> and refactor the code in the svg renderer container classes.

Build fix. Not reviewed.
Rob forgot to land the changes to SVGResourceMarker in his last commit.

5:45 PM Changeset in webkit [25868] by oliver

• 8 edits
  16 adds in branches/rebased-feature-branch

Reviewed by Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13611 (Crash in setAttributeNS setting href of SVG <use> to nonexistent symbol)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14631 (<use> doesn't deep-expand <symbol> elements.)

Rework <use> on <foreignObject> cases, to not just ignore these cases, but actually proceed and skip <fO> objects
from the resulting cloned tree. This fixes parts of "treasure_map.svg" (no bug report availabe on that one, private "testcase").

Fix assertion happening with <use> on <g> containing <symbol>. Introduce expandSymbolElementsInShadowTree()
concept, just like it's done for <use> on <use>, to deep-replace all <symbol> elements by <svg>, as demanded
by the spec. This only worked on <use> on <symbol> direct cases so far.

5:44 PM Changeset in webkit [25867] by oliver

• 6 edits in branches/rebased-feature-branch

Reviewed by Rob.

Fix invisible-text-after-scrolling.xhtml regression. Scroll offset not
taken into account properly. Also fix RenderSVGInlineText::selectionRect(),
so that SVG text can be selected, when being embedded in XHTML.

5:43 PM Changeset in webkit [25866] by oliver

• 610 edits
  8 adds in branches/rebased-feature-branch

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5940 (<svg> inside <body> incorrectly extends over top/bottom borders)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14145 (RenderSVGContainer should not inherit from RenderContainer)

Make RenderSVGContainer inherit from RenderObject directly, instead of RenderContainer.
Itdoes a lot of things that we don't need for SVG, and by removing this inheritance
we can finally fix the differences about SVG object positioning, as we don't need
parent translation (tx/ty). Fixes SVG text rendering within XHTML.

Fix requireLayer() function on RenderSVGRoot, as it can actually be a layer now.
This change is based on Rob's patch at 5940 - fixing z-order indexing.

Change RenderSVGRoot renderName() and update all layout tests, because of this change.

Fix absoluteRects() function for RenderSVGInlineText & RenderSVGTSpan.
Checked extensively using WebInspector, to assure all rects are correctly displayed.

Testcases fixed: junk-data.svg, missing-xlink.svg hixie/013.xml (all regressions!)
(junk-data.svg & missing-xlink.svg previously relied on SVG text painting out of <svg> overflow rect.

Fix these testcases, as within this new RenderSVGContainer concept, that bug is now fixed, and breaks them)

Testcases added: custom/absolute-sized-svg-in-xhtml.xhtml, custom/inline-svg-in-xhtml.xml (Mozilla XTech demo)

5:42 PM Changeset in webkit [25865] by oliver

• 1 edit in branches/rebased-feature-branch/JavaScriptCore/ChangeLog

Reviewed by Mark.

Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.

5:41 PM Changeset in webkit [25864] by oliver

• 88 edits in branches/rebased-feature-branch

Rubber stamped by Mark.

WebKitTools:
Enable svg experimental features as default here in feature-branch.

LayoutTests:
Land new test results with experimental features on by default.
Files showing regressions have NOT been updated, of course.

5:40 PM Changeset in webkit [25863] by oliver

• 33 edits in branches/rebased-feature-branch

WebCore:
Reviewed by Sam.

Remove all "SVGElement* m_context" parameters spread over SVG primitives
(like SVGAngle, SVGPreserveAspectRatio, SVGTransformList, ...)

This is all handled by the JS generation in the bindings now, leading
to a faster static rendering codepaths, and easier handling of the dynamic
parts like JS scripting. Remove the mystified genericContext() concept alltogether.

Add bug number reference missing in the last ChangeLog entry.

LayoutTests:
Reviewed by Sam.
Check in correct results, now that the hashing bug is fixed here as well.

Conflicts:

WebCore/bindings/scripts/CodeGeneratorJS.pm
WebCore/ksvg2/svg/SVGPathSegList.cpp
WebCore/ksvg2/svg/SVGPathSegList.h

5:39 PM Changeset in webkit [25862] by oliver

• 19 edits
  1 copy
  4 adds in branches/rebased-feature-branch

Reviewed by Sam.

Recognizee <textPath> in SVG JS bindings.
Add JSSVGTextPathElement to JSSVGElementWrapperFactory.

Add SVGException.idl just for the JS generation.
Turn on all SVG JS constructors and add them to DOMWindow.idl.

Testcase added: LayoutTests/svg/custom/js-svg-constructors.svg

Forgot to commit the ChangeLog and two files in my last commit!

5:38 PM Changeset in webkit [25861] by oliver

• 2 edits in branches/rebased-feature-branch/LayoutTests

Correcting the pixel test result that was supposed to go in during r23849.

5:37 PM Changeset in webkit [25860] by oliver

• 2 edits in branches/rebased-feature-branch/WebKitTools

Add VIDEO build flag

5:35 PM Changeset in webkit [25859] by oliver

• 3 edits in branches/rebased-feature-branch/JavaScriptCore

Reviewed by Maciej.

Use intHash to hash floats and doubles too.

• ChangeLog:
• wtf/HashFunctions.h: (WTF::FloatHash::hash): (WTF::FloatHash::equal): (WTF::):
• wtf/HashTraits.h: (WTF::FloatHashTraits::emptyValue): (WTF::FloatHashTraits::deletedValue): (WTF::):

5:34 PM Changeset in webkit [25858] by oliver

• 4 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14241
SVG <image> with height or width less than 1 fails to render image

Keep extra member vars to get width/height as floats for accurate
calculations.

5:33 PM Changeset in webkit [25857] by oliver

• 4 edits
  2 moves
  2 adds
  2 deletes in branches/rebased-feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=9976
Fix negative width issue in Hixie's test

Refuse to render zero or negative width/height.

5:32 PM Changeset in webkit [25856] by oliver

• 14 edits
  8 adds in branches/rebased-feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12062
WebCore does not handle CSS-specified fill fallback correctly

Implement fallback for fill and stroke.

5:31 PM Changeset in webkit [25855] by oliver

• 5 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=14157
Rotated shape has wrong gradient rendering

Use the untransformed bbox in objectBoundingBoxMode. Also
don't do objectBoundingBoxMode should the bbox width ort height
be zero.

5:29 PM Changeset in webkit [25854] by oliver

• 40 edits
  20 adds in branches/rebased-feature-branch

Reviewed by Eric & Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14198

Reeanble <foreignObject>. Explicitely disallow <use> on <foreignObject>
as it may lead to bad problems.

While I'm at it disallow <use> on any non-svg element.

Not reviewed.
Forgot to commit new layout tests results, now that <foreignObject> is enabled again.

5:27 PM Changeset in webkit [25853] by oliver

• 9 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=14144
All tx/ty (parentX/parentY) usage should be removed from SVG renders
​http://bugs.webkit.org/show_bug.cgi?id=13981
<br> prevents click handler from firing

Fix the hit testing issues by making RenderSVGRoot take its m_x, m_y
into account in the absolute transform.

5:25 PM Changeset in webkit [25852] by oliver

• 19 edits
  9 adds in branches/rebased-feature-branch

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14015 (SVGTransformList::initialize() has no effect)

Fix SVGTransformList usage in SVG DOM exposed to JS.
This also fixes SVG space invaders including most repainting issues. (still some unrelated ones left)

This is basically the _same_ fix applied to SVGPointList some months ago. We just forgot
to add JSSVGTransformListCustom when switching from SVGTransform* -> SVGTransform (POD type).

5:23 PM Changeset in webkit [25851] by oliver

• 4 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Eric.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14155

JSSVGMatrix was not working properly.
"matrix.translate(10, 10)" actually altered 'matrix' instead of returning a
new SVGMatrix object, as described in SVG 1.1 specification.

5:22 PM Changeset in webkit [25850] by oliver

• 2 edits in branches/rebased-feature-branch/WebCore

2007-06-15 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Fix the release build.

• rendering/SVGRootInlineBox.cpp: (WebCore::applyTextAnchorToTextChunk):

5:21 PM Changeset in webkit [25849] by oliver

• 3 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=14051
<svg:image> fails to position correctly when <svg> is inside an inline <div>

Leave parent translation to the containers.

5:20 PM Changeset in webkit [25848] by oliver

• 5 edits in branches/rebased-feature-branch/WebCore

Reviewed by Eric.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13963

Fix SVG space invaders. It actually highlighted a bad problem with our JSSVGPODTypeWrapper's.
Introduce a new "2nd-level cache" for all readwrite POD properties. Subsequent calls to ie.
myRect.x.baseVal.value don't create a new wrapper everytime, but are properly cached now.
This leads to a massive reduction in created wrappers.

5:18 PM Changeset in webkit [25847] by oliver

• 4 edits in branches/rebased-feature-branch/WebCore

2007-06-14 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Text gradients are broken on feature branch
​http://bugs.webkit.org/show_bug.cgi?id=14142

• rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent):
• rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes): (WebCore::SVGRootInlineBox::paintChildInlineTextBox): (WebCore::SVGRootInlineBox::paintChildInlineFlowBox):
• rendering/SVGRootInlineBox.h:

5:17 PM Changeset in webkit [25846] by oliver

• 2 edits in branches/rebased-feature-branch/WebCore

Reviewed by Sam.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11273

Implement pixelUnitToMillimeterX(), pixelUnitToMillimeterY() in SVGSVGElement.
Use cssPixelsPerInch, just like done in CSSPrimitiveValue & SVGLength.

5:16 PM Changeset in webkit [25845] by oliver

• 2 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=9752
%-sizing of elements with a html parent is broken

Calculate width/height for length percentages when embedded in xhtml.

5:14 PM Changeset in webkit [25844] by oliver

• 20 edits
  2 copies
  2 deletes in branches/rebased-feature-branch/WebCore

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12207
RenderSVGContainer should be split into multiple classes
​http://bugs.webkit.org/show_bug.cgi?id=14125
KCanvasRenderingStyle should be removed

Introduce the RenderSVGRoot class and kill the KCanvas enums.

Build fix.

5:13 PM Changeset in webkit [25843] by oliver

• 2 edits in branches/rebased-feature-branch/WebCore

Reviewed by Eric.
Fix regression: SVG images drawn in the wrong paint phase.

5:11 PM Changeset in webkit [25842] by oliver

• 3 edits
  4 adds in branches/rebased-feature-branch

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=14064
fill property is reported as type SVGColor

Do the checks in the right order.

Change merged into WebCore/bindings/js/JSCSSValueCustom.cpp

5:09 PM Changeset in webkit [25841] by oliver

• 8 edits in branches/rebased-feature-branch/WebCore

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12122
SVGPathElement should not inherit from SVGPathParser

Use path builders for building Path and PathSegLists.

5:08 PM Changeset in webkit [25840] by oliver

• 4 edits in branches/rebased-feature-branch/WebCore

2007-06-06 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Add support for tabbing between links in an SVG file
Also add support for drawing a focus ring around focused svg content.
​http://bugs.webkit.org/show_bug.cgi?id=8823

Layout test is blocked by ​http://bugs.webkit.org/show_bug.cgi?id=14027

• css/svg.css:
• ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable): (WebCore::SVGAElement::isMouseFocusable): (WebCore::SVGAElement::isKeyboardFocusable):
• ksvg2/svg/SVGAElement.h:

5:06 PM Changeset in webkit [25839] by oliver

• 9 edits
  4 adds in branches/rebased-feature-branch

2007-06-06 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Make SVG (mostly) support CSS outline property (and thus focus rings)
​http://bugs.webkit.org/show_bug.cgi?id=10849

Test: svg/custom/focus-ring.svg

• rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::RenderPath::addFocusRingRects):
• rendering/RenderPath.h:
• rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::addFocusRingRects):
• rendering/RenderSVGContainer.h:
• rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::addFocusRingRects):
• rendering/RenderSVGImage.h:

5:05 PM Changeset in webkit [25838] by oliver

• 7 edits
  2 adds in branches/rebased-feature-branch/WebCore

2007-06-06 Eric Seidel <​eric@webkit.org>

Reviewed by weinig.

Break out common SVG rendering logic into prepareToRenderSVGContent in SVGRenderSupport

No test cases should be changed by this.

• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderPath.cpp: (WebCore::fillAndStrokePath): (WebCore::RenderPath::paint):
• rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::requiresLayer): (WebCore::RenderSVGContainer::isOutermostSVG): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::applyContentTransforms): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::viewportTransform): (WebCore::RenderSVGContainer::absoluteTransform):
• rendering/RenderSVGContainer.h:
• rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translationForAttributes):
• rendering/SVGRenderSupport.cpp: Added. (WebCore::prepareToRenderSVGContent):
• rendering/SVGRenderSupport.h: Added.
• rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes):

5:03 PM Changeset in webkit [25837] by tristan

• 2 edits in branches/Safari-2.0-dashboard/WebCore

Reviewed by Beth Dakin.

<rdar://problem/4643028> (WebKitForDashboard) JavaScript to cause Safari crash in DOM::NodeImpl::setChanged (Safari 2 fix; already fixed in Safari 3)

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::removedFromDocument): Checked to see if the node being removed is currently set as the Document's cssTarget If it is, I clear the cssTarget to prevent an extra incorrect reference to it.

5:02 PM Changeset in webkit [25836] by oliver

• 6 edits
  4 adds in branches/rebased-feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=13976
getPresentationAttribute not implemented

Implement getPresentationAttribute.

5:01 PM Changeset in webkit [25835] by oliver

• 6 edits in branches/rebased-feature-branch/WebCore

2007-06-06 Rob Buis <​buis@kde.org>

Reviewed by olliej and eric.

​http://bugs.webkit.org/show_bug.cgi?id=12430
SVG has two transform parsers when it should have one.

Refactor SVGTransformable parser so SVGAnimateTransformElement can reuse it better.

• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGTransformable.cpp: (WebCore::): (WebCore::SVGTransformable::parseTransformValue): (WebCore::SVGTransformable::parseTransformAttribute):
• ksvg2/svg/SVGTransformable.h:

4:59 PM Changeset in webkit [25834] by oliver

• 17 edits in branches/rebased-feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Add support for maskUnits and maskContentUnits
​http://bugs.webkit.org/show_bug.cgi?id=12568

This is covered by the W3C tests (including mask-intro01)

• ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): (WebCore::SVGMaskElement::notifyAttributeChange):
• ksvg2/svg/SVGMaskElement.h:
• ksvg2/svg/SVGMaskElement.idl:
• platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
• platform/graphics/svg/SVGResourceMasker.h:
• platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):

2007-06-05 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Commit files missing from previous commit, oops!

• platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
• platform/graphics/svg/SVGResourceMasker.h:
• platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):

4:58 PM Changeset in webkit [25833] by oliver

• 2 edits
  1 add in branches/rebased-feature-branch/WebCore

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by lars.

Cursor does not change to hand over links containing <use>
​http://bugs.webkit.org/show_bug.cgi?id=12630

Test: manual-tests/svg-link-hover-use.svg

• manual-tests/svg-link-hover-use.svg: Added.
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): use eventParentNode instead of parentNode

4:56 PM Changeset in webkit [25832] by oliver

• 5 edits
  4 adds in branches/rebased-feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

SVG is not correctly respecting scroll during hit testing
​http://bugs.webkit.org/show_bug.cgi?id=13083

Test: svg/custom/scroll-hit-test.svg

• rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
• rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint):

4:55 PM Changeset in webkit [25831] by oliver

• 4 edits
  5 adds in branches/rebased-feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

Fix for: ​http://bugs.webkit.org/show_bug.cgi?id=12187

Tests: fast/dom/attribute-case-sensitivity.html, fast/dom/attribute-case-sensitivity2.xhtml

• dom/Element.cpp: (WebCore::shouldIgnoreAttributeCase): check to make sure element is an HTMLElement (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute):
• dom/NamedAttrMap.cpp: (WebCore::shouldIgnoreAttributeCase): (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem):

4:53 PM Changeset in webkit [25830] by oliver

• 3 edits in branches/rebased-feature-branch

2007-05-31 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
​http://bugs.webkit.org/show_bug.cgi?id=12570

Test: svg/custom/prevent-default.svg

• html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
• ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side

4:51 PM Changeset in webkit [25829] by oliver

• 4 edits in branches/rebased-feature-branch/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

Allow zooming and panning, thereby implementing the above methods.

4:50 PM Changeset in webkit [25828] by oliver

• 13 edits in branches/rebased-feature-branch

Reviewed by Oliver.
Fix regression: gradient on fill of text works again!

4:48 PM Changeset in webkit [25827] by oliver

• 3 edits in branches/rebased-feature-branch/WebCore

Reviewed by Oliver.

Fix "jumpy" selection by correcting the way svgCharacterHitsPosition works.
I basically mixed up the "closest character to position" logic.

4:46 PM Changeset in webkit [25826] by oliver

• 630 edits in branches/rebased-feature-branch

Reviewed by Oliver.

Add new code path dumping SVG text engine specific layout test results.
Finally the dumped results are actually accurate and respond to the
rendered glyphs. This has never been correct so far.

4:43 PM Changeset in webkit [25825] by oliver

• 23 edits
  1 copy
  133 adds in branches/rebased-feature-branch

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12698 (SVG text needs a special per-character layout mode.)
Finally land the new SVG text engine.

4:40 PM Changeset in webkit [25824] by oliver

• 4 edits
  4 adds in branches/rebased-feature-branch

2007-05-10 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

​http://bugs.webkit.org/show_bug.cgi?id=11931
PathCG fails to hit on unclosed sub-paths

Test: svg/custom/hit-test-unclosed-subpaths.svg

• platform/graphics/cg/PathCG.cpp: (WebCore::copyClosingSubpathsApplierFunction): (WebCore::copyCGPathClosingSubpaths): (WebCore::Path::contains): use new copy & close function

4:15 PM Changeset in webkit [25823] by oliver

• 4 edits
  4 deletes in trunk

Rollout accidentally committed r25819

4:00 PM Changeset in webkit [25822] by bdakin

• 1 edit in trunk/WebCore/page/FrameView.cpp

Yet another typo. I really like the whimsy in this one, but it's probably best to fix it.

3:45 PM Changeset in webkit [25821] by bdakin

• 1 edit in trunk/WebCore/page/FrameView.cpp

Wrong its/it's!

3:38 PM Changeset in webkit [25820] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5515426> NetNewsWire 3 crashes at launch in
WebCore::FrameView::layout (other repro scenarios too)

The new call to updateWidget() that we added to FrameView::layout()
can destroy the RenderPartObject. And so we were crashing on the
subsequent call to updateWidgetPosition(). This patch fixes that by
checking to make sure the RenderPartObject is still in the HashSet
after updateWidget(). Because m_widgetUpdateSet can be modified
during the call to updateWidget(), we need it to be intact while we
are iterating through the copy, so we cannot use the HashSet::swap
call we were using before. This patch instead uses a Vector to
iterate through the HashSet data and calls clear() on the HashSet
at the end.

• page/FrameView.cpp: (WebCore::FrameView::layout):

3:08 PM Changeset in webkit [25819] by oliver

• 4 edits
  4 adds in trunk

2007-05-10 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

​http://bugs.webkit.org/show_bug.cgi?id=11931
PathCG fails to hit on unclosed sub-paths

Test: svg/custom/hit-test-unclosed-subpaths.svg

• platform/graphics/cg/PathCG.cpp: (WebCore::copyClosingSubpathsApplierFunction): (WebCore::copyCGPathClosingSubpaths): (WebCore::Path::contains): use new copy & close function

2:44 PM Changeset in webkit [25818] by zecke

• 2 edits in trunk/WebKit/gtk

2007-09-29 Lars Lindner <​lars.lindner@gmail.com>

Reviewed by Adam.

ChromeClientGtk.cpp does not implement mouseDidMoveOverElement()
​http://bugs.webkit.org/show_bug.cgi?id=15299

Implementing "hovering_over_link" signal.

• WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):

2:41 PM Changeset in webkit [25817] by oliver

• 1 copy in branches/rebased-feature-branch

Preparing for rebased feature branch

12:33 PM Changeset in webkit [25816] by ddkilzer

• 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Hyatt.

Make svn-apply and svn-unapply work with added files in git-diff formatted patches.

• Scripts/svn-apply: (gitdiff2svndiff): Ignore lines beginning with "new file".
• Scripts/svn-unapply: (gitdiff2svndiff): Ditto.

11:15 AM Changeset in webkit [25815] by staikos

• 2 edits in trunk/WebCore

2007-10-01 Eli Fidler <​eli@staikos.net>

Reviewed by George Staikos.

Switch bogus assert to a conditional and return. This case happens
when a widget is hidden.

• platform/qt/WidgetQt.cpp: (WebCore::Widget::invalidateRect):

6:51 AM Changeset in webkit [25814] by lars

• 147 edits
  2 copies
  59 adds
  1 delete in trunk/LayoutTests

Remove the separate ChangeLog in Layouttests/platform/qt.
Update layout test results. We still have a few failures,
but these ones are real issues.

Sep 30, 2007:

6:54 PM Changeset in webkit [25813] by darin

• 5 edits in trunk/WebCore

Reviewed by Maciej.

• tone down the assertion I asked Harrison to include in his fix for <rdar://problem/5511128>; it's OK to re-ref and deref the document as long as you do so after the children are done being destroyed

No effect on release builds. Assertion change only.

Besides the changes listed below, renamed m_hasDeleted flag to
m_deletionHasBegun.

• dom/ContainerNode.cpp: (WebCore::ContainerNode::removeAllChildren): Added code to set the m_deletionHasBegun flag and some assertions that test its state.

• dom/Document.h: Removed m_hasDeleted -- we now use m_deletionHasBegun in the base class TreeShared.
• dom/Document.cpp: (WebCore::Document::Document): Removed initialization of m_hasDeleted. (WebCore::Document::removedLastRef): Added code to clear m_inRemovedLastRefFunction if we end up deciding not to delete this.

• platform/Shared.h: (WebCore::TreeShared::TreeShared): Added m_deletionHasBegun in addition to m_inRemovedLastRefFunction (formerly named m_hasRemovedLastRef). (WebCore::TreeShared::~TreeShared): Assert that m_deletionHasBegun is true. (WebCore::TreeShared::ref): Assert neither flag is true. (WebCore::TreeShared::deref): Ditto. (WebCore::TreeShared::hasOneRef): Ditto. (WebCore::TreeShared::removedLastRef): Made private. Added code to set m_hasDeleted to true. Also removed cast; since this class template has a virtual destructor, we don't need to cast before calling delete.

2:08 PM Web Inspector edited by pewtermoose@gmail.com

Point them to the right plist on Windows. (diff)

1:13 PM Changeset in webkit [25812] by staikos

• 4 edits in trunk

Qt build fix - Mac OS X specific

9:03 AM Changeset in webkit [25811] by eseidel

• 3 edits
  2 adds in branches/feature-branch

2007-09-30 Julien <​julien.chaffraix@gmail.com>

Reviewed by aroben & eseidel.

fix ​http://bugs.webkit.org/show_bug.cgi?id=14898

getAllResponseHeaders() separates each header with a CR LF according to the specification

Test: http/tests/xmlhttprequest/xmlhttprequest-crlf-getAllResponseHeader.html

• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders):