⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 4, 2007:

9:11 PM Changeset in webkit [26053] by bdash
  • 4 edits in tags/Safari-4523.10.2

Versioning.

9:11 PM Changeset in webkit [26052] by bdash
  • 8 edits in tags/Safari-4523.10.2

Merge r26050.

8:55 PM Changeset in webkit [26051] by bdash
  • 1 copy in tags/Safari-4523.10.2

New tag.

8:52 PM Changeset in webkit [26050] by bdash
  • 8 edits in trunk

2007-10-04 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.
The "full" level appears to offer no observable benefits even though the documentation
suggests it be used for dead code stripping. This should also decrease link times.

  • Configurations/Base.xcconfig:
8:37 PM Changeset in webkit [26049] by weinig
  • 1 edit
    1 delete in trunk/WebKitTools

Rubber stamped by Adam.

Remove empty directories.

  • DumpRenderTree/DumpRenderTree.qtproj: Removed.
  • DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
4:23 PM Changeset in webkit [26048] by adele
  • 2 edits in trunk/WebKit/win
  • Interfaces/IWebViewPrivate.idl: Moving setInitialFocus down to the end to avoid breaking the OpenSource build.
3:21 PM Changeset in webkit [26047] by adele
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • page/FocusController.h: Added FocusDirection argument.
  • page/FocusController.cpp: (WebCore::FocusController::setInitialFocus): Use FocusDirection argument instead of key modifiers to send direction to advanceFocus.
  • WebCore.exp: Updated symbol.

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Pass in the FocusDirection.

win:

Reviewed by Darin.

WebKit/win part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • WebView.cpp: Added setInitialFocus so the application can specify that its handing off focus to WebKit and so that it can specify the focus direction.
  • WebView.h: ditto.
  • Interfaces/IWebViewPrivate.idl: ditto.
1:34 PM Changeset in webkit [26046] by darin
  • 2 edits in trunk/WebKit
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Removed a bogus comment.
11:33 AM Changeset in webkit [26045] by weinig
  • 15 edits
    14 adds
    1 delete in trunk/LayoutTests

Rubber-stamped by Darin.

Make traversal tests dumpAsText.

  • platform/mac/traversal: Removed.
  • platform/mac/traversal/node-iterator-001-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-001-expected.png: Removed.
  • platform/mac/traversal/node-iterator-001-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-002-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-002-expected.png: Removed.
  • platform/mac/traversal/node-iterator-002-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-003-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-003-expected.png: Removed.
  • platform/mac/traversal/node-iterator-003-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-004-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-004-expected.png: Removed.
  • platform/mac/traversal/node-iterator-004-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-005-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-005-expected.png: Removed.
  • platform/mac/traversal/node-iterator-005-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-006-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-006-expected.png: Removed.
  • platform/mac/traversal/node-iterator-006-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-007-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-007-expected.png: Removed.
  • platform/mac/traversal/node-iterator-007-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-008-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-008-expected.png: Removed.
  • platform/mac/traversal/node-iterator-008-expected.txt: Removed.
  • platform/mac/traversal/stay-within-root-expected.checksum: Removed.
  • platform/mac/traversal/stay-within-root-expected.png: Removed.
  • platform/mac/traversal/stay-within-root-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-001-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-001-expected.png: Removed.
  • platform/mac/traversal/tree-walker-001-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-002-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-002-expected.png: Removed.
  • platform/mac/traversal/tree-walker-002-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-003-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-003-expected.png: Removed.
  • platform/mac/traversal/tree-walker-003-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-004-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-004-expected.png: Removed.
  • platform/mac/traversal/tree-walker-004-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-005-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-005-expected.png: Removed.
  • platform/mac/traversal/tree-walker-005-expected.txt: Removed.
  • traversal/node-iterator-001-expected.txt: Added.
  • traversal/node-iterator-001.html:
  • traversal/node-iterator-002-expected.txt: Added.
  • traversal/node-iterator-002.html:
  • traversal/node-iterator-003-expected.txt: Added.
  • traversal/node-iterator-003.html:
  • traversal/node-iterator-004-expected.txt: Added.
  • traversal/node-iterator-004.html:
  • traversal/node-iterator-005-expected.txt: Added.
  • traversal/node-iterator-005.html:
  • traversal/node-iterator-006-expected.txt: Added.
  • traversal/node-iterator-006.html:
  • traversal/node-iterator-007-expected.txt: Added.
  • traversal/node-iterator-007.html:
  • traversal/node-iterator-008-expected.txt: Added.
  • traversal/node-iterator-008.html:
  • traversal/stay-within-root-expected.txt: Added.
  • traversal/stay-within-root.html:
  • traversal/tree-walker-001-expected.txt: Added.
  • traversal/tree-walker-001.html:
  • traversal/tree-walker-002-expected.txt: Added.
  • traversal/tree-walker-002.html:
  • traversal/tree-walker-003-expected.txt: Added.
  • traversal/tree-walker-003.html:
  • traversal/tree-walker-004-expected.txt: Added.
  • traversal/tree-walker-004.html:
  • traversal/tree-walker-005-expected.txt: Added.
  • traversal/tree-walker-005.html:
10:45 AM Changeset in webkit [26044] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by John.


<rdar://problems/5516309>


  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Avoid the expense of updating tints on controls for the empty-window case since this can take a significant amount of time even on windows that have no content at all. Note this fix specifically optimizes the empty window/tab case; for a more broad fix John wrote up rdar://problem/5521050.
10:13 AM Changeset in webkit [26043] by darin
  • 2 edits in trunk/WebCore
  • page/Frame.h: Put functions into categories to indicate other classes we'd like to move them into in the future. Just organizational -- no code change.
8:19 AM Changeset in webkit [26042] by eseidel
  • 6 edits
    12 adds
    6 deletes in branches/feature-branch

2007-10-03 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


​http://bugs.webkit.org/show_bug.cgi?id=12310
Remove static variables from removeAllChildren causing crash.
removeAllChildren now iterates over the entire tree instead of recursing.
Also (according to Maciej) a possible 1-2% speedboost on HTML iBench.

Test: fast/images/svg-background-crash-on-refresh.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::addChildNodesToDeletionQueue): (WebCore::ContainerNode::removeAllChildren): use new addChildNodesToDeletionQueue
1:45 AM Changeset in webkit [26041] by lars
  • 3 edits
    2 adds in trunk

fix a crash in the FrameLoader that can happen under certain
conditions in the Qt port.

1:09 AM Changeset in webkit [26040] by hyatt
  • 1 edit in branches/feature-branch/WebCore/WebCore.vcproj/WebCore.vcproj

Fix Windows build bustage once and for all. Feature branch builds on Windows now.

12:36 AM Changeset in webkit [26039] by lars
  • 1 edit
    1 move in trunk/LayoutTests

forgot to move one file in the last commit.

12:32 AM Changeset in webkit [26038] by lars
  • 1 edit
    317 moves in trunk/LayoutTests

Move png files that are not test results and where mistakenly moved in r26026
back to where they belong.

12:29 AM Changeset in webkit [26037] by hyatt
  • 1 edit in branches/feature-branch/WebCore/WebCore.vcproj/WebCore.vcproj

Fix Windows build bustage once and for all. Feature branch builds on Windows now.

Oct 3, 2007:

6:44 PM Changeset in webkit [26036] by andrew
  • 2 edits in branches/feature-branch/WebKit

Reviewed by Mark Rowe.


Mac build fix for issue introduced in r26027

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
5:43 PM Changeset in webkit [26035] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

  • Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if we find the internal libraries in the libraries directory. This is helpful for Safari team engineers at Apple.
5:20 PM Changeset in webkit [26034] by hyatt
  • 2 edits in branches/feature-branch/WebKit/win

Fix Windows build bustage. Make sure the font update method is called with the correct # of arguments when used in Windows WebKit.

5:19 PM Changeset in webkit [26033] by hyatt
  • 2 edits in branches/feature-branch/WebKit/win

Fix Windows build bustage. Make sure the font update method is called with the correct # of arguments when used in Windows WebKit.

5:15 PM Changeset in webkit [26032] by hyatt
  • 4 edits in branches/feature-branch/WebCore

Fix more SVG build bustage on Windows. Remove a deleted file from the project. Remove a const from an unimplemented mask method.

5:06 PM Changeset in webkit [26031] by hyatt
  • 1 edit in branches/feature-branch/WebCore/bindings/js/JSSVGPODTypeWrapper.h

Fix UChar ambiguity in SVG code that keeps Windows from compiling the feature branch.

4:38 PM Changeset in webkit [26030] by hyatt
  • 1 edit in branches/feature-branch/WebCore/WebCore.vcproj/WebCore.vcproj

Fix windows build bustage on feature branch.

3:48 PM Changeset in webkit [26029] by adachan
  • 4 edits in trunk/WebKit/win

<rdar://problem/5521230> Implement IWebIconDatabase::iconURLForURL in WebKit for windows

Reviewed by Steve and Brady.

  • Interfaces/IWebIconDatabase.idl:
  • WebIconDatabase.cpp: (WebIconDatabase::iconURLForURL):
  • WebIconDatabase.h:
3:20 PM Changeset in webkit [26028] by hyatt
  • 1 edit in branches/feature-branch/WebCore/WebCore.vcproj/WebCore.vcproj

Fix windows build bustage on feature branch.

2:57 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
2:04 PM Changeset in webkit [26027] by hyatt
  • 48 edits
    16 adds in branches/feature-branch/WebCore

Land support for the CSS @font-face rule. This patch allows custom fonts
to be downloaded from the Web and rendered in Web pages. Right now only
TrueType fonts are supported. Proprietary formats like .eot are not
supported.

Reviewed by Eric Seidel

Many tests will be coming in a future landing.

  • WebCore.base.exp: Expose some more stuff for WebKit, caused by font restructuring.
  • WebCore.xcodeproj/project.pbxproj: Add all the new font face files.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Make sure to ignore the 'src' property of @font-face rules.
  • css/CSSFontFace.cpp: Added. (WebCore::CSSFontFace::CSSFontFace): (WebCore::CSSFontFace::~CSSFontFace): (WebCore::CSSFontFace::isLoaded): (WebCore::CSSFontFace::isValid): (WebCore::CSSFontFace::addSource): (WebCore::CSSFontFace::fontLoaded): (WebCore::CSSFontFace::getFontData):
  • css/CSSFontFace.h: Added. A CSSFontFace is a composite object. It consists of multiple font-face sources, where each source represents either a remote or local file in a @font-face rule's src list.
  • css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::setDeclaration): (WebCore::CSSFontFaceRule::cssText):
  • css/CSSFontFaceRule.h: The implementation of the @font-face rule itself in the CSS sheet back end.


  • css/CSSFontFaceSource.cpp: Added. (WebCore::CSSFontFaceSource::CSSFontFaceSource): (WebCore::CSSFontFaceSource::~CSSFontFaceSource): (WebCore::CSSFontFaceSource::pruneTable): (WebCore::CSSFontFaceSource::isLoaded): (WebCore::CSSFontFaceSource::isValid): (WebCore::CSSFontFaceSource::fontLoaded): (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontFaceSource.h: Added. (WebCore::CSSFontFaceSource::string): (WebCore::CSSFontFaceSource::setFontFace): A font face source represents a single remote or local font. If it represents a remote font than it wraps a CachedFont.


  • css/CSSFontFaceSrcValue.cpp: Added. (WebCore::CSSFontFaceSrcValue::isSupportedFormat): (WebCore::CSSFontFaceSrcValue::cssText):
  • css/CSSFontFaceSrcValue.h: Added. (WebCore::CSSFontFaceSrcValue::m_isLocal): (WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue): (WebCore::CSSFontFaceSrcValue::resource): (WebCore::CSSFontFaceSrcValue::format): (WebCore::CSSFontFaceSrcValue::isLocal): (WebCore::CSSFontFaceSrcValue::setFormat): Used in parsing. Represents the parsed form of the src value that can then be used to build up a CSSFontFace.
  • css/CSSFontSelector.cpp: Added. (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::~CSSFontSelector): (WebCore::CSSFontSelector::isEmpty): (WebCore::CSSFontSelector::docLoader): (WebCore::hashForFont): (WebCore::CSSFontSelector::addFontFaceRule): (WebCore::CSSFontSelector::fontLoaded): (WebCore::CSSFontSelector::getFontData):
  • css/CSSFontSelector.h: Added. The CSS font selector is the object that selects the correct font given a specified font family. It builds up a database of CSSFontFaces that can then be handed back.
  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::createFontFaceRule):
  • css/CSSParser.h: Modify the CSS grammar to now understand @font-face rules.
  • css/CSSPropertyNames.in: Add the src property.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::ensureFontSelector):
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector): The style selector now creates a font selector object and feeds it the appropriate information when @font-face rules are encountered.


  • dom/Document.cpp: (WebCore::Document::recalcStyle): Patch the update method now that it takes a font selector argument.


  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
  • loader/Cache.h: Teach the Cache about CachedFonts.
  • loader/CachedFont.cpp: Added. (WebCore::CachedFont::CachedFont): (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ref): (WebCore::CachedFont::data): (WebCore::CachedFont::beginLoadIfNeeded): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allReferencesRemoved): (WebCore::CachedFont::checkNotify): (WebCore::CachedFont::error):
  • loader/CachedFont.h: Added. (WebCore::CachedFont::schedule): The implementation of CachedFont. This represents the downloaded resource and has all the raw font data.
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h: (WebCore::CachedResourceClient::fontLoaded): Add a new fontLoaded method for clients of cached resources to track when fonts finish downloading.


  • loader/DocLoader.cpp: (WebCore::DocLoader::requestFont):
  • loader/DocLoader.h: Add the ability to request a font.
  • platform/Font.cpp: (WebCore::Font::operator==): (WebCore::Font::update): (WebCore::Font::drawText):
  • platform/Font.h:
  • platform/FontCache.cpp: (WebCore::FontCache::getFontData):
  • platform/FontCache.h:
  • platform/FontData.cpp: (WebCore::FontData::FontData):
  • platform/FontData.h: (WebCore::FontData::isCustomFont): (WebCore::FontData::isLoading):
  • platform/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::fontDataAt):
  • platform/FontFallbackList.h: (WebCore::FontFallbackList::loadingCustomFonts): (WebCore::FontFallbackList::fontSelector):
  • platform/FontSelector.h: Added. (WebCore::FontSelector::~FontSelector):
  • platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::getRoot): (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): (WebCore::GlyphPageTreeNode::~GlyphPageTreeNode): (WebCore::GlyphPageTreeNode::initializePage): (WebCore::GlyphPageTreeNode::getChild): (WebCore::GlyphPageTreeNode::pruneCustomFontData):
  • platform/GlyphPageTreeNode.h: (WebCore::GlyphPageTreeNode::GlyphPageTreeNode): (WebCore::GlyphPageTreeNode::page):
  • platform/PopupMenuClient.h:
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::fontExists): (WebCore::FontCache::createFontPlatformData):
  • platform/mac/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/mac/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  • platform/mac/FontDataMac.mm: (WebCore::initFontData): (WebCore::FontData::platformInit): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::platformWidthForGlyph): (WebCore::FontData::checkShapesArabic):
  • platform/mac/FontMac.mm: (WebCore::initializeATSUStyle): (WebCore::Font::drawGlyphs):
  • platform/mac/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/mac/FontPlatformDataMac.mm: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::~FontPlatformData): (WebCore::FontPlatformData::setFont):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::fontExists):
  • platform/win/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::getData): (WebCore::releaseData): (WebCore::getBytesWithOffset): (WebCore::createFontCustomPlatformData):
  • platform/win/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  • platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch):
  • platform/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Changes to platform to support rendering of custom fonts. Too large to go into, but for ports, the relevant object to implement is FontCustomPlatformData (to get the data loaded into your native font format), and then you have to patch your other font objects to know how to use the font.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::fontSelector):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::fontSelector):
  • rendering/RenderTextControl.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::setFontFromControlSize): Patches for update now taking a font selector argument.
2:00 PM Changeset in webkit [26026] by aroben
  • 1 edit
    8924 moves in trunk/LayoutTests

Move pixel test results that were mistakenly left in place after r25970

Rubberstamped by Sam.

11:29 AM Changeset in webkit [26025] by rwlbuis
  • 3 edits in branches/feature-branch/WebCore

Reviewed by Eric.

Remove unneeded code and other cleanups.

10:40 AM Changeset in webkit [26024] by aroben
  • 2 edits in trunk/LayoutTests

Add some sometimes-timing-out tests to the Skipped file

Rubberstamped by Sam.

  • platform/win/Skipped:
10:33 AM Changeset in webkit [26023] by aroben
  • 2 edits in trunk/WebKitTools

Update the location of AHEM_.TTF after r25968

Reviewed by Sam.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
10:25 AM Changeset in webkit [26022] by alp
  • 23 edits in trunk

2007-10-03 Alp Toker <​alp@atoker.com>

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=14726
[gtk] API design. Mapping the WebView delegates to signals.

Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.

10:16 AM Changeset in webkit [26021] by alp
  • 7 edits in trunk/WebCore

2007-10-03 Alp Toker <​alp@atoker.com>

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=14129
[CAIRO] Support the canvas element

Add a new canvas implementation using Cairo for rendering.

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::platformShading):
  • html/CanvasGradient.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::applyStrokePattern):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement): (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext): (WebCore::HTMLCanvasElement::createPlatformImage):
  • html/HTMLCanvasElement.h:
9:31 AM Changeset in webkit [26020] by zecke
  • 3 edits in trunk/WebKit/gtk

2007-10-02 Cosimo Cecchi <​cosimoc@svn.gnome.org>

Reviewed by Mark.

​http://bugs.webkit.org/show_bug.cgi?id=15299
Fix "hovering_over_link" signal being fired every time mouse moves.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/ChromeClientGtk.h:
9:30 AM Changeset in webkit [26019] by zecke
  • 3 edits in trunk/WebKit/gtk

2007-09-21 Sean Egan <​seanegan@gmail.com>

Reviewed by Alp.

Add an "execute_script" method to programmatically call Javascript
​http://bugs.webkit.org/show_bug.cgi?id=15255

  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
7:20 AM Changeset in webkit [26018] by lars
  • 2 edits in trunk/WebKitTools

This fixes --strict mode in run-webkit-tests again after
the platform dependent test results have been moved.

7:14 AM Changeset in webkit [26017] by lars
  • 2 edits in trunk/JavaScriptCore

Fix a stupid bug in Unicode::toUpper/toLower.
Fixes all three test failures in the JavaScriptCore test
suite.

6:28 AM Changeset in webkit [26016] by lars
  • 2 edits
    25 adds in trunk/LayoutTests/platform/qt

add some more passing tests, and update one result.

5:35 AM Changeset in webkit [26015] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15260
Any styles defined after <element> {<property>:%} style are ignored by Safari

Add dummy rule to skip constructions like width: %.

5:17 AM Changeset in webkit [26014] by rwlbuis
  • 2 edits in branches/feature-branch/WebKitTools

Reviewed by Olliej.

Adapt to changed location of Ahem font.

4:54 AM Changeset in webkit [26013] by bdash
  • 10 edits in branches/feature-branch/WebCore

2007-10-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Lars.

Get Gtk+ port building on the feature branch.

  • WebCore.pro:
  • ksvg2/svg/SVGSVGElement.cpp:
  • platform/graphics/svg/cairo/RenderPathCairo.cpp: (WebCore::RenderPath::strokeContains):
  • platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::renderPath):
  • platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: (WebCore::SVGPaintServerSolid::setup):
  • platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: (WebCore::SVGResourceMasker::applyMask):
  • rendering/SVGCharacterLayoutInfo.cpp:
  • rendering/SVGInlineTextBox.cpp:
  • rendering/SVGRootInlineBox.cpp:
4:52 AM Changeset in webkit [26012] by lars
  • 4 edits
    1 add
    4 deletes in trunk

remove the hack in run-webkit-tests that forced text only test
to be taken from the platform independent dir. It was only left
there from early days.

Remove platform dependent results for tests that are text only nowadays,
and add one platform dependent result for a text only test that requires it.

4:36 AM Changeset in webkit [26011] by oliver
  • 8 edits in branches/feature-branch

Adding merge markers to the appropriate changelogs

4:33 AM Changeset in webkit [26010] by lars
  • 7 adds in trunk/LayoutTests/platform/qt

add some more results.

4:21 AM Changeset in webkit [26009] by oliver
  • 5 edits
    60 moves
    6 adds in branches/feature-branch

move WebKitQt to WebKit/qt for consistency with the other ports.

4:20 AM Changeset in webkit [26008] by oliver
  • 4 edits
    8 moves
    2 adds in branches/feature-branch

Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.

4:20 AM Changeset in webkit [26007] by oliver
  • 2 edits in branches/feature-branch/WebKitTools

2007-10-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Fix build-webkit when both QTDIR and --gtk are set. The presence of --gtk
should take precedence over QTDIR when determining which port we are working with.

  • Scripts/webkitdirs.pm:
4:20 AM Changeset in webkit [26006] by oliver
  • 1 edit
    10 deletes in branches/feature-branch/LayoutTests

Remove pixel test results for text only tests

4:20 AM Changeset in webkit [26005] by oliver
  • 1 edit in branches/feature-branch/WebKit/win/WebKit.vcproj/VERSION

Bump to correct version

4:19 AM Changeset in webkit [26004] by oliver
  • 2 edits in branches/feature-branch/WebKit/win

Bump versions for submit

4:19 AM Changeset in webkit [26003] by oliver
  • 2 edits in branches/feature-branch/WebKit/win

Rubber-stamped by Adam Roben.

  • Interfaces/IWebPreferences.idl: Remove unnecessary comments.
4:18 AM Changeset in webkit [26002] by oliver
  • 3 edits in branches/feature-branch/WebKitTools

Add keychain to the list of default packages to install

Rubberstamped by Sam.

  • CygwinDownloader/cygwin-downloader.py:
  • CygwinDownloader/cygwin-downloader.zip: Regenerated.
4:18 AM Changeset in webkit [26001] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Oliver and Adam.

Patch for <rdar://problem/5506968> Fail to DnD local file with non-ascii character in path from desktop to Safari (can open it with file menu)

Use CoreFoundation to do the conversion from path to URL, as the Windows API was not
correctly converting to UTF-8 and we know CFURL will.

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): (WebCore::getURL):
4:18 AM Changeset in webkit [26000] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Darin Adler.

<rdar://problem/5511842> REGRESSION: Webkit stops responding while loading Apple Store Canada page (15304)

Included the NSSynchronousURLConnection_PrivateMode mode, in addition to the default run loop modes
as an acceptable mode when using performSelectorOnMainThread with our syncronous url callbacks.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Added NSSynchronousURLConnection_PrivateMode to the list of accepted modes.
4:17 AM Changeset in webkit [25999] by oliver
  • 2 edits
    1 move
    2 adds
    2 deletes in branches/feature-branch/LayoutTests

Added a mention of a bug that this test demonstrates:

  • editing/execCommand/5144139-1-expected.checksum: Removed.
  • editing/execCommand/5144139-1-expected.png: Removed.
  • editing/execCommand/5144139-1-expected.txt: Removed.
  • editing/execCommand/5144139-1.html:
  • platform/mac/editing/execCommand/5144139-1-expected.checksum: Added.
  • platform/mac/editing/execCommand/5144139-1-expected.png: Added.
  • platform/mac/editing/execCommand/5144139-1-expected.txt: Added.
4:16 AM Changeset in webkit [25998] by oliver
  • 4 edits in branches/feature-branch/WebKit

Reviewed by Mark Rowe.

Re-added _minimumRequiredSafariBuildNumber. It turns out older version of Safari still rely
on this method, so we need to keep it around at least until the next major Safari release.

  • StringsNotToBeLocalized.txt:
  • WebView/WebView.mm: (+[WebView _minimumRequiredSafariBuildNumber]):
  • WebView/WebViewPrivate.h:
4:16 AM Changeset in webkit [25997] by oliver
  • 6 edits in branches/feature-branch

Set svn:eol-style for all .sln files to CRLF.

4:16 AM Changeset in webkit [25996] by oliver
  • 26 edits
    1 add in branches/feature-branch

JavaScriptCore:

Reviewed by Adam.

  • add support for GDI objects to OwnPtr; I plan to use this to fix some GDI handle leaks
  • kjs/grammar.y: Change parser to avoid macros that conflict with macros defined in Windows system headers: THIS, DELETE, VOID, IN, and CONST. This is needed because OwnPtr.h will now include <windows.h>.
  • kjs/keywords.table: Ditto.
  • wtf/OwnPtr.h: For PLATFORM(WIN), add support so that OwnPtr can be a GDI handle, and it will call DeleteObject. Also change to use the RemovePointer technique used by RetainPtr, so you can say OwnPtr<HBITMAP> rather than having to pass in the type pointed to by HBITMAP.
  • wtf/OwnPtrWin.cpp: Added. (WebCore::deleteOwnedPtr): Put this in a separate file so that we don't have to include <windows.h> in OwnPtr.h.

WebCore:

Reviewed by Adam.

  • add support for GDI objects to OwnPtr; I plan to use this to fix some GDI handle leaks
  • css/CSSGrammar.y: Change parser to avoid macro that conflicts with macro defined in Windows system headers: FLOAT. This is needed because OwnPtr.h will now include <windows.h>.
  • css/CSSParser.cpp: (WebCore::CSSParser::lex): Ditto.
  • css/tokenizer.flex: Ditto.
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): Use OwnPtr for a few HBITMAP objects as a test case.
  • platform/win/COMPtr.h: (COMPtr::COMPtr): Fix so that we can use Query with other COMPtr. Before this would not compile if it was ever instantiated.

win:

Reviewed by Adam.

  • started using the new OwnPtr everywhere we do DeleteObject
  • WebNodeHighlight.cpp: (WebNodeHighlight::updateWindow):
  • WebView.cpp: (WebView::WebView): (WebView::deleteBackingStore): (WebView::ensureBackingStore): (WebView::addToDirtyRegion): (WebView::scrollBackingStore): (WebView::updateBackingStore): (WebView::paint): (WebView::paintIntoBackingStore): (WebView::paintIntoWindow):
  • WebView.h:

Also set svn:eol-style on all .vcproj to CRLF.

Also added svn:ignore of *.user for WebKitInitializer.

4:15 AM Changeset in webkit [25995] by oliver
  • 2 edits in branches/feature-branch/WebKitTools

WebKitTools:

Reviewed by Adam.

Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
Also makes WebCore regression test case logic work when using git.

  • Scripts/prepare-ChangeLog: (reviewerAndDescriptionForGitCommit): Added.
4:15 AM Changeset in webkit [25994] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Adam, Ada.

Fix leak of GDI handle when we call MLANG.

4:14 AM Changeset in webkit [25993] by oliver
  • 3 edits in branches/feature-branch/WebKit/win

Fix <rdar://5505062> WebKit's version-independent ProgIDs contain version numbers

I also added a few registry keys for our version-independent ProgIDs
that we were missing.

Reviewed by Steve.

  • ProgIDMacros.h: Added new macros to get version-independent ProgIDs.
  • WebKitDLL.cpp: Use the version-independent ProgIDs in the right places, and added some new keys for version-independent ProgIDs.
4:14 AM Changeset in webkit [25992] by oliver
  • 4 edits in branches/feature-branch/WebKit

Reviewed by John Sullivan.

<rdar://problem/5517710>

  • WebView/WebView.mm: Removed -[WebView _minimumRequiredSafariBuildNumber] because newer versions of Safari no longer use this method. This won't break existing Safaris because they always use a respondsToSelector check before calling this.
4:14 AM Changeset in webkit [25991] by oliver
  • 3 edits in branches/feature-branch/WebKit/win

Reviewed by Adam.

Fix a bug discovered by app verifier where we would treat an LPCTSTR as a BSTR causing a crash.

Also rename some protection space constants and change their values to match the mac version.

  • Interfaces/IWebURLAuthenticationChallenge.idl:
  • WebURLProtectionSpace.cpp: (WebURLProtectionSpace::initWithHost): (WebURLProtectionSpace::initWithProxyHost): (WebURLProtectionSpace::protocol): (WebURLProtectionSpace::proxyType):
4:13 AM Changeset in webkit [25990] by oliver
  • 4 edits in branches/feature-branch/WebKitQt

Reviewed by Eric Seidel.

Open the requested url on the newly created window.
Implement createModalDialog and provide new API for this.
Patch by M. Mehdi Salem Naraghi (momesana) with additions by me.

4:13 AM Changeset in webkit [25989] by oliver
  • 1 edit in branches/feature-branch/LayoutTests/platform/qt/Skipped

dirty way of getting the Qt port to 0 test failures.
It's still a good thing to do, as we now have a complete
list of all tests that are currently failing in the Skipped
file.

4:12 AM Changeset in webkit [25988] by oliver
  • 3 edits in branches/feature-branch/LayoutTests/platform/qt

update two more test results and skip two crashing test cases for now.

4:12 AM Changeset in webkit [25987] by oliver
  • 8 edits in branches/feature-branch

Add API to retrieve the frame name from QWebFrame.
Implement support for DRT::dumpChildrenAsText.

4:12 AM Changeset in webkit [25986] by oliver
  • 2 edits in branches/feature-branch/LayoutTests/platform/qt/fast

update two more test results.

4:11 AM Changeset in webkit [25985] by oliver
  • 2 edits in branches/feature-branch/LayoutTests/platform/qt

Skip some tests that fail due to a bug in Qt 4.3, and update one more result.

4:11 AM Changeset in webkit [25984] by oliver
  • 5 edits in branches/feature-branch

Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.

4:10 AM Changeset in webkit [25983] by oliver
  • 1 edit in branches/feature-branch/WebKitTools/ChangeLog

2007-10-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.

  • BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
  • WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
4:10 AM Changeset in webkit [25982] by oliver
  • 9 edits in branches/feature-branch/WebKitTools

2007-10-02 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Maciej.

Configuration changes from build.webkit.org. The major change is refactoring to work
with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
last few weeks.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
4:09 AM Changeset in webkit [25981] by oliver
  • 2 edits in branches/feature-branch/WebKitTools

Add support for eventSender.mouseMove to DRT.
Fixes fast/css/hover-affects-child.html

4:09 AM Changeset in webkit [25980] by oliver
  • 2 edits in branches/feature-branch/WebCore

The cookies() method should only return the value of the
cookie, not additional info such as the expiration date.
Fixes LayoutTests/fast/cookies/local-file-can-set-cookies.html

4:09 AM Changeset in webkit [25979] by oliver
  • 1 edit
    4 adds in branches/feature-branch/LayoutTests

Added some more test results.

4:08 AM Changeset in webkit [25978] by oliver
  • 2 edits in branches/feature-branch/LayoutTests

Update test result.

4:08 AM Changeset in webkit [25977] by oliver
  • 4 edits in branches/feature-branch

Fix a wrong extension mapping in the MIMETypeRegistry and identify about: url's as frames in the FrameLoaderClient.

4:07 AM Changeset in webkit [25976] by oliver
  • 1 edit in branches/feature-branch/WebKitTools/ChangeLog

2007-10-01 Mark Rowe <​mrowe@apple.com>

  • BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
4:06 AM Changeset in webkit [25975] by oliver
  • 7 edits
    1 move in branches/feature-branch

WebCore:

Reviewed by Harrison.

<rdar://problem/5516183> REGRESSION: Creating a ToDo on an incoming message fails

Rolling out r25721.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h:

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5516183> REGRESSION: Creating a ToDo on an incoming message fails

  • editing/pasteboard/5483567.html: Removed.
  • editing/pasteboard/5483567.html-disabled: Added.
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/pasteboard/paste-RTFD-expected.txt:
4:06 AM Changeset in webkit [25974] by oliver
  • 1 edit in branches/feature-branch/WebCore/page/FrameView.cpp

Yet another typo. I really like the whimsy in this one, but it's probably best to fix it.

4:05 AM Changeset in webkit [25973] by oliver
  • 1 edit in branches/feature-branch/WebCore/page/FrameView.cpp

Wrong its/it's!

4:05 AM Changeset in webkit [25972] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5515426> NetNewsWire 3 crashes at launch in
WebCore::FrameView::layout (other repro scenarios too)

The new call to updateWidget() that we added to FrameView::layout()
can destroy the RenderPartObject. And so we were crashing on the
subsequent call to updateWidgetPosition(). This patch fixes that by
checking to make sure the RenderPartObject is still in the HashSet
after updateWidget(). Because m_widgetUpdateSet can be modified
during the call to updateWidget(), we need it to be intact while we
are iterating through the copy, so we cannot use the HashSet::swap
call we were using before. This patch instead uses a Vector to
iterate through the HashSet data and calls clear() on the HashSet
at the end.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
4:04 AM Changeset in webkit [25971] by oliver
  • 2 edits in branches/feature-branch/WebKit/gtk

2007-09-29 Lars Lindner <​lars.lindner@gmail.com>

Reviewed by Adam.

ChromeClientGtk.cpp does not implement mouseDidMoveOverElement()
​http://bugs.webkit.org/show_bug.cgi?id=15299

Implementing "hovering_over_link" signal.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
3:53 AM Changeset in webkit [25970] by lars
  • 1 edit
    4294 moves
    137 adds in trunk/LayoutTests

Move all test results that are platform dependent but
stored in the platform independent part to their
correct locations (inside platform/mac).

This will make it a lot easier to maintain test
results for other platforms than mac.

Signed off by aroben.

3:29 AM Changeset in webkit [25969] by lars
  • 5 edits
    60 moves
    6 adds in trunk

move WebKitQt to WebKit/qt for consistency with the other ports.

3:29 AM Changeset in webkit [25968] by lars
  • 4 edits
    8 moves
    2 adds in trunk

Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.

2:25 AM Changeset in webkit [25967] by bdash
  • 2 edits in trunk/WebKitTools

2007-10-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Fix build-webkit when both QTDIR and --gtk are set. The presence of --gtk
should take precedence over QTDIR when determining which port we are working with.

  • Scripts/webkitdirs.pm:
2:03 AM Changeset in webkit [25966] by lars
  • 1 edit
    10 deletes in trunk/LayoutTests

Remove pixel test results for text only tests

Note: See TracTimeline for information about the timeline view.