Timeline

Oct 5, 2007:

5:56 PM Changeset in webkit [26075] by eseidel

• 6 edits in branches/feature-branch/WebCore

2007-10-05 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver Hunt.

SVG invalidates way too much during layout()
​http://bugs.webkit.org/show_bug.cgi?id=14003

• ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): simplify if (WebCore::SVGElement::viewportElement): simplify if
• rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): only layout children if parent changed
• rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): only layout children when size changes
• rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): hack to avoid bad RenderBlock::layout code
• rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): don't use RenderSVGContainer::layout()

5:54 PM Changeset in webkit [26074] by ggaren

• 8 edits in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

Added JSObject::removeDirect, to support the fix for
<rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
page load causes a crash in PropertyMap::put

• kjs/object.cpp: (KJS::JSObject::removeDirect):
• kjs/object.h:

WebCore:

Reviewed by Sam Weinig.

New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
disabled, any page load causes a crash in PropertyMap::put

Explicitly remove the "document" property from the window. The old
solution would leave a stale "document" property around after JavaScript
was re-enabled.

The architecture for disabling JavaScript could use some consolidation.
It seems wrong that a script proxy even exists when JavaScript is
disabled. It also seems wrong that so many individual call sites are
responsible for checking whether JavaScript is enabled. I've filed a
bug about this: ​http://bugs.webkit.org/show_bug.cgi?id=15385.

• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clearDocumentWrapper):
• bindings/js/kjs_proxy.h:
• page/Frame.cpp: (WebCore::Frame::setDocument):

5:22 PM Changeset in webkit [26073] by oliver

• 2 edits in branches/feature-branch/WebCore

30%+ performance improvement for svg embedded in xhtml

Reviewed by Eric.

Relayout internal to SVG was incorrectly being propagated to
the containing xhtml element, which subsequently resulted in
a full paint of the SVG, rather than just the dirty regions.

• rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary):
(WebCore::RenderObject::markContainingBlocksForLayout):

2:38 PM Changeset in webkit [26072] by honeycutt

• 2 edits in trunk/WebCore

2007-10-05 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5520913> Ticketmaster.com doesn't display correctly (Flash
related?)

The plugin is requesting files that don't exist on the server, and
we are passing the 404 error page to the plugin. This change cancels the
stream if the response code indicates a failure.

This is a port of the safari / mac code.

• loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): If the response code indicates a failure, cancel the stream

1:12 PM Changeset in webkit [26071] by ggaren

• 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled,
any page load causes a crash in PropertyMap::put

The problem was that we were using JavaScript when JavaScript was
disabled. The architecture for disabling JavaScript could use some
consolidation, but this is the simplest, safest change for now.

Currently passing layout tests still pass.

• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper):

1:04 PM Changeset in webkit [26070] by bdakin

• 4 edits in trunk

WebCore:

Reviewed by John Sullivan.

Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
Vertical scroll bar not redrawn properly when going back in history
(15033)

This fix if-defs r25142 to be Leopard-only since it causes
correctness issues on Tiger and does not seem to have any
performance impact on Tiger either.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):

WebKit:

Reviewed by John Sullivan.

Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
Vertical scroll bar not redrawn properly when going back in history
(15033)

This fix if-defs r25142 to be Leopard-only since it causes
correctness issues on Tiger and does not seem to have any
performance impact on Tiger either.

• WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

9:57 AM Changeset in webkit [26069] by adachan

• 2 edits in trunk/WebKit/win

<rdar://problem/5436617>
Implement WebIconDatabase::delayDatabaseCleanup() and WebIconDatabase::allowDatabaseCleanup().

Reviewed by Brady.

• WebIconDatabase.cpp: (WebIconDatabase::delayDatabaseCleanup): (WebIconDatabase::allowDatabaseCleanup):

9:52 AM Changeset in webkit [26068] by adachan

• 2 edits in trunk/WebCore

<rdar://problem/5436617> Favicons sometimes don't show up even when they are
in the database

• A client can try to retain an icon for a page before the database is actually opened. Since isOpened() is not a requirement to retain an icon, remove the check for that. Instead, we'll check to make sure whether this database is enabled before proceeding.

Reviewed by Brady.

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::retainIconForPageURL): (WebCore::IconDatabase::releaseIconForPageURL): only check isOpen() before we schedule for a sync.

3:56 AM Changeset in webkit [26067] by lars

• 5 edits in trunk/LayoutTests/platform/qt

these tests deliver the same results as on the Mac, which
makes them pass :)

3:25 AM Changeset in webkit [26066] by lars

• 4 edits in trunk

fix a hang in editing/selection/extend-by-word-002.html

2:10 AM Changeset in webkit [26065] by lars

• 1 edit
  2 adds in trunk/WebKitTools

forgot to add these files in r26061.

2:06 AM Changeset in webkit [26064] by lars

• 14 deletes in trunk/LayoutTests/platform/qt/traversal

remove platform specific results, after r26045 turned
these tests into being text only.

2:04 AM Changeset in webkit [26063] by lars

• 1 edit in trunk/LayoutTests/platform/qt/Skipped

remove four more passing tests from the skipped list.

1:57 AM Changeset in webkit [26062] by lars

• 10 edits in trunk

add proper error messages to the FrameLoaderClient.
Implement ChromeClientQt::closeWindowSoon and
FrameLoaderClientQt::dispatchCreatePage (which should go
away IMO).
Some fixes in DRT to make it work correctly with multiple
windows.

1:57 AM Changeset in webkit [26061] by lars

• 9 edits in trunk

Add a dummy plugin to DRT to fix fast/dom/Window/Plug-Ins.html.
Add support for layoutTextController.setCanOpenWindows() to DRT
fixing another 2 test cases in fast/dom/Window.

12:45 AM Changeset in webkit [26060] by bdash

• 1 copy in tags/WebKit-419.2.1-dashboard/WebKit

New tag (part 2).

12:45 AM Changeset in webkit [26059] by bdash

• 1 copy in tags/WebCore-419.2.1-dashboard/WebCore

New tag (part 2).

12:45 AM Changeset in webkit [26058] by bdash

• 1 copy in tags/JavaScriptCore-419.2.2-dashboard/JavaScriptCore

New tag (part 2).

12:44 AM Changeset in webkit [26057] by bdash

• 1 add in tags/WebKit-419.2.1-dashboard

New tag (part 1).

12:44 AM Changeset in webkit [26056] by bdash

• 1 add in tags/WebCore-419.2.1-dashboard

New tag (part 1).

12:44 AM Changeset in webkit [26055] by bdash

• 1 add in tags/JavaScriptCore-419.2.2-dashboard

New tag (part 1).

12:41 AM Changeset in webkit [26054] by bdash

• 6 edits in branches/Safari-2.0-dashboard

Versioning.

Oct 4, 2007:

9:11 PM Changeset in webkit [26053] by bdash

• 4 edits in tags/Safari-4523.10.2

Versioning.

9:11 PM Changeset in webkit [26052] by bdash

• 8 edits in tags/Safari-4523.10.2

Merge r26050.

8:55 PM Changeset in webkit [26051] by bdash

• 1 copy in tags/Safari-4523.10.2

New tag.

8:52 PM Changeset in webkit [26050] by bdash

• 8 edits in trunk

2007-10-04 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.
The "full" level appears to offer no observable benefits even though the documentation
suggests it be used for dead code stripping. This should also decrease link times.

• Configurations/Base.xcconfig:

8:37 PM Changeset in webkit [26049] by weinig

• 1 edit
  1 delete in trunk/WebKitTools

Rubber stamped by Adam.

Remove empty directories.

• DumpRenderTree/DumpRenderTree.qtproj: Removed.
• DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.

4:23 PM Changeset in webkit [26048] by adele

• 2 edits in trunk/WebKit/win

• Interfaces/IWebViewPrivate.idl: Moving setInitialFocus down to the end to avoid breaking the OpenSource build.

3:21 PM Changeset in webkit [26047] by adele

• 10 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

• page/FocusController.h: Added FocusDirection argument.
• page/FocusController.cpp: (WebCore::FocusController::setInitialFocus): Use FocusDirection argument instead of key modifiers to send direction to advanceFocus.
• WebCore.exp: Updated symbol.

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

• WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Pass in the FocusDirection.

win:

Reviewed by Darin.

WebKit/win part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

• WebView.cpp: Added setInitialFocus so the application can specify that its handing off focus to WebKit and so that it can specify the focus direction.
• WebView.h: ditto.
• Interfaces/IWebViewPrivate.idl: ditto.

1:34 PM Changeset in webkit [26046] by darin

• 2 edits in trunk/WebKit

• WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Removed a bogus comment.

11:33 AM Changeset in webkit [26045] by weinig

• 15 edits
  14 adds
  1 delete in trunk/LayoutTests

Rubber-stamped by Darin.

Make traversal tests dumpAsText.

• platform/mac/traversal: Removed.
• platform/mac/traversal/node-iterator-001-expected.checksum: Removed.
• platform/mac/traversal/node-iterator-001-expected.png: Removed.
• platform/mac/traversal/node-iterator-001-expected.txt: Removed.
• platform/mac/traversal/node-iterator-002-expected.checksum: Removed.
• platform/mac/traversal/node-iterator-002-expected.png: Removed.
• platform/mac/traversal/node-iterator-002-expected.txt: Removed.
• platform/mac/traversal/node-iterator-003-expected.checksum: Removed.
• platform/mac/traversal/node-iterator-003-expected.png: Removed.
• platform/mac/traversal/node-iterator-003-expected.txt: Removed.
• platform/mac/traversal/node-iterator-004-expected.checksum: Removed.
• platform/mac/traversal/node-iterator-004-expected.png: Removed.
• platform/mac/traversal/node-iterator-004-expected.txt: Removed.
• platform/mac/traversal/node-iterator-005-expected.checksum: Removed.
• platform/mac/traversal/node-iterator-005-expected.png: Removed.
• platform/mac/traversal/node-iterator-005-expected.txt: Removed.
• platform/mac/traversal/node-iterator-006-expected.checksum: Removed.
• platform/mac/traversal/node-iterator-006-expected.png: Removed.
• platform/mac/traversal/node-iterator-006-expected.txt: Removed.
• platform/mac/traversal/node-iterator-007-expected.checksum: Removed.
• platform/mac/traversal/node-iterator-007-expected.png: Removed.
• platform/mac/traversal/node-iterator-007-expected.txt: Removed.
• platform/mac/traversal/node-iterator-008-expected.checksum: Removed.
• platform/mac/traversal/node-iterator-008-expected.png: Removed.
• platform/mac/traversal/node-iterator-008-expected.txt: Removed.
• platform/mac/traversal/stay-within-root-expected.checksum: Removed.
• platform/mac/traversal/stay-within-root-expected.png: Removed.
• platform/mac/traversal/stay-within-root-expected.txt: Removed.
• platform/mac/traversal/tree-walker-001-expected.checksum: Removed.
• platform/mac/traversal/tree-walker-001-expected.png: Removed.
• platform/mac/traversal/tree-walker-001-expected.txt: Removed.
• platform/mac/traversal/tree-walker-002-expected.checksum: Removed.
• platform/mac/traversal/tree-walker-002-expected.png: Removed.
• platform/mac/traversal/tree-walker-002-expected.txt: Removed.
• platform/mac/traversal/tree-walker-003-expected.checksum: Removed.
• platform/mac/traversal/tree-walker-003-expected.png: Removed.
• platform/mac/traversal/tree-walker-003-expected.txt: Removed.
• platform/mac/traversal/tree-walker-004-expected.checksum: Removed.
• platform/mac/traversal/tree-walker-004-expected.png: Removed.
• platform/mac/traversal/tree-walker-004-expected.txt: Removed.
• platform/mac/traversal/tree-walker-005-expected.checksum: Removed.
• platform/mac/traversal/tree-walker-005-expected.png: Removed.
• platform/mac/traversal/tree-walker-005-expected.txt: Removed.
• traversal/node-iterator-001-expected.txt: Added.
• traversal/node-iterator-001.html:
• traversal/node-iterator-002-expected.txt: Added.
• traversal/node-iterator-002.html:
• traversal/node-iterator-003-expected.txt: Added.
• traversal/node-iterator-003.html:
• traversal/node-iterator-004-expected.txt: Added.
• traversal/node-iterator-004.html:
• traversal/node-iterator-005-expected.txt: Added.
• traversal/node-iterator-005.html:
• traversal/node-iterator-006-expected.txt: Added.
• traversal/node-iterator-006.html:
• traversal/node-iterator-007-expected.txt: Added.
• traversal/node-iterator-007.html:
• traversal/node-iterator-008-expected.txt: Added.
• traversal/node-iterator-008.html:
• traversal/stay-within-root-expected.txt: Added.
• traversal/stay-within-root.html:
• traversal/tree-walker-001-expected.txt: Added.
• traversal/tree-walker-001.html:
• traversal/tree-walker-002-expected.txt: Added.
• traversal/tree-walker-002.html:
• traversal/tree-walker-003-expected.txt: Added.
• traversal/tree-walker-003.html:
• traversal/tree-walker-004-expected.txt: Added.
• traversal/tree-walker-004.html:
• traversal/tree-walker-005-expected.txt: Added.
• traversal/tree-walker-005.html:

10:45 AM Changeset in webkit [26044] by kdecker

• 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problems/5516309>

• page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Avoid the expense of updating tints on controls for the empty-window case since this can take a significant amount of time even on windows that have no content at all. Note this fix specifically optimizes the empty window/tab case; for a more broad fix John wrote up rdar://problem/5521050.

10:13 AM Changeset in webkit [26043] by darin

• 2 edits in trunk/WebCore

• page/Frame.h: Put functions into categories to indicate other classes we'd like to move them into in the future. Just organizational -- no code change.

8:19 AM Changeset in webkit [26042] by eseidel

• 6 edits
  12 adds
  6 deletes in branches/feature-branch

2007-10-03 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12310
Remove static variables from removeAllChildren causing crash.
removeAllChildren now iterates over the entire tree instead of recursing.
Also (according to Maciej) a possible 1-2% speedboost on HTML iBench.

Test: fast/images/svg-background-crash-on-refresh.html

• WebCore.xcodeproj/project.pbxproj:
• dom/ContainerNode.cpp: (WebCore::addChildNodesToDeletionQueue): (WebCore::ContainerNode::removeAllChildren): use new addChildNodesToDeletionQueue

1:45 AM Changeset in webkit [26041] by lars

• 3 edits
  2 adds in trunk

fix a crash in the FrameLoader that can happen under certain
conditions in the Qt port.

1:09 AM Changeset in webkit [26040] by hyatt

• 1 edit in branches/feature-branch/WebCore/WebCore.vcproj/WebCore.vcproj

Fix Windows build bustage once and for all. Feature branch builds on Windows now.

12:36 AM Changeset in webkit [26039] by lars

• 1 edit
  1 move in trunk/LayoutTests

forgot to move one file in the last commit.

12:32 AM Changeset in webkit [26038] by lars

• 1 edit
  317 moves in trunk/LayoutTests

Move png files that are not test results and where mistakenly moved in r26026
back to where they belong.

12:29 AM Changeset in webkit [26037] by hyatt

• 1 edit in branches/feature-branch/WebCore/WebCore.vcproj/WebCore.vcproj

Fix Windows build bustage once and for all. Feature branch builds on Windows now.