⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 10, 2007:

11:49 PM Changeset in webkit [26355] by oliver
  • 2 edits in branches/feature-branch/LayoutTests

Correcting expected output of svg/batik/text/textOnPathSpaces

RS = Eric.

  • svg/batik/text/textOnPathSpaces-expected.txt
11:01 PM Changeset in webkit [26354] by oliver
  • 3 edits in branches/feature-branch/WebCore

Leopard build fix -- SVGDocument should not trty to make read/write properties read-only

Reviewed by Maciej.

Remove those API definitions SVGDocument now inherits from Document

  • ksvg2/svg/SVGDocument.idl:
10:30 PM Changeset in webkit [26353] by mjs
  • 3 edits in branches/feature-branch/JavaScriptCore

Reviewed by Eric.


  • fix assertion failures on quit.
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Dynamically alocate function-scope static UStrings to avoid the static destructor getting called later.
  • kjs/lookup.h: Dynamically alocate function-scope static Identifiers to avoid the static destructor getting called later.
8:10 PM Changeset in webkit [26352] by eseidel
  • 48 edits
    5 adds in branches/feature-branch

2007-10-10 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.

Make renderers pull localTransform instead of depending on DOM elements to push
This allows for cleaner invalidation code, and makes writing animation easier.
Also fixed a tiny bug in SVGRenderImage focus ring calculations while there


Updated test results for svg/custom/focus-ring.svg

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::createRenderer):
  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyAnimatedValueToElement):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyAnimatedValueToElement):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGGElement.cpp: (WebCore::SVGGElement::createRenderer):
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM):
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource): (WebCore::SVGMarkerElement::notifyAttributeChange):
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::rendererIsNeeded): (WebCore::SVGStyledElement::notifyResourceParentIfExistant):
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::style):
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::parseMappedAttribute): (WebCore::SVGStyledTransformableElement::notifyAttributeChange): (WebCore::SVGStyledTransformableElement::createRenderer):
  • ksvg2/svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::toPathData):
  • ksvg2/svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::createRenderer):
  • ksvg2/svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText):
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::animatedLocalTransform):
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPathElement.cpp:
  • ksvg2/svg/SVGTextPathElement.h:
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::getCTM): (WebCore::SVGTransformable::getScreenCTM):
  • ksvg2/svg/SVGTransformable.h:
  • ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::createRenderer): (WebCore::SVGUseElement::attachShadowTree):
  • platform/graphics/AffineTransform.h: (WebCore::AffineTransform::operator!=):
  • platform/graphics/svg/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::setMarker):
  • platform/graphics/svg/SVGResourceMarker.h:
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::calculateLocalTransform): (WebCore::RenderForeignObject::layout):
  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::localTransform):
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): (WebCore::RenderPath::localTransform): (WebCore::RenderPath::calculateLocalTransform): (WebCore::RenderPath::layout):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::localTransform): (WebCore::RenderSVGContainer::calculateLocalTransform): (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localTransform):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::calculateLocalTransform): (WebCore::RenderSVGText::layout):
  • rendering/RenderSVGText.h: (WebCore::RenderSVGText::isSVGText): (WebCore::RenderSVGText::localTransform):
  • rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath): (WebCore::RenderSVGTextPath::startOffset): (WebCore::RenderSVGTextPath::exactAlignment): (WebCore::RenderSVGTextPath::stretchMethod):
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderSVGTransformableContainer.cpp: Added. (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/RenderSVGTransformableContainer.h: Added.
  • rendering/RenderSVGViewportContainer.h:
8:00 PM Changeset in webkit [26351] by oliver
  • 10 edits in branches/feature-branch/WebCore

Bug 15451: SVGStyledElement must unregister itself from Resources on detach

Reviewed by Eric.

Use a global hashtable to maintain the relationship between the
various SVG resources and their clients, across dom updates, etc.

  • ChangeLog:
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::detach):
  • ksvg2/svg/SVGStyledElement.h:
  • platform/graphics/svg/SVGPaintServer.h:
  • platform/graphics/svg/SVGResource.cpp: (WebCore::ResourceSet::ResourceSet): (WebCore::clientMap): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::removeClient): (WebCore::SVGResource::addClient):
  • platform/graphics/svg/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker):
  • platform/graphics/svg/SVGResourceClipper.h: (WebCore::SVGResourceClipper::resourceType):
  • platform/graphics/svg/SVGResourceFilter.h:
  • platform/graphics/svg/SVGResourceMarker.h:
  • platform/graphics/svg/SVGResourceMasker.h:
5:25 PM Changeset in webkit [26350] by darin
  • 1 edit in trunk/LayoutTests/fast/js/resources/js-test-pre.js

Oops, forgot to save this file.

5:24 PM Changeset in webkit [26349] by darin
  • 5 edits in trunk/LayoutTests

Reviewed by Kevin McCullough and Sam Weinig.

  • fix mistake in test function that treated all non-prototype objects as equal

That means that all numbers are treated as equal!
And all boolean values!

Kevin noticed that his new test was succeeding even though the bug was still
there. Turns out the code to compare arrays that I added with my fix for
bug 14931 was misfiring all the time.

  • fast/js/resources/js-test-pre.js: Use Object.prototype.toString.call to test if something is an array. Thanks, Sam.
  • fast/dom/Window/new-window-opener-expected.txt: Update this to reflect the fact that the test is actually failing!
  • fast/forms/focus-selection-textarea-expected.txt: Ditto.
  • fast/js/kde/encode_decode_uri-expected.txt: Ditto.
4:30 PM Changeset in webkit [26348] by thatcher
  • 1 move in branches/old/su-jag-pink-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26347] by thatcher
  • 1 move in branches/old/pcre-6-1-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26346] by thatcher
  • 1 move in branches/old/kdom-dom-merger

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26345] by thatcher
  • 1 move in branches/old/kde_3_0_rc_3_merge

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26344] by thatcher
  • 1 move in branches/old/kde_3_0_merge

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26343] by thatcher
  • 1 move in branches/old/kde

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26342] by thatcher
  • 1 move in branches/old/js-collector-tweaks

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26341] by thatcher
  • 1 move in branches/old/jaguar-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26340] by thatcher
  • 1 move in branches/old/gcc-4-0-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26339] by thatcher
  • 1 move in branches/old/feature-branch-2007-10-01

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26338] by thatcher
  • 1 move in branches/old/experimental-ui-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26337] by thatcher
  • 1 move in branches/old/experimental-db

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26336] by thatcher
  • 1 move in branches/old/expat

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26335] by thatcher
  • 1 move in branches/old/WebKit-85~7-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26334] by thatcher
  • 1 move in branches/old/WebKit-125~4-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26333] by thatcher
  • 1 move in branches/old/WebFoundation-SDK-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26332] by thatcher
  • 1 move in branches/old/WebCore-85-tarball-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26331] by thatcher
  • 1 move in branches/old/WebCore-73-tarball-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26330] by thatcher
  • 1 move in branches/old/WebCore-68-tarball-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26329] by thatcher
  • 1 move in branches/old/WebCore-60-tarball-branch

Moving old branch to branches/old.

4:30 PM Changeset in webkit [26328] by thatcher
  • 1 move in branches/old/WebCore-53-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26327] by thatcher
  • 1 move in branches/old/WebCore-48-tarball-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26326] by thatcher
  • 1 move in branches/old/WebCore-106-tarball-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26325] by thatcher
  • 1 move in branches/old/WebCore-105-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26324] by thatcher
  • 1 move in branches/old/WWDC-demo-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26323] by thatcher
  • 1 move in branches/old/WWDC-2004-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26322] by thatcher
  • 1 move in branches/old/Ti-2005-009-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26321] by thatcher
  • 1 move in branches/old/Ti-2005-007-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26320] by thatcher
  • 1 move in branches/old/SecurityUpdate-10~3~4-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26319] by thatcher
  • 1 move in branches/old/Safari-OC-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26318] by thatcher
  • 1 move in branches/old/Safari-Leo-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26317] by thatcher
  • 1 move in branches/old/Safari-Den-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26316] by thatcher
  • 1 move in branches/old/Safari-Cam-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26315] by thatcher
  • 1 move in branches/old/Safari-89-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26314] by thatcher
  • 1 move in branches/old/Safari-80~1-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26313] by thatcher
  • 1 move in branches/old/Safari-78~1-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26312] by thatcher
  • 1 move in branches/old/Safari-77~1-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26311] by thatcher
  • 1 move in branches/old/Safari-74-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26310] by thatcher
  • 1 move in branches/old/Safari-73~1-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26309] by thatcher
  • 1 move in branches/old/Safari-70-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26308] by thatcher
  • 1 move in branches/old/Safari-69~1-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26307] by thatcher
  • 1 move in branches/old/Safari-68~1-branch

Moving old branch to branches/old.

4:29 PM Changeset in webkit [26306] by thatcher
  • 1 move in branches/old/Safari-67~1-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26305] by thatcher
  • 1 move in branches/old/Safari-66~1-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26304] by thatcher
  • 1 move in branches/old/Safari-58-1-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26303] by thatcher
  • 1 move in branches/old/Safari-175-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26302] by thatcher
  • 1 move in branches/old/Safari-1-2-tarballs-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26301] by thatcher
  • 1 move in branches/old/Safari-1-1-Merlot-BuildFixes-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26300] by thatcher
  • 1 move in branches/old/SUPanFeldspar-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26299] by thatcher
  • 1 move in branches/old/SUPanBisque-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26298] by thatcher
  • 1 move in branches/old/ParisExpo-2004-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26297] by thatcher
  • 1 move in branches/old/Pan-2005-007-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26296] by thatcher
  • 1 move in branches/old/PCRE-6-1-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26295] by thatcher
  • 1 move in branches/old/LABYRINTH_KDE_3_MERGE

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26294] by thatcher
  • 1 move in branches/old/JavaScriptCore-85-tarball-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26293] by thatcher
  • 1 move in branches/old/JavaScriptCore-73-tarball-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26292] by thatcher
  • 1 move in branches/old/JavaScriptCore-68-tarball-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26291] by thatcher
  • 1 move in branches/old/JavaScriptCore-60-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26290] by thatcher
  • 1 move in branches/old/JavaScriptCore-53-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26289] by thatcher
  • 1 move in branches/old/JavaScriptCore-48-tarball-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26288] by thatcher
  • 1 move in branches/old/JavaScriptCore-100-tarball-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26287] by thatcher
  • 1 move in branches/old/HTML-editing-hacks-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26286] by thatcher
  • 1 move in branches/old/AutoZoneGC_Branch_20040430

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26285] by thatcher
  • 1 move in branches/old/Alexander-48-branch

Moving old branch to branches/old.

4:26 PM Changeset in webkit [26284] by thatcher
  • 1 add in branches/old

Make a branches/old directory to hold any old branches.

4:15 PM Changeset in webkit [26283] by thatcher
  • 1 delete in branches/unlabeled-1.97.4

Removing old branch.

4:15 PM Changeset in webkit [26282] by thatcher
  • 1 delete in branches/unlabeled-1.96.4

Removing old branch.

4:15 PM Changeset in webkit [26281] by thatcher
  • 1 delete in branches/unlabeled-1.95.4

Removing old branch.

4:15 PM Changeset in webkit [26280] by thatcher
  • 1 delete in branches/unlabeled-1.93.4

Removing old branch.

4:15 PM Changeset in webkit [26279] by thatcher
  • 1 delete in branches/unlabeled-1.9.4

Removing old branch.

4:15 PM Changeset in webkit [26278] by thatcher
  • 1 delete in branches/unlabeled-1.9.14

Removing old branch.

4:15 PM Changeset in webkit [26277] by thatcher
  • 1 delete in branches/unlabeled-1.86.4

Removing old branch.

4:15 PM Changeset in webkit [26276] by thatcher
  • 1 delete in branches/unlabeled-1.83.4

Removing old branch.

4:15 PM Changeset in webkit [26275] by thatcher
  • 1 delete in branches/unlabeled-1.80.4

Removing old branch.

4:15 PM Changeset in webkit [26274] by thatcher
  • 1 delete in branches/unlabeled-1.8.4

Removing old branch.

4:15 PM Changeset in webkit [26273] by thatcher
  • 1 delete in branches/unlabeled-1.79.4

Removing old branch.

4:15 PM Changeset in webkit [26272] by thatcher
  • 1 delete in branches/unlabeled-1.73.4

Removing old branch.

4:15 PM Changeset in webkit [26271] by thatcher
  • 1 delete in branches/unlabeled-1.70.4

Removing old branch.

4:15 PM Changeset in webkit [26270] by thatcher
  • 1 delete in branches/unlabeled-1.7.4

Removing old branch.

4:15 PM Changeset in webkit [26269] by thatcher
  • 1 delete in branches/unlabeled-1.62.4

Removing old branch.

4:15 PM Changeset in webkit [26268] by thatcher
  • 1 delete in branches/unlabeled-1.61.4

Removing old branch.

4:15 PM Changeset in webkit [26267] by thatcher
  • 1 delete in branches/unlabeled-1.6.56

Removing old branch.

4:15 PM Changeset in webkit [26266] by thatcher
  • 1 delete in branches/unlabeled-1.6.4

Removing old branch.

4:15 PM Changeset in webkit [26265] by thatcher
  • 1 delete in branches/unlabeled-1.6.20

Removing old branch.

4:15 PM Changeset in webkit [26264] by thatcher
  • 1 delete in branches/unlabeled-1.58.4

Removing old branch.

4:15 PM Changeset in webkit [26263] by thatcher
  • 1 delete in branches/unlabeled-1.56.4

Removing old branch.

4:15 PM Changeset in webkit [26262] by thatcher
  • 1 delete in branches/unlabeled-1.55.4

Removing old branch.

4:15 PM Changeset in webkit [26261] by thatcher
  • 1 delete in branches/unlabeled-1.54.4

Removing old branch.

4:15 PM Changeset in webkit [26260] by thatcher
  • 1 delete in branches/unlabeled-1.50.4

Removing old branch.

4:15 PM Changeset in webkit [26259] by thatcher
  • 1 delete in branches/unlabeled-1.5.56

Removing old branch.

4:15 PM Changeset in webkit [26258] by thatcher
  • 1 delete in branches/unlabeled-1.5.4

Removing old branch.

4:15 PM Changeset in webkit [26257] by thatcher
  • 1 delete in branches/unlabeled-1.49.4

Removing old branch.

4:15 PM Changeset in webkit [26256] by thatcher
  • 1 delete in branches/unlabeled-1.48.4

Removing old branch.

4:15 PM Changeset in webkit [26255] by thatcher
  • 1 delete in branches/unlabeled-1.47.4

Removing old branch.

4:15 PM Changeset in webkit [26254] by thatcher
  • 1 delete in branches/unlabeled-1.46.4

Removing old branch.

4:15 PM Changeset in webkit [26253] by thatcher
  • 1 delete in branches/unlabeled-1.45.4

Removing old branch.

4:15 PM Changeset in webkit [26252] by thatcher
  • 1 delete in branches/unlabeled-1.440.4

Removing old branch.

4:15 PM Changeset in webkit [26251] by thatcher
  • 1 delete in branches/unlabeled-1.44.4

Removing old branch.

4:15 PM Changeset in webkit [26250] by thatcher
  • 1 delete in branches/unlabeled-1.41.4

Removing old branch.

4:15 PM Changeset in webkit [26249] by thatcher
  • 1 delete in branches/unlabeled-1.40.4

Removing old branch.

4:15 PM Changeset in webkit [26248] by thatcher
  • 1 delete in branches/unlabeled-1.4.56

Removing old branch.

4:15 PM Changeset in webkit [26247] by thatcher
  • 1 delete in branches/unlabeled-1.4.4

Removing old branch.

4:15 PM Changeset in webkit [26246] by thatcher
  • 1 delete in branches/unlabeled-1.4.14

Removing old branch.

4:15 PM Changeset in webkit [26245] by thatcher
  • 1 delete in branches/unlabeled-1.39.4

Removing old branch.

4:15 PM Changeset in webkit [26244] by thatcher
  • 1 delete in branches/unlabeled-1.384.2.1.2

Removing old branch.

4:15 PM Changeset in webkit [26243] by thatcher
  • 1 delete in branches/unlabeled-1.37.4

Removing old branch.

4:15 PM Changeset in webkit [26242] by thatcher
  • 1 delete in branches/unlabeled-1.36.4

Removing old branch.

4:15 PM Changeset in webkit [26241] by thatcher
  • 1 delete in branches/unlabeled-1.35.4

Removing old branch.

4:15 PM Changeset in webkit [26240] by thatcher
  • 1 delete in branches/unlabeled-1.35.18

Removing old branch.

4:15 PM Changeset in webkit [26239] by thatcher
  • 1 delete in branches/unlabeled-1.35.14

Removing old branch.

4:14 PM Changeset in webkit [26238] by thatcher
  • 1 delete in branches/unlabeled-1.34.4

Removing old branch.

4:14 PM Changeset in webkit [26237] by thatcher
  • 1 delete in branches/unlabeled-1.32.4

Removing old branch.

4:14 PM Changeset in webkit [26236] by thatcher
  • 1 delete in branches/unlabeled-1.32.14

Removing old branch.

4:14 PM Changeset in webkit [26235] by thatcher
  • 1 delete in branches/unlabeled-1.31.4

Removing old branch.

4:14 PM Changeset in webkit [26234] by thatcher
  • 1 delete in branches/unlabeled-1.30.4

Removing old branch.

4:14 PM Changeset in webkit [26233] by thatcher
  • 1 delete in branches/unlabeled-1.3.56

Removing old branch.

4:14 PM Changeset in webkit [26232] by thatcher
  • 1 delete in branches/unlabeled-1.3.50

Removing old branch.

4:14 PM Changeset in webkit [26231] by thatcher
  • 1 delete in branches/unlabeled-1.3.4

Removing old branch.

4:14 PM Changeset in webkit [26230] by thatcher
  • 1 delete in branches/unlabeled-1.2930.2.4.2

Removing old branch.

4:14 PM Changeset in webkit [26229] by thatcher
  • 1 delete in branches/unlabeled-1.28.4

Removing old branch.

4:14 PM Changeset in webkit [26228] by thatcher
  • 1 delete in branches/unlabeled-1.275.2

Removing old branch.

4:14 PM Changeset in webkit [26227] by thatcher
  • 1 delete in branches/unlabeled-1.27.4

Removing old branch.

4:14 PM Changeset in webkit [26226] by thatcher
  • 1 delete in branches/unlabeled-1.269.4

Removing old branch.

4:14 PM Changeset in webkit [26225] by thatcher
  • 1 delete in branches/unlabeled-1.26.4

Removing old branch.

4:14 PM Changeset in webkit [26224] by thatcher
  • 1 delete in branches/unlabeled-1.25.4

Removing old branch.

4:14 PM Changeset in webkit [26223] by thatcher
  • 1 delete in branches/unlabeled-1.24.4

Removing old branch.

4:14 PM Changeset in webkit [26222] by thatcher
  • 1 delete in branches/unlabeled-1.2336.4

Removing old branch.

4:14 PM Changeset in webkit [26221] by thatcher
  • 1 delete in branches/unlabeled-1.23.4

Removing old branch.

4:14 PM Changeset in webkit [26220] by thatcher
  • 1 delete in branches/unlabeled-1.22.4

Removing old branch.

4:14 PM Changeset in webkit [26219] by thatcher
  • 1 delete in branches/unlabeled-1.21.4

Removing old branch.

4:14 PM Changeset in webkit [26218] by thatcher
  • 1 delete in branches/unlabeled-1.20.4

Removing old branch.

4:14 PM Changeset in webkit [26217] by thatcher
  • 1 delete in branches/unlabeled-1.2.50

Removing old branch.

4:14 PM Changeset in webkit [26216] by thatcher
  • 1 delete in branches/unlabeled-1.2.4

Removing old branch.

4:14 PM Changeset in webkit [26215] by thatcher
  • 1 delete in branches/unlabeled-1.197.4

Removing old branch.

4:14 PM Changeset in webkit [26214] by thatcher
  • 1 delete in branches/unlabeled-1.19.4

Removing old branch.

4:14 PM Changeset in webkit [26213] by thatcher
  • 1 delete in branches/unlabeled-1.183.4

Removing old branch.

4:14 PM Changeset in webkit [26212] by thatcher
  • 1 delete in branches/unlabeled-1.18.4

Removing old branch.

4:14 PM Changeset in webkit [26211] by thatcher
  • 1 delete in branches/unlabeled-1.17.4

Removing old branch.

4:14 PM Changeset in webkit [26210] by thatcher
  • 1 delete in branches/unlabeled-1.168.4

Removing old branch.

4:14 PM Changeset in webkit [26209] by thatcher
  • 1 delete in branches/unlabeled-1.16.50

Removing old branch.

4:14 PM Changeset in webkit [26208] by thatcher
  • 1 delete in branches/unlabeled-1.16.4

Removing old branch.

4:14 PM Changeset in webkit [26207] by thatcher
  • 1 delete in branches/unlabeled-1.15.4

Removing old branch.

4:14 PM Changeset in webkit [26206] by thatcher
  • 1 delete in branches/unlabeled-1.15.14

Removing old branch.

4:14 PM Changeset in webkit [26205] by thatcher
  • 1 delete in branches/unlabeled-1.14.4

Removing old branch.

4:14 PM Changeset in webkit [26204] by thatcher
  • 1 delete in branches/unlabeled-1.137.4

Removing old branch.

4:14 PM Changeset in webkit [26203] by thatcher
  • 1 delete in branches/unlabeled-1.13.4

Removing old branch.

4:14 PM Changeset in webkit [26202] by thatcher
  • 1 delete in branches/unlabeled-1.12.4

Removing old branch.

4:14 PM Changeset in webkit [26201] by thatcher
  • 1 delete in branches/unlabeled-1.118.4

Removing old branch.

4:14 PM Changeset in webkit [26200] by thatcher
  • 1 delete in branches/unlabeled-1.116.4

Removing old branch.

4:14 PM Changeset in webkit [26199] by thatcher
  • 1 delete in branches/unlabeled-1.11.4

Removing old branch.

4:14 PM Changeset in webkit [26198] by thatcher
  • 1 delete in branches/unlabeled-1.11.14

Removing old branch.

4:14 PM Changeset in webkit [26197] by thatcher
  • 1 delete in branches/unlabeled-1.107.4

Removing old branch.

4:14 PM Changeset in webkit [26196] by thatcher
  • 1 delete in branches/unlabeled-1.102.4

Removing old branch.

4:14 PM Changeset in webkit [26195] by thatcher
  • 1 delete in branches/unlabeled-1.101.4

Removing old branch.

4:14 PM Changeset in webkit [26194] by thatcher
  • 1 delete in branches/unlabeled-1.10.4

Removing old branch.

4:14 PM Changeset in webkit [26193] by thatcher
  • 1 delete in branches/unlabeled-1.10.38

Removing old branch.

4:14 PM Changeset in webkit [26192] by thatcher
  • 1 delete in branches/unlabeled-1.1.4

Removing old branch.

4:14 PM Changeset in webkit [26191] by thatcher
  • 1 delete in branches/unlabeled-1.1.2

Removing old branch.

4:14 PM Changeset in webkit [26190] by thatcher
  • 1 delete in branches/unlabeled-1.1.14

Removing old branch.

4:14 PM Changeset in webkit [26189] by thatcher
  • 1 delete in branches/init

Removing old branch.

4:14 PM Changeset in webkit [26188] by thatcher
  • 1 delete in branches/WindowsMerge

Removing old branch.

4:13 PM Changeset in webkit [26187] by thatcher
  • 1 delete in branches/ALEXANDER_48_BRANCH_ANCHOR

Removing old branch.

1:48 PM Changeset in webkit [26186] by aroben
  • 2 edits in trunk/LayoutTests

Remove now-passing tests

Rubberstamped by Sam.

  • platform/win/Skipped:
11:54 AM Changeset in webkit [26185] by staikos
  • 5 edits in trunk

Fix the build on Win32 for VS2005. A solution for mingw and others may be
needed for FTPDirectory*.cpp still

11:31 AM Changeset in webkit [26184] by aliceli1
  • 16 edits in trunk

gtk:

Reviewed by Geoff Garen.

changes to keep the build from breaking

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
  • WebCoreSupport/FrameLoaderClientGtk.h:

qt:

Reviewed by Geoff Garen.

changes to keep the build from breaking

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebCore:

Reviewed by Geoff Garen.

Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT
createFrame() now returns a RefPtr instead of a raw Frame pointer.
Making this change improves the way we handle frames on Windows webkit.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe):
  • loader/FrameLoaderClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::createFrame):

WebKit:

Reviewed by Geoff Garen.

Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT
createFrame() now returns a RefPtr instead of a raw Frame pointer.
Making this change improves the way we handle frames on Windows WebKit.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):

win:

Reviewed by Geoff Garen.

Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT

  • WebFrame.cpp: (WebFrame::createFrame): The crash was caused by the early destruction of the subframe. To resolve this issue, the manual deref of the child frame that occurs in between being appended to the frametree and being used in loadURLIntoChild wasn't exactly incorrect, but just needed to be moved until after loadURLIntoChild. This hasn't been a problem for other uses of child frames because this test case involves removing a child frame immediately after loading it, all in an onload handler. Even better than just moving the deref would be to change the signature of createFrame to use a RefPtr<Frame> so that a manual deref isn't necessary. This is what was done in this patch.
  • WebFrame.h: createFrame() now returns a RefPtr instead of a raw Frame pointer. Making this change improves the way we handle frames on Windows WebKit.
5:01 AM Changeset in webkit [26183] by bdash
  • 2 edits in branches/feature-branch/WebCore

2007-10-10 Mark Rowe <​mrowe@apple.com>

Windows build fix after r26109.

  • WebCore.vcproj/WebCore.vcproj:
4:12 AM Changeset in webkit [26182] by hausmann
  • 15 edits in trunk

Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
includes are needed for INT_MAX, std::auto_ptr and the like.

2:09 AM Changeset in webkit [26181] by oliver
  • 4 edits in branches/feature-branch/WebCore

Fix Bug 15433: Filters do not repaint when base resources change/update

Reviewed by Eric.

SVGFEImage now actually responds to image updates, and triggers a repaint.

  • platform/graphics/svg/SVGResource.h:
  • platform/graphics/svg/filters/SVGFEImage.cpp: (WebCore::SVGFEImage::setCachedImage): Don't re-set the image lest we want to trigger infinite recursion. (WebCore::SVGFEImage::imageChanged): Image change means we need to tell our clients to repaint
  • platform/graphics/svg/filters/SVGFEImage.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent): make sure that users of filters are registered.

Oct 9, 2007:

11:15 PM Changeset in webkit [26180] by alp
  • 2 edits in branches/feature-branch/WebCore

2007-10-09 Eric Seidel <​eric@webkit.org>

Reviewed by Alp.

Track changes in r26109 to fix the Gtk+ build.

  • WebCore.pro:
10:09 PM Changeset in webkit [26179] by sfalken
  • 1 copy in tags/Safari-523.11.1b

New tag.

10:09 PM Changeset in webkit [26178] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

4:50 PM Changeset in webkit [26177] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/ScrollViewWx.cpp

Typo fix (y passed into wrong arg).

4:45 PM Changeset in webkit [26176] by tristan
  • 4 edits in branches/Safari-2.0-dashboard/WebCore

Reviewed by Sam Weinig.

Merge r25249 and r25284 from ToT to Safari-2.0-dashboard.
This time with a fix for <rdar://problem/5531129>.


2007-08-24 Sam Weinig <​sam@webkit.org>

Reviewed by Adele.

Fix for <rdar://problem/5426142>

Use the EventTarget's frame when creating the EventListener.

Tests: http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html

http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html
http/tests/security/listener/xss-window-onclick-addEventListener.html
http/tests/security/listener/xss-window-onclick-shortcut.html

  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):


2007-08-28 Sam Weinig <​sam@webkit.org>

Reviewed by Darin.

Update fix landed in r25249 to account for XMLHttpRequest, which can also be EventTargets.

Tests: http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html

http/tests/security/listener/xss-XMLHttpRequest-shortcut.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::putValueProperty): Use the Window object associated with document's frame, not the active Window. (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): ditto
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::document): Expose Document member so bindings can access the correct frame.
2:26 PM Changeset in webkit [26175] by tristan
  • 4 edits in branches/Safari-2.0-dashboard/WebCore

Reverted r25767 due to numerous regressions as detailed in <rdar://problem/5531129>

  • khtml/ecma/kjs_dom.cpp: (DOMNode::setListener): (DOMNodeProtoFunc::tryCall):
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::putValue): Reverted all code in these files to r25740.
12:13 PM Changeset in webkit [26174] by ap
  • 3 edits
    2 adds in branches/feature-branch

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=15436
Wrong node order for XPath reverse axes

Test: fast/xpath/reverse-axes.html

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Do not prematurely sort reverse axes. Generate preceding axis nodes in reversed document order.
11:58 AM Changeset in webkit [26173] by ap
  • 5 edits
    2 adds in branches/feature-branch

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=15437
XPath substring-after function is broken

Test: fast/xpath/substring-after.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstringAfter::evaluate): Fix it for real this time, hopefully.
11:01 AM Changeset in webkit [26172] by zimmermann
  • 533 edits in branches/feature-branch/LayoutTests

Not reviewed.

Regenerated the SVG test baseline, they have been generated with _trunk_ instead of feature-branch.
Not sure who committed it, but it's wrong - so I'm fixing.

10:32 AM Changeset in webkit [26171] by rwlbuis
  • 4 edits
    4 adds in branches/feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=15080
<use> element not refresh after adding objects by script in referrer

Update shadow tree when elements are added/removed from a tree
that is referenced by a <use>.

6:58 AM Changeset in webkit [26170] by lars
  • 5 edits in trunk/LayoutTests

remove some passing tests from teh Skipped list, and adapt some results.

6:58 AM Changeset in webkit [26169] by lars
  • 3 edits in trunk/WebKitTools

implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.

6:58 AM Changeset in webkit [26168] by lars
  • 3 edits in trunk/JavaScriptCore

fix the invokation of slots with return types. Add a JSLock around the conversion from QVariant to JSValue.

6:58 AM Changeset in webkit [26167] by lars
  • 2 edits in trunk/LayoutTests

remove some tests that are now passing.

6:58 AM Changeset in webkit [26166] by lars
  • 2 edits in trunk/WebKit/qt

set a default encoding for documents. Makes fast/dom/Document/document-charset.html pass.

6:58 AM Changeset in webkit [26165] by lars
  • 2 edits in trunk/WebKit/qt

Don't return a 404 status code for empty data: urls. Fixes fast/dom/HTMLHeadElement/head-check.html

6:58 AM Changeset in webkit [26164] by lars
  • 9 edits in trunk

Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.

6:58 AM Changeset in webkit [26163] by lars
  • 2 edits
    1 add in trunk/LayoutTests

don't try to test objc wrappers on platforms that don't support objc. Add a platform dependent result for Qt.

6:58 AM Changeset in webkit [26162] by lars
  • 1 edit
    1 add in trunk/LayoutTests

expected result for this test. This differs from the Mac result, as I suspect their XMLHttpRequest implementation to have a bug here for local files. If a request is ok, the returned status code should be 200, not 0.

6:57 AM Changeset in webkit [26161] by lars
  • 3 edits in trunk/LayoutTests

fix up the results for one test case, and remove 2 others from the skipped list.

6:57 AM Changeset in webkit [26160] by lars
  • 4 edits in trunk/WebKitTools

add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().

6:57 AM Changeset in webkit [26159] by lars
  • 1 edit
    1 add in trunk/LayoutTests

even though this is a text only test the result is platform dependent.

6:57 AM Changeset in webkit [26158] by lars
  • 3 edits in trunk/WebKit/qt

add a clear() method to QWebPageHistory.

6:52 AM Changeset in webkit [26157] by lars
  • 2 edits in trunk/WebKitTools

make --git-reviewer work again.

2:02 AM Changeset in webkit [26156] by rwlbuis
  • 3 edits
    2 adds in branches/feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15088
HTMLOptionElement.selected returns false when parent HTMLSelectElement is "display: none" until parent's .selectedIndex is accessed

Make sure the list items are up to date when there is no renderer.

Note: See TracTimeline for information about the timeline view.