Context Navigation

← Previous Period
Next Period →

Timeline

Oct 11, 2007:

9:58 PM Changeset in webkit [26380] by oliver

63 edits in branches/feature-branch

Fix Bug 15469: feature branch has 100's of implicit double -> float conversions

Reviewed by Sam.

Re-enable -Wshorten-64-to-32, and make required code changes to make us build sanely again.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
ksvg2/css/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::cssPrimitiveToLength):
ksvg2/css/SVGRenderStyle.h:
ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute): (WebCore::SVGAnimateMotionElement::updateAnimatedValue): (WebCore::parsePoint): (WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines):
ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement): (WebCore::SVGFECompositeElement::parseMappedAttribute):
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
ksvg2/svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement): (WebCore::SVGFELightElement::parseMappedAttribute):
ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement): (WebCore::SVGFEOffsetElement::parseMappedAttribute):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement): (WebCore::SVGFESpecularLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement): (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseMappedAttribute):
ksvg2/svg/SVGFitToViewBox.h:
ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString): (WebCore::SVGLength::PercentageOfViewport):
ksvg2/svg/SVGNumber.idl:
ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse):
ksvg2/svg/SVGNumberList.h:
ksvg2/svg/SVGParserUtilities.cpp: (WebCore::_parseNumber): (WebCore::parseNumber): (WebCore::pointsListFromSVGData): (WebCore::PathBuilder::svgMoveTo): (WebCore::PathBuilder::svgLineTo): (WebCore::PathBuilder::svgCurveToCubic): (WebCore::SVGPathSegListBuilder::svgMoveTo): (WebCore::SVGPathSegListBuilder::svgLineTo): (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): (WebCore::SVGPathSegListBuilder::svgLineToVertical): (WebCore::SVGPathSegListBuilder::svgCurveToCubic): (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::svgArcTo):
ksvg2/svg/SVGParserUtilities.h:
ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::pixelUnitToMillimeterX): (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
ksvg2/svg/SVGSVGElement.h:
ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
ksvg2/svg/SVGTransformDistance.h:
ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformValue):
ksvg2/svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
platform/graphics/svg/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::filterBBoxForItemBBox):
platform/graphics/svg/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext):
platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup):
platform/graphics/svg/cg/SVGResourceFilterCg.mm: (WebCore::SVGResourceFilter::applyFilter):
platform/graphics/svg/filters/SVGFEComponentTransfer.h: (WebCore::SVGComponentTransferFunction::SVGComponentTransferFunction):
platform/graphics/svg/filters/SVGFEComposite.cpp: (WebCore::SVGFEComposite::SVGFEComposite):
platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp: (WebCore::SVGFEConvolveMatrix::SVGFEConvolveMatrix):
platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp: (WebCore::SVGFEDiffuseLighting::SVGFEDiffuseLighting):
platform/graphics/svg/filters/SVGFEFlood.cpp: (WebCore::SVGFEFlood::SVGFEFlood):
platform/graphics/svg/filters/SVGFEGaussianBlur.cpp: (WebCore::SVGFEGaussianBlur::SVGFEGaussianBlur):
platform/graphics/svg/filters/SVGFEMorphology.cpp: (WebCore::SVGFEMorphology::SVGFEMorphology):
platform/graphics/svg/filters/SVGFEOffset.cpp: (WebCore::SVGFEOffset::SVGFEOffset):
platform/graphics/svg/filters/SVGFESpecularLighting.cpp: (WebCore::SVGFESpecularLighting::SVGFESpecularLighting):
platform/graphics/svg/filters/SVGFETurbulence.cpp: (WebCore::SVGFETurbulence::SVGFETurbulence):
platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm: (WebCore::SVGFEColorMatrix::getCIFilter):
platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm: (WebCore::getVectorForChannel): (WebCore::getLightVectors):
platform/graphics/svg/filters/cg/SVGFEImageCg.mm: (WebCore::SVGFEImage::getCIFilter):
rendering/RenderPath.cpp: (WebCore::RenderPath::drawMarkersIfNeeded):
rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::calcViewport): (WebCore::RenderSVGRoot::nodeAtPoint):
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::relativeBBox):
rendering/RenderSVGTextPath.cpp:
rendering/SVGCharacterLayoutInfo.cpp: (WebCore::calculateBaselineShift): (WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo): (WebCore::SVGCharacterLayoutInfo::processedChunk): (WebCore::SVGCharacterLayoutInfo::nextPathLayoutPointAndAngle): (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
rendering/SVGCharacterLayoutInfo.h:
rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::pathForDecoration):
rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::applyTextAnchorToTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):

7:33 PM Changeset in webkit [26379] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/GraphicsContextWx.cpp

64-bit compilation fix.

6:48 PM Changeset in webkit [26378] by andrew

10 edits in branches/feature-branch

JavaScriptCore:

Reviewed by Eric Seidel.

Fix for http://bugs.webkit.org/show_bug.cgi?id=15076
"deg2rad has multiple definitions"

Define deg2rad, rad2deg, deg2grad, grad2deg, rad2grad, grad2rad
These are used through WebKit.

Change based on original patch by Rob Buis.

wtf/MathExtras.h: (deg2rad): (rad2deg): (deg2grad): (grad2deg): (rad2grad): (grad2rad):

WebCore:

Reviewed by Eric Seidel.

Fix for http://bugs.webkit.org/show_bug.cgi?id=15076
"deg2rad has multiple definitions"

Use deg2rad, rad2deg, deg2grad, grad2deg, rad2grad, grad2rad
from wtf where appropriate.

No test cases as this doesn't change behaviour.

Change based on original patch by Rob Buis.

ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::calculate): (WebCore::SVGAngle::convertToSpecifiedUnits): (WebCore::SVGAngle::todeg): (WebCore::SVGAngle::torad):
platform/graphics/AffineTransform.cpp: (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY):
platform/graphics/cg/AffineTransformCG.cpp: (WebCore::AffineTransform::rotate):
platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
rendering/RenderPath.cpp: (WebCore::drawMarkerWithData):

5:24 PM Changeset in webkit [26377] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/PathWx.cpp

Ensure the refcount is properly incremented.

5:16 PM Changeset in webkit [26376] by honeycutt

2 edits in trunk/WebCore

2007-10-11 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

Handle a race condition that could arise if a plugin was loaded while it
was scheduled to be freed: check whether the timer that schedules
library frees is active in PluginPackageWin::load().

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::freeLibrarySoon): Added assertions (WebCore::PluginPackageWin::freeLibraryTimerFired): Added assertion (WebCore::PluginPackageWin::load): If we are scheduled to free this library, cancel the timer, and don't call LoadLibrary

4:54 PM Changeset in webkit [26375] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/ScrollViewWx.cpp

scrollBy needs to convert the scroll offset to an absolute position for the Scroll method. Also, make sure we properly convert pixels to units when scrolling.

4:38 PM Changeset in webkit [26374] by justing

7 edits
1 add in trunk

WebCore:

Reviewed by Harrison.

<rdar://problem/5483567> REGRESSION (Tiger only): Pasting words copied from TextEdit in Mail adds extra newline

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Added. We would like to insert the fragment as-is if possible, but AppKit on Tiger creates fragments from RTF data that have carriage returns and spaces at the beginning and end, and those need to be removed since they'll interfere with paragraph merging. (WebCore::ReplaceSelectionCommand::doApply):
editing/ReplaceSelectionCommand.h:

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5483567> REGRESSION (Tiger only): Pasting words copied from TextEdit in Mail adds extra newline

Re-enabling this test:

editing/pasteboard/5483567.html: Added.
editing/pasteboard/5483567.html-disabled: Removed. Also demonstrates fix:
platform/mac/editing/pasteboard/paste-RTFD-expected.checksum:
platform/mac/editing/pasteboard/paste-RTFD-expected.png:
platform/mac/editing/pasteboard/paste-RTFD-expected.txt:

4:37 PM Changeset in webkit [26373] by kmccullo

2 edits in trunk/WebKitTools

Reviewed by Darin.

Updated rational for the leaks list to be more clear.

Scripts/run-webkit-tests:

4:27 PM Changeset in webkit [26372] by darin

2 deletes in trunk/JavaScriptCore/wtf/unicode

Remove a couple of empty directories.

4:16 PM Changeset in webkit [26371] by zimmermann

30 edits
1 add in branches/feature-branch

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=6421 (<text> textLength attribute is not respected)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=6422 (<text> lengthAdjust attribute is not respected)

Implement textLength and full lengthAdjust (both 'spacing' & 'spacingAndGlyphs' mode)
for <text> & <tspan> & friends. <textPath> is still todo, as it's special.

Also fix usage of cummulatedGlyphWidth/Height in SVGInlineTextBox, calculateGlyphBoundaries was
supposed to be used in the distance calculations, to take per character transformations into account (ie. rotation).

Fixes: svg/W3C-SVG-1.1/text-text-01-b.svg (complelty fixed the single W3C textLength testcase)
Partly fixed: svg/batik/text/textOnPathSpaces.svg (kerning support missing)
Partly fixed: svg/batik/text/textLayout.svg (word-letter spacing & textLength is todo)

4:15 PM Changeset in webkit [26370] by kmccullo

2 edits in trunk/WebKitTools

Rubber Stamp by Sam.

Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
I believe there was a radar on this leak, it looks familiar to me, but I could not find it.

Scripts/run-webkit-tests:

3:31 PM Changeset in webkit [26369] by justing

3 edits
2 adds in trunk

WebCore:

Reviewed by Maciej.

<rdar://problem/5521237> Pasting a word copied from TextEdit after a regular, breaking space, adds a leading newline

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Fixed a typo.

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5521237> Pasting a word copied from TextEdit after a regular, breaking space, adds a leading newline

editing/pasteboard/5521237-expected.txt: Added.
editing/pasteboard/5521237.html: Added.

3:27 PM Changeset in webkit [26368] by oliver

8 edits in branches/feature-branch

Fix for Bug 15468: Parsing of numbers and lists is too lenient in SVG

Reviewed by Niko.

Correct parsing of numbers, number lists, and length lists in SVG.

ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString):
ksvg2/svg/SVGLength.h:
ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::parse):
ksvg2/svg/SVGParserUtilities.cpp: (WebCore::parseNumber):

3:03 PM Changeset in webkit [26367] by aliceli1

2 edits in trunk/LayoutTests

fast/forms/focus-selection-input.html also fails due to unsupported accesskey.
adding to a section that already covers this bug.

platform/win/Skipped:

2:44 PM Changeset in webkit [26366] by eseidel

4 edits
4 adds in branches/feature-branch

2007-10-11 Allan Sandfeld Jensen <sandfeld@kde.org>

Reviewed by Maciej and Eric.

Implement CSS selector combinators nondeterministic matching.
Fixes http://bugs.webkit.org/show_bug.cgi?id=3428

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::checkSelector): Split the function and make the second part recursive (WebCore::CSSStyleSelector::checkOneSelector): Handle pseodo-elements rules and hoveractive quirks here instead of in checkSelector.
css/CSSStyleSelector.h:

2:15 PM Changeset in webkit [26365] by aliceli1

2 edits in trunk/LayoutTests

removing a test that was fixed recently

platform/win/Skipped:

12:52 PM Changeset in webkit [26364] by honeycutt

3 edits in trunk/WebCore

2007-10-10 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://5530519> REGRESSION (303-310A18): Crash when closing tab with
pdf file (Reader 7 only)

Reader 7 subclasses its parent window, so posting a WM_DESTROY to this
window puts us in plugin code. When the plugin forwards the message
back to the original window proc, and we free the plugin library from
there, we will jump back to code we just freed when we return, so delay
calling FreeLibrary at least until the next message loop

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::freeLibrarySoon): Start a timer to free the plugin library (WebCore::PluginPackageWin::freeLibraryTimerFired): Free the library (WebCore::PluginPackageWin::PluginPackageWin): Initialize the timer that will free this library (WebCore::PluginPackageWin::unloadWithoutShutdown): Call freeLibrarySoon()
plugins/win/PluginPackageWin.h: Added m_freeLibraryTimer

11:30 AM Changeset in webkit [26363] by aroben

2 edits in trunk/LayoutTests

Roll out r26186

Apparently some of these tests still fail on the bot even though they
don't fail for me locally.

platform/win/Skipped:

11:20 AM Changeset in webkit [26362] by sfalken

2 edits in trunk/WebKit/win

Delay load additional libraries to improve startup time.

Reviewed by Darin, Ada.

WebKit.vcproj/WebKit.vcproj:

10:04 AM Changeset in webkit [26361] by adachan

7 edits in trunk

WebCore:

<rdar://problem/5534421>
Switched to using wkGetDefaultHTTPCookieStorage() and removed some cookie-related
methods we no longer need in ResourceHandle.

<rdar://problem/5244261> "Never" cookie policy was ignored on windows
Need to set the cookie accept policy on each CFURLRequest.

WebKit/win:

<rdar://problem/5534421>
Switched to using wkGetDefaultHTTPCookieStorage() to avoid recreating CFHTTPCookieStorageRef.
Removed usage of ResourceHandle::cookieStorage().

Reviewed by Oliver.

9:57 AM Changeset in webkit [26360] by adachan

4 edits in trunk/WebKitLibraries

<rdar://problem/5534421>
Added wkGetDefaultHTTPCookieStorage(). Updated libraries.

Reviewed by Darin.

win/include/WebKitSystemInterface/WebKitSystemInterface.h:
win/lib/WebKitSystemInterface.lib:
win/lib/WebKitSystemInterface_debug.lib:

8:16 AM Changeset in webkit [26359] by bdash

8 edits in trunk

2007-10-11 Mark Rowe <mrowe@apple.com>

Reviewed by Tim Hatcher.

Fix for <rdar://problem/5488678>. Disable debugging symbols in production builds for 10.4
PowerPC to prevent a huge STABS section from being generated.

Configurations/Base.xcconfig:

8:10 AM Changeset in webkit [26358] by bdash

2 edits in branches/Safari-2.0-dashboard/WebCore

2007-10-11 Mark Rowe <mrowe@apple.com>

Merge remainder of r12652 from trunk to Safari-2.0-dashboard. This portion
was missed during the merge in r25550.

kwq/KWQTextCodec.mm: (KWQTextDecoder::appendOmittingBOMs): (KWQTextDecoder::convertUsingTEC):

7:29 AM Changeset in webkit [26357] by eseidel

4 edits
4 adds in branches/feature-branch

2007-10-10 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

Fix the SVG dom so that rect.x.baseVal = rect.x.baseVal like it should.
http://bugs.webkit.org/show_bug.cgi?id=14150

Test: svg/dom/animated-tearoff-equlity.xhtml

ksvg2/svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTypeWrapperKey::SVGAnimatedTypeWrapperKey): (WebCore::SVGAnimatedTypeWrapperKey::operator==): (WebCore::SVGAnimatedTypeWrapperKeyHash::hash): (WebCore::SVGAnimatedTypeWrapperKeyHash::equal): (WebCore::SVGAnimatedTypeWrapperKeyHashTraits::deletedValue): (WebCore::SVGAnimatedTypeWrapperKeyHashTraits::emptyValue): (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate): (WebCore::SVGAnimatedTemplate::wrapperCache): (WebCore::SVGAnimatedTemplate::forgetWrapper): (WebCore::lookupOrCreateWrapper):
ksvg2/svg/SVGElement.h:

2:30 AM Changeset in webkit [26356] by lars

3 edits
2 adds in trunk

Ensure that setting innerHTML on an element doesn't do
weird things with the document.
Fixes most issues with http://bugs.webkit.org/show_bug.cgi?id=15456

Oct 10, 2007:

11:49 PM Changeset in webkit [26355] by oliver

2 edits in branches/feature-branch/LayoutTests

Correcting expected output of svg/batik/text/textOnPathSpaces

RS = Eric.

svg/batik/text/textOnPathSpaces-expected.txt

11:01 PM Changeset in webkit [26354] by oliver

3 edits in branches/feature-branch/WebCore

Leopard build fix -- SVGDocument should not trty to make read/write properties read-only

Reviewed by Maciej.

Remove those API definitions SVGDocument now inherits from Document

ksvg2/svg/SVGDocument.idl:

10:30 PM Changeset in webkit [26353] by mjs

3 edits in branches/feature-branch/JavaScriptCore

Reviewed by Eric.

fix assertion failures on quit.

kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Dynamically alocate function-scope static UStrings to avoid the static destructor getting called later.
kjs/lookup.h: Dynamically alocate function-scope static Identifiers to avoid the static destructor getting called later.

8:10 PM Changeset in webkit [26352] by eseidel

48 edits
5 adds in branches/feature-branch

2007-10-10 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

Make renderers pull localTransform instead of depending on DOM elements to push
This allows for cleaner invalidation code, and makes writing animation easier.
Also fixed a tiny bug in SVGRenderImage focus ring calculations while there

Updated test results for svg/custom/focus-ring.svg

WebCore.xcodeproj/project.pbxproj:
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::createRenderer):
ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyAnimatedValueToElement):
ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyAnimatedValueToElement):
ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::canvasResource):
ksvg2/svg/SVGElement.h:
ksvg2/svg/SVGGElement.cpp: (WebCore::SVGGElement::createRenderer):
ksvg2/svg/SVGImageElement.cpp:
ksvg2/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM):
ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource): (WebCore::SVGMarkerElement::notifyAttributeChange):
ksvg2/svg/SVGSVGElement.h:
ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::rendererIsNeeded): (WebCore::SVGStyledElement::notifyResourceParentIfExistant):
ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::style):
ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::parseMappedAttribute): (WebCore::SVGStyledTransformableElement::notifyAttributeChange): (WebCore::SVGStyledTransformableElement::createRenderer):
ksvg2/svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::toPathData):
ksvg2/svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::createRenderer):
ksvg2/svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText):
ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::animatedLocalTransform):
ksvg2/svg/SVGTextElement.h:
ksvg2/svg/SVGTextPathElement.cpp:
ksvg2/svg/SVGTextPathElement.h:
ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::getCTM): (WebCore::SVGTransformable::getScreenCTM):
ksvg2/svg/SVGTransformable.h:
ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::createRenderer): (WebCore::SVGUseElement::attachShadowTree):
platform/graphics/AffineTransform.h: (WebCore::AffineTransform::operator!=):
platform/graphics/svg/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::setMarker):
platform/graphics/svg/SVGResourceMarker.h:
rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::calculateLocalTransform): (WebCore::RenderForeignObject::layout):
rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::localTransform):
rendering/RenderObject.cpp:
rendering/RenderObject.h:
rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): (WebCore::RenderPath::localTransform): (WebCore::RenderPath::calculateLocalTransform): (WebCore::RenderPath::layout):
rendering/RenderPath.h:
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::localTransform): (WebCore::RenderSVGContainer::calculateLocalTransform): (WebCore::RenderSVGContainer::layout):
rendering/RenderSVGContainer.h:
rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localTransform):
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::calculateLocalTransform): (WebCore::RenderSVGText::layout):
rendering/RenderSVGText.h: (WebCore::RenderSVGText::isSVGText): (WebCore::RenderSVGText::localTransform):
rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath): (WebCore::RenderSVGTextPath::startOffset): (WebCore::RenderSVGTextPath::exactAlignment): (WebCore::RenderSVGTextPath::stretchMethod):
rendering/RenderSVGTextPath.h:
rendering/RenderSVGTransformableContainer.cpp: Added. (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
rendering/RenderSVGTransformableContainer.h: Added.
rendering/RenderSVGViewportContainer.h:

8:00 PM Changeset in webkit [26351] by oliver

10 edits in branches/feature-branch/WebCore

Bug 15451: SVGStyledElement must unregister itself from Resources on detach

Reviewed by Eric.

Use a global hashtable to maintain the relationship between the
various SVG resources and their clients, across dom updates, etc.

ChangeLog:
ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::detach):
ksvg2/svg/SVGStyledElement.h:
platform/graphics/svg/SVGPaintServer.h:
platform/graphics/svg/SVGResource.cpp: (WebCore::ResourceSet::ResourceSet): (WebCore::clientMap): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::removeClient): (WebCore::SVGResource::addClient):
platform/graphics/svg/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker):
platform/graphics/svg/SVGResourceClipper.h: (WebCore::SVGResourceClipper::resourceType):
platform/graphics/svg/SVGResourceFilter.h:
platform/graphics/svg/SVGResourceMarker.h:
platform/graphics/svg/SVGResourceMasker.h:

5:25 PM Changeset in webkit [26350] by darin

1 edit in trunk/LayoutTests/fast/js/resources/js-test-pre.js

Oops, forgot to save this file.

5:24 PM Changeset in webkit [26349] by darin

5 edits in trunk/LayoutTests

Reviewed by Kevin McCullough and Sam Weinig.

fix mistake in test function that treated all non-prototype objects as equal

That means that all numbers are treated as equal!
And all boolean values!

Kevin noticed that his new test was succeeding even though the bug was still
there. Turns out the code to compare arrays that I added with my fix for
bug 14931 was misfiring all the time.

fast/js/resources/js-test-pre.js: Use Object.prototype.toString.call to test if something is an array. Thanks, Sam.

fast/dom/Window/new-window-opener-expected.txt: Update this to reflect the fact that the test is actually failing!
fast/forms/focus-selection-textarea-expected.txt: Ditto.
fast/js/kde/encode_decode_uri-expected.txt: Ditto.

4:30 PM Changeset in webkit [26348] by thatcher

1 move in branches/old/su-jag-pink-branch