⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 14, 2007:

4:46 PM Changeset in webkit [26601] by darin
  • 2 edits
    17 adds in trunk/LayoutTests
  • added exceptions for all the tests failing on my personal Leopard machine

This may or may not get the buildbot green. I'll file separate bugs for each
of the tests with changed results.

  • platform/mac-leopard/dom: Added.
  • platform/mac-leopard/dom/xhtml: Added.
  • platform/mac-leopard/dom/xhtml/level2: Added.
  • platform/mac-leopard/dom/xhtml/level2/html: Added.
  • platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Added.
  • platform/mac-leopard/editing: Added.
  • platform/mac-leopard/editing/pasteboard: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Added.
  • platform/mac-leopard/http: Added.
  • platform/mac-leopard/http/tests: Added.
  • platform/mac-leopard/http/tests/security: Added.
  • platform/mac-leopard/http/tests/security/dataURL: Added.
  • platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
  • platform/mac-leopard/svg/custom: Added.
  • platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Added.
  • platform/mac-leopard/webarchive: Added.
  • platform/mac-leopard/webarchive/test-xml-stylesheet-expected.txt: Added.
  • platform/mac-leopard/security/block-test-expected.txt: Changed results.
4:20 PM Changeset in webkit [26600] by darin
  • 1 edit
    3 copies
    1 delete in trunk/LayoutTests
  • moved a test that somehow ended up doubly-nested in platform/mac
  • platform/mac/fast/text/justified-text-rect-expected.checksum: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.checksum.
  • platform/mac/fast/text/justified-text-rect-expected.png: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.png.
  • platform/mac/fast/text/justified-text-rect-expected.txt: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.txt.
  • platform/mac/platform: Removed.
  • platform/mac/platform/mac: Removed.
  • platform/mac/platform/mac/fast: Removed.
  • platform/mac/platform/mac/fast/text: Removed.
  • platform/mac/platform/mac/fast/text/justified-text-rect-expected.checksum: Removed.
  • platform/mac/platform/mac/fast/text/justified-text-rect-expected.png: Removed.
  • platform/mac/platform/mac/fast/text/justified-text-rect-expected.txt: Removed.
3:30 PM Changeset in webkit [26599] by oliver
  • 13 edits
    1661 adds
    1634 deletes in trunk/LayoutTests

Revert "Rubberstamped by Eric."

This reverts commit 4ae99caea8eb153f9b85e86d1819b19b4af12fb4.
RS=Niko

Revert layout test move.

Filed ​http://bugs.webkit.org/show_bug.cgi?id=15513 to track correction for even earlier change

Conflicts:

1:15 PM Changeset in webkit [26598] by zimmermann
  • 1 edit in trunk/LayoutTests/ChangeLog

Not reviewed. Don't list all individual files in the ChangeLog -> make Mark happy

12:09 PM Changeset in webkit [26597] by zimmermann
  • 13 edits
    1 move
    5 deletes in trunk/LayoutTests

Rubberstamped by Eric.

Move current layout tests results from platform/mac/svg to platform/mac-tiger/svg.
The problem is that the current results have accidently been generated with Leopard,
I'm still moving this to mac-tiger so we don't loose the history for all the results.
After this commit, the baseline will be regenerated in mac-tiger/svg, and someone with
Leopard needs to generate new results in mac-leopard/svg.

10:51 AM Changeset in webkit [26596] by sfalken
  • 2 edits in branches/Safari-3-branch/WebKit/win

Merged fix from r26594.

10:45 AM Changeset in webkit [26595] by zimmermann
  • 10 edits
    1 delete in trunk/WebCore

Reviewed by Eric.

Fix bad abstraction in ImageBuffer class.
While the class itself is platform-aware and thus it's location in platform/graphics
is fine, it contains the "renderSubtreeToImage" method which operates on RenderObject.

As it's SVG specific I decided to move this method into SVGRenderSupport, to avoid
implicit platform/ <-> rendering/ dependencies.

10:40 AM Changeset in webkit [26594] by sfalken
  • 2 edits in trunk/WebKit/win

Move pthreads up in the linker order and don't mark it for delay load.
Fixes crash during regsvr32 of WebKit (currently repro if you do a spade ti).


Reviewed by Darin, Ada.

  • WebKit.vcproj/WebKit.vcproj:
6:27 AM BuildingQtOnLinux edited by zecke2@selfish.org
(diff)
6:02 AM Changeset in webkit [26593] by bdash
  • 2 edits in trunk/WebKitTools

2007-10-14 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

  • Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line when querying for QMAKE_MKSPECS.
5:52 AM BuildingGtk edited by zecke2@selfish.org
(diff)
5:06 AM Changeset in webkit [26592] by andrew
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.


Fix run-webkit-tests is too greedy calculating platform hierarchy
​http://bugs.webkit.org/show_bug.cgi?id=15465


Fix run-webkit-tests being too greedy in trying to split the platform name up
causing it to try and find tests in every directory above the first "-" in the
path to the LayoutTests

  • Scripts/run-webkit-tests:
4:59 AM Changeset in webkit [26591] by bdash
  • 2 edits in trunk/WebCore

2007-10-14 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15210
Draw the image outline even for broken images.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
4:58 AM Changeset in webkit [26590] by bdash
  • 3 edits in trunk/WebKit/gtk

2007-10-14 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=15299
Fix "hovering_over_link" signal not emitted when consecutive links
are hovered.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/ChromeClientGtk.h:
  • Remove m_didSendLinkSignal as it is superseded by m_hoveredLinkURL
4:55 AM Changeset in webkit [26589] by bdash
  • 12 edits in trunk

2007-10-14 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam.

Add support for MSVC7, and fix cases where PLATFORM(WIN) should
be PLATFORM(WIN_OS) for other ports building on Windows.

  • dom/XMLTokenizer.cpp:
  • page/FrameTree.cpp:
  • platform/StaticConstructors.h:
  • platform/String.cpp:

2007-10-5 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam.


Add support for MSVC7, and fix cases where PLATFORM(WIN) should
be PLATFORM(WIN_OS) for other ports building on Windows.


  • kjs/DateMath.cpp: (KJS::getDSTOffsetSimple):
  • kjs/JSImmediate.h:
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/Platform.h:
  • wtf/StringExtras.h: (snprintf): (vsnprintf):
4:49 AM Changeset in webkit [26588] by bdash
  • 2 edits in trunk/WebCore

2007-10-14 Maxime Britto <​mbritto@pleyo.com>

Reviewed by Mitz.

Fix an error in the goBackOrForward() function : confusion between forwardListCount and backListCount.
​http://bugs.webkit.org/show_bug.cgi?id=15212

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::goBackOrForward):
4:44 AM Changeset in webkit [26587] by bdash
  • 4 edits
    4 adds in trunk

2007-10-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/button-text-transform.html

Text transformations require access to the original text. The button's inner
text was an anonymous RenderText, meaning it did not have a node to retrieve
the original text from. The patch fixes this by changing the inner text into a
RenderTextFragment, which stores its own original text.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::setText):
  • rendering/RenderButton.h:

2007-10-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/button-text-transform.html: Added.
  • platform/mac/fast/forms/button-text-transform-expected.checksum: Added.
  • platform/mac/fast/forms/button-text-transform-expected.png: Added.
  • platform/mac/fast/forms/button-text-transform-expected.txt: Added.
4:42 AM Changeset in webkit [26586] by bdash
  • 3 edits in trunk/WebKitTools

2007-10-14 Oleg Sukhodolsky <​son.two@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15006
Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
to reduce code duplication.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm: buildQMakeProject() renamed to buildQMakeQtProject(). buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory), unused $colorize has been removed.
4:39 AM Changeset in webkit [26585] by bdash
  • 3 edits
    2 adds in trunk

2007-10-14 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

REGRESSION: Javascript bug in getElementsByName
​http://bugs.webkit.org/show_bug.cgi?id=15274

Test: fast/dom/getelementbyname-invalidation.html

  • dom/NameNodeList.h: remove empty rootNodeChildrenChanged override

2007-10-14 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=15274
REGRESSION: Javascript bug in getElementsByName

  • fast/dom/getelementbyname-invalidation-expected.txt: Added.
  • fast/dom/getelementbyname-invalidation.html: Added.
4:35 AM Changeset in webkit [26584] by bdash
  • 3 edits in trunk/WebCore

2007-10-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

This patch reverts the kjs_window.* parts of r25576 because following
r25783, window properties, including dialog arguments, are not cleared
when the newly created modal dialog transitions to the document.

  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::createWindow): (KJS::showModalDialog): (KJS::Window::clear): (KJS::WindowFunc::callAsFunction): (KJS::Window::setReturnValueSlot):
  • bindings/js/kjs_window.h:
4:33 AM Changeset in webkit [26583] by bdash
  • 3 edits
    4 adds in trunk

2007-10-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/table/generated-caption.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Changed to make sure that the child is not added into generated after content. Also made adding a child before a table caption work correctly instead of adding the child after the caption.

2007-10-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/table/generated-caption.html: Added.
  • platform/mac/fast/table/generated-caption-expected.checksum: Added.
  • platform/mac/fast/table/generated-caption-expected.png: Added.
  • platform/mac/fast/table/generated-caption-expected.txt: Added.
4:31 AM Changeset in webkit [26582] by bdash
  • 8 edits in trunk

2007-10-14 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Adds NegateNode optimization from KJS. The relevant revision in KDE
is 666736.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (NumberNode::evaluate):
  • kjs/nodes.h: (KJS::Node::): (KJS::NumberNode::):
  • kjs/nodes2string.cpp: (NumberNode::streamTo):

2007-10-14 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Adds serialization test cases for NegateNode optimization from KDE.

  • fast/js/function-decompilation-operators-expected.txt:
  • fast/js/function-decompilation-operators.html:
4:30 AM Changeset in webkit [26581] by bdash
  • 3 edits
    3 adds in trunk

2007-10-14 Jason Foreman <​jason@threeve.org>

Reviewed by Maciej.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15145


Ensure that if adjusting n to minimize the difference of n*intPow10(e-p+1) to x,
that the property n < intPow10(p) is maintained.

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):

2007-10-14 Jason Foreman <​jason@threeve.org>

Reviewed by Maciej.

Adding test for ​http://bugs.webkit.org/show_bug.cgi?id=15145.

  • ChangeLog:
  • fast/js/number-toprecision-expected.txt: Added.
  • fast/js/number-toprecision.html: Added.
  • fast/js/resources/number-toprecision.js: Added.
4:28 AM Changeset in webkit [26580] by bdash
  • 2 edits in trunk/WebCore

2007-10-14 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15141
Feed GIF reader data from the point in the stream it expects. Also,
mirror the reader's failure state up to the wrapping decoder.

  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
4:27 AM Changeset in webkit [26579] by bdash
  • 2 edits in trunk/WebCore

2007-10-14 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15142
Return correct frame count in GIFImageDecoder::frameBufferAtIndex(),
even if more data has arrived since the last decoding pass.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex):
4:25 AM Changeset in webkit [26578] by bdash
  • 2 edits in trunk/LayoutTests

2007-10-14 Feng Qian <​ian.eng.webkit@gmail.com>

Reviewed by Maciej.

  • fast/events/window-events-bubble2.html:
4:17 AM Changeset in webkit [26577] by bdash
  • 2 edits in branches/Safari-3-branch/WebCore

Bad Mark, wrong branch.

4:16 AM Changeset in webkit [26576] by bdash
  • 2 edits in branches/Safari-3-branch/WebCore

2007-10-14 Satoshi Ueyama <​gyuque@gmail.com>

Reviewed by Adam Roben.

  • ksvg2/scripts/cssmakevalues: Replaced chomp with regexp. chomp doesn't work well with CR-LF endings.
4:11 AM Changeset in webkit [26575] by bdash
  • 4 copies
    4 adds in branches/Safari-3-branch

Roll over ChangeLogs for JavaScriptCore, LayoutTests, WebCore and WebKit.

4:02 AM Changeset in webkit [26574] by bdash
  • 4 copies
    4 adds in trunk

Roll over ChangeLogs for JavaScriptCore, LayoutTests, WebCore and WebKit.

2:03 AM Changeset in webkit [26573] by eseidel
  • 2 edits in trunk/WebCore

2007-10-14 Eric Seidel <​eric@webkit.org>

Reviewed by aroben.

Remove senseless malloc from paintOutline
No tests needed, no functional change.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutline): remove unneeded malloc

Oct 13, 2007:

9:12 PM Changeset in webkit [26572] by oliver
  • 4 edits
    7 adds in trunk/LayoutTests

Adding leopard specific results to a few SVG specific tests

RS=Maciej.

  • platform/mac-leopard/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/mac-leopard/svg/batik/text/textBiDi-expected.txt: Added.
  • platform/mac-leopard/svg/hixie/text/003-expected.txt:
  • platform/mac-leopard/svg/hixie/text/003a-expected.txt:
  • platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
  • platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/mac-leopard/svg/text/text-path-01-b-expected.txt: Added.
7:07 PM Changeset in webkit [26571] by eseidel
  • 3 edits in trunk/WebCore

2007-10-13 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

Fix SVGSVGElement::currentView() to not leak by using an OwnPtr.
This fix is incompatible with changes eventually needed for supporting
SVGSVGElement.currentView in the bindings (that needs a ref'd object)
There are also several parser crashers in SVGViewSpec, but those will be fixed
in my next patch.


Leak fix only, no additional tests needed.

  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentView): call .get() and .set()
  • ksvg2/svg/SVGSVGElement.h: use OwnPtr
3:36 PM Changeset in webkit [26570] by oliver
  • 5 edits in trunk/LayoutTests

Make svg/batik/text/textDecoration2.svg use Lucida Grande

RS=Eric.

This test case used to use Lucida Sans which is apparently available on some
systems, but not all. Switching to Lucida Grande results in a slight change
but we'll be testing with a font that everyone has.

  • svg/batik/text/textDecoration2-expected.checksum:
  • svg/batik/text/textDecoration2-expected.png:
  • svg/batik/text/textDecoration2-expected.txt:
  • svg/batik/text/textDecoration2.svg:
2:41 PM Changeset in webkit [26569] by oliver
  • 9 edits in trunk/WebCore

Fixing a few testcases by enabling SVG_EXPERIMENTAL on windows, and making the required fixes and corrections.

Reviewed by Maciej

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/build-generated-files.sh:
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::colorFromRGBColorString):
  • page/DOMWindow.idl:
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
  • platform/win/WebCoreTextRenderer.cpp:
Note: See TracTimeline for information about the timeline view.