Context Navigation

← Previous Period
Next Period →

Timeline

Oct 15, 2007:

10:53 PM Changeset in webkit [26653] by ddkilzer

1 edit
1 add in trunk/WebKitTools

WebKitTools:

Reviewed by Eric.

fix http://bugs.webkit.org/show_bug.cgi?id=15002 Script to automatically search nightly builds for regressions (bisect-builds)

Scripts/bisect-builds: Added.

10:17 PM Changeset in webkit [26652] by bdash

2 edits in trunk/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Reviewed by John.

<rdar://problem/5494040> Reproducible assertion failure in WebCore::IconDatabase::iconForPageURL

A race condition between icon database import and Safari asking for an icon for the empty URL
was resulting in a PageURLRecord being created for a URL that can never be retained. By enforcing
that PageURLRecord's cannot be created for the empty URL we can prevent the assertion from failing.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::getOrCreatePageURLRecord): Bail out early if the URL is empty. (WebCore::IconDatabase::performURLImport): Don't create the PageURLRecord if the URL is empty.

9:51 PM Changeset in webkit [26651] by honeycutt

3 edits in trunk/WebCore

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

Use OwnPtr for m_deliveryData, and fix a bug where we were memmove()ing
over m_deliveryData instead of its data buffer

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::~PluginStreamWin): Don't delete m_deliveryData (WebCore::PluginStreamWin::deliverData): Fix memmove() call (WebCore::PluginStreamWin::didReceiveData): Assign using OwnPtr::set()
plugins/win/PluginStreamWin.h: Use OwnPtr

9:14 PM Changeset in webkit [26650] by bdash

4 edits in branches/Safari-3-branch

Versioning.

9:11 PM Changeset in webkit [26649] by bdash

1 copy in tags/Safari-4523.12

New tag.

8:42 PM Changeset in webkit [26648] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26646.

8:39 PM Changeset in webkit [26647] by bdash

2 edits in branches/Safari-3-branch/WebKit

Merge r26645.

8:39 PM Changeset in webkit [26646] by sfalken

2 edits in trunk/WebCore

Reviewed by Oliver.

Add missing null check.

platform/network/cf/AuthenticationCF.cpp: (WebCore::core):

8:30 PM Changeset in webkit [26645] by kdecker

2 edits in trunk/WebKit

Reviewed by Darin Adler.

Fixed: <rdar://problem/5520541> REGRESSION: Broken image when forwarding certain email on Tiger

WebCoreSupport/WebFrameBridge.mm: The problem was that we were loading Mail's WebKit plug-in too soon, which borked some necessary housekeeping on behalf of Mail. The fix is to add a quirk that treats Tiger Mail's WebKit plug-in like a Netscape plug-in, thus ensuring the plug-in will load during first layout and not attach time. For this plug-in, loading at first layout is expected and is consistent with Safari 2 behavior.

7:34 PM Changeset in webkit [26644] by bdash

3 edits in trunk/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Fix the no-SVG build again. Add new transform CSS properties to the switch statements.

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

6:53 PM Changeset in webkit [26643] by bdash

1 copy in tags/WebCore-419.2.3-dashboard/WebCore

New tag (part 2).

6:53 PM Changeset in webkit [26642] by bdash

1 add in tags/WebCore-419.2.3-dashboard

New tag (part 1).

6:51 PM Changeset in webkit [26641] by bdash

2 edits in branches/Safari-2.0-dashboard/WebCore

Versioning.

6:49 PM Changeset in webkit [26640] by bdash

8 edits in branches/Safari-2.0-dashboard/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Roll out r25691, the merge of r24938 and r24946.

6:30 PM Changeset in webkit [26639] by mjs

3 edits
21 adds in trunk

JavaScriptCore:

Reviewed by Darin.

fixes for "New JavaScript benchmark" http://bugs.webkit.org/show_bug.cgi?id=15515

kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): Implement "load" for compatibility with SpiderMonkey. (TestFunctionImp::): ditto (doIt): ditto (kjsmain): Drop useless --> from output.

SunSpider:

Reviewed by Darin.

New JavaScript benchmark http://bugs.webkit.org/show_bug.cgi?id=15515

A start on a new JavaScript benchmark, with standalone and
browser-hosted drivers.

The test content is still incomplete and the drivers could use
some more features but there is enough here to make a good start.

The drivers compute a 95% confidence interval on the mean for the
whole test, each category, and each individual test to make it
easier to tell whether differences are statistically
significant. The confidence interval can be narrowed by running
the test more times.

TODO: Added. Remaining things that need to be done.
sunspider: Added. Perl script that acts as the standalone test driver.
resources/sunspider-standalone-driver.js: Added. JavaScript part of standalone test driver.
resources/sunspider-analyze-results.js: Added. JavaScript statistical analysis code.
resources/TEMPLATE.html: Added. Template for browser-hosted tests.
make-hosted: Added. Script to generate browser-hosted tests.
hosted/sunspider.html: Added. Start page for browser-hosted test.
hosted/sunspider-driver.html: Added. Driver for browser-hosted tests.
hosted/sunspider-results.html: Added. Results page for browser-hosted tests.
hosted/sunspider-record-result.js: Added. Helper file for browser-hosted tests.
tests/LIST: Added. List of tests to use.
tests/bitops-3bit-bits-in-byte.js: Added. Some initial test content.
tests/bitops-bits-in-byte.js: Added. Ditto.
tests/bitops-bitwise-and.js: Added. Ditto.
tests/math-cordic.js: Added. Ditto.

WebKitTools:

Reviewed by Darin.

New JavaScript benchmark http://bugs.webkit.org/show_bug.cgi?id=15515

Scripts/run-sunspider: Added. Wrapper to run sunspider on the current development or release build of JavaScriptCore.

4:54 PM Changeset in webkit [26638] by darin

4 edits in trunk/WebCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15518 Remove the unused attemptFontSubstitution feature and do some cleanup of glyphDataForCharacter.

platform/Font.h:
platform/Font.cpp: (WebCore::WidthIterator::advance): Eliminated uneeded attemptFontSubstitution and cluster parameters to the glyphDataForCharacter function. (WebCore::Font::glyphDataForCharacter): Removed the cluster parameter and attemptFontSubstitution parameter. Removed the isUpper check before calling toUpper in the small caps code path. Split up the inner loop into separate copies for non-small-caps and small caps. Broke out the system fallback page handling so it's not inside the loop. Changed system fallback so it uses the character and breaks it up into UTF-16 as needed, instead of using a passed-in "character cluster".

platform/TextStyle.h: (WebCore::TextStyle::TextStyle): Removed attemptFontSubstitution. (WebCore::TextStyle::applyWordRounding): Ditto.

4:52 PM Changeset in webkit [26637] by ggaren

6 edits in trunk/LayoutTests

Fixed layout test for reals. Changed \r\n to \n, fixing mass confusion.

fast/js/do-while-expression-value-expected.txt:
fast/js/do-while-expression-value.html:
fast/js/nested-function-scope.html:
fast/js/while-expression-value-expected.txt:
fast/js/while-expression-value.html:

4:18 PM Changeset in webkit [26636] by honeycutt

2 edits in trunk/WebCore

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

Remove an operator precedence warning on Windows

editing/markup.cpp: (WebCore::escapeContentText): Use (a) | (b) (WebCore::appendEscapedContent): Use (a) | (b)

3:59 PM Changeset in webkit [26635] by kmccullo

5 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5238818> window.resizeTo doesn't restrict the resized window to the size of the screen
Now we take the doc into account when resizing.
Also I found an issue where we would resize to outside the window, because the resize would be smaller than the window size but the location of the window would make the resize go off-screen. Now we move the window back into the screen.

bindings/js/kjs_window.cpp: (KJS::adjustWindowRect): (KJS::WindowFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5238818> window.resizeTo doesn't restrict the resized window to the size of the screen
Now we take the dock into account when resizing.
Also I found an issue where we would resize to outside the window, because the resize would be smaller than the window size but the location of the window would make the resize go off-screen. Now we move the window back into the screen.

fast/dom/Window/window-resize-expected.txt:
fast/dom/Window/window-resize.html:

3:36 PM Changeset in webkit [26634] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26632.

3:34 PM Changeset in webkit [26633] by bdash

2 edits in trunk/WebKitTools

2007-10-15 Mark Rowe <mrowe@apple.com>

Reviewed by Sam.

Fix 'run-webkit-tests --qt' complaining about the --qt argument.

Scripts/webkitdirs.pm:
Change checkArgv to remove the options from @ARGV to prevent them from interfering with further option processing.
Fix logic error in determineIsQt that would prevent it from bailing out early.
Change isOSX to mean OS X and not Qt or Gtk. Most of our uses of isOSX assume that this is the meaning already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.

3:27 PM Changeset in webkit [26632] by honeycutt

2 edits in trunk/WebCore

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5510700> Repro crash loading embedded Windows Media Player
content

Anders noticed that the older Windows Media Player plugin (npdsplay.dll)
will crash if it receives its resource requests out of order, whereas we
were immediately fulfilling untargeted, non-JavaScript requests and
scheduling targeted or JavaScript resource requests. Implement his
suggested fix, which is to schedule PluginRequests for all resource
requests

plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): If this non-JavaScript request has no target, create a stream for it (WebCore::PluginViewWin::load): Schedule PluginRequests for all resource requests

3:12 PM Changeset in webkit [26631] by bdash

2 edits in trunk/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Gtk and Qt build fix. Add new .cpp file to project.

WebCore.pro:

2:59 PM Changeset in webkit [26630] by sullivan

2 edits in trunk/WebCore

platform/mac/FontDataMac.mm: D'oh! Added missing #import to fix build

2:42 PM Changeset in webkit [26629] by sullivan

4 edits in trunk/WebKit

Reviewed by Geoff Garen

Replaced NS_DURING/NS_HANDLER with @try/@catch throughout WebKit

I made the following changes:

replaced NS_DURING with @try, and added opening brace if there wasn't one
replaced NS_HANDLER with @catch (NSException *localException), and added braces if there weren't any
removed NS_ENDHANDLER, and added a closing brace if there wasn't one
in a couple of places, fixed indentation therein

Misc/WebIconDatabase.mm: (objectFromPathForKey):
WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]): (-[WebHTMLView beginDocument]): (-[WebHTMLView deleteToMark:]):
WebView/WebView.mm: (-[WebView initWithCoder:]):

2:41 PM Changeset in webkit [26628] by sullivan

2 edits in trunk/WebCore

Reviewed by Geoff

platform/mac/FontDataMac.mm: (WebCore::FontData::smallCapsFontData): replace NS_DURING/NS_HANDLER with WebCore-style BEGIN/END_BLOCK_OBJC_EXCEPTIONS

2:25 PM Changeset in webkit [26627] by ggaren

2 edits in trunk/LayoutTests

Changed line ending style of results file to fix layout test that was
failing locally on my machine.

fast/js/nested-function-scope-expected.txt:

2:15 PM Changeset in webkit [26626] by hyatt

7 edits
2 adds in trunk/WebCore

The CSS WG has been discussing the concept of rotation. In the latest draft specification, two properties
have been introduced: rotation and rotation-point. I believe these properties should be generalized to
allow for arbitrary transformations (e.g., translation, skew, rotate, scale).

This patch adds support for the back-end parsing of two new CSS properties: transform and transform-origin.
They are directly analogous to the properties specified by the CSS WG, except that they are designed to allow
for arbitrary affine transforms rather than just rotation.

Reviewed by Beth Dakin

WebCore.xcodeproj/project.pbxproj:
WebCore.vcproj/WebCore.vcproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::TransformParseContext:::m_list): (WebCore::TransformParseContext::list): (WebCore::TransformParseContext::failed): (WebCore::TransformParseContext::addValue): (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::TransformOperationInfo::type): (WebCore::TransformOperationInfo::argCount): (WebCore::TransformOperationInfo::unit): (WebCore::TransformOperationInfo::unknown): (WebCore::TransformOperationInfo::hasCorrectArgCount): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin):
css/CSSParser.h:
css/CSSPropertyNames.in:
css/CSSTransformValue.cpp: Added. (WebCore::CSSTransformValue::CSSTransformValue): (WebCore::CSSTransformValue::~CSSTransformValue): (WebCore::CSSTransformValue::addValue): (WebCore::CSSTransformValue::cssText):
css/CSSTransformValue.h: Added. (WebCore::CSSTransformValue::):

1:58 PM Changeset in webkit [26625] by ggaren

2 edits in trunk/JavaScriptCore

Removed unnecessary #include.

API/JSObjectRef.cpp:

1:57 PM Changeset in webkit [26624] by ggaren

2 edits in trunk/JavaScriptCore

Double-reverse build fix. My tree was out of date.

kjs/nodes.cpp: (NumberNode::evaluate):

1:53 PM Changeset in webkit [26623] by bdash

3 edits in trunk/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

Fix the no-SVG build.

DerivedSources.make: Use the correct file as input to generate CSSPropertyNames.h.
rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary):

1:47 PM Changeset in webkit [26622] by ggaren

2 edits in trunk/JavaScriptCore

Build fix.

kjs/nodes.cpp: (NumberNode::evaluate):

1:44 PM Changeset in webkit [26621] by ggaren

5 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

Removed surprising self-named "hack" that made nested functions
available as named properties of their containing functions, and placed
containing function objects in the scope chains of nested functions.

There were a few reasons to remove this "hack:"

It contradicted FF, IE, and the ECMA spec.

It incurred a performance penalty, since merely parsing a function required parsing its body for nested functions (and so on).

SVN history contains no explanation for why it was added. It was just legacy code in a large merge a long, long time ago.

[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

kjs/nodes.cpp: (FuncDeclNode::processFuncDecl):

LayoutTests:

Reviewed by Darin Adler.

Removed surprising self-named "hack" that made nested functions
available as named properties of their containing functions, and placed
containing function objects in the scope chains of nested functions.

[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

Changed this test to reflect correct behavior:

fast/js/kde/function-expected.txt:
fast/js/kde/resources/function.js: (Also removed tab characters.)

Added this test to flesh out the behavior more:

fast/js/nested-function-scope-expected.txt: Added.
fast/js/nested-function-scope.html: Added.

1:41 PM Changeset in webkit [26620] by ggaren

4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Removed the concept of AnonymousCode. It was unused, and it doesn't
exist in the ECMA spec.

[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

kjs/Context.cpp: (KJS::Context::Context):
kjs/function.h: (KJS::):
kjs/nodes.cpp: (ReturnNode::execute):

1:40 PM Changeset in webkit [26619] by ggaren

3 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

Made function parameters DontDelete. This matches FF and the vague
description in ECMA 10.1.3. It's also required in order to make
symbol table based lookup of function parameters valid. (If the
parameters aren't DontDelete, you can't guarantee that you'll find
them later in the symbol table.)

[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

kjs/function.cpp: (KJS::FunctionImp::passInParameters):

LayoutTests:

Committed revision 26618.

Made function parameters DontDelete.

fast/js/delete-function-parameter-expected.txt: Added.
fast/js/delete-function-parameter.html: Added.

1:39 PM Changeset in webkit [26618] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Some Vector optimizations. These are especially important when using
Vector as a stack for implementing recursive algorithms iteratively.

[ Broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

Added shrink(), which is a version of resize() that you can call to save a branch / improve code generation and inlining when you know that the vector is not getting bigger.

Changed subclassing relationship in VectorBuffer to remove a call to fastFree() in the destructor for the inlineCapacity != 0 template specialization. This brings inline Vectors one step closer to true stack-allocated arrays.

Also changed abort() to CRASH(), since the latter works better.

wtf/Vector.h: (WTF::VectorBufferBase::allocateBuffer): (WTF::VectorBufferBase::deallocateBuffer): (WTF::VectorBufferBase::VectorBufferBase): (WTF::VectorBufferBase::~VectorBufferBase): (WTF::): (WTF::VectorBuffer::VectorBuffer): (WTF::VectorBuffer::~VectorBuffer): (WTF::VectorBuffer::deallocateBuffer): (WTF::VectorBuffer::releaseBuffer): (WTF::Vector::clear): (WTF::Vector::removeLast): (WTF::::operator): (WTF::::fill): (WTF::::shrink):

1:36 PM Changeset in webkit [26617] by ggaren

4 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Fixed http://bugs.webkit.org/show_bug.cgi?id=15490
Iteration statements sometimes incorrectly evaluate to the empty value
(KDE r670547).

[ Broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

This patch is a merge of KDE r670547, with substantial modification
for performance.

It fixes do-while statements to evaluate to a value. (They used
to evaluate to the empty value in all cases.)

It also fixes SourceElementsNode to maintain the value of abnormal
completions like "break" and "continue."

It also re-works the main execution loop in SourceElementsNode so that
it (1) makes a little more sense and (2) avoids unnecessary work. This
is a .28% speedup on command-line JS iBench.

kjs/nodes.cpp: (DoWhileNode::execute): (SourceElementsNode::execute):

LayoutTests:

Reviewed by Maciej Stachowiak.

Layout tests for http://bugs.webkit.org/show_bug.cgi?id=15490
Iteration statements sometimes incorrectly evaluate to the empty value
(KDE r670547)

fast/js/do-while-expression-value-expected.txt: Added.
fast/js/do-while-expression-value.html: Added.
fast/js/while-expression-value-expected.txt: Added.
fast/js/while-expression-value.html: Added.

12:02 PM Changeset in webkit [26616] by darin

5 edits in trunk

WebCore:

Reviewed by Sam.

fix http://bugs.webkit.org/show_bug.cgi?id=15520 alert(undefined) should say "undefined" in the alert

Test: fast/dom/Window/alert-undefined.html

page/DOMWindow.idl: Remove ConvertUndefinedOrNullToNullString from alert, confirm, and prompt. It turns out that the default behavior is what the other browsers do (browsers tested: IE 7, Firefox 2).

LayoutTests:

Reviewed by Sam.

fix http://bugs.webkit.org/show_bug.cgi?id=15520 alert(undefined) should say "undefined" in the alert

fast/dom/Window/alert-undefined.html: Added tests of null and both confirm and prompt.
fast/dom/Window/alert-undefined-expected.txt: Updated.

11:47 AM Changeset in webkit [26615] by darin

4 edits in trunk/WebKitTools

Reviewed by Sam.

added logging of window.prompt and window.confirm

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Implement the recommended delegate rather than the deprecated one. (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Added. (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Added.

DumpRenderTree/win/UIDelegate.h:
DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string. (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added. (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added. (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.

11:39 AM Changeset in webkit [26614] by adele

3 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=15252
<rdar://problem/5498184> REGRESSION: <select multiple> doesn't scroll to top when old options are removed and new ones are added, leaving listbox empty-looking

rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight): If the scrollbar is disabled, make sure the scroll offset gets reset to 0. In general, we don't want to unnecessarily adjust the scroll offset, but in this case, there won't be an obvious way for the user to adjust the scroller position once it's disabled.

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=15252
<rdar://problem/5498184> REGRESSION: <select multiple> doesn't scroll to top when old options are removed and new ones are added, leaving listbox empty-looking

fast/forms/listbox-scroll-after-options-removed-expected.txt: Added.
fast/forms/listbox-scroll-after-options-removed.html: Added.

11:17 AM Changeset in webkit [26613] by sfalken

1 edit in branches/Safari-3-branch/WebCore/ChangeLog

Merged fix from r26610.

11:16 AM Changeset in webkit [26612] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26608.

11:15 AM Changeset in webkit [26611] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26607.

11:01 AM Changeset in webkit [26610] by honeycutt

1 edit in trunk/WebCore/ChangeLog

Fixing a date in the ChangeLog

10:25 AM Changeset in webkit [26609] by aliceli1

10 edits
4 adds in trunk

WebKitTools:

Reviewed by Sam Weinig.

Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail

DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Like on mac, before running each test, set the webview's policy delegate to null (main): allocate the global policy delegate for DRT's custom use
DumpRenderTree/win/DumpRenderTree.vcproj: Adding files to project
DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate): set the webview's policy delegate to DRT's custom one if the test requests it.
DumpRenderTree/win/PolicyDelegate.cpp: Added. Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm (PolicyDelegate::PolicyDelegate): (PolicyDelegate::QueryInterface): (PolicyDelegate::AddRef): (PolicyDelegate::Release): (PolicyDelegate::decidePolicyForNavigationAction):
DumpRenderTree/win/PolicyDelegate.h: Added. (PolicyDelegate::decidePolicyForNewWindowAction): (PolicyDelegate::decidePolicyForMIMEType): (PolicyDelegate::unableToImplementPolicyWithError):

win:

Reviewed by Sam Weinig.

Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail

DefaultPolicyDelegate.cpp: Added. Implementation is a direct port of WebKit/DefaultDelegates/WebDefaultPolicyDelegate.m (DefaultPolicyDelegate::DefaultPolicyDelegate): (DefaultPolicyDelegate::~DefaultPolicyDelegate): (DefaultPolicyDelegate::sharedInstance): (DefaultPolicyDelegate::createInstance): (DefaultPolicyDelegate::QueryInterface): (DefaultPolicyDelegate::AddRef): (DefaultPolicyDelegate::Release): (DefaultPolicyDelegate::decidePolicyForNavigationAction): (DefaultPolicyDelegate::decidePolicyForNewWindowAction): (DefaultPolicyDelegate::decidePolicyForMIMEType): (DefaultPolicyDelegate::unableToImplementPolicyWithError):
DefaultPolicyDelegate.h: Added.
WebFrame.cpp: (WebFrame::dispatchDecidePolicyForNavigationAction): Implemented default action
WebKit.vcproj/WebKit.vcproj: Adding files to project

LayoutTests:

removing fixed test

platform/win/Skipped:

10:20 AM Changeset in webkit [26608] by honeycutt

2 edits in trunk/WebCore

2007-10-12 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Maciej.

Return a more appropriate error from NPN_RequestRange, which is
currently unimplemented

plugins/win/npapi.cpp: return NPERR_STREAM_NOT_SEEKABLE (NPN_RequestRead):

10:15 AM Changeset in webkit [26607] by honeycutt

2 edits in trunk/WebCore

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Maciej.

Add a missing function pointer to the m_browserFuncs structure

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):

9:46 AM Changeset in webkit [26606] by kmccullo

3 edits in trunk/LayoutTests

Reviewed by Sam.

<rdar://problem/5536630> fast/dom/Window/new-window-opener.html fails
This test used to pass because of a mistake in js-test-pre.js. Now that the js file has been fixed this test has been updated, some of the test cases fail because DRT does not implement delegate methods for the bars for each WebView.
See <rdar://problem/5538752> DumpRenderTree does not have a UIDelegate for each WebView.

Also changed the test to correctly wait for the window to close before starting a new testcase. This is necessary because all the windows have the same name and cannot override the settings of a pre-existing window.

fast/dom/Window/new-window-opener-expected.txt:
fast/dom/Window/new-window-opener.html:

8:59 AM Changeset in webkit [26605] by hausmann

4 edits
6 adds in trunk/WebCore

Fix the compilation of the Font code in the Qt port by adding the necessary stubs to support downloadable fonts through the @font-face rules.

8:58 AM Changeset in webkit [26604] by hausmann

4 edits in trunk/WebCore

Adapt to the latest API changes in the SVG API/Code.

8:58 AM Changeset in webkit [26603] by hausmann

2 edits in trunk/JavaScriptCore

Fix compilation with gcc 4.3 by including 'limits' due to the use of std::numeric_limits.

3:04 AM Changeset in webkit [26602] by oliver

164 edits
76 adds
71 deletes in trunk/LayoutTests

Reset svg pixel tests to a tiger baseline and move them to platform/mac

RS=Maciej

Oct 14, 2007:

4:46 PM Changeset in webkit [26601] by darin

2 edits
17 adds in trunk/LayoutTests

added exceptions for all the tests failing on my personal Leopard machine

This may or may not get the buildbot green. I'll file separate bugs for each
of the tests with changed results.

platform/mac-leopard/dom: Added.
platform/mac-leopard/dom/xhtml: Added.
platform/mac-leopard/dom/xhtml/level2: Added.
platform/mac-leopard/dom/xhtml/level2/html: Added.
platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Added.
platform/mac-leopard/editing: Added.
platform/mac-leopard/editing/pasteboard: Added.
platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Added.
platform/mac-leopard/http: Added.
platform/mac-leopard/http/tests: Added.
platform/mac-leopard/http/tests/security: Added.
platform/mac-leopard/http/tests/security/dataURL: Added.
platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
platform/mac-leopard/svg/custom: Added.
platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Added.
platform/mac-leopard/webarchive: Added.
platform/mac-leopard/webarchive/test-xml-stylesheet-expected.txt: Added.

platform/mac-leopard/security/block-test-expected.txt: Changed results.

4:20 PM Changeset in webkit [26600] by darin

1 edit
3 copies
1 delete in trunk/LayoutTests

moved a test that somehow ended up doubly-nested in platform/mac

platform/mac/fast/text/justified-text-rect-expected.checksum: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.checksum.
platform/mac/fast/text/justified-text-rect-expected.png: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.png.
platform/mac/fast/text/justified-text-rect-expected.txt: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.txt.
platform/mac/platform: Removed.
platform/mac/platform/mac: Removed.
platform/mac/platform/mac/fast: Removed.
platform/mac/platform/mac/fast/text: Removed.
platform/mac/platform/mac/fast/text/justified-text-rect-expected.checksum: Removed.
platform/mac/platform/mac/fast/text/justified-text-rect-expected.png: Removed.
platform/mac/platform/mac/fast/text/justified-text-rect-expected.txt: Removed.

3:30 PM Changeset in webkit [26599] by oliver

13 edits
1661 adds
1634 deletes in trunk/LayoutTests

Revert "Rubberstamped by Eric."

This reverts commit 4ae99caea8eb153f9b85e86d1819b19b4af12fb4.
RS=Niko

Revert layout test move.

Filed http://bugs.webkit.org/show_bug.cgi?id=15513 to track correction for even earlier change

Conflicts:

1:15 PM Changeset in webkit [26598] by zimmermann

1 edit in trunk/LayoutTests/ChangeLog

Not reviewed. Don't list all individual files in the ChangeLog -> make Mark happy

12:09 PM Changeset in webkit [26597] by zimmermann

13 edits
1 move
5 deletes in trunk/LayoutTests

Rubberstamped by Eric.

Move current layout tests results from platform/mac/svg to platform/mac-tiger/svg.
The problem is that the current results have accidently been generated with Leopard,
I'm still moving this to mac-tiger so we don't loose the history for all the results.
After this commit, the baseline will be regenerated in mac-tiger/svg, and someone with
Leopard needs to generate new results in mac-leopard/svg.

10:51 AM Changeset in webkit [26596] by sfalken

2 edits in branches/Safari-3-branch/WebKit/win

Merged fix from r26594.

10:45 AM Changeset in webkit [26595] by zimmermann

10 edits
1 delete in trunk/WebCore

Reviewed by Eric.

Fix bad abstraction in ImageBuffer class.
While the class itself is platform-aware and thus it's location in platform/graphics
is fine, it contains the "renderSubtreeToImage" method which operates on RenderObject.

As it's SVG specific I decided to move this method into SVGRenderSupport, to avoid
implicit platform/ <-> rendering/ dependencies.

10:40 AM Changeset in webkit [26594] by sfalken

2 edits in trunk/WebKit/win

Move pthreads up in the linker order and don't mark it for delay load.
Fixes crash during regsvr32 of WebKit (currently repro if you do a spade ti).

Reviewed by Darin, Ada.

WebKit.vcproj/WebKit.vcproj:

6:27 AM BuildingQtOnLinux edited by zecke2@selfish.org

(diff)

6:02 AM Changeset in webkit [26593] by bdash

2 edits in trunk/WebKitTools

2007-10-14 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark.

Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line when querying for QMAKE_MKSPECS.

5:52 AM BuildingGtk edited by zecke2@selfish.org

(diff)

5:06 AM Changeset in webkit [26592] by andrew

2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Fix run-webkit-tests is too greedy calculating platform hierarchy
http://bugs.webkit.org/show_bug.cgi?id=15465

Fix run-webkit-tests being too greedy in trying to split the platform name up
causing it to try and find tests in every directory above the first "-" in the
path to the LayoutTests

Scripts/run-webkit-tests:

4:59 AM Changeset in webkit [26591] by bdash

2 edits in trunk/WebCore

2007-10-14 Peter Kasting <zerodpx@gmail.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15210
Draw the image outline even for broken images.

rendering/RenderImage.cpp: (WebCore::RenderImage::paint):

4:58 AM Changeset in webkit [26590] by bdash

3 edits in trunk/WebKit/gtk

2007-10-14 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=15299
Fix "hovering_over_link" signal not emitted when consecutive links
are hovered.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
WebCoreSupport/ChromeClientGtk.h:
Remove m_didSendLinkSignal as it is superseded by m_hoveredLinkURL

4:55 AM Changeset in webkit [26589] by bdash

12 edits in trunk

2007-10-14 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Adam.

Add support for MSVC7, and fix cases where PLATFORM(WIN) should
be PLATFORM(WIN_OS) for other ports building on Windows.

dom/XMLTokenizer.cpp:
page/FrameTree.cpp:
platform/StaticConstructors.h:
platform/String.cpp:

2007-10-5 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Adam.

Add support for MSVC7, and fix cases where PLATFORM(WIN) should
be PLATFORM(WIN_OS) for other ports building on Windows.

kjs/DateMath.cpp: (KJS::getDSTOffsetSimple):
kjs/JSImmediate.h:
wtf/Assertions.cpp:
wtf/Assertions.h:
wtf/Platform.h:
wtf/StringExtras.h: (snprintf): (vsnprintf):

4:49 AM Changeset in webkit [26588] by bdash

2 edits in trunk/WebCore

2007-10-14 Maxime Britto <mbritto@pleyo.com>

Reviewed by Mitz.

Fix an error in the goBackOrForward() function : confusion between forwardListCount and backListCount.
http://bugs.webkit.org/show_bug.cgi?id=15212

loader/FrameLoader.cpp: (WebCore::FrameLoader::goBackOrForward):

4:44 AM Changeset in webkit [26587] by bdash

4 edits
4 adds in trunk

2007-10-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=15181 text-transform: uppercase not working in input (submit, reset, button) elements <rdar://problem/5474647>

Test: fast/forms/button-text-transform.html

Text transformations require access to the original text. The button's inner
text was an anonymous RenderText, meaning it did not have a node to retrieve
the original text from. The patch fixes this by changing the inner text into a
RenderTextFragment, which stores its own original text.

rendering/RenderButton.cpp: (WebCore::RenderButton::setText):
rendering/RenderButton.h:

2007-10-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=15181 text-transform: uppercase not working in input (submit, reset, button) elements <rdar://problem/5474647>

fast/forms/button-text-transform.html: Added.
platform/mac/fast/forms/button-text-transform-expected.checksum: Added.
platform/mac/fast/forms/button-text-transform-expected.png: Added.
platform/mac/fast/forms/button-text-transform-expected.txt: Added.

4:42 AM Changeset in webkit [26586] by bdash

3 edits in trunk/WebKitTools

2007-10-14 Oleg Sukhodolsky <son.two@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15006
Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
to reduce code duplication.

Scripts/build-webkit:
Scripts/webkitdirs.pm: buildQMakeProject() renamed to buildQMakeQtProject(). buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory), unused $colorize has been removed.

4:39 AM Changeset in webkit [26585] by bdash

3 edits
2 adds in trunk

2007-10-14 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

REGRESSION: Javascript bug in getElementsByName
http://bugs.webkit.org/show_bug.cgi?id=15274

Test: fast/dom/getelementbyname-invalidation.html

dom/NameNodeList.h: remove empty rootNodeChildrenChanged override

2007-10-14 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Test for http://bugs.webkit.org/show_bug.cgi?id=15274
REGRESSION: Javascript bug in getElementsByName

fast/dom/getelementbyname-invalidation-expected.txt: Added.
fast/dom/getelementbyname-invalidation.html: Added.

4:35 AM Changeset in webkit [26584] by bdash

3 edits in trunk/WebCore

2007-10-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15303 Remove now-redundant code to restore dialog arguments after clear

This patch reverts the kjs_window.* parts of r25576 because following
r25783, window properties, including dialog arguments, are not cleared
when the newly created modal dialog transitions to the document.

bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::createWindow): (KJS::showModalDialog): (KJS::Window::clear): (KJS::WindowFunc::callAsFunction): (KJS::Window::setReturnValueSlot):
bindings/js/kjs_window.h:

4:33 AM Changeset in webkit [26583] by bdash

3 edits
4 adds in trunk

2007-10-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=15309 <rdar://problem/5512020> Crash due to infinite recursion in RenderTable::addChild

Test: fast/table/generated-caption.html

rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Changed to make sure that the child is not added into generated after content. Also made adding a child before a table caption work correctly instead of adding the child after the caption.

2007-10-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=15309 <rdar://problem/5512020> Crash due to infinite recursion in RenderTable::addChild

fast/table/generated-caption.html: Added.
platform/mac/fast/table/generated-caption-expected.checksum: Added.
platform/mac/fast/table/generated-caption-expected.png: Added.
platform/mac/fast/table/generated-caption-expected.txt: Added.

4:31 AM Changeset in webkit [26582] by bdash

8 edits in trunk

2007-10-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Adds NegateNode optimization from KJS. The relevant revision in KDE
is 666736.

kjs/grammar.y:
kjs/nodes.cpp: (NumberNode::evaluate):
kjs/nodes.h: (KJS::Node::): (KJS::NumberNode::):
kjs/nodes2string.cpp: (NumberNode::streamTo):

2007-10-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Adds serialization test cases for NegateNode optimization from KDE.

fast/js/function-decompilation-operators-expected.txt:
fast/js/function-decompilation-operators.html:

4:30 AM Changeset in webkit [26581] by bdash

3 edits
3 adds in trunk

2007-10-14 Jason Foreman <jason@threeve.org>

Reviewed by Maciej.

Fix http://bugs.webkit.org/show_bug.cgi?id=15145

Ensure that if adjusting n to minimize the difference of n*intPow10(e-p+1) to x,
that the property n < intPow10(p) is maintained.

kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):

2007-10-14 Jason Foreman <jason@threeve.org>

Reviewed by Maciej.

Adding test for http://bugs.webkit.org/show_bug.cgi?id=15145.

ChangeLog:
fast/js/number-toprecision-expected.txt: Added.
fast/js/number-toprecision.html: Added.
fast/js/resources/number-toprecision.js: Added.

4:28 AM Changeset in webkit [26580] by bdash

2 edits in trunk/WebCore

2007-10-14 Peter Kasting <zerodpx@gmail.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15141
Feed GIF reader data from the point in the stream it expects. Also,
mirror the reader's failure state up to the wrapping decoder.

platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):

4:27 AM Changeset in webkit [26579] by bdash

2 edits in trunk/WebCore

2007-10-14 Peter Kasting <zerodpx@gmail.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15142
Return correct frame count in GIFImageDecoder::frameBufferAtIndex(),
even if more data has arrived since the last decoding pass.