Context Navigation

← Previous Period
Next Period →

Timeline

Oct 16, 2007:

10:38 PM Changeset in webkit [26697] by darin

22 edits
1 move
8 deletes in trunk/JavaScriptCore

Reviewed by Geoff.

merged PCRE changes between 6.4 and 6.5

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj: Removed pcre_config.c, pcre_globals.c, pcre_info.c, pcre_maketables.c, pcre_printint.src, pcre_refcount.c, pcre_study.c, pcre_try_flipped.c, pcre_ucp_findchar.c, pcre_version.c, and ucptable.c. Added pcre_ucp_searchfuncs.c.

pcre/AUTHORS:
pcre/LICENCE:
pcre/MERGING:
pcre/dftables.c:
pcre/pcre-config.h:
pcre/pcre.h:
pcre/pcre.pri:
pcre/pcre_compile.c:
pcre/pcre_exec.c:
pcre/pcre_fullinfo.c:
pcre/pcre_get.c:
pcre/pcre_internal.h:
pcre/pcre_maketables.c:
pcre/pcre_ord2utf8.c:
pcre/pcre_tables.c:
pcre/pcre_ucp_searchfuncs.c: Copied from pcre/pcre_ucp_findchar.c.
pcre/pcre_xclass.c:
pcre/ucp.h:
pcre/ucpinternal.h:
pcre/ucptable.c: Updated with new versions from the PCRE 6.5 release, merged with changes.

pcre/pcre_config.c: Removed.
pcre/pcre_globals.c: Removed.
pcre/pcre_info.c: Removed.
pcre/pcre_printint.src: Removed.
pcre/pcre_refcount.c: Removed.
pcre/pcre_study.c: Removed.
pcre/pcre_try_flipped.c: Removed.
pcre/pcre_ucp_findchar.c: Removed.
pcre/pcre_version.c: Removed.

9:51 PM Changeset in webkit [26696] by darin

5 edits in trunk/WebCore

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=15536 need to cache missing glyph so we're not slow on pages that show missing glyphs

<rdar://problem/5404359> UI thread stall (>60sec) in MLANG running stress test (related to font data caching)

platform/Font.cpp: (WebCore::Font::glyphDataForCharacter): Check for a null value for fontData rather than for glyph to detect non-cached entries in the glyph data.

platform/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
platform/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
platform/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill): Set fontData to 0 for missing glyph entries. Also fixed the Windows and GTK versions to return the proper value for haveGlyphs.

8:47 PM Changeset in webkit [26695] by bdash

3 edits in trunk/WebCore

2007-10-16 Mark Rowe <mrowe@apple.com>

Gtk build fix. Replace use of assert with ASSERT_NOT_REACHED.

platform/gtk/FontCacheGtk.cpp: (WebCore::FontCache::platformInit):

7:02 PM Changeset in webkit [26694] by ddkilzer

2 edits in trunk/WebKit

WebCore:

Reviewed by Timothy.

<rdar://problem/5544354> Wrong delegate method called in WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.

5:57 PM Changeset in webkit [26693] by kmccullo

5 edits in trunk/WebKitTools

Reviewed by Sam.

Minor mac improvements based on observations I made while implementing the Windows code.

Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server then hand it to the Client who will retain it, it should just be the client who creates and owns the server. (-[DebuggerApplication attach:]):
Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
Drosera/mac/DebuggerClient.mm: Creates the server. (-[DebuggerClient initWithServerName:]):
Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but can instead forward declare what it needs.

5:36 PM Changeset in webkit [26692] by aliceli1

2 edits in trunk/LayoutTests

removing fixed tests

platform/win/Skipped:

4:52 PM Changeset in webkit [26691] by darin

2 edits in trunk/WebCore

Reviewed by Adam.

fix http://bugs.webkit.org/show_bug.cgi?id=15534 WebScriptObject.h has some formatting and editorial mistakes

bindings/objc/WebScriptObject.h: Fix wording and formatting.

4:35 PM Changeset in webkit [26690] by ggaren

5 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Removed KJS_VERBOSE because it was getting in the way of readability,
and the messages didn't seem very helpful.

kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters):
kjs/lookup.h: (KJS::lookupPut):
kjs/object.cpp: (KJS::JSObject::put):
kjs/value.h:

4:29 PM Changeset in webkit [26689] by ggaren

4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Removed the Parameter class because it was a redundant wrapper around
Identifier.

kjs/function.cpp: (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::getParameterName):
kjs/nodes.cpp: (FunctionBodyNode::addParam):
kjs/nodes.h: (KJS::FunctionBodyNode::):

4:25 PM Changeset in webkit [26688] by ggaren

34 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Global replace of assert with ASSERT.

3:34 PM Changeset in webkit [26687] by aliceli1

6 edits in trunk/LayoutTests

Rubber-stamped by Adele.

fixing incorrect usage of JS String search method.

editing/deleting/delete-by-word-001.html:
editing/deleting/delete-by-word-002.html:
fast/forms/input-text-option-delete.html:
fast/forms/listbox-onchange.html:
fast/forms/listbox-selection.html:

3:02 PM Changeset in webkit [26686] by darin

2 edits in trunk/WebCore

try to fix the Qt build

config.h: Don't use DisallowCType.h, since it's incompatible with some C++ headers that are used in some Qt-specific source files.

2:53 PM Changeset in webkit [26685] by darin

2 edits in trunk/WebKitTools

Reviewed by Geoff Garen.

Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you want to turn failing tests into platform-specific test results. Also did a number of tweaks, including fixing a potential bug where expectedDirectoryForTest would take the type of results into account only some of the time.

2:43 PM Changeset in webkit [26684] by aroben

18 edits in trunk

Rename WebKit_debug.dll to WebKit.dll for the Debug configuration

JavaScriptCore:

Updated testkjs for the rename of WebKit_debug.dll to WebKit.dll for the Debug configuration

Reviewed by Kevin McCullough.

JavaScriptCore.vcproj/debug.vsprops: Added WebKitDLLConfigSuffix.
JavaScriptCore.vcproj/debug_internal.vsprops: Ditto.
JavaScriptCore.vcproj/release.vsprops: Ditto.
JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Use WebKitDLLConfigSuffix when referring to WebKit.dll, and fixed a typo in the name of icuuc36[_debug].dll.

WebKitTools:

Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration

Reviewed by Kevin McCullough.

DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix when referring to WebKit.dll.
DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
DumpRenderTree/win/debug_internal.vsprops: Ditto.
DumpRenderTree/win/release.vsprops: Ditto.
Scripts/run-safari: Don't pass /debug to Safari anymore because we never have a _debug suffix on WebKit.dll.
WebKitInitializer/WebKitInitializer.cpp: (initializeWebKit): Only use the _debug suffix for WebKit.dll when specified.
WebKitInitializer/debug_internal.vsprops: Added DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.

WebKit/win:

Rename WebKit_debug.dll to WebKit.dll for the Debug configuration

This is needed so that we can stop having Safari delay-load WebKit,
which in turn is needed so that Maciej can land a JavaScript speedup
which breaks delay-loading.

Reviewed by Kevin McCullough.

WebKit.vcproj/WebKit.vcproj: Use WebKitDLLConfigSuffix for the name of our DLL and module definition file.
WebKit.vcproj/debug.vsprops: Added WebKitDLLConfigSuffix.
WebKit.vcproj/debug_internal.vsprops: Ditto.
WebKit.vcproj/release.vsprops: Ditto.

2:40 PM Changeset in webkit [26683] by darin

13 edits
2 deletes in trunk

WebCore:

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=15525 transpose (control-T) should do the last two characters on a line if at end of line
remove unused CommandByName class
move transpose command implementation here from Mac OS X WebKit

editing/Editor.h:
editing/Editor.cpp: (WebCore::execTranspose): Added. (WebCore::Editor::transpose): Added. This has the transpose implementation from WebCoreFrameBridge and WebHTMLView, translated into WebCore-style C++ and with a special case for the end of a paragraph.

page/Frame.h: Removed unused command() function member.
page/FramePrivate.h: Removed unused m_command data member.
page/Frame.cpp: Ditto.

page/mac/WebCoreFrameBridge.h: Removed rangeOfCharactersAroundCaret method.
page/mac/WebCoreFrameBridge.mm: Ditto.

WebCore.pro: Removed CommandByName.h/cpp.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

editing/CommandByName.cpp: Removed.
editing/CommandByName.h: Removed.

WebKit:

Reviewed by Adele.

moved transpose command implementation into WebCore

WebView/WebHTMLView.mm: Removed transpose: and replaced it with standard WebCore forwarding.

2:35 PM Changeset in webkit [26682] by ggaren

8 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Re-structured variable and function declaration code.

Command-line JS iBench shows no regression.

Here are the changes:

Function declarations are now processed at the same time as var declarations -- namely, immediately upon entry to an execution context. This does not match Firefox, which waits to process a function declaration until the declaration's containing block executes, but it does match IE and the ECMA spec. (10.1.3 states that var and function declarations should be processed at the same time -- namely, "On entering an execution context." 12.2 states that "A Block does not define a new execution scope.")

Declaration processing proceeds iteratively now, rather than recursively, storing the nodes is finds in stacks. This will later facilitate an optimization to hold on to the gathered declaration nodes, rather than re-fetching them in every function call. [ http://bugs.webkit.org/show_bug.cgi?id=14868 ]

Modified these tests because they expected the incorrect Mozilla
behavior described above:

tests/mozilla/ecma_3/Function/scope-001.js:
tests/mozilla/js1_5/Scope/regress-184107.js:

LayoutTests:

Reviewed by Maciej Stachowiak.

Layout tests for http://bugs.webkit.org/show_bug.cgi?id=15478
Declare vars and functions iteratively upon entering an execution context

fast/js/function-declarations-expected.txt: Added.
fast/js/function-declarations.html: Added.
fast/js/var-declarations-expected.txt: Added.
fast/js/var-declarations.html: Added.

2:18 PM Changeset in webkit [26681] by aliceli1

3 edits in trunk/LayoutTests

Reviewed by Adele.

Fix <rdar://5134108> "fast/forms/select-accesskey.html and focus-selection-input.html fail on Windows"

Adding code to choose the right accesskey modifier based on a useragent check for existance of mac platform.

fast/forms/focus-selection-input.html:
fast/forms/select-accesskey.html:

1:53 PM Changeset in webkit [26680] by darin

2 edits in trunk/JavaScriptCore

try to fix the GTK build

kjs/ustring.cpp: Include ASCIICType.h, not ASCIICtype.h.

1:44 PM Changeset in webkit [26679] by darin

2 edits in trunk/JavaScriptCore

try to fix the Windows build

kjs/date_object.cpp: (KJS::parseDate): A couple instances of isspace were in here. Not sure why it wasn't failing elsewhere. Changed to isASCIISpace.

1:34 PM Changeset in webkit [26678] by darin

2 edits in trunk/JavaScriptCore

try to fix the GTK build

kjs/ustring.cpp: Include ASCIICType.h.

1:28 PM Changeset in webkit [26677] by darin

9 edits in trunk

WebKitTools:

Reviewed by Adele.

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Remove now-unneeded control/alt key hack; the tests have been updated.

LayoutTests:

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=15533 some tests have hard-coded Mac-specific modifier keys

<rdar://problem/5102974> Layout tests fail on Windows because they have hard-coded Mac-specific modifier keys
<rdar://problem/5075449> fast/forms/listbox-onchange.html is failing on Windows due to modifier key differences
<rdar://problem/5134134> test 12 in fast/forms/listbox-selection.html fails on Windows

editing/deleting/delete-by-word-001.html: Use control key instead of alt key to delete a word on non-Mac platforms. Also use character 8 instead of 127.
editing/deleting/delete-by-word-002.html: Ditto.
fast/forms/input-text-option-delete.html: Ditto.
fast/forms/listbox-onchange.html: Use control key instead of meta key to toggle a single list item on non-Mac platforms.
fast/forms/listbox-selection.html: Ditto.

1:13 PM Changeset in webkit [26676] by darin

31 edits
6 adds in trunk

JavaScriptCore:

Reviewed by Maciej and Geoff (and looked over by Eric).

http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII

wtf/ASCIICType.h: Added.
wtf/DisallowCType.h: Added.

kjs/config.h: Include DisallowCType.h.

kjs/date_object.cpp: (KJS::skipSpacesAndComments): (KJS::findMonth): (KJS::parseDate):
kjs/function.cpp: (KJS::decode):
kjs/ustring.cpp: (KJS::UString::toDouble): Use ASCIICType.h functions instead of ctype.h ones.

WebCore:

Reviewed by Maciej and Geoff (and looked over by Eric).

http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII

ForwardingHeaders/wtf/ASCIICType.h: Added.
ForwardingHeaders/wtf/DisallowCType.h: Added.

WebCorePrefix.h: Get rid of inclusion of <ctype.h>.
config.h: Include DisallowCType.h.

css/CSSParser.cpp: (WebCore::ParseString::lower):
css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier):
css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
html/HTMLTokenizer.cpp: (WebCore::tagMatch):
loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
platform/DeprecatedCString.cpp: (WebCore::DeprecatedCString::lower): (WebCore::DeprecatedCString::upper): (WebCore::DeprecatedCString::find): (WebCore::DeprecatedCString::contains):
platform/DeprecatedString.cpp: (WebCore::equalCaseInsensitive): (WebCore::isCharacterAllowedInBase): (WebCore::DeprecatedString::find): (WebCore::DeprecatedString::contains): (WebCore::toIntegralType):
platform/DeprecatedString.h: (WebCore::DeprecatedChar::isSpace): (WebCore::DeprecatedChar::lower): (WebCore::DeprecatedChar::upper):
platform/KURL.cpp: (WebCore::KURL::parse):
platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::StringImpl::containsOnlyWhitespace): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::find): (WebCore::StringImpl::reverseFind): (WebCore::equalIgnoringCase):
platform/TextEncodingRegistry.cpp: (WebCore::TextEncodingNameHash::equal): (WebCore::TextEncodingNameHash::hash): (WebCore::atomicCanonicalTextEncodingName):
platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode):
platform/win/PopupMenuWin.cpp: (WebCore::isASCIIPrintable): (WebCore::PopupWndProc):
plugins/win/PluginViewWin.cpp: (WebCore::capitalizeRFC822HeaderFieldName):
rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): Use ASCIICType.h functions instead of ctype.h ones.

WebKit:

Reviewed by Maciej and Geoff (and looked over by Eric).

http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII

ForwardingHeaders/wtf/ASCIICType.h: Added.
ForwardingHeaders/wtf/DisallowCType.h: Added.

WebKitPrefix.h: Include DisallowCType.h.

Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
WebView/WebHTMLView.mm: (-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper. (-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes, instead of using ispunct.

1:05 PM Changeset in webkit [26675] by hyatt

1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Fix build bustage caused by merge with changes to CSSStyleSelector.cpp

1:04 PM Changeset in webkit [26674] by mitz

3 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=15296 REGRESSION (r19716-r19719): width not specified for <marquee> tag is causing the alignment issue.

Test: fast/block/float/marquee-shrink-to-avoid-floats.html

rendering/RenderObject.cpp: (WebCore::RenderObject::shrinkToAvoidFloats): Changed to return 'true' for <marquee>s with auto width.

LayoutTests:

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=15296 REGRESSION (r19716-r19719): width not specified for <marquee> tag is causing the alignment issue.

fast/block/float/marquee-shrink-to-avoid-floats.html: Added.
platform/mac/fast/block: Added.
platform/mac/fast/block/float: Added.
platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.checksum: Added.
platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.png: Added.
platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt: Added.

12:51 PM Changeset in webkit [26673] by bdakin

4 edits
4 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5517118> REGRESSION: 9A570 - Safari renders
Amazon seller page way too small

The font size at Amazon was way too small because the calls to
getComputedStyle and getPropertyValue did not cause the div to
attach because there was a pending stylesheet. The fix is to call
updateLayoutIgnorePendingStylesheets() instead of just
updateLayout().

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Reviewed by Darin.

Fix for <rdar://problem/5517118> REGRESSION: 9A570 - Safari renders
Amazon seller page way too small

fast/css/pendingStylesheetFontSize.html: Added.
platform/mac/fast/css/pendingStylesheetFontSize-expected.checksum: Added.
platform/mac/fast/css/pendingStylesheetFontSize-expected.png: Added.
platform/mac/fast/css/pendingStylesheetFontSize-expected.txt: Added.

12:48 PM Changeset in webkit [26672] by sfalken

2 edits in branches/Safari-3-branch/WebKit/win

Merged fix from r26667.

12:48 PM Changeset in webkit [26671] by kmccullo

2 edits in trunk/WebKitTools

Updated leaks list because our internal bot upgraded it's version of leopard and one of the leaks was fixed between that revision and the bot's previous version of leopard.

Scripts/run-webkit-tests:

12:46 PM Changeset in webkit [26670] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26664.

12:46 PM Changeset in webkit [26669] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26662.

12:45 PM Changeset in webkit [26668] by kmccullo

9 edits
2 adds
1 delete in trunk/WebKitTools

Reviewed by Tim.

I encapsulated out the server connecton functionality because it is a specific part of Drosera that will be platform dependant until the WebScriptDebugServer can be moved into WebCore and C++. But if it is encapsulated out it can be easily replaced on Windows. So the majority of this patch is moving preexisting functionality.

Also I removed the prefix header and changed to use config.h because it is more standard on how we use config.h in windows and it didn't make much sense to keep the prefix header and the config.h

Drosera/DebuggerDocument.cpp: (DebuggerDocument::DebuggerDocument):
Drosera/DebuggerDocument.h:
Drosera/config.h:
Drosera/mac/DebuggerApplication.mm: (-[DebuggerApplication attach:]):
Drosera/mac/DebuggerClient.h:
Drosera/mac/DebuggerClient.mm: (-[DebuggerClient initWithServerConnection:]): (-[DebuggerClient dealloc]): (-[DebuggerClient windowDidLoad]): (-[DebuggerClient windowWillClose:]): (-[DebuggerClient webView:didFinishLoadForFrame:]): (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
Drosera/mac/DebuggerDocumentPlatform.mm: (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
Drosera/mac/Drosera.pch: Removed.
Drosera/mac/Drosera.xcodeproj/project.pbxproj:
Drosera/mac/ServerConnection.h: Added.
Drosera/mac/ServerConnection.mm: Added. (-[ServerConnection initWithServerName:]): (-[ServerConnection dealloc]): (-[ServerConnection setGlobalContext:]): (-[ServerConnection pause]): (-[ServerConnection resume]): (-[ServerConnection stepInto]): (-[ServerConnection switchToServerNamed:]): (-[ServerConnection applicationTerminating:]): (-[ServerConnection serverConnectionDidDie:]): (-[ServerConnection webView:didLoadMainResourceForDataSource:]): (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]): (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]): (-[ServerConnection currentFrame]): (-[ServerConnection webScriptAttributeKeysForScriptObject:]): (-[ServerConnection knownServers]):

12:36 PM Changeset in webkit [26667] by honeycutt

2 edits in trunk/WebKit/win

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

<rdar://5530789>: REGRESSION(303-310A19): Crash opening .wma files with
MediaPlayer for the first time

Failure to setup the stream in PluginView::didReceiveResponse will lead,
in a full-page plugin, to the main document load being cancelled. This
is the case with at least two versions of Windows Media Player, which
cancels the stream and brings up its own "Welcome to Windows Media
Player" dialog.

As part of the main document load cancellation, m_pluginView is set to
null, and the crash came from dereferencing this pointer. This patch
adds a null check.

WebFrame.cpp: (WebFrame::finishedLoading): Fix some typos (WebFrame::committedLoad): Added a null check

12:06 PM Changeset in webkit [26666] by hyatt

4 edits in trunk/WebCore

Get transform-origin(x/y) mapped into the front end RenderStyle. Adds a new StyleTransformData struct that
holds transform-origin (and that will also eventually hold the parsed transform operations as well).

Reviewed by Beth

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
rendering/RenderStyle.cpp: (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleTransformData::operator==): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff):
rendering/RenderStyle.h: (WebCore::StyleTransformData::operator!=): (WebCore::RenderStyle::transformOriginX): (WebCore::RenderStyle::transformOriginY): (WebCore::RenderStyle::setTransformOriginX): (WebCore::RenderStyle::setTransformOriginY): (WebCore::RenderStyle::initialTransformOriginX): (WebCore::RenderStyle::initialTransformOriginY):

11:30 AM Changeset in webkit [26665] by adele

4 edits in trunk

WebCore:

Reviewed by Alice.

Fix for <rdar://problem/5538793> REGRESSION: Failing layout test: fast/forms/select-change-listbox-to-popup.html (due to landing feature branch)

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): When switching between types of select elements, call setRecalcListItems since recalcListItems updates the default selection in different ways for the different controls.

LayoutTests:

Reviewed by Alice.

Updating with correct results for:
<rdar://problem/5538793> REGRESSION: Failing layout test: fast/forms/select-change-listbox-to-popup.html (due to landing feature branch)

platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:

11:22 AM Changeset in webkit [26664] by aliceli1

2 edits in trunk/WebCore

rubber-stamped by Darin.

flipping my previous fix around so that mac is special-cased instead of win.

dom/Document.cpp: (WebCore::Document::defaultEventHandler):

11:21 AM Changeset in webkit [26663] by hyatt

3 edits in trunk/WebCore

Clean up transform parsing. Fix a crash, ditch the extra parse context class, and use RefPtr/PassRefPtr more
to simplify the code.

Reviewed by aroben

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseTransform):
css/CSSParser.h:

10:57 AM Changeset in webkit [26662] by aliceli1

2 edits in trunk/WebCore

Reviewed by Adele.

fixed <rdar://5085596> Accesskeys don't work

dom/Document.cpp: (WebCore::Document::defaultEventHandler): accesskey modifier is platform-depedent.

9:55 AM Changeset in webkit [26661] by sullivan

4 edits in trunk/WebKit

Reviewed by Adam Roben

Cleaned up localizable strings

English.lproj/Localizable.strings: updated
StringsNotToBeLocalized.txt: updated
WebKit.xcodeproj/project.pbxproj: StringsNotToBeLocalized.txt recently moved but project file wasn't updated to match; now it is

9:00 AM Changeset in webkit [26660] by bdash

1 copy in tags/WebCore-419.2.5-dashboard/WebCore

New tag (part 2).

8:59 AM Changeset in webkit [26659] by bdash

1 add in tags/WebCore-419.2.5-dashboard

New tag (part 1).

8:57 AM Changeset in webkit [26658] by bdash

2 edits in branches/Safari-2.0-dashboard/WebCore

Versioning

8:57 AM Changeset in webkit [26657] by bdash

3 edits in branches/Safari-2.0-dashboard/WebCore

2007-10-16 Mark Rowe <mrowe@apple.com>

Reinstate equalIgnoringCase that was added as part of r25691 but subsequently rolled out.
Other merged changes depend on it existing.

4:19 AM Changeset in webkit [26656] by ddkilzer

1 edit in trunk/WebKit/ChangeLog-2007-10-14

Removed conflict markers.

12:34 AM Changeset in webkit [26655] by sfalken

3 edits in branches/Safari-3-branch/WebCore

Merged fix from r26651.

12:04 AM Changeset in webkit [26654] by ap

2 edits
1 move
2 deletes in trunk/LayoutTests

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15506
editing/pasteboard/paste-into-anchor-text.html accesses an external resource

Removed the external resource reference and made the test dump as text.

editing/pasteboard/paste-into-anchor-text-expected.txt: Copied from platform/mac/editing/pasteboard/paste-into-anchor-text-expected.txt.
editing/pasteboard/paste-into-anchor-text.html:
platform/mac/editing/pasteboard/paste-into-anchor-text-expected.checksum: Removed.
platform/mac/editing/pasteboard/paste-into-anchor-text-expected.png: Removed.
platform/mac/editing/pasteboard/paste-into-anchor-text-expected.txt: Removed.

Oct 15, 2007:

10:53 PM Changeset in webkit [26653] by ddkilzer

1 edit
1 add in trunk/WebKitTools

WebKitTools:

Reviewed by Eric.

fix http://bugs.webkit.org/show_bug.cgi?id=15002 Script to automatically search nightly builds for regressions (bisect-builds)

Scripts/bisect-builds: Added.

10:17 PM Changeset in webkit [26652] by bdash

2 edits in trunk/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Reviewed by John.

<rdar://problem/5494040> Reproducible assertion failure in WebCore::IconDatabase::iconForPageURL

A race condition between icon database import and Safari asking for an icon for the empty URL
was resulting in a PageURLRecord being created for a URL that can never be retained. By enforcing
that PageURLRecord's cannot be created for the empty URL we can prevent the assertion from failing.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::getOrCreatePageURLRecord): Bail out early if the URL is empty. (WebCore::IconDatabase::performURLImport): Don't create the PageURLRecord if the URL is empty.

9:51 PM Changeset in webkit [26651] by honeycutt

3 edits in trunk/WebCore

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

Use OwnPtr for m_deliveryData, and fix a bug where we were memmove()ing
over m_deliveryData instead of its data buffer

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::~PluginStreamWin): Don't delete m_deliveryData (WebCore::PluginStreamWin::deliverData): Fix memmove() call (WebCore::PluginStreamWin::didReceiveData): Assign using OwnPtr::set()
plugins/win/PluginStreamWin.h: Use OwnPtr

9:14 PM Changeset in webkit [26650] by bdash

4 edits in branches/Safari-3-branch

Versioning.

9:11 PM Changeset in webkit [26649] by bdash

1 copy in tags/Safari-4523.12

New tag.

8:42 PM Changeset in webkit [26648] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26646.

8:39 PM Changeset in webkit [26647] by bdash

2 edits in branches/Safari-3-branch/WebKit

Merge r26645.

8:39 PM Changeset in webkit [26646] by sfalken

2 edits in trunk/WebCore

Reviewed by Oliver.

Add missing null check.

platform/network/cf/AuthenticationCF.cpp: (WebCore::core):

8:30 PM Changeset in webkit [26645] by kdecker

2 edits in trunk/WebKit

Reviewed by Darin Adler.

Fixed: <rdar://problem/5520541> REGRESSION: Broken image when forwarding certain email on Tiger

WebCoreSupport/WebFrameBridge.mm: The problem was that we were loading Mail's WebKit plug-in too soon, which borked some necessary housekeeping on behalf of Mail. The fix is to add a quirk that treats Tiger Mail's WebKit plug-in like a Netscape plug-in, thus ensuring the plug-in will load during first layout and not attach time. For this plug-in, loading at first layout is expected and is consistent with Safari 2 behavior.

7:34 PM Changeset in webkit [26644] by bdash

3 edits in trunk/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Fix the no-SVG build again. Add new transform CSS properties to the switch statements.

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

6:53 PM Changeset in webkit [26643] by bdash

1 copy in tags/WebCore-419.2.3-dashboard/WebCore

New tag (part 2).

6:53 PM Changeset in webkit [26642] by bdash

1 add in tags/WebCore-419.2.3-dashboard

New tag (part 1).

6:51 PM Changeset in webkit [26641] by bdash

2 edits in branches/Safari-2.0-dashboard/WebCore

Versioning.

6:49 PM Changeset in webkit [26640] by bdash

8 edits in branches/Safari-2.0-dashboard/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Roll out r25691, the merge of r24938 and r24946.

6:30 PM Changeset in webkit [26639] by mjs

3 edits
21 adds in trunk

JavaScriptCore:

Reviewed by Darin.

fixes for "New JavaScript benchmark" http://bugs.webkit.org/show_bug.cgi?id=15515

kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): Implement "load" for compatibility with SpiderMonkey. (TestFunctionImp::): ditto (doIt): ditto (kjsmain): Drop useless --> from output.

SunSpider:

Reviewed by Darin.

New JavaScript benchmark http://bugs.webkit.org/show_bug.cgi?id=15515

A start on a new JavaScript benchmark, with standalone and
browser-hosted drivers.

The test content is still incomplete and the drivers could use
some more features but there is enough here to make a good start.

The drivers compute a 95% confidence interval on the mean for the
whole test, each category, and each individual test to make it
easier to tell whether differences are statistically
significant. The confidence interval can be narrowed by running
the test more times.

TODO: Added. Remaining things that need to be done.
sunspider: Added. Perl script that acts as the standalone test driver.
resources/sunspider-standalone-driver.js: Added. JavaScript part of standalone test driver.
resources/sunspider-analyze-results.js: Added. JavaScript statistical analysis code.
resources/TEMPLATE.html: Added. Template for browser-hosted tests.
make-hosted: Added. Script to generate browser-hosted tests.
hosted/sunspider.html: Added. Start page for browser-hosted test.
hosted/sunspider-driver.html: Added. Driver for browser-hosted tests.
hosted/sunspider-results.html: Added. Results page for browser-hosted tests.
hosted/sunspider-record-result.js: Added. Helper file for browser-hosted tests.
tests/LIST: Added. List of tests to use.
tests/bitops-3bit-bits-in-byte.js: Added. Some initial test content.
tests/bitops-bits-in-byte.js: Added. Ditto.
tests/bitops-bitwise-and.js: Added. Ditto.
tests/math-cordic.js: Added. Ditto.

WebKitTools:

Reviewed by Darin.

New JavaScript benchmark http://bugs.webkit.org/show_bug.cgi?id=15515

Scripts/run-sunspider: Added. Wrapper to run sunspider on the current development or release build of JavaScriptCore.

4:54 PM Changeset in webkit [26638] by darin

4 edits in trunk/WebCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15518 Remove the unused attemptFontSubstitution feature and do some cleanup of glyphDataForCharacter.

platform/Font.h:
platform/Font.cpp: (WebCore::WidthIterator::advance): Eliminated uneeded attemptFontSubstitution and cluster parameters to the glyphDataForCharacter function. (WebCore::Font::glyphDataForCharacter): Removed the cluster parameter and attemptFontSubstitution parameter. Removed the isUpper check before calling toUpper in the small caps code path. Split up the inner loop into separate copies for non-small-caps and small caps. Broke out the system fallback page handling so it's not inside the loop. Changed system fallback so it uses the character and breaks it up into UTF-16 as needed, instead of using a passed-in "character cluster".

platform/TextStyle.h: (WebCore::TextStyle::TextStyle): Removed attemptFontSubstitution. (WebCore::TextStyle::applyWordRounding): Ditto.

4:52 PM Changeset in webkit [26637] by ggaren

6 edits in trunk/LayoutTests

Fixed layout test for reals. Changed \r\n to \n, fixing mass confusion.

fast/js/do-while-expression-value-expected.txt:
fast/js/do-while-expression-value.html:
fast/js/nested-function-scope.html:
fast/js/while-expression-value-expected.txt:
fast/js/while-expression-value.html:

4:18 PM Changeset in webkit [26636] by honeycutt

2 edits in trunk/WebCore

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

Remove an operator precedence warning on Windows

editing/markup.cpp: (WebCore::escapeContentText): Use (a) | (b) (WebCore::appendEscapedContent): Use (a) | (b)

3:59 PM Changeset in webkit [26635] by kmccullo

5 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5238818> window.resizeTo doesn't restrict the resized window to the size of the screen
Now we take the doc into account when resizing.
Also I found an issue where we would resize to outside the window, because the resize would be smaller than the window size but the location of the window would make the resize go off-screen. Now we move the window back into the screen.

bindings/js/kjs_window.cpp: (KJS::adjustWindowRect): (KJS::WindowFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5238818> window.resizeTo doesn't restrict the resized window to the size of the screen
Now we take the dock into account when resizing.
Also I found an issue where we would resize to outside the window, because the resize would be smaller than the window size but the location of the window would make the resize go off-screen. Now we move the window back into the screen.

fast/dom/Window/window-resize-expected.txt:
fast/dom/Window/window-resize.html:

3:36 PM Changeset in webkit [26634] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26632.

3:34 PM Changeset in webkit [26633] by bdash

2 edits in trunk/WebKitTools

2007-10-15 Mark Rowe <mrowe@apple.com>

Reviewed by Sam.

Fix 'run-webkit-tests --qt' complaining about the --qt argument.

Scripts/webkitdirs.pm:
Change checkArgv to remove the options from @ARGV to prevent them from interfering with further option processing.
Fix logic error in determineIsQt that would prevent it from bailing out early.
Change isOSX to mean OS X and not Qt or Gtk. Most of our uses of isOSX assume that this is the meaning already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.

3:27 PM Changeset in webkit [26632] by honeycutt

2 edits in trunk/WebCore

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5510700> Repro crash loading embedded Windows Media Player
content

Anders noticed that the older Windows Media Player plugin (npdsplay.dll)
will crash if it receives its resource requests out of order, whereas we
were immediately fulfilling untargeted, non-JavaScript requests and
scheduling targeted or JavaScript resource requests. Implement his
suggested fix, which is to schedule PluginRequests for all resource
requests

plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): If this non-JavaScript request has no target, create a stream for it (WebCore::PluginViewWin::load): Schedule PluginRequests for all resource requests

3:12 PM Changeset in webkit [26631] by bdash

2 edits in trunk/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Gtk and Qt build fix. Add new .cpp file to project.

WebCore.pro:

2:59 PM Changeset in webkit [26630] by sullivan

2 edits in trunk/WebCore

platform/mac/FontDataMac.mm: D'oh! Added missing #import to fix build

2:42 PM Changeset in webkit [26629] by sullivan

4 edits in trunk/WebKit

Reviewed by Geoff Garen

Replaced NS_DURING/NS_HANDLER with @try/@catch throughout WebKit

I made the following changes:

replaced NS_DURING with @try, and added opening brace if there wasn't one
replaced NS_HANDLER with @catch (NSException *localException), and added braces if there weren't any
removed NS_ENDHANDLER, and added a closing brace if there wasn't one
in a couple of places, fixed indentation therein

Misc/WebIconDatabase.mm: (objectFromPathForKey):
WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]): (-[WebHTMLView beginDocument]): (-[WebHTMLView deleteToMark:]):
WebView/WebView.mm: (-[WebView initWithCoder:]):

2:41 PM Changeset in webkit [26628] by sullivan

2 edits in trunk/WebCore

Reviewed by Geoff

platform/mac/FontDataMac.mm: (WebCore::FontData::smallCapsFontData): replace NS_DURING/NS_HANDLER with WebCore-style BEGIN/END_BLOCK_OBJC_EXCEPTIONS

2:25 PM Changeset in webkit [26627] by ggaren

2 edits in trunk/LayoutTests

Changed line ending style of results file to fix layout test that was
failing locally on my machine.

fast/js/nested-function-scope-expected.txt:

2:15 PM Changeset in webkit [26626] by hyatt

7 edits
2 adds in trunk/WebCore

The CSS WG has been discussing the concept of rotation. In the latest draft specification, two properties
have been introduced: rotation and rotation-point. I believe these properties should be generalized to
allow for arbitrary transformations (e.g., translation, skew, rotate, scale).

This patch adds support for the back-end parsing of two new CSS properties: transform and transform-origin.
They are directly analogous to the properties specified by the CSS WG, except that they are designed to allow
for arbitrary affine transforms rather than just rotation.

Reviewed by Beth Dakin

WebCore.xcodeproj/project.pbxproj:
WebCore.vcproj/WebCore.vcproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::TransformParseContext:::m_list): (WebCore::TransformParseContext::list): (WebCore::TransformParseContext::failed): (WebCore::TransformParseContext::addValue): (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::TransformOperationInfo::type): (WebCore::TransformOperationInfo::argCount): (WebCore::TransformOperationInfo::unit): (WebCore::TransformOperationInfo::unknown): (WebCore::TransformOperationInfo::hasCorrectArgCount): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin):
css/CSSParser.h:
css/CSSPropertyNames.in:
css/CSSTransformValue.cpp: Added. (WebCore::CSSTransformValue::CSSTransformValue): (WebCore::CSSTransformValue::~CSSTransformValue): (WebCore::CSSTransformValue::addValue): (WebCore::CSSTransformValue::cssText):
css/CSSTransformValue.h: Added. (WebCore::CSSTransformValue::):

1:58 PM Changeset in webkit [26625] by ggaren

2 edits in trunk/JavaScriptCore

Removed unnecessary #include.

API/JSObjectRef.cpp:

1:57 PM Changeset in webkit [26624] by ggaren

2 edits in trunk/JavaScriptCore

Double-reverse build fix. My tree was out of date.

kjs/nodes.cpp: (NumberNode::evaluate):

1:53 PM Changeset in webkit [26623] by bdash

3 edits in trunk/WebCore

2007-10-15 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

Fix the no-SVG build.

DerivedSources.make: Use the correct file as input to generate CSSPropertyNames.h.
rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary):

1:47 PM Changeset in webkit [26622] by ggaren

2 edits in trunk/JavaScriptCore

Build fix.

kjs/nodes.cpp: (NumberNode::evaluate):

1:44 PM Changeset in webkit [26621] by ggaren

5 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

Removed surprising self-named "hack" that made nested functions
available as named properties of their containing functions, and placed
containing function objects in the scope chains of nested functions.

There were a few reasons to remove this "hack:"

It contradicted FF, IE, and the ECMA spec.

It incurred a performance penalty, since merely parsing a function required parsing its body for nested functions (and so on).

SVN history contains no explanation for why it was added. It was just legacy code in a large merge a long, long time ago.

[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

kjs/nodes.cpp: (FuncDeclNode::processFuncDecl):

LayoutTests:

Reviewed by Darin Adler.

Removed surprising self-named "hack" that made nested functions
available as named properties of their containing functions, and placed
containing function objects in the scope chains of nested functions.

[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

Changed this test to reflect correct behavior:

fast/js/kde/function-expected.txt:
fast/js/kde/resources/function.js: (Also removed tab characters.)

Added this test to flesh out the behavior more:

fast/js/nested-function-scope-expected.txt: Added.
fast/js/nested-function-scope.html: Added.

1:41 PM Changeset in webkit [26620] by ggaren

4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Removed the concept of AnonymousCode. It was unused, and it doesn't
exist in the ECMA spec.

[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

kjs/Context.cpp: (KJS::Context::Context):
kjs/function.h: (KJS::):
kjs/nodes.cpp: (ReturnNode::execute):

1:40 PM Changeset in webkit [26619] by ggaren

3 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

Made function parameters DontDelete. This matches FF and the vague
description in ECMA 10.1.3. It's also required in order to make
symbol table based lookup of function parameters valid. (If the
parameters aren't DontDelete, you can't guarantee that you'll find
them later in the symbol table.)

[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

kjs/function.cpp: (KJS::FunctionImp::passInParameters):

LayoutTests:

Committed revision 26618.

Made function parameters DontDelete.

fast/js/delete-function-parameter-expected.txt: Added.
fast/js/delete-function-parameter.html: Added.

1:39 PM Changeset in webkit [26618] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Some Vector optimizations. These are especially important when using
Vector as a stack for implementing recursive algorithms iteratively.

[ Broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

Added shrink(), which is a version of resize() that you can call to save a branch / improve code generation and inlining when you know that the vector is not getting bigger.

Changed subclassing relationship in VectorBuffer to remove a call to fastFree() in the destructor for the inlineCapacity != 0 template specialization. This brings inline Vectors one step closer to true stack-allocated arrays.

Also changed abort() to CRASH(), since the latter works better.

wtf/Vector.h: (WTF::VectorBufferBase::allocateBuffer): (WTF::VectorBufferBase::deallocateBuffer): (WTF::VectorBufferBase::VectorBufferBase): (WTF::VectorBufferBase::~VectorBufferBase): (WTF::): (WTF::VectorBuffer::VectorBuffer): (WTF::VectorBuffer::~VectorBuffer): (WTF::VectorBuffer::deallocateBuffer): (WTF::VectorBuffer::releaseBuffer): (WTF::Vector::clear): (WTF::Vector::removeLast): (WTF::::operator): (WTF::::fill): (WTF::::shrink):

1:36 PM Changeset in webkit [26617] by ggaren

4 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Fixed http://bugs.webkit.org/show_bug.cgi?id=15490
Iteration statements sometimes incorrectly evaluate to the empty value
(KDE r670547).

[ Broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]

This patch is a merge of KDE r670547, with substantial modification
for performance.

It fixes do-while statements to evaluate to a value. (They used
to evaluate to the empty value in all cases.)

It also fixes SourceElementsNode to maintain the value of abnormal
completions like "break" and "continue."

It also re-works the main execution loop in SourceElementsNode so that
it (1) makes a little more sense and (2) avoids unnecessary work. This
is a .28% speedup on command-line JS iBench.

kjs/nodes.cpp: (DoWhileNode::execute): (SourceElementsNode::execute):

LayoutTests:

Reviewed by Maciej Stachowiak.

Layout tests for http://bugs.webkit.org/show_bug.cgi?id=15490
Iteration statements sometimes incorrectly evaluate to the empty value
(KDE r670547)

fast/js/do-while-expression-value-expected.txt: Added.
fast/js/do-while-expression-value.html: Added.
fast/js/while-expression-value-expected.txt: Added.
fast/js/while-expression-value.html: Added.

12:02 PM Changeset in webkit [26616] by darin

5 edits in trunk

WebCore:

Reviewed by Sam.

fix http://bugs.webkit.org/show_bug.cgi?id=15520 alert(undefined) should say "undefined" in the alert

Test: fast/dom/Window/alert-undefined.html

page/DOMWindow.idl: Remove ConvertUndefinedOrNullToNullString from alert, confirm, and prompt. It turns out that the default behavior is what the other browsers do (browsers tested: IE 7, Firefox 2).

LayoutTests:

Reviewed by Sam.

fix http://bugs.webkit.org/show_bug.cgi?id=15520 alert(undefined) should say "undefined" in the alert

fast/dom/Window/alert-undefined.html: Added tests of null and both confirm and prompt.
fast/dom/Window/alert-undefined-expected.txt: Updated.

11:47 AM Changeset in webkit [26615] by darin

4 edits in trunk/WebKitTools

Reviewed by Sam.

added logging of window.prompt and window.confirm

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Implement the recommended delegate rather than the deprecated one. (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Added. (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Added.

DumpRenderTree/win/UIDelegate.h:
DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string. (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added. (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added. (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.

11:39 AM Changeset in webkit [26614] by adele

3 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=15252
<rdar://problem/5498184> REGRESSION: <select multiple> doesn't scroll to top when old options are removed and new ones are added, leaving listbox empty-looking

rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight): If the scrollbar is disabled, make sure the scroll offset gets reset to 0. In general, we don't want to unnecessarily adjust the scroll offset, but in this case, there won't be an obvious way for the user to adjust the scroller position once it's disabled.

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=15252
<rdar://problem/5498184> REGRESSION: <select multiple> doesn't scroll to top when old options are removed and new ones are added, leaving listbox empty-looking

fast/forms/listbox-scroll-after-options-removed-expected.txt: Added.
fast/forms/listbox-scroll-after-options-removed.html: Added.

11:17 AM Changeset in webkit [26613] by sfalken

1 edit in branches/Safari-3-branch/WebCore/ChangeLog

Merged fix from r26610.

11:16 AM Changeset in webkit [26612] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26608.

11:15 AM Changeset in webkit [26611] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26607.

11:01 AM Changeset in webkit [26610] by honeycutt

1 edit in trunk/WebCore/ChangeLog

Fixing a date in the ChangeLog

10:25 AM Changeset in webkit [26609] by aliceli1

10 edits
4 adds in trunk

WebKitTools:

Reviewed by Sam Weinig.

Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail

DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Like on mac, before running each test, set the webview's policy delegate to null (main): allocate the global policy delegate for DRT's custom use
DumpRenderTree/win/DumpRenderTree.vcproj: Adding files to project
DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate): set the webview's policy delegate to DRT's custom one if the test requests it.
DumpRenderTree/win/PolicyDelegate.cpp: Added. Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm (PolicyDelegate::PolicyDelegate): (PolicyDelegate::QueryInterface): (PolicyDelegate::AddRef): (PolicyDelegate::Release): (PolicyDelegate::decidePolicyForNavigationAction):
DumpRenderTree/win/PolicyDelegate.h: Added. (PolicyDelegate::decidePolicyForNewWindowAction): (PolicyDelegate::decidePolicyForMIMEType): (PolicyDelegate::unableToImplementPolicyWithError):

win:

Reviewed by Sam Weinig.

Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail

DefaultPolicyDelegate.cpp: Added. Implementation is a direct port of WebKit/DefaultDelegates/WebDefaultPolicyDelegate.m (DefaultPolicyDelegate::DefaultPolicyDelegate): (DefaultPolicyDelegate::~DefaultPolicyDelegate): (DefaultPolicyDelegate::sharedInstance): (DefaultPolicyDelegate::createInstance): (DefaultPolicyDelegate::QueryInterface): (DefaultPolicyDelegate::AddRef): (DefaultPolicyDelegate::Release): (DefaultPolicyDelegate::decidePolicyForNavigationAction): (DefaultPolicyDelegate::decidePolicyForNewWindowAction): (DefaultPolicyDelegate::decidePolicyForMIMEType): (DefaultPolicyDelegate::unableToImplementPolicyWithError):
DefaultPolicyDelegate.h: Added.
WebFrame.cpp: (WebFrame::dispatchDecidePolicyForNavigationAction): Implemented default action
WebKit.vcproj/WebKit.vcproj: Adding files to project

LayoutTests:

removing fixed test

platform/win/Skipped:

10:20 AM Changeset in webkit [26608] by honeycutt

2 edits in trunk/WebCore

2007-10-12 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Maciej.

Return a more appropriate error from NPN_RequestRange, which is
currently unimplemented

plugins/win/npapi.cpp: return NPERR_STREAM_NOT_SEEKABLE (NPN_RequestRead):

10:15 AM Changeset in webkit [26607] by honeycutt

2 edits in trunk/WebCore

2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Maciej.

Add a missing function pointer to the m_browserFuncs structure

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):

9:46 AM Changeset in webkit [26606] by kmccullo

3 edits in trunk/LayoutTests

Reviewed by Sam.

<rdar://problem/5536630> fast/dom/Window/new-window-opener.html fails
This test used to pass because of a mistake in js-test-pre.js. Now that the js file has been fixed this test has been updated, some of the test cases fail because DRT does not implement delegate methods for the bars for each WebView.
See <rdar://problem/5538752> DumpRenderTree does not have a UIDelegate for each WebView.

Also changed the test to correctly wait for the window to close before starting a new testcase. This is necessary because all the windows have the same name and cannot override the settings of a pre-existing window.