Context Navigation

editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): For selection preservation, we must emit a character between every VisiblePosition. We weren't emitting a space after some tables, because we won't try to emit a space if shouldEmitNewlineAFterNode is true, even if no newline was emitted.

LayoutTests:

Reviewed by Kevin McCullough.

<rdar://problem/5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks

Demonstrates fix for the hang:

editing/execCommand/5483526-expected.txt: Added.
editing/execCommand/5483526.html: Added.

Fixed selection endpoint (problems with selection painting prevent this
from being reflected in the pixel test results):

platform/mac/editing/execCommand/5432254-2-expected.txt:

7:14 PM Changeset in webkit [26760] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Adam.

use declspec(thread) for fast thread-local storage on Windows

2.2% speedup on sunspider (on Windows)
7% speedup on the string section
6% speedup on JS iBench

fixed <rdar://problem/5473084> PLT on Windows got 2.5% slower between r25406 and r25422
fixed at least some of <rdar://5527965? i-Bench JS was 14% slower in 310A11 than 310A10

wtf/FastMalloc.cpp: (WTF::getThreadHeap): (WTF::setThreadHeap): (WTF::TCMalloc_ThreadCache::GetCache): (WTF::TCMalloc_ThreadCache::GetCacheIfPresent): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

5:49 PM Changeset in webkit [26759] by mitz

2 edits in trunk/WebKit

Tiger build fix.

WebView/WebDataSource.mm: (-[WebDataSource _MIMETypeOfResponse:]):

5:33 PM Changeset in webkit [26758] by mitz

13 edits in trunk

WebCore:

Reviewed by Adam Roben.

fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard

platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Work around <rdar://problem/5321972> by testing for the case of a response with a MIME type of application/octet-stream and a Content-Type header starting with text/plain and setting the MIME type to text/plain in that case.

WebKit:

Reviewed by Adam Roben.

fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
WebView/WebDataSource.mm: (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse with a MIMEType of application/octet-stream and a Content-Type header starting with text/plain and returning text/plain as the MIME type in that case. (-[WebDataSource _responseMIMEType]): Added. Used to get the correct response MIME type. (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType. (-[WebDataSource _makeRepresentation]): Ditto. (-[WebDataSource mainResource]): Ditto. (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and pass the MIME type explicitly. (-[WebDataSource subresourceForURL:]): Ditto.
WebView/WebDataSourcePrivate.h:
WebView/WebFrameView.mm: (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use _responseMIMEType.
WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this method to take a MIME type instead of extracting it from the response, so that WebDataSource could pass the correct MIME type.
WebView/WebResourcePrivate.h:

WebKitTools:

Reviewed by Adam Roben.

fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard

DumpRenderTree/mac/DumpRenderTree.mm: (dump): Changed to use _responseMIMEType.

LayoutTests:

Reviewed by Adam Roben.

removing fixed test

platform/mac-leopard/Skipped:

4:11 PM Changeset in webkit [26757] by bdash

2 edits in trunk/WebCore

2007-10-18 Mark Rowe <mrowe@apple.com>

Fix the no-SVG build.

css/CSSPrimitiveValueMappings.h: Move the CSSPrimitiveValue implementations for LineCap, LineJoin and WindRule inside #if ENABLE(SVG).

2:59 PM Changeset in webkit [26756] by darin

5 edits in trunk/WebCore

Reviewed by Anders.

some small tweaks to the threading implementation

I had trouble building on Windows. Either the problem went away by itself
or one of these changes fixed it.

platform/Threading.h: Eliminated the use of friend, and shared a single declaration for the initializeThreading function.

platform/pthreads/ThreadingPthreads.cpp: (WebCore::ThreadCondition::wait): Call impl() here.

platform/win/ThreadingWin.cpp: Got rid of two globals here with static constructors. Also added a typedef for the type of the function queue. (WebCore::functionQueueMutex): Added function. (WebCore::functionQueue): Ditto. (WebCore::callFunctionsOnMainThread): Use functions instead of using the globals directly. (WebCore::callOnMainThread): Ditto.

css/CSSParser.cpp: Had to touch this file to make things build.

2:35 PM Changeset in webkit [26755] by aroben

2 edits in trunk/WebKit/win

Fix <rdar://5547784> ProgIDMacros.h should explicitly use wide strings

Reviewed by Adele.

ProgIDMacros.h: Always use wide strings instead of relying on the TEXT macro.

1:43 PM Changeset in webkit [26754] by sfalken

1 copy in tags/Safari-523.12.2b

New tag.

1:43 PM Changeset in webkit [26753] by sfalken

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

1:29 PM Changeset in webkit [26752] by aroben

3 edits
1 add in branches/Safari-3-branch/WebCore

Merge r26751

1:26 PM Changeset in webkit [26751] by aroben

3 edits
1 add in trunk/WebCore

Fix <rdar://5547462> Need to copy Inspector resources in Production builds

I also added an excludes file for the xcopy command to avoid copying
.svn folders.

Reviewed by Geoff.

WebCore.vcproj/WebCore.make: Make sure we copy the Inspector resources.
WebCore.vcproj/WebCore.vcproj: Pass /exclude:xcopy.excludes to xcopy.
WebCore.vcproj/xcopy.excludes: Added.

10:00 AM Changeset in webkit [26750] by darin

4 edits in trunk

WebCore:

Reviewed by Sam.

fix http://bugs.webkit.org/show_bug.cgi?id=15541 REGRESSION (r26616): prompt with one argument uses the literal "undefined" as default reply

page/DOMWindow.idl: Add ConvertUndefinedOrNullToNullString back for defaultValue.

LayoutTests:

Reviewed by Sam.

test update for http://bugs.webkit.org/show_bug.cgi?id=15541 REGRESSION (r26616): prompt with one argument uses the literal "undefined" as default reply

fast/dom/Window/alert-undefined-expected.txt: Back to expecting empty string for default value.

9:44 AM Changeset in webkit [26749] by zimmermann

2 edits in trunk/WebCore

Build fix. Not reviewed.
Hopefully fix win build by including wtf/MathExtras.h.

9:27 AM Changeset in webkit [26748] by sfalken

1 copy in tags/Safari-523.12.1b

New tag.

9:27 AM Changeset in webkit [26747] by sfalken

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

9:21 AM Changeset in webkit [26746] by mitz

3 edits
4 adds in trunk

WebCore:

Reviewed by Nikolas Zimmermann.

fix http://bugs.webkit.org/show_bug.cgi?id=15367 Assertion failure inspecting a document including soft hyphen code (0xad)

Test: fast/text/word-break-soft-hyphen.html

rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths): Changed to treat soft hyphens as word boundaries. This fixes the bug and is consistent with the fact that run rounding does occur at soft hyphens.

LayoutTests:

Reviewed by Nikolas Zimmermann.

test for http://bugs.webkit.org/show_bug.cgi?id=15367 Assertion failure inspecting a document including soft hyphen code (0xad)

fast/text/word-break-soft-hyphen.html: Added.
platform/mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
platform/mac/fast/text/word-break-soft-hyphen-expected.png: Added.
platform/mac/fast/text/word-break-soft-hyphen-expected.txt: Added.

8:19 AM Changeset in webkit [26745] by zimmermann

10 edits in trunk

Reviewed by Anders.

Fix last layout test failure seen on buildbot "trunk-mac-ppc-release".
Problem: "svg/custom/mask-excessive-malloc.svg -> crashed"

Clamp any ImageBuffer allocation within SVG to the RenderView's visibleSize
to avoid excessive mallocs (in the testcase above 1000000x1000000)

2:57 AM Changeset in webkit [26744] by ap

2 edits in trunk/WebCore

Windows build fix.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Add braces around cases that have local variables now.

1:57 AM Changeset in webkit [26743] by ap

2 edits in trunk/WebCore

Release build fix.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

1:39 AM Changeset in webkit [26742] by ap

8 edits
1 add in trunk/WebCore

Reviewed by Darin.

Split most of CSSPrimitiveValue enum mapping out of CSSComputedStyleDeclaration::getPropertyCSSValue()
and CSSStyleSelector::applyProperty() (and their SVG counterparts). This should make the code more readable.

WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::getPositionOffsetValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::init):
css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
css/CSSPrimitiveValueMappings.h: Added. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EBorderStyle): (WebCore::CSSPrimitiveValue::operator CompositeOperator): (WebCore::CSSPrimitiveValue::operator EAppearance): (WebCore::CSSPrimitiveValue::operator EBackgroundBox): (WebCore::CSSPrimitiveValue::operator EBackgroundRepeat): (WebCore::CSSPrimitiveValue::operator EBoxAlignment): (WebCore::CSSPrimitiveValue::operator EBoxDirection): (WebCore::CSSPrimitiveValue::operator EBoxLines): (WebCore::CSSPrimitiveValue::operator EBoxOrient): (WebCore::CSSPrimitiveValue::operator ECaptionSide): (WebCore::CSSPrimitiveValue::operator EClear): (WebCore::CSSPrimitiveValue::operator ECursor): (WebCore::CSSPrimitiveValue::operator EDisplay): (WebCore::CSSPrimitiveValue::operator EEmptyCell): (WebCore::CSSPrimitiveValue::operator EFloat): (WebCore::CSSPrimitiveValue::operator EKHTMLLineBreak): (WebCore::CSSPrimitiveValue::operator EListStylePosition): (WebCore::CSSPrimitiveValue::operator EListStyleType): (WebCore::CSSPrimitiveValue::operator EMarginCollapse): (WebCore::CSSPrimitiveValue::operator EMarqueeBehavior): (WebCore::CSSPrimitiveValue::operator EMarqueeDirection): (WebCore::CSSPrimitiveValue::operator EMatchNearestMailBlockquoteColor): (WebCore::CSSPrimitiveValue::operator ENBSPMode): (WebCore::CSSPrimitiveValue::operator EOverflow): (WebCore::CSSPrimitiveValue::operator EPageBreak): (WebCore::CSSPrimitiveValue::operator EPosition): (WebCore::CSSPrimitiveValue::operator EResize): (WebCore::CSSPrimitiveValue::operator ETableLayout): (WebCore::CSSPrimitiveValue::operator ETextAlign): (WebCore::CSSPrimitiveValue::operator ETextSecurity): (WebCore::CSSPrimitiveValue::operator ETextTransform): (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): (WebCore::CSSPrimitiveValue::operator EUserDrag): (WebCore::CSSPrimitiveValue::operator EUserModify): (WebCore::CSSPrimitiveValue::operator EUserSelect): (WebCore::CSSPrimitiveValue::operator EVisibility): (WebCore::CSSPrimitiveValue::operator EWhiteSpace): (WebCore::CSSPrimitiveValue::operator EWordBreak): (WebCore::CSSPrimitiveValue::operator EWordWrap): (WebCore::CSSPrimitiveValue::operator LineCap): (WebCore::CSSPrimitiveValue::operator LineJoin): (WebCore::CSSPrimitiveValue::operator TextDirection): (WebCore::CSSPrimitiveValue::operator WindRule): (WebCore::CSSPrimitiveValue::operator EAlignmentBaseline): (WebCore::CSSPrimitiveValue::operator EColorInterpolation): (WebCore::CSSPrimitiveValue::operator EColorRendering): (WebCore::CSSPrimitiveValue::operator EDominantBaseline): (WebCore::CSSPrimitiveValue::operator EImageRendering): (WebCore::CSSPrimitiveValue::operator EPointerEvents): (WebCore::CSSPrimitiveValue::operator EShapeRendering): (WebCore::CSSPrimitiveValue::operator ETextAnchor): (WebCore::CSSPrimitiveValue::operator ETextRendering): (WebCore::CSSPrimitiveValue::operator EWritingMode):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundAttachment): (WebCore::CSSStyleSelector::mapBackgroundClip): (WebCore::CSSStyleSelector::mapBackgroundComposite): (WebCore::CSSStyleSelector::mapBackgroundOrigin): (WebCore::CSSStyleSelector::mapBackgroundRepeat): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
ksvg2/css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):

1:01 AM Changeset in webkit [26741] by mjs

3 edits in trunk/SunSpider

Reviewed by Eric.

Support Windows and Windows browsers.

hosted/sunspider-results.html: Display results correctly in IE.
sunspider: tweaks to work on Windows, and with spaces in the path.

12:30 AM Changeset in webkit [26740] by eseidel

6 edits
2 adds in trunk

2007-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Fix crashers in SVGViewSpec::parseViewSpec
http://bugs.webkit.org/show_bug.cgi?id=15504

Test is blocked by bug 15503, landed as:

svg/dom/viewspec-parser.html-disabled

bindings/scripts/CodeGeneratorObjC.pm: support classes where all parents are interfaces
ksvg2/svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
ksvg2/svg/SVGViewSpec.idl: Added.

12:27 AM Changeset in webkit [26739] by mjs

2 edits in trunk/SunSpider

Rubber stamped by Oliver.

tests/string-tagcloud.js: Remove stray print()

12:17 AM Changeset in webkit [26738] by mjs

2 edits
3 adds in trunk/SunSpider

Reviewed by Oliver.

Add some string test cases.

tests/string-base64.js: Added. Does base64 encoding and decoding.
tests/string-tagcloud.js: Added. Parses a JSON string and generates tagcloud HTML markup based on the data.
tests/string-unpack-code.js: Added. Unpack compressed versions of four of the most popular JavaScript libraries.
tests/LIST: Added the new tests.

Oct 17, 2007:

10:50 PM Changeset in webkit [26737] by aroben

3 edits in branches/Safari-3-branch/WebKitTools

Merge r26733

9:03 PM Changeset in webkit [26736] by sfalken

1 copy in tags/Safari-523.12b

New tag.

9:03 PM Changeset in webkit [26735] by sfalken

2 edits in branches/Safari-3-branch/WebKit/win

Bump versions for submit

8:56 PM Changeset in webkit [26734] by aroben

2 edits in trunk/WebKitTools

Make it possible to have Windows-specific tests and results

When searching for tests to run and the Skipped file, we will only
look in platform/win and the cross-platform directory. When looking
for expected results, we will look in platform/win, then
platform/mac-leopard, then platform/mac, then finally the
cross-platform directory.

Reviewed by Sam.

Scripts/run-webkit-tests: (sub expectedDirectoryForTest): Search in mac-leopard and mac before searching in the cross-platform directory. (sub buildPlatformHierarchy): Removed some unneeded calls to dirname/basename.

8:53 PM Changeset in webkit [26733] by aroben

3 edits in trunk/WebKitTools

Add back the call to register WebKit that we had before WebKitInitializer existed

This is needed to ensure that the right WebKit is used when
instantiating COM objects.

Reviewed by Oliver.

DumpRenderTree/win/debug_internal.vsprops: Define DEBUG_WEBKIT_HAS_SUFFIX.
DumpRenderTree/win/DumpRenderTree.cpp: (initialize):

8:28 PM Changeset in webkit [26732] by darin

4 edits
1 add in trunk

WebCore:

Reviewed by Darin, Adam, and Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first

Reset the element id cache when an id is added and there is a duplicate for that id.

dom/Document.cpp: (WebCore::Document::addElementById):

LayoutTests:

Reviewed by Darin, Adam, and Maciej.

Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first

fast/dom/duplicate-ids-document-order.html: Added.

8:20 PM Changeset in webkit [26731] by aroben

2 edits in branches/Safari-3-branch/WebKitTools

Merge r26730

8:17 PM Changeset in webkit [26730] by aroben

2 edits in trunk/WebKitTools

Import File::Basename in webkitdirs since we use it

Reviewed by NOBODY.

Scripts/webkitdirs.pm:

6:07 PM Changeset in webkit [26729] by kmccullo

2 edits in trunk/WebKitTools

Updated the tiger leaks list to make the internal bots green.

Scripts/run-webkit-tests:

5:18 PM Changeset in webkit [26728] by aroben

2 edits in branches/Safari-3-branch/WebKitTools

Merge r26727

5:15 PM Changeset in webkit [26727] by aroben

2 edits in trunk/WebKitTools

Build fix for VC++ Express

Reviewed by NOBODY.

FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib and ole32.lib.

5:10 PM Changeset in webkit [26726] by aroben

2 edits in trunk/WebCore

Fix an ASSERT on launch on Windows

Fix dictated to me by Brady.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncThreadMainLoop): Make sure we hold m_syncLock before going into the loop.

4:51 PM Changeset in webkit [26725] by bdash

2 edits in trunk/WebCore

2007-10-17 Mark Rowe <mrowe@apple.com>

Mac build fix.

Configurations/WebCore.xcconfig: Make it possible to include CoreGraphics header files.

4:39 PM Changeset in webkit [26724] by aroben

2 edits in trunk/WebKit/win

Fix for clean builds needed after r26683

Reviewed by NOBODY.

WebView.cpp: Remove #include of non-existant file.

4:10 PM Changeset in webkit [26723] by aroben

3 edits in trunk/WebCore

Windows build fix

Reviewed by NOBODY.

platform/graphics/AffineTransform.h: Don't #include ApplicationServices.h.
platform/graphics/cg/GraphicsContextCG.cpp: Add an #include that's needed now that we're not #including ApplicationServices.h.

3:57 PM Changeset in webkit [26722] by bdash

3 edits
1 add in trunk/WebCore

2007-10-17 Mark Rowe <mrowe@apple.com>

Gtk build fix. Move non-pthread stubs from Threading.h to ThreadingNone.cpp to prevent
multiple-definition link errors.

WebCore.pro:
platform/Threading.h:
platform/ThreadingNone.cpp: Added. (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock): (WebCore::ThreadCondition::ThreadCondition):

3:37 PM Changeset in webkit [26721] by aliceli1

4 edits in trunk/LayoutTests

Rubber-stamped by Adele.

Correct uses of initKeyboardEvent for tests that test accesskey.
Accesskey modifier is ctrl for mac and alt for other platforms.

fast/events/access-key-self-destruct.html:
fast/forms/access-key.html:
fast/forms/legend-access-key.html:

2:25 PM Changeset in webkit [26720] by darin

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

fix http://bugs.webkit.org/show_bug.cgi?id=15543 <rdar://problem/5545639> REGRESSION (r26697): GoogleDocs: Can't create new documents or open existing ones

Test: fast/js/regexp-non-character.html

pcre/pcre_compile.c: (check_escape): Take out the checks for valid characters in the \u sequences -- not needed and actively harmful.

LayoutTests:

Reviewed by Mark Rowe.

test for http://bugs.webkit.org/show_bug.cgi?id=15543 <rdar://problem/5545639> REGRESSION (r26697): GoogleDocs: Can't create new documents or open existing ones

fast/js/regexp-non-character-expected.txt: Added.
fast/js/regexp-non-character.html: Added.
fast/js/resources/regexp-non-character.js: Added.

2:24 PM Changeset in webkit [26719] by tristan

6 edits in branches/Safari-2.0-dashboard/WebCore

Fixed merge of r24938 and r24946 by initializing the security policy URL
in the right place. Tests from Aaron Sigel now pass.

<rdar://problem/5471815> [WebKitForDashboard clone] data: URLs can gain access to frames in foreign domains

khtml/ecma/kjs_window.cpp: (Window::isSafeScript):
khtml/khtml_part.cpp: (KHTMLPart::begin): (KHTMLPart::URL): (KHTMLPart::setOpener):
khtml/khtml_part.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::initSecurityPolicyURL):
khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::securityPolicyURL):

2:15 PM Changeset in webkit [26718] by darin

1 edit in trunk/JavaScriptCore/ChangeLog

Remove stray change marker.

2:13 PM Changeset in webkit [26717] by darin

1 edit in trunk/WebCore/ChangeLog

Remove stray merge marker.

2:05 PM Changeset in webkit [26716] by andersca

10 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Oliver.

wtf/Platform.h: #define USE_PTHREADS on Mac.

WebCore:

Reviewed by Oliver.

WebCore.xcodeproj/project.pbxproj:
WebCore.vcproj/WebCore.vcproj:

config.h: #define USE_PTHREADS on Windows.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::getOrCreateIconRecord): (WebCore::IconDatabase::getOrCreatePageURLRecord): Update for mutex changes.

platform/Threading.h: (WebCore::): (WebCore::ThreadSafeShared::ThreadSafeShared): (WebCore::ThreadSafeShared::ref): (WebCore::ThreadSafeShared::deref): (WebCore::ThreadSafeShared::hasOneRef): (WebCore::ThreadSafeShared::refCount): (WebCore::ThreadSafeShared::isThreadSafe): Add a new Shared base class that uses a mutex to manage its refcount.

(WebCore::createThread):
(WebCore::waitForThreadCompletion):
(WebCore::detachThread):
New functions for thread creation.

(WebCore::Mutex::Mutex):
(WebCore::Mutex::~Mutex):
(WebCore::Mutex::lock):
(WebCore::Mutex::tryLock):
(WebCore::Mutex::unlock):
Move the definitions to ThreadingPthreads.cpp

(WebCore::ThreadCondition::ThreadCondition):
(WebCore::ThreadCondition::~ThreadCondition):
(WebCore::ThreadCondition::wait):
(WebCore::ThreadCondition::signal):
(WebCore::ThreadCondition::broadcast):
Move the definitions to ThreadingPthreads.cpp

platform/pthreads: Added.
platform/pthreads/ThreadingPthreads.cpp: Added. Add pthread specific implementation of the thread creation functions, Mutex and ThreadCondition.

win:

Update for locking primitive changes.

WebIconDatabase.cpp: (WebIconDatabase::scheduleNotificationDelivery):

2:01 PM Changeset in webkit [26715] by ggaren

8 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Merged DeclaredFunctionImp into FunctionImp (the base class) because
the distinction between the two was unused.

Removed codeType() from FunctionImp because FunctionImp and its
subclasses all returned FunctionCode, so it was unused, practically
speaking.

Removed a different codeType() from GlobalFuncImp because it was unused.
(Perhaps it was vestigial from a time when GlobalFuncImp used to
inherit from FunctionImp.)

bindings/runtime_method.cpp:
bindings/runtime_method.h:
kjs/function.cpp: (KJS::): (KJS::FunctionImp::FunctionImp): (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::construct): (KJS::FunctionImp::execute): (KJS::FunctionImp::processVarDecls):
kjs/function.h: (KJS::FunctionImp::implementsConstruct): (KJS::FunctionImp::scope):
kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate):

1:29 PM Changeset in webkit [26714] by aroben

2 edits
1 add in branches/Safari-3-branch/WebKitTools

Merge r26708

1:29 PM Changeset in webkit [26713] by aroben

13 edits
6 deletes in branches/Safari-3-branch

Merge r26707

1:29 PM Changeset in webkit [26712] by aroben

4 edits
3 adds in branches/Safari-3-branch

Merge r26706

1:28 PM Changeset in webkit [26711] by aroben

18 edits in branches/Safari-3-branch

Merge r26684

1:28 PM Changeset in webkit [26710] by hyatt

9 edits in trunk/WebCore

Add support for creating a layer when a transform is in effect. Add support to RenderStyle for
handing back a computed AffineTransform.

Reviewed by Mitz Pettel

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::requiresLayer): (WebCore::RenderObject::setStyle):
rendering/RenderObject.h: (WebCore::RenderObject::hasTransform): (WebCore::RenderObject::setHasTransform):
rendering/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
rendering/RenderStyle.h: (WebCore::RenderStyle::hasTransform):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer):
rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):

1:24 PM Changeset in webkit [26709] by darin

2 edits in trunk/WebKit

Reviewed by Mark Rowe.

fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]

WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object. It's safe to do that for functions that return integers or pointers, but not structures.

1:12 PM Changeset in webkit [26708] by aroben

2 edits
1 add in trunk/WebKitTools

Add a new nightly launcher script for Windows

This new script is for versions of Safari that don't delay-load
WebKit. I had to make FindSafari be able to print out the nightly
launcher script on stdout because Windows shell scripts can't capture
the output from a command into an environment variable.

Reviewed by Steve.

FindSafari/FindSafari.cpp: (_tmain): Added /printSafariLauncher option.
Scripts/run-webkit-nightly.cmd: Added.

1:12 PM Changeset in webkit [26707] by aroben

13 edits
6 deletes in trunk

Stop delay-loading WebKit in DRT and teskjs

JavaScriptCore:

Make testkjs not delay-load WebKit

Soon, delay-loading WebKit will be impossible (because we will be
using declspec(thread) for thread-local storage). This change
prepares testkjs for the future.

Reviewed by Sam.

JavaScriptCore.vcproj/JavaScriptCore.sln: Removed WebKitInitializer, added FindSafari.
JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Don't link against WebKitInitializer, don't delay-load WebKit.
kjs/testkjs.cpp: Don't use WebKitInitializer.

WebKitTools:

Replace WebKitInitializer with FindSafari

We now rely on setting the PATH environment variable to tell Windows
where to find WebKit and its dependencies (similar to
DYLD_FRAMEWORK_PATH on Mac).

This change also make DumpRenderTree no longer delay-load WebKit.

Reviewed by Sam.

DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added FindSafari.
DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against WebKitInitializer, don't delay-load WebKit.
Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
Scripts/run-webkit-tests: Ditto.
Scripts/webkitdirs.pm: (sub setPathForRunningWebKitApp): Added.
WebKitInitializer/WebKitInitializer.cpp: Removed.
WebKitInitializer/WebKitInitializer.h: Removed.
WebKitInitializer/WebKitInitializer.vcproj: Removed.
WebKitInitializer/debug.vsprops: Removed.
WebKitInitializer/debug_internal.vsprops: Removed.
WebKitInitializer/release.vsprops: Removed.

WebKit/win:

Remove WebKitInitializer

Reviewed by Sam.

WebKit.vcproj/WebKit.sln:

1:11 PM Changeset in webkit [26706] by aroben

4 edits
3 adds in trunk

Fix Bug 15532: run-safari fails if Safari is installed in a non-default location

WebKitTools:

Fix Bug 15532: run-safari fails if Safari is installed in a non-default location

http://bugs.webkit.org/show_bug.cgi?id=15532

FindSafari simply prints the location of an installed Safari.exe on
stdout.

Reviewed by Darin.

FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp. (getStringValue): (getWebViewCLSID): (getInstalledWebKitDirectory): (_tmain):
FindSafari/FindSafari.vcproj: Added.
Scripts/webkitdirs.pm: (sub installedSafariPath): Added. Calls FindSafari on Windows.

WebKit/win:

Add FindSafari

Reviewed by Darin.

WebKit.vcproj/WebKit.sln:

12:47 PM Changeset in webkit [26705] by hyatt

8 edits in trunk/WebCore

Add support for mapping of the transform CSS property into RenderStyles. Everything is now ready for the front
end to use.

Reviewed by Mitz Pettel

WebCore.xcodeproj/project.pbxproj:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
css/CSSTransformValue.h: (WebCore::CSSTransformValue::type): (WebCore::CSSTransformValue::values):
platform/graphics/AffineTransform.cpp: (WebCore::AffineTransform::skew):
platform/graphics/AffineTransform.h:
rendering/RenderStyle.cpp: (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleTransformData::operator==): (WebCore::StyleTransformData::transformDataEquivalent):
rendering/RenderStyle.h: (WebCore::TransformOperation::~TransformOperation): (WebCore::TransformOperation::operator!=): (WebCore::TransformOperation::isScaleOperation): (WebCore::TransformOperation::isRotateOperation): (WebCore::TransformOperation::isSkewOperation): (WebCore::TransformOperation::isTranslateOperation): (WebCore::TransformOperation::isMatrixOperation): (WebCore::ScaleTransformOperation::ScaleTransformOperation): (WebCore::ScaleTransformOperation::isScaleOperation): (WebCore::ScaleTransformOperation::operator==): (WebCore::ScaleTransformOperation::apply): (WebCore::RotateTransformOperation::RotateTransformOperation): (WebCore::RotateTransformOperation::isRotateOperation): (WebCore::RotateTransformOperation::operator==): (WebCore::RotateTransformOperation::apply): (WebCore::SkewTransformOperation::SkewTransformOperation): (WebCore::SkewTransformOperation::isSkewOperation): (WebCore::SkewTransformOperation::operator==): (WebCore::SkewTransformOperation::apply): (WebCore::TranslateTransformOperation::TranslateTransformOperation): (WebCore::TranslateTransformOperation::isTranslateOperation): (WebCore::TranslateTransformOperation::operator==): (WebCore::TranslateTransformOperation::apply): (WebCore::MatrixTransformOperation::MatrixTransformOperation): (WebCore::MatrixTransformOperation::isMatrixOperation): (WebCore::MatrixTransformOperation::operator==): (WebCore::MatrixTransformOperation::apply): (WebCore::StyleTransformData::operator!=): (WebCore::RenderStyle::transform): (WebCore::RenderStyle::setTransform): (WebCore::RenderStyle::initialTransform):

12:30 PM Changeset in webkit [26704] by aroben

6 edits in trunk

Windows build fix part 2.

JavaScriptCore:

Windows build fix part 2.

Fix was by Darin, reviewed by Anders and Adam.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add FastMallocPCRE.cpp to the project, and let Visual Studio have its way with the post-build step.
pcre/pcre.h: Don't DLL export the entry points just because this is Win32 -- this is an internal copy of PCRE and should be private.
pcre/pcre_compile.c: Fix an uninitialized variable warning -- there's no real problem but it's better to quiet the compiler by tweaking the code slightly than turn off the warning entirely.

WebCore:

page/Frame.cpp: I had to touch this file when fixing the Windows build. Checking it in in case it helps others, too.

11:33 AM Changeset in webkit [26703] by eseidel

2 edits in trunk/WebCore

2007-10-17 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Remove a couple more uses of svg_dynamic_cast.

No functional changes, no tests.

ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):

11:05 AM Changeset in webkit [26702] by bdash

2 edits in trunk/WebCore

2007-10-17 Mark Rowe <mrowe@apple.com>

Reviewed by Eric and Geoff.

<rdar://problem/5453743> Repro ASSERT in CachedResource::setEncodedSize() loading image in background tab
http://bugs.webkit.org/show_bug.cgi?id=15191

loader/DocLoader.cpp: (WebCore::DocLoader::setAutoLoadImages): Don't start a load if the CachedImage is already loading.

10:54 AM Changeset in webkit [26701] by aroben

3 edits in trunk/JavaScriptCore

Windows build fix.

Reviewed by Anders.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable some mismatched signed/unsigned comparison warnings.
pcre/pcre_exec.c: (match): #if-out some labels that don't seem to exist.

10:51 AM Changeset in webkit [26700] by justing

5 edits
4 adds in trunk

WebCore:

Reviewed by Harrison.

<rdar://problem/5481523>
GoogleDocs: Safari hangs when indenting a particular table twice

Fixed by fixing problems with the selection preservation done by IndentOutdentCommand.
It is now more difficult to create selections that cause hangs. Those are covered by:
<rdar://problem/5543472>

editing/IndentOutdentCommand.cpp: (WebCore::indexForVisiblePosition): Compute indices from the first VisiblePosition in the document, instead of the first Position. Use rangeCompliantEquivalents when creating the Range that we pass to rangeLength. Tell TextIterator::rangeLength that we're doing selection preservation, so that it will emit characters between all VisiblePositions. (WebCore::IndentOutdentCommand::indentRegion): Fixed a bug where the range and location passed to rangeFromLocationAndLength were reversed. Tell rangeFromLocationAndLength that we're doing doing selection preservation, as above.
editing/TextIterator.cpp: (WebCore::CharacterIterator::CharacterIterator): (WebCore::TextIterator::rangeLength): Rename emitSpacesForReplacedElements to forSelectionPreservation, to match the name of the boolean inside TextIterator and to match its meaning after r25522. (WebCore::TextIterator::rangeFromLocationAndLength): Ditto.

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5481523>
GoogleDocs: Safari hangs when indenting a particular table twice

editing/execCommand/5481523.html: Added.
platform/mac/editing/execCommand/5481523-expected.checksum: Added.
platform/mac/editing/execCommand/5481523-expected.png: Added.
platform/mac/editing/execCommand/5481523-expected.txt: Added.

12:45 AM Changeset in webkit [26699] by bdash

3 edits in trunk/JavaScriptCore

2007-10-17 Mark Rowe <mrowe@apple.com>

Gtk build fix.

JavaScriptCore.pri: Add FastMallocPCRE.cpp.
pcre/pcre_get. #if out two functions that depend on pcre_get_stringnumber, which is currently unavailable for UTF-16.

12:12 AM Changeset in webkit [26698] by mjs

4 edits
3 adds in trunk/SunSpider

Reviewed by Anders.

TODO: Updated with info on how to do the stats properly.

hosted/sunspider-driver.html: Reduce timeout from 500 to 200 to avoid overly slowing down the benchmark.

Context Navigation

Timeline

Oct 18, 2007:

Oct 17, 2007:

Download in other formats: