⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 19, 2007:

10:37 PM Changeset in webkit [26810] by alp
  • 10 edits in trunk

2007-10-19 Alp Toker <​alp@atoker.com>

Reviewed by Oliver.

GTK+ build fix enabling the new local database storage feature.
There is also a prospective Qt build fix.

10:20 PM Changeset in webkit [26809] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Added Bugzilla link to ChangeLog

10:18 PM Changeset in webkit [26808] by ggaren
  • 6 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


To improve encapsulation, moved processDeclarations call into
FunctionBodyNode::execute. Also marked processDeclarations
ALWAYS_INLINE, since it has only 1 caller now. This is a .71% speedup
on command-line JS iBench.

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
  • kjs/nodes.cpp: (FunctionBodyNode::execute):
  • kjs/nodes.h:
9:39 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
9:35 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
9:10 PM Changeset in webkit [26807] by aroben
  • 2 edits in branches/Safari-3-branch/WebKitTools

Merge r26766

9:08 PM Changeset in webkit [26806] by andrew
  • 2 edits in trunk/WebCore

Reviewed by Brady Eidson.

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj:
8:09 PM Changeset in webkit [26805] by oliver
  • 2 edits in trunk/LayoutTests

Updating window properties to include new features from HTML5 database support

RS=Mark

  • fast/dom/Window/window-properties-expected.txt:
7:20 PM Changeset in webkit [26804] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Mark Rowe.

Fix a couple of exceptions for first time users.

  • misc/DatabaseExample.html:
6:48 PM Changeset in webkit [26803] by alp
  • 3 edits in trunk/WebCore

2007-10-19 Alp Toker <​alp@atoker.com>

Reviewed by Oliver.

Use platform colors for text selection.
Update the cache when the GTK style is changed.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkStyleSet): (WebCore::RenderThemeGtk::gtkEntry):
  • platform/gtk/RenderThemeGtk.h:
6:18 PM Changeset in webkit [26802] by adele
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Beth.

Fix for: <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com

Test: fast/forms/menulist-no-overflow.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Don't allow overflow on menu lists.

LayoutTests:

Reviewed by Beth.

Test for <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com

  • fast/forms/menulist-no-overflow.html: Added.
  • platform/mac/fast/forms/menulist-no-overflow-expected.checksum: Added.
  • platform/mac/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/mac/fast/forms/menulist-no-overflow-expected.txt: Added.
6:06 PM Changeset in webkit [26801] by andersca
  • 3 edits
    6 moves in trunk/WebCore

Reviewed by Brady.

Move some SQL-related classes to platform/sql.


  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/SQLDatabase.cpp: Removed.
  • loader/icon/SQLDatabase.h: Removed.
  • loader/icon/SQLStatement.cpp: Removed.
  • loader/icon/SQLStatement.h: Removed.
  • loader/icon/SQLTransaction.cpp: Removed.
  • loader/icon/SQLTransaction.h: Removed.
  • platform/sql/SQLDatabase.cpp: Copied from loader/icon/SQLDatabase.cpp.
  • platform/sql/SQLDatabase.h: Copied from loader/icon/SQLDatabase.h.
  • platform/sql/SQLStatement.cpp: Copied from loader/icon/SQLStatement.cpp.
  • platform/sql/SQLStatement.h: Copied from loader/icon/SQLStatement.h.
  • platform/sql/SQLTransaction.cpp: Copied from loader/icon/SQLTransaction.cpp.
  • platform/sql/SQLTransaction.h: Copied from loader/icon/SQLTransaction.h.
5:49 PM Changeset in webkit [26800] by andersca
  • 2 edits in trunk/WebKitSite

Reviewed by Brady.


Make example actually work.


  • misc/DatabaseExample.html:
5:45 PM Changeset in webkit [26799] by andersca
  • 6 edits in trunk

WebCore:

Reviewed by Adam.

Update to match the latest version of the spec. Now, executeSQL takes an array
of SQL parameters instead of them being passed as arguments.


  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::executeSql):
  • page/inspector/DatabasePanel.js:
  • storage/Database.idl:

WebKitSite:

Reviewed by Adam.

Update example.


  • misc/DatabaseExample.html:
5:38 PM Changeset in webkit [26798] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

  • This change should be identical but for some reason was not working on my machine.
  • Scripts/prepare-ChangeLog:
5:22 PM Changeset in webkit [26797] by beidson
  • 6 edits in trunk

WebCore:

Reviewed by Tim

Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(

  • storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker):

WebKitSite:

Reviewed by Tim

Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(

  • misc/DatabaseExample.html:
4:57 PM Changeset in webkit [26796] by andersca
  • 2 edits in trunk/WebCore

Release build fix.


  • WebCore.vcproj/WebCore.vcproj:
4:42 PM Changeset in webkit [26795] by sfalken
  • 1 copy in tags/Safari-523.12.5b

New tag.

4:42 PM Changeset in webkit [26794] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

4:37 PM Changeset in webkit [26793] by beidson
  • 2 edits in trunk/WebCore

Remove stray printfs

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
4:36 PM Changeset in webkit [26792] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Apparently the Win32 pthreads impl we use does not allow unlocking a mutex that has not
already been locked, so lock the mutex first.


  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):
4:34 PM Changeset in webkit [26791] by beidson
  • 2 edits in trunk/WebCore

Better build fix

  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction): Definite works by 3.3.13
4:25 PM Changeset in webkit [26790] by beidson
  • 2 edits in trunk/WebCore

Build fix

  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction): I don't know *when* these constants were added to SQLite, but I know they were by 3.4.0
3:55 PM Changeset in webkit [26789] by sfalken
  • 1 copy in tags/Safari-523.12.4b

New tag.

3:55 PM Changeset in webkit [26788] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

3:50 PM Changeset in webkit [26787] by beidson
  • 48 edits
    24 copies
    34 adds in trunk

JavaScriptCore:

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Sam

Queue -> Deque! and small style tweaks

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
  • wtf/Deque.h: Added. (WTF::DequeNode::DequeNode): (WTF::Deque::Deque): (WTF::Deque::~Deque): (WTF::Deque::size): (WTF::Deque::isEmpty): (WTF::Deque::append): (WTF::Deque::prepend): (WTF::Deque::first): (WTF::Deque::last): (WTF::Deque::removeFirst): (WTF::Deque::clear):
  • wtf/Queue.h: Removed.

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Oliver

Added a simple LinkedList based Queue to wtf
We can make a better, more sophisticated an efficient one later, but have
needed one for some time, now!

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Queue.h: Added. (WTF::QueueNode::QueueNode): (WTF::Queue::Queue): (WTF::Queue::~Queue): (WTF::Queue::size): (WTF::Queue::isEmpty): (WTF::Queue::append): (WTF::Queue::prepend): (WTF::Queue::first): (WTF::Queue::last): (WTF::Queue::removeFirst): (WTF::Queue::clear):

WebCore:
2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

Windows specific changes, as well as renaming Queue -> Deque

  • ForwardingHeaders/wtf/Deque.h: Added.
  • ForwardingHeaders/wtf/Queue.h: Removed.
  • platform/win/FileSystemWin.cpp: (WebCore::fileSize): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath):
  • storage/Database.h:
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::documentGoingAway): (WebCore::DatabaseThread::databaseGoingAway): (WebCore::DatabaseThread::dispatchNextTaskIdentifier): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask):
  • storage/DatabaseThread.h:

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Tim and Anders

Preliminary support for HTML5 local database storage (​http://www.whatwg.org/specs/web-apps/current-work/)

The specification is still in flux but the fundamentals are pretty solid and we can start using and testing
this implementation even while filing bugs to track changes in the spec as it becomes more final

There are some implementation details in this patch that seem unused or useless, but they remain in place
while the spec is in flux and might go one way or another.

  • platform/Logging.cpp: Add StorageAPI logging channel
  • platform/Logging.h:
  • storage/Database.cpp: Added. (WebCore::Database::databaseInfoTableName): (WebCore::databaseVersionKey): (WebCore::Database::openDatabase): C++ version of the window.openDatabase() javascript API (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::retrieveTextResultFromDatabase): (WebCore::Database::getVersionFromDatabase): (WebCore::setTextValueInDatabase): (WebCore::Database::setVersionInDatabase): (WebCore::Database::databaseThreadGoingAway): May be removed in the future (WebCore::Database::disableAuthorizer): For internal (WebInspector) use to get around the authorizer's restrictions (WebCore::Database::enableAuthorizer): (WebCore::Database::guidForOriginAndName): Candidate for refactoring and/or moving to the database tracker. The GUID for each database identifier is currently for tracking the database version, but might be rescoped in the future (WebCore::Database::resetAuthorizer): (WebCore::Database::performPolicyChecks): Currently, the only post-executeSql policy check planned is the origin size usage (WebCore::Database::scheduleDatabaseCallback): (WebCore::Database::performOpenAndVerify): (WebCore::Database::performChangeVersion): (WebCore::Database::performExecuteSql): (WebCore::Database::performCloseTransaction): (WebCore::Database::performGetTableNames): (WebCore::Database::version): C++ version of the javascript API (WebCore::Database::changeVersion): Ditto (WebCore::Database::executeSql): Ditto (WebCore::Database::closeTransaction): Ditto (WebCore::Database::tableNames): For internal (WebInspector) use (WebCore::Database::deliverAllPendingCallbacks): (WebCore::Database::deliverPendingCallbacks):
  • storage/Database.h: Added. (WebCore::Database::databaseDebugName): For debug logging purposes
  • storage/Database.idl: Added.
  • storage/DatabaseAuthorizer.cpp: Added. The DatabaseAuthorizer is used to both prevent the script from doing "illegal" things in sql as well as tracking when effects certain sql statements might have (such as increasing the size of the database) (WebCore::DatabaseAuthorizer::DatabaseAuthorizer): (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::createTempTable): (WebCore::DatabaseAuthorizer::dropTable): (WebCore::DatabaseAuthorizer::dropTempTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTempIndex): (WebCore::DatabaseAuthorizer::dropIndex): (WebCore::DatabaseAuthorizer::dropTempIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createTempTrigger): (WebCore::DatabaseAuthorizer::dropTrigger): (WebCore::DatabaseAuthorizer::dropTempTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::dropVTable): (WebCore::DatabaseAuthorizer::allowDelete): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate): (WebCore::DatabaseAuthorizer::allowRead): (WebCore::DatabaseAuthorizer::allowAnalyze): (WebCore::DatabaseAuthorizer::allowPragma): (WebCore::DatabaseAuthorizer::allowAttach): (WebCore::DatabaseAuthorizer::allowDetach): (WebCore::DatabaseAuthorizer::allowFunction): (WebCore::DatabaseAuthorizer::disable): (WebCore::DatabaseAuthorizer::enable): (WebCore::DatabaseAuthorizer::denyBasedOnTableName): Don't allow access to the WebKit meta info table as it should be invisible to scripts
  • storage/DatabaseAuthorizer.h: Added. (WebCore::DatabaseAuthorizer::lastActionWasInsert): (WebCore::DatabaseAuthorizer::lastActionIncreasedSize):
  • storage/DatabaseCallback.cpp: Added. Generic item to queue up for callbacks on the main thread for database activities that take place on a secondary thread (WebCore::DatabaseChangeVersionCallback::DatabaseChangeVersionCallback): (WebCore::DatabaseChangeVersionCallback::performCallback): (WebCore::DatabaseExecuteSqlCallback::DatabaseExecuteSqlCallback): (WebCore::DatabaseExecuteSqlCallback::performCallback):
  • storage/DatabaseCallback.h: Added. (WebCore::DatabaseCallback::~DatabaseCallback): (WebCore::DatabaseChangeVersionCallback::~DatabaseChangeVersionCallback): (WebCore::DatabaseExecuteSqlCallback::~DatabaseExecuteSqlCallback):
  • storage/DatabaseTask.h: Added. Generic work-item to be queued up on the background database thread (WebCore::DatabaseTask::isComplete): (WebCore::DatabaseOpenTask::exceptionCode): (WebCore::DatabaseOpenTask::openSuccessful): (WebCore::DatabaseTableNamesTask::tableNames):
  • storage/DatabaseTask.cpp: Added. (WebCore::DatabaseTask::DatabaseTask): (WebCore::DatabaseTask::~DatabaseTask): (WebCore::DatabaseTask::performTask): (WebCore::DatabaseTask::lockForSynchronousScheduling): Used when the main thread needs this task accomplished synchronously (WebCore::DatabaseTask::waitForSynchronousCompletion):

(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):

(WebCore::DatabaseExecuteSqlTask::DatabaseExecuteSqlTask):
(WebCore::DatabaseExecuteSqlTask::doPerformTask):

(WebCore::DatabaseChangeVersionTask::DatabaseChangeVersionTask):
(WebCore::DatabaseChangeVersionTask::doPerformTask):

(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseTableNamesTask::doPerformTask):

  • storage/DatabaseThread.cpp: Added. The current design is that each Document will have its own DatabaseThread. This makes scripts on each individual document more response at the cost of adding more threads and potentially creating concurrency issues when the same database is open twice from two different documents (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::~DatabaseThread): (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::documentGoingAway): Called to shut the thread down when the document is destroyed (WebCore::DatabaseThread::databaseGoingAway): Remove all pending tasks for this database (WebCore::DatabaseThread::databaseThreadStart): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::dispatchNextTaskIdentifier): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask): Schedule a task that gets to "cut to the front of the line" when the main thread requires a task be performed synchronously (WebCore::DatabaseThread::wakeWorkThread):
  • storage/DatabaseThread.h: Added.
  • storage/DatabaseTracker.cpp: Added. The DatabaseTracker is the master management of all databases. It will keep track of the filename for a given unique database, keep track of the total disk usage per-origin, and policys per database/origin (WebCore::DatabaseTracker::setDatabasePath): (WebCore::DatabaseTracker::databasePath): (WebCore::DatabaseTracker::tracker): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteAllDatabasesForOrigin):
  • storage/DatabaseTracker.h: Added.
  • storage/SQLCallback.h: Added. C++ version of the javascript executeSql() callback (WebCore::SQLCallback::~SQLCallback):
  • storage/SQLCallback.idl: Added.
  • storage/SQLResultSet.cpp: Added. C++ version of the javascript SQLResultSet object (WebCore::SQLResultSet::SQLResultSet): (WebCore::SQLResultSet::insertId): (WebCore::SQLResultSet::rowsAffected): (WebCore::SQLResultSet::errorCode): (WebCore::SQLResultSet::error): (WebCore::SQLResultSet::rows): (WebCore::SQLResultSet::setInsertId): (WebCore::SQLResultSet::setRowsAffected): (WebCore::SQLResultSet::setErrorCode): (WebCore::SQLResultSet::setErrorMessage):
  • storage/SQLResultSet.h: Added.
  • storage/SQLResultSet.idl: Added.
  • storage/SQLResultSetRowList.cpp: Added. C++ version of the javascript SQLResultSetRowList object (WebCore::SQLResultSetRowList::length):
  • storage/SQLResultSetRowList.h: Added. (WebCore::SQLResultSetRowList::columnNames): (WebCore::SQLResultSetRowList::values): (WebCore::SQLResultSetRowList::addColumn): (WebCore::SQLResultSetRowList::addResult):
  • storage/SQLResultSetRowList.idl: Added.
  • storage/VersionChangeCallback.h: Added. C++ version of the javascript changeVersion() callback (WebCore::VersionChangeCallback::~VersionChangeCallback):
  • storage/VersionChangeCallback.idl: Added.

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Oliver + Same

Forwarding header for the new wtf/Queue.h

  • ForwardingHeaders/wtf/Queue.h: Added.

2007-10-19 Anders Carlsson <​beidson@apple.com>

Reviewed by Sam Weinig

Most of the Javascript binding support for the Storage API

  • bindings/js/JSCustomSQLCallback.cpp: Added. (WebCore::JSCustomSQLCallback::JSCustomSQLCallback): (WebCore::JSCustomSQLCallback::handleEvent):
  • bindings/js/JSCustomSQLCallback.h: Added. Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches handleEvent to a JS function or a JS object with a handleEvent function.
  • bindings/js/JSCustomVersionChangeCallback.cpp: Added. (WebCore::JSCustomVersionChangeCallback::JSCustomVersionChangeCallback): (WebCore::JSCustomVersionChangeCallback::handleEvent):
  • bindings/js/JSCustomVersionChangeCallback.h: Added. Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches handleEvent to a JS function or a JS object with a handleEvent function.
  • bindings/js/JSDatabaseCustom.cpp: Added. (WebCore::JSDatabase::executeSql): Custom implementation of executeSql that takes an array of parameters.

(WebCore::JSDatabase::changeVersion):

Custom implementation of changeVersion.

  • bindings/js/JSSQLResultSetRowListCustom.cpp: Added. (WebCore::JSSQLResultSetRowList::item): Custom method that returns a JS object that corresponds to a given row in the database.
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase):
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Add openDatabase implementation.

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Oliver

Added tons of utility to the FileSystem abstractions, including moving
some stuff over from IconDatabase

  • platform/FileSystem.h:
  • platform/cf/FileSystemCF.cpp: Added. (WebCore::fileSystemRepresentation):
  • platform/mac/FileSystemMac.mm:
  • platform/posix/FileSystemPOSIX.cpp: Added. (WebCore::fileExists): (WebCore::deleteFile): (WebCore::fileSize): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories):

2007-10-19 Timothy Hatcher <​timothy@apple.com>

Reviewed by Adam Roben

Preliminary Web Inspector support for the Storage API
(This patch does not include the support artwork)

  • page/InspectorController.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::setScriptObject): (WebCore::databaseTableNames): Return the table names for a Database object. (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::populateScriptResources): (WebCore::InspectorController::addDatabaseScriptResource): Add the script object for the database. (WebCore::InspectorController::removeDatabaseScriptResource): Remove the script object for the database. (WebCore::InspectorController::clearDatabaseScriptResources): Remove all the database resources. (WebCore::InspectorController::didCommitLoad): Call clearDatabaseScriptResources(). (WebCore::InspectorController::didOpenDatabase): Make a new InspectorDatabaseResource and add it to m_databaseResources.
  • page/InspectorController.h:
  • page/inspector/Database.js: Added.
  • page/inspector/DatabasePanel.js: Added.
  • page/inspector/ResourceCategory.js: Make resource categories assume less about the resource.
  • page/inspector/inspector.css: Add styles for the database panel.
  • page/inspector/inspector.html: Include DatabasePanel.js
  • page/inspector/inspector.js: Support for adding and removing Database resources.

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Tim Hatcher

Added support for Chrome prompts required by the Storage API

  • page/Chrome.cpp: (WebCore::Chrome::runDatabaseSizeLimitPrompt):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h:

2007-10-19 Brady Eidson <​beidson@apple.com>

Contributions and Review by Anders

Various SQLite tweaks in preparation for the storage API

  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::~SQLDatabase): (WebCore::SQLDatabase::authorizerFunction): Static callback from sqlite for authorizer functions (WebCore::SQLDatabase::setAuthorizer): (WebCore::SQLDatabase::lock): (WebCore::SQLDatabase::unlock):
  • loader/icon/SQLDatabase.h:
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Switch to prepare16_v2 (WebCore::SQLStatement::bindDouble): Added (WebCore::SQLStatement::bindValue): Bind a wrapped SQLValue object (described later) (WebCore::SQLStatement::bindParameterCount): Accessor to the sqlite3 API for validating statements
  • loader/icon/SQLStatement.h: (WebCore::SQLStatement::isPrepared):
  • platform/sql/SQLAuthorizer.cpp: Added. Fully virtual interface to implement your own SQLite authorizer
  • platform/sql/SQLAuthorizer.h: Added. (WebCore::SQLAuthorizer::~SQLAuthorizer): (WebCore::SQLAuthorizer::createTable): (WebCore::SQLAuthorizer::createTempTable): (WebCore::SQLAuthorizer::dropTable): (WebCore::SQLAuthorizer::dropTempTable): (WebCore::SQLAuthorizer::allowAlterTable): (WebCore::SQLAuthorizer::createIndex): (WebCore::SQLAuthorizer::createTempIndex): (WebCore::SQLAuthorizer::dropIndex): (WebCore::SQLAuthorizer::dropTempIndex): (WebCore::SQLAuthorizer::createTrigger): (WebCore::SQLAuthorizer::createTempTrigger): (WebCore::SQLAuthorizer::dropTrigger): (WebCore::SQLAuthorizer::dropTempTrigger): (WebCore::SQLAuthorizer::createView): (WebCore::SQLAuthorizer::createTempView): (WebCore::SQLAuthorizer::dropView): (WebCore::SQLAuthorizer::dropTempView): (WebCore::SQLAuthorizer::createVTable): (WebCore::SQLAuthorizer::dropVTable): (WebCore::SQLAuthorizer::allowDelete): (WebCore::SQLAuthorizer::allowInsert): (WebCore::SQLAuthorizer::allowUpdate): (WebCore::SQLAuthorizer::allowTransaction): (WebCore::SQLAuthorizer::allowSelect): (WebCore::SQLAuthorizer::allowRead): (WebCore::SQLAuthorizer::allowAttach): (WebCore::SQLAuthorizer::allowDetach): (WebCore::SQLAuthorizer::allowReindex): (WebCore::SQLAuthorizer::allowAnalyze): (WebCore::SQLAuthorizer::allowFunction):
  • platform/sql/SQLValue.cpp: Added. Contains a value for a SQLite database that can be one of a few types. For now, just a String or a double (WebCore::SQLValue::SQLValue): (WebCore::SQLValue::string): (WebCore::SQLValue::number):
  • platform/sql/SQLValue.h: Added. (WebCore::SQLValue::): (WebCore::SQLValue::SQLValue): (WebCore::SQLValue::type):

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Maciej

Changed IconDatabase over to use new FileSystem apis

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):

WebKit:

Reviewed by Tim Hatcher

Added support for Chrome prompts required by the Storage API
Added support API for future managing of databases from the WebKit client
Added preference and initialization for the databases path

  • Misc/WebDatabaseManager.h: Added. WebDatabaseManager is how a WebKit application can list and remove the current available databases
  • Misc/WebDatabaseManager.mm: Added. (+[WebDatabaseManager origins]): (+[WebDatabaseManager databasesWithOrigin:]): (+[WebDatabaseManager deleteAllDatabases]): (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]): (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]): (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
  • Misc/WebDatabaseManagerPrivate.h: Added.
  • WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for an origin exceeding its size limit
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runDatabaseSizeLimitPrompt):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
  • WebView/WebViewInternal.h:

WebKitSite:

Reviewed by Tim Hatcher

Sample database API usage

  • misc/DatabaseExample.html: Added.

WebKit/win:

Reviewed by Anders

Keep windows building with new Chrome additions

  • WebChromeClient.cpp:
  • WebChromeClient.h:
3:21 PM Changeset in webkit [26786] by kmccullo
  • 7 edits in trunk/WebKitTools

Reviewed by Oliver and Tim.

  • Made use of RetainPtr to avoid retain and release issues and moved the log function to DebuggerDocumentPlatform, which seems to be a more logical place for it to live.
  • Also moved knownServers from the ServerConnection to DebuggerApplication to match the Windows code and because it makes sense that a connection knows its own server but not all of them.
  • Drosera/mac/DebuggerClient.h: Moved the log function to DebuggerDocumentPlatform.
  • Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server Because it's owned by an own Ptr in DebuggerDocument. Also moved the call for the server name up from the ServerConnection class. (-[DebuggerClient dealloc]): (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call for the server name up from the ServerConnection.
  • Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog): Log directly from here. No need to call DebuggerClient.
  • Drosera/mac/ServerConnection.h: Removed the knownServers function. The way I see it, a ServerConnection should only know about its connection and the group of all possible servers should be kept by the application.
  • Drosera/mac/ServerConnection.mm: Removed knownServer but added currentServerName, it makes sense that the connection should know that name. (-[ServerConnection currentServerName]):
3:00 PM Changeset in webkit [26785] by hyatt
  • 2 edits in trunk/WebCore

Fix for ebay parser crash.

Reviewed by Beth

fast/invalid/table-residual-style-crash.html added as a test

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2:58 PM Changeset in webkit [26784] by hyatt
  • 4 adds in trunk/LayoutTests

Add new layout test for parser crash.

2:25 PM Changeset in webkit [26783] by zimmermann
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.
Try to fix Qt/Win build slave, by including windows.h also on Qt/Win.

2:17 PM Changeset in webkit [26782] by weinig
  • 3 edits in trunk/WebCore

Fix Windows, Qt and GTK builds.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
2:03 PM Changeset in webkit [26781] by zimmermann
  • 59 edits in trunk/LayoutTests

Rubberstamped by Oliver.

Land tiger baseline matching my MBP, as discussed with Oliver.
Mostly differences regarding the size of "(" / ")" characters.

1:53 PM Changeset in webkit [26780] by weinig
  • 21 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Encapsulate the same origin check into the new SecurityOrigin class.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::defaultEventHandler):
  • dom/Document.h: (WebCore::Document::securityOrigin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::setOpener):
  • loader/FrameLoader.h:
  • platform/SecurityOrigin.cpp: Added. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::clear): (WebCore::SecurityOrigin::isEmpty): (WebCore::SecurityOrigin::setForFrame): (WebCore::SecurityOrigin::setDomainFromDOM): (WebCore::SecurityOrigin::allowsAccessFrom): (WebCore::SecurityOrigin::isSecureTransitionTo):
  • platform/SecurityOrigin.h: Added.

LayoutTests:

Reviewed by Darin.

Update results after changing the warning message in isSafeScript to print the frame URL
rather than the security domain URL. This now also prints the warning when using data:
URLs because we no longer return early.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt:
1:04 PM Changeset in webkit [26779] by kmccullo
  • 9 edits
    3 adds
    2 deletes in trunk/WebKitTools

Reviewed by Adam.

  • Integrated changes from mac drosera. Recently I've encapsulated out the server connection object from the rest of Drosera because it is very platform dependent right now and RPC is not implemented on windows. This functionality, of communicating with the WebKit server is the next area I will be focusing on in Windows.
  • Other changes and cleanup were made to organize the code and add notes on which parts still need work. Also some mac code is added and commented out, to act as pseudocode for the logic of those parts.
  • Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart pointer.
  • Drosera/config.h: Added whitespace.
  • Drosera/win/DebuggerApplication.cpp: Removed. The functionality of these files got moved into Drosera.h/cpp
  • Drosera/win/DebuggerApplication.h: Removed.
  • Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring happened here to better match the logic flow of the same code on the mac side and to use the new ServerConnection class. (DebuggerClient::DebuggerClient): Constructor that takes a server name. (DebuggerClient::initWithServerName): Initializer that will set up the class to use a ServerConnection object. This was necessary so I could create a DebuggerClient without having to initilaize it at construction. (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client will be the UIDelegate and FrameLoadDelegate. (DebuggerClient::AddRef): For IUnknown. (DebuggerClient::Release): For IUnknown. (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate this still needs to set the global context of the server, but IWebFrame does not have an accessor for the global context yet. (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate this is a pass through for the same function in the document. (DebuggerClient::didReceiveTitle): Unimplemented part of FrameLoadDelegate this would change the title of the window. (DebuggerClient::createWebViewWithRequest): Part of the FrameLoadDelegate. This is about new windows via Window.open() and how their delegates are set. (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the UIDelegate. Just a debug function for printing messages.
  • Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h because the Client should be the UIDelegate and FrameLoadDelegate to match the delegates on mac. (DebuggerClient::webViewLoaded): Added accessor method.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently forgotten to add this file before. This is where the platform dependent versions of the Documents functions live. Most of these are unimplemented because some piece of functionality does not exist on Windows yet. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
  • Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate responsibilities becaue they belong in the Client. Also I laid the groundwork for attaching Drosera to a WebKit process (attachWndProc): Now if a server is selected the Client becomes it's delegate. (Drosera::Drosera): Added the construction of the Client and dictionary of server names. (Drosera::initUI): This is no longer the delegates, the Client is. (Drosera::webViewLoaded): Now asks the Client instead of holding local state. (Drosera::applicationDidFinishLaunching): Placeholder for needed notification registration when it's possible to implement. (Drosera::serverLoaded): Ditto (Drosera::serverUnloaded): Ditto (Drosera::attach): Attach Drosera to the WebKit server.
  • Drosera/win/Drosera.h: Ditto for Drosera.cpp comment. (Drosera::getInst): (Drosera::setInst): (Drosera::knownServers):
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication and added the ServerConnection.
  • Drosera/win/DroseraPrefix.h: Added an ifndef check.
  • Drosera/win/ServerConnection.cpp: Added. This is the interesting part Most of the functions are completely unimlemented because they cannot connect with the WebKit server, because one does not exist on Windows yet. (ServerConnection::initWithServerName): (ServerConnection::~ServerConnection): (ServerConnection::setGlobalContext): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::switchToServerNamed): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie): (ServerConnection::currentFrame):
  • Drosera/win/ServerConnection.h: Added. Ditto. (ServerConnection::ServerConnection):
11:12 AM Changeset in webkit [26778] by aliceli1
  • 1 edit in trunk/WebKitTools/ChangeLog

Reviewed by Darin.

Fix for these broken layout tests on Windows:


fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html
fast/forms/select-accesskey.html


  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): correct the VK code for alt key.
11:05 AM Changeset in webkit [26777] by aliceli1
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): correct the VK code for alt key.
10:51 AM Changeset in webkit [26776] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher


  • fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
  • History/WebHistory.mm: (-[WebHistoryPrivate removeAllItems]): This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition to the other places where it's cleared.
10:33 AM Changeset in webkit [26775] by mitz
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

removing a commented-out test and a test that no longer fails

  • platform/mac-leopard/Skipped:
10:14 AM Changeset in webkit [26774] by ddkilzer
  • 2 edits
    1 copy in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

Provide the functionality of js-test-post.js in a function named isSuccessfullyParsed().

  • fast/encoding/char-encoding.html: Updated to use js-test-post-function.js instead of local hack.
  • fast/js/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post.js. Modified to create isSuccessfullyParsed() function.
8:13 AM Changeset in webkit [26773] by hausmann
  • 4 edits in trunk

Fix the Qt/Windows build: Added missing FontSelector.h include and re-order moc inclusion.

7:46 AM Changeset in webkit [26772] by hausmann
  • 2 edits in trunk/WebCore

Qt/Windows build fix: Threading.h uses int32_t but doesn't include stdint.h.

7:14 AM Changeset in webkit [26771] by hausmann
  • 2 edits in trunk/JavaScriptCore

Fix compilation on Windows when wchar_t is a typedef instead of a native type (triggered by -Zc:wchar_t-).
Don't provide the wchar_t overloads then as they conflict with the unsigned short ones.

4:28 AM Changeset in webkit [26770] by hausmann
  • 2 edits in trunk/JavaScriptCore

Another build fix for the windows/qt build: Apply the same fix as in revision 26686 also to kjs/config.h to disable the disallowctype feature.

4:12 AM Changeset in webkit [26769] by hausmann
  • 3 edits in trunk/WebKit/qt

Fix the windows/qt build by including config.h first to fix wtf/MathExtras.h inclusion.

3:38 AM Changeset in webkit [26768] by hausmann
  • 2 edits in trunk/WebCore

Fix the qt/windows build.

1:58 AM Changeset in webkit [26767] by eseidel
  • 2 edits in trunk/WebKitTools

2007-10-19 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.


Make the GtkLauncher code slightly more readable.

  • GtkLauncher/main.cpp: (setupMainMenu): Added. (setupMainWindowUI): Added. (main):
1:01 AM Changeset in webkit [26766] by mjs
  • 2 edits in trunk/WebKitTools

Rubber stamped by Adam.


  • don't delay-load WebKit in DumpRenderTree.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
12:44 AM Manual Testing created by oliver@apple.com
Random manual tests

Oct 18, 2007:

10:10 PM Changeset in webkit [26765] by sfalken
  • 1 copy in tags/Safari-523.12.3b

New tag.

10:10 PM Changeset in webkit [26764] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

10:09 PM Changeset in webkit [26763] by sfalken
  • 2 edits in branches/Safari-3-branch/JavaScriptCore

Merged fix from r26760.

7:45 PM Changeset in webkit [26762] by mitz
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

removing tests that no longer fail

  • platform/mac-leopard/Skipped:
7:19 PM Changeset in webkit [26761] by justing
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Kevin McCullough.

<rdar://problem/5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks

  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): For selection preservation, we must emit a character between every VisiblePosition. We weren't emitting a space after some tables, because we won't try to emit a space if shouldEmitNewlineAFterNode is true, even if no newline was emitted.

LayoutTests:

Reviewed by Kevin McCullough.


<rdar://problem/5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks


Demonstrates fix for the hang:

  • editing/execCommand/5483526-expected.txt: Added.
  • editing/execCommand/5483526.html: Added.


Fixed selection endpoint (problems with selection painting prevent this
from being reflected in the pixel test results):

  • platform/mac/editing/execCommand/5432254-2-expected.txt:
7:14 PM Changeset in webkit [26760] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • use declspec(thread) for fast thread-local storage on Windows


  • 2.2% speedup on sunspider (on Windows)
  • 7% speedup on the string section
  • 6% speedup on JS iBench


  • fixed <rdar://problem/5473084> PLT on Windows got 2.5% slower between r25406 and r25422
  • fixed at least some of <rdar://5527965? i-Bench JS was 14% slower in 310A11 than 310A10



  • wtf/FastMalloc.cpp: (WTF::getThreadHeap): (WTF::setThreadHeap): (WTF::TCMalloc_ThreadCache::GetCache): (WTF::TCMalloc_ThreadCache::GetCacheIfPresent): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
5:49 PM Changeset in webkit [26759] by mitz
  • 2 edits in trunk/WebKit

Tiger build fix.

  • WebView/WebDataSource.mm: (-[WebDataSource _MIMETypeOfResponse:]):
5:33 PM Changeset in webkit [26758] by mitz
  • 13 edits in trunk

WebCore:

Reviewed by Adam Roben.

  • fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Work around <rdar://problem/5321972> by testing for the case of a response with a MIME type of application/octet-stream and a Content-Type header starting with text/plain and setting the MIME type to text/plain in that case.

WebKit:

Reviewed by Adam Roben.

  • fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
  • WebView/WebDataSource.mm: (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse with a MIMEType of application/octet-stream and a Content-Type header starting with text/plain and returning text/plain as the MIME type in that case. (-[WebDataSource _responseMIMEType]): Added. Used to get the correct response MIME type. (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType. (-[WebDataSource _makeRepresentation]): Ditto. (-[WebDataSource mainResource]): Ditto. (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and pass the MIME type explicitly. (-[WebDataSource subresourceForURL:]): Ditto.
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrameView.mm: (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use _responseMIMEType.
  • WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this method to take a MIME type instead of extracting it from the response, so that WebDataSource could pass the correct MIME type.
  • WebView/WebResourcePrivate.h:

WebKitTools:

Reviewed by Adam Roben.

  • fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump): Changed to use _responseMIMEType.

LayoutTests:

Reviewed by Adam Roben.

  • removing fixed test
  • platform/mac-leopard/Skipped:
4:11 PM Changeset in webkit [26757] by bdash
  • 2 edits in trunk/WebCore

2007-10-18 Mark Rowe <​mrowe@apple.com>

Fix the no-SVG build.

  • css/CSSPrimitiveValueMappings.h: Move the CSSPrimitiveValue implementations for LineCap, LineJoin and WindRule inside #if ENABLE(SVG).
2:59 PM Changeset in webkit [26756] by darin
  • 5 edits in trunk/WebCore

Reviewed by Anders.

  • some small tweaks to the threading implementation

I had trouble building on Windows. Either the problem went away by itself
or one of these changes fixed it.

  • platform/Threading.h: Eliminated the use of friend, and shared a single declaration for the initializeThreading function.
  • platform/pthreads/ThreadingPthreads.cpp: (WebCore::ThreadCondition::wait): Call impl() here.
  • platform/win/ThreadingWin.cpp: Got rid of two globals here with static constructors. Also added a typedef for the type of the function queue. (WebCore::functionQueueMutex): Added function. (WebCore::functionQueue): Ditto. (WebCore::callFunctionsOnMainThread): Use functions instead of using the globals directly. (WebCore::callOnMainThread): Ditto.
  • css/CSSParser.cpp: Had to touch this file to make things build.
2:35 PM Changeset in webkit [26755] by aroben
  • 2 edits in trunk/WebKit/win

Fix <rdar://5547784> ProgIDMacros.h should explicitly use wide strings

Reviewed by Adele.

  • ProgIDMacros.h: Always use wide strings instead of relying on the TEXT macro.
1:43 PM Changeset in webkit [26754] by sfalken
  • 1 copy in tags/Safari-523.12.2b

New tag.

1:43 PM Changeset in webkit [26753] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

1:29 PM Changeset in webkit [26752] by aroben
  • 3 edits
    1 add in branches/Safari-3-branch/WebCore

Merge r26751

1:26 PM Changeset in webkit [26751] by aroben
  • 3 edits
    1 add in trunk/WebCore

Fix <rdar://5547462> Need to copy Inspector resources in Production builds

I also added an excludes file for the xcopy command to avoid copying
.svn folders.

Reviewed by Geoff.

  • WebCore.vcproj/WebCore.make: Make sure we copy the Inspector resources.
  • WebCore.vcproj/WebCore.vcproj: Pass /exclude:xcopy.excludes to xcopy.
  • WebCore.vcproj/xcopy.excludes: Added.
10:00 AM Changeset in webkit [26750] by darin
  • 4 edits in trunk

WebCore:

Reviewed by Sam.

  • page/DOMWindow.idl: Add ConvertUndefinedOrNullToNullString back for defaultValue.

LayoutTests:

Reviewed by Sam.

  • fast/dom/Window/alert-undefined-expected.txt: Back to expecting empty string for default value.
9:44 AM Changeset in webkit [26749] by zimmermann
  • 2 edits in trunk/WebCore

Build fix. Not reviewed.
Hopefully fix win build by including wtf/MathExtras.h.

9:27 AM Changeset in webkit [26748] by sfalken
  • 1 copy in tags/Safari-523.12.1b

New tag.

9:27 AM Changeset in webkit [26747] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

9:21 AM Changeset in webkit [26746] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Nikolas Zimmermann.

Test: fast/text/word-break-soft-hyphen.html

  • rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths): Changed to treat soft hyphens as word boundaries. This fixes the bug and is consistent with the fact that run rounding does occur at soft hyphens.

LayoutTests:

Reviewed by Nikolas Zimmermann.

  • fast/text/word-break-soft-hyphen.html: Added.
  • platform/mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
  • platform/mac/fast/text/word-break-soft-hyphen-expected.png: Added.
  • platform/mac/fast/text/word-break-soft-hyphen-expected.txt: Added.
8:19 AM Changeset in webkit [26745] by zimmermann
  • 10 edits in trunk

Reviewed by Anders.

Fix last layout test failure seen on buildbot "trunk-mac-ppc-release".
Problem: "svg/custom/mask-excessive-malloc.svg -> crashed"

Clamp any ImageBuffer allocation within SVG to the RenderView's visibleSize
to avoid excessive mallocs (in the testcase above 1000000x1000000)

2:57 AM Changeset in webkit [26744] by ap
  • 2 edits in trunk/WebCore

Windows build fix.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Add braces around cases that have local variables now.
1:57 AM Changeset in webkit [26743] by ap
  • 2 edits in trunk/WebCore

Release build fix.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
1:39 AM Changeset in webkit [26742] by ap
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Split most of CSSPrimitiveValue enum mapping out of CSSComputedStyleDeclaration::getPropertyCSSValue()
and CSSStyleSelector::applyProperty() (and their SVG counterparts). This should make the code more readable.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getPositionOffsetValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::init):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSPrimitiveValueMappings.h: Added. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EBorderStyle): (WebCore::CSSPrimitiveValue::operator CompositeOperator): (WebCore::CSSPrimitiveValue::operator EAppearance): (WebCore::CSSPrimitiveValue::operator EBackgroundBox): (WebCore::CSSPrimitiveValue::operator EBackgroundRepeat): (WebCore::CSSPrimitiveValue::operator EBoxAlignment): (WebCore::CSSPrimitiveValue::operator EBoxDirection): (WebCore::CSSPrimitiveValue::operator EBoxLines): (WebCore::CSSPrimitiveValue::operator EBoxOrient): (WebCore::CSSPrimitiveValue::operator ECaptionSide): (WebCore::CSSPrimitiveValue::operator EClear): (WebCore::CSSPrimitiveValue::operator ECursor): (WebCore::CSSPrimitiveValue::operator EDisplay): (WebCore::CSSPrimitiveValue::operator EEmptyCell): (WebCore::CSSPrimitiveValue::operator EFloat): (WebCore::CSSPrimitiveValue::operator EKHTMLLineBreak): (WebCore::CSSPrimitiveValue::operator EListStylePosition): (WebCore::CSSPrimitiveValue::operator EListStyleType): (WebCore::CSSPrimitiveValue::operator EMarginCollapse): (WebCore::CSSPrimitiveValue::operator EMarqueeBehavior): (WebCore::CSSPrimitiveValue::operator EMarqueeDirection): (WebCore::CSSPrimitiveValue::operator EMatchNearestMailBlockquoteColor): (WebCore::CSSPrimitiveValue::operator ENBSPMode): (WebCore::CSSPrimitiveValue::operator EOverflow): (WebCore::CSSPrimitiveValue::operator EPageBreak): (WebCore::CSSPrimitiveValue::operator EPosition): (WebCore::CSSPrimitiveValue::operator EResize): (WebCore::CSSPrimitiveValue::operator ETableLayout): (WebCore::CSSPrimitiveValue::operator ETextAlign): (WebCore::CSSPrimitiveValue::operator ETextSecurity): (WebCore::CSSPrimitiveValue::operator ETextTransform): (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): (WebCore::CSSPrimitiveValue::operator EUserDrag): (WebCore::CSSPrimitiveValue::operator EUserModify): (WebCore::CSSPrimitiveValue::operator EUserSelect): (WebCore::CSSPrimitiveValue::operator EVisibility): (WebCore::CSSPrimitiveValue::operator EWhiteSpace): (WebCore::CSSPrimitiveValue::operator EWordBreak): (WebCore::CSSPrimitiveValue::operator EWordWrap): (WebCore::CSSPrimitiveValue::operator LineCap): (WebCore::CSSPrimitiveValue::operator LineJoin): (WebCore::CSSPrimitiveValue::operator TextDirection): (WebCore::CSSPrimitiveValue::operator WindRule): (WebCore::CSSPrimitiveValue::operator EAlignmentBaseline): (WebCore::CSSPrimitiveValue::operator EColorInterpolation): (WebCore::CSSPrimitiveValue::operator EColorRendering): (WebCore::CSSPrimitiveValue::operator EDominantBaseline): (WebCore::CSSPrimitiveValue::operator EImageRendering): (WebCore::CSSPrimitiveValue::operator EPointerEvents): (WebCore::CSSPrimitiveValue::operator EShapeRendering): (WebCore::CSSPrimitiveValue::operator ETextAnchor): (WebCore::CSSPrimitiveValue::operator ETextRendering): (WebCore::CSSPrimitiveValue::operator EWritingMode):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundAttachment): (WebCore::CSSStyleSelector::mapBackgroundClip): (WebCore::CSSStyleSelector::mapBackgroundComposite): (WebCore::CSSStyleSelector::mapBackgroundOrigin): (WebCore::CSSStyleSelector::mapBackgroundRepeat): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • ksvg2/css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
1:01 AM Changeset in webkit [26741] by mjs
  • 3 edits in trunk/SunSpider

Reviewed by Eric.


  • Support Windows and Windows browsers.
  • hosted/sunspider-results.html: Display results correctly in IE.
  • sunspider: tweaks to work on Windows, and with spaces in the path.
12:30 AM Changeset in webkit [26740] by eseidel
  • 6 edits
    2 adds in trunk

2007-10-18 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Fix crashers in SVGViewSpec::parseViewSpec
​http://bugs.webkit.org/show_bug.cgi?id=15504

Test is blocked by bug 15503, landed as:

  • svg/dom/viewspec-parser.html-disabled
  • bindings/scripts/CodeGeneratorObjC.pm: support classes where all parents are interfaces
  • ksvg2/svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • ksvg2/svg/SVGViewSpec.idl: Added.
12:27 AM Changeset in webkit [26739] by mjs
  • 2 edits in trunk/SunSpider

Rubber stamped by Oliver.

  • tests/string-tagcloud.js: Remove stray print()
12:17 AM Changeset in webkit [26738] by mjs
  • 2 edits
    3 adds in trunk/SunSpider

Reviewed by Oliver.


Add some string test cases.

  • tests/string-base64.js: Added. Does base64 encoding and decoding.
  • tests/string-tagcloud.js: Added. Parses a JSON string and generates tagcloud HTML markup based on the data.
  • tests/string-unpack-code.js: Added. Unpack compressed versions of four of the most popular JavaScript libraries.
  • tests/LIST: Added the new tests.
Note: See TracTimeline for information about the timeline view.