Context Navigation

← Previous Period
Next Period →

Timeline

Oct 20, 2007:

11:48 PM Changeset in webkit [26845] by hyatt

4 adds in trunk/LayoutTests/platform/mac/fast/transforms

Add new transforms directory along with an initial layout test.

11:44 PM Changeset in webkit [26844] by hyatt

2 adds in trunk/LayoutTests/fast/transforms

Add new transforms directory along with an initial layout test.

11:39 PM Changeset in webkit [26843] by hyatt

9 edits in trunk/WebCore

Land support for the transform CSS property. Basic painting now works properly. There are many open issues
that will have to be covered by individual bugs.

Reviewed by olliej

css/CSSParser.cpp: (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseTransform):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateTransform): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::childrenClipRect): (WebCore::RenderLayer::selfClipRect): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::boundingBox):
rendering/RenderLayer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
rendering/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
rendering/RenderStyle.h: (WebCore::TransformOperation::isScaleOperation): (WebCore::TransformOperation::isRotateOperation): (WebCore::TransformOperation::isSkewOperation): (WebCore::TransformOperation::isTranslateOperation): (WebCore::TransformOperation::isMatrixOperation): (WebCore::ScaleTransformOperation::isScaleOperation): (WebCore::RotateTransformOperation::isRotateOperation): (WebCore::SkewTransformOperation::isSkewOperation): (WebCore::TranslateTransformOperation::isTranslateOperation): (WebCore::MatrixTransformOperation::isMatrixOperation):
rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
rendering/RenderTreeAsText.cpp: (WebCore::writeLayers):

11:36 PM Changeset in webkit [26842] by thatcher

6 edits in trunk/WebCore

Reviewed by Adam.

Add basic @font-face to the Web Inspector.

page/InspectorController.cpp: (WebCore::InspectorResource::type): Check for CachedResource::FontResource.
page/inspector/Resource.js: Add support for Font types and font preview in the icon.
page/inspector/ResourcePanel.js: Show a font preview for font resources.
page/inspector/inspector.css: Style for the font preview and font icon.
page/inspector/inspector.js: Add font mime types.

10:19 PM Changeset in webkit [26841] by weinig

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Fixes:

http://bugs.webkit.org/show_bug.cgi?id=14393 Column on the left side of the Web Inspector should have a smaller minimum width for resizing
http://bugs.webkit.org/show_bug.cgi?id=14394 Left pane of the Web Inspector "shakes" when resizing it to maximum width

page/inspector/inspector.js: Change the constraint logic to only enforce a 100px min-width and window.innerWidth - 100 max-width for the sidebar. The change also makes the viewbuttons move with the sidebar.

9:00 PM Changeset in webkit [26840] by mitz

7 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=15208 display:table causes the collapsed text to show at a different position when expanded

Test: fast/table/insert-before-anonymous-ancestors.html

rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Rolled out r11579. I think whatever that change was supposed to accomplish has since been done in other places in the code.

LayoutTests:

Reviewed by Dave Hyatt.

test and updated results for http://bugs.webkit.org/show_bug.cgi?id=15208 display:table causes the collapsed text to show at a different position when expanded

fast/table/form-in-table-before-misnested-text-crash-css-expected.txt:
fast/table/form-in-table-before-misnested-text-crash-expected.txt:
fast/table/insert-before-anonymous-ancestors.html: Added.
fast/table/section-in-table-before-misnested-text-crash-css-expected.txt:
fast/table/section-in-table-before-misnested-text-crash-expected.txt:
platform/mac/fast/table/insert-before-anonymous-ancestors-expected.checksum: Added.
platform/mac/fast/table/insert-before-anonymous-ancestors-expected.png: Added.
platform/mac/fast/table/insert-before-anonymous-ancestors-expected.txt: Added.

8:06 PM Changeset in webkit [26839] by eseidel

2 edits in trunk/WebKitTools

2007-10-20 Eric Seidel <eric@webkit.org>

Reviewed by aroben.

Scripts/find-extra-includes: fix path matching regex to not match ".patch"

7:43 PM Changeset in webkit [26838] by eseidel

8 edits
1 add in trunk

2007-10-20 Eric Seidel <eric@webkit.org>

Reviewed by darin.

Add improved argument handling to run-sunspider, including
--runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
Also re-factor code into subroutines

Scripts/build-dumprendertree: removed bogus comments
Scripts/build-testkjs: Added.
Scripts/run-javascriptcore-tests: use build-testkjs
Scripts/run-sunspider: improved argument handling, abstraction
Scripts/run-webkit-tests: improved abstraction

7:41 PM Changeset in webkit [26837] by bdash

2 edits in trunk/WebCore

2007-10-20 Mark Rowe <mrowe@apple.com>

Reviewed by Dave Hyatt.

Fix http://bugs.webkit.org/show_bug.cgi?id=15584
Bug 15584: REGRESSION(r26696): GtkLauncher segfaults on WebCore::WidthIterator::advance

platform/Font.cpp: (WebCore::Font::glyphDataForCharacter): If the fallback page exists but does not have a glyph for the character, fall back to the missing glyph data rather than returning an invalid GlyphData.

4:01 PM Changeset in webkit [26836] by mjs

3 edits
6 adds in trunk/SunSpider

Reviewed by Mark.

Add more new tests, mostly from the computer language shootout. Not normalized yet.

TODO:
tests/LIST:
tests/access-binary-trees.js: Added.
tests/access-nsieve.js: Added.
tests/bitops-nsieve-bits.js: Added.
tests/math-partial-sums.js: Added.
tests/math-spectral-norm.js: Added.
tests/string-fasta.js: Added.

3:54 PM Changeset in webkit [26835] by bdash

2 edits in trunk/WebCore

2007-10-20 Jasper Bryant-Greene <m@ni.ac.nz>

Reviewed by Maciej.

Changed the hard-coded scroll delta in WheelEventGtk from 120 to 0.25,
as suggested by George Wright in #15108 (which this patch will
resolve).

This gives a more sane scrolling behaviour, rather than the
jumping to the end or start of the document as occurred previously.

platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

3:43 PM Changeset in webkit [26834] by mjs

1 edit in trunk/SunSpider/ChangeLog

Fix reviewer in ChangeLog.

3:42 PM Changeset in webkit [26833] by mjs

9 edits in trunk/SunSpider

Reviewed by Eric.

TODO: Updated to note areas that are now well-covered.

Change the tests and the driver to avoid leaving large object graphs hanging around, since that throws off the subsequent tests.

resources/sunspider-standalone-driver.js:
tests/3d-cube.js:
tests/3d-morph.js:
tests/3d-raytrace.js:
tests/bitops-bitwise-and.js:
tests/string-base64.js:
tests/string-tagcloud.js:

3:38 PM Changeset in webkit [26832] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15579 stop churning identifier reference counts copying Completion objects

kjs/completion.h: Replace the Identifier with an Identifier*.
kjs/nodes.cpp: (ForInNode::execute): Update for change to Completion constructor. (ContinueNode::execute): Ditto. (BreakNode::execute): Ditto.

3:10 PM Changeset in webkit [26831] by alp

4 edits
1 move
2 adds in trunk/WebCore

2007-10-20 Alp Toker <alp@atoker.com>

Reviewed by Eric.

Support text boundary detection.
Move TextBoundariesWin.cpp to platform/ since it's portable and useful.
Split out and implement some TemporaryLinkStubs.

WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
platform/TextBoundariesICU.cpp: Copied from WebCore/platform/win/TextBoundariesWin.cpp.
platform/gtk/Language.cpp: Added. (WebCore::defaultLanguage):
platform/gtk/TemporaryLinkStubs.cpp:
platform/gtk/TextBreakIteratorInternalICUGtk.cpp: Added. (WebCore::currentTextBreakLocaleID):
platform/win/TextBoundariesWin.cpp: Removed.

2:00 PM Changeset in webkit [26830] by bdash

2 edits in trunk/WebCore

2007-10-20 Mark Rowe <mrowe@apple.com>

Reviewed by Tim Hatcher.

Workaround for http://bugs.webkit.org/show_bug.cgi?id=15574
Bug 15574: Web Inspector doesn't work with the new Database feature

The executeSql callback is executed in the security domain of the web page that owns the database,
while the inspector's window object is in the callback functions scope chain. This is leading to a
security violation when the callback attempts to access "document". We can work around this by
ensuring that "document" can be found in the scope chain before the window object.

page/inspector/DatabasePanel.js:

11:57 AM Changeset in webkit [26829] by pewtermoose

2 edits in trunk/WebKitTools

Windows build fix

11:25 AM Changeset in webkit [26828] by bdash

2 edits
2 adds
2 deletes in trunk/WebKitSite

2007-10-20 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Adam.

Convert TIFFs to PNGs so that the demo page is fully-functional in the Gtk port.

misc/DatabaseExample.html:
misc/deleteButton.png: Added.
misc/deleteButton.tiff: Removed.
misc/deleteButtonPressed.png: Added.
misc/deleteButtonPressed.tiff: Removed.

10:30 AM Changeset in webkit [26827] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15567 speed up hashing const char* by removing call to strlen

This includes one other fix as well. Both were from a day where I did some
profiling to find hot spots when running the page load test.

platform/StringImpl.cpp: (WebCore::StringImpl::computeHash): Compute the hash without calling strlen. Also change the argument names to not confusingly use m_ prefixes. (WebCore::StringImpl::createStrippingNull): Added a faster case for strings that don't have null.

10:29 AM Changeset in webkit [26826] by darin

5 edits in trunk

WebKitTools:

Reviewed by Tim Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=15544 <rdar://problem/5076426> fast/events/arrow-navigation.html needs to not rely on Apple-specific key codes

DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]): Added named key "rightArrow". Later we could have a whole table of these. Also tweaked modifiers code a little.

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.

LayoutTests:

Reviewed by Tim Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=15544 <rdar://problem/5076426> fast/events/arrow-navigation.html needs to not rely on Apple-specific key codes

fast/events/arrow-navigation.html: Use "rightArrow" instead.

10:26 AM Changeset in webkit [26825] by darin

3 edits in trunk/WebKitTools

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=15566 possible fix for leak seen in DumpRenderTree

DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue): Delete the item if it's not put on the queue, since the caller has no way of knowing that. Would be better to have the parameter type be auto_ptr to express the fact that we take ownership.

unrelated change

Drosera/mac/main.m: Add missing include.

6:54 AM Changeset in webkit [26824] by bdash

7 edits in trunk

2007-10-20 Mark Rowe <mrowe@apple.com>

Reviewed by Alp.

Gtk changes needed to enable HTML 5 client-side database storage.

JavaScriptCore:

wtf/Platform.h: Have Gtk use pthreads for now.

WebCore:

WebCore.pro: Have Gtk use ThreadingPthreads.cpp.
platform/pthreads/ThreadingPthreads.cpp: Include errno so that EDEADLK and EBUSY are available.

WebKit/gtk:

Api/webkitgtkglobal.cpp: Set a default database path based on the user data directory. This should become configurable by client applications in the future.

6:01 AM Changeset in webkit [26823] by bdash

3 edits
1 add in trunk/WebCore

2007-10-20 Mark Rowe <mrowe@apple.com>

Reviewed by Alp.

Implement callOnMainThread for Gtk+ via a one-shot zero-delay timer that will be dispatched
from the main event loop.

WebCore.pro:
platform/gtk/TemporaryLinkStubs.cpp:
platform/gtk/ThreadingGtk.cpp: Added. (WebCore::callFunctionOnMainThread): (WebCore::callOnMainThread):

6:00 AM Changeset in webkit [26822] by bdash

2 edits in trunk/WebKit/gtk

2007-10-20 Mark Rowe <mrowe@apple.com>

Reviewed by Eric.

Don't allow control characters to be inserted into editable regions.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):

5:55 AM Changeset in webkit [26821] by zimmermann

13 edits in trunk

Reviewed by Eric.

Fix non-functional display="inline" / display="none" for SVG text.

Fixes: svg/W3C-SVG-1.1/animate-elem-39-t.svg (display="inline" support)
Fixes: svg/batik/text/textProperties2.svg (display="inline/none" support)
Fixes: svg/carto.net/tabgroup.svg (display="none" support, stray content before layouting)

4:17 AM Changeset in webkit [26820] by bdash

2 edits
1 add in trunk/WebCore

2007-10-20 Mark Rowe <mrowe@apple.com>

Reviewed by Alp.

Replace #ifdef'd code with the appropriate use of a forwarding header.

ForwardingHeaders/kjs/array_instance.h: Added.
bindings/js/JSDatabaseCustom.cpp:

3:37 AM Changeset in webkit [26819] by zimmermann

21 edits in trunk

Reviewed by Oliver.

Add support for 'kerning' property in SVG text layout code.
Support all textLength/lengthAdjust modes on normal text & textPaths.

Support letter & word spacing on textPath.
Fix text selection when any spacing (letter/word/kerning) is involved.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15571
Fixes: svg/batik/text/textOnPathSpaces.svg (spacing)

svg/batik/text/textLayout.svg (kerning support)
svg/text/text-spacing-01-b.svg (text selection)

3:37 AM Changeset in webkit [26818] by aroben

1 edit in trunk/WebKitSite/misc/DatabaseExample.html

Fix typo

3:30 AM Changeset in webkit [26817] by aroben

2 edits
2 adds in trunk/WebKitSite

Make the notes sticky!

Reviewed by Mark.

misc/DatabaseExample.html:
misc/deleteButton.tiff: Added.
misc/deleteButtonPressed.tiff: Added.

3:20 AM Changeset in webkit [26816] by bdash

10 edits in trunk/WebCore

2007-10-20 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewd by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15563
Fix conflict with X11 Window type in WebCore

WebCore/bindings/js/JSDocumentCustom.cpp:
WebCore/bindings/js/JSHTMLDocumentCustom.cpp:
WebCore/bindings/js/JSHTMLFrameSetElementCustom.cpp:
WebCore/bindings/js/kjs_dom.cpp:
WebCore/bindings/js/kjs_events.cpp:
WebCore/bindings/js/kjs_proxy.cpp:
WebCore/history/CachedPage.cpp:
WebCore/page/Chrome.cpp:
WebCore/page/Frame.cpp:

2:45 AM Changeset in webkit [26815] by hausmann

2 edits in trunk/WebCore

Fix the Qt build.

1:51 AM Changeset in webkit [26814] by mjs

10 edits in trunk/SunSpider

Reviewed by Nikolas.

Rebalance test complexity.

Scaled all the tests so they take 400-600ms on a reasonably normal user setup:

Internet Explorer 7, Window XP, Dell Latitude D810 with a 2.13GHz Pentium M

However, for some tests, IE7 was a huge outlier compared to other
major browsers. For those tests, I used Firefox 2.0.0.8 on the
same OS and hardware as a normalization basis.

tests/3d-morph.js:
tests/3d-raytrace.js:
tests/bitops-3bit-bits-in-byte.js:
tests/bitops-bits-in-byte.js:
tests/bitops-bitwise-and.js:
tests/math-cordic.js:
tests/string-base64.js:
tests/string-tagcloud.js:
tests/string-unpack-code.js:

1:11 AM Changeset in webkit [26813] by mjs

2 edits in trunk/SunSpider

Reviewed by Oliver.

Fix the browser-hosted driver to be compatible with Safari 2

hosted/sunspider-driver.html:

1:05 AM Changeset in webkit [26812] by mjs

2 edits in trunk/SunSpider

Rubber stamped by Hyatt.

Add BSD license notice to cordic test, the original author said to do so.

tests/math-cordic.js:

12:11 AM Changeset in webkit [26811] by ggaren

3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Fixed http://bugs.webkit.org/show_bug.cgi?id=15570
Store gathered declaration nodes in the function body node.

This means that you only have to gather the declaration nodes the first
time the function executes. Performance gain of 2.10% on SunSpider,
0.90% on command-line JS iBench.

kjs/nodes.cpp: Split declaration stack initialization code off into initializeDeclarationStacks(). (FunctionBodyNode::FunctionBodyNode): (FunctionBodyNode::initializeDeclarationStacks): (FunctionBodyNode::processDeclarations):

kjs/nodes.h: Changed DeclarationStacks structure to hold references, since the actual Vectors are now stored either on the stack or in the function body node.

Oct 19, 2007:

10:37 PM Changeset in webkit [26810] by alp

10 edits in trunk

2007-10-19 Alp Toker <alp@atoker.com>

Reviewed by Oliver.

GTK+ build fix enabling the new local database storage feature.
There is also a prospective Qt build fix.

10:20 PM Changeset in webkit [26809] by ggaren

1 edit in trunk/JavaScriptCore/ChangeLog

Added Bugzilla link to ChangeLog

10:18 PM Changeset in webkit [26808] by ggaren

6 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

To improve encapsulation, moved processDeclarations call into
FunctionBodyNode::execute. Also marked processDeclarations
ALWAYS_INLINE, since it has only 1 caller now. This is a .71% speedup
on command-line JS iBench.

kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
kjs/function.h:
kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
kjs/nodes.cpp: (FunctionBodyNode::execute):
kjs/nodes.h:

9:39 PM JavaScript performance improvement ideas edited by mjs@apple.com

(diff)

9:35 PM JavaScript performance improvement ideas edited by mjs@apple.com

(diff)

9:10 PM Changeset in webkit [26807] by aroben

2 edits in branches/Safari-3-branch/WebKitTools

Merge r26766

9:08 PM Changeset in webkit [26806] by andrew

2 edits in trunk/WebCore

Reviewed by Brady Eidson.

Mac build fix.

WebCore.xcodeproj/project.pbxproj:

8:09 PM Changeset in webkit [26805] by oliver

2 edits in trunk/LayoutTests

Updating window properties to include new features from HTML5 database support

RS=Mark

fast/dom/Window/window-properties-expected.txt:

7:20 PM Changeset in webkit [26804] by thatcher

2 edits in trunk/WebKitSite

Reviewed by Mark Rowe.

Fix a couple of exceptions for first time users.

misc/DatabaseExample.html:

6:48 PM Changeset in webkit [26803] by alp

3 edits in trunk/WebCore

2007-10-19 Alp Toker <alp@atoker.com>

Reviewed by Oliver.

Use platform colors for text selection.
Update the cache when the GTK style is changed.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkStyleSet): (WebCore::RenderThemeGtk::gtkEntry):
platform/gtk/RenderThemeGtk.h:

6:18 PM Changeset in webkit [26802] by adele

3 edits
4 adds in trunk

WebCore:

Reviewed by Beth.

Fix for: <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com

Test: fast/forms/menulist-no-overflow.html

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Don't allow overflow on menu lists.

LayoutTests:

Reviewed by Beth.

Test for <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com

fast/forms/menulist-no-overflow.html: Added.
platform/mac/fast/forms/menulist-no-overflow-expected.checksum: Added.
platform/mac/fast/forms/menulist-no-overflow-expected.png: Added.
platform/mac/fast/forms/menulist-no-overflow-expected.txt: Added.

6:06 PM Changeset in webkit [26801] by andersca

3 edits
6 moves in trunk/WebCore

Reviewed by Brady.

Move some SQL-related classes to platform/sql.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
loader/icon/SQLDatabase.cpp: Removed.
loader/icon/SQLDatabase.h: Removed.
loader/icon/SQLStatement.cpp: Removed.
loader/icon/SQLStatement.h: Removed.
loader/icon/SQLTransaction.cpp: Removed.
loader/icon/SQLTransaction.h: Removed.
platform/sql/SQLDatabase.cpp: Copied from loader/icon/SQLDatabase.cpp.
platform/sql/SQLDatabase.h: Copied from loader/icon/SQLDatabase.h.
platform/sql/SQLStatement.cpp: Copied from loader/icon/SQLStatement.cpp.
platform/sql/SQLStatement.h: Copied from loader/icon/SQLStatement.h.
platform/sql/SQLTransaction.cpp: Copied from loader/icon/SQLTransaction.cpp.
platform/sql/SQLTransaction.h: Copied from loader/icon/SQLTransaction.h.

5:49 PM Changeset in webkit [26800] by andersca

2 edits in trunk/WebKitSite

Reviewed by Brady.

Make example actually work.

misc/DatabaseExample.html:

5:45 PM Changeset in webkit [26799] by andersca

6 edits in trunk

WebCore:

Reviewed by Adam.

Update to match the latest version of the spec. Now, executeSQL takes an array
of SQL parameters instead of them being passed as arguments.

bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::executeSql):
page/inspector/DatabasePanel.js:
storage/Database.idl:

WebKitSite:

Reviewed by Adam.

Update example.

misc/DatabaseExample.html:

5:38 PM Changeset in webkit [26798] by kmccullo

2 edits in trunk/WebKitTools

Reviewed by Adam.

This change should be identical but for some reason was not working on my machine.

Scripts/prepare-ChangeLog:

5:22 PM Changeset in webkit [26797] by beidson

6 edits in trunk

WebCore:

Reviewed by Tim

Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(

storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker):

WebKitSite:

Reviewed by Tim

Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(

misc/DatabaseExample.html:

4:57 PM Changeset in webkit [26796] by andersca

2 edits in trunk/WebCore

Release build fix.

WebCore.vcproj/WebCore.vcproj:

4:42 PM Changeset in webkit [26795] by sfalken

1 copy in tags/Safari-523.12.5b

New tag.

4:42 PM Changeset in webkit [26794] by sfalken

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

4:37 PM Changeset in webkit [26793] by beidson

2 edits in trunk/WebCore

Remove stray printfs

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):

4:36 PM Changeset in webkit [26792] by andersca

2 edits in trunk/WebCore

Reviewed by Brady.

Apparently the Win32 pthreads impl we use does not allow unlocking a mutex that has not
already been locked, so lock the mutex first.

storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):

4:34 PM Changeset in webkit [26791] by beidson

2 edits in trunk/WebCore

Better build fix

loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction): Definite works by 3.3.13

4:25 PM Changeset in webkit [26790] by beidson

2 edits in trunk/WebCore

Build fix

loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction): I don't know *when* these constants were added to SQLite, but I know they were by 3.4.0

3:55 PM Changeset in webkit [26789] by sfalken

1 copy in tags/Safari-523.12.4b

New tag.

3:55 PM Changeset in webkit [26788] by sfalken

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

3:50 PM Changeset in webkit [26787] by beidson

48 edits
24 copies
34 adds in trunk

JavaScriptCore:

2007-10-19 Brady Eidson <beidson@apple.com>

Reviewed by Sam

Queue -> Deque! and small style tweaks

JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
wtf/Deque.h: Added. (WTF::DequeNode::DequeNode): (WTF::Deque::Deque): (WTF::Deque::~Deque): (WTF::Deque::size): (WTF::Deque::isEmpty): (WTF::Deque::append): (WTF::Deque::prepend): (WTF::Deque::first): (WTF::Deque::last): (WTF::Deque::removeFirst): (WTF::Deque::clear):
wtf/Queue.h: Removed.

2007-10-19 Brady Eidson <beidson@apple.com>

Reviewed by Oliver

Added a simple LinkedList based Queue to wtf
We can make a better, more sophisticated an efficient one later, but have
needed one for some time, now!

JavaScriptCore.xcodeproj/project.pbxproj:
wtf/Queue.h: Added. (WTF::QueueNode::QueueNode): (WTF::Queue::Queue): (WTF::Queue::~Queue): (WTF::Queue::size): (WTF::Queue::isEmpty): (WTF::Queue::append): (WTF::Queue::prepend): (WTF::Queue::first): (WTF::Queue::last): (WTF::Queue::removeFirst): (WTF::Queue::clear):

WebCore:
2007-10-19 Brady Eidson <beidson@apple.com>

Reviewed by Anders

Windows specific changes, as well as renaming Queue -> Deque

ForwardingHeaders/wtf/Deque.h: Added.
ForwardingHeaders/wtf/Queue.h: Removed.
platform/win/FileSystemWin.cpp: (WebCore::fileSize): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath):
storage/Database.h:
storage/DatabaseThread.cpp: (WebCore::DatabaseThread::documentGoingAway): (WebCore::DatabaseThread::databaseGoingAway): (WebCore::DatabaseThread::dispatchNextTaskIdentifier): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask):
storage/DatabaseThread.h:

2007-10-19 Brady Eidson <beidson@apple.com>

Reviewed by Tim and Anders

Preliminary support for HTML5 local database storage (http://www.whatwg.org/specs/web-apps/current-work/)

The specification is still in flux but the fundamentals are pretty solid and we can start using and testing
this implementation even while filing bugs to track changes in the spec as it becomes more final

There are some implementation details in this patch that seem unused or useless, but they remain in place
while the spec is in flux and might go one way or another.

platform/Logging.cpp: Add StorageAPI logging channel
platform/Logging.h:

storage/Database.cpp: Added. (WebCore::Database::databaseInfoTableName): (WebCore::databaseVersionKey): (WebCore::Database::openDatabase): C++ version of the window.openDatabase() javascript API (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::retrieveTextResultFromDatabase): (WebCore::Database::getVersionFromDatabase): (WebCore::setTextValueInDatabase): (WebCore::Database::setVersionInDatabase): (WebCore::Database::databaseThreadGoingAway): May be removed in the future (WebCore::Database::disableAuthorizer): For internal (WebInspector) use to get around the authorizer's restrictions (WebCore::Database::enableAuthorizer): (WebCore::Database::guidForOriginAndName): Candidate for refactoring and/or moving to the database tracker. The GUID for each database identifier is currently for tracking the database version, but might be rescoped in the future (WebCore::Database::resetAuthorizer): (WebCore::Database::performPolicyChecks): Currently, the only post-executeSql policy check planned is the origin size usage (WebCore::Database::scheduleDatabaseCallback): (WebCore::Database::performOpenAndVerify): (WebCore::Database::performChangeVersion): (WebCore::Database::performExecuteSql): (WebCore::Database::performCloseTransaction): (WebCore::Database::performGetTableNames): (WebCore::Database::version): C++ version of the javascript API (WebCore::Database::changeVersion): Ditto (WebCore::Database::executeSql): Ditto (WebCore::Database::closeTransaction): Ditto (WebCore::Database::tableNames): For internal (WebInspector) use (WebCore::Database::deliverAllPendingCallbacks): (WebCore::Database::deliverPendingCallbacks):
storage/Database.h: Added. (WebCore::Database::databaseDebugName): For debug logging purposes
storage/Database.idl: Added.

storage/DatabaseAuthorizer.cpp: Added. The DatabaseAuthorizer is used to both prevent the script from doing "illegal" things in sql as well as tracking when effects certain sql statements might have (such as increasing the size of the database) (WebCore::DatabaseAuthorizer::DatabaseAuthorizer): (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::createTempTable): (WebCore::DatabaseAuthorizer::dropTable): (WebCore::DatabaseAuthorizer::dropTempTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTempIndex): (WebCore::DatabaseAuthorizer::dropIndex): (WebCore::DatabaseAuthorizer::dropTempIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createTempTrigger): (WebCore::DatabaseAuthorizer::dropTrigger): (WebCore::DatabaseAuthorizer::dropTempTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::dropVTable): (WebCore::DatabaseAuthorizer::allowDelete): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate): (WebCore::DatabaseAuthorizer::allowRead): (WebCore::DatabaseAuthorizer::allowAnalyze): (WebCore::DatabaseAuthorizer::allowPragma): (WebCore::DatabaseAuthorizer::allowAttach): (WebCore::DatabaseAuthorizer::allowDetach): (WebCore::DatabaseAuthorizer::allowFunction): (WebCore::DatabaseAuthorizer::disable): (WebCore::DatabaseAuthorizer::enable): (WebCore::DatabaseAuthorizer::denyBasedOnTableName): Don't allow access to the WebKit meta info table as it should be invisible to scripts
storage/DatabaseAuthorizer.h: Added. (WebCore::DatabaseAuthorizer::lastActionWasInsert): (WebCore::DatabaseAuthorizer::lastActionIncreasedSize):

storage/DatabaseCallback.cpp: Added. Generic item to queue up for callbacks on the main thread for database activities that take place on a secondary thread (WebCore::DatabaseChangeVersionCallback::DatabaseChangeVersionCallback): (WebCore::DatabaseChangeVersionCallback::performCallback): (WebCore::DatabaseExecuteSqlCallback::DatabaseExecuteSqlCallback): (WebCore::DatabaseExecuteSqlCallback::performCallback):
storage/DatabaseCallback.h: Added. (WebCore::DatabaseCallback::~DatabaseCallback): (WebCore::DatabaseChangeVersionCallback::~DatabaseChangeVersionCallback): (WebCore::DatabaseExecuteSqlCallback::~DatabaseExecuteSqlCallback):

storage/DatabaseTask.h: Added. Generic work-item to be queued up on the background database thread (WebCore::DatabaseTask::isComplete): (WebCore::DatabaseOpenTask::exceptionCode): (WebCore::DatabaseOpenTask::openSuccessful): (WebCore::DatabaseTableNamesTask::tableNames):
storage/DatabaseTask.cpp: Added. (WebCore::DatabaseTask::DatabaseTask): (WebCore::DatabaseTask::~DatabaseTask): (WebCore::DatabaseTask::performTask): (WebCore::DatabaseTask::lockForSynchronousScheduling): Used when the main thread needs this task accomplished synchronously (WebCore::DatabaseTask::waitForSynchronousCompletion):

(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):

(WebCore::DatabaseExecuteSqlTask::DatabaseExecuteSqlTask):
(WebCore::DatabaseExecuteSqlTask::doPerformTask):

(WebCore::DatabaseChangeVersionTask::DatabaseChangeVersionTask):
(WebCore::DatabaseChangeVersionTask::doPerformTask):

(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseTableNamesTask::doPerformTask):

storage/DatabaseThread.cpp: Added. The current design is that each Document will have its own DatabaseThread. This makes scripts on each individual document more response at the cost of adding more threads and potentially creating concurrency issues when the same database is open twice from two different documents (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::~DatabaseThread): (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::documentGoingAway): Called to shut the thread down when the document is destroyed (WebCore::DatabaseThread::databaseGoingAway): Remove all pending tasks for this database (WebCore::DatabaseThread::databaseThreadStart): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::dispatchNextTaskIdentifier): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask): Schedule a task that gets to "cut to the front of the line" when the main thread requires a task be performed synchronously (WebCore::DatabaseThread::wakeWorkThread):
storage/DatabaseThread.h: Added.

storage/DatabaseTracker.cpp: Added. The DatabaseTracker is the master management of all databases. It will keep track of the filename for a given unique database, keep track of the total disk usage per-origin, and policys per database/origin (WebCore::DatabaseTracker::setDatabasePath): (WebCore::DatabaseTracker::databasePath): (WebCore::DatabaseTracker::tracker): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteAllDatabasesForOrigin):
storage/DatabaseTracker.h: Added.

storage/SQLCallback.h: Added. C++ version of the javascript executeSql() callback (WebCore::SQLCallback::~SQLCallback):
storage/SQLCallback.idl: Added.

storage/SQLResultSet.cpp: Added. C++ version of the javascript SQLResultSet object (WebCore::SQLResultSet::SQLResultSet): (WebCore::SQLResultSet::insertId): (WebCore::SQLResultSet::rowsAffected): (WebCore::SQLResultSet::errorCode): (WebCore::SQLResultSet::error): (WebCore::SQLResultSet::rows): (WebCore::SQLResultSet::setInsertId): (WebCore::SQLResultSet::setRowsAffected): (WebCore::SQLResultSet::setErrorCode): (WebCore::SQLResultSet::setErrorMessage):
storage/SQLResultSet.h: Added.
storage/SQLResultSet.idl: Added.

storage/SQLResultSetRowList.cpp: Added. C++ version of the javascript SQLResultSetRowList object (WebCore::SQLResultSetRowList::length):
storage/SQLResultSetRowList.h: Added. (WebCore::SQLResultSetRowList::columnNames): (WebCore::SQLResultSetRowList::values): (WebCore::SQLResultSetRowList::addColumn): (WebCore::SQLResultSetRowList::addResult):
storage/SQLResultSetRowList.idl: Added.

storage/VersionChangeCallback.h: Added. C++ version of the javascript changeVersion() callback (WebCore::VersionChangeCallback::~VersionChangeCallback):
storage/VersionChangeCallback.idl: Added.

2007-10-19 Brady Eidson <beidson@apple.com>

Reviewed by Oliver + Same

Forwarding header for the new wtf/Queue.h

ForwardingHeaders/wtf/Queue.h: Added.

2007-10-19 Anders Carlsson <beidson@apple.com>

Reviewed by Sam Weinig

Most of the Javascript binding support for the Storage API

bindings/js/JSCustomSQLCallback.cpp: Added. (WebCore::JSCustomSQLCallback::JSCustomSQLCallback): (WebCore::JSCustomSQLCallback::handleEvent):
bindings/js/JSCustomSQLCallback.h: Added. Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches handleEvent to a JS function or a JS object with a handleEvent function.

bindings/js/JSCustomVersionChangeCallback.cpp: Added. (WebCore::JSCustomVersionChangeCallback::JSCustomVersionChangeCallback): (WebCore::JSCustomVersionChangeCallback::handleEvent):
bindings/js/JSCustomVersionChangeCallback.h: Added. Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches handleEvent to a JS function or a JS object with a handleEvent function.

bindings/js/JSDatabaseCustom.cpp: Added. (WebCore::JSDatabase::executeSql): Custom implementation of executeSql that takes an array of parameters.

(WebCore::JSDatabase::changeVersion):

Custom implementation of changeVersion.

bindings/js/JSSQLResultSetRowListCustom.cpp: Added. (WebCore::JSSQLResultSetRowList::item): Custom method that returns a JS object that corresponds to a given row in the database.

bindings/scripts/CodeGeneratorJS.pm:

page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase):
page/DOMWindow.h:
page/DOMWindow.idl: Add openDatabase implementation.

2007-10-19 Brady Eidson <beidson@apple.com>

Reviewed by Oliver

Added tons of utility to the FileSystem abstractions, including moving
some stuff over from IconDatabase

platform/FileSystem.h:

platform/cf/FileSystemCF.cpp: Added. (WebCore::fileSystemRepresentation):

platform/mac/FileSystemMac.mm:

platform/posix/FileSystemPOSIX.cpp: Added. (WebCore::fileExists): (WebCore::deleteFile): (WebCore::fileSize): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories):

2007-10-19 Timothy Hatcher <timothy@apple.com>

Reviewed by Adam Roben

Preliminary Web Inspector support for the Storage API
(This patch does not include the support artwork)

page/InspectorController.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::setScriptObject): (WebCore::databaseTableNames): Return the table names for a Database object. (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::populateScriptResources): (WebCore::InspectorController::addDatabaseScriptResource): Add the script object for the database. (WebCore::InspectorController::removeDatabaseScriptResource): Remove the script object for the database. (WebCore::InspectorController::clearDatabaseScriptResources): Remove all the database resources. (WebCore::InspectorController::didCommitLoad): Call clearDatabaseScriptResources(). (WebCore::InspectorController::didOpenDatabase): Make a new InspectorDatabaseResource and add it to m_databaseResources.
page/InspectorController.h:
page/inspector/Database.js: Added.
page/inspector/DatabasePanel.js: Added.
page/inspector/ResourceCategory.js: Make resource categories assume less about the resource.
page/inspector/inspector.css: Add styles for the database panel.
page/inspector/inspector.html: Include DatabasePanel.js
page/inspector/inspector.js: Support for adding and removing Database resources.

2007-10-19 Brady Eidson <beidson@apple.com>

Reviewed by Tim Hatcher

Added support for Chrome prompts required by the Storage API

page/Chrome.cpp: (WebCore::Chrome::runDatabaseSizeLimitPrompt):
page/Chrome.h:
page/ChromeClient.h:
platform/graphics/svg/SVGImageEmptyClients.h:

2007-10-19 Brady Eidson <beidson@apple.com>

Contributions and Review by Anders

Various SQLite tweaks in preparation for the storage API

loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::~SQLDatabase): (WebCore::SQLDatabase::authorizerFunction): Static callback from sqlite for authorizer functions (WebCore::SQLDatabase::setAuthorizer): (WebCore::SQLDatabase::lock): (WebCore::SQLDatabase::unlock):
loader/icon/SQLDatabase.h:

loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Switch to prepare16_v2 (WebCore::SQLStatement::bindDouble): Added (WebCore::SQLStatement::bindValue): Bind a wrapped SQLValue object (described later) (WebCore::SQLStatement::bindParameterCount): Accessor to the sqlite3 API for validating statements
loader/icon/SQLStatement.h: (WebCore::SQLStatement::isPrepared):

platform/sql/SQLAuthorizer.cpp: Added. Fully virtual interface to implement your own SQLite authorizer
platform/sql/SQLAuthorizer.h: Added. (WebCore::SQLAuthorizer::~SQLAuthorizer): (WebCore::SQLAuthorizer::createTable): (WebCore::SQLAuthorizer::createTempTable): (WebCore::SQLAuthorizer::dropTable): (WebCore::SQLAuthorizer::dropTempTable): (WebCore::SQLAuthorizer::allowAlterTable): (WebCore::SQLAuthorizer::createIndex): (WebCore::SQLAuthorizer::createTempIndex): (WebCore::SQLAuthorizer::dropIndex): (WebCore::SQLAuthorizer::dropTempIndex): (WebCore::SQLAuthorizer::createTrigger): (WebCore::SQLAuthorizer::createTempTrigger): (WebCore::SQLAuthorizer::dropTrigger): (WebCore::SQLAuthorizer::dropTempTrigger): (WebCore::SQLAuthorizer::createView): (WebCore::SQLAuthorizer::createTempView): (WebCore::SQLAuthorizer::dropView): (WebCore::SQLAuthorizer::dropTempView): (WebCore::SQLAuthorizer::createVTable): (WebCore::SQLAuthorizer::dropVTable): (WebCore::SQLAuthorizer::allowDelete): (WebCore::SQLAuthorizer::allowInsert): (WebCore::SQLAuthorizer::allowUpdate): (WebCore::SQLAuthorizer::allowTransaction): (WebCore::SQLAuthorizer::allowSelect): (WebCore::SQLAuthorizer::allowRead): (WebCore::SQLAuthorizer::allowAttach): (WebCore::SQLAuthorizer::allowDetach): (WebCore::SQLAuthorizer::allowReindex): (WebCore::SQLAuthorizer::allowAnalyze): (WebCore::SQLAuthorizer::allowFunction):

platform/sql/SQLValue.cpp: Added. Contains a value for a SQLite database that can be one of a few types. For now, just a String or a double (WebCore::SQLValue::SQLValue): (WebCore::SQLValue::string): (WebCore::SQLValue::number):
platform/sql/SQLValue.h: Added. (WebCore::SQLValue::): (WebCore::SQLValue::SQLValue): (WebCore::SQLValue::type):

2007-10-19 Brady Eidson <beidson@apple.com>

Reviewed by Maciej

Changed IconDatabase over to use new FileSystem apis

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):

WebKit:

Reviewed by Tim Hatcher

Added support for Chrome prompts required by the Storage API
Added support API for future managing of databases from the WebKit client
Added preference and initialization for the databases path

Misc/WebDatabaseManager.h: Added. WebDatabaseManager is how a WebKit application can list and remove the current available databases
Misc/WebDatabaseManager.mm: Added. (+[WebDatabaseManager origins]): (+[WebDatabaseManager databasesWithOrigin:]): (+[WebDatabaseManager deleteAllDatabases]): (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]): (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]): (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
Misc/WebDatabaseManagerPrivate.h: Added.

WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for an origin exceeding its size limit
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runDatabaseSizeLimitPrompt):
WebKit.xcodeproj/project.pbxproj:
WebView/WebUIDelegate.h:

WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
WebView/WebViewInternal.h:

WebKitSite:

Reviewed by Tim Hatcher

Sample database API usage

misc/DatabaseExample.html: Added.

WebKit/win:

Reviewed by Anders

Keep windows building with new Chrome additions

WebChromeClient.cpp:
WebChromeClient.h:

3:21 PM Changeset in webkit [26786] by kmccullo

7 edits in trunk/WebKitTools

Reviewed by Oliver and Tim.

Made use of RetainPtr to avoid retain and release issues and moved the log function to DebuggerDocumentPlatform, which seems to be a more logical place for it to live.
Also moved knownServers from the ServerConnection to DebuggerApplication to match the Windows code and because it makes sense that a connection knows its own server but not all of them.

Drosera/mac/DebuggerClient.h: Moved the log function to DebuggerDocumentPlatform.
Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server Because it's owned by an own Ptr in DebuggerDocument. Also moved the call for the server name up from the ServerConnection class. (-[DebuggerClient dealloc]): (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call for the server name up from the ServerConnection.
Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog): Log directly from here. No need to call DebuggerClient.
Drosera/mac/ServerConnection.h: Removed the knownServers function. The way I see it, a ServerConnection should only know about its connection and the group of all possible servers should be kept by the application.
Drosera/mac/ServerConnection.mm: Removed knownServer but added currentServerName, it makes sense that the connection should know that name. (-[ServerConnection currentServerName]):

3:00 PM Changeset in webkit [26785] by hyatt

2 edits in trunk/WebCore

Fix for ebay parser crash.

Reviewed by Beth

fast/invalid/table-residual-style-crash.html added as a test

html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):

2:58 PM Changeset in webkit [26784] by hyatt

4 adds in trunk/LayoutTests

Add new layout test for parser crash.

2:25 PM Changeset in webkit [26783] by zimmermann

2 edits in trunk/JavaScriptCore

Reviewed by Anders.
Try to fix Qt/Win build slave, by including windows.h also on Qt/Win.

2:17 PM Changeset in webkit [26782] by weinig

3 edits in trunk/WebCore

Fix Windows, Qt and GTK builds.

WebCore.pro:
WebCore.vcproj/WebCore.vcproj:

2:03 PM Changeset in webkit [26781] by zimmermann

59 edits in trunk/LayoutTests

Rubberstamped by Oliver.

Land tiger baseline matching my MBP, as discussed with Oliver.
Mostly differences regarding the size of "(" / ")" characters.

1:53 PM Changeset in webkit [26780] by weinig

21 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

Encapsulate the same origin check into the new SecurityOrigin class.

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::defaultEventHandler):
dom/Document.h: (WebCore::Document::securityOrigin):
loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::setOpener):
loader/FrameLoader.h:
platform/SecurityOrigin.cpp: Added. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::clear): (WebCore::SecurityOrigin::isEmpty): (WebCore::SecurityOrigin::setForFrame): (WebCore::SecurityOrigin::setDomainFromDOM): (WebCore::SecurityOrigin::allowsAccessFrom): (WebCore::SecurityOrigin::isSecureTransitionTo):
platform/SecurityOrigin.h: Added.

LayoutTests:

Reviewed by Darin.

Update results after changing the warning message in isSafeScript to print the frame URL
rather than the security domain URL. This now also prints the warning when using data:
URLs because we no longer return early.

http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt:

1:04 PM Changeset in webkit [26779] by kmccullo

9 edits
3 adds
2 deletes in trunk/WebKitTools

Reviewed by Adam.

Integrated changes from mac drosera. Recently I've encapsulated out the server connection object from the rest of Drosera because it is very platform dependent right now and RPC is not implemented on windows. This functionality, of communicating with the WebKit server is the next area I will be focusing on in Windows.

Other changes and cleanup were made to organize the code and add notes on which parts still need work. Also some mac code is added and commented out, to act as pseudocode for the logic of those parts.

Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart pointer.
Drosera/config.h: Added whitespace.
Drosera/win/DebuggerApplication.cpp: Removed. The functionality of these files got moved into Drosera.h/cpp
Drosera/win/DebuggerApplication.h: Removed.
Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring happened here to better match the logic flow of the same code on the mac side and to use the new ServerConnection class. (DebuggerClient::DebuggerClient): Constructor that takes a server name. (DebuggerClient::initWithServerName): Initializer that will set up the class to use a ServerConnection object. This was necessary so I could create a DebuggerClient without having to initilaize it at construction. (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client will be the UIDelegate and FrameLoadDelegate. (DebuggerClient::AddRef): For IUnknown. (DebuggerClient::Release): For IUnknown. (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate this still needs to set the global context of the server, but IWebFrame does not have an accessor for the global context yet. (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate this is a pass through for the same function in the document. (DebuggerClient::didReceiveTitle): Unimplemented part of FrameLoadDelegate this would change the title of the window. (DebuggerClient::createWebViewWithRequest): Part of the FrameLoadDelegate. This is about new windows via Window.open() and how their delegates are set. (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the UIDelegate. Just a debug function for printing messages.
Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h because the Client should be the UIDelegate and FrameLoadDelegate to match the delegates on mac. (DebuggerClient::webViewLoaded): Added accessor method.
Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently forgotten to add this file before. This is where the platform dependent versions of the Documents functions live. Most of these are unimplemented because some piece of functionality does not exist on Windows yet. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate responsibilities becaue they belong in the Client. Also I laid the groundwork for attaching Drosera to a WebKit process (attachWndProc): Now if a server is selected the Client becomes it's delegate. (Drosera::Drosera): Added the construction of the Client and dictionary of server names. (Drosera::initUI): This is no longer the delegates, the Client is. (Drosera::webViewLoaded): Now asks the Client instead of holding local state. (Drosera::applicationDidFinishLaunching): Placeholder for needed notification registration when it's possible to implement. (Drosera::serverLoaded): Ditto (Drosera::serverUnloaded): Ditto (Drosera::attach): Attach Drosera to the WebKit server.
Drosera/win/Drosera.h: Ditto for Drosera.cpp comment. (Drosera::getInst): (Drosera::setInst): (Drosera::knownServers):
Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication and added the ServerConnection.
Drosera/win/DroseraPrefix.h: Added an ifndef check.
Drosera/win/ServerConnection.cpp: Added. This is the interesting part Most of the functions are completely unimlemented because they cannot connect with the WebKit server, because one does not exist on Windows yet. (ServerConnection::initWithServerName): (ServerConnection::~ServerConnection): (ServerConnection::setGlobalContext): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::switchToServerNamed): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie): (ServerConnection::currentFrame):
Drosera/win/ServerConnection.h: Added. Ditto. (ServerConnection::ServerConnection):

11:12 AM Changeset in webkit [26778] by aliceli1

1 edit in trunk/WebKitTools/ChangeLog

Reviewed by Darin.

Fix for these broken layout tests on Windows:

fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html
fast/forms/select-accesskey.html

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): correct the VK code for alt key.

11:05 AM Changeset in webkit [26777] by aliceli1

2 edits in trunk/WebKitTools

Reviewed by Darin.

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): correct the VK code for alt key.

10:51 AM Changeset in webkit [26776] by sullivan

2 edits in trunk/WebKit

Reviewed by Tim Hatcher

fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history

History/WebHistory.mm: (-[WebHistoryPrivate removeAllItems]): This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition to the other places where it's cleared.

10:33 AM Changeset in webkit [26775] by mitz

2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

removing a commented-out test and a test that no longer fails

platform/mac-leopard/Skipped:

10:14 AM Changeset in webkit [26774] by ddkilzer

2 edits
1 copy in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

Provide the functionality of js-test-post.js in a function named isSuccessfullyParsed().

fast/encoding/char-encoding.html: Updated to use js-test-post-function.js instead of local hack.
fast/js/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post.js. Modified to create isSuccessfullyParsed() function.

8:13 AM Changeset in webkit [26773] by hausmann

4 edits in trunk

Fix the Qt/Windows build: Added missing FontSelector.h include and re-order moc inclusion.

7:46 AM Changeset in webkit [26772] by hausmann

2 edits in trunk/WebCore

Qt/Windows build fix: Threading.h uses int32_t but doesn't include stdint.h.

7:14 AM Changeset in webkit [26771] by hausmann

2 edits in trunk/JavaScriptCore

Fix compilation on Windows when wchar_t is a typedef instead of a native type (triggered by -Zc:wchar_t-).
Don't provide the wchar_t overloads then as they conflict with the unsigned short ones.

4:28 AM Changeset in webkit [26770] by hausmann