Context Navigation

← Previous Period
Next Period →

Timeline

Oct 22, 2007:

11:45 PM Changeset in webkit [26913] by sfalken

2 edits in trunk/WebCore

Fix build.

plugins/win/PluginViewWin.cpp:

11:44 PM Changeset in webkit [26912] by darin

7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=15636 some JavaScriptCore regression tests are failing due to numeric conversion

This should restore correctness and make speed better too, restoring some
of the optimization we lost in my last check-in.

kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): Added. Uses the range checking idiom I used in my patch yesterday. (KJS::JSImmediate::getTruncatedUInt32): Ditto.

kjs/internal.h: Removed getInt32 and added getTruncatedInt/UInt32.
kjs/internal.cpp: (KJS::NumberImp::getUInt32): Changed to always use double, since I can't find a way to write this more efficiently for float. (KJS::NumberImp::getTruncatedInt32): Added. (KJS::NumberImp::getTruncatedUInt32): Added.

kjs/value.h: Removed getInt32 and added getTruncatedInt/UInt32. (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): Added. (KJS::JSValue::getTruncatedUInt32): Added. (KJS::JSValue::toInt32): Changed getInt32 call to getTruncatedInt32. (KJS::JSValue::toUInt32): Changed getUInt32 call to getTruncatedUInt32.
kjs/value.cpp: (KJS::JSCell::getTruncatedInt32): Added. (KJS::JSCell::getTruncatedUInt32): Added. (KJS::JSValue::toInteger): Changed getUInt32 call to getTruncatedInt32. (KJS::JSValue::toInt32SlowCase): Removed extra getInt32 call I accidentally had left in here. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Changed getUInt32 call to getTruncatedUInt32.

JavaScriptCore.exp: Updated.

11:28 PM Changeset in webkit [26911] by eseidel

2 edits in trunk/WebCore

2007-10-22 Eric Seidel <eric@webkit.org>

Build fix only, no review.

WebCore.xcodeproj/project.pbxproj: re-add all DOMSVG headers to copy-files phase to make sure.

11:22 PM Changeset in webkit [26910] by eseidel

2 edits in trunk/WebCore

2007-10-22 Eric Seidel <eric@webkit.org>

Build fix only, no review.

WebCore.xcodeproj/project.pbxproj: make sure DOMSVGAnimateElement.h is copied into headers.

11:07 PM Changeset in webkit [26909] by eseidel

1 edit in trunk/WebCore/ksvg2/svg/SVGAnimateElement.idl

Touch SVGAnimateElement.idl to force to bots to rebuild *SVGAnimateElement.*

9:19 PM Changeset in webkit [26908] by mjs

2 edits
7 adds in trunk/SunSpider

Reviewed by Review.

add more tests (probably the final set for now)

Already balanced. Added date, regexp, control flow, and a few
more string and object/array access tests.

tests/LIST:
tests/access-fannkuch.js: Added.
tests/access-nbody.js: Added.
tests/controlflow-recursive.js: Added.
tests/date-format-tofte.js: Added.
tests/date-format-xparb.js: Added.
tests/regexp-dna.js: Added.
tests/string-validate-input.js: Added.

8:49 PM Changeset in webkit [26907] by eseidel

12 edits
2 adds in trunk

2007-10-22 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Fix build by properly exposing SVG font-face dom bindings.

DerivedSources.make:
WebCore.vcproj/WebCore.vcproj: add font-face files to build
WebCore.xcodeproj/project.pbxproj: add missing DOM bindings files
bindings/js/JSSVGElementWrapperFactory.cpp:
bindings/objc/DOM.mm: (WebCore::createElementClassMap):
bindings/objc/DOMSVG.h:
ksvg2/svg/SVGDefinitionSrcElement.idl: inherit from SVGElement

7:44 PM Changeset in webkit [26906] by bdash

2 edits in trunk/WebCore

2007-10-22 Mark Rowe <mrowe@apple.com>

Gtk build fix.

WebCore.pro:

7:30 PM Changeset in webkit [26905] by darin

3 edits in trunk/WebCore

a first cut at fixing the Qt and GTK builds

WebCore.pro: Add new .idl and .cpp files.
DerivedSources.make: Re-sorted.

6:02 PM JavaScript performance improvement ideas edited by mjs@apple.com

(diff)

5:50 PM JavaScript performance improvement ideas edited by ggaren@apple.com

(diff)

5:38 PM Changeset in webkit [26904] by eseidel

15 edits
28 adds in trunk

2007-10-22 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

Implement <font-face> and friends for SVG.
http://bugs.webkit.org/show_bug.cgi?id=10652

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSSVGElementWrapperFactory.cpp:
dom/Document.cpp: (WebCore::Document::mappedElementSheet): (WebCore::Document::recalcStyleSelector):
dom/Document.h:
ksvg2/scripts/make_names.pl:
ksvg2/svg/SVGDefinitionSrcElement.cpp: Added. (WebCore::SVGDefinitionSrcElement::SVGDefinitionSrcElement): (WebCore::SVGDefinitionSrcElement::~SVGDefinitionSrcElement): (WebCore::SVGDefinitionSrcElement::childrenChanged):
ksvg2/svg/SVGDefinitionSrcElement.h: Added.
ksvg2/svg/SVGDefinitionSrcElement.idl: Added.
ksvg2/svg/SVGFontFaceElement.cpp: Added. (WebCore::SVGFontFaceElement::SVGFontFaceElement): (WebCore::SVGFontFaceElement::~SVGFontFaceElement): (WebCore::cssPropertyIdForName): (WebCore::mapAttributeToCSSProperty): (WebCore::cssPropertyIdForSVGAttributeName): (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::childrenChanged):
ksvg2/svg/SVGFontFaceElement.h: Added.
ksvg2/svg/SVGFontFaceElement.idl: Added.
ksvg2/svg/SVGFontFaceFormatElement.cpp: Added. (WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement): (WebCore::SVGFontFaceFormatElement::~SVGFontFaceFormatElement): (WebCore::SVGFontFaceFormatElement::childrenChanged):
ksvg2/svg/SVGFontFaceFormatElement.h: Added.
ksvg2/svg/SVGFontFaceFormatElement.idl: Added.
ksvg2/svg/SVGFontFaceNameElement.cpp: Added. (WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement): (WebCore::SVGFontFaceNameElement::~SVGFontFaceNameElement): (WebCore::SVGFontFaceNameElement::srcValue):
ksvg2/svg/SVGFontFaceNameElement.h: Added.
ksvg2/svg/SVGFontFaceNameElement.idl: Added.
ksvg2/svg/SVGFontFaceSrcElement.cpp: Added. (WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement): (WebCore::SVGFontFaceSrcElement::~SVGFontFaceSrcElement): (WebCore::SVGFontFaceSrcElement::srcValue): (WebCore::SVGFontFaceSrcElement::childrenChanged):
ksvg2/svg/SVGFontFaceSrcElement.h: Added.
ksvg2/svg/SVGFontFaceSrcElement.idl: Added.
ksvg2/svg/SVGFontFaceUriElement.cpp: Added. (WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement): (WebCore::SVGFontFaceUriElement::~SVGFontFaceUriElement): (WebCore::SVGFontFaceUriElement::srcValue): (WebCore::SVGFontFaceUriElement::childrenChanged):
ksvg2/svg/SVGFontFaceUriElement.h: Added.
ksvg2/svg/SVGFontFaceUriElement.idl: Added.
ksvg2/svg/svgtags.in:

5:33 PM Changeset in webkit [26903] by aroben

2 edits in trunk/WebKitTools

Windows build fix

Reviewed by NOBODY.

Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.

5:28 PM Changeset in webkit [26902] by sfalken

1 copy in tags/Safari-523.12.7b

New tag.

5:28 PM Changeset in webkit [26901] by sfalken

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

5:26 PM Changeset in webkit [26900] by sfalken

2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26898.

4:36 PM Changeset in webkit [26899] by darin

7 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

fix http://bugs.webkit.org/show_bug.cgi?id=15632 js1_5/Array/array-001.js test failing

One of the JavaScriptCore tests was failing; it failed because of
my change to NumberImp::getUInt32. The incorrect code I copied was
from JSImmediate::getUInt32, and was a pre-existing bug.

This patch fixes correctness, but will surely slow down SunSpider.
We may be able to code this tighter and get the speed back.

kjs/JSImmediate.h: (KJS::JSImmediate::getInt32): Renamed from toInt32 to more accurately reflect the fact that this function only returns true if the value is accurate (no fractional part, etc.). Changed code so that it returns false when the value has a fraction. (KJS::JSImmediate::getUInt32): Ditto.

kjs/internal.cpp: (KJS::NumberImp::getInt32): Changed code so that it returns false when the value has a fraction. Restores the old behavior. (KJS::NumberImp::getUInt32): Ditto.

kjs/value.h: (KJS::JSValue::getInt32): Updated for name change. (KJS::JSValue::getUInt32): Ditto. (KJS::JSValue::toInt32): Ditto. (KJS::JSValue::toUInt32): Ditto.

LayoutTests:

Reviewed by Geoff.

tests for http://bugs.webkit.org/show_bug.cgi?id=15632

Added tests for cases where you use something that looks like an array
index, but it has a fractional part.

fast/js/kde/resources/Array.js: Added tests.
fast/js/kde/Array-expected.txt: Updated.

4:29 PM Changeset in webkit [26898] by honeycutt

2 edits in trunk/WebCore

2007-10-22 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

We purposefully do not destroy our Java VM when its reference count
reaches 0, but we were unloading our JavaPlugin.dll when its reference
count reached 0, which lost the reference to the VM. This led to our
process trying to create a new VM the next time a page using Java was
loaded, and the JNI spec states that a single process is not allowed to
create more than one VM. The fix is to avoid unloading the Java plugin
via our PluginQuirkDontUnloadPlugin.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks):

3:18 PM Changeset in webkit [26897] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Brady.

fix crash seen when running JavaScriptCore tests

kjs/array_instance.cpp: (KJS::ArrayInstance::mark): Copy and paste error: I accidentally had code here that was making a copy of the HashMap -- that's illegal inside a mark function and was unnecessary. The other callsite was modifying the map as it iterated it, but this function is not.

2:32 PM Changeset in webkit [26896] by hyatt

6 adds in trunk/LayoutTests/platform/mac/fast/transforms

Add results for new layout tests for transforms.

2:32 PM Changeset in webkit [26895] by hyatt

2 adds in trunk/LayoutTests/fast/transforms

Add two new layout tests for transforms.

2:29 PM Changeset in webkit [26894] by hyatt

4 edits in trunk/WebCore

Fix for bug 15624, make transforms work properly with opacity.

Make sure a unitless 0 is allowed as an angle argument to rotation/skew.

Reviewed by Mitz Pettel

fast/transforms/transforms-with-opacity.html
fast/transforms/skew-with-unitless-zero.html

css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::calculateClipRects):
rendering/RenderLayer.h: (WebCore::RenderLayer::transform):

2:26 PM Changeset in webkit [26893] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Oliver.

Avoid moving floats into integer registers in jsNumber() for 3% speedup on SunSpider http://bugs.webkit.org/show_bug.cgi?id=15627

kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): Avoid moving floats to integer registers since this is very slow.

11:39 AM Changeset in webkit [26892] by darin

7 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=15617 improve speed of integer conversions

Makes SunSpider 6% faster.

kjs/JSImmediate.h: Added toInt32 and toUInt32, with separate versions for 32-bit and 64-bit.
kjs/value.h: (KJS::JSValue::getUInt32): Call JSImmediate::toUInt32.

kjs/internal.h: Added getInt32.
kjs/internal.cpp: (KJS::NumberImp::getInt32): Added. (KJS::NumberImp::getUInt32): Replaced with more-optimal implementation stolen from JSValue.

kjs/value.h: (KJS::jsNumber): Marked ALWAYS_INLINE, because this wasn't getting inlined. (KJS::JSValue::getInt32): Added. (KJS::JSValue::getUInt32): Changed to call the new JSImmediate::toUInt32 to avoid converting from float to double. (KJS::JSValue::toInt32): Made inline, separated out the slow case. (KJS::JSValue::toUInt32): Ditto.
kjs/value.cpp: (KJS::JSCell::getInt32): Added. (KJS::JSValue::toInt32SlowCase): Renamed from toInt32. Changed to use the new getInt32. Added a faster case for in-range numbers. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Added a faster case for in-range numbers.

JavaScriptCore.exp: Updated for changes.

11:02 AM Changeset in webkit [26891] by kmccullo

2 edits in trunk/WebKitTools

Removed a leak that was fixed.

Scripts/run-webkit-tests:

10:48 AM Changeset in webkit [26890] by kmccullo

6 edits in trunk/WebKitTools

Reviewed by Darin.

Changed the Client so that the DebuggerDocument now own the ServerConnection. This simplifies ownership and cleanup.

Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the ServerConnection. (DebuggerClient::initWithServerName): (DebuggerClient::didFinishLoadForFrame):
Drosera/win/DebuggerClient.h: DebuggerDocument now owns the ServerConnection.
Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to until after we have a server which we are attached to. (Drosera::initUI): (Drosera::attach):
Drosera/win/Drosera.h: Removed two needless pointers I forgot to take out previously.

10:43 AM Changeset in webkit [26889] by aroben

5 edits in trunk

Windows build fix

JavaScriptCore:

Windows build fix

Reviewed by NOBODY.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn off warning about implicit conversion to bool.

WebCore:

Windows build fix

Reviewed by NOBODY.

WebCore.vcproj/WebCore.vcproj: Copy header files from platform/sql.
page/Page.cpp: Touched to force the header files to be copied.

10:14 AM Changeset in webkit [26888] by zimmermann

4 edits in trunk/WebCore

Reviewed by Simon.

Move textPath related SVGChar data in it's own structure SVGCharOnPath.
Store a pointer to that datastructure inside SVGChar, instead of 4 floats & one bool.

Saves space for the common case. And allows me to add more data (another float) to support
glyph-orientation-* on textPath later on...

9:29 AM QtWebKit edited by Simon Hausmann

(diff)

9:21 AM BuildingQtOnWindows edited by Simon Hausmann

(diff)

9:01 AM Changeset in webkit [26887] by hausmann

2 edits in trunk/WebKitTools

When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.

8:06 AM Changeset in webkit [26886] by alp

6 edits in trunk/WebCore

2007-10-22 Alp Toker <alp@atoker.com>

Reviewed by Nikolas Zimmermann.

Implement more GraphicsContextCairo stubs.

Remove a hack "to work around no current point bug" that was breaking
canvas tests.

Fix warnings.

platform/graphics/cairo/CairoPath.h: (WebCore::CairoPath::CairoPath):
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::strokeRect):
platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty):
platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):
platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: (WebCore::SVGPaintServerSolid::setup):

7:54 AM Changeset in webkit [26885] by hausmann

9 edits in trunk/WebKitTools

Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.

7:53 AM Changeset in webkit [26884] by hausmann

3 edits in trunk/WebCore

Fix compilation from a clean build with the database feature disabled.
JSCustomVersionChangeCallback.cpp doesn't actually need the SQL header file, just ScriptInterpreter.

6:56 AM Changeset in webkit [26883] by bdash

2 edits in trunk/JavaScriptCore

2007-10-22 Mark Rowe <mrowe@apple.com>

Gtk build fix.

kjs/array_instance.cpp:

6:46 AM Changeset in webkit [26882] by darin

1 edit in trunk/LayoutTests/ChangeLog

fast/js/kde/resources/Array.js: Added tests to cover missing value behavior (not the same as undefined values in arrays). This matches the ECMA JavaScript specification, but doesn't exactly match Firefox, because Firefox incorrectly inserts undefined values rather than missing values in array literals with extra commas.
fast/js/kde/Array-expected.txt: Updated with results.

6:35 AM Changeset in webkit [26881] by darin

11 edits
1 copy in trunk

JavaScriptCore:

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15606 make cut-off for sparse vs. dense arrays smarter for speed with large arrays

Makes the morph test in SunSpider 26% faster, and the overall
benchmark 3% faster.

This also fixes some small problems we had with the distinction
between nonexistent and undefined values in arrays.

kjs/array_instance.h: Tweaked formatting and naming.
kjs/array_instance.cpp: Copied from kjs/array_object.cpp. (KJS::storageSize): Added. Computes the size of the storage given a vector length. (KJS::increasedVectorLength): Added. Implements the rule for resizing the vector. (KJS::isDenseEnoughForVector): Added. (KJS::ArrayInstance::ArrayInstance): Initialize the new fields. (KJS::ArrayInstance::~ArrayInstance): Since m_storage is now never 0, delete it. (KJS::ArrayInstance::getItem): Updated for name changes. (KJS::ArrayInstance::lengthGetter): Ditto. (KJS::ArrayInstance::inlineGetOwnPropertySlot): Added. Allows both versions of getOwnPropertySlot to share more code. (KJS::ArrayInstance::getOwnPropertySlot): Just refactored, no code change. (KJS::ArrayInstance::put): Added logic for extending the vector as long as the array is dense enough. Also keep m_numValuesInVector up to date. (KJS::ArrayInstance::deleteProperty): Added code to keep m_numValuesInVector up to date. (KJS::ArrayInstance::getPropertyNames): Fixed bug where this would omit names for array indices with undefined values. (KJS::ArrayInstance::increaseVectorLength): Renamed from resizeStorage. Also simplified to only handle getting larger. (KJS::ArrayInstance::setLength): Added code to update m_numValuesInVector, to zero out the unused part of the vector and to delete the map if it's no longer needed. (KJS::ArrayInstance::mark): Tweaked formatting. (KJS::compareByStringForQSort): Ditto. (KJS::ArrayInstance::sort): Ditto. (KJS::CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): Ditto. (KJS::compareWithCompareFunctionForQSort): Ditto. (KJS::ArrayInstance::compactForSorting): Fixed bug where this would turn undefined values into nonexistent values in some cases.

kjs/array_object.h: Removed MAX_ARRAY_INDEX.
kjs/array_object.cpp: Removed ArrayInstance. Moved to a separate file.

JavaScriptCore.pri: Added array_instance.cpp.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
kjs/AllInOneFile.cpp: Ditto.

LayoutTests:

fast/js/kde/resources/Array.js: Added tests to cover missing value behavior (not the same as undefined values in arrays). This matches the ECMA JavaScript specification, but doesn't exactly match Firefox.
fast/js/kde/Array-expected.txt: Updated with results.

5:56 AM Changeset in webkit [26880] by andrew

10 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

Configurations/JavaScriptCore.xcconfig:

WebCore:

Reviewed by Mark Rowe.

Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

Configurations/WebCore.xcconfig:
WebCore.pro:
WebCore.vcproj/build-generated-files.sh:

WebKit:

Reviewed by Mark Rowe.

Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

Configurations/WebKit.xcconfig:

WebKitTools:

Reviewed by Mark Rowe.

Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

Scripts/build-webkit:

4:39 AM Changeset in webkit [26879] by hausmann

2 edits in trunk/JavaScriptCore

Build fix for the non-qmake builds.

4:28 AM Changeset in webkit [26878] by hausmann

2 edits in trunk/WebCore

Disable the database feature in the qmake build for now.

4:22 AM Changeset in webkit [26877] by hausmann

9 edits in trunk/WebCore

Make disabling the database feature (ENABLE_DATABASE=0) work by
placing various #ifdefs into the code and making the compilation of
some files optional.

3:41 AM Changeset in webkit [26876] by alp

6 edits in trunk

2007-10-22 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=15611
[GTK] Text selection behaviour different in Debug and Release builds

http://bugs.webkit.org/show_bug.cgi?id=15578
[GTK] Text editor caret does not blink

Never allow control to reach the end of non-void functions.

Return more sensible values, or in some cases, nulls.

2:35 AM Changeset in webkit [26875] by hausmann

2 edits in trunk/WebCore

Implement ResourceHandle::loadResourceSynchronously using ResourceHandle and a special ResourceHandleClient. This approach has the possible danger of reentrancy.

Signed-off-by: Simon Hausmann <hausmann@kde.org>

2:33 AM Changeset in webkit [26874] by hausmann

5 edits in trunk

Do not build testkjs as an application bundle. This is

needed for run-javascriptcore-tests on OSX.

Also, based on r26633, allow to test the WebKit/Qt port on OSX.
Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set

as we do not have -rpath on OSX.

Signed-off-by: Simon Hausmann <hausmann@kde.org>

2:24 AM Changeset in webkit [26873] by hausmann

2 edits in trunk/WebCore