⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 24, 2007:

11:38 PM Changeset in webkit [27022] by eseidel
  • 31 edits
    1 copy
    1 add in trunk

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


Add a JSGlobalObject class and remove the InterpreterMap
​http://bugs.webkit.org/show_bug.cgi?id=15681


This required making JSCallbackObject a template class to allow for
JSGlobalObjects with JSCallbackObject functionality.


SunSpider claims this was a 0.5% speedup.

  • API/JSCallbackObject.cpp: (KJS::):
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: Copied from API/JSCallbackObject.cpp. (KJS::::JSCallbackObject): (KJS::::init): (KJS::::~JSCallbackObject): (KJS::::initializeIfNeeded): (KJS::::className): (KJS::::getOwnPropertySlot): (KJS::::put): (KJS::::deleteProperty): (KJS::::implementsConstruct): (KJS::::construct): (KJS::::implementsHasInstance): (KJS::::hasInstance): (KJS::::implementsCall): (KJS::::callAsFunction): (KJS::::getPropertyNames): (KJS::::toNumber): (KJS::::toString): (KJS::::setPrivate): (KJS::::getPrivate): (KJS::::inherits): (KJS::::cachedValueGetter): (KJS::::staticValueGetter): (KJS::::staticFunctionGetter): (KJS::::callbackGetter):
  • API/JSClassRef.cpp: (OpaqueJSClass::prototype):
  • API/JSContextRef.cpp: (JSGlobalContextCreate):
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectGetPrivate): (JSObjectSetPrivate):
  • API/JSValueRef.cpp: (JSValueIsObjectOfClass):
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
  • bindings/jni/jni_jsobject.cpp:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
  • kjs/Context.cpp: (KJS::Context::Context):
  • kjs/ExecState.cpp: (KJS::ExecState::lexicalInterpreter):
  • kjs/JSGlobalObject.h: Added. (KJS::JSGlobalObject::JSGlobalObject): (KJS::JSGlobalObject::isGlobalObject): (KJS::JSGlobalObject::interpreter): (KJS::JSGlobalObject::setInterpreter):
  • kjs/array_instance.cpp:
  • kjs/context.h:
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/interpreter.cpp: (KJS::Interpreter::Interpreter): (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::globalObject): (KJS::Interpreter::initGlobalObject): (KJS::Interpreter::evaluate):
  • kjs/interpreter.h:
  • kjs/lookup.h: (KJS::cacheGlobalObject):
  • kjs/object.h: (KJS::JSObject::isGlobalObject):
  • kjs/testkjs.cpp:
11:26 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
10:38 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
10:33 PM Changeset in webkit [27021] by staikos
  • 2 edits in trunk/WebKitTools

unbreak Qt build

10:23 PM Changeset in webkit [27020] by aroben
  • 7 edits
    2 adds in trunk

Fix <rdar://5549919> Add font database initialization code to WebCore and call it from WebKit

WebCore:

Add font database initialization code to WebCore

Reviewed by Ada.

  • WebCore.vcproj/WebCore.vcproj: Added FontDatabase.{cpp,h}.
  • platform/win/FontDatabase.cpp: Added. (WebCore::systemFontsDirectory): (WebCore::fontsPlistPath): (WebCore::systemHasFontsNewerThanFontsPlist): (WebCore::readFontPlist): (WebCore::populateFontDatabaseFromPlist): (WebCore::populateFontDatabaseFromFileSystem): (WebCore::writeFontDatabaseToPlist): (WebCore::populateFontDatabase): This is the only function callable from outside this file. It populates the font database once, either from the fonts plist, or from the filesystem (and then saves a new fonts plist).
  • platform/win/FontDatabase.h: Added.

WebKitTools:

Remove now-unnecessary call to InitializeCoreGraphics

WebKit takes care of this now.

Reviewed by Ada.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize):

WebKit/win:

Fix <rdar://5549919> Initialize the font database before any font code is invoked

We initialize the database in two places:

  1. When instantiating WebKitClassFactory, which is guaranteed to happen before any WebView is instantiated.
  2. When making a WebCore::Font in WebKitGraphics.

This ensures that the font database will be populated before any font
code is invoked. We rely on WebCore to only populate the database
once.

Reviewed by Ada.

  • WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Populate the font database.
  • WebKitGraphics.cpp: (makeFont): Ditto.
10:22 PM Changeset in webkit [27019] by aroben
  • 9 edits
    2 copies in trunk

Add [I]WebTextRenderer

WebKitTools:

Use WebTextRenderer in DRT

Reviewed by Ada.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Use WebTextRenderer instead of using InitializeCoreGraphics/AddFontResourceEx.

WebKit/win:

Add [I]WebTextRenderer

Right now this class can only be used to add private fonts for use by
the running process, but will eventually be the home of the
WebKitGraphics functions.

Reviewed by Ada.

  • ForEachCoClass.h: Added WebTextRenderer.
  • Interfaces/WebKit.idl: Ditto.
  • WebKit.vcproj/Interfaces.vcproj: Ditto.
  • WebKit.vcproj/WebKit.vcproj: Ditto.
  • WebKit.vcproj/WebKitGUID.vcproj: Ditto.
  • WebKitClassFactory.cpp: Ditto.
  • WebTextRenderer.cpp: Added. (WebTextRenderer::createInstance): (WebTextRenderer::WebTextRenderer): (WebTextRenderer::~WebTextRenderer): (WebTextRenderer::QueryInterface): (WebTextRenderer::AddRef): (WebTextRenderer::Release): (WebTextRenderer::registerPrivateFont):
  • WebTextRenderer.h: Added.
10:22 PM Changeset in webkit [27018] by aroben
  • 4 edits in trunk/WebKit/win

Use FOR_EACH_COCLASS in WebKitClassFactory

Reviewed by Ada.

  • WebError.cpp: (WebError::createInstance): Added an overload that takes no arguments to make the macro used in WebKitClassFactory work.
  • WebError.h:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Use FOR_EACH_COCLASS.
10:22 PM Changeset in webkit [27017] by aroben
  • 3 edits
    1 add in trunk/WebKit/win

Put FOR_EACH_COCLASS macro into its own file and export it

The macro used to be called FOR_EACH_CLASS and lived in WebKitDLL.cpp.
This way we will be able to use the macro in more places that care
about all WebKit's COM classes.

Reviewed by Ada.

  • ForEachCoClass.h: Added.
  • WebKit.vcproj/WebKit.vcproj: Copy ForEachCoClass.h to WebKitOutputDir, and added it to the project.
  • WebKitDLL.cpp: Updated for macro rename, and changed to #undef the macros we pass to FOR_EACH_COCLASS after we're done with them.
10:20 PM Changeset in webkit [27016] by aroben
  • 4 edits in trunk/WebKitLibraries

Added some font-related functions needed for <rdar://5549919>

Reviewed by Ada.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
10:01 PM Changeset in webkit [27015] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

2007-10-24 Sven Herzberg <​sven@imendio.com>

Reviewed by Mark Rowe.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=15614
Bug 15614: [GTK] qmake based backends don't build on OS X

  • Scripts/build-webkit: set QMAKESPEC correctly if building the QT or GTK backend on a Mac
  • Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into isDarwin() to make it reusable in other places (like the workaround- for-prebuilt-qmake in build-webkit)
8:51 PM Changeset in webkit [27014] by ddkilzer
  • 2 edits in trunk/WebKitTools

Refurbish update-webkit script.

Reviewed by Adam.

Scripts/update-webkit: Add -hhelp switch and usage statement. Check result of
GetOptions() call. Fix -qquiet switch to be passed to svn command properly. Use

multi-argument version of system() for flexibility and security. Check for existence
of Internal directory using -d test instead of -x.

8:50 PM Changeset in webkit [27013] by ddkilzer
  • 2 edits in trunk/WebKitTools

Minor clean-up of prepare-ChangeLog script.

Reviewed by Adam.

  • Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead of a string. Use multi-argument versions of open() and system() for flexibility and security.
7:40 PM Changeset in webkit [27012] by adachan
  • 2 edits in trunk/WebKit/win

<rdar://problem/5552221> REGRESSION(310A24-ToT): Shortcut key disable. (15604)

Reviewed by Adam.

  • WebView.cpp: (WebView::handleEditingKeyboardEvent): don't handle system key events as text input (WebView::keyDown): only remove WM_SYSCHAR message from the queue if we handle it. For WM_SYSCHAR message that we don't handle, let it stay in the queue and return false to let windows handle it.
6:19 PM Changeset in webkit [27011] by aroben
  • 15 edits in trunk

Touch all files that include *.lut.h to fix Windows builds

6:16 PM Changeset in webkit [27010] by bdash
  • 2 edits in trunk/WebKit/gtk

2007-10-24 Mark Rowe <​mrowe@apple.com>

Gtk build fix. Track WebCore changes in r27004.

  • Api/webkitgtkglobal.cpp:
5:58 PM Changeset in webkit [27009] by justing
  • 6 edits in trunk

WebCore:

Reviewed by Darin Adler.

Correcting the fix for:
<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time


Made removal of the previous composition part of the current Undo step in the
case where the new composition is the empty string, too.

  • editing/Editor.cpp: (WebCore::Editor::confirmComposition): Call the new TypingCommand::deleteSelection, which either has the currently open typing command delete the current selection, or opens a new typing command (of type DeleteSelection) if one is not already open. (WebCore::Editor::setComposition): Ditto.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Added. (WebCore::TypingCommand::doApply): Handle DeleteSelection. (WebCore::TypingCommand::deleteKeyPressed): Clarified which deleteSelection is called. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::preservesTypingStyle): Handle DeleteSelection.
  • editing/TypingCommand.h:

LayoutTests:

Reviewed by Darin.


<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time

  • platform/mac/editing/input/text-input-controller-expected.txt: The delete we were using previously to remove the old composition makes fewer calls to the editing delegate.
5:30 PM Changeset in webkit [27008] by weinig
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
5:10 PM Changeset in webkit [27007] by thatcher
  • 1 edit in trunk/WebKitTools/Scripts/build-webkit

Build fix.

4:55 PM Changeset in webkit [27006] by thatcher
  • 4 edits
    2 adds
    1 delete in trunk

WebKit:

Reviewed by Mark Rowe.

<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard

Use the WebKitSystemInterface that matches the system version.

  • Configurations/DebugRelease.xcconfig:
  • WebKit.xcodeproj/project.pbxproj:

WebKitLibraries:

Reviewed by Mark Rowe.

<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard

Add system specific versions of WebKitSystemInterface.

  • libWebKitSystemInterface.a: Removed.
  • libWebKitSystemInterfaceLeopard.a: Added.
  • libWebKitSystemInterfaceTiger.a: Added.
4:29 PM Changeset in webkit [27005] by aliceli1
  • 7 edits in trunk

WebCore:

Reviewed by Oliver.

Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe): Some mouse move events are actually drags, which on mac return early from this function. Adding the same logic to its Windows equivalent.

WebKitTools:

Reviewed by Oliver.

Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows

Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
replay the saved events when we're still processing the mousedown that starts the drag

  • DumpRenderTree/win/EventSender.cpp: (doMouseMove):
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop):

LayoutTests:

Removing fixed test

  • platform/win/Skipped:
4:02 PM Changeset in webkit [27004] by beidson
  • 10 edits
    2 adds in trunk

WebCore:

Reviewed by Anders

<rdar://5554130> DatabaseTracker.o has a global initializer

Since DatabaseTracker is a singleton, it makes much more sense to keep the database path as a member variable.
Now constructing the shared DatabaseTracker no longer implicitly opens it - It is only opened when the databases
path is set.


  • WebCore.vcproj/WebCore.vcproj: Copy WebCore/storage headers for WebKit build


  • storage/Database.cpp: (WebCore::Database::~Database): Remove bogus assertion


  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Does nothing now! Move this code to openTrackerDatabase (WebCore::DatabaseTracker::setDatabasePath): Set the member variable, also closing/opening the database if needed (WebCore::DatabaseTracker::databasePath): (WebCore::DatabaseTracker::openTrackerDatabase): To open and validate the Databases db, moved from the c'tor (WebCore::DatabaseTracker::fullPathForDatabase): Return the member variable
  • storage/DatabaseTracker.h:


WebKit/win:

Reviewed by Anders

Windows portion of <rdar://5554130>


Slowly introduce Windows WebKit portion of the Database API that sets the
on-disk location for databases


  • WebDatabaseManager.cpp: Added. (WebKitSetWebDatabasesPathIfNecessary):
  • WebDatabaseManager.h: Added.


  • WebKit.vcproj/WebKit.vcproj:


  • WebView.cpp: (WebView::initWithFrame): Call WebKitSetWebDatabasesPathIfNecessary()


WebKit:

Reviewed by Anders

<rdar://problem/5554130> DatabaseTracker.o has a global initializer

  • Misc/WebDatabaseManager.mm: (WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
4:00 PM Changeset in webkit [27003] by kmccullo
  • 11 edits
    2 adds in trunk

WebKitTools:

Reviewed by Sam, Steve and Darin.

  • Stubbed out the WebScriptDebugListener functionality in the Server Connection class to prepare it for receiving those callbacks.
  • Also I changed the instantiation of DebuggerClient, DebuggerDocument and the ServerConnection to not need to be initialized with a server name, since that is not the way we connect to the WebKit server.
  • Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging no exception. Now it only loggs when there is an exception (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::callFunctionOnObject):
  • Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection to be instantiated with a server's name. (DebuggerClient::DebuggerClient): (DebuggerClient::didFinishLoadForFrame):
  • Drosera/win/DebuggerClient.h: Removed unsued variable.
  • Drosera/win/Drosera.cpp: Client no longer needs to be initialized with a server name. (Drosera::init): (Drosera::initServer):
  • Drosera/win/Drosera.h: No longer need the ServerConnection to be instantiated with a server's name.
  • Drosera/win/ServerConnection.cpp: (ServerConnection::ServerConnection): No longer needs a server name (ServerConnection::~ServerConnection): Only release the global context if there is one. (ServerConnection::serverConnectionDidDie): Stub for IWebScriptDebugListener (ServerConnection::QueryInterface): ditto (ServerConnection::AddRef): ditto (ServerConnection::Release): ditto (ServerConnection::didLoadMainResourceForDataSource): ditto (ServerConnection::didParseSource): ditto (ServerConnection::failedToParseSource): ditto (ServerConnection::didEnterCallFrame): ditto (ServerConnection::willExecuteStatement): ditto (ServerConnection::willLeaveCallFrame): ditto (ServerConnection::exceptionWasRaised): ditto
  • Drosera/win/ServerConnection.h: Stubbed out the IWebScriptDebugListener functions, and this class no longer needs to be instantiated with a server name.

win:

Reviewed by Sam, Steve and Darin.

  • Added stubs for what will be neede to let Drosera attach to the WebKit process and debug it.
  • Interfaces/IWebScriptCallFrame.idl: Added.
  • Interfaces/IWebScriptDebugListener.idl: Added.
  • Interfaces/WebKit.idl:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
3:10 PM Changeset in webkit [27002] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Build fix for Gtk, no review.

  • kjs/collector.cpp: #include "context.h"
2:31 PM Changeset in webkit [27001] by eseidel
  • 5 edits
    2 adds in trunk

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


Stop checking isOutOfMemory after every allocation, instead let the collector
notify all ExecStates if we ever hit this rare condition.


SunSpider claims this was a 2.2% speedup.

  • kjs/collector.cpp: (KJS::Collector::collect): (KJS::Collector::reportOutOfMemoryToAllInterpreters):
  • kjs/collector.h:
  • kjs/nodes.cpp: (KJS::TryNode::execute):
1:33 PM Changeset in webkit [27000] by hyatt
  • 3 edits in trunk/WebCore

Don't try to gap fill transformed selections. Fix the invalidation of selection to use the clip to visible content
code path so that it works with multi-column layouts and transforms.

Reviewed by aroben

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::fillSelectionGaps):
  • rendering/RenderView.cpp: (WebCore::RenderView::setSelection):
1:25 PM Changeset in webkit [26999] by eseidel
  • 3 edits in trunk/WebCore

2007-10-24 Eric Seidel <​eric@webkit.org>

No review, I want to tickle the CIA bot to test changes,
and took this as an opportunity to clean up some old change logs.

  • ChangeLog-2005-08-23: update email address
  • ChangeLog-2006-12-31: fix spelling mistakes
11:45 AM Changeset in webkit [26998] by mitz
  • 140 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

  • add "(anonymous)" to the renderName of anonymous table cells, rows and sections
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::renderName):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::renderName):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::renderName):

LayoutTests:

Reviewed by Oliver Hunt.

  • updated results to reflect which table parts are anonymous
11:41 AM Changeset in webkit [26997] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Bug 15476: DOM tree fully expands some elements when arrowing up
​http://bugs.webkit.org/show_bug.cgi?id=15476

Add a new expandTreeElementsWhenArrowing option to TreeOutline. This option
is used only for the sidebar and search results.

  • page/inspector/inspector.js: Opt-in for the sidebar and search results.
  • page/inspector/treeoutline.js: Add expandTreeElementsWhenArrowing and pass this option to traverseNextTreeElement and traversePreviousTreeElement.
11:30 AM Changeset in webkit [26996] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-10-24 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/identifier.h: Remove extra qualification.
11:04 AM Changeset in webkit [26995] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.


Disable ALWAYS_INLINE in debug builds, since it drives the debugger
crazy.

  • wtf/AlwaysInline.h:
11:02 AM Changeset in webkit [26994] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.


Inlined the fast path for creating an Identifier from an Identifier.


This is a .4% speedup on SunSpider overall, but as big as a 2.5%
speedup on certain individual tests. 65% of the Identifiers creating
by SunSpider are already Identifiers.


(The main reason I'm making this change is that it resolves a large
regression in a patch I haven't checked in yet.)

  • JavaScriptCore.exp:
  • kjs/identifier.cpp: (KJS::Identifier::addSlowCase):
  • kjs/identifier.h: (KJS::Identifier::Identifier::add):
10:58 AM Changeset in webkit [26993] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog.

10:56 AM Changeset in webkit [26992] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Geoff and Mitz.

<rdar://problem/5493833>
REGRESSION: ~5MB of image data leaked @ cuteoverload.com (often seen while browsing other sites, too)

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument): If an image element that is currently loading an image is not in the document, it should still be marked.


  • bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::construct): Force the document wrapper to be created.


  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::haveFiredLoadEvent): New method which calls down to the image loader.


  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::HTMLImageLoader): (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::setLoadingImage): (WebCore::HTMLImageLoader::dispatchLoadEvent): Remove code that's not needed anymore.


  • html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::haveFiredLoadEvent): Make this public.
10:27 AM Changeset in webkit [26991] by aroben
  • 6 edits in trunk

Move Windows safe file creation code into WebCore from WebPreferences

WebCore:

Move Windows safe file creation code into WebCore from WebPreferences

Reviewed by Brady.

  • platform/FileSystem.h:
  • platform/win/FileSystemWin.cpp: (WebCore::safeCreateFile): Moved here from WebKit/win/WebPreferences.cpp.

WebKit/win:

Move safe file creation code to WebCore

Reviewed by Brady.

  • WebPreferences.cpp: (preferencesPath): Made into a static helper function. (WebPreferences::save): Now calls WebCore's safeCreateFile function. (WebPreferences::load): Uses String/CString to handle the UTF-8 conversion.
  • WebPreferences.h: Removed preferencesPath and safeCreateFileWithData.
10:27 AM Changeset in webkit [26990] by aroben
  • 6 edits in trunk

Reduce code duplication by using WebCore's FileSystem functions

WebCore:

Add methods to FileSystemWin to get some user profile directories

These directories are used to hold things like preferences, caches,
etc.

Reviewed by Brady.

  • platform/FileSystem.h: Added new method declarations for Windows only.
  • platform/win/FileSystemWin.cpp: (WebCore::bundleName): Added. (WebCore::storageDirectory): Added. (WebCore::cachedStorageDirectory): Added. (WebCore::localUserSpecificStorageDirectory): Added. Returns the directory where WebKit should store any user-specific data that should stay local to the current machine (i.e., shouldn't be stored in a roaming profile). (WebCore::roamingUserSpecificStorageDirectory): Added. Returns the directory where WebKit should store any user-specific data that should move with the user from machine to machine (i.e., should be stored in a roaming profile).

WebKit/win:

Reduce code duplication by using WebCore's FileSystem functions

Reviewed by Brady.

  • WebIconDatabase.cpp: Removed a now-unused function and a fixed FIXME. (WebIconDatabase::init): Changed to use FileSystem functions.
  • WebPreferences.cpp: (WebPreferences::preferencesPath): Ditto.
6:28 AM Changeset in webkit [26989] by bdash
  • 3 edits in trunk/LayoutTests

2007-10-24 Mark Rowe <​mrowe@apple.com>

Fix incorrect test results landed with r26986.

  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt:
6:21 AM Changeset in webkit [26988] by lars
  • 13 edits
    18 adds in trunk/LayoutTests

update some test results for the Qt port.

6:06 AM Changeset in webkit [26987] by alp
  • 2 edits in trunk/WebCore

2007-10-24 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15659
InlineTextBox does not setStrokeStyle() as needed

GraphicsContextCairo workaround to support a GraphicsContextCG quirk:

Save and restore the StrokeStyle manually.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText):
5:49 AM Changeset in webkit [26986] by bdash
  • 5 edits
    6 adds in trunk

2007-10-24 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=15356
Bug 15356: getResponseHeader and getAllResponseHeaders do not throw exceptions

  • getAllResponseHeaders and getResponseHeader throws INVALID_STATE_ERR exception as specified in the specification
  • Add the check to field-name production in getResponseHeader (call to isValidToken) and returns an empty string if the header is not valid (Opera and IE behaviour)
  • Updated XMLHttpRequest::responseMIMEType() to keep its behaviour

Tests: http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html

http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html
http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::responseMIMEType):
  • xml/XMLHttpRequest.h:

2007-10-24 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=15356
getResponseHeader and getAllResponseHeaders do not throw exceptions

  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Added.
5:33 AM Changeset in webkit [26985] by lars
  • 2 edits
    3 adds in trunk/LayoutTests

these tests don't crash anymore :)

5:33 AM Changeset in webkit [26984] by lars
  • 2 edits in trunk/WebKit/qt
  • Stop crashing on fast/events/frame-tab-focus.html the keyEvent can be 0.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

5:33 AM Changeset in webkit [26983] by lars
  • 2 edits in trunk/WebCore

implement most of DragData.

5:33 AM Changeset in webkit [26982] by lars
  • 4 edits in trunk

add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.

5:33 AM Changeset in webkit [26981] by lars
  • 2 edits
    511 adds in trunk/LayoutTests

we're passing most editing tests now. Commit them.

5:33 AM Changeset in webkit [26980] by lars
  • 2 edits in trunk/WebKitTools

add another command.

5:32 AM Changeset in webkit [26979] by lars
  • 2 edits
    1 add
    3 deletes in trunk/LayoutTests

convert the text to be text only, and fix it up a little so it doesn't depend on specific font metrics anymore.

5:32 AM Changeset in webkit [26978] by lars
  • 2 edits in trunk/WebKit/qt

remove some notImplemented() warnings.

5:32 AM Changeset in webkit [26977] by lars
  • 3 edits in trunk/WebKitTools

add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.

5:32 AM Changeset in webkit [26976] by lars
  • 2 edits in trunk/WebCore

remove a stupid notImplemented() warning and implement PasteBoad::clear().

5:32 AM Changeset in webkit [26975] by lars
  • 2 edits in trunk/WebKit/qt

allow paste from DOM so we pass more test cases.

5:32 AM Changeset in webkit [26974] by lars
  • 2 edits in trunk/WebCore

implement Pasteboard::documentFragment(), and fix a mem leak.

5:32 AM Changeset in webkit [26973] by lars
  • 2 edits in trunk/WebKitTools

implement eventSender.keyDown().

5:32 AM Changeset in webkit [26972] by lars
  • 3 edits in trunk/JavaScriptCore

some changes to the way JS values are converted to Qt values in the script bindings. Added support for converting JS arrays into QStringList's.

5:32 AM Changeset in webkit [26971] by lars
  • 5 edits in trunk

Simplify the PlatformKeyEvent constructor. No need to have an extra boolean for isKeyUp in there, as the QKeyEvent has the information.

5:32 AM Changeset in webkit [26970] by lars
  • 5 edits in trunk

some smaller fixes to the editing support in DRT. Makes another few tests pass.

5:32 AM Changeset in webkit [26969] by lars
  • 2 edits in trunk/LayoutTests

explicitly add some tests that currently cause DRT to hang.

5:32 AM Changeset in webkit [26968] by lars
  • 5 edits in trunk/WebKitTools

first bit of implementation for the textinputcontroller.

5:32 AM Changeset in webkit [26967] by lars
  • 2 edits in trunk/WebKit/qt

implemented support for most editing shortcuts to make contentEditable usable.

5:32 AM Changeset in webkit [26966] by lars
  • 2 edits in trunk/WebKit/qt

no need to call setIsActive ourselves on the frame, as the focus controller does it for us.

5:32 AM Changeset in webkit [26965] by lars
  • 2 edits in trunk/WebKitTools

make the man webpage believe it has focus, so the editing tests work correctly.

5:32 AM Changeset in webkit [26964] by lars
  • 3 edits in trunk/WebKitTools

implement layoutTestController.dumpEditingCallbacks() correctly.

5:32 AM Changeset in webkit [26963] by lars
  • 3 edits in trunk/WebCore

use the new QTextBoundaryFinder class in Qt.

5:32 AM Changeset in webkit [26962] by lars
  • 4 edits in trunk

Implement support for testing editing.

1:53 AM Changeset in webkit [26961] by oliver
  • 4 edits in trunk/JavaScriptCore

Remove old relation method, replace with specialised LessThan and lessThenEq functions for a 0.5-0.6% improvement in SunSpider

Reviewed by Darin

1:50 AM Changeset in webkit [26960] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

  • kjs/nodes.h: (KJS::ImmediateNumberNode::): Fix ASSERT correctness (and debug build!)
1:21 AM Changeset in webkit [26959] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • kjs/object.cpp: (KJS::JSObject::defaultValue): Get rid of a little Identifier ref/deref for what SunSpider claims is a 0.4% speedup.
1:14 AM Changeset in webkit [26958] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • separate out the code to create a hash table the first time from the code to rehash

SunSpider claims this was a 0.7% speedup.

  • kjs/property_map.cpp: (KJS::PropertyMap::expand): Changed to call either createTable or rehash. (KJS::PropertyMap::createTable): Added. For the case where we had no table. (KJS::PropertyMap::rehash): Removed code needed only in the case where we had no table.
  • kjs/property_map.h: Added createTable.
1:06 AM Changeset in webkit [26957] by eseidel
  • 5 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by darin.


Add ImmediateNumberNode to hold a JSValue* instead of a double for numbers
which can be represented by JSImmediate.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::NumberNode::evaluate): (KJS::ImmediateNumberNode::evaluate):
  • kjs/nodes.h: (KJS::Node::): (KJS::ImmediateNumberNode::):
  • kjs/nodes2string.cpp: (ImmediateNumberNode::streamTo):
1:03 AM Changeset in webkit [26956] by darin
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Seems to give 0.7% SunSpider speedup.

  • kjs/create_hash_table: Updated to generate new format.
  • kjs/lookup.cpp: (KJS::keysMatch): Took out unneeded typecast. (KJS::findEntry): Updated to expect table type 3 -- changed the printf to a plain old assert. Replaced the modulus with a bit mask. (KJS::Lookup::findEntry): Get the hash directly, since we know identifiers already have computed their hash -- saves a branch. (KJS::Lookup::find): Ditto.
  • kjs/lookup.h: Changed attr from 2-byte value to one-byte value. Replaced hashSize with hashSizeMask.

WebCore:

Reviewed by Maciej.

  • bindings/scripts/CodeGeneratorJS.pm: Updated to generate new format.
12:59 AM Changeset in webkit [26955] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • remove KJS_CHECKEXCEPTIONs in places where exceptions can't happen for 0.6% SunSpider speedup
  • kjs/nodes.cpp: (KJS::DoWhileNode::execute): (KJS::WhileNode::execute): (KJS::ForNode::execute): (KJS::ForInNode::execute): (KJS::SourceElementsNode::execute):
12:41 AM Changeset in webkit [26954] by darin
  • 3 edits in trunk/SunSpider

Reviewed by Eric.

  • sunspider: Open the profile in shark after completing a run.
  • sunspider-compare-results: Tiny perl tweaks.
12:40 AM Changeset in webkit [26953] by hausmann
  • 2 edits in trunk/WebCore

Fix pathByAppendingComponent for the Qt port.

Oct 23, 2007:

11:52 PM Changeset in webkit [26952] by hyatt
  • 2 edits in trunk/WebCore

Make repainting work with transforms.

Reviewed by John Sullivan

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
11:41 PM Changeset in webkit [26951] by darin
  • 1 edit in trunk/SunSpider/hosted

Ignore files generated by the make-hosted script.

11:19 PM Changeset in webkit [26950] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/JSImmediate.h: (KJS::JSImmediate::getUInt32): Changed an && to an & for a 1% gain in SunSpider.
9:40 PM Changeset in webkit [26949] by alp
  • 4 edits in trunk/WebCore

2007-10-23 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14412
[GDK] Clipboard support

Initial clipboard implementation for the GTK+ port.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::~Pasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::plainText):
  • platform/gtk/TemporaryLinkStubs.cpp:
9:35 PM Changeset in webkit [26948] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Fixes the Network panel so that it refreshes as needed.

  • page/inspector/ConsolePanel.js: Call the base class show() and hide() first.
  • page/inspector/NetworkPanel.js: Add refreshNeeded and refreshIfNeeded back. Ditto.
8:47 PM Changeset in webkit [26947] by weinig
  • 2 edits in trunk/WebKitTools

Check for null BSTR that can be passed to the UIDelegate methods
from javascript null and undefined. Fixes a failing test case on
Windows (fast/dom/Window/alert-undefined.html)

Reviewed by Eric Seidel.

  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::webViewAddMessageToConsole):
7:15 PM Changeset in webkit [26946] by mitz
  • 6 edits in trunk/WebCore

Rolled out r26941 because it of layout test failures.

7:01 PM Changeset in webkit [26945] by oliver
  • 4 edits in trunk/JavaScriptCore

Reduce branching in implementations of some operator implementations, yielding 1.3% boost to SunSpider.

Reviewed by Maciej

  • kjs/nodes.cpp: (KJS::MultNode::evaluate): (KJS::DivNode::evaluate): (KJS::ModNode::evaluate): (KJS::add): (KJS::sub): (KJS::AddNode::evaluate): (KJS::SubNode::evaluate): (KJS::valueForReadModifyAssignment):
  • kjs/operations.cpp:
  • kjs/operations.h:
6:59 PM Changeset in webkit [26944] by justing
  • 4 edits in trunk/LayoutTests

Fixing an accidental change made in r25484.

  • editing/pasteboard/quirks-mode-br-1.html:
  • platform/mac/editing/pasteboard/quirks-mode-br-1-expected.checksum:
  • platform/mac/editing/pasteboard/quirks-mode-br-1-expected.txt:
6:56 PM Changeset in webkit [26943] by justing
  • 4 edits in trunk/LayoutTests

Reviewed by Oliver Hunt.


<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time


  • platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
  • platform/mac/editing/input/text-input-controller-expected.txt:
  • platform/mac/editing/input/wrapped-line-char-rect-expected.txt:
6:53 PM Changeset in webkit [26942] by justing
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time


No layout test for now because I'm having trouble getting Undo during a layout
test to only undo the last Undo step, and I want to write a test that fails
without the code change.

  • editing/Editor.cpp: (WebCore::Editor::confirmComposition): When we replace the previous composition, delete it with a sub-command of the command used to insert the new composition, instead of with a separate command. No new code was added because insertText already deletes the current selection. (WebCore::Editor::setComposition): Ditto.
6:51 PM Changeset in webkit [26941] by mitz
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Eric Seidel.

Calling updateWidget() during attach() led to arbitrary (plugin and resource load delegate)
code execution under attach(). The fix is to use the mechanism that's already in place for
deferring updateWidget() until after layout.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::attach): Replaced call to updateWidget() with call to updateWidgetSoon()
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Ditto.
  • manual-tests/paint-during-plugin-attach.html: Added.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidgetSoon): Added this function that schedules the updateWidget() call for after the next layout.
  • rendering/RenderPartObject.h:
6:36 PM Changeset in webkit [26940] by weinig
  • 3 edits in trunk/WebKit/win

Make the WebNotificationCenter work with null (wildcard) and specific
observed objects, matching NSNotificationCenter.

  • Removes the ObserverKey, ObserverHash, and ObserverKeyTraits as we now hash against the notification name only and check the object on notification posting.
  • Use OwnPtr for the WebNotificationCenterPrivate member variable.

Reviewed by Adam Roben.

  • WebNotificationCenter.cpp: (WebNotificationCenter::WebNotificationCenter): (WebNotificationCenter::~WebNotificationCenter): (WebNotificationCenter::postNotificationInternal): (WebNotificationCenter::addObserver): (WebNotificationCenter::postNotification): (WebNotificationCenter::postNotificationName): (WebNotificationCenter::removeObserver):
  • WebNotificationCenter.h:
6:33 PM Changeset in webkit [26939] by sfalken
  • 1 copy in tags/Safari-523.12.8b

New tag.

6:33 PM Changeset in webkit [26938] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

6:30 PM Changeset in webkit [26937] by aroben
  • 2 edits in trunk/WebCore

Fix the behavior of pathByAppendingComponent when path is empty

We now use the Windows Shell API function PathAppendW instead of
rolling our own broken implementation.

Reviewed by Anders.

  • platform/win/FileSystemWin.cpp: (WebCore::pathByAppendingComponent):
5:56 PM Changeset in webkit [26936] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


Don't print a massive pile of setenvs from tools that automatically build testkjs.

  • Scripts/build-testkjs:
5:40 PM Changeset in webkit [26935] by mjs
  • 3 edits
    1 add in trunk

SunSpider:

Reviewed by Darin.

  • Don't hardcode my path to testkjs


  • sunspider-compare-results:

WebKitTools:

Reviewed by Darin.

  • add wrapper that finds the right copy of testkjs


  • Scripts/sunspider-compare-results: Added.
5:12 PM Changeset in webkit [26934] by adele
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872

Test: fast/forms/textfield-onchange-deletion.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Refetch the renderer since arbitrary JS code run during onchange can do anything, including destroying it.

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872

  • fast/forms/textfield-onchange-deletion-expected.txt: Added.
  • fast/forms/textfield-onchange-deletion.html: Added.
5:08 PM Changeset in webkit [26933] by thatcher
  • 8 edits
    7 adds in trunk/WebCore

Reviewed by Sam Weinig.

  • Made seperate files for the various classes in ResourcePanel.js.
  • Broke up ResourcePanel.js and created seperate panel classes for different resource types.
  • Moved View code down to the Panel base-class.
  • Reduced code duplication in DatabasePanel.js by sub-classing from the new ResourcePanel.
  • page/inspector/DatabasePanel.js:
  • page/inspector/DocumentPanel.js: Added.
  • page/inspector/FontPanel.js: Added.
  • page/inspector/ImagePanel.js: Added.
  • page/inspector/Panel.js: Added.
  • page/inspector/PropertiesSection.js: Added.
  • page/inspector/Resource.js:
  • page/inspector/ResourcePanel.js:
  • page/inspector/SidebarPane.js: Added.
  • page/inspector/SourcePanel.js: Added.
  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
4:47 PM Changeset in webkit [26932] by andersca
  • 2 edits in trunk/WebCore

Correct the version #if check.


  • platform/sql/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction):
4:40 PM Changeset in webkit [26931] by sfalken
  • 3 edits in branches/Safari-3-branch/WebCore

Reviewed by Anders.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

It is possible to load Mozilla's Java plugin instead of our own, which
can lead to a crash. The fix is to prefer plugins in our own Plugins
directory when searching for a plugin.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Return the path to our own Plugins directory (WebCore::PluginDatabaseWin::defaultPluginPaths): Use new method safariPluginsPath() (WebCore::PluginDatabaseWin::pluginForMIMEType): If the plugin's path is our Plugins path, return this plugin. Otherwise, continue scanning the list of plugins (WebCore::PluginDatabaseWin::pluginForExtension): Same
  • plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::path): Return this plugin's path
4:30 PM Changeset in webkit [26930] by sfalken
  • 2 edits in branches/Safari-3-branch/WebCore

Fix build.

  • plugins/win/PluginViewWin.cpp:
4:16 PM Changeset in webkit [26929] by honeycutt
  • 3 edits in trunk/WebCore

2007-10-23 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

It is possible to load Mozilla's Java plugin instead of our own, which
can lead to a crash. The fix is to prefer plugins in our own Plugins
directory when searching for a plugin.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Return the path to our own Plugins directory (WebCore::PluginDatabaseWin::defaultPluginPaths): Use new method safariPluginsPath() (WebCore::PluginDatabaseWin::pluginForMIMEType): If the plugin's path is our Plugins path, return this plugin. Otherwise, continue scanning the list of plugins (WebCore::PluginDatabaseWin::pluginForExtension): Same
  • plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::path): Return this plugin's path
4:14 PM Changeset in webkit [26928] by adachan
  • 5 edits in trunk/WebKit/win

<rdar://problem/5244261> SafariWin ignores cookie policy setting "never" in the preferences
Custom WebPreferences (not the shared WebPreferences) could override the cookie accept
policy setting on the default cookie storage. To fix that, I added a new method in
WebView called updateGlobalSettingsFromPreferences() to handle updating the global pref
options such as cookie accept policy, and it's only called to update changes from
the shared WebPreferences.


Use CLSID_WebPreferences and remove IID_WebPreferences.

Reviewed by Darin and Adam.

  • WebPreferences.cpp: (WebPreferences::QueryInterface):
  • WebPreferences.h:
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): (WebView::updateGlobalSettingsFromPreferences): (WebView::updateSettingsFromPreferences): (WebView::developerExtrasEnabled): (WebView::initWithFrame): (WebView::onNotify):
  • WebView.h:
4:11 PM Changeset in webkit [26927] by kmccullo
  • 6 edits in trunk/WebKitTools

Reviewed by Sam.

  • After talking with Steve I now see that the WebKit server must be running for DCOM to create the distributed objects, which makes sense and currently WebKit only allows one instance to be running at a time which avoids accidentally connecting to the wrong server
  • In light of this I have removed the code for the attach box and NotificationServer and known server names, since they are all extranious now.
  • Drosera/win/Drosera.cpp: Removed notification classes and known server names. (_tWinMain): Uses init instead of initUI. (droseraWndProc): No longer creats an attach dialog box. (Drosera::Drosera): Does the OleInitialize so COM is ready to go and it's not manditory to call init before doing COM stuff. (Drosera::init): calls initUI and will call attach when the functionality exists. (Drosera::initUI): Has changed very little. (Drosera::attach): Changed the signature to reflect that we no longer need the dictionary of known server names.
  • Drosera/win/Drosera.h: Removed notification classes and known server names. Also renamed and moved some functions.
  • Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the headers to the resources folder.
  • Drosera/win/resource.h: Removed the Attach box.
3:27 PM Changeset in webkit [26926] by mjs
  • 2 edits
    2 adds in trunk/SunSpider

Reviewed by Darin.


  • Add a compare script to compare results, and improve formatting of standard results a bit.
  • resources/sunspider-analyze-results.js:
  • resources/sunspider-compare-results.js: Added.
  • sunspider-compare-results: Added.
2:25 PM Changeset in webkit [26925] by oliver
  • 6 edits in trunk/JavaScriptCore

Separating all of the simple binary expression nodes into multiple classes

Reviewed by Maciej

Separating all of the simple (eg. non-read-modify-write) binary operators into separate classes in preparation for further JS optimisations.

Happily this produces a 0.8% to 1.0% performance increase in SunSpider with no further work.

12:29 PM Changeset in webkit [26924] by alp
  • 2 edits in trunk/WebCore

2007-10-23 Jasper Bryant-Greene <​m@ni.ac.nz>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15058
Precedence fault in KeyEventGdk causes shift, control, alt etc to work incorrectly

Corrected precendence fault which was causing Shift, Alt, Control and
Meta to behave incorrectly on GTK.

Coding style fix by Alp.

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
12:05 PM BuildingGtk edited by iwkse@claws-mail.org
(diff)
11:25 AM Changeset in webkit [26923] by aroben
  • 2 edits in trunk/LayoutTests

Add some SVG tests to the Windows Skipped file

Reviewed by Oliver.

  • platform/win/Skipped:
11:11 AM Changeset in webkit [26922] by weinig
  • 5 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Add resizing of the DOM view right sidebar. This allows us to actually see the values now.

  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
8:52 AM Changeset in webkit [26921] by hyatt
  • 9 edits in trunk/WebCore

Get basic hit testing right for transforms.

Reviewed by ollliej

  • platform/graphics/AffineTransform.cpp: (WebCore::AffineTransform::mapPoint):
  • platform/graphics/AffineTransform.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
  • rendering/RenderObject.h:
8:49 AM Changeset in webkit [26920] by darin
  • 3 edits in trunk/LayoutTests
  • removed numeric results so the test is more platform-independent
  • fast/js/math-expected.txt: Updated.
  • fast/js/resources/math.js: Updated.
7:12 AM Changeset in webkit [26919] by darin
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

Test: fast/js/math.html

  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): Fix abs to look at the sign bit. Add a special case for values in the range between -0 and -1 and a special case for ceil and for -0 for floor.

LayoutTests:

Reviewed by Maciej.

  • fast/js/math-expected.txt: Added.
  • fast/js/math.html: Added.
  • fast/js/resources/math.js: Added.
5:11 AM Changeset in webkit [26918] by bdash
  • 2 edits in trunk/WebKit

2007-10-23 Mark Rowe <​mrowe@apple.com>

Build fix for Eric's build fix in r26916.

  • MigrateHeaders.make:
2:44 AM Changeset in webkit [26917] by eseidel
  • 2 edits in trunk/WebCore

2007-10-23 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

Fix leaks seen on TOT from new font-face code.

  • ksvg2/svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): use a stack allocated CSSProperty instead of mallocing
1:33 AM Changeset in webkit [26916] by eseidel
  • 3 edits in trunk/WebCore

2007-10-23 Eric Seidel <​eric@webkit.org>

Build fix only, no review.

Sacrifice three virgin hours upon the altar of the heathen XCode gods
and pray that our build troubles are finally over. :(

  • DerivedSources.make: add DOMSVGException.h
  • WebCore.xcodeproj/project.pbxproj: Remove DOMSVG*Interal.h files from "Copy Generated Headers" phase. Why? Who knows.
12:07 AM Changeset in webkit [26915] by mjs
  • 3 edits in trunk/SunSpider

Reviewed by Darin.

  • resources/sunspider-analyze-results.js: Do the error range properly, using the t-distribution instead of 1.96 (which was based on the normal distribution).


  • sunspider: Print results in a way that will be friendlier to the soon-to-come compare mode.
12:00 AM Changeset in webkit [26914] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • streamline exception handling code for a >1% speed-up of SunSpider
  • kjs/nodes.cpp: Changed macros to use functions for everything that's not part of normal execution. We'll take function call overhead when propagating an exception or out of memory. (KJS::createOutOfMemoryCompletion): Added. (KJS::substitute): Use append instead of the relatively inefficient + operator. (KJS::Node::rethrowException): Added.
  • kjs/nodes.h: Added rethrowException.
Note: See TracTimeline for information about the timeline view.