⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 25, 2007:

11:58 PM Changeset in webkit [27094] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

2007-10-26 Mark Rowe <​mrowe@apple.com>

Update expected results.

  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
11:55 PM Changeset in webkit [27093] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Tweaked the inner hashtable lookup loop to remove a branch in the "not
found" case. .5% speedup on SunSpider.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/HashTable.h: (WTF::::lookup):
11:55 PM Changeset in webkit [27092] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-10-26 Mark Rowe <​mrowe@apple.com>

Qt build fix. r27084 added a destructor implementation for LayoutTestController
to the Qt port on the assumption that it was an implementation of the cross-platform
LayoutTestController class. It is not, so it did not need to be changed.

  • DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
11:36 PM Changeset in webkit [27091] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-10-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Fix builds with code coverage enabled.

  • Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
11:19 PM Changeset in webkit [27090] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
  • Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
11:09 PM Changeset in webkit [27089] by mrowe@apple.com
  • 2 moves in releases/Apple

Rename 10.4 and 10.5 release tags.

10:25 PM Changeset in webkit [27088] by mrowe@apple.com
  • 4 copies
    2 adds in releases/Apple/Leopard

Release tags for Mac OS X 10.5.

10:01 PM Changeset in webkit [27087] by slewis
  • 2 edits in trunk/WebKitTools

build Fix

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:10 PM JavaScript performance improvement ideas edited by oliver@apple.com
(diff)
9:06 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
8:58 PM Changeset in webkit [27086] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Oliver.

  • fold together toPrimitive() and toNumber() conversions for 0.5% gain on SunSpider
  • kjs/nodes.cpp: (KJS::SubNode::evaluate): Subtract directly, since toPrimitive() is not adding any value over toNumber() here. (KJS::valueForReadModifyAssignment): Ditto. (KJS::lessThan): Use new getPrimitiveNumber() method to avoid some virtual calls and branches. (KJS::lessThanEq): Ditto.
  • JavaScriptCore.exp: Export new functions as needed.
  • kjs/value.h: (KJS::JSValue::toPrimitive): Fixed formatting. (KJS::JSValue::getPrimitiveNumber): New method - this simultaneously converts to number and tells you whether a toPrimitive() conversion with a Number hint would have given a string.
  • kjs/internal.cpp: (KJS::StringImp::getPrimitiveNumber): Implemented. (KJS::NumberImp::getPrimitiveNumber): ditto (KJS::GetterSetterImp::getPrimitiveNumber): ditto (KJS::StringImp::toPrimitive): Fixed formatting. (KJS::NumberImp::toPrimitive): ditto (KJS::GetterSetterImp::toPrimitive): ditto
  • kjs/internal.h:
  • kjs/object.cpp: (KJS::JSObject::getPrimitiveNumber): Implemented.
  • kjs/object.h:
8:42 PM Changeset in webkit [27085] by slewis
  • 2 edits in trunk/WebKitTools

Weak link against WebCore so DumpRenderTree can be bundled with production roots.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
8:09 PM Changeset in webkit [27084] by aliceli1
  • 7 edits in trunk/WebKitTools

Reviewed by Adam.

Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows

Moving destructor into platform-specific files

  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::~LayoutTestController):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::~LayoutTestController):

LayoutTestController wasn't being destroyed

  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):

Added declspec

  • DumpRenderTree/win/EditingDelegate.h:

Reset certain values on the webview (or related delegate) that might
have changed while running a test

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::~LayoutTestController):
7:46 PM Changeset in webkit [27083] by alp
  • 2 edits in trunk/WebCore

2007-10-26 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15693
[GTK] Paging does not work when widget is added to a GtkScrolledWindow

Eliminate MagicGtkScrollConstant in favour of the same calculations as
GtkTextView for step and page increments. This also makes paging work,
as the page increment was previously always 0.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
6:44 PM Changeset in webkit [27082] by weinig
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

Fix the windows build for real

6:11 PM Changeset in webkit [27081] by weinig
  • 2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

Make debug builds run again.

  • WebView.cpp: (WebView::notifyPreferencesChanged):
6:09 PM Changeset in webkit [27080] by aroben
  • 4 edits in trunk/WebKitLibraries

Add wkSetPatternBaseCTM.

Reviewed by NOBODY.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
6:09 PM Changeset in webkit [27079] by weinig
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Remove JSStringRefCFHack from windows as it is no longer needed.

win:

Reviewed by Adam Roben.

Remove JSStringRefCFHack.

  • WebKit.vcproj/WebKit.vcproj:
5:10 PM Changeset in webkit [27078] by weinig
  • 10 edits
    2 adds in trunk/WebKit/win

Reviewed by Steve Falkenburg.

Fix for <rdar://problem/5463608>
Port WebKit cache model code (Windows needs a big disk cache, smarter memory cache)

  • Interfaces/IWebPreferences.idl: Deprecate pageCacheSize and objectCacheSize and add cacheModel/setCacheModel.
  • Interfaces/IWebPreferencesPrivate.idl: Add automaticallyDetectsCacheModel/setAutomaticallyDetectsCacheModel


  • WebFrame.cpp: (WebFrame::didPerformFirstNavigation): Implement based on the mac version.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitSystemBits.cpp: Added. (WebMemorySize): Moved and renamed from WebPreferences.cpp (WebVolumeFreeSize): Added.
  • WebKitSystemBits.h: Added.
  • WebPreferenceKeysPrivate.h: Added WebKitCacheModelPreferenceKey.
  • WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): (WebPreferences::WebPreferences): (WebPreferences::initializeDefaultSettings): Added default for cacheModel. (WebPreferences::webPreferencesChangedNotification): (WebPreferences::webPreferencesRemovedNotification): (WebPreferences::initWithIdentifier): Post a preferences change notification. (WebPreferences::pageCacheSize): Deprecated. (WebPreferences::objectCacheSize): Deprecated. (WebPreferences::cacheModel): Added. (WebPreferences::setCacheModel): Added. (WebPreferences::setAutomaticallyDetectsCacheModel): Added. (WebPreferences::automaticallyDetectsCacheModel): Added. (WebPreferences::willAddToWebView): Added. (WebPreferences::didRemoveFromWebView): Added.
  • WebPreferences.h:
  • WebView.cpp: (PreferencesChangedOrRemovedObserver::PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::~PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::QueryInterface): (PreferencesChangedOrRemovedObserver::AddRef): (PreferencesChangedOrRemovedObserver::Release): (PreferencesChangedOrRemovedObserver::sharedInstance): (PreferencesChangedOrRemovedObserver::onNotify): (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged): (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved): This singleton class updates static properties for all webviews when preferenceChange or preferenceRemoved notifications are fired for any WebPreference. (WebView::WebView): (WebView::~WebView): (initializeStaticObservers): (allWebViewsSet): (WebView::addToAllWebViewsSet): (WebView::removeFromAllWebViewsSet): (WebView::setCacheModel): (WebView::cacheModel): (WebView::didSetCacheModel): (WebView::maxCacheModelInAnyInstance): (WebView::close): (WebViewWndProc): (WebView::developerExtrasEnabled): (WebView::initWithFrame): (WebView::setPreferences): (WebView::preferences): (WebView::onNotify): (WebView::notifyPreferencesChanged): (updateSharedSettingsFromPreferencesIfNeeded):
  • WebView.h: Match the macs behavior by using explicit postings of notifications to update the preferences.
4:38 PM Changeset in webkit [27077] by aroben
  • 2 edits in trunk/WebKitTools

Make sunspider-compare-results work with relative paths

Reviewed by Sam.

  • Scripts/sunspider-compare-results: Convert arguments to absolute paths before we chdir.
4:33 PM Changeset in webkit [27076] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cg/ImageCG.cpp

Fix unbalanced save/restore on Leopard only.

4:23 PM Changeset in webkit [27075] by aroben
  • 2 edits in trunk/SunSpider

Strip carriage returns from results

Carriage returns were screwing up sunspider-compare-results on
Windows.

Rubberstamped by Oliver.

  • sunspider:
4:17 PM Changeset in webkit [27074] by mitz
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt and Sam Weinig.

Build fix

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
4:16 PM Changeset in webkit [27073] by weinig
  • 3 edits in trunk/WebKitLibraries

Fix the windows build.

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
3:29 PM Changeset in webkit [27072] by ggaren
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Rolled out my last patch. It turns out that I needed 2 words, not 1,
so it didn't help.

3:23 PM Changeset in webkit [27071] by thatcher
  • 4 edits in trunk/WebKitLibraries

Add WKSetPatternBaseCTM.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:13 PM Changeset in webkit [27070] by thatcher
  • 1 delete in trunk/WebKitQt

Remove the empty WebKitQt folders.

2:56 PM Changeset in webkit [27069] by alp
  • 2 edits in trunk/WebCore

2007-10-23 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15656
[GTK] Implement WebCore::Widget::isEnabled/setEnabled

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::isEnabled): (WebCore::Widget::setEnabled): Implemented.
2:37 PM Changeset in webkit [27068] by ggaren
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15694
Shrink the size of an activation object by 1 word


This is in preparation for adding a symbol table to the activation
object.


The basic strategy here is to rely on the mutual exclusion between
the arguments object pointer and the function pointer (you only need
the latter in order to create the former), and store them in the same
place. The LazyArgumentsObject class encapsulates this strategy.


Also inlined the ArgumentsImp constructor, for good measure.


SunSpider reports no regression. Regression tests pass.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Context.cpp: (KJS::Context::~Context):
  • kjs/function.cpp: (KJS::ActivationImp::LazyArgumentsObject::createArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::mark): (KJS::): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::mark):
  • kjs/function.h: (KJS::ActivationImp::LazyArgumentsObject::LazyArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::getOrCreate): (KJS::ActivationImp::LazyArgumentsObject::resetArguments): (KJS::ActivationImp::LazyArgumentsObject::setArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::argumentsObject): (KJS::ActivationImp::LazyArgumentsObject::setFunction): (KJS::ActivationImp::LazyArgumentsObject::function): (KJS::ActivationImp::LazyArgumentsObject::createdArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::): (KJS::ActivationImp::ActivationImp::ActivationImp): (KJS::ActivationImp::resetArguments):
2:32 PM Changeset in webkit [27067] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Weinig also reviewed this patch, and wanted Changelog credit for it

2:26 PM Changeset in webkit [27066] by kmccullo
  • 4 edits in trunk/WebKitTools

Reviewed by Sam.

  • Implemented server calls now the WebScriptDebugServer exists.
  • Also removed no longer needed call to initialize CG.
  • Drosera/win/Drosera.cpp: No longer initializes CG because this happens automatically now. (_tWinMain):
  • Drosera/win/ServerConnection.cpp: Now uses the COM class. (ServerConnection::ServerConnection): (ServerConnection::~ServerConnection): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie):
  • Drosera/win/ServerConnection.h: Now uses the COM class.
2:12 PM Changeset in webkit [27065] by hyatt
  • 3 adds in trunk/LayoutTests/platform/mac/fast/borders

Add border image transforms test.

2:11 PM Changeset in webkit [27064] by hyatt
  • 1 add in trunk/LayoutTests/fast/borders/border-image-scale-transform.html

Add border image transforms test.

2:09 PM Changeset in webkit [27063] by hyatt
  • 3 adds in trunk/LayoutTests/platform/mac/fast/backgrounds/repeat

Add background transform test.

2:08 PM Changeset in webkit [27062] by hyatt
  • 1 add in trunk/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-transformed.html

Add background transform test.

2:03 PM Changeset in webkit [27061] by aroben
  • 9 edits
    1 delete in trunk

Fix some JavaScriptCore build issues

JavaScriptCore:

Change JavaScriptCore.vcproj to use DerivedSources.make

We were trying to emulate the logic of make in
build-generated-files.sh, but we got it wrong. We now use a
build-generated-files very much like the one that WebCore uses to
invoke make.

We also now only have a Debug configuration of dftables which we build
even when doing a Release build of JavaScriptCore. dftables also no
longer has the "_debug" name suffix.

Changes mostly made by Darin, reviewed by me.

  • DerivedSources.make: Add a variable to set the extension used for the dftables executable.
  • JavaScriptCore.vcproj/JavaScriptCore.sln: Updated to use Debug dftables in Release configurations.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
    • Updated include path to point to the new location of the derived sources.
    • Modified pre-build event to pass the right arguments to build-generated-files.sh and not call dftables directly.
    • Added the derived source files to the project.
    • Removed grammarWrapper.cpp, which isn't needed now that we're compiling grammar.cpp directly.
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Slightly modified from the WebCore version.
  • JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Removed.
  • JavaScriptCore.vcproj/dftables/dftables.vcproj:
    • Changed the output location to match Mac.
    • Removed the Release configuration.
    • Removed the _debug suffix.

win:

Update WebKit.sln for the removal of Release dftables

Reviewed by NOBODY.

  • WebKit.vcproj/WebKit.sln:
2:03 PM Changeset in webkit [27060] by hyatt
  • 9 edits in trunk

WebCore:

Fix for bug 15672, background images don't tile properly inside transforms. This patch fixes background
tiling to work in the presence of transforms and fixes bugs in both SVG and CSS transforms.

Reviewed by aroben and mitz

  • WebCore.base.exp:
  • platform/graphics/Image.cpp: (WebCore::Image::setData):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::ImageInfo::ImageInfo): (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Fix for bug 15672, backgrounds don't tile properly inside transforms. This patch fixes tiling
of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
transforms.

Reviewed by aroben and mmitz

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebKit.xcodeproj/project.pbxproj:
1:46 PM Changeset in webkit [27059] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Hatcher


Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
always does, when available.

  • WebView/WebPreferencesPrivate.h: removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with a comment that says that they can be removed when no longer needed. That time is now.
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): removed WebKitUsePDFPreviewViewPreferenceKey (-[WebPreferences _usePDFPreviewView]): removed (-[WebPreferences _setUsePDFPreviewView:]): removed
  • WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): don't check _usePDFPreviewView


  • WebView/WebPreferenceKeysPrivate.h: removed WebKitUsePDFPreviewViewPreferenceKey
1:37 PM Changeset in webkit [27058] by kmccullo
  • 4 edits in trunk/WebKit/win

Rubber stamped by Geoff.

  • Stubbed out the WebScriptDebugServer methods to give Drosera something to connect to and now the signature of the interface matches the mac.
  • Interfaces/IWebScriptDebugServer.idl:
  • WebScriptDebugServer.cpp: (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused):
  • WebScriptDebugServer.h:
1:17 PM Changeset in webkit [27057] by thatcher
  • 2 edits in trunk/WebKitLibraries

Reviewed by Adam.

Update the Leopard WebKitSystemInterface to be 4-way univeral to include 64-bit.

  • libWebKitSystemInterfaceLeopard.a:
12:37 PM Changeset in webkit [27056] by beidson
  • 2 edits in trunk/WebCore

Blind build fix attempt

  • WebCore.pro:
12:26 PM Changeset in webkit [27055] by weinig
  • 4 edits in trunk/WebKitLibraries

Added wrapper for getting the foundation cache directory.

Reviewed by Adam Roben.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:26 PM Changeset in webkit [27054] by beidson
  • 11 edits
    8 moves in trunk/WebCore

Reviewed by Anders

Bulk rename of platform/sql/SQL* to platform/sql/SQLite*

This is more accurate in that there is no realistic "SQL" abstraction, the classes are obviously
tied extremely close to SQLite, and is necessitated by the introduction of "SQLTransaction" in
the HTML5 database API which we are adopting.

11:47 AM Changeset in webkit [27053] by kmccullo
  • 9 edits
    3 moves in trunk/WebKit/win

Reviewed by Darin.

  • Renamed WebDebugProgram to WebScriptDebugServer to match the naming scheme on the mac.
  • Interfaces/IWebDebugProgram.idl: Removed.
  • Interfaces/IWebScriptDebugServer.idl: Copied from win/Interfaces/IWebDebugProgram.idl.
  • Interfaces/WebKit.idl:
  • WebDebugProgram.cpp: Removed.
  • WebDebugProgram.h: Removed.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
  • WebKitDLL.cpp: (RunAsLocalServer):
  • WebScriptDebugServer.cpp: Copied from win/WebDebugProgram.cpp. (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::~WebScriptDebugServer): (WebScriptDebugServer::createInstance): (WebScriptDebugServer::QueryInterface): (WebScriptDebugServer::AddRef): (WebScriptDebugServer::Release): (WebScriptDebugServer::viewAdded): (WebScriptDebugServer::viewRemoved): (WebScriptDebugServer::attach): (WebScriptDebugServer::detach): (WebScriptDebugServer::statistics): (WebScriptDebugServer::webViews):
  • WebScriptDebugServer.h: Copied from win/WebDebugProgram.h.
  • WebView.cpp: (WebView::WebView): (WebView::~WebView):
11:31 AM Changeset in webkit [27052] by ap
  • 4 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15650
XML attribute nodes are not importable

Tests: fast/dom/import-attribute-node.html

fast/dom/import-document-fragment.html

  • dom/Document.cpp: (WebCore::Document::importNode): Implemented for Attribute and DocumentFragment nodes.
11:23 AM Changeset in webkit [27051] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dynamic/insert-before-table-part-in-continuation.html

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's parent is an anonymous table part, let the table figure out where to insert the new child.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/dynamic/insert-before-table-part-in-continuation.html: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
11:21 AM Changeset in webkit [27050] by alp
  • 4 edits in trunk

2007-10-25 Alp Toker <​alp@atoker.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem

Re-enable database support in the GTK+ port, with a fix.

Initialize GLib threading as early as possible.

10:51 AM Changeset in webkit [27049] by sfalken
  • 5 edits in branches/Safari-3-branch/WebCore

Merged fix from r27048.

10:35 AM Changeset in webkit [27048] by honeycutt
  • 5 edits in trunk/WebCore

2007-10-25 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

Previous patch erroneously compared a path and a
path-including-filename. This corrects that. It also caches the result
of safariPluginsPath() and uses shell API funcs for determining filename
and parent directory from a full path.

  • ChangeLog:
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Cache return value. Use API functions to build the path (WebCore::PluginDatabaseWin::pluginForMIMEType): Compare again plugin's parent directory, not full path (WebCore::PluginDatabaseWin::pluginForExtension): Same
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Store parent directory
  • plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::parentDirectory):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):
8:00 AM Changeset in webkit [27047] by alp
  • 4 edits in trunk

2007-10-25 Alp Toker <​alp@atoker.com>

Unreviewed fix to make the GTK+ port run.

​http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem

​http://bugs.webkit.org/show_bug.cgi?id=15688
[GTK] Make it possible to disable database support

Disable database support until #15686 is fixed.

6:44 AM Changeset in webkit [27046] by hausmann
  • 2 edits in trunk/WebCore

Fixed a crash in the Qt 4.4 based text iterators when they're called with a null string.

6:41 AM Changeset in webkit [27045] by hausmann
  • 7 edits in trunk
  • We need to set a != 0 status code for the fast/loader/xmlhttprequest-missing-file-exception.html
  • libxml2 has the semantic that when writing an empty string and finishing it will report an error. For QXmlStreamReader this is valid.
  • This is causing some regressions...

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27044] by hausmann
  • 4 edits
    1 delete in trunk
  • Make fast/loader/xmlhttprequest-bad-mimetype.html pass. We use QHttp to download local files but we may not set the HTTP result code on the ResourceResponse.
  • We can use the cross-platform result now. QWebNetworkInterface/Manager behaves the same as mac for local files.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27043] by hausmann
  • 6 edits in trunk
  • fast/dom/onerror-img.html regressed due checking the JobStates because in case of error (e.g. not being able to connect) the job will no be started.
  • Use the error message from Qt. It might or might not be translated.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27042] by hausmann
  • 2 edits in trunk/WebKit/qt
  • Use the JobStatus to make sure to not deliver finished/data before the job has started. This is the case with the fast/dom/onerror-img.html test case.
  • We have no idea if any data will come so we can still finish and then get pending data. This luckily can't happen for the local file case.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27041] by hausmann
  • 4 edits in trunk/WebKit/qt
  • No need to initialize values in the QWebNetworkJob c'tor
  • Add a JobStatus to QWebNetworkJob and verify that the jobs are handled in the way we expect them to be handled. This means no data after the job has finished, not finishing a job before it has been started.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27040] by hausmann
  • 2 edits in trunk/WebKit/qt
  • Consistency: Always name the jobs job.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:40 AM Changeset in webkit [27039] by hausmann
  • 8 edits in trunk
  • Implement our own queuing of network jobs to allow special handling of synchronous jobs. This makes us pass the fast/dom/xmlhttprequest-html-response-encoding.html test without a crash. Sync jobs will get a special treatment over the normals ones and in theory more than one sync job is supported.
  • This should be thread-safe besides QWebNetworkJob::{ref,deref}

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:40 AM Changeset in webkit [27038] by hausmann
  • 4 edits in trunk
  • Do the percent replacement only when we are not base64. With base64 we should not have any % in it anyway.
  • Have a custom decodePercentEncoding method that works without doing any charset conversion. With converting back to latin1() we lost some information.
  • We pass the char-decoding.html test now

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

5:36 AM Changeset in webkit [27037] by alp
  • 3 edits in trunk/WebCore

2007-10-25 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Add support for list box theme colors and styled menu list buttons.

Remove obsolete FIXMEs.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::adjustMenuListStyle): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkTreeView):
  • platform/gtk/RenderThemeGtk.h:
4:55 AM Changeset in webkit [27036] by ap
  • 1 edit in trunk/WebKitSite/ChangeLog

Corrected ChangeLog entry.

4:53 AM Changeset in webkit [27035] by ap
  • 2 edits in trunk/WebKitSite

Rubber-stamped by Mark Rowe.

  • images/download.png: Updated to say "Nightly builds" instead of

"Nightly (6 MB)" - the Mac version is ~17 MB now, and this isn't a direct
download link anyway.

4:36 AM Changeset in webkit [27034] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r27033 as it broke the JavaScriptCore tests.

2:59 AM Changeset in webkit [27033] by eseidel
  • 2 edits in trunk/JavaScriptCore

HackTop [30311:JavaScriptCore]% less ChangeLog Stuff/Projects/WebKit/JavaScriptCore
2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.


Start work on long-running-mode from the perl-script side of things.
jsDriver.pl will likely be removed (and replaced by something better)
But for now, I'm just hacking it down to something smaller.

  • tests/mozilla/jsDriver.pl: Remove lots of unused code.
2:25 AM Changeset in webkit [27032] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.


Slightly elaborated the differences between declaration procesing in
Function Code and Program Code.


.3% speedup on SunSpider.

  • kjs/nodes.cpp: (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): Store a minimum set of attributes instead of recomputing all the time. Also, ignore m_parameters, since programs don't have arguments.
2:08 AM Changeset in webkit [27031] by eseidel
  • 3 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


More preparation work before adding long-running mode to testkjs.

  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (prettyPrintScript): (runWithScripts): (parseArguments): (kjsmain): (fillBufferWithContentsOfFile):
1:53 AM Changeset in webkit [27030] by aroben
  • 1 add in trunk/WebKit/win/Interfaces/IWebTextRenderer.idl

Forgot to check in this file in r27019

1:37 AM Changeset in webkit [27029] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


Bring testkjs code out of the dark ages in preparation for more
radical improvements (like long-running testing support!)

  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (setupInterpreter): (doIt): (fillBufferWithContentsOfFile):
1:11 AM Changeset in webkit [27028] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Make a fast path for declaration processing inside Function Code.


Lifted declaration processing code up from individual declaration nodes
and into processDeclarations.


Broke out processDeclarations into two cases, depending on the type of
code. This eliminates 2 branches, and facilitates more radical
divergeance in the future.


2.5% SunSpider speedup.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::initializeDeclarationStacks): (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): (KJS::FunctionBodyNode::execute): (KJS::FuncDeclNode::makeFunction):
  • kjs/nodes.h: (KJS::):
12:26 AM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
12:16 AM Changeset in webkit [27027] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • add header includes needed on platforms that don't use AllInOneFile.cpp
  • API/JSCallbackObject.cpp:
  • kjs/Context.cpp:
  • kjs/ExecState.cpp:
  • kjs/array_instance.cpp:
  • kjs/function_object.cpp:
  • kjs/interpreter.cpp:
  • kjs/nodes.cpp:
12:14 AM Changeset in webkit [27026] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

  • JavaScriptCore.xcodeproj/project.pbxproj: re-mark JSGlobalObject.h as private
12:09 AM Changeset in webkit [27025] by ggaren
  • 6 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15683
Re-order declaration initialization to avoid calling hasProperty inside
VarDeclNode::processDeclaration


.7% speedup on SunSpider.

  • kjs/function.h:
  • kjs/function.cpp: Merged parameter processing into FunctionBodyNode's other processing of declared symbols, so the order of execution could change.
  • kjs/nodes.cpp: (KJS::VarDeclNode::getDeclarations): Added special case for the "arguments" property name, explained in the comment.

(KJS::VarDeclNode::processDeclaration): Removed call to hasProperty
in the case of function code, since we know the declared symbol
management will resolve conflicts between symbols. Yay!

(KJS::VarDeclListNode::getDeclarations): Now that VarDeclNode's
implementation of getDeclarations is non-trivial, we can't take a
short-cut here any longer -- we need to put the VarDecl node on the
stack so it gets processed normally.

(KJS::FunctionBodyNode::processDeclarations): Changed the order of
processing to enforce mutual exclusion rules.

  • kjs/nodes.h: (KJS::DeclarationStacks::DeclarationStacks): Structure includes an ExecState now, for fast access to the "arguments" property name.

LayoutTests:

Layout tests for bugs that might result from changes like
​http://bugs.webkit.org/show_bug.cgi?id=15683

  • fast/js/vardecl-preserve-parameters-expected.txt: Added.
  • fast/js/vardecl-preserve-parameters.html: Added.
  • fast/js/vardecl-preserve-vardecl-expected.txt: Added.
  • fast/js/vardecl-preserve-vardecl.html: Added.
12:08 AM Changeset in webkit [27024] by eseidel
  • 2 edits in trunk/WebCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

  • bindings/js/kjs_window.h: fix bogus comment, s/DOMNode/DOMObject/
12:07 AM Changeset in webkit [27023] by eseidel
  • 4 edits in trunk/JavaScriptGlue

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.


Make JSG build again after JSGlobalObject change.

  • JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
  • JSRun.h: (JSInterpreter::JSInterpreter):
  • JSUtils.h:

Oct 24, 2007:

11:38 PM Changeset in webkit [27022] by eseidel
  • 31 edits
    1 copy
    1 add in trunk

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


Add a JSGlobalObject class and remove the InterpreterMap
​http://bugs.webkit.org/show_bug.cgi?id=15681


This required making JSCallbackObject a template class to allow for
JSGlobalObjects with JSCallbackObject functionality.


SunSpider claims this was a 0.5% speedup.

  • API/JSCallbackObject.cpp: (KJS::):
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: Copied from API/JSCallbackObject.cpp. (KJS::::JSCallbackObject): (KJS::::init): (KJS::::~JSCallbackObject): (KJS::::initializeIfNeeded): (KJS::::className): (KJS::::getOwnPropertySlot): (KJS::::put): (KJS::::deleteProperty): (KJS::::implementsConstruct): (KJS::::construct): (KJS::::implementsHasInstance): (KJS::::hasInstance): (KJS::::implementsCall): (KJS::::callAsFunction): (KJS::::getPropertyNames): (KJS::::toNumber): (KJS::::toString): (KJS::::setPrivate): (KJS::::getPrivate): (KJS::::inherits): (KJS::::cachedValueGetter): (KJS::::staticValueGetter): (KJS::::staticFunctionGetter): (KJS::::callbackGetter):
  • API/JSClassRef.cpp: (OpaqueJSClass::prototype):
  • API/JSContextRef.cpp: (JSGlobalContextCreate):
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectGetPrivate): (JSObjectSetPrivate):
  • API/JSValueRef.cpp: (JSValueIsObjectOfClass):
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
  • bindings/jni/jni_jsobject.cpp:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
  • kjs/Context.cpp: (KJS::Context::Context):
  • kjs/ExecState.cpp: (KJS::ExecState::lexicalInterpreter):
  • kjs/JSGlobalObject.h: Added. (KJS::JSGlobalObject::JSGlobalObject): (KJS::JSGlobalObject::isGlobalObject): (KJS::JSGlobalObject::interpreter): (KJS::JSGlobalObject::setInterpreter):
  • kjs/array_instance.cpp:
  • kjs/context.h:
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/interpreter.cpp: (KJS::Interpreter::Interpreter): (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::globalObject): (KJS::Interpreter::initGlobalObject): (KJS::Interpreter::evaluate):
  • kjs/interpreter.h:
  • kjs/lookup.h: (KJS::cacheGlobalObject):
  • kjs/object.h: (KJS::JSObject::isGlobalObject):
  • kjs/testkjs.cpp:
11:26 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
10:38 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
10:33 PM Changeset in webkit [27021] by staikos
  • 2 edits in trunk/WebKitTools

unbreak Qt build

10:23 PM Changeset in webkit [27020] by aroben
  • 7 edits
    2 adds in trunk

Fix <rdar://5549919> Add font database initialization code to WebCore and call it from WebKit

WebCore:

Add font database initialization code to WebCore

Reviewed by Ada.

  • WebCore.vcproj/WebCore.vcproj: Added FontDatabase.{cpp,h}.
  • platform/win/FontDatabase.cpp: Added. (WebCore::systemFontsDirectory): (WebCore::fontsPlistPath): (WebCore::systemHasFontsNewerThanFontsPlist): (WebCore::readFontPlist): (WebCore::populateFontDatabaseFromPlist): (WebCore::populateFontDatabaseFromFileSystem): (WebCore::writeFontDatabaseToPlist): (WebCore::populateFontDatabase): This is the only function callable from outside this file. It populates the font database once, either from the fonts plist, or from the filesystem (and then saves a new fonts plist).
  • platform/win/FontDatabase.h: Added.

WebKitTools:

Remove now-unnecessary call to InitializeCoreGraphics

WebKit takes care of this now.

Reviewed by Ada.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize):

WebKit/win:

Fix <rdar://5549919> Initialize the font database before any font code is invoked

We initialize the database in two places:

  1. When instantiating WebKitClassFactory, which is guaranteed to happen before any WebView is instantiated.
  2. When making a WebCore::Font in WebKitGraphics.

This ensures that the font database will be populated before any font
code is invoked. We rely on WebCore to only populate the database
once.

Reviewed by Ada.

  • WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Populate the font database.
  • WebKitGraphics.cpp: (makeFont): Ditto.
10:22 PM Changeset in webkit [27019] by aroben
  • 9 edits
    2 copies in trunk

Add [I]WebTextRenderer

WebKitTools:

Use WebTextRenderer in DRT

Reviewed by Ada.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Use WebTextRenderer instead of using InitializeCoreGraphics/AddFontResourceEx.

WebKit/win:

Add [I]WebTextRenderer

Right now this class can only be used to add private fonts for use by
the running process, but will eventually be the home of the
WebKitGraphics functions.

Reviewed by Ada.

  • ForEachCoClass.h: Added WebTextRenderer.
  • Interfaces/WebKit.idl: Ditto.
  • WebKit.vcproj/Interfaces.vcproj: Ditto.
  • WebKit.vcproj/WebKit.vcproj: Ditto.
  • WebKit.vcproj/WebKitGUID.vcproj: Ditto.
  • WebKitClassFactory.cpp: Ditto.
  • WebTextRenderer.cpp: Added. (WebTextRenderer::createInstance): (WebTextRenderer::WebTextRenderer): (WebTextRenderer::~WebTextRenderer): (WebTextRenderer::QueryInterface): (WebTextRenderer::AddRef): (WebTextRenderer::Release): (WebTextRenderer::registerPrivateFont):
  • WebTextRenderer.h: Added.
10:22 PM Changeset in webkit [27018] by aroben
  • 4 edits in trunk/WebKit/win

Use FOR_EACH_COCLASS in WebKitClassFactory

Reviewed by Ada.

  • WebError.cpp: (WebError::createInstance): Added an overload that takes no arguments to make the macro used in WebKitClassFactory work.
  • WebError.h:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Use FOR_EACH_COCLASS.
10:22 PM Changeset in webkit [27017] by aroben
  • 3 edits
    1 add in trunk/WebKit/win

Put FOR_EACH_COCLASS macro into its own file and export it

The macro used to be called FOR_EACH_CLASS and lived in WebKitDLL.cpp.
This way we will be able to use the macro in more places that care
about all WebKit's COM classes.

Reviewed by Ada.

  • ForEachCoClass.h: Added.
  • WebKit.vcproj/WebKit.vcproj: Copy ForEachCoClass.h to WebKitOutputDir, and added it to the project.
  • WebKitDLL.cpp: Updated for macro rename, and changed to #undef the macros we pass to FOR_EACH_COCLASS after we're done with them.
10:20 PM Changeset in webkit [27016] by aroben
  • 4 edits in trunk/WebKitLibraries

Added some font-related functions needed for <rdar://5549919>

Reviewed by Ada.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
10:01 PM Changeset in webkit [27015] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

2007-10-24 Sven Herzberg <​sven@imendio.com>

Reviewed by Mark Rowe.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=15614
Bug 15614: [GTK] qmake based backends don't build on OS X

  • Scripts/build-webkit: set QMAKESPEC correctly if building the QT or GTK backend on a Mac
  • Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into isDarwin() to make it reusable in other places (like the workaround- for-prebuilt-qmake in build-webkit)
8:51 PM Changeset in webkit [27014] by ddkilzer
  • 2 edits in trunk/WebKitTools

Refurbish update-webkit script.

Reviewed by Adam.

Scripts/update-webkit: Add -hhelp switch and usage statement. Check result of
GetOptions() call. Fix -qquiet switch to be passed to svn command properly. Use

multi-argument version of system() for flexibility and security. Check for existence
of Internal directory using -d test instead of -x.

8:50 PM Changeset in webkit [27013] by ddkilzer
  • 2 edits in trunk/WebKitTools

Minor clean-up of prepare-ChangeLog script.

Reviewed by Adam.

  • Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead of a string. Use multi-argument versions of open() and system() for flexibility and security.
7:40 PM Changeset in webkit [27012] by adachan
  • 2 edits in trunk/WebKit/win

<rdar://problem/5552221> REGRESSION(310A24-ToT): Shortcut key disable. (15604)

Reviewed by Adam.

  • WebView.cpp: (WebView::handleEditingKeyboardEvent): don't handle system key events as text input (WebView::keyDown): only remove WM_SYSCHAR message from the queue if we handle it. For WM_SYSCHAR message that we don't handle, let it stay in the queue and return false to let windows handle it.
6:19 PM Changeset in webkit [27011] by aroben
  • 15 edits in trunk

Touch all files that include *.lut.h to fix Windows builds

6:16 PM Changeset in webkit [27010] by bdash
  • 2 edits in trunk/WebKit/gtk

2007-10-24 Mark Rowe <​mrowe@apple.com>

Gtk build fix. Track WebCore changes in r27004.

  • Api/webkitgtkglobal.cpp:
5:58 PM Changeset in webkit [27009] by justing
  • 6 edits in trunk

WebCore:

Reviewed by Darin Adler.

Correcting the fix for:
<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time


Made removal of the previous composition part of the current Undo step in the
case where the new composition is the empty string, too.

  • editing/Editor.cpp: (WebCore::Editor::confirmComposition): Call the new TypingCommand::deleteSelection, which either has the currently open typing command delete the current selection, or opens a new typing command (of type DeleteSelection) if one is not already open. (WebCore::Editor::setComposition): Ditto.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Added. (WebCore::TypingCommand::doApply): Handle DeleteSelection. (WebCore::TypingCommand::deleteKeyPressed): Clarified which deleteSelection is called. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::preservesTypingStyle): Handle DeleteSelection.
  • editing/TypingCommand.h:

LayoutTests:

Reviewed by Darin.


<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time

  • platform/mac/editing/input/text-input-controller-expected.txt: The delete we were using previously to remove the old composition makes fewer calls to the editing delegate.
5:30 PM Changeset in webkit [27008] by weinig
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
5:10 PM Changeset in webkit [27007] by thatcher
  • 1 edit in trunk/WebKitTools/Scripts/build-webkit

Build fix.

4:55 PM Changeset in webkit [27006] by thatcher
  • 4 edits
    2 adds
    1 delete in trunk

WebKit:

Reviewed by Mark Rowe.

<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard

Use the WebKitSystemInterface that matches the system version.

  • Configurations/DebugRelease.xcconfig:
  • WebKit.xcodeproj/project.pbxproj:

WebKitLibraries:

Reviewed by Mark Rowe.

<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard

Add system specific versions of WebKitSystemInterface.

  • libWebKitSystemInterface.a: Removed.
  • libWebKitSystemInterfaceLeopard.a: Added.
  • libWebKitSystemInterfaceTiger.a: Added.
4:29 PM Changeset in webkit [27005] by aliceli1
  • 7 edits in trunk

WebCore:

Reviewed by Oliver.

Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe): Some mouse move events are actually drags, which on mac return early from this function. Adding the same logic to its Windows equivalent.

WebKitTools:

Reviewed by Oliver.

Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows

Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
replay the saved events when we're still processing the mousedown that starts the drag

  • DumpRenderTree/win/EventSender.cpp: (doMouseMove):
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop):

LayoutTests:

Removing fixed test

  • platform/win/Skipped:
4:02 PM Changeset in webkit [27004] by beidson
  • 10 edits
    2 adds in trunk

WebCore:

Reviewed by Anders

<rdar://5554130> DatabaseTracker.o has a global initializer

Since DatabaseTracker is a singleton, it makes much more sense to keep the database path as a member variable.
Now constructing the shared DatabaseTracker no longer implicitly opens it - It is only opened when the databases
path is set.


  • WebCore.vcproj/WebCore.vcproj: Copy WebCore/storage headers for WebKit build


  • storage/Database.cpp: (WebCore::Database::~Database): Remove bogus assertion


  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Does nothing now! Move this code to openTrackerDatabase (WebCore::DatabaseTracker::setDatabasePath): Set the member variable, also closing/opening the database if needed (WebCore::DatabaseTracker::databasePath): (WebCore::DatabaseTracker::openTrackerDatabase): To open and validate the Databases db, moved from the c'tor (WebCore::DatabaseTracker::fullPathForDatabase): Return the member variable
  • storage/DatabaseTracker.h:


WebKit/win:

Reviewed by Anders

Windows portion of <rdar://5554130>


Slowly introduce Windows WebKit portion of the Database API that sets the
on-disk location for databases


  • WebDatabaseManager.cpp: Added. (WebKitSetWebDatabasesPathIfNecessary):
  • WebDatabaseManager.h: Added.


  • WebKit.vcproj/WebKit.vcproj:


  • WebView.cpp: (WebView::initWithFrame): Call WebKitSetWebDatabasesPathIfNecessary()


WebKit:

Reviewed by Anders

<rdar://problem/5554130> DatabaseTracker.o has a global initializer

  • Misc/WebDatabaseManager.mm: (WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
4:00 PM Changeset in webkit [27003] by kmccullo
  • 11 edits
    2 adds in trunk

WebKitTools:

Reviewed by Sam, Steve and Darin.

  • Stubbed out the WebScriptDebugListener functionality in the Server Connection class to prepare it for receiving those callbacks.
  • Also I changed the instantiation of DebuggerClient, DebuggerDocument and the ServerConnection to not need to be initialized with a server name, since that is not the way we connect to the WebKit server.
  • Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging no exception. Now it only loggs when there is an exception (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::callFunctionOnObject):
  • Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection to be instantiated with a server's name. (DebuggerClient::DebuggerClient): (DebuggerClient::didFinishLoadForFrame):
  • Drosera/win/DebuggerClient.h: Removed unsued variable.
  • Drosera/win/Drosera.cpp: Client no longer needs to be initialized with a server name. (Drosera::init): (Drosera::initServer):
  • Drosera/win/Drosera.h: No longer need the ServerConnection to be instantiated with a server's name.
  • Drosera/win/ServerConnection.cpp: (ServerConnection::ServerConnection): No longer needs a server name (ServerConnection::~ServerConnection): Only release the global context if there is one. (ServerConnection::serverConnectionDidDie): Stub for IWebScriptDebugListener (ServerConnection::QueryInterface): ditto (ServerConnection::AddRef): ditto (ServerConnection::Release): ditto (ServerConnection::didLoadMainResourceForDataSource): ditto (ServerConnection::didParseSource): ditto (ServerConnection::failedToParseSource): ditto (ServerConnection::didEnterCallFrame): ditto (ServerConnection::willExecuteStatement): ditto (ServerConnection::willLeaveCallFrame): ditto (ServerConnection::exceptionWasRaised): ditto
  • Drosera/win/ServerConnection.h: Stubbed out the IWebScriptDebugListener functions, and this class no longer needs to be instantiated with a server name.

win:

Reviewed by Sam, Steve and Darin.

  • Added stubs for what will be neede to let Drosera attach to the WebKit process and debug it.
  • Interfaces/IWebScriptCallFrame.idl: Added.
  • Interfaces/IWebScriptDebugListener.idl: Added.
  • Interfaces/WebKit.idl:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
3:10 PM Changeset in webkit [27002] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Build fix for Gtk, no review.

  • kjs/collector.cpp: #include "context.h"
2:31 PM Changeset in webkit [27001] by eseidel
  • 5 edits
    2 adds in trunk

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


Stop checking isOutOfMemory after every allocation, instead let the collector
notify all ExecStates if we ever hit this rare condition.


SunSpider claims this was a 2.2% speedup.

  • kjs/collector.cpp: (KJS::Collector::collect): (KJS::Collector::reportOutOfMemoryToAllInterpreters):
  • kjs/collector.h:
  • kjs/nodes.cpp: (KJS::TryNode::execute):
1:33 PM Changeset in webkit [27000] by hyatt
  • 3 edits in trunk/WebCore

Don't try to gap fill transformed selections. Fix the invalidation of selection to use the clip to visible content
code path so that it works with multi-column layouts and transforms.

Reviewed by aroben

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::fillSelectionGaps):
  • rendering/RenderView.cpp: (WebCore::RenderView::setSelection):
1:25 PM Changeset in webkit [26999] by eseidel
  • 3 edits in trunk/WebCore

2007-10-24 Eric Seidel <​eric@webkit.org>

No review, I want to tickle the CIA bot to test changes,
and took this as an opportunity to clean up some old change logs.

  • ChangeLog-2005-08-23: update email address
  • ChangeLog-2006-12-31: fix spelling mistakes
11:45 AM Changeset in webkit [26998] by mitz
  • 140 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

  • add "(anonymous)" to the renderName of anonymous table cells, rows and sections
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::renderName):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::renderName):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::renderName):

LayoutTests:

Reviewed by Oliver Hunt.

  • updated results to reflect which table parts are anonymous
11:41 AM Changeset in webkit [26997] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Bug 15476: DOM tree fully expands some elements when arrowing up
​http://bugs.webkit.org/show_bug.cgi?id=15476

Add a new expandTreeElementsWhenArrowing option to TreeOutline. This option
is used only for the sidebar and search results.

  • page/inspector/inspector.js: Opt-in for the sidebar and search results.
  • page/inspector/treeoutline.js: Add expandTreeElementsWhenArrowing and pass this option to traverseNextTreeElement and traversePreviousTreeElement.
11:30 AM Changeset in webkit [26996] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-10-24 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/identifier.h: Remove extra qualification.
11:04 AM Changeset in webkit [26995] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.


Disable ALWAYS_INLINE in debug builds, since it drives the debugger
crazy.

  • wtf/AlwaysInline.h:
11:02 AM Changeset in webkit [26994] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.


Inlined the fast path for creating an Identifier from an Identifier.


This is a .4% speedup on SunSpider overall, but as big as a 2.5%
speedup on certain individual tests. 65% of the Identifiers creating
by SunSpider are already Identifiers.


(The main reason I'm making this change is that it resolves a large
regression in a patch I haven't checked in yet.)

  • JavaScriptCore.exp:
  • kjs/identifier.cpp: (KJS::Identifier::addSlowCase):
  • kjs/identifier.h: (KJS::Identifier::Identifier::add):
10:58 AM Changeset in webkit [26993] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog.

10:56 AM Changeset in webkit [26992] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Geoff and Mitz.

<rdar://problem/5493833>
REGRESSION: ~5MB of image data leaked @ cuteoverload.com (often seen while browsing other sites, too)

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument): If an image element that is currently loading an image is not in the document, it should still be marked.


  • bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::construct): Force the document wrapper to be created.


  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::haveFiredLoadEvent): New method which calls down to the image loader.


  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::HTMLImageLoader): (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::setLoadingImage): (WebCore::HTMLImageLoader::dispatchLoadEvent): Remove code that's not needed anymore.


  • html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::haveFiredLoadEvent): Make this public.
10:27 AM Changeset in webkit [26991] by aroben
  • 6 edits in trunk

Move Windows safe file creation code into WebCore from WebPreferences

WebCore:

Move Windows safe file creation code into WebCore from WebPreferences

Reviewed by Brady.

  • platform/FileSystem.h:
  • platform/win/FileSystemWin.cpp: (WebCore::safeCreateFile): Moved here from WebKit/win/WebPreferences.cpp.

WebKit/win:

Move safe file creation code to WebCore

Reviewed by Brady.

  • WebPreferences.cpp: (preferencesPath): Made into a static helper function. (WebPreferences::save): Now calls WebCore's safeCreateFile function. (WebPreferences::load): Uses String/CString to handle the UTF-8 conversion.
  • WebPreferences.h: Removed preferencesPath and safeCreateFileWithData.
10:27 AM Changeset in webkit [26990] by aroben
  • 6 edits in trunk

Reduce code duplication by using WebCore's FileSystem functions

WebCore:

Add methods to FileSystemWin to get some user profile directories

These directories are used to hold things like preferences, caches,
etc.

Reviewed by Brady.

  • platform/FileSystem.h: Added new method declarations for Windows only.
  • platform/win/FileSystemWin.cpp: (WebCore::bundleName): Added. (WebCore::storageDirectory): Added. (WebCore::cachedStorageDirectory): Added. (WebCore::localUserSpecificStorageDirectory): Added. Returns the directory where WebKit should store any user-specific data that should stay local to the current machine (i.e., shouldn't be stored in a roaming profile). (WebCore::roamingUserSpecificStorageDirectory): Added. Returns the directory where WebKit should store any user-specific data that should move with the user from machine to machine (i.e., should be stored in a roaming profile).

WebKit/win:

Reduce code duplication by using WebCore's FileSystem functions

Reviewed by Brady.

  • WebIconDatabase.cpp: Removed a now-unused function and a fixed FIXME. (WebIconDatabase::init): Changed to use FileSystem functions.
  • WebPreferences.cpp: (WebPreferences::preferencesPath): Ditto.
6:28 AM Changeset in webkit [26989] by bdash
  • 3 edits in trunk/LayoutTests

2007-10-24 Mark Rowe <​mrowe@apple.com>

Fix incorrect test results landed with r26986.

  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt:
6:21 AM Changeset in webkit [26988] by lars
  • 13 edits
    18 adds in trunk/LayoutTests

update some test results for the Qt port.

6:06 AM Changeset in webkit [26987] by alp
  • 2 edits in trunk/WebCore

2007-10-24 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15659
InlineTextBox does not setStrokeStyle() as needed

GraphicsContextCairo workaround to support a GraphicsContextCG quirk:

Save and restore the StrokeStyle manually.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText):
5:49 AM Changeset in webkit [26986] by bdash
  • 5 edits
    6 adds in trunk

2007-10-24 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=15356
Bug 15356: getResponseHeader and getAllResponseHeaders do not throw exceptions

  • getAllResponseHeaders and getResponseHeader throws INVALID_STATE_ERR exception as specified in the specification
  • Add the check to field-name production in getResponseHeader (call to isValidToken) and returns an empty string if the header is not valid (Opera and IE behaviour)
  • Updated XMLHttpRequest::responseMIMEType() to keep its behaviour

Tests: http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html

http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html
http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::responseMIMEType):
  • xml/XMLHttpRequest.h:

2007-10-24 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=15356
getResponseHeader and getAllResponseHeaders do not throw exceptions

  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Added.
5:33 AM Changeset in webkit [26985] by lars
  • 2 edits
    3 adds in trunk/LayoutTests

these tests don't crash anymore :)

5:33 AM Changeset in webkit [26984] by lars
  • 2 edits in trunk/WebKit/qt
  • Stop crashing on fast/events/frame-tab-focus.html the keyEvent can be 0.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

5:33 AM Changeset in webkit [26983] by lars
  • 2 edits in trunk/WebCore

implement most of DragData.

5:33 AM Changeset in webkit [26982] by lars
  • 4 edits in trunk

add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.

5:33 AM Changeset in webkit [26981] by lars
  • 2 edits
    511 adds in trunk/LayoutTests

we're passing most editing tests now. Commit them.

5:33 AM Changeset in webkit [26980] by lars
  • 2 edits in trunk/WebKitTools

add another command.

5:32 AM Changeset in webkit [26979] by lars
  • 2 edits
    1 add
    3 deletes in trunk/LayoutTests

convert the text to be text only, and fix it up a little so it doesn't depend on specific font metrics anymore.

5:32 AM Changeset in webkit [26978] by lars
  • 2 edits in trunk/WebKit/qt

remove some notImplemented() warnings.

5:32 AM Changeset in webkit [26977] by lars
  • 3 edits in trunk/WebKitTools

add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.

5:32 AM Changeset in webkit [26976] by lars
  • 2 edits in trunk/WebCore

remove a stupid notImplemented() warning and implement PasteBoad::clear().

5:32 AM Changeset in webkit [26975] by lars
  • 2 edits in trunk/WebKit/qt

allow paste from DOM so we pass more test cases.

5:32 AM Changeset in webkit [26974] by lars
  • 2 edits in trunk/WebCore

implement Pasteboard::documentFragment(), and fix a mem leak.

5:32 AM Changeset in webkit [26973] by lars
  • 2 edits in trunk/WebKitTools

implement eventSender.keyDown().

5:32 AM Changeset in webkit [26972] by lars
  • 3 edits in trunk/JavaScriptCore

some changes to the way JS values are converted to Qt values in the script bindings. Added support for converting JS arrays into QStringList's.

5:32 AM Changeset in webkit [26971] by lars
  • 5 edits in trunk

Simplify the PlatformKeyEvent constructor. No need to have an extra boolean for isKeyUp in there, as the QKeyEvent has the information.

5:32 AM Changeset in webkit [26970] by lars
  • 5 edits in trunk

some smaller fixes to the editing support in DRT. Makes another few tests pass.

5:32 AM Changeset in webkit [26969] by lars
  • 2 edits in trunk/LayoutTests

explicitly add some tests that currently cause DRT to hang.

5:32 AM Changeset in webkit [26968] by lars
  • 5 edits in trunk/WebKitTools

first bit of implementation for the textinputcontroller.

5:32 AM Changeset in webkit [26967] by lars
  • 2 edits in trunk/WebKit/qt

implemented support for most editing shortcuts to make contentEditable usable.

5:32 AM Changeset in webkit [26966] by lars
  • 2 edits in trunk/WebKit/qt

no need to call setIsActive ourselves on the frame, as the focus controller does it for us.

5:32 AM Changeset in webkit [26965] by lars
  • 2 edits in trunk/WebKitTools

make the man webpage believe it has focus, so the editing tests work correctly.

5:32 AM Changeset in webkit [26964] by lars
  • 3 edits in trunk/WebKitTools

implement layoutTestController.dumpEditingCallbacks() correctly.

5:32 AM Changeset in webkit [26963] by lars
  • 3 edits in trunk/WebCore

use the new QTextBoundaryFinder class in Qt.

5:32 AM Changeset in webkit [26962] by lars
  • 4 edits in trunk

Implement support for testing editing.

1:53 AM Changeset in webkit [26961] by oliver
  • 4 edits in trunk/JavaScriptCore

Remove old relation method, replace with specialised LessThan and lessThenEq functions for a 0.5-0.6% improvement in SunSpider

Reviewed by Darin

1:50 AM Changeset in webkit [26960] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

  • kjs/nodes.h: (KJS::ImmediateNumberNode::): Fix ASSERT correctness (and debug build!)
1:21 AM Changeset in webkit [26959] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • kjs/object.cpp: (KJS::JSObject::defaultValue): Get rid of a little Identifier ref/deref for what SunSpider claims is a 0.4% speedup.
1:14 AM Changeset in webkit [26958] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • separate out the code to create a hash table the first time from the code to rehash

SunSpider claims this was a 0.7% speedup.

  • kjs/property_map.cpp: (KJS::PropertyMap::expand): Changed to call either createTable or rehash. (KJS::PropertyMap::createTable): Added. For the case where we had no table. (KJS::PropertyMap::rehash): Removed code needed only in the case where we had no table.
  • kjs/property_map.h: Added createTable.
1:06 AM Changeset in webkit [26957] by eseidel
  • 5 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by darin.


Add ImmediateNumberNode to hold a JSValue* instead of a double for numbers
which can be represented by JSImmediate.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::NumberNode::evaluate): (KJS::ImmediateNumberNode::evaluate):
  • kjs/nodes.h: (KJS::Node::): (KJS::ImmediateNumberNode::):
  • kjs/nodes2string.cpp: (ImmediateNumberNode::streamTo):
1:03 AM Changeset in webkit [26956] by darin
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Seems to give 0.7% SunSpider speedup.

  • kjs/create_hash_table: Updated to generate new format.
  • kjs/lookup.cpp: (KJS::keysMatch): Took out unneeded typecast. (KJS::findEntry): Updated to expect table type 3 -- changed the printf to a plain old assert. Replaced the modulus with a bit mask. (KJS::Lookup::findEntry): Get the hash directly, since we know identifiers already have computed their hash -- saves a branch. (KJS::Lookup::find): Ditto.
  • kjs/lookup.h: Changed attr from 2-byte value to one-byte value. Replaced hashSize with hashSizeMask.

WebCore:

Reviewed by Maciej.

  • bindings/scripts/CodeGeneratorJS.pm: Updated to generate new format.
12:59 AM Changeset in webkit [26955] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • remove KJS_CHECKEXCEPTIONs in places where exceptions can't happen for 0.6% SunSpider speedup
  • kjs/nodes.cpp: (KJS::DoWhileNode::execute): (KJS::WhileNode::execute): (KJS::ForNode::execute): (KJS::ForInNode::execute): (KJS::SourceElementsNode::execute):
12:41 AM Changeset in webkit [26954] by darin
  • 3 edits in trunk/SunSpider

Reviewed by Eric.

  • sunspider: Open the profile in shark after completing a run.
  • sunspider-compare-results: Tiny perl tweaks.
12:40 AM Changeset in webkit [26953] by hausmann
  • 2 edits in trunk/WebCore

Fix pathByAppendingComponent for the Qt port.

Note: See TracTimeline for information about the timeline view.