⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 26, 2007:

9:42 PM Changeset in webkit [27141] by weinig
  • 5 edits in trunk/WebCore

Enable dragging the left sidebar using the separator.

Reviewed by Anders (unless Mitz says otherwise).

  • page/inspector/DocumentPanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
8:40 PM Changeset in webkit [27140] by weinig
  • 2 edits in trunk/WebCore

Fix an off by one error when resizing the Inspector find window.

Reviewed by Hyatt.

  • page/inspector/inspector.js:
7:56 PM Changeset in webkit [27139] by honeycutt
  • 2 edits in trunk/WebCore

2007-10-26 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Fix fallout from r26072, which leads to all plugin streams for local
resources being cancelled

  • loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Ensure this is an HTTP response before checking the HTTP response code
7:50 PM Changeset in webkit [27138] by hyatt
  • 2 edits
    4 adds in trunk

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15719, transformed box doesn't repaint properly
when only translation changes.

Move the updating of the transform to in between the old repaint and the new repaint.

Reviewed by mitz

fast/repaint/transform-translate.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
6:45 PM Changeset in webkit [27137] by kmccullo
  • 2 edits
    2 moves in trunk/JavaScriptCore

Rubber stamp by Adam.

  • Renamed JSStringRefCOM to JSStringRefBSTR since it he only thing the files contain are functions that operate on BSTRs.
  • API/JSStringRefBSTR.cpp: Copied from API/JSStringRefCOM.cpp.
  • API/JSStringRefBSTR.h: Copied from API/JSStringRefCOM.h.
  • API/JSStringRefCOM.cpp: Removed.
  • API/JSStringRefCOM.h: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
6:38 PM Changeset in webkit [27136] by kmccullo
  • 3 edits in trunk/WebKitTools

Reviewed by Adam.

  • Implemented the WebScriptDebugListener functions now that the WebScriptDebugServer exists
  • Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener functions. (ServerConnection::currentFrame): (ServerConnection::didLoadMainResourceForDataSource): (ServerConnection::didParseSource): (ServerConnection::failedToParseSource): (ServerConnection::didEnterCallFrame): (ServerConnection::willExecuteStatement): (ServerConnection::willLeaveCallFrame): (ServerConnection::exceptionWasRaised):
  • Drosera/win/ServerConnection.h: Removed unused arguments from the members arguments list.
6:37 PM Changeset in webkit [27135] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Made JSStringCreateWithBSTR capable of handling null BSTRs.
  • API/JSStringRefCOM.cpp: (JSStringCreateWithBSTR):
6:01 PM Changeset in webkit [27134] by weinig
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/SymbolTable.h: Add header gaurd.
  • kjs/nodes.h: #include "SymbolTable.h"
4:33 PM Changeset in webkit [27133] by ggaren
  • 2 edits in trunk/JavaScriptCore

Suggested by Anders Carlsson.


Fixed tyop.

  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):
4:31 PM Changeset in webkit [27132] by ggaren
  • 2 edits in trunk/JavaScriptCore

Suggested by Darin Adler.


Use computedHash(), which is safer than just directly accessing _hash.

  • kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):
4:07 PM Changeset in webkit [27131] by honeycutt
  • 5 edits in trunk/WebCore

2007-10-26 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://5557379> Crash in Silverlight when opening microsoft.com

The crash is within Silverlight, and the latest version of the plugin
does not exhibit this crash, so just avoid loading this version of the
plugin.

  • plugins/win/PluginDatabaseWin.cpp: Added isPluginBlacklisted() and constants silverlightPluginMinRequiredVersionMSDWORD and silverlightPluginMinRequiredVersionLSDWORD. Their values are taken from the version info of Silverlight 1.0.20926.0, which is a version known not to exhibit this crash (WebCore::PluginDatabaseWin::isPluginBlacklisted): Determine whether this plugin is blacklisted
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Initialize m_fileVersion* (WebCore::PluginPackageWin::getFileVersion): (WebCore::PluginPackageWin::storeFileVersion): Read version info for the plugin, and store the file version (WebCore::PluginPackageWin::fetchInfo): After determining the name, description, and file version, determine whether this plug-in is blacklisted. If so, return false so this plug-in isn't loaded
  • plugins/win/PluginPackageWin.h:
3:59 PM Changeset in webkit [27130] by ggaren
  • 1 edit
    1 add in trunk/JavaScriptCore

Build fix: svn add SymbolTable.h

  • kjs/SymbolTable.h: Added. (KJS::SymbolTable::set): (KJS::SymbolTable::get):
3:54 PM Changeset in webkit [27129] by ggaren
  • 2 edits in trunk/JavaScriptCore

Build fix: export SymbolTable.h to WebCore.

3:47 PM Changeset in webkit [27128] by ggaren
  • 2 edits in trunk/JavaScriptCore

Comment tweak suggested by Maciej.

  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):
3:45 PM Changeset in webkit [27127] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Tweaked property maps to remove 2 branches. 2.5% speedup on SunSpider.

  • kjs/property_map.cpp: Use a special no branch accessor to the UString's hash value. Also, return immediately instead of branching to the end of the loop if the value is not found. (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::remove): (KJS::PropertyMap::checkConsistency):
  • kjs/ustring.h: (KJS::UString::Rep::computedHash): Special no branch accessor to the UString's hash value. Used when the caller knows that the hash value has already been computed. (For example, if the caller got the UString from an Identifier.)
3:43 PM Changeset in webkit [27126] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Switched ActivationImp to using a symbol table. For now, though, all
clients take the slow path.


Net .6% speedup on SunSpider.


Slowdowns:

  • ActivationImp now mallocs in its constructor
  • Local variable hits use an extra level of indirection to retrieve data
  • Local variable misses do two lookups

Speedups:

  • Fast initialization of local variables upon function entry


  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Malloc a private structure to hold data that won't fit in a JSCell. (KJS::ActivationImp::argumentsGetter): Use slow symbol table path for lookup. (KJS::ActivationImp::getOwnPropertySlot): ditto (KJS::ActivationImp::deleteProperty): ditto (KJS::ActivationImp::put): ditto (KJS::ActivationImp::createArgumentsObject): ditto

(KJS::ActivationImp::mark): Call JSObject::mark first so that one of
our properties doesn't try to recursively mark us. (This caused a crash
in earlier testing. Not sure why we haven't run into it before.)

  • kjs/nodes.cpp: Functions now build a symbol table the first time they're called. (KJS::VarDeclNode::evaluate): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::initializeSymbolTable): (KJS::FunctionBodyNode::processDeclarations): (KJS::FunctionBodyNode::processDeclarationsForFunctionCode): (KJS::FunctionBodyNode::processDeclarationsForProgramCode):
  • kjs/nodes.h: (KJS::FunctionBodyNode::symbolTable):
  • wtf/Forward.h: Added Vector.
2:44 PM Changeset in webkit [27125] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Adele Peterson.

Fix for <rdar://problem/5421754>
m_frameName member variable in HTMLPlugInElement unnecessary

  • Refactor the willRemove() method down into HTMLFrameOwnerElement now that we no longer need to use the m_frameName variable.
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
  • html/HTMLFrameOwnerElement.h:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
2:28 PM Changeset in webkit [27124] by kmccullo
  • 1 edit in trunk/JavaScriptCore/ChangeLog
  • Corrected function name mistake in this changelog.
2:19 PM Changeset in webkit [27123] by kmccullo
  • 6 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Sam and Steve.

  • Added convenience methods for converting between BSTR and JSStringRefs
  • API/JSStringRefCOM.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString):
  • API/JSStringRefCOM.h: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

win:

Reviewed by Sam and Steve.

  • Added convenience methods for converting between BSTR and JSSTringRefs
  • Added WebKit_debug.def to the project.
  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKit_debug.def:
2:03 PM Changeset in webkit [27122] by adele
  • 1 edit in trunk/WebCore/WebCore.base.exp

Reverting an unintentional added symbol

1:55 PM Changeset in webkit [27121] by adele
  • 2 edits in trunk/WebCore

Export _wkDrawCapsLockIndicator.

  • WebCore.base.exp:
1:28 PM Changeset in webkit [27120] by adele
  • 2 edits in trunk/WebKitLibraries

Reviewed by Tim Hatcher.

Updating header too for WKDrawCapsLockIndicator.

  • WebKitSystemInterface.h:
12:52 PM Changeset in webkit [27119] by adele
  • 8 edits in trunk

WebCore:

Reviewed by Oliver.

Adding WebKitSystemInterface support for the caps lock indicator

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Oliver.

Adding WebKitSystemInterface support for the caps lock indicator

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Oliver.

Adding wkDrawCapsLockIndicator in preparation for fixing the caps lock indicator.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
12:22 PM Changeset in webkit [27118] by tristan
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5555053> REGRESSION:9A581: Window disappears when opening ​http://research.microsoft.com/users/darkok/
The problem was caused by checkin r24654. This change moved explicit bounds checking into adjustWindowRect
but failed to account for bounds checking (instead replaced with bounds clipping). This caused issues
when NaN was used. This patch goes one step further and does NaN checking to prevent the possibility of
setting window bounds to NaN before an update occurs.

Test: fast/dom/Window/window-resize-nan.html


  • bindings/js/kjs_window.cpp: (KJS::adjustWindowRect): Added a new parameter, pendingChanges, which takes pending changes to the window rect, and if they are valid (not NaN) sets them on window.


(KJS::WindowFunc::callAsFunction):
Adjusted uses of adjustWindowRect to take new update parameter.

LayoutTests:

Reviewed by Darin Adler.


Added new test cases to handle non-number input to window adjusting
functions like resizeTo, resizeBy, moveTo, and moveBy for
<rdar://problem/5555053>.

  • fast/dom/Window/window-resize-nan-expected.txt: Added.
  • fast/dom/Window/window-resize-nan.html: Added.
11:39 AM Changeset in webkit [27117] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15175
Cannot copy text of errors from Web Inspector from Console view

  • page/inspector/inspector.css: add -webkit-user-select: text for console messages.
11:17 AM Changeset in webkit [27116] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15446
Web Inspector find window is not resizable

  • Adds ability to resize the find window.
  • Fixes bug that messed up the find window when resizing the left sidebar.
  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
10:15 AM Changeset in webkit [27115] by sfalken
  • 1 copy in tags/Safari-523.12.9b

New tag.

10:15 AM Changeset in webkit [27114] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

9:34 AM Changeset in webkit [27113] by adachan
  • 2 edits in trunk/WebCore

Update m_current index after we've removed an item:

  • if item removed is before m_current, decrement m_current
  • if the current item is removed, make sure m_current is within bounds.

Reviewed by Darin.

  • history/BackForwardList.cpp: (WebCore::BackForwardList::removeItem):
8:38 AM Changeset in webkit [27112] by ddkilzer
  • 3 edits
    1 add in trunk/WebKitTools

prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
<​http://bugs.webkit.org/show_bug.cgi?id=15600>

Reviewed by Darin.

The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
a patch of the local changes and applying it with a fuzz level of 3 to the new file.
If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
file. Note that it may also be used as a stand-alone script.

  • Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
  • Scripts/resolve-ChangeLogs: Added.
  • Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
6:34 AM Changeset in webkit [27111] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/kjs/collector.cpp

Restore the semicolon.

6:31 AM Changeset in webkit [27110] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • kjs/collector.cpp: (KJS::Collector::collect):
5:22 AM Changeset in webkit [27109] by mrowe@apple.com
  • 2 edits in trunk/WebKit/qt

2007-10-26 Mark Rowe <​mrowe@apple.com>

Build fix. Add missing #include of Platform.h.

  • Api/qwebhistoryinterface.cpp:
5:07 AM Changeset in webkit [27108] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Debug build fix.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
5:06 AM Changeset in webkit [27107] by oliver
  • 6 edits in trunk/JavaScriptCore

Make the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in SunSpider.

Reviewed by Maciej

  • kjs/CollectorHeapIntrospector.cpp: (KJS::CollectorHeapIntrospector::init): (KJS::CollectorHeapIntrospector::enumerate):
  • kjs/CollectorHeapIntrospector.h:
  • kjs/collector.cpp: (KJS::Collector::recordExtraCost): (KJS::Collector::heapAllocate): (KJS::Collector::allocate): (KJS::Collector::allocateNumber): (KJS::Collector::registerThread): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::sweep): (KJS::Collector::collect):
  • kjs/collector.h:
  • kjs/internal.h: (KJS::NumberImp::operator new): Force numbers to be allocated in the secondary heap.
4:53 AM Changeset in webkit [27106] by mjs
  • 2 edits in trunk/WebCore

No review, build fix.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): (-[WebScriptObject setException:]):
4:50 AM Changeset in webkit [27105] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Rubber Stamped by Mark.

  • fix build
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:48 AM Changeset in webkit [27104] by mjs
  • 2 edits in trunk/WebCore

Rubber Stamped by Oliver.

  • fix build
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:46 AM Changeset in webkit [27103] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • encourage GCC a little harder to inline a few hot functions for 1.5% improvement on SunSpider.
  • kjs/value.h: (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): (KJS::JSValue::toNumber):
  • wtf/PassRefPtr.h: (WTF::PassRefPtr::~PassRefPtr):
  • wtf/RefPtr.h: (WTF::RefPtr::operator->):
3:45 AM Changeset in webkit [27102] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog ordering.

3:44 AM Changeset in webkit [27101] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/ExecState.h:
3:36 AM Changeset in webkit [27100] by mjs
  • 8 edits in trunk/JavaScriptCore

Windows build fix.

2:38 AM Changeset in webkit [27099] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

2:38 AM Changeset in webkit [27098] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

1:32 AM Changeset in webkit [27097] by mjs
  • 17 edits
    1 add
    2 deletes in trunk

JavaScriptCore:

Reviewed by Oliver.


  • moved Context class into ExecState.{h,cpp} in preparation for merging ExecState and Context classes.
  • kjs/ExecState.h: Moved CodeType enum and Context class here in preparation for merging ExecState and Context.
  • kjs/ExecState.cpp: Moved Context class here from Context.cpp. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark):
  • kjs/context.h: Removed.
  • kjs/Context.cpp: Removed.
  • kjs/function.h: Removed CodeType enum.
  • kjs/LabelStack.h: Added. Pulled LabelStack class out of internal.h.
  • kjs/internal.h: Removed LabelStack.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new file, removed ones that are gone.
  • kjs/collector.cpp: Fixed includes.
  • kjs/function.cpp: ditto
  • kjs/internal.cpp: ditto
  • kjs/interpreter.cpp: ditto
  • kjs/lookup.h: ditto
  • kjs/nodes.cpp: ditto

WebCore:

Reviewed by Oliver.

  • bindings/objc/WebScriptObject.mm:
  • bridge/mac/WebCoreScriptDebugger.mm:
1:13 AM Changeset in webkit [27096] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • kjs/string_object.cpp: (KJS::StringObjectFuncImp::callAsFunction):
12:51 AM Changeset in webkit [27095] by darin
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Gives about 1% gain on SunSpider.

  • kjs/value.h: Added toIntegerPreserveNan, removed toUInt16. (KJS::JSValue::toInt32): Changed to call getTruncatedInt32 in a way that works with both immediate and number values. (KJS::JSValue::toUInt32): Ditto.
  • kjs/value.cpp: (KJS::JSValue::toInteger): Moved the logic from roundValue here, with a couple differences. One is that it now correctly returns 0 for NaN, and another is that there's no special case for 0 or infinity, since the general case already handles those correctly. (KJS::JSValue::toIntegerPreserveNaN): Added. Like toInteger, but without the check for NaN. (KJS::JSValue::toInt32SlowCase): Call toNumber instead of roundValue. The truncation done by the typecast already does the necessary truncation that roundValue was doing. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Removed.
  • kjs/internal.h: Removed roundValue.
  • kjs/internal.cpp: Ditto.
  • kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Remove unneeded code to handle NaN in Array.slice; toInteger now never returns NaN as specified.
  • kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): Replaced call to roundValue with a call to toNumber as specified. (KJS::DateProtoFunc::callAsFunction): In SetTime case, replaced call to roundValue with a call to toNumber and timeClip as specified. (KJS::DateObjectImp::construct): Removed unnecessary checks of numArgs in cases where the default behavior of toInt32 (returning 0) was already correct. Replaced call to roundValue with a call to toNumber as specified. (KJS::DateObjectFuncImp::callAsFunction): Ditto.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed unnecessary special cases for the pow function that the library already handles correctly.
  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Changed ToString to call toIntegerPreserveNaN, so we can continue to handle the NaN case differently. The real toInteger now returns 0 for NaN. Took out unneeded special case in ToFixed for undefined; was only needed because our toInteger was wrong. Same thing in ToExponential. Changed ToPrecision to call toIntegerPreserveNaN.
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Took out CharAt and CharCodeAt special cases for undefined that were only needed because toInteger was wrong. Same in IndexOf, and was able to remove some special cases. In LastIndexOf, used toIntegerPreserveNaN, but was able to remove some special cases there too. Changed Substr implementation to preserve correct behavior with the change to toInteger and match the specification. Also made sure we weren't converting an out of range double to an int. (KJS::StringObjectFuncImp::callAsFunction): Changed constructor to just use toUInt32, because truncating toUInt32 to 16 bits is the same thing and there's no reason to have toUInt16 as a second, less-optimized function that's only called at this one call site.
  • wtf/MathExtras.h: Added trunc function for Windows.

LayoutTests:

Reviewed by Maciej.

  • fast/js/resources/char-at.js: Updated test to expect that we get the first character if we pass NaN to charAt and charCodeAt; it's what the specification asks for and matches other browsers too.
  • fast/js/char-at-expected.txt: Updated.

Oct 25, 2007:

11:58 PM Changeset in webkit [27094] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

2007-10-26 Mark Rowe <​mrowe@apple.com>

Update expected results.

  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
11:55 PM Changeset in webkit [27093] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Tweaked the inner hashtable lookup loop to remove a branch in the "not
found" case. .5% speedup on SunSpider.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/HashTable.h: (WTF::::lookup):
11:55 PM Changeset in webkit [27092] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-10-26 Mark Rowe <​mrowe@apple.com>

Qt build fix. r27084 added a destructor implementation for LayoutTestController
to the Qt port on the assumption that it was an implementation of the cross-platform
LayoutTestController class. It is not, so it did not need to be changed.

  • DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
11:36 PM Changeset in webkit [27091] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-10-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Fix builds with code coverage enabled.

  • Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
11:19 PM Changeset in webkit [27090] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
  • Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
11:09 PM Changeset in webkit [27089] by mrowe@apple.com
  • 2 moves in releases/Apple

Rename 10.4 and 10.5 release tags.

10:25 PM Changeset in webkit [27088] by mrowe@apple.com
  • 4 copies
    2 adds in releases/Apple/Leopard

Release tags for Mac OS X 10.5.

10:01 PM Changeset in webkit [27087] by slewis
  • 2 edits in trunk/WebKitTools

build Fix

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:10 PM JavaScript performance improvement ideas edited by oliver@apple.com
(diff)
9:06 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
8:58 PM Changeset in webkit [27086] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Oliver.

  • fold together toPrimitive() and toNumber() conversions for 0.5% gain on SunSpider
  • kjs/nodes.cpp: (KJS::SubNode::evaluate): Subtract directly, since toPrimitive() is not adding any value over toNumber() here. (KJS::valueForReadModifyAssignment): Ditto. (KJS::lessThan): Use new getPrimitiveNumber() method to avoid some virtual calls and branches. (KJS::lessThanEq): Ditto.
  • JavaScriptCore.exp: Export new functions as needed.
  • kjs/value.h: (KJS::JSValue::toPrimitive): Fixed formatting. (KJS::JSValue::getPrimitiveNumber): New method - this simultaneously converts to number and tells you whether a toPrimitive() conversion with a Number hint would have given a string.
  • kjs/internal.cpp: (KJS::StringImp::getPrimitiveNumber): Implemented. (KJS::NumberImp::getPrimitiveNumber): ditto (KJS::GetterSetterImp::getPrimitiveNumber): ditto (KJS::StringImp::toPrimitive): Fixed formatting. (KJS::NumberImp::toPrimitive): ditto (KJS::GetterSetterImp::toPrimitive): ditto
  • kjs/internal.h:
  • kjs/object.cpp: (KJS::JSObject::getPrimitiveNumber): Implemented.
  • kjs/object.h:
8:42 PM Changeset in webkit [27085] by slewis
  • 2 edits in trunk/WebKitTools

Weak link against WebCore so DumpRenderTree can be bundled with production roots.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
8:09 PM Changeset in webkit [27084] by aliceli1
  • 7 edits in trunk/WebKitTools

Reviewed by Adam.

Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows

Moving destructor into platform-specific files

  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::~LayoutTestController):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::~LayoutTestController):

LayoutTestController wasn't being destroyed

  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):

Added declspec

  • DumpRenderTree/win/EditingDelegate.h:

Reset certain values on the webview (or related delegate) that might
have changed while running a test

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::~LayoutTestController):
7:46 PM Changeset in webkit [27083] by alp
  • 2 edits in trunk/WebCore

2007-10-26 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15693
[GTK] Paging does not work when widget is added to a GtkScrolledWindow

Eliminate MagicGtkScrollConstant in favour of the same calculations as
GtkTextView for step and page increments. This also makes paging work,
as the page increment was previously always 0.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
6:44 PM Changeset in webkit [27082] by weinig
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

Fix the windows build for real

6:11 PM Changeset in webkit [27081] by weinig
  • 2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

Make debug builds run again.

  • WebView.cpp: (WebView::notifyPreferencesChanged):
6:09 PM Changeset in webkit [27080] by aroben
  • 4 edits in trunk/WebKitLibraries

Add wkSetPatternBaseCTM.

Reviewed by NOBODY.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
6:09 PM Changeset in webkit [27079] by weinig
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Remove JSStringRefCFHack from windows as it is no longer needed.

win:

Reviewed by Adam Roben.

Remove JSStringRefCFHack.

  • WebKit.vcproj/WebKit.vcproj:
5:10 PM Changeset in webkit [27078] by weinig
  • 10 edits
    2 adds in trunk/WebKit/win

Reviewed by Steve Falkenburg.

Fix for <rdar://problem/5463608>
Port WebKit cache model code (Windows needs a big disk cache, smarter memory cache)

  • Interfaces/IWebPreferences.idl: Deprecate pageCacheSize and objectCacheSize and add cacheModel/setCacheModel.
  • Interfaces/IWebPreferencesPrivate.idl: Add automaticallyDetectsCacheModel/setAutomaticallyDetectsCacheModel


  • WebFrame.cpp: (WebFrame::didPerformFirstNavigation): Implement based on the mac version.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitSystemBits.cpp: Added. (WebMemorySize): Moved and renamed from WebPreferences.cpp (WebVolumeFreeSize): Added.
  • WebKitSystemBits.h: Added.
  • WebPreferenceKeysPrivate.h: Added WebKitCacheModelPreferenceKey.
  • WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): (WebPreferences::WebPreferences): (WebPreferences::initializeDefaultSettings): Added default for cacheModel. (WebPreferences::webPreferencesChangedNotification): (WebPreferences::webPreferencesRemovedNotification): (WebPreferences::initWithIdentifier): Post a preferences change notification. (WebPreferences::pageCacheSize): Deprecated. (WebPreferences::objectCacheSize): Deprecated. (WebPreferences::cacheModel): Added. (WebPreferences::setCacheModel): Added. (WebPreferences::setAutomaticallyDetectsCacheModel): Added. (WebPreferences::automaticallyDetectsCacheModel): Added. (WebPreferences::willAddToWebView): Added. (WebPreferences::didRemoveFromWebView): Added.
  • WebPreferences.h:
  • WebView.cpp: (PreferencesChangedOrRemovedObserver::PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::~PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::QueryInterface): (PreferencesChangedOrRemovedObserver::AddRef): (PreferencesChangedOrRemovedObserver::Release): (PreferencesChangedOrRemovedObserver::sharedInstance): (PreferencesChangedOrRemovedObserver::onNotify): (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged): (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved): This singleton class updates static properties for all webviews when preferenceChange or preferenceRemoved notifications are fired for any WebPreference. (WebView::WebView): (WebView::~WebView): (initializeStaticObservers): (allWebViewsSet): (WebView::addToAllWebViewsSet): (WebView::removeFromAllWebViewsSet): (WebView::setCacheModel): (WebView::cacheModel): (WebView::didSetCacheModel): (WebView::maxCacheModelInAnyInstance): (WebView::close): (WebViewWndProc): (WebView::developerExtrasEnabled): (WebView::initWithFrame): (WebView::setPreferences): (WebView::preferences): (WebView::onNotify): (WebView::notifyPreferencesChanged): (updateSharedSettingsFromPreferencesIfNeeded):
  • WebView.h: Match the macs behavior by using explicit postings of notifications to update the preferences.
4:38 PM Changeset in webkit [27077] by aroben
  • 2 edits in trunk/WebKitTools

Make sunspider-compare-results work with relative paths

Reviewed by Sam.

  • Scripts/sunspider-compare-results: Convert arguments to absolute paths before we chdir.
4:33 PM Changeset in webkit [27076] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cg/ImageCG.cpp

Fix unbalanced save/restore on Leopard only.

4:23 PM Changeset in webkit [27075] by aroben
  • 2 edits in trunk/SunSpider

Strip carriage returns from results

Carriage returns were screwing up sunspider-compare-results on
Windows.

Rubberstamped by Oliver.

  • sunspider:
4:17 PM Changeset in webkit [27074] by mitz
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt and Sam Weinig.

Build fix

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
4:16 PM Changeset in webkit [27073] by weinig
  • 3 edits in trunk/WebKitLibraries

Fix the windows build.

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
3:29 PM Changeset in webkit [27072] by ggaren
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Rolled out my last patch. It turns out that I needed 2 words, not 1,
so it didn't help.

3:23 PM Changeset in webkit [27071] by thatcher
  • 4 edits in trunk/WebKitLibraries

Add WKSetPatternBaseCTM.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:13 PM Changeset in webkit [27070] by thatcher
  • 1 delete in trunk/WebKitQt

Remove the empty WebKitQt folders.

2:56 PM Changeset in webkit [27069] by alp
  • 2 edits in trunk/WebCore

2007-10-23 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15656
[GTK] Implement WebCore::Widget::isEnabled/setEnabled

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::isEnabled): (WebCore::Widget::setEnabled): Implemented.
2:37 PM Changeset in webkit [27068] by ggaren
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15694
Shrink the size of an activation object by 1 word


This is in preparation for adding a symbol table to the activation
object.


The basic strategy here is to rely on the mutual exclusion between
the arguments object pointer and the function pointer (you only need
the latter in order to create the former), and store them in the same
place. The LazyArgumentsObject class encapsulates this strategy.


Also inlined the ArgumentsImp constructor, for good measure.


SunSpider reports no regression. Regression tests pass.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Context.cpp: (KJS::Context::~Context):
  • kjs/function.cpp: (KJS::ActivationImp::LazyArgumentsObject::createArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::mark): (KJS::): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::mark):
  • kjs/function.h: (KJS::ActivationImp::LazyArgumentsObject::LazyArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::getOrCreate): (KJS::ActivationImp::LazyArgumentsObject::resetArguments): (KJS::ActivationImp::LazyArgumentsObject::setArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::argumentsObject): (KJS::ActivationImp::LazyArgumentsObject::setFunction): (KJS::ActivationImp::LazyArgumentsObject::function): (KJS::ActivationImp::LazyArgumentsObject::createdArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::): (KJS::ActivationImp::ActivationImp::ActivationImp): (KJS::ActivationImp::resetArguments):
2:32 PM Changeset in webkit [27067] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Weinig also reviewed this patch, and wanted Changelog credit for it

2:26 PM Changeset in webkit [27066] by kmccullo
  • 4 edits in trunk/WebKitTools

Reviewed by Sam.

  • Implemented server calls now the WebScriptDebugServer exists.
  • Also removed no longer needed call to initialize CG.
  • Drosera/win/Drosera.cpp: No longer initializes CG because this happens automatically now. (_tWinMain):
  • Drosera/win/ServerConnection.cpp: Now uses the COM class. (ServerConnection::ServerConnection): (ServerConnection::~ServerConnection): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie):
  • Drosera/win/ServerConnection.h: Now uses the COM class.
2:12 PM Changeset in webkit [27065] by hyatt
  • 3 adds in trunk/LayoutTests/platform/mac/fast/borders

Add border image transforms test.

2:11 PM Changeset in webkit [27064] by hyatt
  • 1 add in trunk/LayoutTests/fast/borders/border-image-scale-transform.html

Add border image transforms test.

2:09 PM Changeset in webkit [27063] by hyatt
  • 3 adds in trunk/LayoutTests/platform/mac/fast/backgrounds/repeat

Add background transform test.

2:08 PM Changeset in webkit [27062] by hyatt
  • 1 add in trunk/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-transformed.html

Add background transform test.

2:03 PM Changeset in webkit [27061] by aroben
  • 9 edits
    1 delete in trunk

Fix some JavaScriptCore build issues

JavaScriptCore:

Change JavaScriptCore.vcproj to use DerivedSources.make

We were trying to emulate the logic of make in
build-generated-files.sh, but we got it wrong. We now use a
build-generated-files very much like the one that WebCore uses to
invoke make.

We also now only have a Debug configuration of dftables which we build
even when doing a Release build of JavaScriptCore. dftables also no
longer has the "_debug" name suffix.

Changes mostly made by Darin, reviewed by me.

  • DerivedSources.make: Add a variable to set the extension used for the dftables executable.
  • JavaScriptCore.vcproj/JavaScriptCore.sln: Updated to use Debug dftables in Release configurations.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
    • Updated include path to point to the new location of the derived sources.
    • Modified pre-build event to pass the right arguments to build-generated-files.sh and not call dftables directly.
    • Added the derived source files to the project.
    • Removed grammarWrapper.cpp, which isn't needed now that we're compiling grammar.cpp directly.
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Slightly modified from the WebCore version.
  • JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Removed.
  • JavaScriptCore.vcproj/dftables/dftables.vcproj:
    • Changed the output location to match Mac.
    • Removed the Release configuration.
    • Removed the _debug suffix.

win:

Update WebKit.sln for the removal of Release dftables

Reviewed by NOBODY.

  • WebKit.vcproj/WebKit.sln:
2:03 PM Changeset in webkit [27060] by hyatt
  • 9 edits in trunk

WebCore:

Fix for bug 15672, background images don't tile properly inside transforms. This patch fixes background
tiling to work in the presence of transforms and fixes bugs in both SVG and CSS transforms.

Reviewed by aroben and mitz

  • WebCore.base.exp:
  • platform/graphics/Image.cpp: (WebCore::Image::setData):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::ImageInfo::ImageInfo): (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Fix for bug 15672, backgrounds don't tile properly inside transforms. This patch fixes tiling
of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
transforms.

Reviewed by aroben and mmitz

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebKit.xcodeproj/project.pbxproj:
1:46 PM Changeset in webkit [27059] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Hatcher


Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
always does, when available.

  • WebView/WebPreferencesPrivate.h: removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with a comment that says that they can be removed when no longer needed. That time is now.
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): removed WebKitUsePDFPreviewViewPreferenceKey (-[WebPreferences _usePDFPreviewView]): removed (-[WebPreferences _setUsePDFPreviewView:]): removed
  • WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): don't check _usePDFPreviewView


  • WebView/WebPreferenceKeysPrivate.h: removed WebKitUsePDFPreviewViewPreferenceKey
1:37 PM Changeset in webkit [27058] by kmccullo
  • 4 edits in trunk/WebKit/win

Rubber stamped by Geoff.

  • Stubbed out the WebScriptDebugServer methods to give Drosera something to connect to and now the signature of the interface matches the mac.
  • Interfaces/IWebScriptDebugServer.idl:
  • WebScriptDebugServer.cpp: (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused):
  • WebScriptDebugServer.h:
1:17 PM Changeset in webkit [27057] by thatcher
  • 2 edits in trunk/WebKitLibraries

Reviewed by Adam.

Update the Leopard WebKitSystemInterface to be 4-way univeral to include 64-bit.

  • libWebKitSystemInterfaceLeopard.a:
12:37 PM Changeset in webkit [27056] by beidson
  • 2 edits in trunk/WebCore

Blind build fix attempt

  • WebCore.pro:
12:26 PM Changeset in webkit [27055] by weinig
  • 4 edits in trunk/WebKitLibraries

Added wrapper for getting the foundation cache directory.

Reviewed by Adam Roben.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:26 PM Changeset in webkit [27054] by beidson
  • 11 edits
    8 moves in trunk/WebCore

Reviewed by Anders

Bulk rename of platform/sql/SQL* to platform/sql/SQLite*

This is more accurate in that there is no realistic "SQL" abstraction, the classes are obviously
tied extremely close to SQLite, and is necessitated by the introduction of "SQLTransaction" in
the HTML5 database API which we are adopting.

11:47 AM Changeset in webkit [27053] by kmccullo
  • 9 edits
    3 moves in trunk/WebKit/win

Reviewed by Darin.

  • Renamed WebDebugProgram to WebScriptDebugServer to match the naming scheme on the mac.
  • Interfaces/IWebDebugProgram.idl: Removed.
  • Interfaces/IWebScriptDebugServer.idl: Copied from win/Interfaces/IWebDebugProgram.idl.
  • Interfaces/WebKit.idl:
  • WebDebugProgram.cpp: Removed.
  • WebDebugProgram.h: Removed.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
  • WebKitDLL.cpp: (RunAsLocalServer):
  • WebScriptDebugServer.cpp: Copied from win/WebDebugProgram.cpp. (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::~WebScriptDebugServer): (WebScriptDebugServer::createInstance): (WebScriptDebugServer::QueryInterface): (WebScriptDebugServer::AddRef): (WebScriptDebugServer::Release): (WebScriptDebugServer::viewAdded): (WebScriptDebugServer::viewRemoved): (WebScriptDebugServer::attach): (WebScriptDebugServer::detach): (WebScriptDebugServer::statistics): (WebScriptDebugServer::webViews):
  • WebScriptDebugServer.h: Copied from win/WebDebugProgram.h.
  • WebView.cpp: (WebView::WebView): (WebView::~WebView):
11:31 AM Changeset in webkit [27052] by ap
  • 4 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15650
XML attribute nodes are not importable

Tests: fast/dom/import-attribute-node.html

fast/dom/import-document-fragment.html

  • dom/Document.cpp: (WebCore::Document::importNode): Implemented for Attribute and DocumentFragment nodes.
11:23 AM Changeset in webkit [27051] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dynamic/insert-before-table-part-in-continuation.html

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's parent is an anonymous table part, let the table figure out where to insert the new child.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/dynamic/insert-before-table-part-in-continuation.html: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
11:21 AM Changeset in webkit [27050] by alp
  • 4 edits in trunk

2007-10-25 Alp Toker <​alp@atoker.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem

Re-enable database support in the GTK+ port, with a fix.

Initialize GLib threading as early as possible.

10:51 AM Changeset in webkit [27049] by sfalken
  • 5 edits in branches/Safari-3-branch/WebCore

Merged fix from r27048.

10:35 AM Changeset in webkit [27048] by honeycutt
  • 5 edits in trunk/WebCore

2007-10-25 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

Previous patch erroneously compared a path and a
path-including-filename. This corrects that. It also caches the result
of safariPluginsPath() and uses shell API funcs for determining filename
and parent directory from a full path.

  • ChangeLog:
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Cache return value. Use API functions to build the path (WebCore::PluginDatabaseWin::pluginForMIMEType): Compare again plugin's parent directory, not full path (WebCore::PluginDatabaseWin::pluginForExtension): Same
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Store parent directory
  • plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::parentDirectory):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):
8:00 AM Changeset in webkit [27047] by alp
  • 4 edits in trunk

2007-10-25 Alp Toker <​alp@atoker.com>

Unreviewed fix to make the GTK+ port run.

​http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem

​http://bugs.webkit.org/show_bug.cgi?id=15688
[GTK] Make it possible to disable database support

Disable database support until #15686 is fixed.

6:44 AM Changeset in webkit [27046] by hausmann
  • 2 edits in trunk/WebCore

Fixed a crash in the Qt 4.4 based text iterators when they're called with a null string.

6:41 AM Changeset in webkit [27045] by hausmann
  • 7 edits in trunk
  • We need to set a != 0 status code for the fast/loader/xmlhttprequest-missing-file-exception.html
  • libxml2 has the semantic that when writing an empty string and finishing it will report an error. For QXmlStreamReader this is valid.
  • This is causing some regressions...

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27044] by hausmann
  • 4 edits
    1 delete in trunk
  • Make fast/loader/xmlhttprequest-bad-mimetype.html pass. We use QHttp to download local files but we may not set the HTTP result code on the ResourceResponse.
  • We can use the cross-platform result now. QWebNetworkInterface/Manager behaves the same as mac for local files.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27043] by hausmann
  • 6 edits in trunk
  • fast/dom/onerror-img.html regressed due checking the JobStates because in case of error (e.g. not being able to connect) the job will no be started.
  • Use the error message from Qt. It might or might not be translated.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27042] by hausmann
  • 2 edits in trunk/WebKit/qt
  • Use the JobStatus to make sure to not deliver finished/data before the job has started. This is the case with the fast/dom/onerror-img.html test case.
  • We have no idea if any data will come so we can still finish and then get pending data. This luckily can't happen for the local file case.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27041] by hausmann
  • 4 edits in trunk/WebKit/qt
  • No need to initialize values in the QWebNetworkJob c'tor
  • Add a JobStatus to QWebNetworkJob and verify that the jobs are handled in the way we expect them to be handled. This means no data after the job has finished, not finishing a job before it has been started.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27040] by hausmann
  • 2 edits in trunk/WebKit/qt
  • Consistency: Always name the jobs job.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:40 AM Changeset in webkit [27039] by hausmann
  • 8 edits in trunk
  • Implement our own queuing of network jobs to allow special handling of synchronous jobs. This makes us pass the fast/dom/xmlhttprequest-html-response-encoding.html test without a crash. Sync jobs will get a special treatment over the normals ones and in theory more than one sync job is supported.
  • This should be thread-safe besides QWebNetworkJob::{ref,deref}

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:40 AM Changeset in webkit [27038] by hausmann
  • 4 edits in trunk
  • Do the percent replacement only when we are not base64. With base64 we should not have any % in it anyway.
  • Have a custom decodePercentEncoding method that works without doing any charset conversion. With converting back to latin1() we lost some information.
  • We pass the char-decoding.html test now

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

5:36 AM Changeset in webkit [27037] by alp
  • 3 edits in trunk/WebCore

2007-10-25 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Add support for list box theme colors and styled menu list buttons.

Remove obsolete FIXMEs.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::adjustMenuListStyle): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkTreeView):
  • platform/gtk/RenderThemeGtk.h:
4:55 AM Changeset in webkit [27036] by ap
  • 1 edit in trunk/WebKitSite/ChangeLog

Corrected ChangeLog entry.

4:53 AM Changeset in webkit [27035] by ap
  • 2 edits in trunk/WebKitSite

Rubber-stamped by Mark Rowe.

  • images/download.png: Updated to say "Nightly builds" instead of

"Nightly (6 MB)" - the Mac version is ~17 MB now, and this isn't a direct
download link anyway.

4:36 AM Changeset in webkit [27034] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r27033 as it broke the JavaScriptCore tests.

2:59 AM Changeset in webkit [27033] by eseidel
  • 2 edits in trunk/JavaScriptCore

HackTop [30311:JavaScriptCore]% less ChangeLog Stuff/Projects/WebKit/JavaScriptCore
2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.


Start work on long-running-mode from the perl-script side of things.
jsDriver.pl will likely be removed (and replaced by something better)
But for now, I'm just hacking it down to something smaller.

  • tests/mozilla/jsDriver.pl: Remove lots of unused code.
2:25 AM Changeset in webkit [27032] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.


Slightly elaborated the differences between declaration procesing in
Function Code and Program Code.


.3% speedup on SunSpider.

  • kjs/nodes.cpp: (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): Store a minimum set of attributes instead of recomputing all the time. Also, ignore m_parameters, since programs don't have arguments.
2:08 AM Changeset in webkit [27031] by eseidel
  • 3 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


More preparation work before adding long-running mode to testkjs.

  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (prettyPrintScript): (runWithScripts): (parseArguments): (kjsmain): (fillBufferWithContentsOfFile):
1:53 AM Changeset in webkit [27030] by aroben
  • 1 add in trunk/WebKit/win/Interfaces/IWebTextRenderer.idl

Forgot to check in this file in r27019

1:37 AM Changeset in webkit [27029] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


Bring testkjs code out of the dark ages in preparation for more
radical improvements (like long-running testing support!)

  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (setupInterpreter): (doIt): (fillBufferWithContentsOfFile):
1:11 AM Changeset in webkit [27028] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Make a fast path for declaration processing inside Function Code.


Lifted declaration processing code up from individual declaration nodes
and into processDeclarations.


Broke out processDeclarations into two cases, depending on the type of
code. This eliminates 2 branches, and facilitates more radical
divergeance in the future.


2.5% SunSpider speedup.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::initializeDeclarationStacks): (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): (KJS::FunctionBodyNode::execute): (KJS::FuncDeclNode::makeFunction):
  • kjs/nodes.h: (KJS::):
12:26 AM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
12:16 AM Changeset in webkit [27027] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • add header includes needed on platforms that don't use AllInOneFile.cpp
  • API/JSCallbackObject.cpp:
  • kjs/Context.cpp:
  • kjs/ExecState.cpp:
  • kjs/array_instance.cpp:
  • kjs/function_object.cpp:
  • kjs/interpreter.cpp:
  • kjs/nodes.cpp:
12:14 AM Changeset in webkit [27026] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

  • JavaScriptCore.xcodeproj/project.pbxproj: re-mark JSGlobalObject.h as private
12:09 AM Changeset in webkit [27025] by ggaren
  • 6 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15683
Re-order declaration initialization to avoid calling hasProperty inside
VarDeclNode::processDeclaration


.7% speedup on SunSpider.

  • kjs/function.h:
  • kjs/function.cpp: Merged parameter processing into FunctionBodyNode's other processing of declared symbols, so the order of execution could change.
  • kjs/nodes.cpp: (KJS::VarDeclNode::getDeclarations): Added special case for the "arguments" property name, explained in the comment.

(KJS::VarDeclNode::processDeclaration): Removed call to hasProperty
in the case of function code, since we know the declared symbol
management will resolve conflicts between symbols. Yay!

(KJS::VarDeclListNode::getDeclarations): Now that VarDeclNode's
implementation of getDeclarations is non-trivial, we can't take a
short-cut here any longer -- we need to put the VarDecl node on the
stack so it gets processed normally.

(KJS::FunctionBodyNode::processDeclarations): Changed the order of
processing to enforce mutual exclusion rules.

  • kjs/nodes.h: (KJS::DeclarationStacks::DeclarationStacks): Structure includes an ExecState now, for fast access to the "arguments" property name.

LayoutTests:

Layout tests for bugs that might result from changes like
​http://bugs.webkit.org/show_bug.cgi?id=15683

  • fast/js/vardecl-preserve-parameters-expected.txt: Added.
  • fast/js/vardecl-preserve-parameters.html: Added.
  • fast/js/vardecl-preserve-vardecl-expected.txt: Added.
  • fast/js/vardecl-preserve-vardecl.html: Added.
12:08 AM Changeset in webkit [27024] by eseidel
  • 2 edits in trunk/WebCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

  • bindings/js/kjs_window.h: fix bogus comment, s/DOMNode/DOMObject/
12:07 AM Changeset in webkit [27023] by eseidel
  • 4 edits in trunk/JavaScriptGlue

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.


Make JSG build again after JSGlobalObject change.

  • JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
  • JSRun.h: (JSInterpreter::JSInterpreter):
  • JSUtils.h:
Note: See TracTimeline for information about the timeline view.