⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 27, 2007:

11:45 PM Changeset in webkit [27171] by timothy@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Adam.

Bug 15727: Resizing the resource sidebar doesn't scale the font preview or network timeline
​http://bugs.webkit.org/show_bug.cgi?id=15727

Add one window resize listener and call the new resize function on the currentPanel.
Also call the currentPanel's resize function when resizing the sidebar.

  • page/inspector/DocumentPanel.js: Implement resize and call updateTreeSelection() when the panel is shown and when resizing the DOM sidebar.
  • page/inspector/FontPanel.js: Implement resize.
  • page/inspector/NetworkPanel.js: Ditto.
  • page/inspector/inspector.js: Add a window resize listener.
11:31 PM Changeset in webkit [27170] by mjs
  • 11 edits in trunk/WebCore

Reviewed by Oliver.


  • update for HashTable changes
  • bindings/js/JSSVGPODTypeWrapper.h:
  • dom/Document.h:
  • dom/QualifiedName.cpp:
  • dom/StyledElement.cpp:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • platform/FontCache.cpp:
  • platform/StringHash.h: (WTF::):
  • platform/TextEncodingRegistry.cpp:
  • platform/graphics/IntSizeHash.h: (WTF::):
  • plugins/win/PluginPackageWin.h:
10:34 PM Changeset in webkit [27169] by alp
  • 5 edits in trunk/WebCore

2007-10-28 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=15646
[GTK] caretBlinkFrequency is hard-coded in Frame.cpp

Abstract caretBlinkFrequency to RenderTheme.

  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::caretShouldBlink): (WebCore::RenderThemeGtk::caretBlinkFrequency):
  • platform/gtk/RenderThemeGtk.h:
  • rendering/RenderTheme.h:
10:22 PM Changeset in webkit [27168] by alp
  • 2 edits in trunk/WebKit/gtk

2007-10-28 Lars Lindner <​lars.lindner@gmail.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15466
[gtk] widget does not take focus on mouse click

Grab widget focus in mouse press callback.

  • Api/webkitgtkpage.cpp:
10:02 PM Changeset in webkit [27167] by aroben
  • 2 edits in trunk/LayoutTests

Updated Windows Skipped file for currently failing tests

Reviewed by NOBODY.

  • platform/win/Skipped:
9:38 PM Changeset in webkit [27166] by aroben
  • 1 edit
    5 adds
    1 delete in trunk/LayoutTests

Fix HTMLDocument12.xhtml on Leopard/Windows

<rdar://5313535> and <rdar://5539816>

The test succeeds on Leopard and Windows, but fails on Tiger. For some
reason, failing expected results had been checked in to
platform/mac-leopard. The test seems to be passing now, so I moved the
failing results to platform/mac-tiger.

Reviewed by Maciej and Sam.

  • platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Removed.
  • platform/mac-tiger/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Moved from platform/mac-leopard.
9:24 PM Changeset in webkit [27165] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Don't print the line number in the Inspector Console if it is Zero.

  • page/inspector/ConsolePanel.js:
8:31 PM Changeset in webkit [27164] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • fix ASCIICType.h for some Windows compiles
  • wtf/ASCIICType.h: Check the compiler, not the OS, since it's the compiler/library that has the wchar_t that is just a typedef.
8:12 PM Changeset in webkit [27163] by weinig
  • 1 edit
    2 adds in trunk/LayoutTests

Hit with the rubber-stamp of Timothy Hatcher.

Tests for window.console's functions.

  • fast/dom/Window/console-functions-expected.txt: Added.
  • fast/dom/Window/console-functions.html: Added.
7:52 PM Changeset in webkit [27162] by weinig
  • 2 edits
    1 add in trunk/LayoutTests

Reviewed by Tim Hatcher.

Speculative fix for an intermittently failing test

  • fast/dom/Window/resources/opened-window.html: Added.
  • fast/dom/Window/window-early-properties.html: Use onload for opened window and use a local file instead of a data: URL to avoid same origin check issues.
7:11 PM Changeset in webkit [27161] by weinig
  • 13 edits
    3 adds in trunk

WebCore:

Reviewed by Adam Roben.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore

  • Adds a window.console object that has 4 methods (log, info, warn, and error) that send messages to the Chrome. This moves functionality that was in the app down into WebCore.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm: Add extended attribute to mark attributes as [Replacable] which indicates they can overridden when set.
  • page/Chrome.cpp: (WebCore::Chrome::addMessageToConsole): Allow all messages to go up to the ChromeClient.
  • page/Console.cpp: Added. (WebCore::Console::Console): (WebCore::Console::disconnectFrame): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::warn):
  • page/Console.h: Added.
  • page/Console.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::console):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Adam Roben.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt:
5:47 PM Changeset in webkit [27160] by pewtermoose
  • 2 edits in trunk/LayoutTests

Update results

5:02 PM Changeset in webkit [27159] by aroben
  • 2 edits in trunk/LayoutTests

Speculative fix for an intermittently failing test

Reviewed by Sam and Eric.

  • http/tests/local/style-access-before-stylesheet-loaded.html: Use waitUntilDone/notifyDone.
4:53 PM Changeset in webkit [27158] by eseidel
  • 20 edits in trunk/WebCore

2007-10-27 Eric Seidel <​eric@webkit.org>

Reviewed by aroben.


Remove legacy createFilterEffect function (causing extra filter tests to fail on windows)

No functional changes, thus no tests.

  • ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::filterEffect):
  • ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::filterEffect):
  • ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::filterEffect):
  • ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::filterEffect):
  • ksvg2/svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::filterEffect):
  • ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::filterEffect):
  • ksvg2/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::filterEffect):
  • ksvg2/svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::filterEffect):
  • platform/graphics/svg/SVGResourceFilter.h:
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
  • platform/graphics/svg/cg/SVGResourceFilterCg.mm:
  • platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
4:31 PM Changeset in webkit [27157] by aroben
  • 2 edits in trunk/LayoutTests

Add some more failing tests to the Windows Skipped file

Reviewed by NOBODY.

  • platform/win/Skipped:
4:26 PM Changeset in webkit [27156] by kmccullo
  • 3 edits
    2 adds in trunk/WebKit/win

Reviewed by Adam.

  • Stubbed out IWebScriptCallFrame for Drosera.
  • Interfaces/IWebScriptCallFrame.idl: Added function declarations.
  • WebKit.vcproj/WebKit.vcproj: Added .h/.cpp files to the project.
  • WebScriptCallFrame.cpp: Added. (WebScriptCallFrame::WebScriptCallFrame): (WebScriptCallFrame::~WebScriptCallFrame): (WebScriptCallFrame::createInstance): (WebScriptCallFrame::QueryInterface): (WebScriptCallFrame::AddRef): (WebScriptCallFrame::Release): (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::evaluateWebScript):
  • WebScriptCallFrame.h: Added.
4:25 PM Changeset in webkit [27155] by mitz
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix a crash when opening Zenoss server history view <rdar://problem/5530657>

Test: fast/table/colgroup-relative.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Added a hasLayer() check before accessing layer().

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/5530657>
  • fast/table/colgroup-relative-expected.txt: Added.
  • fast/table/colgroup-relative.html: Added.
3:45 PM Changeset in webkit [27154] by kmccullo
  • 2 edits in trunk/JavaScriptCore
  • BuildFix
  • Forgot to change the build step when I changed the filename.
12:20 PM Changeset in webkit [27153] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Fixed the rest of "ASSERTION FAILED: _hash in KJS::UString::Rep::
computedHash()"
​http://bugs.webkit.org/show_bug.cgi?id=15718

  • kjs/identifier.cpp: Fixed more cases where an Identifier didn't get a hash value. Also changed O(n) strlen to O(1) check for empty string. (KJS::Identifier::add):
  • kjs/ustring.cpp: Changed O(n) strlens to O(1) checks for empty string. (KJS::UString::UString): (KJS::UString::operator=):
12:10 PM Changeset in webkit [27152] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • a couple of Windows fixes
  • wtf/MathExtras.h: (wtf_pow): Add a special case for MSVC, which has a "pow" function that does not properly handle the case where arg1 is NaN and arg2 is 0.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): Don't explicity specify "::pow" -- just "pow" is fine.
  • wtf/ASCIICType.h: Check the compiler, not the OS, since it's the compiler/library that has the wchar_t that is just a typedef.
11:51 AM Changeset in webkit [27151] by ap
  • 4 edits
    2 adds in trunk

2007-10-27 Julien <​julien.chaffraix@gmail.com>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=13141
XMLHttpRequest should set readyState to 0 after abort()


Test: http/tests/xmlhttprequest/xmlhttprequest-abort-readyState.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::abort):
9:54 AM Changeset in webkit [27150] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix rotated border images by using a temporary subimage containing only the part we want to tile

Test: fast/borders/border-image-rotate-transform.html

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):

LayoutTests:

Reviewed by Dave Hyatt.

  • rotated border image test
  • fast/borders/border-image-rotate-transform.html: Added.
  • platform/mac/fast/borders/border-image-rotate-transform-expected.checksum: Added.
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png: Added.
  • platform/mac/fast/borders/border-image-rotate-transform-expected.txt: Added.
7:48 AM Changeset in webkit [27149] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/JSImmediate.h: Put ALWAYS_INLINE on everything.
  • kjs/object.h: Removed redundant includes.
  • kjs/value.h: Ditto.
3:46 AM Changeset in webkit [27148] by mrowe@apple.com
  • 2 edits in trunk/WebKit

2007-10-27 Mark Ambachtsheer <​mark.a@apple.com>

Reviewed by Darin.

Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
(0, 0) the clipping rectangle is not correct.
Added the origin to the window clip rectangle coordinates to account for plugins that
don't originate at (0,0); affects code for offscreen GWorlds only.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3:39 AM Changeset in webkit [27147] by alp
  • 3 edits in trunk/WebCore

2007-10-27 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15722
[GTK] Refactor gtk/RenderThemeGtk and implement a few more methods

Refactor/enhance GTK RenderTheme

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::supportsFocus): added TextArea, Menulist, Radio, and Checkbox Appearances (WebCore::RenderThemeGtk::supportsFocusRing): call supportsFocus() to check if focus on appearance is supported (WebCore::RenderThemeGtk::controlSupportsTints): copied from Qt and Safari ports (WebCore::RenderThemeGtk::baselinePosition): copied from Qt and Safari ports (WebCore::RenderThemeGtk::paintCheckbox): moved painting in paintButton (WebCore::RenderThemeGtk::paintRadio): moved painting in paintButton (WebCore::RenderThemeGtk::paintButton): paint the different buttons here, checking for the right appearance before doing so (WebCore::RenderThemeGtk::paintMenuList): use 0 instead of NULLs (WebCore::RenderThemeGtk::adjustTextFieldStyle): (WebCore::RenderThemeGtk::getThemeData):
  • platform/gtk/RenderThemeGtk.h: (WebCore::RenderThemeGtk::supportsControlTints):
3:23 AM Changeset in webkit [27146] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark.


  • kjs/identifier.cpp: (KJS::Identifier::addSlowCase): Ensure that empty Identifiers have a hash computed, now that we count on all Identifiers already having one.
1:40 AM Changeset in webkit [27145] by ap
  • 6 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15555
XMLHttpRequest does not support charset "x-user-defined", which can
facilitate loading of binary data

Test: http/tests/xmlhttprequest/binary-x-user-defined.html

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/TextCodecUserDefined.cpp: Added. (WebCore::TextCodecUserDefined::registerEncodingNames): (WebCore::newStreamingTextDecoderUserDefined): (WebCore::TextCodecUserDefined::registerCodecs): (WebCore::TextCodecUserDefined::decode): (WebCore::encodeComplexUserDefined): (WebCore::TextCodecUserDefined::encode):
  • platform/TextCodecUserDefined.h: Added.
  • platform/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
1:16 AM Changeset in webkit [27144] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15467
Setting innerHTML to blank string in application/xhtml+xml mode
throws DOM Exception 7

Test: fast/dom/blank-innerHTML.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment): Bail out early if the input string is empty.
1:11 AM Changeset in webkit [27143] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-27 Mark Rowe <​mrowe@apple.com>

Silence a warning.

  • kjs/SymbolTable.h:
1:08 AM Changeset in webkit [27142] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-27 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/function.h:

Oct 26, 2007:

9:42 PM Changeset in webkit [27141] by weinig
  • 5 edits in trunk/WebCore

Enable dragging the left sidebar using the separator.

Reviewed by Anders (unless Mitz says otherwise).

  • page/inspector/DocumentPanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
8:40 PM Changeset in webkit [27140] by weinig
  • 2 edits in trunk/WebCore

Fix an off by one error when resizing the Inspector find window.

Reviewed by Hyatt.

  • page/inspector/inspector.js:
7:56 PM Changeset in webkit [27139] by honeycutt
  • 2 edits in trunk/WebCore

2007-10-26 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Fix fallout from r26072, which leads to all plugin streams for local
resources being cancelled

  • loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Ensure this is an HTTP response before checking the HTTP response code
7:50 PM Changeset in webkit [27138] by hyatt
  • 2 edits
    4 adds in trunk

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15719, transformed box doesn't repaint properly
when only translation changes.

Move the updating of the transform to in between the old repaint and the new repaint.

Reviewed by mitz

fast/repaint/transform-translate.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
6:45 PM Changeset in webkit [27137] by kmccullo
  • 2 edits
    2 moves in trunk/JavaScriptCore

Rubber stamp by Adam.

  • Renamed JSStringRefCOM to JSStringRefBSTR since it he only thing the files contain are functions that operate on BSTRs.
  • API/JSStringRefBSTR.cpp: Copied from API/JSStringRefCOM.cpp.
  • API/JSStringRefBSTR.h: Copied from API/JSStringRefCOM.h.
  • API/JSStringRefCOM.cpp: Removed.
  • API/JSStringRefCOM.h: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
6:38 PM Changeset in webkit [27136] by kmccullo
  • 3 edits in trunk/WebKitTools

Reviewed by Adam.

  • Implemented the WebScriptDebugListener functions now that the WebScriptDebugServer exists
  • Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener functions. (ServerConnection::currentFrame): (ServerConnection::didLoadMainResourceForDataSource): (ServerConnection::didParseSource): (ServerConnection::failedToParseSource): (ServerConnection::didEnterCallFrame): (ServerConnection::willExecuteStatement): (ServerConnection::willLeaveCallFrame): (ServerConnection::exceptionWasRaised):
  • Drosera/win/ServerConnection.h: Removed unused arguments from the members arguments list.
6:37 PM Changeset in webkit [27135] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Made JSStringCreateWithBSTR capable of handling null BSTRs.
  • API/JSStringRefCOM.cpp: (JSStringCreateWithBSTR):
6:01 PM Changeset in webkit [27134] by weinig
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/SymbolTable.h: Add header gaurd.
  • kjs/nodes.h: #include "SymbolTable.h"
4:33 PM Changeset in webkit [27133] by ggaren
  • 2 edits in trunk/JavaScriptCore

Suggested by Anders Carlsson.


Fixed tyop.

  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):
4:31 PM Changeset in webkit [27132] by ggaren
  • 2 edits in trunk/JavaScriptCore

Suggested by Darin Adler.


Use computedHash(), which is safer than just directly accessing _hash.

  • kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):
4:07 PM Changeset in webkit [27131] by honeycutt
  • 5 edits in trunk/WebCore

2007-10-26 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://5557379> Crash in Silverlight when opening microsoft.com

The crash is within Silverlight, and the latest version of the plugin
does not exhibit this crash, so just avoid loading this version of the
plugin.

  • plugins/win/PluginDatabaseWin.cpp: Added isPluginBlacklisted() and constants silverlightPluginMinRequiredVersionMSDWORD and silverlightPluginMinRequiredVersionLSDWORD. Their values are taken from the version info of Silverlight 1.0.20926.0, which is a version known not to exhibit this crash (WebCore::PluginDatabaseWin::isPluginBlacklisted): Determine whether this plugin is blacklisted
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Initialize m_fileVersion* (WebCore::PluginPackageWin::getFileVersion): (WebCore::PluginPackageWin::storeFileVersion): Read version info for the plugin, and store the file version (WebCore::PluginPackageWin::fetchInfo): After determining the name, description, and file version, determine whether this plug-in is blacklisted. If so, return false so this plug-in isn't loaded
  • plugins/win/PluginPackageWin.h:
3:59 PM Changeset in webkit [27130] by ggaren
  • 1 edit
    1 add in trunk/JavaScriptCore

Build fix: svn add SymbolTable.h

  • kjs/SymbolTable.h: Added. (KJS::SymbolTable::set): (KJS::SymbolTable::get):
3:54 PM Changeset in webkit [27129] by ggaren
  • 2 edits in trunk/JavaScriptCore

Build fix: export SymbolTable.h to WebCore.

3:47 PM Changeset in webkit [27128] by ggaren
  • 2 edits in trunk/JavaScriptCore

Comment tweak suggested by Maciej.

  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):
3:45 PM Changeset in webkit [27127] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Tweaked property maps to remove 2 branches. 2.5% speedup on SunSpider.

  • kjs/property_map.cpp: Use a special no branch accessor to the UString's hash value. Also, return immediately instead of branching to the end of the loop if the value is not found. (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::remove): (KJS::PropertyMap::checkConsistency):
  • kjs/ustring.h: (KJS::UString::Rep::computedHash): Special no branch accessor to the UString's hash value. Used when the caller knows that the hash value has already been computed. (For example, if the caller got the UString from an Identifier.)
3:43 PM Changeset in webkit [27126] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Switched ActivationImp to using a symbol table. For now, though, all
clients take the slow path.


Net .6% speedup on SunSpider.


Slowdowns:

  • ActivationImp now mallocs in its constructor
  • Local variable hits use an extra level of indirection to retrieve data
  • Local variable misses do two lookups

Speedups:

  • Fast initialization of local variables upon function entry


  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Malloc a private structure to hold data that won't fit in a JSCell. (KJS::ActivationImp::argumentsGetter): Use slow symbol table path for lookup. (KJS::ActivationImp::getOwnPropertySlot): ditto (KJS::ActivationImp::deleteProperty): ditto (KJS::ActivationImp::put): ditto (KJS::ActivationImp::createArgumentsObject): ditto

(KJS::ActivationImp::mark): Call JSObject::mark first so that one of
our properties doesn't try to recursively mark us. (This caused a crash
in earlier testing. Not sure why we haven't run into it before.)

  • kjs/nodes.cpp: Functions now build a symbol table the first time they're called. (KJS::VarDeclNode::evaluate): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::initializeSymbolTable): (KJS::FunctionBodyNode::processDeclarations): (KJS::FunctionBodyNode::processDeclarationsForFunctionCode): (KJS::FunctionBodyNode::processDeclarationsForProgramCode):
  • kjs/nodes.h: (KJS::FunctionBodyNode::symbolTable):
  • wtf/Forward.h: Added Vector.
2:44 PM Changeset in webkit [27125] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Adele Peterson.

Fix for <rdar://problem/5421754>
m_frameName member variable in HTMLPlugInElement unnecessary

  • Refactor the willRemove() method down into HTMLFrameOwnerElement now that we no longer need to use the m_frameName variable.
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
  • html/HTMLFrameOwnerElement.h:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
2:28 PM Changeset in webkit [27124] by kmccullo
  • 1 edit in trunk/JavaScriptCore/ChangeLog
  • Corrected function name mistake in this changelog.
2:19 PM Changeset in webkit [27123] by kmccullo
  • 6 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Sam and Steve.

  • Added convenience methods for converting between BSTR and JSStringRefs
  • API/JSStringRefCOM.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString):
  • API/JSStringRefCOM.h: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

win:

Reviewed by Sam and Steve.

  • Added convenience methods for converting between BSTR and JSSTringRefs
  • Added WebKit_debug.def to the project.
  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKit_debug.def:
2:03 PM Changeset in webkit [27122] by adele
  • 1 edit in trunk/WebCore/WebCore.base.exp

Reverting an unintentional added symbol

1:55 PM Changeset in webkit [27121] by adele
  • 2 edits in trunk/WebCore

Export _wkDrawCapsLockIndicator.

  • WebCore.base.exp:
1:28 PM Changeset in webkit [27120] by adele
  • 2 edits in trunk/WebKitLibraries

Reviewed by Tim Hatcher.

Updating header too for WKDrawCapsLockIndicator.

  • WebKitSystemInterface.h:
12:52 PM Changeset in webkit [27119] by adele
  • 8 edits in trunk

WebCore:

Reviewed by Oliver.

Adding WebKitSystemInterface support for the caps lock indicator

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Oliver.

Adding WebKitSystemInterface support for the caps lock indicator

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Oliver.

Adding wkDrawCapsLockIndicator in preparation for fixing the caps lock indicator.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
12:22 PM Changeset in webkit [27118] by tristan
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5555053> REGRESSION:9A581: Window disappears when opening ​http://research.microsoft.com/users/darkok/
The problem was caused by checkin r24654. This change moved explicit bounds checking into adjustWindowRect
but failed to account for bounds checking (instead replaced with bounds clipping). This caused issues
when NaN was used. This patch goes one step further and does NaN checking to prevent the possibility of
setting window bounds to NaN before an update occurs.

Test: fast/dom/Window/window-resize-nan.html


  • bindings/js/kjs_window.cpp: (KJS::adjustWindowRect): Added a new parameter, pendingChanges, which takes pending changes to the window rect, and if they are valid (not NaN) sets them on window.


(KJS::WindowFunc::callAsFunction):
Adjusted uses of adjustWindowRect to take new update parameter.

LayoutTests:

Reviewed by Darin Adler.


Added new test cases to handle non-number input to window adjusting
functions like resizeTo, resizeBy, moveTo, and moveBy for
<rdar://problem/5555053>.

  • fast/dom/Window/window-resize-nan-expected.txt: Added.
  • fast/dom/Window/window-resize-nan.html: Added.
11:39 AM Changeset in webkit [27117] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15175
Cannot copy text of errors from Web Inspector from Console view

  • page/inspector/inspector.css: add -webkit-user-select: text for console messages.
11:17 AM Changeset in webkit [27116] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15446
Web Inspector find window is not resizable

  • Adds ability to resize the find window.
  • Fixes bug that messed up the find window when resizing the left sidebar.
  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
10:15 AM Changeset in webkit [27115] by sfalken
  • 1 copy in tags/Safari-523.12.9b

New tag.

10:15 AM Changeset in webkit [27114] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

9:34 AM Changeset in webkit [27113] by adachan
  • 2 edits in trunk/WebCore

Update m_current index after we've removed an item:

  • if item removed is before m_current, decrement m_current
  • if the current item is removed, make sure m_current is within bounds.

Reviewed by Darin.

  • history/BackForwardList.cpp: (WebCore::BackForwardList::removeItem):
8:38 AM Changeset in webkit [27112] by ddkilzer
  • 3 edits
    1 add in trunk/WebKitTools

prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
<​http://bugs.webkit.org/show_bug.cgi?id=15600>

Reviewed by Darin.

The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
a patch of the local changes and applying it with a fuzz level of 3 to the new file.
If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
file. Note that it may also be used as a stand-alone script.

  • Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
  • Scripts/resolve-ChangeLogs: Added.
  • Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
6:34 AM Changeset in webkit [27111] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/kjs/collector.cpp

Restore the semicolon.

6:31 AM Changeset in webkit [27110] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • kjs/collector.cpp: (KJS::Collector::collect):
5:22 AM Changeset in webkit [27109] by mrowe@apple.com
  • 2 edits in trunk/WebKit/qt

2007-10-26 Mark Rowe <​mrowe@apple.com>

Build fix. Add missing #include of Platform.h.

  • Api/qwebhistoryinterface.cpp:
5:07 AM Changeset in webkit [27108] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Debug build fix.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
5:06 AM Changeset in webkit [27107] by oliver
  • 6 edits in trunk/JavaScriptCore

Make the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in SunSpider.

Reviewed by Maciej

  • kjs/CollectorHeapIntrospector.cpp: (KJS::CollectorHeapIntrospector::init): (KJS::CollectorHeapIntrospector::enumerate):
  • kjs/CollectorHeapIntrospector.h:
  • kjs/collector.cpp: (KJS::Collector::recordExtraCost): (KJS::Collector::heapAllocate): (KJS::Collector::allocate): (KJS::Collector::allocateNumber): (KJS::Collector::registerThread): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::sweep): (KJS::Collector::collect):
  • kjs/collector.h:
  • kjs/internal.h: (KJS::NumberImp::operator new): Force numbers to be allocated in the secondary heap.
4:53 AM Changeset in webkit [27106] by mjs
  • 2 edits in trunk/WebCore

No review, build fix.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): (-[WebScriptObject setException:]):
4:50 AM Changeset in webkit [27105] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Rubber Stamped by Mark.

  • fix build
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:48 AM Changeset in webkit [27104] by mjs
  • 2 edits in trunk/WebCore

Rubber Stamped by Oliver.

  • fix build
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:46 AM Changeset in webkit [27103] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • encourage GCC a little harder to inline a few hot functions for 1.5% improvement on SunSpider.
  • kjs/value.h: (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): (KJS::JSValue::toNumber):
  • wtf/PassRefPtr.h: (WTF::PassRefPtr::~PassRefPtr):
  • wtf/RefPtr.h: (WTF::RefPtr::operator->):
3:45 AM Changeset in webkit [27102] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog ordering.

3:44 AM Changeset in webkit [27101] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/ExecState.h:
3:36 AM Changeset in webkit [27100] by mjs
  • 8 edits in trunk/JavaScriptCore

Windows build fix.

2:38 AM Changeset in webkit [27099] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

2:38 AM Changeset in webkit [27098] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

1:32 AM Changeset in webkit [27097] by mjs
  • 17 edits
    1 add
    2 deletes in trunk

JavaScriptCore:

Reviewed by Oliver.


  • moved Context class into ExecState.{h,cpp} in preparation for merging ExecState and Context classes.
  • kjs/ExecState.h: Moved CodeType enum and Context class here in preparation for merging ExecState and Context.
  • kjs/ExecState.cpp: Moved Context class here from Context.cpp. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark):
  • kjs/context.h: Removed.
  • kjs/Context.cpp: Removed.
  • kjs/function.h: Removed CodeType enum.
  • kjs/LabelStack.h: Added. Pulled LabelStack class out of internal.h.
  • kjs/internal.h: Removed LabelStack.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new file, removed ones that are gone.
  • kjs/collector.cpp: Fixed includes.
  • kjs/function.cpp: ditto
  • kjs/internal.cpp: ditto
  • kjs/interpreter.cpp: ditto
  • kjs/lookup.h: ditto
  • kjs/nodes.cpp: ditto

WebCore:

Reviewed by Oliver.

  • bindings/objc/WebScriptObject.mm:
  • bridge/mac/WebCoreScriptDebugger.mm:
1:13 AM Changeset in webkit [27096] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • kjs/string_object.cpp: (KJS::StringObjectFuncImp::callAsFunction):
12:51 AM Changeset in webkit [27095] by darin
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Gives about 1% gain on SunSpider.

  • kjs/value.h: Added toIntegerPreserveNan, removed toUInt16. (KJS::JSValue::toInt32): Changed to call getTruncatedInt32 in a way that works with both immediate and number values. (KJS::JSValue::toUInt32): Ditto.
  • kjs/value.cpp: (KJS::JSValue::toInteger): Moved the logic from roundValue here, with a couple differences. One is that it now correctly returns 0 for NaN, and another is that there's no special case for 0 or infinity, since the general case already handles those correctly. (KJS::JSValue::toIntegerPreserveNaN): Added. Like toInteger, but without the check for NaN. (KJS::JSValue::toInt32SlowCase): Call toNumber instead of roundValue. The truncation done by the typecast already does the necessary truncation that roundValue was doing. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Removed.
  • kjs/internal.h: Removed roundValue.
  • kjs/internal.cpp: Ditto.
  • kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Remove unneeded code to handle NaN in Array.slice; toInteger now never returns NaN as specified.
  • kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): Replaced call to roundValue with a call to toNumber as specified. (KJS::DateProtoFunc::callAsFunction): In SetTime case, replaced call to roundValue with a call to toNumber and timeClip as specified. (KJS::DateObjectImp::construct): Removed unnecessary checks of numArgs in cases where the default behavior of toInt32 (returning 0) was already correct. Replaced call to roundValue with a call to toNumber as specified. (KJS::DateObjectFuncImp::callAsFunction): Ditto.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed unnecessary special cases for the pow function that the library already handles correctly.
  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Changed ToString to call toIntegerPreserveNaN, so we can continue to handle the NaN case differently. The real toInteger now returns 0 for NaN. Took out unneeded special case in ToFixed for undefined; was only needed because our toInteger was wrong. Same thing in ToExponential. Changed ToPrecision to call toIntegerPreserveNaN.
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Took out CharAt and CharCodeAt special cases for undefined that were only needed because toInteger was wrong. Same in IndexOf, and was able to remove some special cases. In LastIndexOf, used toIntegerPreserveNaN, but was able to remove some special cases there too. Changed Substr implementation to preserve correct behavior with the change to toInteger and match the specification. Also made sure we weren't converting an out of range double to an int. (KJS::StringObjectFuncImp::callAsFunction): Changed constructor to just use toUInt32, because truncating toUInt32 to 16 bits is the same thing and there's no reason to have toUInt16 as a second, less-optimized function that's only called at this one call site.
  • wtf/MathExtras.h: Added trunc function for Windows.

LayoutTests:

Reviewed by Maciej.

  • fast/js/resources/char-at.js: Updated test to expect that we get the first character if we pass NaN to charAt and charCodeAt; it's what the specification asks for and matches other browsers too.
  • fast/js/char-at-expected.txt: Updated.
Note: See TracTimeline for information about the timeline view.