Context Navigation

← Previous Period
Next Period →

Timeline

Oct 28, 2007:

11:49 PM Changeset in webkit [27215] by mjs

6 edits in trunk/JavaScriptCore

Reviewed by Darin.

avoid creating and then breaking circular lists in the parser, instead track head and tail pointers at parse time http://bugs.webkit.org/show_bug.cgi?id=15748

Not a significant speedup or slowdown on SunSpider.

kjs/Parser.cpp: (KJS::clearNewNodes):
kjs/Parser.h:
kjs/grammar.y:
kjs/nodes.cpp: (KJS::BlockNode::BlockNode): (KJS::CaseBlockNode::CaseBlockNode): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::SourceElementsNode::SourceElementsNode): (KJS::ProgramNode::ProgramNode):
kjs/nodes.h: (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::ForNode::): (KJS::ParameterNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::):

11:25 PM Changeset in webkit [27214] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-10-28 Mark Rowe <mrowe@apple.com>

Disable assertions in a manner that doesn't break the Qt Windows build.

wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting):

11:14 PM Changeset in webkit [27213] by ggaren

2 edits in trunk/JavaScriptCore

Temporarily disabling some ASSERTs I introduced in my last check-in
because of http://bugs.webkit.org/show_bug.cgi?id=15747
Lots of layout tests fail the !HashTranslator::equal(KeyTraits::emptyValue() ASSERT

wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):

11:13 PM Changeset in webkit [27212] by aroben

2 edits in trunk/SunSpider

Fix SunSpider on Windows

Reviewed by Eric.

sunspider: Don't use colons in filenames.

10:53 PM Changeset in webkit [27211] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Fixed http://bugs.webkit.org/show_bug.cgi?id=15746
#ifndef ASSERT_DISABLED is no good!

Replaced with #if !ASSERT_DISABLED.

wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):

10:32 PM Changeset in webkit [27210] by ggaren

5 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode
to the AST transfom that replaces slow resolve nodes with fast local
variable alternatives.

2.5% speedup on SunSpider.

Also added some missing copyright notices.

kjs/nodes.cpp: (KJS::FunctionCallResolveNode::optimizeVariableAccess): (KJS::FunctionCallResolveNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::PostfixResolveNode::optimizeVariableAccess): (KJS::PostfixResolveNode::evaluate): (KJS::LocalVarPostfixNode::evaluate): (KJS::DeleteResolveNode::optimizeVariableAccess): (KJS::DeleteResolveNode::evaluate): (KJS::LocalVarDeleteNode::evaluate):
kjs/nodes.h: (KJS::FunctionCallResolveNode::): (KJS::LocalVarFunctionCallNode::LocalVarFunctionCallNode): (KJS::PostfixResolveNode::): (KJS::LocalVarPostfixNode::LocalVarPostfixNode): (KJS::DeleteResolveNode::): (KJS::LocalVarDeleteNode::LocalVarDeleteNode):

9:53 PM Changeset in webkit [27209] by eseidel

3 edits in trunk/JavaScriptCore

2007-10-28 Eric Seidel <eric@webkit.org>

Reviewed by darin.

Inline UString::Rep::deref() for a 0.8% improvement in SunSpider
Add virtual keyword to a few virtual functions previously unmarked.

kjs/internal.h: (KJS::StringImp::type): (KJS::NumberImp::type):
kjs/ustring.h: (KJS::UString::Rep::deref):

9:37 PM Changeset in webkit [27208] by darin

3 edits in trunk/JavaScriptCore

fix "broken everything" from the storage leak fix

wtf/RefPtr.h: (WTF::RefPtr::RefPtr): Added a PlacementNewAdopt constructor.
kjs/ustring.h: (KJS::UString::UString): Pass PlacementNewAdopt along to RefPtr.

9:31 PM Changeset in webkit [27207] by darin

7 edits in trunk/JavaScriptCore

Reviewed by Adam.

turn on unused parameter waring on Mac OS X because it's already on elsewhere

Configurations/Base.xcconfig: Took out -wno-unused-parameter.

API/JSNode.c:
API/JSNodeList.c:
API/minidom.c:
API/testapi.c: Fixed unused variables by using them or marked them with UNUSED_PARAM.

kjs/CollectorHeapIntrospector.h: (KJS::CollectorHeapIntrospector::zoneCalloc): Removed parameter names to indicate they are unused.

9:11 PM Changeset in webkit [27206] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix a storage leak where we ref the UString every time we replace a ResolveNode with a LocalVarAccessNode

kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor that takes PlacementNewAdopt.

kjs/nodes.h: (KJS::ResolveNode::ResolveNode): Initialize the ident with PlacementNewAdopt instead of the old value of ident.

kjs/ustring.h: (KJS::UString::UString): Added a constructor that takes PlacementNewAdopt.

9:04 PM Changeset in webkit [27205] by eseidel

2 edits in trunk/LayoutTests

2007-10-28 Eric Seidel <eric@webkit.org>

Reviewed by aroben.

platform/mac/svg/custom/path-bad-data-expected.txt: updated to better results

9:02 PM Changeset in webkit [27204] by darin

3 edits in trunk/JavaScriptCore

Windows build fix; get rid of unused parameter

kjs/nodes.cpp: (KJS::ResolveNode::optimizeVariableAccess): Don't pass it.
kjs/nodes.h: (KJS::LocalVarAccessNode::LocalVarAccessNode): Remove it. The assertions weren't all that helpful.

8:48 PM Changeset in webkit [27203] by eseidel

5 edits in trunk/WebCore

2007-10-28 Eric Seidel <eric@webkit.org>

Reviewed by darin.

Fix leaks on TOT and prevent Path code from logging to console so frequently

platform/graphics/svg/SVGResourceFilter.h: (WebCore::SVGResourceFilterPlatformData::SVGResourceFilterPlatformData): (WebCore::SVGResourceFilterPlatformData::~SVGResourceFilterPlatformData):
platform/graphics/svg/cg/CgSupport.cpp: (WebCore::strokeBoundingBox):
platform/graphics/svg/cg/SVGResourceFilterCg.mm:
platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:

8:00 PM Changeset in webkit [27202] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-10-28 Mark Rowe <mrowe@apple.com>

Gtk build fix. Add include of MathExtras.h.

kjs/string_object.cpp:

7:52 PM Changeset in webkit [27201] by mrowe@apple.com

14 edits in trunk

2007-10-28 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej and Tim.

Replace uses of isNaN and isInf with isnan and isinf, and
remove isNaN and isInf.

kjs/config.h: Remove unused HAVE_'s
kjs/date_object.cpp: (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectFuncImp::callAsFunction):
kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
kjs/math_object.cpp: (MathFuncImp::callAsFunction):
kjs/nodes2string.cpp: (KJS::isParserRoundTripNumber):
kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):
kjs/operations.cpp:
kjs/operations.h:
kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
kjs/ustring.cpp: (KJS::UString::from):
kjs/value.cpp: (KJS::JSValue::toInteger): (KJS::JSValue::toInt32SlowCase): (KJS::JSValue::toUInt32SlowCase):

2007-10-28 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Replace uses of isNaN and isInf with isnan and isinf.

bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength):

7:08 PM Changeset in webkit [27200] by ggaren

3 edits in trunk/JavaScriptCore

Build fix: use the new-fangled missingSymbolMarker().

kjs/nodes.cpp: (KJS::ResolveNode::optimizeVariableAccess):
kjs/nodes.h: (KJS::LocalVarAccessNode::LocalVarAccessNode):

7:00 PM Changeset in webkit [27199] by ggaren

5 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak, Darin Adler.

Much supporting work done by Maciej Stachowiak, Maks Orlovich, and
Cameron Zwarich.

AST transfom to replace slow resolve nodes with fast local variable
alternatives that do direct memory access. Currently, only ResolveNode
provides a fast local variable alternative. 6 others are soon to come.

16.7% speedup on SunSpider.

Most of this patch is just scaffolding to support iterating all the
resolve nodes in the AST through optimizeResolveNodes(). In
optimizeResolveNodes(), most classes just push their child nodes onto
the processing stack, while ResolveNodes actually replace themselves in
the tree with more optimized alternatives, if possible.

Here are the interesting bits:

kjs/nodes.h: Added PlacementNewAdoptTag, along with implementations in Node and ResolveNode. This tag allows you to use placement new to swap out a base class Node in favor of a subclass copy that holds the same data. (Without this tag, default initialization would NULL out RefPtrs, change line numbers, etc.)

kjs/nodes.cpp: (KJS::ResolveNode::evaluate): Since we're taking the slow path, ASSERT that the fast path is impossible, to make sure we didn't leave anything on the table.

(KJS::FunctionBodyNode::optimizeResolveNodes): Here's where the AST
transformation happens.

(KJS::ResolveNode::optimizeResolveNodes): Here's where the ResolveNode
optimization happens.

kjs/function.h: Added symbolTable() accessor for, for the sake of an ASSERT.

6:56 PM Changeset in webkit [27198] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

2007-10-28 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Fix "AllInOneFile.o has a global initializer in it".

Some versions of gcc generate a global initializer for std::numeric_limits<size_t>::max().
We can avoid this by moving it inside an inline function.

kjs/SymbolTable.h: (KJS::missingSymbolMarker):
kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::put):

6:50 PM Changeset in webkit [27197] by eseidel

2 edits in trunk/WebKitTools

2007-10-28 Eric Seidel <eric@webkit.org>

Reviewed by Maciej and Geoff, in unison.

Scripts/run-webkit-tests: remove broken --svg option

6:29 PM Changeset in webkit [27196] by mjs

4 edits
1 add in trunk

JavaScriptCore:

Reviewed by Mark.

Added assertions to protect against adding empty or deleted keys to a HashTable

wtf/HashTable.h: (WTF::HashTable::lookup): (WTF::HashTable::lookupForWriting): (WTF::HashTable::fullLookupForWriting): (WTF::HashTable::add):

WebCore:

Reviewed by Mark.

fixed REGRESSION(r27176): Reproducible crash while trying to order dinner makes bdash sad http://bugs.webkit.org/show_bug.cgi?id=15731

bindings/js/kjs_window.cpp: (KJS::Window::installTimeout): Avoid putting in or accessing empty or deleted keys. (KJS::Window::clearTimeout): ditto
manual-tests/bad-clearTimeout-crash.html: Added. Automated test not possible.

5:14 PM Changeset in webkit [27195] by timothy@apple.com

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Remove IDLs from the Copy Bundle Resources phase.

4:08 PM Changeset in webkit [27194] by darin

4 edits in trunk/SunSpider

Reviewed by Adam.

resources/sunspider-analyze-results.js: Tweak the output format a little. Change so that when there's only one run we don't write out confidence intervals at all rather than writing "NaN" over and over again.

sunspider: Use the time and date as a suffix on the results file, that way all the results are left behind in the tmp directory. This will make it easy for us to add features that compare past results in the future. Also rename the .mshark files using the same scheme.

sunspider-compare-results: Relax the parsing rules so we can parse the results file exactly as it's emitted from sunspider.

4:06 PM Changeset in webkit [27193] by darin

2 edits in trunk/JavaScriptCore

fix GTK build

kjs/nodes2string.cpp: (KJS::isParserRoundTripNumber): Use isNaN and isInf instead of isnan and isinf.

4:00 PM Changeset in webkit [27192] by darin

3 edits in trunk/WebKitTools

Reviewed by Adam.

Scripts/run-sunspider: Default to "Release" configuration rather than defaulting to the last configuration used as other scripts do. This can still be overriden on the command line with "--debug" if there's some reason to do so. Also fix a typo.

Scripts/sunspider-compare-results: Fix a typo.

3:50 PM Changeset in webkit [27191] by darin

8 edits
6 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15735 remove GroupNode to simplify AST and possibly get a modest speedup

This patch removes 4 node types: GroupNode, PropertyNameNode,
FunctionCallParenBracketNode, and FunctionCallParenDotNode.

To remove GroupNode, we add knowledge of precedence to the tree nodes,
and use that when serializing to determine where parentheses are needed.
This means we no longer have to represent parentheses in the tree.

The precedence values are named after productions in the grammar from the
JavaScript standard.

SunSpider says this is an 0.4% speedup.

kjs/function.h:
kjs/function.cpp: Removed escapeStringForPrettyPrinting -- it's part of serialization, so I moved it to the file that takes care of that.

kjs/grammar.y: Changed makeGetterOrSetterPropertyNode to use 0 to indicate failure instead of a separate boolean. Got rid of PropertyNameNode by merging the PropertyName rule into the Property rule (which was easier than figuring out how to pass the Identifier from one node to another). Got rid of GroupNode, nodeInsideAllParens(), FunctionCallParenBracketNode, and FunctionCallParenDotNode.

kjs/nodes.h: Removed unused forward declarations and Operator values. Added Precedence enum, and precedence function to all nodes. Removed nodeInsideAllParens. Added streamBinaryOperator function for serialization. Removed GroupNode and PropertyNameNode. Made PropertyNode store an Identifier. Removed FunctionCallParenBracketNode and FunctionCallParenDotNode.

kjs/nodes.cpp: Removed Node::nodinsideAllParens, GroupNode, and PropertyNameNode. (KJS::PropertyListNode::evaluate): Changed code to get name directly instead of converting it from an Identifier to a jsString then back to a UString then into an Identifier again!

kjs/nodes2string.cpp: Changed special-token implementation to use a separate function for each of Endl, Indent, Unindent, and DotExpr instead of using a single function with a switch. Added a precedence that you can stream in, to cause the next node serialized to add parentheses based on that precedence value. (KJS::operatorString): Moved to the top of the file. (KJS::escapeStringForPrettyPrinting): Moved here from function.cpp. Removed old workaround for snprintf, since StringExtras.h takes care of that. (KJS::operator<<): Made the char and char* versions faster by using UString's character append functions instead of constructing a UString. Added the logic to the Node* version to add parentheses if needed. (KJS::Node::streamLeftAssociativeBinaryOperator): Added helper function. (KJS::ElementNode::streamTo): Use PrecAssignment for the elements. (KJS::BracketAccessorNode::streamTo): Use PrecCall for the expression before the bracket. (KJS::DotAccessorNode::streamTo): Use PrecCall for the expression before the dot. (KJS::ArgumentListNode::streamTo): Use PrecAssignment for the arguments. (KJS::NewExprNode::streamTo): Use PrecMember for the expression. (KJS::FunctionCallValueNode::streamTo): Use PrecCall. (KJS::FunctionCallBracketNode::streamTo): Ditto. (KJS::FunctionCallDotNode::streamTo): Ditto. (KJS::PostfixBracketNode::streamTo): Ditto. (KJS::PostfixDotNode::streamTo): Ditto. (KJS::PostfixErrorNode::streamTo): Use PrecLeftHandSide. (KJS::DeleteBracketNode::streamTo): Use PrecCall. (KJS::DeleteDotNode::streamTo): Ditto. (KJS::DeleteValueNode::streamTo): Use PrecUnary. (KJS::VoidNode::streamTo): Ditto. (KJS::TypeOfValueNode::streamTo): Ditto. (KJS::PrefixBracketNode::streamTo): Use PrecCall. (KJS::PrefixDotNode::streamTo): Ditto. (KJS::PrefixErrorNode::streamTo): Use PrecUnary. (KJS::UnaryPlusNode::streamTo): Ditto. (KJS::NegateNode::streamTo): Ditto. (KJS::BitwiseNotNode::streamTo): Ditto. (KJS::LogicalNotNode::streamTo): Ditto. (KJS::MultNode::streamTo): Use streamLeftAssociativeBinaryOperator. (KJS::DivNode::streamTo): Ditto. (KJS::ModNode::streamTo): Ditto. (KJS::AddNode::streamTo): Ditto. (KJS::SubNode::streamTo): Ditto. (KJS::LeftShiftNode::streamTo): Ditto. (KJS::RightShiftNode::streamTo): Ditto. (KJS::UnsignedRightShiftNode::streamTo): Ditto. (KJS::LessNode::streamTo): Ditto. (KJS::GreaterNode::streamTo): Ditto. (KJS::LessEqNode::streamTo): Ditto. (KJS::GreaterEqNode::streamTo): Ditto. (KJS::InstanceOfNode::streamTo): Ditto. (KJS::InNode::streamTo): Ditto. (KJS::EqualNode::streamTo): Ditto. (KJS::NotEqualNode::streamTo): Ditto. (KJS::StrictEqualNode::streamTo): Ditto. (KJS::NotStrictEqualNode::streamTo): Ditto. (KJS::BitAndNode::streamTo): Ditto. (KJS::BitXOrNode::streamTo): Ditto. (KJS::BitOrNode::streamTo): Ditto. (KJS::LogicalAndNode::streamTo): Ditto. (KJS::LogicalOrNode::streamTo): Ditto. (KJS::ConditionalNode::streamTo): Ditto. (KJS::AssignResolveNode::streamTo): Use PrecAssignment for the right side. (KJS::AssignBracketNode::streamTo): Use PrecCall for the expression before the bracket and PrecAssignment for the right side. (KJS::AssignDotNode::streamTo): Ditto. (KJS::AssignErrorNode::streamTo): Use PrecLeftHandSide for the left side and PrecAssignment for the right side. (KJS::CommaNode::streamTo): Use PrecAssignment for both expressions. (KJS::AssignExprNode::streamTo): Use PrecAssignment.

LayoutTests:

Reviewed by Maciej.

test for http://bugs.webkit.org/show_bug.cgi?id=15735 remove GroupNode to simplify AST and possibly get a modest speedup

One test is a start at testing that parentheses are added when needed.
The other test checks some aspects of object literals, since I changed
the way the property names is handled in those. More tests are needed.

fast/js/function-toString-object-literals-expected.txt: Added.
fast/js/function-toString-object-literals.html: Added.
fast/js/function-toString-parentheses-expected.txt: Added.
fast/js/function-toString-parentheses.html: Added.
fast/js/resources/function-toString-object-literals.js: Added.
fast/js/resources/function-toString-parentheses.js: Added.

2:27 PM Changeset in webkit [27190] by kevino

12 edits in trunk/WebCore

wx port defines for graphics and network layers.

2:09 PM Changeset in webkit [27189] by alp

4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

http://bugs.webkit.org/show_bug.cgi?id=14124
[CURL] Support data URLs

Add data URL support (both Base64 and percent-encoded formats).

Inspired by code from the Qt port.

1:23 PM Changeset in webkit [27188] by alp

2 edits in trunk/WebCore

http://bugs.webkit.org/show_bug.cgi?id=15701
The curl http backend does not deal properly with redirects

Implement http redirect support.

12:18 PM Changeset in webkit [27187] by kevino

25 edits in trunk

Add the defines, platform types and options needed for the wx port.

11:20 AM Changeset in webkit [27186] by mrowe@apple.com

10 edits in trunk

2007-10-28 Mark Rowe <mrowe@apple.com>

We don't include "config.h" in headers.

bindings/jni/jni_instance.h:
kjs/regexp.h:
wtf/TCPageMap.h:
wtf/TCSpinLock.h:

2007-10-28 Mark Rowe <mrowe@apple.com>

We don't include "config.h" in headers.

dom/XMLTokenizer.h:
platform/graphics/svg/SVGResourceFilter.h:
platform/image-decoders/ImageDecoder.h:
platform/wx/FontPlatformData.h:

10:53 AM UsingSafari2WithSafari3PublicBetaInstalled edited by djvasi@gmail.com

Self-contained Safari 3 (diff)

10:41 AM Changeset in webkit [27185] by darin

1 edit in trunk/WebCore/ChangeLog

Removed some "Reviewed by NOBODY".

10:37 AM Changeset in webkit [27184] by darin

1 edit in trunk/WebKitTools/ChangeLog

Removed some "Reviewed by NOBODY".

10:36 AM Changeset in webkit [27183] by darin

1 edit in trunk/WebKitLibraries/ChangeLog

Removed some "Reviewed by NOBODY".

10:31 AM Changeset in webkit [27182] by darin

2 edits in trunk/WebCore

platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h: We don't include "config.h" in headers. Hope this desn't break the non-SVG build again.

10:22 AM Changeset in webkit [27181] by darin

2 edits in trunk/WebKit/win

try to fix Windows build

WebKit.vcproj/WebKit.vcproj: Suppress warning 4800 (conversion to bool), since we don't want to add !! everywhere, and because HashTable.h has a conversion to bool of this type now.

4:47 AM Changeset in webkit [27180] by eseidel

3 edits in trunk/WebCore

2007-10-28 Eric Seidel <eric@webkit.org>

Build fix for non-SVG build, no review.

platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:
platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.mm:

3:34 AM Changeset in webkit [27179] by eseidel

58 edits
3 adds in trunk/WebCore

2007-10-28 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

Push SVGResourceFilter platform specific data down into m_platformData
in preparation for implementing a non-mac filter solution.

Also update a very old email address in copyright headers

WebCore.xcodeproj/project.pbxproj:
platform/graphics/FloatPoint3D.cpp: (WebCore::FloatPoint3D::FloatPoint3D):
platform/graphics/FloatPoint3D.h:
platform/graphics/svg/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter):
platform/graphics/svg/SVGResourceFilter.h: (WebCore::SVGResourceFilter::platformData): (WebCore::SVGResourceFilter::effects):
platform/graphics/svg/cg/SVGResourceFilterCg.mm: (WebCore::SVGResourceFilter::createPlatformData):l (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
platform/graphics/svg/filters/SVGDistantLightSource.h:
platform/graphics/svg/filters/SVGFEBlend.cpp:
platform/graphics/svg/filters/SVGFEBlend.h:
platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
platform/graphics/svg/filters/SVGFEColorMatrix.h:
platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
platform/graphics/svg/filters/SVGFEComponentTransfer.h:
platform/graphics/svg/filters/SVGFEComposite.cpp:
platform/graphics/svg/filters/SVGFEComposite.h:
platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
platform/graphics/svg/filters/SVGFEDisplacementMap.h:
platform/graphics/svg/filters/SVGFEFlood.cpp:
platform/graphics/svg/filters/SVGFEFlood.h:
platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
platform/graphics/svg/filters/SVGFEGaussianBlur.h:
platform/graphics/svg/filters/SVGFEImage.cpp:
platform/graphics/svg/filters/SVGFEImage.h:
platform/graphics/svg/filters/SVGFEMerge.cpp:
platform/graphics/svg/filters/SVGFEMerge.h:
platform/graphics/svg/filters/SVGFEMorphology.cpp:
platform/graphics/svg/filters/SVGFEMorphology.h:
platform/graphics/svg/filters/SVGFEOffset.cpp:
platform/graphics/svg/filters/SVGFEOffset.h:
platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
platform/graphics/svg/filters/SVGFESpecularLighting.h:
platform/graphics/svg/filters/SVGFETile.h:
platform/graphics/svg/filters/SVGFETurbulence.cpp:
platform/graphics/svg/filters/SVGFETurbulence.h:
platform/graphics/svg/filters/SVGFilterEffect.cpp:
platform/graphics/svg/filters/SVGFilterEffect.h:
platform/graphics/svg/filters/SVGLightSource.cpp:
platform/graphics/svg/filters/SVGLightSource.h:
platform/graphics/svg/filters/SVGPointLightSource.h:
platform/graphics/svg/filters/SVGSpotLightSource.h:
platform/graphics/svg/filters/cg/SVGFEBlendCg.mm: (WebCore::SVGFEBlend::getCIFilter):
platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm: (WebCore::SVGFEColorMatrix::getCIFilter):
platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm: (WebCore::SVGFEComponentTransfer::getCIFilter):
platform/graphics/svg/filters/cg/SVGFECompositeCg.mm: (WebCore::SVGFEComposite::getCIFilter):
platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm: (WebCore::SVGFEDiffuseLighting::getCIFilter):
platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm: (WebCore::SVGFEDisplacementMap::getCIFilter):
platform/graphics/svg/filters/cg/SVGFEFloodCg.mm: (WebCore::SVGFEFlood::getCIFilter):
platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
platform/graphics/svg/filters/cg/SVGFEImageCg.mm: (WebCore::SVGFEImage::getCIFilter):
platform/graphics/svg/filters/cg/SVGFEMergeCg.mm: (WebCore::SVGFEMerge::getCIFilter):
platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm: (WebCore::SVGFESpecularLighting::getCIFilter):
platform/graphics/svg/mac: Added.
platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h: Added.
platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.mm: Added. (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac): (WebCore::SVGResourceFilterPlatformDataMac::~SVGResourceFilterPlatformDataMac): (WebCore::SVGResourceFilterPlatformDataMac::getCIFilterStack): (WebCore::alphaImageForImage): (WebCore::SVGResourceFilterPlatformDataMac::imageForName): (WebCore::SVGResourceFilterPlatformDataMac::setImageForName): (WebCore::SVGResourceFilterPlatformDataMac::setOutputImage): (WebCore::SVGResourceFilterPlatformDataMac::inputImage):

3:19 AM Changeset in webkit [27178] by mjs

3 edits in trunk/JavaScriptCore

Rubber stamped by Mark.

avoid using non-portable SIZE_T_MAX in favor of std::numeric_limits

kjs/SymbolTable.h: (KJS::SymbolTableIndexHashTraits::emptyValue):
kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::put):

2:20 AM Changeset in webkit [27177] by mjs

4 edits in trunk/JavaScriptCore

Reviewed by Eric.

switch SymbolTable to be a HashMap instead of a PropertyMap for 3% SunSpider speedup

kjs/SymbolTable.h: (KJS::IdentifierRepHash::hash): Special hash function for identifier reps. (KJS::IdentifierRepHash::equal): ditto (KJS::SymbolTableIndexHashTraits::emptyValue): Special HashTraits for the index value. (KJS::SymbolTable): change to a typedef for a HashMap.
kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): Adjusted for new SymbolTable API. (KJS::ActivationImp::deleteProperty): ditto (KJS::ActivationImp::put): ditto

kjs/nodes.cpp: (KJS::FunctionBodyNode::initializesymbolTable): Adjusted, since you now have to store a UString::rep, not an identifier.

1:17 AM Changeset in webkit [27176] by mjs

8 edits in trunk/JavaScriptCore

Reviewed by Oliver.

numerous HashTable performance improvements

This does not quite add up to a measurable win on SunSpider, but it allows a
follow-on > 3% improvement and probably helps WebCore too.

I made the following improvements, among others:

Made HashFunctions note whether it is ok to compare a real value with the equal() function to the empty or deleted value, and used this to optimize the comparisons done in hash lookup.

Specialized lookup so it doesn't have to do so many extra branches and build so many extra std::pairs for cases that don't need them. There are now four versions, one for read-only access, two for writing, and one folded directly into add() (these all were improvments).

Made HashMap::get() use lookup() directly instead of find() to avoid having to build iterators.

Made a special constructor for iterators that knows it points to a valid filled cell and so skips updating itself.

Reordered memory accesses in the various lookup functions for better codegetion

Made simple translators avoid passing a hash code around

Other minor tweaks

wtf/HashTable.h: (WTF::): (WTF::HashTableConstIterator::HashTableConstIterator): (WTF::HashTableIterator::HashTableIterator): (WTF::IdentityHashTranslator::translate): (WTF::HashTable::end): (WTF::HashTable::lookup): (WTF::HashTable::lookupForWriting): (WTF::HashTable::makeKnownGoodIterator): (WTF::HashTable::makeKnownGoodConstIterator): (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add): (WTF::::addPassingHashCode): (WTF::::reinsert): (WTF::::find): (WTF::::contains):
kjs/identifier.cpp: (WTF::):
wtf/HashFunctions.h: (WTF::):
wtf/HashMap.h: (WTF::): (WTF::::get):
wtf/HashSet.h: (WTF::): (WTF::::add):
wtf/ListHashSet.h: (WTF::ListHashSetTranslator::translate):

1:02 AM Changeset in webkit [27175] by ap

2 edits in trunk/WebCore

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=15217
Plugin complains that xpcom_core.dll missing

plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::isPluginBlacklisted): Blacklist npmozax.dll.

12:32 AM Changeset in webkit [27174] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Adam.

Pass the Document's domain to InspectorController:didOpenDatabase. This matches
what the Inspector shows for other resources.

storage/Database.cpp: (WebCore::Database::openDatabase):

dom/Document.h: Remove KURL.h, no longer needed.

12:08 AM Changeset in webkit [27173] by timothy@apple.com

14 edits in trunk/WebCore

Reviewed by Adam.

Bug 15728: Selected Resource background image gradient has banding
http://bugs.webkit.org/show_bug.cgi?id=15728

Reduced images to 1px wide that are tiled horizontally in CSS.
Corrected the -webkit-background-size usage to specify auto for the width.

page/inspector/Images/attachedShadow.png:
page/inspector/Images/bottomShadow.png:
page/inspector/Images/darkShadow.png:
page/inspector/Images/gradient.png:
page/inspector/Images/gradientHighlight.png:
page/inspector/Images/gradientHighlightBottom.png:
page/inspector/Images/sidebarSelection.png:
page/inspector/Images/sidebarSelectionBlurred.png:
page/inspector/Images/sidebarSelectionBlurredTall.png:
page/inspector/Images/sidebarSelectionGray.png:
page/inspector/Images/sidebarSelectionGrayTall.png:
page/inspector/Images/sidebarSelectionTall.png:
page/inspector/inspector.css:

12:04 AM Changeset in webkit [27172] by aroben

2 edits in trunk/LayoutTests

Re-enable a bunch of passing tests on Windows

Reviewed by NOBODY.

platform/win/Skipped:

Oct 27, 2007:

11:45 PM Changeset in webkit [27171] by timothy@apple.com

6 edits in trunk/WebCore

Reviewed by Adam.

Bug 15727: Resizing the resource sidebar doesn't scale the font preview or network timeline
http://bugs.webkit.org/show_bug.cgi?id=15727

Add one window resize listener and call the new resize function on the currentPanel.
Also call the currentPanel's resize function when resizing the sidebar.

page/inspector/DocumentPanel.js: Implement resize and call updateTreeSelection() when the panel is shown and when resizing the DOM sidebar.
page/inspector/FontPanel.js: Implement resize.
page/inspector/NetworkPanel.js: Ditto.
page/inspector/inspector.js: Add a window resize listener.

11:31 PM Changeset in webkit [27170] by mjs

11 edits in trunk/WebCore

Reviewed by Oliver.

update for HashTable changes

bindings/js/JSSVGPODTypeWrapper.h:
dom/Document.h:
dom/QualifiedName.cpp:
dom/StyledElement.cpp:
ksvg2/svg/SVGAnimatedTemplate.h:
platform/FontCache.cpp:
platform/StringHash.h: (WTF::):
platform/TextEncodingRegistry.cpp:
platform/graphics/IntSizeHash.h: (WTF::):
plugins/win/PluginPackageWin.h:

10:34 PM Changeset in webkit [27169] by alp

5 edits in trunk/WebCore

2007-10-28 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=15646
[GTK] caretBlinkFrequency is hard-coded in Frame.cpp

Abstract caretBlinkFrequency to RenderTheme.

page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::caretShouldBlink): (WebCore::RenderThemeGtk::caretBlinkFrequency):
platform/gtk/RenderThemeGtk.h:
rendering/RenderTheme.h:

10:22 PM Changeset in webkit [27168] by alp

2 edits in trunk/WebKit/gtk

2007-10-28 Lars Lindner <lars.lindner@gmail.com>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=15466
[gtk] widget does not take focus on mouse click

Grab widget focus in mouse press callback.

Api/webkitgtkpage.cpp:

10:02 PM Changeset in webkit [27167] by aroben

2 edits in trunk/LayoutTests

Updated Windows Skipped file for currently failing tests

Reviewed by NOBODY.

platform/win/Skipped:

9:38 PM Changeset in webkit [27166] by aroben

1 edit
5 adds
1 delete in trunk/LayoutTests

Fix HTMLDocument12.xhtml on Leopard/Windows

<rdar://5313535> and <rdar://5539816>

The test succeeds on Leopard and Windows, but fails on Tiger. For some
reason, failing expected results had been checked in to
platform/mac-leopard. The test seems to be passing now, so I moved the
failing results to platform/mac-tiger.

Reviewed by Maciej and Sam.

platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Removed.
platform/mac-tiger/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Moved from platform/mac-leopard.

9:24 PM Changeset in webkit [27165] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam.

Don't print the line number in the Inspector Console if it is Zero.

page/inspector/ConsolePanel.js:

8:31 PM Changeset in webkit [27164] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Eric.

fix ASCIICType.h for some Windows compiles

wtf/ASCIICType.h: Check the compiler, not the OS, since it's the compiler/library that has the wchar_t that is just a typedef.

8:12 PM Changeset in webkit [27163] by weinig

1 edit
2 adds in trunk/LayoutTests

Hit with the rubber-stamp of Timothy Hatcher.

Tests for window.console's functions.

fast/dom/Window/console-functions-expected.txt: Added.
fast/dom/Window/console-functions.html: Added.

7:52 PM Changeset in webkit [27162] by weinig

2 edits
1 add in trunk/LayoutTests

Reviewed by Tim Hatcher.

Speculative fix for an intermittently failing test

fast/dom/Window/resources/opened-window.html: Added.
fast/dom/Window/window-early-properties.html: Use onload for opened window and use a local file instead of a data: URL to avoid same origin check issues.

7:11 PM Changeset in webkit [27161] by weinig

13 edits
3 adds in trunk

WebCore:

Reviewed by Adam Roben.

Fix http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore

Adds a window.console object that has 4 methods (log, info, warn, and error) that send messages to the Chrome. This moves functionality that was in the app down into WebCore.

DerivedSources.make:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/scripts/CodeGeneratorJS.pm: Add extended attribute to mark attributes as [Replacable] which indicates they can overridden when set.
page/Chrome.cpp: (WebCore::Chrome::addMessageToConsole): Allow all messages to go up to the ChromeClient.
page/Console.cpp: Added. (WebCore::Console::Console): (WebCore::Console::disconnectFrame): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::warn):
page/Console.h: Added.
page/Console.idl: Added.
page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::console):
page/DOMWindow.h:
page/DOMWindow.idl:

LayoutTests:

Reviewed by Adam Roben.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore

fast/dom/Window/window-properties-expected.txt:
http/tests/security/cross-frame-access-put-expected.txt:

5:47 PM Changeset in webkit [27160] by pewtermoose

2 edits in trunk/LayoutTests

Update results

5:02 PM Changeset in webkit [27159] by aroben

2 edits in trunk/LayoutTests

Speculative fix for an intermittently failing test

Reviewed by Sam and Eric.

http/tests/local/style-access-before-stylesheet-loaded.html: Use waitUntilDone/notifyDone.

4:53 PM Changeset in webkit [27158] by eseidel

20 edits in trunk/WebCore

2007-10-27 Eric Seidel <eric@webkit.org>

Reviewed by aroben.

Remove legacy createFilterEffect function (causing extra filter tests to fail on windows)

No functional changes, thus no tests.

ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::filterEffect):
ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
ksvg2/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::filterEffect):
ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::filterEffect):
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
ksvg2/svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::filterEffect):
ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::filterEffect):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::filterEffect):
ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::filterEffect):
ksvg2/svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::filterEffect):
ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::filterEffect):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::filterEffect):
ksvg2/svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::filterEffect):
ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::filterEffect):
platform/graphics/svg/SVGResourceFilter.h:
platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
platform/graphics/svg/cg/SVGResourceFilterCg.mm:
platform/graphics/svg/qt/SVGResourceFilterQt.cpp:

4:31 PM Changeset in webkit [27157] by aroben

2 edits in trunk/LayoutTests

Add some more failing tests to the Windows Skipped file

Reviewed by NOBODY.

platform/win/Skipped:

4:26 PM Changeset in webkit [27156] by kmccullo

3 edits
2 adds in trunk/WebKit/win

Reviewed by Adam.

Stubbed out IWebScriptCallFrame for Drosera.

Interfaces/IWebScriptCallFrame.idl: Added function declarations.
WebKit.vcproj/WebKit.vcproj: Added .h/.cpp files to the project.
WebScriptCallFrame.cpp: Added. (WebScriptCallFrame::WebScriptCallFrame): (WebScriptCallFrame::~WebScriptCallFrame): (WebScriptCallFrame::createInstance): (WebScriptCallFrame::QueryInterface): (WebScriptCallFrame::AddRef): (WebScriptCallFrame::Release): (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::evaluateWebScript):
WebScriptCallFrame.h: Added.

4:25 PM Changeset in webkit [27155] by mitz

3 edits
2 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix a crash when opening Zenoss server history view <rdar://problem/5530657>

Test: fast/table/colgroup-relative.html

rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Added a hasLayer() check before accessing layer().

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/5530657>

fast/table/colgroup-relative-expected.txt: Added.
fast/table/colgroup-relative.html: Added.

3:45 PM Changeset in webkit [27154] by kmccullo

2 edits in trunk/JavaScriptCore

BuildFix
Forgot to change the build step when I changed the filename.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

12:20 PM Changeset in webkit [27153] by ggaren

3 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Fixed the rest of "ASSERTION FAILED: _hash in KJS::UString::Rep::
computedHash()"
http://bugs.webkit.org/show_bug.cgi?id=15718

kjs/identifier.cpp: Fixed more cases where an Identifier didn't get a hash value. Also changed O(n) strlen to O(1) check for empty string. (KJS::Identifier::add):

kjs/ustring.cpp: Changed O(n) strlens to O(1) checks for empty string. (KJS::UString::UString): (KJS::UString::operator=):

12:10 PM Changeset in webkit [27152] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Eric.

a couple of Windows fixes

wtf/MathExtras.h: (wtf_pow): Add a special case for MSVC, which has a "pow" function that does not properly handle the case where arg1 is NaN and arg2 is 0.

kjs/math_object.cpp: (MathFuncImp::callAsFunction): Don't explicity specify "::pow" -- just "pow" is fine.

wtf/ASCIICType.h: Check the compiler, not the OS, since it's the compiler/library that has the wchar_t that is just a typedef.

11:51 AM Changeset in webkit [27151] by ap

4 edits
2 adds in trunk

2007-10-27 Julien <julien.chaffraix@gmail.com>

Reviewed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=13141
XMLHttpRequest should set readyState to 0 after abort()

Test: http/tests/xmlhttprequest/xmlhttprequest-abort-readyState.html

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::abort):

9:54 AM Changeset in webkit [27150] by mitz

3 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix rotated border images by using a temporary subimage containing only the part we want to tile

Test: fast/borders/border-image-rotate-transform.html

platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):

LayoutTests:

Reviewed by Dave Hyatt.

rotated border image test

fast/borders/border-image-rotate-transform.html: Added.
platform/mac/fast/borders/border-image-rotate-transform-expected.checksum: Added.
platform/mac/fast/borders/border-image-rotate-transform-expected.png: Added.
platform/mac/fast/borders/border-image-rotate-transform-expected.txt: Added.

7:48 AM Changeset in webkit [27149] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=15711 force JSImmediate to be inlined for roughly 1.2% SunSpider speedup

kjs/JSImmediate.h: Put ALWAYS_INLINE on everything.

kjs/object.h: Removed redundant includes.
kjs/value.h: Ditto.

3:46 AM Changeset in webkit [27148] by mrowe@apple.com

2 edits in trunk/WebKit

2007-10-27 Mark Ambachtsheer <mark.a@apple.com>

Reviewed by Darin.

Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
(0, 0) the clipping rectangle is not correct.
Added the origin to the window clip rectangle coordinates to account for plugins that
don't originate at (0,0); affects code for offscreen GWorlds only.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

3:39 AM Changeset in webkit [27147] by alp

3 edits in trunk/WebCore

2007-10-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=15722
[GTK] Refactor gtk/RenderThemeGtk and implement a few more methods

Refactor/enhance GTK RenderTheme

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::supportsFocus): added TextArea, Menulist, Radio, and Checkbox Appearances (WebCore::RenderThemeGtk::supportsFocusRing): call supportsFocus() to check if focus on appearance is supported (WebCore::RenderThemeGtk::controlSupportsTints): copied from Qt and Safari ports (WebCore::RenderThemeGtk::baselinePosition): copied from Qt and Safari ports (WebCore::RenderThemeGtk::paintCheckbox): moved painting in paintButton (WebCore::RenderThemeGtk::paintRadio): moved painting in paintButton (WebCore::RenderThemeGtk::paintButton): paint the different buttons here, checking for the right appearance before doing so (WebCore::RenderThemeGtk::paintMenuList): use 0 instead of NULLs (WebCore::RenderThemeGtk::adjustTextFieldStyle): (WebCore::RenderThemeGtk::getThemeData):
platform/gtk/RenderThemeGtk.h: (WebCore::RenderThemeGtk::supportsControlTints):

3:23 AM Changeset in webkit [27146] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Mark.

fixed "ASSERTION FAILED: _hash in KJS::UString::Rep::computedHash()" http://bugs.webkit.org/show_bug.cgi?id=15718

kjs/identifier.cpp: (KJS::Identifier::addSlowCase): Ensure that empty Identifiers have a hash computed, now that we count on all Identifiers already having one.

1:40 AM Changeset in webkit [27145] by ap

6 edits
5 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15555
XMLHttpRequest does not support charset "x-user-defined", which can
facilitate loading of binary data

Test: http/tests/xmlhttprequest/binary-x-user-defined.html

WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/TextCodecUserDefined.cpp: Added. (WebCore::TextCodecUserDefined::registerEncodingNames): (WebCore::newStreamingTextDecoderUserDefined): (WebCore::TextCodecUserDefined::registerCodecs): (WebCore::TextCodecUserDefined::decode): (WebCore::encodeComplexUserDefined): (WebCore::TextCodecUserDefined::encode):
platform/TextCodecUserDefined.h: Added.
platform/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):

1:16 AM Changeset in webkit [27144] by ap