⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 30, 2007:

11:57 PM Changeset in webkit [27293] by aroben
  • 3 edits in trunk/WebCore

Windows build fixes

I'm not completely sure why these const issues weren't caught by GCC,
but MSVC was certainly not happy with them.

  • editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote):
  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl):
11:09 PM Changeset in webkit [27292] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Oliver.



We do this by using a single mark bit per two number cells, and
tweaking marking.


Besides being an 0.5% win overall, this is a 7.1% win on morph.

  • kjs/collector.cpp: (KJS::): (KJS::Collector::heapAllocate): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::sweep):
  • kjs/collector.h: (KJS::SmallCollectorCell::):
8:55 PM Changeset in webkit [27291] by hyatt
  • 7 edits in trunk/WebCore

transition-property was defaulting to all when it should default to none.

It was taking a string type. I figured out how to make it take an ident instead, so you can write:

transition-property: opacity

instead of

transition-property: "opacity"

Transition layers also weren't properly repeating patterns the way they were supposed to. I fixed that.

Finally, I fixed a bug in the code to fix up transition layers where something was misplaced that should have been inside a null check.

Reviewed by aroben

  • css/CSSHelper.h:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransitionProperty):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • page/AnimationController.cpp: (WebCore::ImplicitAnimation::animate):
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::adjustTransitions):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::initialTransitionProperty):
8:30 PM Changeset in webkit [27290] by antti
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Leak fix

  • platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::getSupportedTypes):
8:04 PM Changeset in webkit [27289] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam Roben, Sam Weinig.


Made conflicts in grammar.y a persistent build failure.

  • DerivedSources.make:
7:47 PM Changeset in webkit [27288] by mitz
  • 2 edits in trunk/WebCore

Reviewed by Stephanie Lewis.

  • fix <rdar://problem/5547237> REGRESSION (304-ToT): Repro font-related crash in fontdatawin.cpp Line 93 (many sites)
  • platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): Handle the case where the font has no glyphs on page zero.
7:36 PM Changeset in webkit [27287] by hyatt
  • 1 edit in trunk/WebCore/page/AnimationController.cpp

Fix Qt bustage in AnimationController.cpp

7:35 PM Changeset in webkit [27286] by antti
  • 4 edits
    85 adds in trunk/LayoutTests

Reviewed by Maciej.


Media tests from feature branch.

  • fast/dom/Window/window-properties-expected.txt: Replaced.
  • fast/dom/Window/window-properties.html: Replaced.
  • media: Added.
  • media/audio-constructor-expected.txt: Added.
  • media/audio-constructor-src-expected.txt: Added.
  • media/audio-constructor-src.html: Added.
  • media/audio-constructor.html: Added.
  • media/content: Added.
  • media/content/test.mp4: Added.
  • media/content/test.wav: Added.
  • media/progress-event-expected.txt: Added.
  • media/progress-event.html: Added.
  • media/video-append-source-expected.txt: Added.
  • media/video-append-source.html: Added.
  • media/video-autoplay-expected.txt: Added.
  • media/video-autoplay.html: Added.
  • media/video-buffered-expected.txt: Added.
  • media/video-buffered.html: Added.
  • media/video-cuepoint-add-expected.txt: Added.
  • media/video-cuepoint-add.html: Added.
  • media/video-cuepoint-multiple-expected.txt: Added.
  • media/video-cuepoint-multiple.html: Added.
  • media/video-cuepoint-pause-expected.txt: Added.
  • media/video-cuepoint-pause.html: Added.
  • media/video-cuepoint-remove-expected.txt: Added.
  • media/video-cuepoint-remove-multiple-expected.txt: Added.
  • media/video-cuepoint-remove-multiple.html: Added.
  • media/video-cuepoint-remove.html: Added.
  • media/video-currentTime-expected.txt: Added.
  • media/video-currentTime-set-expected.txt: Added.
  • media/video-currentTime-set.html: Added.
  • media/video-currentTime-set2-expected.txt: Added.
  • media/video-currentTime-set2.html: Added.
  • media/video-currentTime.html: Added.
  • media/video-dom-autoplay-expected.txt: Added.
  • media/video-dom-autoplay.html: Added.
  • media/video-dom-end-expected.txt: Added.
  • media/video-dom-end.html: Added.
  • media/video-dom-loopcount-expected.txt: Added.
  • media/video-dom-loopcount.html: Added.
  • media/video-dom-loopend-expected.txt: Added.
  • media/video-dom-loopend.html: Added.
  • media/video-dom-loopstart-expected.txt: Added.
  • media/video-dom-loopstart.html: Added.
  • media/video-dom-src-expected.txt: Added.
  • media/video-dom-src.html: Added.
  • media/video-dom-start-expected.txt: Added.
  • media/video-dom-start.html: Added.
  • media/video-end-expected.txt: Added.
  • media/video-end.html: Added.
  • media/video-error-abort-expected.txt: Added.
  • media/video-error-abort.html: Added.
  • media/video-error-does-not-exist-expected.txt: Added.
  • media/video-error-does-not-exist.html: Added.
  • media/video-load-networkState-expected.txt: Added.
  • media/video-load-networkState.html: Added.
  • media/video-load-readyState-expected.txt: Added.
  • media/video-load-readyState.html: Added.
  • media/video-loopcount-expected.txt: Added.
  • media/video-loopcount.html: Added.
  • media/video-loopend-expected.txt: Added.
  • media/video-loopend.html: Added.
  • media/video-loopstart-expected.txt: Added.
  • media/video-loopstart.html: Added.
  • media/video-muted-expected.txt: Added.
  • media/video-muted.html: Added.
  • media/video-no-autoplay-expected.txt: Added.
  • media/video-no-autoplay.html: Added.
  • media/video-seekable-expected.txt: Added.
  • media/video-seekable.html: Added.
  • media/video-size-expected.txt: Added.
  • media/video-size.html: Added.
  • media/video-source-expected.txt: Added.
  • media/video-source-media-expected.txt: Added.
  • media/video-source-media.html: Added.
  • media/video-source-type-expected.txt: Added.
  • media/video-source-type.html: Added.
  • media/video-source.html: Added.
  • media/video-src-expected.txt: Added.
  • media/video-src-source-expected.txt: Added.
  • media/video-src-source.html: Added.
  • media/video-src.html: Added.
  • media/video-start-expected.txt: Added.
  • media/video-start.html: Added.
  • media/video-test.js: Added.
  • media/video-volume-expected.txt: Added.
  • media/video-volume.html: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
7:35 PM Changeset in webkit [27285] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderStyle.cpp

Remove unused blendLengths function.

7:32 PM Changeset in webkit [27284] by hyatt
  • 2 edits in trunk/WebCore

Eliminate rounding from int-based animation blending.

7:30 PM Changeset in webkit [27283] by hyatt
  • 6 edits in trunk/WebCore

Make sure CSS transforms can be animated using the CSS transition property.

Reviewed by Dan and Antti

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/AnimationController.cpp: (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate):
  • rendering/Length.h: (WebCore::Length::blend):
  • rendering/RenderStyle.cpp: (WebCore::StyleTransformData::operator==): (WebCore::TransformOperations::operator==): (WebCore::blendLengths): (WebCore::ScaleTransformOperation::blend): (WebCore::RotateTransformOperation::blend): (WebCore::SkewTransformOperation::blend): (WebCore::TranslateTransformOperation::blend): (WebCore::MatrixTransformOperation::blend):
  • rendering/RenderStyle.h: (WebCore::TransformOperations::operator!=): (WebCore::TransformOperations::isEmpty): (WebCore::TransformOperations::size): (WebCore::TransformOperations::operator[]): (WebCore::TransformOperations::append): (WebCore::RenderStyle::transform): (WebCore::RenderStyle::setTransform): (WebCore::RenderStyle::initialTransform):
7:11 PM Changeset in webkit [27282] by antti
  • 2 edits in trunk/WebCore

Another Qt/GTK build fix.

  • bindings/js/JSHTMLElementWrapperFactory.cpp:
6:51 PM Changeset in webkit [27281] by antti
  • 2 edits in trunk/WebCore

Attempt to fix Qt/GTK build.

  • WebCore.pro:
6:27 PM Changeset in webkit [27280] by justing
  • 11 edits
    10 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5549929> CrashTracer: [USER] 35 crashes at WebCore::CharacterData::insertData


We were trying to insert a tab into a br, after the br incorrectly ended up inside
a tab span.


  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): Changed to take in a const Node* instead of a Node*.
  • editing/DeleteSelectionCommand.cpp: (WebCore::isTableRow): Ditto.
  • editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote): Ditto. (WebCore::isListOrIndentBlockquote): Ditto.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::shouldUseBreakElement): Added, moved code from doApply here. (WebCore::InsertLineBreakCommand::doApply): Don't upstream() the insertion position. upstream()ing it will only have an effect when the insertion position is the first in its paragraph (since we canonicalize VisiblePositions to the upstream() candidate). In this start of paragraph case, upstream() can move outside inline elements like tab spans or elements that might have a different whitespace mode (added two test cases to cover these). Moved code to decide whether to insert a br or a '\n' to its own method. Removed special case code for inserting at a position inside a tab span. We instead adjust the insertion position before insertion if it is inside a tab span and handle insertion in the appropriate if-block. This fixes a bug where we would only insert one line break when two were needed (added a testcase). Removed special case code for inserting before and after tables and horizontal rules. We handle these insertions in the appropriate if-block.
  • editing/InsertLineBreakCommand.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Change to take in a const Node*.
  • editing/htmlediting.cpp: (WebCore::isContentEditable): Ditto. (WebCore::isBlock): Ditto. (WebCore::enclosingNodeOfType): Changed to take a function pointer to a function that takes in a const Node*. (WebCore::isTabSpanTextNode): Check to see that the node actually a text node, and not, say, a br.
  • editing/htmlediting.h:
  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Changed to take in a const Node*. (WebCore::elementHasTextDecorationProperty): Ditto.

LayoutTests:

Reviewed by Darin Adler.

<rdar://problem/5549929> CrashTracer: [USER] 35 crashes at WebCore::CharacterData::insertData

  • editing/inserting/5549929-1-expected.txt: Added.
  • editing/inserting/5549929-1.html: Added.
  • editing/inserting/5549929-2.html: Added.
  • editing/inserting/5549929-3.html: Added.
  • platform/mac/editing/inserting/5549929-2-expected.checksum: Added.
  • platform/mac/editing/inserting/5549929-2-expected.png: Added.
  • platform/mac/editing/inserting/5549929-2-expected.txt: Added.
  • platform/mac/editing/inserting/5549929-3-expected.checksum: Added.
  • platform/mac/editing/inserting/5549929-3-expected.png: Added.
  • platform/mac/editing/inserting/5549929-3-expected.txt: Added.
6:23 PM Changeset in webkit [27279] by antti
  • 1 edit
    3 adds in trunk/WebCore

Reviewed by NOBODY.

Add files missing from previous commit.

  • html/VoidCallback.cpp: Added. (VoidCallback::VoidCallback): (VoidCallback::~VoidCallback): (VoidCallback::handleEvent): (VoidCallback::execute): (VoidCallback::operator==): (WebCore::toVoidCallback):
  • html/VoidCallback.h: Added.
  • html/VoidCallback.idl: Added.
6:08 PM Changeset in webkit [27278] by ddkilzer
  • 5 edits in trunk

WebCore:

Generated files missing from WebCore's Xcode project file
<​http://bugs.webkit.org/show_bug.cgi?id=15406>

Reviewed by Darin.

Added the following files to the Xcode project file (note that
JSHTMLInputElementBaseTable.cpp is used as a header file):

  • DOMCSSStyleSheetPrivate.h
  • DOMEventPrivate.h
  • DOMHTMLCollectionPrivate.h
  • DOMHTMLEmbedElementPrivate.h
  • DOMHTMLIFrameElementPrivate.h
  • DOMHTMLObjectElementPrivate.h
  • DOMHTMLSelectElementPrivate.h
  • DOMTextEventInternal.h
  • JSHTMLInputElementBaseTable.cpp
  • DerivedSources.make: Removed DOMSVGException.h and JSSVGAnimatedPoints.h since their generated code was not used.
  • WebCore.xcodeproj/project.pbxproj: Added missing header files.

WebKit:

Generated files missing from WebCore's Xcode project file
<​http://bugs.webkit.org/show_bug.cgi?id=15406>

Reviewed by Darin.

Added the following private header files to MigrateHeaders.make:

  • DOMCSSStyleSheetPrivate.h
  • DOMEventPrivate.h
  • DOMHTMLCollectionPrivate.h
  • DOMHTMLEmbedElementPrivate.h
  • DOMHTMLIFrameElementPrivate.h
  • DOMHTMLObjectElementPrivate.h
  • DOMHTMLSelectElementPrivate.h
  • MigrateHeaders.make:
6:03 PM Changeset in webkit [27277] by antti
  • 31 edits
    28 adds in trunk/WebCore

Rubber stamped by Adele.

Initial media (<video> and <audio>) support from feature branch and
QTKit based platform implementation.


This will need to be updated to match current draft specification.

  • Configurations/WebCore.xcconfig:
  • DerivedSources.make:
  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSHTMLAudioElementConstructor.cpp: Added. (WebCore::JSHTMLAudioElementConstructor::JSHTMLAudioElementConstructor): (WebCore::JSHTMLAudioElementConstructor::implementsConstruct): (WebCore::JSHTMLAudioElementConstructor::construct):
  • bindings/js/JSHTMLAudioElementConstructor.h: Added.
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp: (WebCore::Document::createEvent): (WebCore::Document::willSaveToCache): (WebCore::Document::didRestoreFromCache): (WebCore::Document::registerForCacheCallbacks): (WebCore::Document::unregisterForCacheCallbacks):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::setBooleanAttribute):
  • dom/Element.h: (WebCore::Element::willSaveToCache):
  • dom/Event.cpp: (WebCore::Event::isProgressEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchProgressEvent):
  • dom/EventTargetNode.h:
  • dom/ProgressEvent.cpp: Added. (WebCore::ProgressEvent::ProgressEvent): (WebCore::ProgressEvent::initProgressEvent): (WebCore::ProgressEvent::initProgressEventNS):
  • dom/ProgressEvent.h: Added. (WebCore::ProgressEvent::lengthComputable): (WebCore::ProgressEvent::loaded): (WebCore::ProgressEvent::total): (WebCore::ProgressEvent::isProgressEvent):
  • dom/ProgressEvent.idl: Added.
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
  • html/HTMLAttributeNames.in:
  • html/HTMLAudioElement.cpp: Added. (WebCore::HTMLAudioElement::HTMLAudioElement):
  • html/HTMLAudioElement.h: Added. (WebCore::HTMLAudioElement::tagPriority):
  • html/HTMLAudioElement.idl: Added.
  • html/HTMLElement.cpp: (WebCore::inlineTagList):
  • html/HTMLElementFactory.cpp: (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor): (WebCore::createFunctionMap):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
  • html/HTMLMediaElement.cpp: Added. (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::checkDTD): (WebCore::HTMLMediaElement::rendererIsNeeded): (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::insertedIntoDocument): (WebCore::HTMLMediaElement::removedFromDocument): (WebCore::HTMLMediaElement::scheduleLoad): (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): (WebCore::HTMLMediaElement::dispatchEventAsync): (WebCore::HTMLMediaElement::loadTimerFired): (WebCore::HTMLMediaElement::asyncEventTimerFired): (WebCore::serializeTimeOffset): (WebCore::parseTimeOffset): (WebCore::HTMLMediaElement::getTimeOffsetAttribute): (WebCore::HTMLMediaElement::setTimeOffsetAttribute): (WebCore::HTMLMediaElement::error): (WebCore::HTMLMediaElement::src): (WebCore::HTMLMediaElement::HTMLMediaElement::setSrc): (WebCore::HTMLMediaElement::currentSrc): (WebCore::HTMLMediaElement::networkState): (WebCore::HTMLMediaElement::bufferingRate): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::movieNetworkStateChanged): (WebCore::HTMLMediaElement::movieReadyStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::progressEventTimerFired): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::readyState): (WebCore::HTMLMediaElement::seeking): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::setCurrentTime): (WebCore::HTMLMediaElement::duration): (WebCore::HTMLMediaElement::paused): (WebCore::HTMLMediaElement::defaultPlaybackRate): (WebCore::HTMLMediaElement::setDefaultPlaybackRate): (WebCore::HTMLMediaElement::playbackRate): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::ended): (WebCore::HTMLMediaElement::autoplay): (WebCore::HTMLMediaElement::setAutoplay): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::loopCount): (WebCore::HTMLMediaElement::setLoopCount): (WebCore::HTMLMediaElement::start): (WebCore::HTMLMediaElement::setStart): (WebCore::HTMLMediaElement::end): (WebCore::HTMLMediaElement::setEnd): (WebCore::HTMLMediaElement::loopStart): (WebCore::HTMLMediaElement::setLoopStart): (WebCore::HTMLMediaElement::loopEnd): (WebCore::HTMLMediaElement::setLoopEnd): (WebCore::HTMLMediaElement::currentLoop): (WebCore::HTMLMediaElement::setCurrentLoop): (WebCore::HTMLMediaElement::controls): (WebCore::HTMLMediaElement::setControls): (WebCore::HTMLMediaElement::volume): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::muted): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::pickMedia): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::movieVolumeChanged): (WebCore::HTMLMediaElement::movieDidEnd): (WebCore::HTMLMediaElement::movieCuePointReached): (WebCore::HTMLMediaElement::addCuePoint): (WebCore::HTMLMediaElement::removeCuePoint): (WebCore::HTMLMediaElement::buffered): (WebCore::HTMLMediaElement::played): (WebCore::HTMLMediaElement::seekable): (WebCore::HTMLMediaElement::effectiveStart): (WebCore::HTMLMediaElement::effectiveEnd): (WebCore::HTMLMediaElement::effectiveLoopStart): (WebCore::HTMLMediaElement::effectiveLoopEnd): (WebCore::HTMLMediaElement::activelyPlaying): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
  • html/HTMLMediaElement.h: Added. (WebCore::HTMLMediaElement::movie): (WebCore::HTMLMediaElement::isVideo): (WebCore::HTMLMediaElement::): (WebCore::HTMLMediaElement::CallbackEntry::CallbackEntry):
  • html/HTMLMediaElement.idl: Added.
  • html/HTMLSourceElement.cpp: Added. (WebCore::HTMLSourceElement::HTMLSourceElement): (WebCore::HTMLSourceElement::~HTMLSourceElement): (WebCore::HTMLSourceElement::insertedIntoDocument): (WebCore::HTMLSourceElement::src): (WebCore::HTMLSourceElement::setSrc): (WebCore::HTMLSourceElement::media): (WebCore::HTMLSourceElement::setMedia): (WebCore::HTMLSourceElement::type): (WebCore::HTMLSourceElement::setType):
  • html/HTMLSourceElement.h: Added. (WebCore::HTMLSourceElement::endTagRequirement): (WebCore::HTMLSourceElement::tagPriority):
  • html/HTMLSourceElement.idl: Added.
  • html/HTMLTagNames.in:
  • html/HTMLVideoElement.cpp: Added. (WebCore::HTMLVideoElement::HTMLVideoElement): (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight):
  • html/HTMLVideoElement.h: Added. (WebCore::HTMLVideoElement::tagPriority): (WebCore::HTMLVideoElement::isVideo):
  • html/HTMLVideoElement.idl: Added.
  • html/MediaError.h: Added. (WebCore::MediaError::): (WebCore::MediaError::MediaError): (WebCore::MediaError::code):
  • html/MediaError.idl: Added.
  • html/TimeRanges.cpp: Added. (TimeRanges::TimeRanges): (TimeRanges::start): (TimeRanges::end): (TimeRanges::add): (TimeRanges::contain):
  • html/TimeRanges.h: Added. (WebCore::TimeRanges::TimeRanges): (WebCore::TimeRanges::length): (WebCore::TimeRanges::Range::Range):
  • html/TimeRanges.idl: Added.
  • page/DOMWindow.idl:
  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMovieMIMETypes): (WebCore::initialiseMIMETypeRegistry): (WebCore::MIMETypeRegistry::isSupportedMovieMIMEType): (WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):
  • platform/MIMETypeRegistry.h:
  • platform/graphics/Movie.cpp: Added. (WebCore::Movie::Movie): (WebCore::Movie::~Movie): (WebCore::Movie::load): (WebCore::Movie::cancelLoad): (WebCore::Movie::play): (WebCore::Movie::pause): (WebCore::Movie::duration): (WebCore::Movie::currentTime): (WebCore::Movie::seek): (WebCore::Movie::paused): (WebCore::Movie::seeking): (WebCore::Movie::naturalSize): (WebCore::Movie::hasVideo): (WebCore::Movie::networkState): (WebCore::Movie::readyState): (WebCore::Movie::volume): (WebCore::Movie::setVolume): (WebCore::Movie::rate): (WebCore::Movie::setRate): (WebCore::Movie::muted): (WebCore::Movie::setMuted): (WebCore::Movie::dataRate): (WebCore::Movie::setEndTime): (WebCore::Movie::addCuePoint): (WebCore::Movie::removeCuePoint): (WebCore::Movie::clearCuePoints): (WebCore::Movie::maxTimeBuffered): (WebCore::Movie::maxTimeSeekable): (WebCore::Movie::bytesLoaded): (WebCore::Movie::totalBytesKnown): (WebCore::Movie::totalBytes): (WebCore::Movie::setRect): (WebCore::Movie::visible): (WebCore::Movie::setVisible): (WebCore::Movie::paint): (WebCore::Movie::getSupportedTypes): (WebCore::Movie::networkStateChanged): (WebCore::Movie::readyStateChanged): (WebCore::Movie::volumeChanged): (WebCore::Movie::didEnd): (WebCore::Movie::cuePointReached):
  • platform/graphics/Movie.h: Added. (WebCore::MovieClient::~MovieClient): (WebCore::MovieClient::movieNetworkStateChanged): (WebCore::MovieClient::movieReadyStateChanged): (WebCore::MovieClient::movieVolumeChanged): (WebCore::MovieClient::movieDidEnd): (WebCore::MovieClient::movieCuePointReached): (WebCore::Movie::parentWidget): (WebCore::Movie::setParentWidget): (WebCore::Movie::rect): (WebCore::Movie::):
  • platform/graphics/mac/MoviePrivateQTKit.h: Added.
  • platform/graphics/mac/MoviePrivateQTKit.mm: Added. (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::createQTMovie): (WebCore::MoviePrivate::createQTMovieView): (WebCore::MoviePrivate::createQTTime): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::duration): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::setEndTime): (WebCore::MoviePrivate::addCuePoint): (WebCore::MoviePrivate::removeCuePoint): (WebCore::MoviePrivate::clearCuePoints): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seekTimerFired): (WebCore::MoviePrivate::cuePointTimerFired): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::hasVideo): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::setRate): (WebCore::MoviePrivate::dataRate): (WebCore::MoviePrivate::networkState): (WebCore::MoviePrivate::readyState): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::maxTimeSeekable): (WebCore::MoviePrivate::maxTimeLoaded): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::cancelLoad): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::loadStateChanged): (WebCore::MoviePrivate::rateChanged): (WebCore::MoviePrivate::sizeChanged): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::volumeChanged): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::setRect): (WebCore::MoviePrivate::setVisible): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::getSupportedTypes): (-[WebCoreMovieObserver loadStateChanged:]): (-[WebCoreMovieObserver rateChanged:]): (-[WebCoreMovieObserver sizeChanged:]): (-[WebCoreMovieObserver timeChanged:]): (-[WebCoreMovieObserver volumeChanged:]): (-[WebCoreMovieObserver didEnd:]): (-[WebCoreMovieObserver setCallback:WebCore::]):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::collectLayers):
  • rendering/RenderVideo.cpp: Added. (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::~RenderVideo): (WebCore::RenderVideo::movie): (WebCore::RenderVideo::videoSizeChanged): (WebCore::RenderVideo::paint): (WebCore::RenderVideo::layout): (WebCore::RenderVideo::updateFromElement): (WebCore::RenderVideo::updateMovie): (WebCore::RenderVideo::isWidthSpecified): (WebCore::RenderVideo::isHeightSpecified): (WebCore::RenderVideo::calcReplacedWidth): (WebCore::RenderVideo::calcReplacedHeight): (WebCore::RenderVideo::calcAspectRatioWidth): (WebCore::RenderVideo::calcAspectRatioHeight): (WebCore::RenderVideo::calcPrefWidths):
  • rendering/RenderVideo.h: Added. (WebCore::RenderVideo::renderName):
6:02 PM Changeset in webkit [27276] by weinig
  • 105 edits in trunk/WebCore

Reviewed by Adam Roben.

Add Interface and Class UUIDs to the IDLs in preparation of adding
autogeneration of the COM DOM bindings.

  • bindings/scripts/IDLParser.pm: Relax parsing rules to allow newlines as whitespace.
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSUnknownRule.idl:
  • css/CSSValue.idl:
  • css/CSSValueList.idl:
  • css/Counter.idl:
  • css/MediaList.idl:
  • css/RGBColor.idl:
  • css/Rect.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • dom/Attr.idl:
  • dom/CDATASection.idl:
  • dom/CharacterData.idl:
  • dom/Comment.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/EntityReference.idl:
  • dom/Event.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Text.idl:
  • html/CanvasGradient.idl:
  • html/CanvasPattern.idl:
  • html/CanvasRenderingContext2D.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl:
6:01 PM Changeset in webkit [27275] by kmccullo
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Adam and Geoff.

  • Added a new cast so all the casts are in the same place.
  • API/APICast.h: (toGlobalRef):

win:

Reviewed by Adam and Geoff.

  • Added the globalContext method so Drosera can ask a WebFrame for its context.
  • Interfaces/IWebFrame.idl:
  • WebFrame.cpp:
  • WebFrame.h:
5:58 PM Changeset in webkit [27274] by adele
  • 2 edits in trunk/WebCore

RS by Darin.

  • page/AnimationController.cpp: (WebCore::blendFunc): Use lround instead of round.
5:48 PM Changeset in webkit [27273] by antti
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.


Build media support by default on OSX only.

  • Scripts/build-webkit:
5:45 PM Changeset in webkit [27272] by antti
  • 2 edits in trunk/WebKit

Reviewed by Maciej.


Some SPIs for media support.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
4:19 PM Changeset in webkit [27271] by timothy@apple.com
  • 1 edit in trunk/WebKit/StringsNotToBeLocalized.txt

Update WebKit/StringsNotToBeLocalized.txt.

4:15 PM Changeset in webkit [27270] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Fixed <rdar://problem/5567504> shift/reduce conflict introduced in r24457


JS tests, including

ecma_2/Statements/dowhile-001.js
ecma_2/Statements/dowhile-002.js
ecma_2/Statements/dowhile-003.js
ecma_2/Statements/dowhile-004.js
ecma_2/Statements/dowhile-005.js
ecma_2/Statements/dowhile-006.js
ecma_2/Statements/dowhile-007.js
js1_2/statements/do_while.js

and layout tests, including

do-while-expression-value.html
do-while-semicolon.html
do-while-without-semicolon.html


pass.


  • kjs/grammar.y: Use the explicit "error" production, as we do with other automatic semicolon insertions, to disambiguate "do { } while();" from "do { } while()" followed by ";" (the empty statement).
4:05 PM Changeset in webkit [27269] by kmccullo
  • 1 edit in trunk/WebKitTools/ChangeLog
  • Made Adam the reviewer for a previous checkin. Not sure how it didn't get caught by the pre-commit hooks.
3:54 PM Changeset in webkit [27268] by kmccullo
  • 8 edits
    1 delete in trunk/WebKitTools

Reviewed by Adam.

  • This is a collection of relatively unrelated changes and cleanups to Drosera to prepare it for interacting with WebKit. A lot of these changes are just correcting mistakes, for example removing included headers that are no longer needed.
  • Drosera/DebuggerDocument.h: Added accessor for the ServerConnection this will be needed by the DebuggerClient. (DebuggerDocument::server):
  • Drosera/win/BaseDelegate.h: Removed unnecessary include.
  • Drosera/win/DebuggerClient.cpp: (DebuggerClient::didFinishLoadForFrame): Finished implementing. (DebuggerClient::didReceiveTitle): Added comment about its purpose. (DebuggerClient::createWebViewWithRequest): Added comment about its purpose.
  • Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward declarations. (DebuggerClient::webViewLoaded): Moved.
  • Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions file, since this was the only place it was used. (cfStringToBSTR):
  • Drosera/win/Drosera.h: Cleaned up the includes.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
  • Drosera/win/HelperFunctions.h: Removed.
3:52 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
3:46 PM JavaScript performance improvement ideas edited by ggaren@apple.com
(diff)
3:12 PM Changeset in webkit [27267] by kmccullo
  • 3 edits in trunk/WebKitTools

Reviewed by NOBODY (OOPS!).

  • Small cleanup in the ServerConnection class.
  • Drosera/win/ServerConnection.cpp: Added comments, moved some functions and added an include. (ServerConnection::currentFrame): (ServerConnection::getCallerFrame):
  • Drosera/win/ServerConnection.h: Added comments, moved some functions, made a pointer into a COMPtr, and cleaned up the includes.
2:26 PM Changeset in webkit [27266] by timothy@apple.com
  • 17 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • Allow showing and closing the inspector programatically.
  • Add showConsole() and showTimeline() methods.
  • WebCore.base.exp: Add exports for WebKit.
  • page/InspectorController.cpp: (WebCore::callSimpleFunction): Renamed from callClearFunction(). (WebCore::unloading): Renamed to close(). (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspect): Moved showing code to show(). (WebCore::InspectorController::setWindowVisible): Show the timeline or console if needed. (WebCore::InspectorController::show): Code factored out of inspect(). (WebCore::InspectorController::showConsole): Call show() and the JS showConsole(). (WebCore::InspectorController::showTimeline): Call show() and the JS showTimeline(). (WebCore::InspectorController::close): (WebCore::InspectorController::clearScriptResources): Call the new callSimpleFunction. (WebCore::InspectorController::clearDatabaseScriptResources): Ditto. (WebCore::InspectorController::clearScriptConsoleMessages): Ditto. (WebCore::InspectorController::clearNetworkTimeline): Ditto.
  • page/InspectorController.h: Add and rename methods.
  • page/inspector/inspector.js: Add showConsole() and showTimeline().

WebKit:

Reviewed by John Sullivan.

Various semi-related changes:

  • A WebView can now be asked for it's WebInspector. There is one WebInspector per WebView.
  • Refactor the WebInspector class and move obsolete methods to a special category.
  • Add new WebInspector methods to show, hide and show the console/timeline panels.
  • Add an isDisabled method to WebCache.
  • Allow WebLocalizableStrings.h to be used in C files.
  • Misc/WebCache.h: Add isDisabled.
  • Misc/WebCache.mm: (+[WebCache isDisabled]): New method.
  • Misc/WebLocalizableStrings.h: Changes to allow use in plain C files.
  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): Call super if already visible so the window will be ordered front. (-[WebInspectorWindowController showWebInspector:]): Method used by menu items, so they are enabled and work when the Inspector window is key. (-[WebInspectorWindowController showErrorConsole:]): Ditto. (-[WebInspectorWindowController showNetworkTimeline:]): Ditto.
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Release the WebInspector. (-[WebView _close]): Call webViewClosed on the WebInspector. (-[WebView inspector]): Create a WebInspector if needed and return it.
  • WebView/WebViewPrivate.h: Add the inspector method.

WebKitTools:

Reviewed by John Sullivan.


  • Place the Localizable.strings file in mac or win directories if that location exists.
  • Also look for UI_STRING in .c files.
  • Scripts/extract-localizable-strings:
2:18 PM Changeset in webkit [27265] by adele
  • 2 edits in trunk/WebCore

Reviewed by Sam.

Build fix.

  • page/AnimationController.cpp: (WebCore::blendFunc):
2:05 PM Changeset in webkit [27264] by adele
  • 21 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for ​http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields

Test: manual-tests/password-caps-lock.html

  • WebCore.base.exp: Added symbol for capsLockStateMayHaveChanged.
  • page/Frame.cpp: (WebCore::Frame::setIsActive): Calls capsLockStateMayHaveChanged.
  • page/EventHandler.cpp: (WebCore::EventHandler::capsLockStateMayHaveChanged): Added. Tells the focused node's renderer that the capsLockStateMayHaveChanged.
  • page/EventHandler.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Added.
  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Added.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::paint): Added. If m_shouldDrawCapsLockIndicator is true, paints the caps lock indicator after the background. (WebCore::RenderTextControl::forwardEvent): When the control gets and loses focus, update the caps lock state. (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Added. Updates m_shouldDrawCapsLockIndicator, which is true if the field is a password field, and the frame is active, and the element is focused, and the caps lock is on. Causes a repaint when m_shouldDrawCapsLockIndicator changes state.
  • rendering/RenderTextControl.h: Added m_shouldDrawCapsLockIndicator.
  • rendering/RenderObject.h: (WebCore::RenderObject::capsLockStateMayHaveChanged): Added.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintCapsLockIndicator): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCapsLockIndicator): Added. Calls wkDrawCapsLockIndicator.
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintCapsLockIndicator): Added. Calls paintThemePart for the CapsLockPart.
  • rendering/RenderThemeSafari.h:

WebKit:

Reviewed by Darin.

WebKit part of fix for ​http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields

  • WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field. (+[WebHTMLView _postFlagsChangedEvent:]): Added a comment with a Radar number for why this isn't just in flagsChanged. (-[WebHTMLView scrollWheel:]): Instead of calling the next responder explicitly, we can just call super, which will take care of this.

win:

Reviewed by Darin.

WebKitWin part of fix for ​http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5110427> REGRESSION: Caps lock icon should show in password fields

  • WebView.cpp: (WebView::keyDown): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field.
1:20 PM Changeset in webkit [27263] by hyatt
  • 16 edits in trunk/WebCore

Land support for implicit animation in CSS.


Reviewed by mitz, darin

  • css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseTransitionTimingFunction): (WebCore::CSSParser::parseTransitionProperty):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapTransitionDuration): (WebCore::CSSStyleSelector::mapTransitionRepeatCount): (WebCore::CSSStyleSelector::mapTransitionTimingFunction): (WebCore::CSSStyleSelector::mapTransitionProperty):
  • css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::x1): (WebCore::CSSTimingFunctionValue::y1): (WebCore::CSSTimingFunctionValue::x2): (WebCore::CSSTimingFunctionValue::y2):
  • dom/Element.cpp: (WebCore::Element::styleForRenderer): (WebCore::Element::createRenderer):
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::setRenderStyle):
  • page/AnimationController.cpp: (WebCore::CurveData::CurveData): (WebCore::CurveData::sampleCurveX): (WebCore::CurveData::sampleCurveY): (WebCore::CurveData::sampleCurveDerivativeX): (WebCore::CurveData::solveCurveX): (WebCore::solveEpsilon): (WebCore::solveCubicBezierFunction): (WebCore::ImplicitAnimation::finished): (WebCore::CompositeImplicitAnimation::~CompositeImplicitAnimation): (WebCore::CompositeImplicitAnimation::hasAnimationForProperty): (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::reset): (WebCore::ImplicitAnimation::progress): (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate): (WebCore::CompositeImplicitAnimation::animate): (WebCore::CompositeImplicitAnimation::animating): (WebCore::CompositeImplicitAnimation::reset): (WebCore::AnimationControllerPrivate::hasImplicitAnimations): (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::~AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::get): (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateTimer): (WebCore::AnimationControllerPrivate::timerFired): (WebCore:::m_data): (WebCore::AnimationController::~AnimationController): (WebCore::AnimationController::cancelImplicitAnimations): (WebCore::AnimationController::updateImplicitAnimations): (WebCore::AnimationController::suspendAnimations): (WebCore::AnimationController::resumeAnimations):
  • page/AnimationController.h:
  • page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setAnimatableStyle): (WebCore::RenderObject::destroy):
  • rendering/RenderObject.h:
  • rendering/RenderStyle.h: (WebCore::TimingFunction::TimingFunction): (WebCore::TimingFunction::operator==): (WebCore::TimingFunction::x1): (WebCore::TimingFunction::y1): (WebCore::TimingFunction::x2): (WebCore::TimingFunction::y2): (WebCore::TimingFunction::type): (WebCore::Transition::transitionProperty): (WebCore::Transition::setTransitionProperty): (WebCore::RenderStyle::initialTransitionProperty):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
11:41 AM Changeset in webkit [27262] by kmccullo
  • 9 edits in trunk/WebKitTools

Reviewed by Adam.

  • Set the eol-style to native and made all the line endings the same so that I avoid messy diffs that show eol changes.
  • Drosera/win/ServerConnection.cpp: (ServerConnection::didParseSource): (ServerConnection::didEnterCallFrame): (ServerConnection::willExecuteStatement): (ServerConnection::willLeaveCallFrame): (ServerConnection::exceptionWasRaised):
11:15 AM Changeset in webkit [27261] by kmccullo
  • 5 edits in trunk/WebKitTools

Reviewed by Adam.

  • Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the functionality that could not have existed previously without the new interfaces. (JSValueRefCreateWithBSTR): Added a helper function to easily convert from a BSTR to a JSValueRef. (DebuggerDocument::platformEvaluateScript): Implemented. (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): Implemented. (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
  • Drosera/win/HelperFunctions.h: Cleaned up some comments.
  • Drosera/win/ServerConnection.cpp: Added a helper function. (ServerConnection::getCallerFrame):
  • Drosera/win/ServerConnection.h: Added a helper function.
10:49 AM Changeset in webkit [27260] by aroben
  • 2 edits in trunk/LayoutTests

Add another failing test to the Windows Skipped file

  • platform/win/Skipped:
10:39 AM Changeset in webkit [27259] by weinig
  • 5 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Update test to not intermittently fail.

  • http/tests/security/host-compare-case-insensitive-expected.txt:
  • http/tests/security/host-compare-case-insensitive.html:
  • http/tests/security/resources/cross-frame-iframe.html:
  • http/tests/security/resources/localhost-accesssor.html:
10:29 AM Changeset in webkit [27258] by bdakin
  • 2 edits
    2 adds in trunk/LayoutTests

Rubber stamped by Geoff.

This test needed updated results from my patch last night. It has
<parsererror> tags, which are now block instead on inline.

  • platform/mac/fast/frames/onlyCommentInIFrame-expected.checksum: Replaced.
  • platform/mac/fast/frames/onlyCommentInIFrame-expected.png: Replaced.
  • platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
8:16 AM Changeset in webkit [27257] by bdakin
  • 2 edits
    1 add in trunk/LayoutTests

Rubber stamped by Geoff.

Fixing two layout test mixups from my patch last night.

I added this test, but checked in old results:

  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:


I removed the results of this test by accident:

  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt: Added.

Oct 29, 2007:

11:29 PM Changeset in webkit [27256] by mjs
  • 1 edit
    1 add in trunk/SunSpider

Reviewed by Eric.


  • Added list of ECMAScript3 features that SunSpider does not cover currently.
  • UNCOVERED: Added.
10:36 PM Changeset in webkit [27255] by oliver
  • 5 edits in trunk/JavaScriptCore

Debranching remaining assignment nodes, and miscellaneous cleanup

Reviewed by Maciej.

Split read-modify code paths out of AssignBracketNode and AssignDotNode
Removed now unnecessary check for write-only assignment in ReadModifyLocalVarNode
and ReadModifyResolveNode evaluate methods

Leads to a 1% gain in SunSpider.

10:27 PM Changeset in webkit [27254] by bdakin
  • 11 edits
    30 adds
    1 delete in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5399614> anchor tag is not rendered without
text content, works in Firefox with CSS background-image (13237)

This patch allows empty inlines that have box decorations or width
from border/padding/margin to have line boxes.

  • rendering/bidi.cpp: (WebCore::inlineFlowAllowsLineBox): Convenience function that defines when we allow an inline flow to have a line box. (WebCore::requiresLineBox): Call inlineFlowAllowsLineBox. (WebCore::shouldSkipWhitespaceAfterStartObject): New function to merge some shared code between list markers and empty inline flows that fall at the beginning of a line. (WebCore::RenderBlock::findNextLineBreak): Make flows more like list markers.

One interesting side effect of this bug appeared in our xhtml/svg
tests that generate parser error tags. The tag we generate was
actually an empty inline with box decorations. This patch causes
those inlines to draw now, and the parser errors looked strange. So
I changed it so that the parsererror tag is display:block. This
matches Firefox, and I think was the original intent of the tag
since that causes its red background and border to show up.

  • dom/XMLTokenizer.cpp: (WebCore::createXHTMLParserErrorHeader):

LayoutTests:

Reviewed by Hyatt.

New tests and new results for old tests for <rdar://problem/
5399614> anchor tag is not rendered without text content, works in
Firefox with CSS background-image (13237)

New tests:

  • fast/inline/drawStyledEmptyInlines.html: Added.
  • fast/inline/drawStyledEmptyInlinesWithWS.html: Added.
  • fast/inline/emptyInlinesWithinLists.html: Added.
  • fast/inline/styledEmptyInlinesWithBRs.html: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.png: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum: Added.
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.png: Added.
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt: Added.
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum: Added.
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png: Added.
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.txt: Added.


New results for tests with <paserererrors> since <parsererror> is
now block.

  • platform/mac/fast/invalid/junk-data-expected.checksum: Replaced.
  • platform/mac/fast/invalid/junk-data-expected.png: Replaced.
  • platform/mac/fast/invalid/junk-data-expected.txt:
  • platform/mac/fast/invalid/missing-end-tag-expected.checksum: Replaced.
  • platform/mac/fast/invalid/missing-end-tag-expected.png: Replaced.
  • platform/mac/fast/invalid/missing-end-tag-expected.txt:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum: Replaced.
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.png: Replaced.
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum: Replaced.
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png: Replaced.
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt: Removed.
  • platform/mac/svg/custom/junk-data-expected.checksum: Replaced.
  • platform/mac/svg/custom/junk-data-expected.png: Replaced.
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.checksum: Replaced.
  • platform/mac/svg/custom/missing-xlink-expected.png: Replaced.
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/hixie/error/012-expected.checksum: Replaced.
  • platform/mac/svg/hixie/error/012-expected.png: Replaced.
  • platform/mac/svg/hixie/error/012-expected.txt:
8:48 PM Changeset in webkit [27253] by mitz
  • 3 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix crashing tests fast/frames/inline-object-inside-frameset.html and fast/forms/form-hides-table.html
  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
8:14 PM Changeset in webkit [27252] by oliver
  • 6 edits in trunk/JavaScriptCore

Debranching various Node::evaluate implementations

Reviewed by Maciej.

Split the read-modify-write assignment cases out of AssignResolveNode and into ReadModifyResolveNode
Split the increment and decrement cases for Prefix- and Postfix- ResolveNode, BracketNode, and DotNode

Gains 1.6% on SunSpider

7:56 PM Changeset in webkit [27251] by mitz
  • 4 edits
    5 adds in trunk

WebCore:

Reviewed by Adam Roben.

Test: fast/backgrounds/size/zero.html

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern): Added an ASSERT and an early return to guard against singular pattern transforms.
  • rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): Changed to ensure a minimum tile size of 1x1.

LayoutTests:

Reviewed by Adam Roben.

  • fast/backgrounds/size/zero.html: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.png: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.txt: Added.
7:44 PM Changeset in webkit [27250] by kmccullo
  • 8 edits
    3 adds in trunk/WebKit/win

Reviewed by Adam and Maciej.

  • Added the IWebScriptScope interface which is used by Drosera to get information and run contextually significant code with respect to the current JS stack frame.
  • Interfaces/IWebScriptCallFrame.idl: Line endings changed, not sure why but the real changes were to change the return type of scopeChain() and the return type and name of evaluateWebScript() to stringByEvaluatingJavaScriptFromString().
  • Interfaces/IWebScriptScope.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added the new interface.
  • WebKit.vcproj/WebKit.vcproj: Added the files for the new class.
  • WebKit.vcproj/WebKitGUID.vcproj: Added the new interfaces.
  • WebScriptCallFrame.cpp: Changed the return type to E_NOTIMPL and asserted so it would be obvious if I accidentally try to use one of these functions before it's implemented. (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
  • WebScriptCallFrame.h: Changed the return types mentioned above.
  • WebScriptDebugServer.cpp: Also changed the return type to E_NOTIMPL. (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused):
  • WebScriptScope.cpp: Added. (WebScriptScope::WebScriptScope): (WebScriptScope::~WebScriptScope): (WebScriptScope::QueryInterface): (WebScriptScope::AddRef): (WebScriptScope::Release): (WebScriptScope::getVariableNames): (WebScriptScope::getValueForVariable):
  • WebScriptScope.h: Added.
7:18 PM Changeset in webkit [27249] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.


  • Include Vector.h in a way that actually works.
  • kjs/LocalStorage.h:
7:12 PM Changeset in webkit [27248] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.


  • Install LocalStorage.h as a private header.
6:55 PM Changeset in webkit [27247] by mjs
  • 2 edits in trunk/SunSpider

Reviewed by Oliver.


  • Give better error messages when sunspider-compare-results fails
  • sunspider-compare-results:
6:54 PM Changeset in webkit [27246] by alp
  • 2 edits in trunk/WebKit/gtk

Reviewed by Maciej.

Do not allow control to reach end of non-void functions

6:46 PM Changeset in webkit [27245] by alp
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog entry for r27244

6:44 PM Changeset in webkit [27244] by alp
  • 4 edits
    3 adds in trunk/WebCore

Reviewed by Maciej.

Add GTK+ convenience conversions for various primitives

6:37 PM Changeset in webkit [27243] by mjs
  • 3 edits in trunk/SunSpider

Reviewed by Darin.


  • fix Date tests to work in command-line SpiderMonkey
  • tests/date-format-tofte.js:
  • tests/date-format-xparb.js:
6:34 PM Changeset in webkit [27242] by mjs
  • 5 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.


  • Define good VectorTraits for LocalStorage entry for 0.5% speed improvement on SunSpider.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/LocalStorage.h: Added. (KJS::LocalStorageEntry::LocalStorageEntry): (WTF::):
  • kjs/function.h:
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::processDeclarationsForFunctionCode):
6:31 PM Changeset in webkit [27241] by kmccullo
  • 1 edit in trunk/WebKitTools/ChangeLog

updated reviewers for my previous changelog.

6:30 PM Changeset in webkit [27240] by kmccullo
  • 6 edits in trunk/WebKitTools

Reviewed by Maciej and Adam.

  • Minor mac-side improvements including moving a function to a more appropriate location, fixing a warning, and correctly checking exceptions.
  • Drosera/DebuggerDocument.cpp: Corrected the exception checking. (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::callFunctionOnObject):
  • Drosera/mac/DebuggerClient.mm: Fixes a warning.
  • Drosera/mac/DebuggerDocumentPlatform.mm: Moved webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform because it doesn't require the ServerConnection at all. (NSStringCreateWithJSStringRef): Made an argument const. (JSValueRefCreateWithNSString): Made an argument const. (+[WebScriptObject webScriptAttributeKeysForScriptObject:]): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
  • Drosera/mac/ServerConnection.h: Moved aforementioned function.
  • Drosera/mac/ServerConnection.mm: Ditto. (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
5:49 PM Changeset in webkit [27239] by weinig
  • 17 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Simplify the dataURL xxs tests.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url.html:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html:
5:34 PM Changeset in webkit [27238] by weinig
  • 3 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Add a globalFlag property to the LayoutTestController to allow cross-domain indications.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (getGlobalFlagCallback): (setGlobalFlagCallback): (LayoutTestController::getJSClass): (LayoutTestController::staticValues):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::globalFlag): (LayoutTestController::setGlobalFlag):
5:28 PM Changeset in webkit [27237] by darin
  • 4 edits in trunk

SunSpider:

Reviewed by Maciej.

  • sunspider: Added --shark20 option, to run Shark at its highest sample resolution instead of its default.

WebKitTools:

Reviewed by Maciej.

  • Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample resolution instead of its default.
4:13 PM Changeset in webkit [27236] by honeycutt
  • 4 edits in trunk/WebCore

2007-10-29 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

Speculative fix for <rdar://5538489> Safari 3.0.4 seed hangs at
​http://tgmonline.futuregamer.it/ (works fine on Safari 2.0.4 and Safari
Beta for Mac)


I cannot reproduce this hang, but it is likely due to our not limiting
WM_USER+1 messages or InvalidateRect calls for a plugin with initially-
unknown MIME type. The embed tag on the page is missing a type
attribute, so as fallback, we choose to load the Flash plugin based on
the file extension of "swf." However, we do not record this determined
MIME type, and so our quirks cannot be established.


Changed findPlugin() so that, if it fails to find a plugin for the
given MIME type, it will lookup the MIME type for the file extension -
overwriting its passed MIME type parameter - and search for a plugin
for that MIME type.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::pluginForMIMEType): Added an early return if the MIME type is empty (WebCore::PluginDatabaseWin::MIMETypeForExtension): Added to replace pluginForExtension. Returns a String with the MIME type for the file extension. Also, changed to use case-insensitive compares (WebCore::PluginDatabaseWin::findPlugin): If we fail to find a plugin for the given extension, overwrite the incoming MIME type parameter with the MIME type for the file extension, and search for a plugin for that MIME type. Also, changed the way that the extension is determined (WebCore::PluginDatabaseWin::createPluginView): Pass a mutable String to findPlugin() so that it can be updated if necessary
  • plugins/win/PluginDatabaseWin.h: Changed findPlugin() to take a non- const String, removed definition of pluginForExtension, added definition for MIMETypeForExtension
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::fetchInfo): Store the MIME type in lowercase for easier compares
3:55 PM Changeset in webkit [27235] by andrew
  • 2 edits in trunk/WebCore

Not reviewed - build fix

Fix Mac Build.


WebKit/WebCore/xml/XSLTProcessor.cpp:79: warning: 'level' may be used uninitialized
in this function

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc):
3:28 PM Changeset in webkit [27234] by alp
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=15725
[GTK] WebCore.pro header dependencies are incorrect

Fix header dependencies in the build system

INCLUDEPATH and DEPENDPATH are now up to date.

3:16 PM Changeset in webkit [27233] by mrowe@apple.com
  • 180 edits
    62 adds
    99 deletes in trunk/WebKitSite

Upgrade WordPress.

2:46 PM Changeset in webkit [27232] by bdash
  • 2 edits
    6 adds in trunk/WebKitSite

Files that have been added or modified on the server without making it in to SVN.

12:17 PM Changeset in webkit [27231] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Some small tweaks that I notice while reviewing Oliver's last patch.


Includes removal of an unnecessary KJS_CHECKEXCEPTIONVALUE.


No change in SunSpider because SunSpider doesn't take the code path that
would execute the unnecessary KJS_CHECKEXCEPTIONVALUE much.

  • kjs/nodes.cpp: (KJS::LocalVarPostfixNode::evaluate): (KJS::TypeOfResolveNode::optimizeVariableAccess): (KJS::LocalVarTypeOfNode::evaluate): (KJS::PrefixResolveNode::optimizeVariableAccess): (KJS::LocalVarPrefixNode::evaluate): (KJS::AssignResolveNode::optimizeVariableAccess): (KJS::LocalVarAssignNode::evaluate):
  • kjs/nodes.h: (KJS::LocalVarTypeOfNode::): (KJS::PrefixResolveNode::): (KJS::LocalVarPrefixNode::): (KJS::AssignResolveNode::): (KJS::LocalVarAssignNode::):
11:57 AM Changeset in webkit [27230] by timothy@apple.com
  • 1 edit in trunk/WebCore/css/CSSParser.cpp

A better build fix.

11:50 AM Changeset in webkit [27229] by bdakin
  • 3 edits in trunk/WebCore

Build fix.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapTransitionTimingFunction):
11:22 AM Changeset in webkit [27228] by hyatt
  • 21 edits
    4 adds in trunk/WebCore

Land the back end for CSS animated property transitions. I am landing this in stages, so the AnimationController
class is deliberately left empty.

Reviewed by darin/aroben

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/CSSTimingFunctionValue.cpp: Added. (WebCore::CSSTimingFunctionValue::cssText):
  • css/CSSTimingFunctionValue.h: Added. (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::firstPoint): (WebCore::CSSTimingFunctionValue::secondPoint):
  • css/CSSValueKeywords.in:
  • history/CachedPage.cpp: (WebCore::CachedPage::restore):
  • page/AnimationController.cpp: Added. (WebCore::AnimationController::AnimationController): (WebCore::AnimationController::~AnimationController): (WebCore::AnimationController::cancelTransitions): (WebCore::AnimationController::updateTransitions): (WebCore::AnimationController::suspendAnimations): (WebCore::AnimationController::resumeAnimations):
  • page/AnimationController.h: Added.
  • page/Frame.cpp: (WebCore::Frame::animationController): (WebCore::Frame::clearTimers):
  • page/Frame.h:
  • page/FramePrivate.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::animationController):
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp: (WebCore::Transition::Transition): (WebCore::Transition::~Transition): (WebCore::Transition::operator=): (WebCore::Transition::operator==): (WebCore::Transition::fillUnsetProperties): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareNonInheritedData::transitionDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::adjustTransitions): (WebCore::RenderStyle::accessTransitions):
  • rendering/RenderStyle.h: (WebCore::BackgroundLayer::next): (WebCore::): (WebCore::TimingFunction::TimingFunction): (WebCore::TimingFunction::operator==): (WebCore::Transition::next): (WebCore::Transition::isTransitionDurationSet): (WebCore::Transition::isTransitionRepeatCountSet): (WebCore::Transition::isTransitionTimingFunctionSet): (WebCore::Transition::isTransitionPropertySet): (WebCore::Transition::isEmpty): (WebCore::Transition::clearTransitionDuration): (WebCore::Transition::clearTransitionRepeatCount): (WebCore::Transition::clearTransitionTimingFunction): (WebCore::Transition::clearTransitionProperty): (WebCore::Transition::transitionDuration): (WebCore::Transition::transitionRepeatCount): (WebCore::Transition::transitionTimingFunction): (WebCore::Transition::transitionProperty): (WebCore::Transition::setTransitionDuration): (WebCore::Transition::setTransitionRepeatCount): (WebCore::Transition::setTransitionTimingFunction): (WebCore::Transition::setTransitionProperty): (WebCore::Transition::setNext): (WebCore::Transition::operator!=): (WebCore::RenderStyle::transitions): (WebCore::RenderStyle::clearTransitions): (WebCore::RenderStyle::inheritTransitions): (WebCore::RenderStyle::initialTransitionDuration): (WebCore::RenderStyle::initialTransitionRepeatCount): (WebCore::RenderStyle::initialTransitionTimingFunction): (WebCore::RenderStyle::initialTransitionProperty):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
10:02 AM Changeset in webkit [27227] by ap
  • 5 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=6040
XSLT does not report errors to the user

Made parseErrorFunc a static member function of XSLTProcessor to be reusable from XSLStylesheet.
Switched to xmlSetStructuredErrorFunc to get an error structure instead of pre-formatted console
output. Got rid of DeprecatedString in XSLTProcessor.

  • dom/Document.cpp: (WebCore::Document::applyXSLTransform):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc): (WebCore::docLoaderFunc): (WebCore::setXSLTLoadCallBack): (WebCore::writeToString): (WebCore::saveResultToString): (WebCore::transformTextStringToXHTMLDocumentString): (WebCore::xsltParamArrayFromParameterMap): (WebCore::freeXsltParamArray): (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::createFragmentFromSource): (WebCore::xsltStylesheetPointer): (WebCore::xmlDocPtrFromNode): (WebCore::resultMIMEType): (WebCore::XSLTProcessor::transformToString): (WebCore::XSLTProcessor::transformToDocument): (WebCore::XSLTProcessor::transformToFragment):
  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::setXSLStylesheet): (WebCore::XSLTProcessor::importStylesheet): (WebCore::XSLTProcessor::xslStylesheet):
9:34 AM Changeset in webkit [27226] by ddkilzer
  • 2 edits in trunk/WebKitTools

Fixed showStatus() to print status for successfully resolved conflicts when using git.

Reviewed by Mark Rowe.

Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
was successfully resolved, but this would not show any status because the change had
already been cached in the index using "git add". The solution is to add an optional
second argument to showStatus() which adds the "--cached" switch to the command.

  • Scripts/resolve-ChangeLogs: (showStatus):
9:28 AM Changeset in webkit [27225] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=10030
Star Alliance site is opened without the main frame

  • fast/frames/location-change-expected.txt: Added.
  • fast/frames/location-change.html: Added.
  • fast/frames/resources/location-change-frame-1.html: Added.
  • fast/frames/resources/location-change-frame-2.html: Added.
9:02 AM Changeset in webkit [27224] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/5424455> REGRESSION (r21168-r21193, Tiger only): Safari scrollbar is clipped at top when loading particular RSS page

Test: fast/repaint/layout-state-only-posiitoned.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutOnlyPositionedObjects): Pop layout state before updating scroll info, which possibly repaints us.

LayoutTests:

Reviewed by John Sullivan,

  • repaint test for <rdar://problem/5424455> REGRESSION (r21168-r21193, Tiger only): Safari scrollbar is clipped at top when loading particular RSS page
  • fast/repaint/layout-state-only-posiitoned.html: Added.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Added.
3:31 AM Changeset in webkit [27223] by ddkilzer
  • 3 edits
    5 adds in trunk

WebCore:

REGRESSION (r17701): Favicons should be viewable as image documents
<​http://bugs.webkit.org/show_bug.cgi?id=15640>

Reviewed by Darin.

On Tiger and Leopard, the image/x-icon MIME type is not returned from
CGImageSourceCopyTypeIdentifiers(), so opening a URL to a favicon caused
the icon to be downloaded instead being displayed in an image document.

Test: fast/images/favicon-as-image.html

  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes): Manually add image/x-icon to supportedImageMIMETypes and supportedImageResourceMIMETypes. Also fixed comment about the image/bmp MIME type since it applies to both Tiger and Leopard.

LayoutTests:

Test for: REGRESSION (r17701): Favicons should be viewable as image documents
<​http://bugs.webkit.org/show_bug.cgi?id=15640>

Reviewed by Darin.

  • fast/images/favicon-as-image.html: Added.
  • fast/images/resources/favicon.ico: Added.
  • platform/mac/fast/images/favicon-as-image-expected.checksum: Added.
  • platform/mac/fast/images/favicon-as-image-expected.png: Added.
  • platform/mac/fast/images/favicon-as-image-expected.txt: Added.
2:14 AM Changeset in webkit [27222] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-29 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


SunSpider claims this was a 0.7% speedup.

  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): avoid mallocing a jsString in the common case
1:44 AM Changeset in webkit [27221] by mjs
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Mark.


  • re-enable asserts for access to empty or deleted keys
  • wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):

WebCore:

Reviewed by Mark.

  • fixed assertion failures detected by the new assertions
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): Clear _internal before calling [super dealloc] because it's not a pointer and shouldn't be in the normal wrapper cache.
  • dom/Document.cpp: (WebCore::Document::addImageMap): Don't access hashmap if name is null. (WebCore::Document::removeImageMap): ditto
  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Don't claim we have a class when the class attribute is empty.
  • platform/TextCodecICU.cpp: (WebCore::gbkCallbackEscape): Don't look up 0 code points.
1:32 AM Changeset in webkit [27220] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-29 Eric Seidel <​eric@webkit.org>

Build fix only, no review.

  • JavaScriptCore.exp: Export symbol for new StringInstance::getOwnPropertySlot
1:31 AM Changeset in webkit [27219] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-10-29 Mark Rowe <​mrowe@apple.com>

Gtk build fix. Move struct declarations into nodes.h.

  • kjs/grammar.y:
  • kjs/nodes.h:
12:55 AM Changeset in webkit [27218] by eseidel
  • 4 edits in trunk/JavaScriptCore

2007-10-29 Eric Seidel <​eric@webkit.org>

Reviewed by darin.


Give StringInstance a getOwnPropertySlot(ExecState, unsigned, PropertySlot) fastpath, just like Arrays.
Make it a compile time error to use toString(ExecState) on a StringInstance


SunSpider claims this was a 6.6% speedup overall (22% on string-base64)

  • kjs/internal.h: (KJS::StringImp::getLength):
  • kjs/string_object.cpp: (KJS::StringInstance::lengthGetter): (KJS::StringInstance::inlineGetOwnPropertySlot): (KJS::StringInstance::getOwnPropertySlot):
  • kjs/string_object.h:
12:21 AM Changeset in webkit [27217] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10734
Made HTMLOptionElement.index read-only, matching IE and DOM standard.

Test: fast/dom/HTMLOptionElement/set-option-index-text.html

  • html/HTMLOptionElement.idl: Marked index as readonly.
  • html/HTMLOptionElement.cpp:
  • html/HTMLOptionElement.h: Removed setIndex().
12:05 AM Changeset in webkit [27216] by oliver
  • 3 edits in trunk/JavaScriptCore

Added nodes to allow Assignment, TypeOf, and prefix operators to
make use of the new optimised local variable look up.

5% gain on sunspider

Reviewed by Darin

Note: See TracTimeline for information about the timeline view.