Context Navigation

kjs/ExecState.cpp: (KJS::ExecState::updateLocalStorage):
kjs/ExecState.h: (KJS::ExecState::localStorage):
kjs/nodes.cpp: (KJS::LocalVarAccessNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::PostIncLocalVarNode::evaluate): (KJS::PostDecLocalVarNode::evaluate): (KJS::LocalVarTypeOfNode::evaluate): (KJS::PreIncLocalVarNode::evaluate): (KJS::PreDecLocalVarNode::evaluate): (KJS::ReadModifyLocalVarNode::evaluate): (KJS::AssignLocalVarNode::evaluate): (KJS::FunctionBodyNode::processDeclarationsForFunctionCode):

8:51 PM Changeset in webkit [27338] by aroben

3 edits
2 adds in trunk

Fix a crash when parsing a cubic-bezier function

WebCore:

Fix a crash when parsing a cubic-bezier function

Reviewed by Hyatt.

Test: fast/css/parse-timing-function-crash.html

WebCore.vcproj/WebCore.vcproj:
css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue): Don't walk off the end of the ValueList.

LayoutTests:

New test for a crash when parsing a cubic-bezier function

Reviewed by Hyatt.

fast/css/parse-timing-function-crash-expected.txt: Added.
fast/css/parse-timing-function-crash.html: Added.

8:05 PM Changeset in webkit [27337] by hyatt

2 edits in trunk/WebCore

Fix a merge error from when I applied my patch to ToT. A couple of lines should be part of an if.

rendering/RenderStyle.cpp: (WebCore::RenderStyle::adjustTransitions):

6:22 PM Changeset in webkit [27336] by aroben

4 edits in trunk/JavaScriptCore

Fix a crash on launch due to a static initializer race

We now use fast inline assembler spinlocks which can be statically
initialized at compile time.

As a side benefit, this speeds up SunSpider by 0.4%.

Reviewed by Oliver.

wtf/FastMalloc.cpp:
wtf/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
wtf/TCSystemAlloc.cpp:

6:16 PM Changeset in webkit [27335] by andersca

3 edits
22 adds in trunk/WebCore

Reviewed by Sam.

Add new SQL callback interfaces and JS implementations of them.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCustomSQLStatementCallback.cpp: Added. (WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback): (WebCore::JSCustomSQLStatementCallback::handleEvent):
bindings/js/JSCustomSQLStatementCallback.h: Added.
bindings/js/JSCustomSQLStatementErrorCallback.cpp: Added. (WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback): (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
bindings/js/JSCustomSQLStatementErrorCallback.h: Added.
bindings/js/JSCustomSQLTransactionCallback.cpp: Added. (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::handleEvent):
bindings/js/JSCustomSQLTransactionCallback.h: Added.
bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Added. (WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback): (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
bindings/js/JSCustomSQLTransactionErrorCallback.h: Added.
storage/JSCustomSQLStatementCallback.h: Added.
storage/JSCustomSQLStatementErrorCallback.h: Added.
storage/JSCustomSQLTransactionCallback.h: Added.
storage/JSCustomSQLTransactionErrorCallback.h: Added.
storage/SQLStatementCallback.h: Added. (WebCore::SQLStatementCallback::~SQLStatementCallback):
storage/SQLStatementCallback.idl: Added.
storage/SQLStatementErrorCallback.h: Added. (WebCore::SQLStatementErrorCallback::~SQLStatementErrorCallback):
storage/SQLStatementErrorCallback.idl: Added.
storage/SQLTransaction.h: Added.
storage/SQLTransaction.idl: Added.
storage/SQLTransactionCallback.h: Added. (WebCore::SQLTransactionCallback::~SQLTransactionCallback):
storage/SQLTransactionCallback.idl: Added.
storage/SQLTransactionErrorCallback.h: Added. (WebCore::SQLTransactionErrorCallback::~SQLTransactionErrorCallback):
storage/SQLTransactionErrorCallback.idl: Added.

5:06 PM Changeset in webkit [27334] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by Sam.

Corrected spelling.

wtf/HashTraits.h:

4:23 PM Changeset in webkit [27333] by justing

3 edits
4 adds in trunk

WebCore:

Reviewed by Dave Harrison.

<rdar://problem/5569741> Pasting content with a line break into a list can remove the list

editing/htmlediting.cpp: (WebCore::enclosingEmptyListItem): A single list item can contain multiple paragraphs, so if the incoming VisiblePosition is in an empty paragraph in a list item, that list item isn't necessarily empty.

LayoutTests:

Reviewed by Dave Harrison.

editing/execCommand/5569741.html: Added.
platform/mac/editing/execCommand/5569741-expected.checksum: Added.
platform/mac/editing/execCommand/5569741-expected.png: Added.
platform/mac/editing/execCommand/5569741-expected.txt: Added.

4:12 PM Changeset in webkit [27332] by timothy@apple.com

6 edits in trunk/WebKit

Reviewed by John Sullivan.

Move the developer extras preference to WebPreferences.

WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
WebView/WebPreferences.m: (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO. (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey. (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
WebView/WebView.mm: (+[WebView _developerExtrasEnabled]): Removed. (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.

2:19 PM Changeset in webkit [27331] by hyatt

2 edits in trunk/WebCore

Disable style sharing for animating styles.

Reviewed by mitzpettel

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):

1:58 PM Changeset in webkit [27330] by mitz

2 edits in trunk/WebCore

Reviewed by Darin Adler.

fix intermediate length calculation

rendering/Length.h: (WebCore::Length::blend):

1:54 PM Changeset in webkit [27329] by antti

1 edit
10 deletes in trunk/LayoutTests

Remove timing dependent, occasionally failing cue point tests.
Cue points will be replaced with cue ranges soon anyway.

media/video-cuepoint-pause-expected.txt: Removed.
media/video-cuepoint-remove-multiple-expected.txt: Removed.
media/video-cuepoint-multiple-expected.txt: Removed.
media/video-cuepoint-remove-expected.txt: Removed.
media/video-cuepoint-pause.html: Removed.
media/video-cuepoint-remove-multiple.html: Removed.
media/video-cuepoint-multiple.html: Removed.
media/video-cuepoint-remove.html: Removed.
media/video-cuepoint-add-expected.txt: Removed.
media/video-cuepoint-add.html: Removed.

1:07 PM Changeset in webkit [27328] by andersca

4 edits
2 adds in trunk/WebCore

Reviewed by Darin.

Add new SQLError implementation.

DerivedSources.make:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
storage/SQLError.h: Added. (WebCore::SQLError::SQLError): (WebCore::SQLError::code): (WebCore::SQLError::message):
storage/SQLError.idl: Added.

11:46 AM Changeset in webkit [27327] by hyatt

2 edits in trunk/WebCore

Change the initial value of transition-property to all. Change the initial value of
transition-duration to 0.

Reviewed by antti

rendering/RenderStyle.h: (WebCore::RenderStyle::initialTransitionDuration): (WebCore::RenderStyle::initialTransitionProperty):

11:33 AM Changeset in webkit [27326] by aroben

4 edits in trunk

Switch the Debug configuration to using the non-debug CRT

WebKitTools:

Switch the Debug configuration to using the non-debug CRT

This matches WebKit.

Reviewed by Steve.

DumpRenderTree/win/DumpRenderTree.vcproj:

WebKit/win:

Switch the Debug configuration to using the non-debug CRT

The debug CRT conflicts with what Safari uses, which causes loading
problems.

Reviewed by Steve.

WebKit.vcproj/WebKit.vcproj:

9:23 AM Changeset in webkit [27325] by alp

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

The new Color must be marked valid.

8:16 AM Changeset in webkit [27324] by antti

2 edits in trunk/WebKitTools

Reviewed by bdash.

Disable media tests when doing leak checking on Tiger.
They crash in QuickTime (rdar://problem/5537157).

Scripts/run-webkit-tests:

8:05 AM Changeset in webkit [27323] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-10-31 Mark Rowe <mrowe@apple.com>

Further Gtk build fixage.

kjs/regexp_object.cpp:

7:59 AM Changeset in webkit [27322] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-10-31 Mark Rowe <mrowe@apple.com>

Gtk build fix.

kjs/regexp.h:

7:52 AM Changeset in webkit [27321] by darin

1 edit in trunk/JavaScriptCore/ChangeLog

Tweaked formatting of the ChangeLog a bit.

7:46 AM Changeset in webkit [27320] by darin

7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=15749 RegExp/RegExpObjectImp cause needless UString creation

Speeds things up 0.4% according to SunSpider.

kjs/config.h: Define USE(PCRE16) instead of HAVE(PCREPOSIX), because this library doesn't use the real PCRE -- it uses its own PCRE that works on UTF-16.

kjs/regexp.h: Removed a few unused functions. Changed the ifdef. Use Noncopyable. Change the return value of match.
kjs/regexp.cpp: (KJS::RegExp::RegExp): Call pcre_compile2, for a slight speed boost. (KJS::RegExp::~RegExp): PCRE16 rather than PCREPOSIX. (KJS::RegExp::match): Change to return the position as an int and the ovector as a OwnArrayPtr<int> for efficiency and clearer storage management.

kjs/regexp_object.h: Change performMatch and arrayOfMatches to no longer require a result string.
kjs/regexp_object.cpp: (RegExpProtoFunc::callAsFunction): Update for new signature of performMatch. (RegExpObjectImp::performMatch): Change so it doesn't return a string. (RegExpObjectImp::arrayOfMatches): Simplify by unifying the handling of the main result with the backreferences; now it doesn't need to take a result parameter. (RegExpObjectImp::getBackref): Minor tweaks. (RegExpObjectImp::getLastParen): Ditto. (RegExpObjectImp::getLeftContext): Ditto. (RegExpObjectImp::getRightContext): Ditto. (RegExpObjectImp::getValueProperty): Change LastMatch case to call getBackref(0) so we don't need a separate getLastMatch function.

kjs/string_object.cpp: (KJS::replace): Update to use new performMatch, including merging the matched string section with the other substrings. (KJS::StringProtoFunc::callAsFunction): Update functions to use the new performMatch and match. Also change to use OwnArrayPtr.

4:42 AM Changeset in webkit [27319] by hausmann

2 edits in trunk/WebCore

Build fix for non-Qt builds.

4:18 AM Changeset in webkit [27318] by hausmann

2 edits in trunk/WebCore

Fix dependency path to header files of the public API of the Qt port.

4:15 AM Changeset in webkit [27317] by hausmann

3 edits in trunk/WebCore

QXmlStreamNamespaceDeclaration doesn't have the constructor we want to use for Qt4.3. Reenable the old code path which is likely to be dead as I have not checked if m_prefixToNamespaceMap is actually used.
Guard the entity resolver with the QT_VERSION as well.
Partially reverts 369506279abdaa863e15efed649ca19e062f2c30 and d2b54d0fc1b07a2480f4f7a1417abd7a636b0107 for Qt4.3.

4:13 AM Changeset in webkit [27316] by hausmann

2 edits in trunk/WebCore

QMimeData::removeData will be new in Qt4.4, don't use it for Qt4.3
Provide a bad fallback implementation to filter the format list.

Signed-off-by: Lars Knoll <lars@trolltech.com>

4:09 AM Changeset in webkit [27315] by hausmann

2 edits in trunk/WebCore

add an entitiy resolver to QXmlStream.
Fixes fast/parser/entities-in-attributes.xhtml.

4:09 AM Changeset in webkit [27314] by hausmann

5 edits
2 deletes in trunk

Fixes in the XML tokenizer when using QXmlStream.

Use new functionality of QXmlStream in Qt 4.4 to simplify
the code (but keep the old code for now to still support Qt 4.3).

Add proper support for namespace handling when parsing into
a document fragment.

4:08 AM Changeset in webkit [27313] by hausmann

4 edits in trunk/WebCore

add support for dragging images.

4:08 AM Changeset in webkit [27312] by hausmann

7 edits in trunk

fix most of the issues I found with Clipboard and DnD.

4:08 AM Changeset in webkit [27311] by hausmann

2 edits in trunk/WebKit/qt

QDrag objects need to be created on the heap.

4:08 AM Changeset in webkit [27310] by hausmann

2 edits in trunk/WebKit/qt

a dragLeave event is not the same as cancelling a drag.

4:02 AM Changeset in webkit [27309] by oliver

2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (qt buildfix)

kjs/nodes.h: include OwnPtr.h

3:54 AM Changeset in webkit [27308] by oliver

5 edits in trunk/JavaScriptCore

Remove SourceCodeElement class and replaced with a Vector for a 0.8% gain on sunspider

Reviewed by Maciej

3:52 AM Changeset in webkit [27307] by mjs

1 edit in trunk/JavaScriptCore/ChangeLog

Oliver hasn't changed his name to ChangeLog.

2:47 AM Changeset in webkit [27306] by bdash

3 edits in trunk/WebCore

2007-10-30 Mark Rowe <mrowe@apple.com>

Fix the Gtk and Qt builds by stubbing out PlatformKeyboardEvent::currentCapsLockState.

platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState):
platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState):

2:33 AM Changeset in webkit [27305] by bdash

2 edits in trunk/JavaScriptCore

2007-10-30 Mark Rowe <mrowe@apple.com>

Build fix for non-Mac ports.

kjs/property_map.cpp:

2:17 AM Changeset in webkit [27304] by mjs

2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

fix builds

kjs/property_map.cpp: Include HashTable.h the right way.

1:29 AM Changeset in webkit [27303] by ap

5 edits
3 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11001
WebKit doesn't support RegExp.compile method

Test: fast/js/regexp-compile.html

kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): (RegExpProtoFunc::callAsFunction):
kjs/regexp_object.h: (KJS::RegExpProtoFunc::): Added RegExp.compile.

tests/mozilla/expected.html: js1_2/regexp/compile.js now passes.

1:22 AM Changeset in webkit [27302] by ap

5 edits in trunk

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=15762
XSLStylesheet loads subresources from a wrong URL

Covered by corrected existing tests.

xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString): Pass stylesheet URL, not the document one.

1:22 AM Changeset in webkit [27301] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by ChangeLog.

get rid of integer divide in PropertyMap and HashTable for 1% SunSpider speedup

Integer divide sucks. Fortunately, a bunch of shifts and XORs
biased towards the high bits is sufficient to provide a good
double hash. Besides the SunSpider win, I used the dump statistics
mode for both to verify that collisions did not increase and that
the longest collision chain is not any longer.

kjs/property_map.cpp: (KJS::doubleHash): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::remove): (KJS::PropertyMap::checkConsistency):
wtf/HashTable.h: (WTF::doubleHash): (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):

1:20 AM Changeset in webkit [27300] by ap

2 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=10818
String::append does 2 full copies instead of 1 (or zero!)

No change in functionality, thus no test.

platform/String.cpp: (WebCore::String::append): Rewrote to copy once. Also removed an ancient FIXME that doesn't seem to make any sense. Note that append() behavior doesn't match documented String behavior ("modifications to one instance will also modify all others"), but there are a lot of methods that don't.

12:54 AM Changeset in webkit [27299] by aroben

2 edits in trunk/WebCore

Windows build fix

WebCore.vcproj/WebCore.vcproj: Add [JS]ProgressEvent.{cpp,h} files.

12:24 AM Changeset in webkit [27298] by aroben

2 edits in trunk/JavaScriptCore

Build fix

kjs/collector.h: Make HeapType public.

12:20 AM Changeset in webkit [27297] by aroben

4 edits in trunk/JavaScriptCore

Change ALWAYS_INLINE and WTF_PRIVATE_INLINE to use forceinline on Windows

Speeds up SunSpider by 0.4%.

Reviewed by Steve and Maciej.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable a warning during LTCG in release builds about double -> float conversion.
wtf/AlwaysInline.h:
wtf/FastMalloc.h:

12:19 AM Changeset in webkit [27296] by aroben

2 edits in trunk/JavaScriptCore

Use GetCurrentThreadId instead of pthread_self in FastMalloc

Speeds up SunSpider by 0.3%.

Reviewed by Steve.

wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::InitTSD): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

12:19 AM Changeset in webkit [27295] by aroben

4 edits in trunk/JavaScriptCore

Switch to a Win32 critical section implementation of spinlocks

Speeds up SunSpider by 0.4%.

Reviewed by Steve.

wtf/FastMalloc.cpp:
wtf/TCSpinLock.h: (TCMalloc_SpinLock::TCMalloc_SpinLock): (TCMalloc_SpinLock::Init): (TCMalloc_SpinLock::Finalize): (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock):
wtf/TCSystemAlloc.cpp:

12:18 AM Changeset in webkit [27294] by aroben

2 edits in trunk/JavaScriptCore

Fix Bug 15586: REGRESSION (r26759-r26785): Windows nightly builds crash with Safari 3 Public Beta

http://bugs.webkit.org/show_bug.cgi?id=15586

Also fixes: <rdar://5565303> Cannot use regsvr32.exe to register WebKit.dll

Use Win32 TLS functions instead of declspec(thread), which breaks
delay-loading.

Reviewed by Steve.

wtf/FastMalloc.cpp: (WTF::getThreadHeap): (WTF::TCMalloc_ThreadCache::InitModule):

Oct 30, 2007:

11:57 PM Changeset in webkit [27293] by aroben

3 edits in trunk/WebCore

Windows build fixes

I'm not completely sure why these const issues weren't caught by GCC,
but MSVC was certainly not happy with them.

editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote):
editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl):

11:09 PM Changeset in webkit [27292] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Oliver.

allocate numbers in half-size cells, for an 0.5% SunSpider speedup http://bugs.webkit.org/show_bug.cgi?id=15772

We do this by using a single mark bit per two number cells, and
tweaking marking.

Besides being an 0.5% win overall, this is a 7.1% win on morph.

kjs/collector.cpp: (KJS::): (KJS::Collector::heapAllocate): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::sweep):
kjs/collector.h: (KJS::SmallCollectorCell::):

8:55 PM Changeset in webkit [27291] by hyatt

7 edits in trunk/WebCore

transition-property was defaulting to all when it should default to none.

It was taking a string type. I figured out how to make it take an ident instead, so you can write:

transition-property: opacity

instead of

transition-property: "opacity"

Transition layers also weren't properly repeating patterns the way they were supposed to. I fixed that.

Finally, I fixed a bug in the code to fix up transition layers where something was misplaced that should have been inside a null check.

Reviewed by aroben

css/CSSHelper.h:
css/CSSParser.cpp: (WebCore::CSSParser::parseTransitionProperty):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
page/AnimationController.cpp: (WebCore::ImplicitAnimation::animate):
rendering/RenderStyle.cpp: (WebCore::RenderStyle::adjustTransitions):
rendering/RenderStyle.h: (WebCore::RenderStyle::initialTransitionProperty):

8:30 PM Changeset in webkit [27290] by antti

2 edits in trunk/WebCore

Reviewed by Geoff.

Leak fix

platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::getSupportedTypes):

8:04 PM Changeset in webkit [27289] by ggaren

3 edits in trunk/JavaScriptCore

Reviewed by Adam Roben, Sam Weinig.

Made conflicts in grammar.y a persistent build failure.

DerivedSources.make:

7:47 PM Changeset in webkit [27288] by mitz

2 edits in trunk/WebCore

Reviewed by Stephanie Lewis.

fix <rdar://problem/5547237> REGRESSION (304-ToT): Repro font-related crash in fontdatawin.cpp Line 93 (many sites)

platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): Handle the case where the font has no glyphs on page zero.

7:36 PM Changeset in webkit [27287] by hyatt

1 edit in trunk/WebCore/page/AnimationController.cpp

Fix Qt bustage in AnimationController.cpp

7:35 PM Changeset in webkit [27286] by antti

4 edits
85 adds in trunk/LayoutTests

Reviewed by Maciej.

Media tests from feature branch.

fast/dom/Window/window-properties-expected.txt: Replaced.
fast/dom/Window/window-properties.html: Replaced.
media: Added.
media/audio-constructor-expected.txt: Added.
media/audio-constructor-src-expected.txt: Added.
media/audio-constructor-src.html: Added.
media/audio-constructor.html: Added.
media/content: Added.
media/content/test.mp4: Added.
media/content/test.wav: Added.
media/progress-event-expected.txt: Added.
media/progress-event.html: Added.
media/video-append-source-expected.txt: Added.
media/video-append-source.html: Added.
media/video-autoplay-expected.txt: Added.
media/video-autoplay.html: Added.
media/video-buffered-expected.txt: Added.
media/video-buffered.html: Added.
media/video-cuepoint-add-expected.txt: Added.
media/video-cuepoint-add.html: Added.
media/video-cuepoint-multiple-expected.txt: Added.
media/video-cuepoint-multiple.html: Added.
media/video-cuepoint-pause-expected.txt: Added.
media/video-cuepoint-pause.html: Added.
media/video-cuepoint-remove-expected.txt: Added.
media/video-cuepoint-remove-multiple-expected.txt: Added.
media/video-cuepoint-remove-multiple.html: Added.
media/video-cuepoint-remove.html: Added.
media/video-currentTime-expected.txt: Added.
media/video-currentTime-set-expected.txt: Added.
media/video-currentTime-set.html: Added.
media/video-currentTime-set2-expected.txt: Added.
media/video-currentTime-set2.html: Added.
media/video-currentTime.html: Added.
media/video-dom-autoplay-expected.txt: Added.
media/video-dom-autoplay.html: Added.
media/video-dom-end-expected.txt: Added.
media/video-dom-end.html: Added.
media/video-dom-loopcount-expected.txt: Added.
media/video-dom-loopcount.html: Added.
media/video-dom-loopend-expected.txt: Added.
media/video-dom-loopend.html: Added.
media/video-dom-loopstart-expected.txt: Added.
media/video-dom-loopstart.html: Added.
media/video-dom-src-expected.txt: Added.
media/video-dom-src.html: Added.
media/video-dom-start-expected.txt: Added.
media/video-dom-start.html: Added.
media/video-end-expected.txt: Added.
media/video-end.html: Added.
media/video-error-abort-expected.txt: Added.
media/video-error-abort.html: Added.
media/video-error-does-not-exist-expected.txt: Added.
media/video-error-does-not-exist.html: Added.
media/video-load-networkState-expected.txt: Added.
media/video-load-networkState.html: Added.
media/video-load-readyState-expected.txt: Added.
media/video-load-readyState.html: Added.
media/video-loopcount-expected.txt: Added.
media/video-loopcount.html: Added.
media/video-loopend-expected.txt: Added.
media/video-loopend.html: Added.
media/video-loopstart-expected.txt: Added.
media/video-loopstart.html: Added.
media/video-muted-expected.txt: Added.
media/video-muted.html: Added.
media/video-no-autoplay-expected.txt: Added.
media/video-no-autoplay.html: Added.
media/video-seekable-expected.txt: Added.
media/video-seekable.html: Added.
media/video-size-expected.txt: Added.
media/video-size.html: Added.
media/video-source-expected.txt: Added.
media/video-source-media-expected.txt: Added.
media/video-source-media.html: Added.
media/video-source-type-expected.txt: Added.
media/video-source-type.html: Added.
media/video-source.html: Added.
media/video-src-expected.txt: Added.
media/video-src-source-expected.txt: Added.
media/video-src-source.html: Added.
media/video-src.html: Added.
media/video-start-expected.txt: Added.
media/video-start.html: Added.
media/video-test.js: Added.
media/video-volume-expected.txt: Added.
media/video-volume.html: Added.
platform/qt/Skipped:
platform/win/Skipped:

7:35 PM Changeset in webkit [27285] by hyatt

1 edit in trunk/WebCore/rendering/RenderStyle.cpp

Remove unused blendLengths function.

7:32 PM Changeset in webkit [27284] by hyatt

2 edits in trunk/WebCore

Eliminate rounding from int-based animation blending.

7:30 PM Changeset in webkit [27283] by hyatt

6 edits in trunk/WebCore

Make sure CSS transforms can be animated using the CSS transition property.

Reviewed by Dan and Antti

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
page/AnimationController.cpp: (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate):
rendering/Length.h: (WebCore::Length::blend):
rendering/RenderStyle.cpp: (WebCore::StyleTransformData::operator==): (WebCore::TransformOperations::operator==): (WebCore::blendLengths): (WebCore::ScaleTransformOperation::blend): (WebCore::RotateTransformOperation::blend): (WebCore::SkewTransformOperation::blend): (WebCore::TranslateTransformOperation::blend): (WebCore::MatrixTransformOperation::blend):
rendering/RenderStyle.h: (WebCore::TransformOperations::operator!=): (WebCore::TransformOperations::isEmpty): (WebCore::TransformOperations::size): (WebCore::TransformOperations::operator[]): (WebCore::TransformOperations::append): (WebCore::RenderStyle::transform): (WebCore::RenderStyle::setTransform): (WebCore::RenderStyle::initialTransform):

7:11 PM Changeset in webkit [27282] by antti

2 edits in trunk/WebCore

Another Qt/GTK build fix.

bindings/js/JSHTMLElementWrapperFactory.cpp:

6:51 PM Changeset in webkit [27281] by antti

2 edits in trunk/WebCore

Attempt to fix Qt/GTK build.

WebCore.pro:

6:27 PM Changeset in webkit [27280] by justing

11 edits
10 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5549929> CrashTracer: [USER] 35 crashes at WebCore::CharacterData::insertData

We were trying to insert a tab into a br, after the br incorrectly ended up inside
a tab span.

editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): Changed to take in a const Node* instead of a Node*.
editing/DeleteSelectionCommand.cpp: (WebCore::isTableRow): Ditto.
editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote): Ditto. (WebCore::isListOrIndentBlockquote): Ditto.
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::shouldUseBreakElement): Added, moved code from doApply here. (WebCore::InsertLineBreakCommand::doApply): Don't upstream() the insertion position. upstream()ing it will only have an effect when the insertion position is the first in its paragraph (since we canonicalize VisiblePositions to the upstream() candidate). In this start of paragraph case, upstream() can move outside inline elements like tab spans or elements that might have a different whitespace mode (added two test cases to cover these). Moved code to decide whether to insert a br or a '\n' to its own method. Removed special case code for inserting at a position inside a tab span. We instead adjust the insertion position before insertion if it is inside a tab span and handle insertion in the appropriate if-block. This fixes a bug where we would only insert one line break when two were needed (added a testcase). Removed special case code for inserting before and after tables and horizontal rules. We handle these insertions in the appropriate if-block.
editing/InsertLineBreakCommand.h:
editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Change to take in a const Node*.
editing/htmlediting.cpp: (WebCore::isContentEditable): Ditto. (WebCore::isBlock): Ditto. (WebCore::enclosingNodeOfType): Changed to take a function pointer to a function that takes in a const Node*. (WebCore::isTabSpanTextNode): Check to see that the node actually a text node, and not, say, a br.
editing/htmlediting.h:
editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Changed to take in a const Node*. (WebCore::elementHasTextDecorationProperty): Ditto.

LayoutTests:

Reviewed by Darin Adler.

<rdar://problem/5549929> CrashTracer: [USER] 35 crashes at WebCore::CharacterData::insertData

editing/inserting/5549929-1-expected.txt: Added.
editing/inserting/5549929-1.html: Added.
editing/inserting/5549929-2.html: Added.
editing/inserting/5549929-3.html: Added.
platform/mac/editing/inserting/5549929-2-expected.checksum: Added.
platform/mac/editing/inserting/5549929-2-expected.png: Added.
platform/mac/editing/inserting/5549929-2-expected.txt: Added.
platform/mac/editing/inserting/5549929-3-expected.checksum: Added.
platform/mac/editing/inserting/5549929-3-expected.png: Added.
platform/mac/editing/inserting/5549929-3-expected.txt: Added.

6:23 PM Changeset in webkit [27279] by antti

1 edit
3 adds in trunk/WebCore

Reviewed by NOBODY.

Add files missing from previous commit.

html/VoidCallback.cpp: Added. (VoidCallback::VoidCallback): (VoidCallback::~VoidCallback): (VoidCallback::handleEvent): (VoidCallback::execute): (VoidCallback::operator==): (WebCore::toVoidCallback):
html/VoidCallback.h: Added.
html/VoidCallback.idl: Added.

6:08 PM Changeset in webkit [27278] by ddkilzer

5 edits in trunk

WebCore:

Generated files missing from WebCore's Xcode project file
<http://bugs.webkit.org/show_bug.cgi?id=15406>

Reviewed by Darin.

Added the following files to the Xcode project file (note that
JSHTMLInputElementBaseTable.cpp is used as a header file):

DOMCSSStyleSheetPrivate.h
DOMEventPrivate.h
DOMHTMLCollectionPrivate.h
DOMHTMLEmbedElementPrivate.h
DOMHTMLIFrameElementPrivate.h
DOMHTMLObjectElementPrivate.h
DOMHTMLSelectElementPrivate.h
DOMTextEventInternal.h
JSHTMLInputElementBaseTable.cpp

DerivedSources.make: Removed DOMSVGException.h and JSSVGAnimatedPoints.h since their generated code was not used.
WebCore.xcodeproj/project.pbxproj: Added missing header files.

WebKit:

Generated files missing from WebCore's Xcode project file
<http://bugs.webkit.org/show_bug.cgi?id=15406>

Reviewed by Darin.

Added the following private header files to MigrateHeaders.make:

DOMCSSStyleSheetPrivate.h
DOMEventPrivate.h
DOMHTMLCollectionPrivate.h
DOMHTMLEmbedElementPrivate.h
DOMHTMLIFrameElementPrivate.h
DOMHTMLObjectElementPrivate.h
DOMHTMLSelectElementPrivate.h

MigrateHeaders.make:

6:03 PM Changeset in webkit [27277] by antti

31 edits
28 adds in trunk/WebCore

Rubber stamped by Adele.

Initial media (<video> and <audio>) support from feature branch and
QTKit based platform implementation.

This will need to be updated to match current draft specification.

Configurations/WebCore.xcconfig:
DerivedSources.make:
WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEventCustom.cpp: (WebCore::toJS):
bindings/js/JSHTMLAudioElementConstructor.cpp: Added. (WebCore::JSHTMLAudioElementConstructor::JSHTMLAudioElementConstructor): (WebCore::JSHTMLAudioElementConstructor::implementsConstruct): (WebCore::JSHTMLAudioElementConstructor::construct):
bindings/js/JSHTMLAudioElementConstructor.h: Added.
bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
bindings/js/kjs_window.h: (KJS::Window::):
bindings/scripts/CodeGeneratorJS.pm:
dom/Document.cpp: (WebCore::Document::createEvent): (WebCore::Document::willSaveToCache): (WebCore::Document::didRestoreFromCache): (WebCore::Document::registerForCacheCallbacks): (WebCore::Document::unregisterForCacheCallbacks):
dom/Document.h:
dom/Element.cpp: (WebCore::Element::setBooleanAttribute):
dom/Element.h: (WebCore::Element::willSaveToCache):
dom/Event.cpp: (WebCore::Event::isProgressEvent):
dom/Event.h:
dom/EventNames.h:
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchProgressEvent):
dom/EventTargetNode.h:
dom/ProgressEvent.cpp: Added. (WebCore::ProgressEvent::ProgressEvent): (WebCore::ProgressEvent::initProgressEvent): (WebCore::ProgressEvent::initProgressEventNS):
dom/ProgressEvent.h: Added. (WebCore::ProgressEvent::lengthComputable): (WebCore::ProgressEvent::loaded): (WebCore::ProgressEvent::total): (WebCore::ProgressEvent::isProgressEvent):
dom/ProgressEvent.idl: Added.
history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
html/HTMLAttributeNames.in:
html/HTMLAudioElement.cpp: Added. (WebCore::HTMLAudioElement::HTMLAudioElement):
html/HTMLAudioElement.h: Added. (WebCore::HTMLAudioElement::tagPriority):
html/HTMLAudioElement.idl: Added.
html/HTMLElement.cpp: (WebCore::inlineTagList):
html/HTMLElementFactory.cpp: (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor): (WebCore::createFunctionMap):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
html/HTMLMediaElement.cpp: Added. (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::checkDTD): (WebCore::HTMLMediaElement::rendererIsNeeded): (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::insertedIntoDocument): (WebCore::HTMLMediaElement::removedFromDocument): (WebCore::HTMLMediaElement::scheduleLoad): (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): (WebCore::HTMLMediaElement::dispatchEventAsync): (WebCore::HTMLMediaElement::loadTimerFired): (WebCore::HTMLMediaElement::asyncEventTimerFired): (WebCore::serializeTimeOffset): (WebCore::parseTimeOffset): (WebCore::HTMLMediaElement::getTimeOffsetAttribute): (WebCore::HTMLMediaElement::setTimeOffsetAttribute): (WebCore::HTMLMediaElement::error): (WebCore::HTMLMediaElement::src): (WebCore::HTMLMediaElement::HTMLMediaElement::setSrc): (WebCore::HTMLMediaElement::currentSrc): (WebCore::HTMLMediaElement::networkState): (WebCore::HTMLMediaElement::bufferingRate): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::movieNetworkStateChanged): (WebCore::HTMLMediaElement::movieReadyStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::progressEventTimerFired): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::readyState): (WebCore::HTMLMediaElement::seeking): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::setCurrentTime): (WebCore::HTMLMediaElement::duration): (WebCore::HTMLMediaElement::paused): (WebCore::HTMLMediaElement::defaultPlaybackRate): (WebCore::HTMLMediaElement::setDefaultPlaybackRate): (WebCore::HTMLMediaElement::playbackRate): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::ended): (WebCore::HTMLMediaElement::autoplay): (WebCore::HTMLMediaElement::setAutoplay): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::loopCount): (WebCore::HTMLMediaElement::setLoopCount): (WebCore::HTMLMediaElement::start): (WebCore::HTMLMediaElement::setStart): (WebCore::HTMLMediaElement::end): (WebCore::HTMLMediaElement::setEnd): (WebCore::HTMLMediaElement::loopStart): (WebCore::HTMLMediaElement::setLoopStart): (WebCore::HTMLMediaElement::loopEnd): (WebCore::HTMLMediaElement::setLoopEnd): (WebCore::HTMLMediaElement::currentLoop): (WebCore::HTMLMediaElement::setCurrentLoop): (WebCore::HTMLMediaElement::controls): (WebCore::HTMLMediaElement::setControls): (WebCore::HTMLMediaElement::volume): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::muted): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::pickMedia): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::movieVolumeChanged): (WebCore::HTMLMediaElement::movieDidEnd): (WebCore::HTMLMediaElement::movieCuePointReached): (WebCore::HTMLMediaElement::addCuePoint): (WebCore::HTMLMediaElement::removeCuePoint): (WebCore::HTMLMediaElement::buffered): (WebCore::HTMLMediaElement::played): (WebCore::HTMLMediaElement::seekable): (WebCore::HTMLMediaElement::effectiveStart): (WebCore::HTMLMediaElement::effectiveEnd): (WebCore::HTMLMediaElement::effectiveLoopStart): (WebCore::HTMLMediaElement::effectiveLoopEnd): (WebCore::HTMLMediaElement::activelyPlaying): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
html/HTMLMediaElement.h: Added. (WebCore::HTMLMediaElement::movie): (WebCore::HTMLMediaElement::isVideo): (WebCore::HTMLMediaElement::): (WebCore::HTMLMediaElement::CallbackEntry::CallbackEntry):
html/HTMLMediaElement.idl: Added.
html/HTMLSourceElement.cpp: Added. (WebCore::HTMLSourceElement::HTMLSourceElement): (WebCore::HTMLSourceElement::~HTMLSourceElement): (WebCore::HTMLSourceElement::insertedIntoDocument): (WebCore::HTMLSourceElement::src): (WebCore::HTMLSourceElement::setSrc): (WebCore::HTMLSourceElement::media): (WebCore::HTMLSourceElement::setMedia): (WebCore::HTMLSourceElement::type): (WebCore::HTMLSourceElement::setType):
html/HTMLSourceElement.h: Added. (WebCore::HTMLSourceElement::endTagRequirement): (WebCore::HTMLSourceElement::tagPriority):
html/HTMLSourceElement.idl: Added.
html/HTMLTagNames.in:
html/HTMLVideoElement.cpp: Added. (WebCore::HTMLVideoElement::HTMLVideoElement): (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight):
html/HTMLVideoElement.h: Added. (WebCore::HTMLVideoElement::tagPriority): (WebCore::HTMLVideoElement::isVideo):
html/HTMLVideoElement.idl: Added.
html/MediaError.h: Added. (WebCore::MediaError::): (WebCore::MediaError::MediaError): (WebCore::MediaError::code):
html/MediaError.idl: Added.
html/TimeRanges.cpp: Added. (TimeRanges::TimeRanges): (TimeRanges::start): (TimeRanges::end): (TimeRanges::add): (TimeRanges::contain):
html/TimeRanges.h: Added. (WebCore::TimeRanges::TimeRanges): (WebCore::TimeRanges::length): (WebCore::TimeRanges::Range::Range):
html/TimeRanges.idl: Added.
page/DOMWindow.idl:
platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMovieMIMETypes): (WebCore::initialiseMIMETypeRegistry): (WebCore::MIMETypeRegistry::isSupportedMovieMIMEType): (WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):
platform/MIMETypeRegistry.h:
platform/graphics/Movie.cpp: Added. (WebCore::Movie::Movie): (WebCore::Movie::~Movie): (WebCore::Movie::load): (WebCore::Movie::cancelLoad): (WebCore::Movie::play): (WebCore::Movie::pause): (WebCore::Movie::duration): (WebCore::Movie::currentTime): (WebCore::Movie::seek): (WebCore::Movie::paused): (WebCore::Movie::seeking): (WebCore::Movie::naturalSize): (WebCore::Movie::hasVideo): (WebCore::Movie::networkState): (WebCore::Movie::readyState): (WebCore::Movie::volume): (WebCore::Movie::setVolume): (WebCore::Movie::rate): (WebCore::Movie::setRate): (WebCore::Movie::muted): (WebCore::Movie::setMuted): (WebCore::Movie::dataRate): (WebCore::Movie::setEndTime): (WebCore::Movie::addCuePoint): (WebCore::Movie::removeCuePoint): (WebCore::Movie::clearCuePoints): (WebCore::Movie::maxTimeBuffered): (WebCore::Movie::maxTimeSeekable): (WebCore::Movie::bytesLoaded): (WebCore::Movie::totalBytesKnown): (WebCore::Movie::totalBytes): (WebCore::Movie::setRect): (WebCore::Movie::visible): (WebCore::Movie::setVisible): (WebCore::Movie::paint): (WebCore::Movie::getSupportedTypes): (WebCore::Movie::networkStateChanged): (WebCore::Movie::readyStateChanged): (WebCore::Movie::volumeChanged): (WebCore::Movie::didEnd): (WebCore::Movie::cuePointReached):
platform/graphics/Movie.h: Added. (WebCore::MovieClient::~MovieClient): (WebCore::MovieClient::movieNetworkStateChanged): (WebCore::MovieClient::movieReadyStateChanged): (WebCore::MovieClient::movieVolumeChanged): (WebCore::MovieClient::movieDidEnd): (WebCore::MovieClient::movieCuePointReached): (WebCore::Movie::parentWidget): (WebCore::Movie::setParentWidget): (WebCore::Movie::rect): (WebCore::Movie::):
platform/graphics/mac/MoviePrivateQTKit.h: Added.
platform/graphics/mac/MoviePrivateQTKit.mm: Added. (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::createQTMovie): (WebCore::MoviePrivate::createQTMovieView): (WebCore::MoviePrivate::createQTTime): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::duration): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::setEndTime): (WebCore::MoviePrivate::addCuePoint): (WebCore::MoviePrivate::removeCuePoint): (WebCore::MoviePrivate::clearCuePoints): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seekTimerFired): (WebCore::MoviePrivate::cuePointTimerFired): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::hasVideo): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::setRate): (WebCore::MoviePrivate::dataRate): (WebCore::MoviePrivate::networkState): (WebCore::MoviePrivate::readyState): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::maxTimeSeekable): (WebCore::MoviePrivate::maxTimeLoaded): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::cancelLoad): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::loadStateChanged): (WebCore::MoviePrivate::rateChanged): (WebCore::MoviePrivate::sizeChanged): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::volumeChanged): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::setRect): (WebCore::MoviePrivate::setVisible): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::getSupportedTypes): (-[WebCoreMovieObserver loadStateChanged:]): (-[WebCoreMovieObserver rateChanged:]): (-[WebCoreMovieObserver sizeChanged:]): (-[WebCoreMovieObserver timeChanged:]): (-[WebCoreMovieObserver volumeChanged:]): (-[WebCoreMovieObserver didEnd:]): (-[WebCoreMovieObserver setCallback:WebCore::]):
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::collectLayers):
rendering/RenderVideo.cpp: Added. (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::~RenderVideo): (WebCore::RenderVideo::movie): (WebCore::RenderVideo::videoSizeChanged): (WebCore::RenderVideo::paint): (WebCore::RenderVideo::layout): (WebCore::RenderVideo::updateFromElement): (WebCore::RenderVideo::updateMovie): (WebCore::RenderVideo::isWidthSpecified): (WebCore::RenderVideo::isHeightSpecified): (WebCore::RenderVideo::calcReplacedWidth): (WebCore::RenderVideo::calcReplacedHeight): (WebCore::RenderVideo::calcAspectRatioWidth): (WebCore::RenderVideo::calcAspectRatioHeight): (WebCore::RenderVideo::calcPrefWidths):
rendering/RenderVideo.h: Added. (WebCore::RenderVideo::renderName):

6:02 PM Changeset in webkit [27276] by weinig

105 edits in trunk/WebCore

Reviewed by Adam Roben.

Add Interface and Class UUIDs to the IDLs in preparation of adding
autogeneration of the COM DOM bindings.

bindings/scripts/IDLParser.pm: Relax parsing rules to allow newlines as whitespace.
css/CSSCharsetRule.idl:
css/CSSFontFaceRule.idl:
css/CSSImportRule.idl:
css/CSSMediaRule.idl:
css/CSSPageRule.idl:
css/CSSPrimitiveValue.idl:
css/CSSRule.idl:
css/CSSRuleList.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleRule.idl:
css/CSSStyleSheet.idl:
css/CSSUnknownRule.idl:
css/CSSValue.idl:
css/CSSValueList.idl:
css/Counter.idl:
css/MediaList.idl:
css/RGBColor.idl:
css/Rect.idl:
css/StyleSheet.idl:
css/StyleSheetList.idl:
dom/Attr.idl:
dom/CDATASection.idl:
dom/CharacterData.idl:
dom/Comment.idl:
dom/DOMImplementation.idl:
dom/Document.idl:
dom/DocumentFragment.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Entity.idl:
dom/EntityReference.idl:
dom/Event.idl:
dom/EventListener.idl:
dom/EventTarget.idl:
dom/NamedNodeMap.idl:
dom/Node.idl:
dom/NodeList.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl:
html/CanvasGradient.idl:
html/CanvasPattern.idl:
html/CanvasRenderingContext2D.idl:
html/HTMLAnchorElement.idl:
html/HTMLAppletElement.idl:
html/HTMLAreaElement.idl:
html/HTMLBRElement.idl:
html/HTMLBaseElement.idl:
html/HTMLBaseFontElement.idl:
html/HTMLBlockquoteElement.idl:
html/HTMLBodyElement.idl:
html/HTMLButtonElement.idl:
html/HTMLCanvasElement.idl:
html/HTMLCollection.idl:
html/HTMLDListElement.idl:
html/HTMLDirectoryElement.idl:
html/HTMLDivElement.idl:
html/HTMLDocument.idl:
html/HTMLElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLFieldSetElement.idl:
html/HTMLFontElement.idl:
html/HTMLFormElement.idl:
html/HTMLFrameElement.idl:
html/HTMLFrameSetElement.idl:
html/HTMLHRElement.idl:
html/HTMLHeadElement.idl:
html/HTMLHeadingElement.idl:
html/HTMLHtmlElement.idl:
html/HTMLIFrameElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLIsIndexElement.idl:
html/HTMLLIElement.idl:
html/HTMLLabelElement.idl:
html/HTMLLegendElement.idl:
html/HTMLLinkElement.idl:
html/HTMLMapElement.idl:
html/HTMLMarqueeElement.idl:
html/HTMLMenuElement.idl:
html/HTMLMetaElement.idl:
html/HTMLModElement.idl:
html/HTMLOListElement.idl:
html/HTMLObjectElement.idl:
html/HTMLOptGroupElement.idl:
html/HTMLOptionElement.idl:
html/HTMLOptionsCollection.idl:
html/HTMLParagraphElement.idl:
html/HTMLParamElement.idl:
html/HTMLPreElement.idl:
html/HTMLQuoteElement.idl:
html/HTMLScriptElement.idl:
html/HTMLSelectElement.idl:
html/HTMLStyleElement.idl:
html/HTMLTableCaptionElement.idl:
html/HTMLTableCellElement.idl:
html/HTMLTableColElement.idl:
html/HTMLTableElement.idl:
html/HTMLTableRowElement.idl:
html/HTMLTableSectionElement.idl:
html/HTMLTextAreaElement.idl:
html/HTMLTitleElement.idl:
html/HTMLUListElement.idl:

6:01 PM Changeset in webkit [27275] by kmccullo

6 edits in trunk

JavaScriptCore:

Reviewed by Adam and Geoff.

Added a new cast so all the casts are in the same place.

API/APICast.h: (toGlobalRef):

win:

Reviewed by Adam and Geoff.

Added the globalContext method so Drosera can ask a WebFrame for its context.

Interfaces/IWebFrame.idl:
WebFrame.cpp:
WebFrame.h:

5:58 PM Changeset in webkit [27274] by adele

2 edits in trunk/WebCore

RS by Darin.

page/AnimationController.cpp: (WebCore::blendFunc): Use lround instead of round.

5:48 PM Changeset in webkit [27273] by antti

2 edits in trunk/WebKitTools

Reviewed by Maciej.

Build media support by default on OSX only.

Scripts/build-webkit:

5:45 PM Changeset in webkit [27272] by antti

2 edits in trunk/WebKit

Reviewed by Maciej.

Some SPIs for media support.

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

4:19 PM Changeset in webkit [27271] by timothy@apple.com

1 edit in trunk/WebKit/StringsNotToBeLocalized.txt

Update WebKit/StringsNotToBeLocalized.txt.

4:15 PM Changeset in webkit [27270] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Fixed <rdar://problem/5567504> shift/reduce conflict introduced in r24457

JS tests, including

ecma_2/Statements/dowhile-001.js
ecma_2/Statements/dowhile-002.js
ecma_2/Statements/dowhile-003.js
ecma_2/Statements/dowhile-004.js
ecma_2/Statements/dowhile-005.js
ecma_2/Statements/dowhile-006.js
ecma_2/Statements/dowhile-007.js
js1_2/statements/do_while.js

and layout tests, including

do-while-expression-value.html
do-while-semicolon.html
do-while-without-semicolon.html

pass.

kjs/grammar.y: Use the explicit "error" production, as we do with other automatic semicolon insertions, to disambiguate "do { } while();" from "do { } while()" followed by ";" (the empty statement).

4:05 PM Changeset in webkit [27269] by kmccullo

1 edit in trunk/WebKitTools/ChangeLog

Made Adam the reviewer for a previous checkin. Not sure how it didn't get caught by the pre-commit hooks.

3:54 PM Changeset in webkit [27268] by kmccullo

8 edits
1 delete in trunk/WebKitTools

Reviewed by Adam.

This is a collection of relatively unrelated changes and cleanups to Drosera to prepare it for interacting with WebKit. A lot of these changes are just correcting mistakes, for example removing included headers that are no longer needed.

Drosera/DebuggerDocument.h: Added accessor for the ServerConnection this will be needed by the DebuggerClient. (DebuggerDocument::server):
Drosera/win/BaseDelegate.h: Removed unnecessary include.
Drosera/win/DebuggerClient.cpp: (DebuggerClient::didFinishLoadForFrame): Finished implementing. (DebuggerClient::didReceiveTitle): Added comment about its purpose. (DebuggerClient::createWebViewWithRequest): Added comment about its purpose.
Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward declarations. (DebuggerClient::webViewLoaded): Moved.
Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions file, since this was the only place it was used. (cfStringToBSTR):
Drosera/win/Drosera.h: Cleaned up the includes.
Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
Drosera/win/HelperFunctions.h: Removed.

3:52 PM JavaScript performance improvement ideas edited by mjs@apple.com

(diff)

3:46 PM JavaScript performance improvement ideas edited by ggaren@apple.com

(diff)

3:12 PM Changeset in webkit [27267] by kmccullo

3 edits in trunk/WebKitTools

Reviewed by NOBODY (OOPS!).

Small cleanup in the ServerConnection class.

Drosera/win/ServerConnection.cpp: Added comments, moved some functions and added an include. (ServerConnection::currentFrame): (ServerConnection::getCallerFrame):
Drosera/win/ServerConnection.h: Added comments, moved some functions, made a pointer into a COMPtr, and cleaned up the includes.

2:26 PM Changeset in webkit [27266] by timothy@apple.com

17 edits in trunk

WebCore:

Reviewed by John Sullivan.

Allow showing and closing the inspector programatically.
Add showConsole() and showTimeline() methods.

WebCore.base.exp: Add exports for WebKit.
page/InspectorController.cpp: (WebCore::callSimpleFunction): Renamed from callClearFunction(). (WebCore::unloading): Renamed to close(). (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspect): Moved showing code to show(). (WebCore::InspectorController::setWindowVisible): Show the timeline or console if needed. (WebCore::InspectorController::show): Code factored out of inspect(). (WebCore::InspectorController::showConsole): Call show() and the JS showConsole(). (WebCore::InspectorController::showTimeline): Call show() and the JS showTimeline(). (WebCore::InspectorController::close): (WebCore::InspectorController::clearScriptResources): Call the new callSimpleFunction. (WebCore::InspectorController::clearDatabaseScriptResources): Ditto. (WebCore::InspectorController::clearScriptConsoleMessages): Ditto. (WebCore::InspectorController::clearNetworkTimeline): Ditto.
page/InspectorController.h: Add and rename methods.
page/inspector/inspector.js: Add showConsole() and showTimeline().

WebKit:

Reviewed by John Sullivan.

Various semi-related changes:

A WebView can now be asked for it's WebInspector. There is one WebInspector per WebView.
Refactor the WebInspector class and move obsolete methods to a special category.
Add new WebInspector methods to show, hide and show the console/timeline panels.
Add an isDisabled method to WebCache.
Allow WebLocalizableStrings.h to be used in C files.

Misc/WebCache.h: Add isDisabled.
Misc/WebCache.mm: (+[WebCache isDisabled]): New method.

Misc/WebLocalizableStrings.h: Changes to allow use in plain C files.

WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): Call super if already visible so the window will be ordered front. (-[WebInspectorWindowController showWebInspector:]): Method used by menu items, so they are enabled and work when the Inspector window is key. (-[WebInspectorWindowController showErrorConsole:]): Ditto. (-[WebInspectorWindowController showNetworkTimeline:]): Ditto.

WebInspector/WebInspector.h: Add and remove methods.
WebInspector/WebInspector.mm: (-webViewClosed): Called when the WebView is closed/dealloced. Clears the _webView pointer. (-show:): Calls thru to the Page's InspectorController. (-showConsole:): Ditto. (-showTimeline:): Ditto. (-close:): Ditto. (-attach:): Ditto. (-detach:): Ditto. (+sharedWebInspector): Moved to the obsolete category. (+webInspector): Ditto. (-setWebFrame:): Ditto. (-window): Ditto. (-showWindow:): Ditto.

WebView/WebView.mm: (-[WebViewPrivate dealloc]): Release the WebInspector. (-[WebView _close]): Call webViewClosed on the WebInspector. (-[WebView inspector]): Create a WebInspector if needed and return it.
WebView/WebViewPrivate.h: Add the inspector method.

WebKitTools:

Reviewed by John Sullivan.

Place the Localizable.strings file in mac or win directories if that location exists.
Also look for UI_STRING in .c files.

Scripts/extract-localizable-strings:

2:18 PM Changeset in webkit [27265] by adele

2 edits in trunk/WebCore

Reviewed by Sam.

Build fix.

page/AnimationController.cpp: (WebCore::blendFunc):

2:05 PM Changeset in webkit [27264] by adele

21 edits
1 add in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields

Test: manual-tests/password-caps-lock.html

WebCore.base.exp: Added symbol for capsLockStateMayHaveChanged.

page/Frame.cpp: (WebCore::Frame::setIsActive): Calls capsLockStateMayHaveChanged.
page/EventHandler.cpp: (WebCore::EventHandler::capsLockStateMayHaveChanged): Added. Tells the focused node's renderer that the capsLockStateMayHaveChanged.
page/EventHandler.h:

platform/PlatformKeyboardEvent.h:
platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Added.
platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Added.

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::paint): Added. If m_shouldDrawCapsLockIndicator is true, paints the caps lock indicator after the background. (WebCore::RenderTextControl::forwardEvent): When the control gets and loses focus, update the caps lock state. (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Added. Updates m_shouldDrawCapsLockIndicator, which is true if the field is a password field, and the frame is active, and the element is focused, and the caps lock is on. Causes a repaint when m_shouldDrawCapsLockIndicator changes state.
rendering/RenderTextControl.h: Added m_shouldDrawCapsLockIndicator.
rendering/RenderObject.h: (WebCore::RenderObject::capsLockStateMayHaveChanged): Added.

rendering/RenderTheme.h: (WebCore::RenderTheme::paintCapsLockIndicator): Added.
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCapsLockIndicator): Added. Calls wkDrawCapsLockIndicator.
rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintCapsLockIndicator): Added. Calls paintThemePart for the CapsLockPart.
rendering/RenderThemeSafari.h:

WebKit:

Reviewed by Darin.

WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields

WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field. (+[WebHTMLView _postFlagsChangedEvent:]): Added a comment with a Radar number for why this isn't just in flagsChanged. (-[WebHTMLView scrollWheel:]): Instead of calling the next responder explicitly, we can just call super, which will take care of this.

win:

Reviewed by Darin.

WebKitWin part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5110427> REGRESSION: Caps lock icon should show in password fields

WebView.cpp: (WebView::keyDown): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field.

1:20 PM Changeset in webkit [27263] by hyatt

16 edits in trunk/WebCore

Land support for implicit animation in CSS.

Reviewed by mitz, darin

css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseTransitionTimingFunction): (WebCore::CSSParser::parseTransitionProperty):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapTransitionDuration): (WebCore::CSSStyleSelector::mapTransitionRepeatCount): (WebCore::CSSStyleSelector::mapTransitionTimingFunction): (WebCore::CSSStyleSelector::mapTransitionProperty):
css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::x1): (WebCore::CSSTimingFunctionValue::y1): (WebCore::CSSTimingFunctionValue::x2): (WebCore::CSSTimingFunctionValue::y2):
dom/Element.cpp: (WebCore::Element::styleForRenderer): (WebCore::Element::createRenderer):
dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::setRenderStyle):
page/AnimationController.cpp: (WebCore::CurveData::CurveData): (WebCore::CurveData::sampleCurveX): (WebCore::CurveData::sampleCurveY): (WebCore::CurveData::sampleCurveDerivativeX): (WebCore::CurveData::solveCurveX): (WebCore::solveEpsilon): (WebCore::solveCubicBezierFunction): (WebCore::ImplicitAnimation::finished): (WebCore::CompositeImplicitAnimation::~CompositeImplicitAnimation): (WebCore::CompositeImplicitAnimation::hasAnimationForProperty): (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::reset): (WebCore::ImplicitAnimation::progress): (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate): (WebCore::CompositeImplicitAnimation::animate): (WebCore::CompositeImplicitAnimation::animating): (WebCore::CompositeImplicitAnimation::reset): (WebCore::AnimationControllerPrivate::hasImplicitAnimations): (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::~AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::get): (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateTimer): (WebCore::AnimationControllerPrivate::timerFired): (WebCore:::m_data): (WebCore::AnimationController::~AnimationController): (WebCore::AnimationController::cancelImplicitAnimations): (WebCore::AnimationController::updateImplicitAnimations): (WebCore::AnimationController::suspendAnimations): (WebCore::AnimationController::resumeAnimations):
page/AnimationController.h:
page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy):
rendering/RenderObject.cpp: (WebCore::RenderObject::setAnimatableStyle): (WebCore::RenderObject::destroy):
rendering/RenderObject.h:
rendering/RenderStyle.h: (WebCore::TimingFunction::TimingFunction): (WebCore::TimingFunction::operator==): (WebCore::TimingFunction::x1): (WebCore::TimingFunction::y1): (WebCore::TimingFunction::x2): (WebCore::TimingFunction::y2): (WebCore::TimingFunction::type): (WebCore::Transition::transitionProperty): (WebCore::Transition::setTransitionProperty): (WebCore::RenderStyle::initialTransitionProperty):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

11:41 AM Changeset in webkit [27262] by kmccullo

9 edits in trunk/WebKitTools

Reviewed by Adam.

Set the eol-style to native and made all the line endings the same so that I avoid messy diffs that show eol changes.

Drosera/win/ServerConnection.cpp: (ServerConnection::didParseSource): (ServerConnection::didEnterCallFrame): (ServerConnection::willExecuteStatement): (ServerConnection::willLeaveCallFrame): (ServerConnection::exceptionWasRaised):

11:15 AM Changeset in webkit [27261] by kmccullo

5 edits in trunk/WebKitTools

Reviewed by Adam.

Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the functionality that could not have existed previously without the new interfaces. (JSValueRefCreateWithBSTR): Added a helper function to easily convert from a BSTR to a JSValueRef. (DebuggerDocument::platformEvaluateScript): Implemented. (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): Implemented. (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
Drosera/win/HelperFunctions.h: Cleaned up some comments.
Drosera/win/ServerConnection.cpp: Added a helper function. (ServerConnection::getCallerFrame):
Drosera/win/ServerConnection.h: Added a helper function.

10:49 AM Changeset in webkit [27260] by aroben