⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 1, 2007:

11:51 PM Changeset in webkit [27375] by oliver
  • 4 edits in trunk

Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key

WebCore:

Reviewed by Alexey.

Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key

  • platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

WebKit/win:

Reviewed by Alexey.

Allow Shift, Ctrl, Alt, Meta and Capslock keys to be sent into WebCore.

  • WebView.cpp: (WebView::keyDown): (WebView::keyUp):
11:27 PM Changeset in webkit [27374] by mitz
  • 2 edits in trunk/WebKit

Reviewed by Oliver Hunt.

  • fix an assertion failure when Command-Tabbing out of Safari
  • WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to webCore.
5:14 PM Changeset in webkit [27373] by ggaren
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


In preparation for making List a simple stack-allocated Vector:

Removed all instances of List copying and/or assignment, and made List
inherit from Noncopyable.


Functions that used to return a List by copy now take List& out
parameters.


Layout tests and JS tests pass.

  • kjs/list.cpp: (KJS::List::slice): Replaced copyTail with a more generic slice alternative. (JavaScriptCore only calls slice(1), but WebCore calls slice(2)).

WebCore:

Reviewed by Maciej Stachowiak.


In preparation for making List a simple stack-allocated Vector:

Removed all instances of List copying, assignment, and/or storage.


Layout tests and JS tests pass.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Stores a Vector of protected JSValue*'s instead of a List now. Converts to List on the fly when calling the timer function. This is slightly less efficient, but the common case is 0-2 arguments, so it's no biggie.

(HTML iBench shows no regression. PLT does not use JS timers.)


(KJS::ScheduledAction::execute): Uses the more efficient and non-copying
List::slice now.
(KJS::ScheduledAction::ScheduledAction): ditto

  • bindings/objc/WebScriptObject.mm: (getListFromNSArray): Takes a List out parameter now, to avoid copying.
4:30 PM Changeset in webkit [27372] by oliver
  • 9 edits in trunk

Correct event behaviour on certain control keys

Reviewed by Geoff

Make sure we send the correct keyDown and keyUp events for the
control keys CapsLock, Shift, Ctrl, Alt, and Meta/Command, and
uses Windows key codes for the event keyCode.

4:10 PM Changeset in webkit [27371] by timothy@apple.com
  • 1 edit in trunk/WebCore/page/inspector/inspector.css

Forgot part of the patch for my last change.

4:00 PM Changeset in webkit [27370] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • page/inspector/inspector.css: Use the white disclosure triangles when a parent DOM element is sepected.
3:58 PM Changeset in webkit [27369] by justing
  • 5 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

<rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): No need to match style when pasting into a plaintext-only region, since when we build the fragment to insert from plain text, we don't put any style information on it, so it will automatically match style with no intervention.
  • editing/markup.cpp: (WebCore::createFragmentFromText): Place paragraphs into clones of the block being inserted into, instead of default paragraph elements, so that when inserted content will match the surrounding paragraph style. This was broken before, but I haven't added a layout test yet because there currently isn't a way to get only plain text onto the pasteboard in a layout test.

WebKit:

Reviewed by Oliver Hunt.


<rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply


No need to match style when pasting plain text, since the fragment we build for plain text
won't have any style information on it.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no longer a need to know whether this function chosePlaintext. (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView _documentFragmentFromPasteboard:]):
3:54 PM Changeset in webkit [27368] by kmccullo
  • 2 edits in trunk/WebKit/win
  • Fixed a build failure
  • WebEditorClient.cpp: (WebEditorClient::textWillBeDeletedInTextField):
3:31 PM Changeset in webkit [27367] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Add a releaseRef method to COMPtr which matches the behavior
of the method by the same name in PassRefPtr. This is in
preparation of adding autogenerated COM DOM bindings.

  • platform/win/COMPtr.h: (COMPtr::releaseRef):
3:28 PM Changeset in webkit [27366] by mitz
  • 2 edits
    4 moves in trunk

WebCore:

wx impl. for DragController and EventHandler interfaces.

Reviewed by Adam Roben.

  • page/wx: Added.
  • page/wx/DragControllerWx.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize):
  • page/wx/EventHandlerWx.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::createDraggingClipboard):

LayoutTests:

  • fix typo in test name
  • fast/repaint/layout-state-only-posiitoned.html: Removed.
  • fast/repaint/layout-state-only-positioned.html: Copied from fast/repaint/layout-state-only-posiitoned.html.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Removed.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Removed.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Removed.
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum.
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.png: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png.
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.txt: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt.
2:43 PM Changeset in webkit [27365] by kevino
  • 1 edit
    3 adds in trunk/WebCore

wx impl. for DragController and EventHandler interfaces.

Reviewed by Adam Roben.

2:36 PM Changeset in webkit [27364] by kevino
  • 1 edit
    2 adds in trunk/WebCore

Adding files for wx impl. of editing interfaces.

Reviewed by Adam Roben.

2:33 PM Changeset in webkit [27363] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Make implicit conversions from LPCSTRs and BSTRs to WebCore string
types possible in preparation of adding autogenerated COM DOM bindings.

  • platform/AtomicString.cpp: (WebCore::AtomicString::add):
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString):
  • platform/PlatformString.h:
  • platform/win/BString.cpp: (WebCore::BString::BString):
  • platform/win/BString.h:
2:15 PM Changeset in webkit [27362] by beidson@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Anders

Renamed a flag inside of SQLiteTransaction and added an accessor (for future work)

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::SQLiteTransaction): (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin): (WebCore::SQLiteTransaction::commit): (WebCore::SQLiteTransaction::rollback):
  • platform/sql/SQLiteTransaction.h: (WebCore::SQLiteTransaction::inProgress):
2:01 PM Changeset in webkit [27361] by aroben
  • 2 edits in trunk/WebCore

Remove all duplicate xcopy commands from WebCore's post-build step

Also add the /d option to the copy of platform/sql.

Rubberstamped by Sam.

  • WebCore.vcproj/WebCore.vcproj:
2:00 PM Changeset in webkit [27360] by aroben
  • 2 edits in trunk/WebKitTools

Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"

Reviewed by Sam.

  • Scripts/commit-log-editor: Show all the directories beneath the source root, instead of just the last one.
1:50 PM Changeset in webkit [27359] by ggaren
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15785
REGRESSION(r27344): Crash on load at finance.yahoo.com


Reverted a small portion of my last check-in. (The speedup and the List
removal are still there, though.)


ActivationImp needs to hold a pointer to its function, and mark that
pointer (rather than accessing its function through its ExecState, and
counting on the active scope to mark its function) because a closure
can cause an ActivationImp to outlive its ExecState along with any
active scope.

  • kjs/ExecState.cpp: (KJS::ExecState::ExecState):
  • kjs/function.cpp: (KJS::FunctionImp::~FunctionImp): (KJS::ActivationImp::ActivationImp):
  • kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):

Also made HashTable a little more crash-happy in debug builds, so
problems like this will show up earlier:


  • wtf/HashTable.h: (WTF::HashTable::~HashTable):

LayoutTests:

Reviewed by Maciej Stachowiak.


Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=15785
REGRESSION(r27344): Crash on load at finance.yahoo.com

  • fast/js/activation-object-function-lifetime-expected.txt: Added.
  • fast/js/activation-object-function-lifetime.html: Added.
1:35 PM Changeset in webkit [27358] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Rubber-stamped by Tim Hatcher.

  • misc/DatabaseExample.html: Speed up default close speed to .25s
1:28 PM Changeset in webkit [27357] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.

  • Don't show the close button on the notes unless hovering over the note.
  • Do transformation and fade when closing a note using the new transition properties.
  • misc/DatabaseExample.html:
1:23 PM Changeset in webkit [27356] by aroben
  • 3 edits in trunk/WebKit/win

Fix the parameter type of WebLocalizedString to match the UI_STRING macro

Reviewed by Sam.

  • WebLocalizableStrings.cpp: (WebLocalizedString): (WebLocalizedLPCTSTR):
  • WebLocalizableStrings.h:
12:01 PM Changeset in webkit [27355] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Add support for the animation of the -webkit-border-raduis properties.

  • page/AnimationController.cpp: (WebCore::blendFunc): Added for IntSize. (WebCore::ImplicitAnimation::animate): Added cases for border radius properties.
11:37 AM Changeset in webkit [27354] by alp
  • 2 edits in trunk/WebCore

2007-11-01 Alp Toker <​alp@atoker.com>

Reviewed by Mitz Pettel.

Fix an unbalanced save/restore.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
11:28 AM Changeset in webkit [27353] by hyatt
  • 2 edits in trunk/WebCore

Add support for the animation of the visibility property.

Reviewed by oliver, aroben

  • page/AnimationController.cpp: (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate):
10:13 AM Changeset in webkit [27352] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • Made COMPtr be able to be used by certain other templates, specifically HashSet.
  • platform/win/COMPtr.h: (WTF::):
8:30 AM Changeset in webkit [27351] by mitz
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/repaint/overflow-clip-subtree-layout.html

This patch does not address the bigger issue of doing a full relayout
of inline flows containing floats, but it addresses the problem on
aol.com, where the changes that trigger layout are confined to an
overflow area inside the float.

  • page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree): If the new and old layout roots are different but one descends from the other, make (or keep) the ancestor as the layout root.
  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Made boxes with overflow clipping and non-auto width and height relayout boundaries.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/repaint/overflow-clip-subtree-layout.html: Added.
  • platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum: Added.
  • platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
  • platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
8:01 AM Changeset in webkit [27350] by ap
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Fixed line endings that got confused in this file somehow.

  • platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::isAttachment):
2:58 AM Changeset in webkit [27349] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.


Addressed some of Darin's review comments.


Used perl -p, which is the shorthand while(<>) {}.


Made sure not to suppress bison's output.


Added line to removed bison_out.txt, since this script removes other
intermediate files, too.

  • DerivedSources.make:
2:30 AM Changeset in webkit [27348] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

2007-11-01 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam Roben.

Print out an error message when the Windows build fails
and provide guidance on how to find out what went wrong.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
2:30 AM Changeset in webkit [27347] by aroben
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Add some more tests that r27343 fixed

2:29 AM Changeset in webkit [27346] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-11-01 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Dave Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=15778
Malformed GIFs should not result in memory corruption.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::output_row): (GIFImageReader::read):
2:21 AM Changeset in webkit [27345] by ap
  • 4 edits in trunk

Rubber-stamped by Adam Roben.

Rolled out r27326 - debug CRT seems to cause no problems after all.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
1:36 AM Changeset in webkit [27344] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Removed List from ActivationImp, in preparation for making all lists
stack-allocated.


Tests pass.


1.0% speedup on SunSpider, presumably due to reduced List refcount thrash.

  • kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::createArgumentsObject):
  • kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):
1:28 AM Changeset in webkit [27343] by aroben
  • 3 edits in trunk/JavaScriptCore

Use jsNumberCell instead of jsNumber when converting double constants to JSValues

This fixes fast/js/math.html, which was suffering from a bug in MSVC.
It also gets rid of an MSVC warning that we previously had to silence.

Reviewed by Geoff.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn back on the "overflow in constant arithmetic" warning.
  • kjs/number_object.cpp: (NumberObjectImp::getValueProperty): Use jsNumberCell instead of jsNumber.

Oct 31, 2007:

11:50 PM Changeset in webkit [27342] by aroben
  • 1 edit
    4 adds in trunk/LayoutTests

Add Windows-specific results for window-properties

HTML Timed Media elements aren't implemented yet on Windows.

  • platform/win/fast/dom/Window/window-properties-expected.txt: Added.
11:20 PM Changeset in webkit [27341] by aroben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • kjs/ExecState.h:
10:05 PM Changeset in webkit [27340] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog entry.

10:02 PM Changeset in webkit [27339] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • shave some cycles off of local storage access for a 1% SunSpider speedup


Keep the LocalStorage pointer in the ExecState, not

  • kjs/ExecState.cpp: (KJS::ExecState::updateLocalStorage):
  • kjs/ExecState.h: (KJS::ExecState::localStorage):
  • kjs/nodes.cpp: (KJS::LocalVarAccessNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::PostIncLocalVarNode::evaluate): (KJS::PostDecLocalVarNode::evaluate): (KJS::LocalVarTypeOfNode::evaluate): (KJS::PreIncLocalVarNode::evaluate): (KJS::PreDecLocalVarNode::evaluate): (KJS::ReadModifyLocalVarNode::evaluate): (KJS::AssignLocalVarNode::evaluate): (KJS::FunctionBodyNode::processDeclarationsForFunctionCode):
8:51 PM Changeset in webkit [27338] by aroben
  • 3 edits
    2 adds in trunk

Fix a crash when parsing a cubic-bezier function

WebCore:

Fix a crash when parsing a cubic-bezier function

Reviewed by Hyatt.

Test: fast/css/parse-timing-function-crash.html

  • WebCore.vcproj/WebCore.vcproj:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue): Don't walk off the end of the ValueList.

LayoutTests:

New test for a crash when parsing a cubic-bezier function

Reviewed by Hyatt.

  • fast/css/parse-timing-function-crash-expected.txt: Added.
  • fast/css/parse-timing-function-crash.html: Added.
8:05 PM Changeset in webkit [27337] by hyatt
  • 2 edits in trunk/WebCore

Fix a merge error from when I applied my patch to ToT. A couple of lines should be part of an if.

  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::adjustTransitions):
6:22 PM Changeset in webkit [27336] by aroben
  • 4 edits in trunk/JavaScriptCore

Fix a crash on launch due to a static initializer race

We now use fast inline assembler spinlocks which can be statically
initialized at compile time.

As a side benefit, this speeds up SunSpider by 0.4%.

Reviewed by Oliver.

  • wtf/FastMalloc.cpp:
  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • wtf/TCSystemAlloc.cpp:
6:16 PM Changeset in webkit [27335] by andersca
  • 3 edits
    22 adds in trunk/WebCore

Reviewed by Sam.

Add new SQL callback interfaces and JS implementations of them.


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCustomSQLStatementCallback.cpp: Added. (WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback): (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.h: Added.
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: Added. (WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback): (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.h: Added.
  • bindings/js/JSCustomSQLTransactionCallback.cpp: Added. (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.h: Added.
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Added. (WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback): (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.h: Added.
  • storage/JSCustomSQLStatementCallback.h: Added.
  • storage/JSCustomSQLStatementErrorCallback.h: Added.
  • storage/JSCustomSQLTransactionCallback.h: Added.
  • storage/JSCustomSQLTransactionErrorCallback.h: Added.
  • storage/SQLStatementCallback.h: Added. (WebCore::SQLStatementCallback::~SQLStatementCallback):
  • storage/SQLStatementCallback.idl: Added.
  • storage/SQLStatementErrorCallback.h: Added. (WebCore::SQLStatementErrorCallback::~SQLStatementErrorCallback):
  • storage/SQLStatementErrorCallback.idl: Added.
  • storage/SQLTransaction.h: Added.
  • storage/SQLTransaction.idl: Added.
  • storage/SQLTransactionCallback.h: Added. (WebCore::SQLTransactionCallback::~SQLTransactionCallback):
  • storage/SQLTransactionCallback.idl: Added.
  • storage/SQLTransactionErrorCallback.h: Added. (WebCore::SQLTransactionErrorCallback::~SQLTransactionErrorCallback):
  • storage/SQLTransactionErrorCallback.idl: Added.
5:06 PM Changeset in webkit [27334] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

  • Corrected spelling.
  • wtf/HashTraits.h:
4:23 PM Changeset in webkit [27333] by justing
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Harrison.

<rdar://problem/5569741> Pasting content with a line break into a list can remove the list

  • editing/htmlediting.cpp: (WebCore::enclosingEmptyListItem): A single list item can contain multiple paragraphs, so if the incoming VisiblePosition is in an empty paragraph in a list item, that list item isn't necessarily empty.

LayoutTests:

Reviewed by Dave Harrison.

  • editing/execCommand/5569741.html: Added.
  • platform/mac/editing/execCommand/5569741-expected.checksum: Added.
  • platform/mac/editing/execCommand/5569741-expected.png: Added.
  • platform/mac/editing/execCommand/5569741-expected.txt: Added.
4:12 PM Changeset in webkit [27332] by timothy@apple.com
  • 6 edits in trunk/WebKit

Reviewed by John Sullivan.

Move the developer extras preference to WebPreferences.

  • WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO. (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey. (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
  • WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
  • WebView/WebView.mm: (+[WebView _developerExtrasEnabled]): Removed. (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
  • WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.
2:19 PM Changeset in webkit [27331] by hyatt
  • 2 edits in trunk/WebCore

Disable style sharing for animating styles.

Reviewed by mitzpettel

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
1:58 PM Changeset in webkit [27330] by mitz
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix intermediate length calculation
  • rendering/Length.h: (WebCore::Length::blend):
1:54 PM Changeset in webkit [27329] by antti
  • 1 edit
    10 deletes in trunk/LayoutTests

Remove timing dependent, occasionally failing cue point tests.
Cue points will be replaced with cue ranges soon anyway.

  • media/video-cuepoint-pause-expected.txt: Removed.
  • media/video-cuepoint-remove-multiple-expected.txt: Removed.
  • media/video-cuepoint-multiple-expected.txt: Removed.
  • media/video-cuepoint-remove-expected.txt: Removed.
  • media/video-cuepoint-pause.html: Removed.
  • media/video-cuepoint-remove-multiple.html: Removed.
  • media/video-cuepoint-multiple.html: Removed.
  • media/video-cuepoint-remove.html: Removed.
  • media/video-cuepoint-add-expected.txt: Removed.
  • media/video-cuepoint-add.html: Removed.
1:07 PM Changeset in webkit [27328] by andersca
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Darin.

Add new SQLError implementation.


  • DerivedSources.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/SQLError.h: Added. (WebCore::SQLError::SQLError): (WebCore::SQLError::code): (WebCore::SQLError::message):
  • storage/SQLError.idl: Added.
11:46 AM Changeset in webkit [27327] by hyatt
  • 2 edits in trunk/WebCore

Change the initial value of transition-property to all. Change the initial value of
transition-duration to 0.

Reviewed by antti

  • rendering/RenderStyle.h: (WebCore::RenderStyle::initialTransitionDuration): (WebCore::RenderStyle::initialTransitionProperty):
11:33 AM Changeset in webkit [27326] by aroben
  • 4 edits in trunk

Switch the Debug configuration to using the non-debug CRT

WebKitTools:

Switch the Debug configuration to using the non-debug CRT

This matches WebKit.

Reviewed by Steve.

  • DumpRenderTree/win/DumpRenderTree.vcproj:

WebKit/win:

Switch the Debug configuration to using the non-debug CRT

The debug CRT conflicts with what Safari uses, which causes loading
problems.

Reviewed by Steve.

  • WebKit.vcproj/WebKit.vcproj:
9:23 AM Changeset in webkit [27325] by alp
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

The new Color must be marked valid.

8:16 AM Changeset in webkit [27324] by antti
  • 2 edits in trunk/WebKitTools

Reviewed by bdash.


Disable media tests when doing leak checking on Tiger.
They crash in QuickTime (rdar://problem/5537157).

  • Scripts/run-webkit-tests:
8:05 AM Changeset in webkit [27323] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-31 Mark Rowe <​mrowe@apple.com>

Further Gtk build fixage.

  • kjs/regexp_object.cpp:
7:59 AM Changeset in webkit [27322] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-31 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/regexp.h:
7:52 AM Changeset in webkit [27321] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Tweaked formatting of the ChangeLog a bit.

7:46 AM Changeset in webkit [27320] by darin
  • 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Speeds things up 0.4% according to SunSpider.

  • kjs/config.h: Define USE(PCRE16) instead of HAVE(PCREPOSIX), because this library doesn't use the real PCRE -- it uses its own PCRE that works on UTF-16.
  • kjs/regexp.h: Removed a few unused functions. Changed the ifdef. Use Noncopyable. Change the return value of match.
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Call pcre_compile2, for a slight speed boost. (KJS::RegExp::~RegExp): PCRE16 rather than PCREPOSIX. (KJS::RegExp::match): Change to return the position as an int and the ovector as a OwnArrayPtr<int> for efficiency and clearer storage management.
  • kjs/regexp_object.h: Change performMatch and arrayOfMatches to no longer require a result string.
  • kjs/regexp_object.cpp: (RegExpProtoFunc::callAsFunction): Update for new signature of performMatch. (RegExpObjectImp::performMatch): Change so it doesn't return a string. (RegExpObjectImp::arrayOfMatches): Simplify by unifying the handling of the main result with the backreferences; now it doesn't need to take a result parameter. (RegExpObjectImp::getBackref): Minor tweaks. (RegExpObjectImp::getLastParen): Ditto. (RegExpObjectImp::getLeftContext): Ditto. (RegExpObjectImp::getRightContext): Ditto. (RegExpObjectImp::getValueProperty): Change LastMatch case to call getBackref(0) so we don't need a separate getLastMatch function.
  • kjs/string_object.cpp: (KJS::replace): Update to use new performMatch, including merging the matched string section with the other substrings. (KJS::StringProtoFunc::callAsFunction): Update functions to use the new performMatch and match. Also change to use OwnArrayPtr.
4:42 AM Changeset in webkit [27319] by hausmann
  • 2 edits in trunk/WebCore

Build fix for non-Qt builds.

4:18 AM Changeset in webkit [27318] by hausmann
  • 2 edits in trunk/WebCore

Fix dependency path to header files of the public API of the Qt port.

4:15 AM Changeset in webkit [27317] by hausmann
  • 3 edits in trunk/WebCore
4:13 AM Changeset in webkit [27316] by hausmann
  • 2 edits in trunk/WebCore
  • QMimeData::removeData will be new in Qt4.4, don't use it for Qt4.3
  • Provide a bad fallback implementation to filter the format list.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

4:09 AM Changeset in webkit [27315] by hausmann
  • 2 edits in trunk/WebCore

add an entitiy resolver to QXmlStream.
Fixes fast/parser/entities-in-attributes.xhtml.

4:09 AM Changeset in webkit [27314] by hausmann
  • 5 edits
    2 deletes in trunk

Fixes in the XML tokenizer when using QXmlStream.

Use new functionality of QXmlStream in Qt 4.4 to simplify
the code (but keep the old code for now to still support Qt 4.3).

Add proper support for namespace handling when parsing into
a document fragment.

4:08 AM Changeset in webkit [27313] by hausmann
  • 4 edits in trunk/WebCore

add support for dragging images.

4:08 AM Changeset in webkit [27312] by hausmann
  • 7 edits in trunk

fix most of the issues I found with Clipboard and DnD.

4:08 AM Changeset in webkit [27311] by hausmann
  • 2 edits in trunk/WebKit/qt

QDrag objects need to be created on the heap.

4:08 AM Changeset in webkit [27310] by hausmann
  • 2 edits in trunk/WebKit/qt

a dragLeave event is not the same as cancelling a drag.

4:02 AM Changeset in webkit [27309] by oliver
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (qt buildfix)

  • kjs/nodes.h: include OwnPtr.h
3:54 AM Changeset in webkit [27308] by oliver
  • 5 edits in trunk/JavaScriptCore

Remove SourceCodeElement class and replaced with a Vector for a 0.8% gain on sunspider

Reviewed by Maciej

3:52 AM Changeset in webkit [27307] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Oliver hasn't changed his name to ChangeLog.

2:47 AM Changeset in webkit [27306] by bdash
  • 3 edits in trunk/WebCore

2007-10-30 Mark Rowe <​mrowe@apple.com>

Fix the Gtk and Qt builds by stubbing out PlatformKeyboardEvent::currentCapsLockState.

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState):
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState):
2:33 AM Changeset in webkit [27305] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-10-30 Mark Rowe <​mrowe@apple.com>

Build fix for non-Mac ports.

  • kjs/property_map.cpp:
2:17 AM Changeset in webkit [27304] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.


  • fix builds
  • kjs/property_map.cpp: Include HashTable.h the right way.
1:29 AM Changeset in webkit [27303] by ap
  • 5 edits
    3 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11001
WebKit doesn't support RegExp.compile method

Test: fast/js/regexp-compile.html

  • kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): (RegExpProtoFunc::callAsFunction):
  • kjs/regexp_object.h: (KJS::RegExpProtoFunc::): Added RegExp.compile.
  • tests/mozilla/expected.html: js1_2/regexp/compile.js now passes.
1:22 AM Changeset in webkit [27302] by ap
  • 5 edits in trunk

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=15762
XSLStylesheet loads subresources from a wrong URL

Covered by corrected existing tests.

  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString): Pass stylesheet URL, not the document one.
1:22 AM Changeset in webkit [27301] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by ChangeLog.


  • get rid of integer divide in PropertyMap and HashTable for 1% SunSpider speedup


Integer divide sucks. Fortunately, a bunch of shifts and XORs
biased towards the high bits is sufficient to provide a good
double hash. Besides the SunSpider win, I used the dump statistics
mode for both to verify that collisions did not increase and that
the longest collision chain is not any longer.

  • kjs/property_map.cpp: (KJS::doubleHash): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::remove): (KJS::PropertyMap::checkConsistency):
  • wtf/HashTable.h: (WTF::doubleHash): (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):
1:20 AM Changeset in webkit [27300] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10818
String::append does 2 full copies instead of 1 (or zero!)

No change in functionality, thus no test.

  • platform/String.cpp: (WebCore::String::append): Rewrote to copy once. Also removed an ancient FIXME that doesn't seem to make any sense. Note that append() behavior doesn't match documented String behavior ("modifications to one instance will also modify all others"), but there are a lot of methods that don't.
12:54 AM Changeset in webkit [27299] by aroben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Add [JS]ProgressEvent.{cpp,h} files.
12:24 AM Changeset in webkit [27298] by aroben
  • 2 edits in trunk/JavaScriptCore

Build fix

  • kjs/collector.h: Make HeapType public.
12:20 AM Changeset in webkit [27297] by aroben
  • 4 edits in trunk/JavaScriptCore

Change ALWAYS_INLINE and WTF_PRIVATE_INLINE to use forceinline on Windows

Speeds up SunSpider by 0.4%.

Reviewed by Steve and Maciej.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable a warning during LTCG in release builds about double -> float conversion.
  • wtf/AlwaysInline.h:
  • wtf/FastMalloc.h:
12:19 AM Changeset in webkit [27296] by aroben
  • 2 edits in trunk/JavaScriptCore

Use GetCurrentThreadId instead of pthread_self in FastMalloc

Speeds up SunSpider by 0.3%.

Reviewed by Steve.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::InitTSD): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
12:19 AM Changeset in webkit [27295] by aroben
  • 4 edits in trunk/JavaScriptCore

Switch to a Win32 critical section implementation of spinlocks

Speeds up SunSpider by 0.4%.

Reviewed by Steve.

  • wtf/FastMalloc.cpp:
  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::TCMalloc_SpinLock): (TCMalloc_SpinLock::Init): (TCMalloc_SpinLock::Finalize): (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock):
  • wtf/TCSystemAlloc.cpp:
12:18 AM Changeset in webkit [27294] by aroben
  • 2 edits in trunk/JavaScriptCore

Fix Bug 15586: REGRESSION (r26759-r26785): Windows nightly builds crash with Safari 3 Public Beta

​http://bugs.webkit.org/show_bug.cgi?id=15586

Also fixes: <rdar://5565303> Cannot use regsvr32.exe to register WebKit.dll

Use Win32 TLS functions instead of declspec(thread), which breaks
delay-loading.

Reviewed by Steve.

  • wtf/FastMalloc.cpp: (WTF::getThreadHeap): (WTF::TCMalloc_ThreadCache::InitModule):
Note: See TracTimeline for information about the timeline view.