⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 2, 2007:

11:58 PM Changeset in webkit [27391] by ddkilzer
  • 1 edit
    1 add in trunk/WebKitTools

Script to sort "files(...);" sections in Xcode project.pbxproj files.

Rubber-stamped by Darin.

  • Scripts/sort-Xcode-project-file: Added.
9:17 PM Changeset in webkit [27390] by antti
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Adam.


Add video width/height DOM and content attributes from latest HTML5 draft.

Test: media/video-width-height.html

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): (WebCore::HTMLVideoElement::width): (WebCore::HTMLVideoElement::setWidth): (WebCore::HTMLVideoElement::height): (WebCore::HTMLVideoElement::setHeight):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:

LayoutTests:

Reviewed by Adam.


Test for video width/height DOM and content attributes.

  • media/video-width-height-expected.txt: Added.
  • media/video-width-height.html: Added.
8:24 PM Changeset in webkit [27389] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • add SourceElements as a typedef for Vector<RefPtr<StatementNode> >.
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::statementListPushFIFO): (KJS::statementListGetDeclarations): (KJS::statementListInitializeDeclarationStacks): (KJS::statementListInitializeVariableAccessStack): (KJS::statementListExecute): (KJS::BlockNode::BlockNode): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::ProgramNode::ProgramNode):
  • kjs/nodes.h: (KJS::CaseClauseNode::):
5:48 PM Changeset in webkit [27388] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • DerivedSources.make: Remove a few explicit filenames from some rules by using make variables a little more.
  • WebCore.LP64.exp: Fix typo, grammar.
5:46 PM Changeset in webkit [27387] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

The property map now has an array of indices and a separate array of
property map entries. This slightly slows down lookup because of a second
memory acess, but makes property maps smaller and faster to iterate in
functions like mark().

SunSpider says this is 1.2% faster, although it makes the bitwise-end test
more than 10% slower. To fix that we'll need to optimize global variable lookup.

  • kjs/property_map.cpp: (KJS::PropertyMapEntry::PropertyMapEntry): (KJS::PropertyMapHashTable::entries): (KJS::PropertyMapHashTable::allocationSize): (KJS::SavedProperties::SavedProperties): (KJS::SavedProperties::~SavedProperties): (KJS::PropertyMap::checkConsistency): (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::createTable): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::comparePropertyMapEntryIndices): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::restore):
  • kjs/property_map.h:
5:39 PM Changeset in webkit [27386] by antti
  • 4 edits in trunk/WebKitLibraries

Reviewed by Darin.


Update to add WKQTMovieViewSetDrawSynchronously

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
5:30 PM Changeset in webkit [27385] by Darin Adler
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • wtf/HashMap.h: Added take function. Simplistic implementation for now, but still does only one hash table lookup.
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put): Use take rather than a find followed by a remove.

WebCore:

Reviewed by Maciej.

  • use the new HashMap::take function where appropriate
  • bindings/js/kjs_binding.cpp: (KJS::addWrapper): Made an inline rather than a macro; inlines good, macros bad. (KJS::removeWrapper): Ditto. (KJS::removeWrappers): Ditto. (KJS::ScriptInterpreter::putDOMObject): Use the inline instead of the macro. (KJS::ScriptInterpreter::forgetDOMObject): Ditto. This involves using take instead of remove -- in theory ever so slightly less efficient, but I think it's fine. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Ditto. (KJS::ScriptInterpreter::putDOMNodeForDocument): Use the inline instead of the macro. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Use take instead of find/remove. (KJS::ScriptInterpreter::updateDOMNodeDocument): Use the inlines instead of the macros.
  • bindings/js/kjs_window.cpp: (KJS::Window::clearTimeout): Use take instead of find/remove.
  • bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::remove): Ditto.
  • page/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear): Ditto.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): Ditto. (WebCore::RenderBlock::setDesiredColumnCountAndWidth): Ditto.
  • rendering/RootInlineBox.cpp: Ditto.(WebCore::RootInlineBox::detachEllipsisBox): Ditto.
5:23 PM Changeset in webkit [27384] by antti
  • 7 edits in trunk

WebCore:

Reviewed by Darin.

Enable video composition.

  • WebCore.base.exp:
  • platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::createQTMovieView):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Darin.


Add method to enable video composition.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
5:20 PM Changeset in webkit [27383] by Darin Adler
  • 4 edits in trunk

SunSpider:

  • sunspider: Changed "--base" to "--set-baseline".

WebKitTools:

  • Scripts/run-sunspider: Changed "--base" to "--set-baseline".
5:15 PM Changeset in webkit [27382] by Darin Adler
  • 6 edits in trunk

SunSpider:

Reviewed by Maciej.

  • sunspider: Added a "--base" option that records the current test as a baseline. Moved the code to find the newest .mshark file into a function (since I needed to use it in the other script and I prefer to copy/paste a function).
  • sunspider-compare-results: Added logic to compare the baseline with the last run when you don't pass any parameters.

WebKitTools:

Reviewed by Maciej.

  • Scripts/run-sunspider: Pass the "--base" option through.
  • Scripts/sunspider-compare-results: Don't check the number of parameters; let the real script do that. Default configuration to Release to match run-sunspider so we don't end up building Debug just to compare results.
4:16 PM Changeset in webkit [27381] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix compiler warning "warning: suggest parentheses around && within
"

​http://bugs.webkit.org/show_bug.cgi?id=15764

  • kjs/value.h: (KJS::JSValue::isNumber): Add parentheses.
4:13 PM Changeset in webkit [27380] by Darin Adler
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.

Test: fast/forms/remove-radio-button-assert.html

  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removeFromForm): Added protected function to be used by derived classes that need to do the same sort of removal from form that's automatically done by the base class in certain circumstances.
  • html/HTMLGenericFormElement.h: Added removeFromForm.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): Call removeFromForm here so the element is removed before we destroy the HTMLInputElement part of this object. By the time we get to the base class's destructor it's too late. The problem is specific to radio buttons so we don't have to worry about other classes derived from HTMLGenericFormElement.

LayoutTests:

Reviewed by Mitz.

  • fast/forms/remove-radio-button-assert-expected.txt: Added.
  • fast/forms/remove-radio-button-assert.html: Added.
4:11 PM Changeset in webkit [27379] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent): Instead of asserting the frame loader is non-0, return false if it is 0.
4:08 PM Changeset in webkit [27378] by Darin Adler
  • 10 edits in trunk

WebCore:

Reviewed by Mitz.

  • fix <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted

Already covered by existing tests (that had incorrect results).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Return false to indicate failure when both URL and MIME type are empty. The old code would not attempt a load, but it would indicate success.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Remove non-helpful early exit for the case where there is no URL and no type. Returning early prevents the fallback code from running.

WebKit:

Reviewed by Mitz.

  • fix problem I ran into while doing some testing on Mac for <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted

I don't know how to reproduce this failure in DumpRenderTree, so there is no
regression test.

  • Plugins/WebNullPluginView.h: Removed some unneeded declarations, including the didSendError local variable. Instead we just set the error to nil once we've sent it.
  • Plugins/WebNullPluginView.mm: (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that the null plug-in image code is separate from the rest of the function and so that the whole thing is not inside an if statement. Also don't hold a reference to the DOM element if there is no error to report. (-[WebNullPluginView reportFailure]): Added. Does the actual delegate callback. Happens back at the top level of the run loop so it doesn't fire deep inside layout. Also wrote this so that it is guaranteed not to reenter and so that it can handle the case where the delegate destroys the world (including this object). NOTE: This is not a real, general solution to the problem of plug-ins that do work inside layout. We will need a more general fix that works for other plug-ins, and we'll track that with a separate bug report. (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code; changed so it just does a performSelector:afterDelay:0.

LayoutTests:

Reviewed by Mitz.

  • update tests affected by fix for <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted
  • dom/html/level2/html/AppletsCollection-expected.txt: The text "Nothing here!" renders now.
  • fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Some blank space renders now.
  • platform/mac/fast/invalid/residual-style-expected.txt: A font element renders now.
2:51 PM Changeset in webkit [27377] by alp
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Include Cairo headers properly

7:07 AM Changeset in webkit [27376] by mrowe@apple.com
  • 2 edits in trunk/WebKit

2007-11-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15780
Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates in the page coordinate system rather than the client area coordinate system.

Nov 1, 2007:

11:51 PM Changeset in webkit [27375] by oliver
  • 4 edits in trunk

Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key

WebCore:

Reviewed by Alexey.

Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key

  • platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

WebKit/win:

Reviewed by Alexey.

Allow Shift, Ctrl, Alt, Meta and Capslock keys to be sent into WebCore.

  • WebView.cpp: (WebView::keyDown): (WebView::keyUp):
11:27 PM Changeset in webkit [27374] by mitz
  • 2 edits in trunk/WebKit

Reviewed by Oliver Hunt.

  • fix an assertion failure when Command-Tabbing out of Safari
  • WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to webCore.
5:14 PM Changeset in webkit [27373] by ggaren
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


In preparation for making List a simple stack-allocated Vector:

Removed all instances of List copying and/or assignment, and made List
inherit from Noncopyable.


Functions that used to return a List by copy now take List& out
parameters.


Layout tests and JS tests pass.

  • kjs/list.cpp: (KJS::List::slice): Replaced copyTail with a more generic slice alternative. (JavaScriptCore only calls slice(1), but WebCore calls slice(2)).

WebCore:

Reviewed by Maciej Stachowiak.


In preparation for making List a simple stack-allocated Vector:

Removed all instances of List copying, assignment, and/or storage.


Layout tests and JS tests pass.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Stores a Vector of protected JSValue*'s instead of a List now. Converts to List on the fly when calling the timer function. This is slightly less efficient, but the common case is 0-2 arguments, so it's no biggie.

(HTML iBench shows no regression. PLT does not use JS timers.)


(KJS::ScheduledAction::execute): Uses the more efficient and non-copying
List::slice now.
(KJS::ScheduledAction::ScheduledAction): ditto

  • bindings/objc/WebScriptObject.mm: (getListFromNSArray): Takes a List out parameter now, to avoid copying.
4:30 PM Changeset in webkit [27372] by oliver
  • 9 edits in trunk

Correct event behaviour on certain control keys

Reviewed by Geoff

Make sure we send the correct keyDown and keyUp events for the
control keys CapsLock, Shift, Ctrl, Alt, and Meta/Command, and
uses Windows key codes for the event keyCode.

4:10 PM Changeset in webkit [27371] by timothy@apple.com
  • 1 edit in trunk/WebCore/page/inspector/inspector.css

Forgot part of the patch for my last change.

4:00 PM Changeset in webkit [27370] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • page/inspector/inspector.css: Use the white disclosure triangles when a parent DOM element is sepected.
3:58 PM Changeset in webkit [27369] by justing
  • 5 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

<rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): No need to match style when pasting into a plaintext-only region, since when we build the fragment to insert from plain text, we don't put any style information on it, so it will automatically match style with no intervention.
  • editing/markup.cpp: (WebCore::createFragmentFromText): Place paragraphs into clones of the block being inserted into, instead of default paragraph elements, so that when inserted content will match the surrounding paragraph style. This was broken before, but I haven't added a layout test yet because there currently isn't a way to get only plain text onto the pasteboard in a layout test.

WebKit:

Reviewed by Oliver Hunt.


<rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply


No need to match style when pasting plain text, since the fragment we build for plain text
won't have any style information on it.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no longer a need to know whether this function chosePlaintext. (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView _documentFragmentFromPasteboard:]):
3:54 PM Changeset in webkit [27368] by kmccullo
  • 2 edits in trunk/WebKit/win
  • Fixed a build failure
  • WebEditorClient.cpp: (WebEditorClient::textWillBeDeletedInTextField):
3:31 PM Changeset in webkit [27367] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Add a releaseRef method to COMPtr which matches the behavior
of the method by the same name in PassRefPtr. This is in
preparation of adding autogenerated COM DOM bindings.

  • platform/win/COMPtr.h: (COMPtr::releaseRef):
3:28 PM Changeset in webkit [27366] by mitz
  • 2 edits
    4 moves in trunk

WebCore:

wx impl. for DragController and EventHandler interfaces.

Reviewed by Adam Roben.

  • page/wx: Added.
  • page/wx/DragControllerWx.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize):
  • page/wx/EventHandlerWx.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::createDraggingClipboard):

LayoutTests:

  • fix typo in test name
  • fast/repaint/layout-state-only-posiitoned.html: Removed.
  • fast/repaint/layout-state-only-positioned.html: Copied from fast/repaint/layout-state-only-posiitoned.html.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Removed.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Removed.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Removed.
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum.
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.png: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png.
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.txt: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt.
2:43 PM Changeset in webkit [27365] by kevino
  • 1 edit
    3 adds in trunk/WebCore

wx impl. for DragController and EventHandler interfaces.

Reviewed by Adam Roben.

2:36 PM Changeset in webkit [27364] by kevino
  • 1 edit
    2 adds in trunk/WebCore

Adding files for wx impl. of editing interfaces.

Reviewed by Adam Roben.

2:33 PM Changeset in webkit [27363] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Make implicit conversions from LPCSTRs and BSTRs to WebCore string
types possible in preparation of adding autogenerated COM DOM bindings.

  • platform/AtomicString.cpp: (WebCore::AtomicString::add):
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString):
  • platform/PlatformString.h:
  • platform/win/BString.cpp: (WebCore::BString::BString):
  • platform/win/BString.h:
2:15 PM Changeset in webkit [27362] by beidson@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Anders

Renamed a flag inside of SQLiteTransaction and added an accessor (for future work)

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::SQLiteTransaction): (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin): (WebCore::SQLiteTransaction::commit): (WebCore::SQLiteTransaction::rollback):
  • platform/sql/SQLiteTransaction.h: (WebCore::SQLiteTransaction::inProgress):
2:01 PM Changeset in webkit [27361] by aroben
  • 2 edits in trunk/WebCore

Remove all duplicate xcopy commands from WebCore's post-build step

Also add the /d option to the copy of platform/sql.

Rubberstamped by Sam.

  • WebCore.vcproj/WebCore.vcproj:
2:00 PM Changeset in webkit [27360] by aroben
  • 2 edits in trunk/WebKitTools

Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"

Reviewed by Sam.

  • Scripts/commit-log-editor: Show all the directories beneath the source root, instead of just the last one.
1:50 PM Changeset in webkit [27359] by ggaren
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15785
REGRESSION(r27344): Crash on load at finance.yahoo.com


Reverted a small portion of my last check-in. (The speedup and the List
removal are still there, though.)


ActivationImp needs to hold a pointer to its function, and mark that
pointer (rather than accessing its function through its ExecState, and
counting on the active scope to mark its function) because a closure
can cause an ActivationImp to outlive its ExecState along with any
active scope.

  • kjs/ExecState.cpp: (KJS::ExecState::ExecState):
  • kjs/function.cpp: (KJS::FunctionImp::~FunctionImp): (KJS::ActivationImp::ActivationImp):
  • kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):

Also made HashTable a little more crash-happy in debug builds, so
problems like this will show up earlier:


  • wtf/HashTable.h: (WTF::HashTable::~HashTable):

LayoutTests:

Reviewed by Maciej Stachowiak.


Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=15785
REGRESSION(r27344): Crash on load at finance.yahoo.com

  • fast/js/activation-object-function-lifetime-expected.txt: Added.
  • fast/js/activation-object-function-lifetime.html: Added.
1:35 PM Changeset in webkit [27358] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Rubber-stamped by Tim Hatcher.

  • misc/DatabaseExample.html: Speed up default close speed to .25s
1:28 PM Changeset in webkit [27357] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.

  • Don't show the close button on the notes unless hovering over the note.
  • Do transformation and fade when closing a note using the new transition properties.
  • misc/DatabaseExample.html:
1:23 PM Changeset in webkit [27356] by aroben
  • 3 edits in trunk/WebKit/win

Fix the parameter type of WebLocalizedString to match the UI_STRING macro

Reviewed by Sam.

  • WebLocalizableStrings.cpp: (WebLocalizedString): (WebLocalizedLPCTSTR):
  • WebLocalizableStrings.h:
12:01 PM Changeset in webkit [27355] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Add support for the animation of the -webkit-border-raduis properties.

  • page/AnimationController.cpp: (WebCore::blendFunc): Added for IntSize. (WebCore::ImplicitAnimation::animate): Added cases for border radius properties.
11:37 AM Changeset in webkit [27354] by alp
  • 2 edits in trunk/WebCore

2007-11-01 Alp Toker <​alp@atoker.com>

Reviewed by Mitz Pettel.

Fix an unbalanced save/restore.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
11:28 AM Changeset in webkit [27353] by hyatt
  • 2 edits in trunk/WebCore

Add support for the animation of the visibility property.

Reviewed by oliver, aroben

  • page/AnimationController.cpp: (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate):
10:13 AM Changeset in webkit [27352] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • Made COMPtr be able to be used by certain other templates, specifically HashSet.
  • platform/win/COMPtr.h: (WTF::):
8:30 AM Changeset in webkit [27351] by mitz
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/repaint/overflow-clip-subtree-layout.html

This patch does not address the bigger issue of doing a full relayout
of inline flows containing floats, but it addresses the problem on
aol.com, where the changes that trigger layout are confined to an
overflow area inside the float.

  • page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree): If the new and old layout roots are different but one descends from the other, make (or keep) the ancestor as the layout root.
  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Made boxes with overflow clipping and non-auto width and height relayout boundaries.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/repaint/overflow-clip-subtree-layout.html: Added.
  • platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum: Added.
  • platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
  • platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
8:01 AM Changeset in webkit [27350] by ap
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Fixed line endings that got confused in this file somehow.

  • platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::isAttachment):
2:58 AM Changeset in webkit [27349] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.


Addressed some of Darin's review comments.


Used perl -p, which is the shorthand while(<>) {}.


Made sure not to suppress bison's output.


Added line to removed bison_out.txt, since this script removes other
intermediate files, too.

  • DerivedSources.make:
2:30 AM Changeset in webkit [27348] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

2007-11-01 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam Roben.

Print out an error message when the Windows build fails
and provide guidance on how to find out what went wrong.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
2:30 AM Changeset in webkit [27347] by aroben
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Add some more tests that r27343 fixed

2:29 AM Changeset in webkit [27346] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-11-01 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Dave Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=15778
Malformed GIFs should not result in memory corruption.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::output_row): (GIFImageReader::read):
2:21 AM Changeset in webkit [27345] by ap
  • 4 edits in trunk

Rubber-stamped by Adam Roben.

Rolled out r27326 - debug CRT seems to cause no problems after all.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
1:36 AM Changeset in webkit [27344] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Removed List from ActivationImp, in preparation for making all lists
stack-allocated.


Tests pass.


1.0% speedup on SunSpider, presumably due to reduced List refcount thrash.

  • kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::createArgumentsObject):
  • kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):
1:28 AM Changeset in webkit [27343] by aroben
  • 3 edits in trunk/JavaScriptCore

Use jsNumberCell instead of jsNumber when converting double constants to JSValues

This fixes fast/js/math.html, which was suffering from a bug in MSVC.
It also gets rid of an MSVC warning that we previously had to silence.

Reviewed by Geoff.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn back on the "overflow in constant arithmetic" warning.
  • kjs/number_object.cpp: (NumberObjectImp::getValueProperty): Use jsNumberCell instead of jsNumber.
Note: See TracTimeline for information about the timeline view.