⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 3, 2007:

11:18 PM Changeset in webkit [27420] by Darin Adler
  • 7 edits
    4 deletes in trunk/JavaScriptCore
  • fix non-Mac builds; remove some more unused PCRE stuff
  • pcre/pcre_compile.c: (compile_branch): Removed branch chain and some unused ESC values. (compile_regex): Ditto. (jsRegExpCompile): Ditto.
  • pcre/pcre_exec.c: (match): Removed unused branch targets. Don't use macros any more. (jsRegExpExecute): More of the same.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update for removed files.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • pcre/pcre.pri: Ditto.
  • pcre/MERGING: Removed.
  • pcre/pcre_fullinfo.c: Removed.
  • pcre/pcre_get.c: Removed.
  • pcre/pcre_internal.h:
  • pcre/ucp.h: Removed.
10:22 PM Changeset in webkit [27419] by Darin Adler
  • 24 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

A first step toward removing the PCRE features we don't use.
This gives a 0.8% speedup on SunSpider, and a 6.5% speedup on
the SunSpider regular expression test.

Replaced the public interface with one that doesn't use the
name PCRE. Removed code we don't need for JavaScript and various
configurations we don't use. This is in preparation for still
more changes in the future. We'll probably switch to C++ and
make some even more significant changes to the regexp engine
to get some additional speed.

There's probably additional unused stuff that I haven't
deleted yet.

This does mean that our PCRE is now a fork, but I think that's
not really a big deal.

  • JavaScriptCore.exp: Remove the 5 old entry points and add the 3 new entry points for WebCore's direct use of the regular expression engine.
  • kjs/config.h: Remove the USE(PCRE16) define. I decided to flip its sense and now there's a USE(POSIX_REGEX) instead, which should probably not be set by anyone. Maybe later we'll just get rid of it altogether.
  • kjs/regexp.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Switch to new jsRegExp function names and defines. Cut down on the number of functions used. (KJS::RegExp::~RegExp): Ditto. (KJS::RegExp::match): Ditto.
  • pcre/dftables.c: (main): Get rid of ctype_letter and ctype_meta, which are unused.
  • pcre/pcre-config.h: Get rid of EBCIDIC, PCRE_DATA_SCOPE, const, size_t, HAVE_STRERROR, HAVE_MEMMOVE, HAVE_BCOPY, NEWLINE, POSIX_MALLOC_THRESHOLD, NO_RECURSE, SUPPORT_UCP, SUPPORT_UTF8, and JAVASCRIPT. These are all no longer configurable in our copy of the library.
  • pcre/pcre.h: Remove the macro-based kjs prefix hack, the PCRE version macros, PCRE_UTF16, the code to set up PCRE_DATA_SCOPE, the include of <stdlib.h>, and most of the constants and functions defined in this header. Changed the naming scheme to use a JSRegExp prefix rather than a pcre prefix. In the future, we'll probably change this to be a C++ header.
  • pcre/pcre_compile.c: Removed all unused code branches, including many whole functions and various byte codes. Kept changes outside of removal to a minimum. (check_escape): (first_significant_code): (find_fixedlength): (find_recurse): (could_be_empty_branch): (compile_branch): (compile_regex): (is_anchored): (is_startline): (find_firstassertedchar): (jsRegExpCompile): Renamed from pcre_compile2 and changed the parameters around a bit. (jsRegExpFree): Added.
  • pcre/pcre_exec.c: Removed many unused opcodes and variables. Also started tearing down the NO_RECURSE mechanism since it's now the default. In some cases there were things in the explicit frame that could be turned into plain old local variables and other small like optimizations. (pchars): (match_ref): (match): Changed parameters quite a bit since it's now not used recursively. (jsRegExpExecute): Renamed from pcre_exec.
  • pcre/pcre_internal.h: Get rid of PCRE_DEFINITION, PCRE_SPTR, PCRE_IMS, PCRE_ICHANGED, PCRE_NOPARTIAL, PCRE_STUDY_MAPPED, PUBLIC_OPTIONS, PUBLIC_EXEC_OPTIONS, PUBLIC_DFA_EXEC_OPTIONS, PUBLIC_STUDY_OPTIONS, MAGIC_NUMBER, 16 of the opcodes, _pcre_utt, _pcre_utt_size, _pcre_try_flipped, _pcre_ucp_findprop, and _pcre_valid_utf8. Also moved pcre_malloc and pcre_free here.
  • pcre/pcre_maketables.c: Changed to only compile in dftables. Also got rid of many of the tables that we don't use.
  • pcre/pcre_tables.c: Removed the unused Unicode property tables.
  • pcre/pcre_ucp_searchfuncs.c: Removed everything except for _pcre_ucp_othercase.
  • pcre/pcre_xclass.c: (_pcre_xclass): Removed uneeded support for classes based on Unicode properties.
  • wtf/FastMallocPCRE.cpp: Removed unused bits. It would be good to eliminate this completely, but we need the regular expression code to be C++ first.
  • pcre/pcre_fullinfo.c:
  • pcre/pcre_get.c:
  • pcre/ucp.h: Files that are no longer needed. I didn't remove them with this check-in, because I didn't want to modify all the project files.

WebCore:

Reviewed by Maciej.

  • page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
  • page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement): Remove use of ":digit:" syntax. This hasn't worked for some time. Use "\d" instead.
  • platform/RegularExpression.h: Remove the unused cap function. We can add it back later if we find we need it.
  • platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Update for JavaScriptCore regular expression entry point changes. (WebCore::RegularExpression::Private::~Private): Ditto. (WebCore::RegularExpression::match): Remove the code to set PCRE_NOTBOL. This means that regular expressions with metacharactesr like in them won't work any more with non-whole-string searches, but we don't use any regular expressions like that.
10:15 PM Changeset in webkit [27418] by kevino
  • 2 edits in trunk/WebCore

Update the link stubs to match the current build, and fix coding style issues.

Reviewed by Mark Rowe.

9:17 PM Changeset in webkit [27417] by weinig@apple.com
  • 2 edits in trunk/JavaScriptGlue

Build-fix.

  • UserObjectImp.cpp:
8:37 PM Changeset in webkit [27416] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.


  • remove NaN check from JSImmediate::fromDouble for 0.5% SunSpider speedup

It turns out that doing this check costs more than it saves.


  • kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble):
7:21 PM Changeset in webkit [27415] by kevino
  • 1 edit
    3 adds in trunk/WebCore

wx <-> WebKit conversions for IntPoint, IntRect and FloatRect

Reviewed by Mark Rowe.

7:05 PM Changeset in webkit [27414] by kevino
  • 1 edit
    3 adds in trunk/WebCore

wx <-> WebKit data type conversions for Pen and Color.

Reviewed by Darin Adler.

6:08 PM Changeset in webkit [27413] by weinig@apple.com
  • 31 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.

  • API/JSCallbackConstructor.cpp: (KJS::):
  • API/JSCallbackFunction.cpp: (KJS::):
  • API/JSCallbackObject.cpp: (KJS::):
  • bindings/objc/objc_runtime.mm:
  • bindings/runtime_array.cpp:
  • bindings/runtime_object.cpp:
  • kjs/array_instance.cpp: (KJS::):
  • kjs/array_object.cpp: (KJS::):
  • kjs/bool_object.cpp:
  • kjs/date_object.cpp: (KJS::):
  • kjs/error_object.cpp:
  • kjs/function.cpp: (KJS::):
  • kjs/internal.cpp: (KJS::):
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/number_object.cpp:
  • kjs/object.h:
  • kjs/regexp_object.cpp:
  • kjs/string_object.cpp: (KJS::):

WebCore:

Reviewed by Oliver.

Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.

  • bindings/js/JSDOMExceptionConstructor.cpp: (WebCore::):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::):
  • bindings/js/JSXSLTProcessor.cpp: (KJS::):
  • bindings/js/kjs_css.cpp: (WebCore::):
  • bindings/js/kjs_events.cpp: (WebCore::):
  • bindings/js/kjs_navigator.cpp: (KJS::):
  • bindings/js/kjs_window.cpp: (KJS::):
  • bindings/scripts/CodeGeneratorJS.pm:
4:52 PM Changeset in webkit [27412] by kmccullo
  • 2 edits in trunk/JavaScriptCore
  • Updated testkjs results to make the build bots green until we can fix the tests that are failing. The new failures are in DST.
  • tests/mozilla/expected.html:
3:58 PM Changeset in webkit [27411] by mjs
  • 6 edits
    1 add in trunk/SunSpider

Reviewed by Darin.

  • Add compare mode and a description of the benchmark to the hosted version.
  • hosted/sunspider-results.html: Add compare mode - you can just paste in another results URL.
  • hosted/sunspider.html: Added intro text.
  • make-hosted: Copy new file.
  • resources/sunspider-compare-results.js: Made more reusable by putting the implementation in a function.
  • resources/sunspider-standalone-compare.js: Added. Calls the function in the way standalone mode expects.
  • sunspider-compare-results: Use sunspider-standalone-compare.js.
2:13 PM Changeset in webkit [27410] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • don't print the var twice for ForInNodes with a var declaration
  • kjs/nodes2string.cpp: (KJS::ForInNode::streamTo):
1:54 PM Changeset in webkit [27409] by mjs
  • 2 edits in trunk/WebKitTools

Rubber stamped by Adam.


  • Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:44 AM Changeset in webkit [27408] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of C-incompatible declaration.
9:42 AM Changeset in webkit [27407] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-03 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/nodes.cpp: Add missing include.
9:40 AM Changeset in webkit [27406] by Darin Adler
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

These changes cause us to match the JavaScript specification and pass the
fast/js/kde/encode_decode_uri.html test.

  • kjs/function.cpp: (KJS::encode): Call the UTF-8 string conversion in its new strict mode, throwing an exception if there are malformed UTF-16 surrogate pairs in the text.
  • kjs/ustring.h: Added a strict version of the UTF-8 string conversion.
  • kjs/ustring.cpp: (KJS::decodeUTF8Sequence): Removed code to disallow U+FFFE and U+FFFF; while those might be illegal in some sense, they aren't supposed to get any special handling in the place where this function is currently used. (KJS::UString::UTF8String): Added the strictness.

LayoutTests:

Reviewed by Maciej.

  • fast/js/kde/resources/encode_decode_uri.js: Rewrote the test to cover edges better, and use the should functions in a way that makes failures easier to understand.
  • fast/js/kde/encode_decode_uri-expected.txt: Updated.
9:28 AM Changeset in webkit [27405] by Darin Adler
  • 9 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Two or three fixes get 7 more of the Mozilla tests passing.
This gets us down from 61 failing tests to 54.

  • kjs/interpreter.h: (KJS::Interpreter::builtinRegExp): Made this inline and gave it a more specific type. Some day we should probably do that for all of these -- might even get a bit of a speed boost from it.
  • kjs/interpreter.cpp: Removed Interpreter::builtinRegExp now that it's inline in the header.
  • kjs/regexp_object.h:
  • kjs/regexp_object.cpp: (KJS::RegExpProtoFunc::callAsFunction): Moved test and exec out of the switch statement into the RegExpImp object, so they can be shared with RegExpImp::callAsFunction. (KJS::RegExpImp::match): Added. Common code used by both test and exec. (KJS::RegExpImp::test): Added. (KJS::RegExpImp::exec): Added. (KJS::RegExpImp::implementsCall): Added. (KJS::RegExpImp::callAsFunction): Added. (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): Initialize lastInput to null rather than empty string -- we take advantage of the difference in RegExpImp::match. (KJS::RegExpObjectImp::input): Added. No reason to go through hash tables just to get at a field like this.
  • pcre/pcre_compile.c: (check_escape): Changed the \u handling to match the JavaScript specification. If there are not 4 hex digits after the \u, then it's processed as if it wasn't an escape sequence at all.
  • pcre/pcre_internal.h: Added IS_NEWLINE, with the appropriate definition for JavaScript (4 specific Unicode values).
  • pcre/pcre_exec.c: (match): Changed all call sites to use IS_NEWLINE. (pcre_exec): Ditto.
  • tests/mozilla/expected.html: Updated to expect 7 more successful tests.
8:52 AM Changeset in webkit [27404] by alp
  • 2 edits in trunk/WebKit/gtk

Reviewed by Mark Rowe.

Restore correct double and triple click behaviour

We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
recent refactoring.

8:26 AM Changeset in webkit [27403] by kevino
  • 8 edits in trunk/WebCore

Build fixes to get wx impls. building on trunk.

Reviewed by Mark Rowe.

8:10 AM Changeset in webkit [27402] by ddkilzer
  • 14 edits in trunk

JavaScriptCore:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

JavaScriptGlue:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • WebCore.xcodeproj/project.pbxproj:
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:

WebKit:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • WebKit.xcodeproj/project.pbxproj:

WebKitTools:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
7:57 AM Changeset in webkit [27401] by kevino
  • 4 edits in trunk/WebCore

Coding style fixes for platform/wx files.

Reviewed by Mark Rowe.

7:33 AM Changeset in webkit [27400] by alp
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

Implement platform scrollbar static width/height getters

7:33 AM Changeset in webkit [27399] by alp
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Cast function pointers to gpointer.

7:33 AM Changeset in webkit [27398] by alp
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Adam Roben.

RenderThemeGtk implementation based on Mozilla's GTK+ style code

There is still work needed to complete this feature.

7:33 AM Changeset in webkit [27397] by alp
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Do not allow scrollbars to handle wheel events

We bubble the wheel event up so the parent can handle it instead.

7:32 AM Changeset in webkit [27396] by alp
  • 7 edits in trunk

Reviewed by Mark Rowe.

Frame scrolling and invalidation fixes

Make upward scroll events have a positive delta to match other ports.

Fix the invalidation rect offset for frames so that scrolling works properly.

Avoid allocating negative sizes to widgets to avoid GTK+ warnings.

Allow tabbing to all widgets and links.

Fix event returns, improving the focus situation and correcting scroll wheel
behavior.

6:35 AM Changeset in webkit [27395] by ddkilzer
  • 27 edits in trunk

WebCore:

LGPL'ed files contain incorrect FSF address
<​http://bugs.webkit.org/show_bug.cgi?id=14885>

Reviewed by NOBODY (follow-up fix).

  • bindings/js/JSSVGTransformListCustom.cpp:
  • ksvg2/svg/SVGException.idl:
  • ksvg2/svg/SVGTextPathElement.cpp:
  • ksvg2/svg/SVGTextPathElement.h:
  • ksvg2/svg/SVGViewSpec.cpp:
  • ksvg2/svg/SVGViewSpec.h:
  • platform/mac/FontCustomPlatformData.cpp:
  • platform/mac/FontCustomPlatformData.h:
  • platform/mac/FontPlatformDataMac.mm:
  • platform/win/FontCustomPlatformData.cpp:
  • platform/win/FontCustomPlatformData.h:
  • rendering/RenderSVGRoot.cpp:
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTextPath.cpp:
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderSVGTransformableContainer.h:
  • rendering/RenderSVGViewportContainer.cpp:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGCharacterLayoutInfo.cpp:
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGRenderSupport.cpp:
  • rendering/SVGRenderSupport.h:

WebKitSite:

LGPL'ed files contain incorrect FSF address
<​http://bugs.webkit.org/show_bug.cgi?id=14885>

Reviewed by NOBODY (follow-up fix).

  • blog/wp-includes/class-snoopy.php:
  • blog/wp-includes/gettext.php:
  • blog/wp-includes/streams.php:
3:09 AM Changeset in webkit [27394] by mjs
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • remove VarDeclListNode and simplify VarDeclNode evaluation for 0.4% SunSpider speedup
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::VarDeclNode::optimizeVariableAccess): (KJS::VarDeclNode::getDeclarations): (KJS::VarDeclNode::handleSlowCase): (KJS::VarDeclNode::evaluateSingle): (KJS::VarDeclNode::evaluate): (KJS::VarStatementNode::execute):
  • kjs/nodes.h: (KJS::VarDeclNode::): (KJS::VarStatementNode::):
  • kjs/nodes2string.cpp: (KJS::VarDeclNode::streamTo):
1:36 AM Changeset in webkit [27393] by ap
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15800
REGRESSION (r27303): RegExp leaks

  • kjs/regexp_object.h: (KJS::RegExpImp::setRegExp): (KJS::RegExpImp::regExp): (KJS::RegExpImp::classInfo):
  • kjs/regexp_object.cpp: (RegExpImp::RegExpImp): (RegExpImp::~RegExpImp): Renamed reg member variable to m_regExp, changed it to use OwnPtr.
12:27 AM Changeset in webkit [27392] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

Nov 2, 2007:

11:58 PM Changeset in webkit [27391] by ddkilzer
  • 1 edit
    1 add in trunk/WebKitTools

Script to sort "files(...);" sections in Xcode project.pbxproj files.

Rubber-stamped by Darin.

  • Scripts/sort-Xcode-project-file: Added.
9:17 PM Changeset in webkit [27390] by antti
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Adam.


Add video width/height DOM and content attributes from latest HTML5 draft.

Test: media/video-width-height.html

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): (WebCore::HTMLVideoElement::width): (WebCore::HTMLVideoElement::setWidth): (WebCore::HTMLVideoElement::height): (WebCore::HTMLVideoElement::setHeight):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:

LayoutTests:

Reviewed by Adam.


Test for video width/height DOM and content attributes.

  • media/video-width-height-expected.txt: Added.
  • media/video-width-height.html: Added.
8:24 PM Changeset in webkit [27389] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • add SourceElements as a typedef for Vector<RefPtr<StatementNode> >.
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::statementListPushFIFO): (KJS::statementListGetDeclarations): (KJS::statementListInitializeDeclarationStacks): (KJS::statementListInitializeVariableAccessStack): (KJS::statementListExecute): (KJS::BlockNode::BlockNode): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::ProgramNode::ProgramNode):
  • kjs/nodes.h: (KJS::CaseClauseNode::):
5:48 PM Changeset in webkit [27388] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • DerivedSources.make: Remove a few explicit filenames from some rules by using make variables a little more.
  • WebCore.LP64.exp: Fix typo, grammar.
5:46 PM Changeset in webkit [27387] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

The property map now has an array of indices and a separate array of
property map entries. This slightly slows down lookup because of a second
memory acess, but makes property maps smaller and faster to iterate in
functions like mark().

SunSpider says this is 1.2% faster, although it makes the bitwise-end test
more than 10% slower. To fix that we'll need to optimize global variable lookup.

  • kjs/property_map.cpp: (KJS::PropertyMapEntry::PropertyMapEntry): (KJS::PropertyMapHashTable::entries): (KJS::PropertyMapHashTable::allocationSize): (KJS::SavedProperties::SavedProperties): (KJS::SavedProperties::~SavedProperties): (KJS::PropertyMap::checkConsistency): (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::createTable): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::comparePropertyMapEntryIndices): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::restore):
  • kjs/property_map.h:
5:39 PM Changeset in webkit [27386] by antti
  • 4 edits in trunk/WebKitLibraries

Reviewed by Darin.


Update to add WKQTMovieViewSetDrawSynchronously

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
5:30 PM Changeset in webkit [27385] by Darin Adler
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • wtf/HashMap.h: Added take function. Simplistic implementation for now, but still does only one hash table lookup.
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put): Use take rather than a find followed by a remove.

WebCore:

Reviewed by Maciej.

  • use the new HashMap::take function where appropriate
  • bindings/js/kjs_binding.cpp: (KJS::addWrapper): Made an inline rather than a macro; inlines good, macros bad. (KJS::removeWrapper): Ditto. (KJS::removeWrappers): Ditto. (KJS::ScriptInterpreter::putDOMObject): Use the inline instead of the macro. (KJS::ScriptInterpreter::forgetDOMObject): Ditto. This involves using take instead of remove -- in theory ever so slightly less efficient, but I think it's fine. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Ditto. (KJS::ScriptInterpreter::putDOMNodeForDocument): Use the inline instead of the macro. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Use take instead of find/remove. (KJS::ScriptInterpreter::updateDOMNodeDocument): Use the inlines instead of the macros.
  • bindings/js/kjs_window.cpp: (KJS::Window::clearTimeout): Use take instead of find/remove.
  • bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::remove): Ditto.
  • page/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear): Ditto.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): Ditto. (WebCore::RenderBlock::setDesiredColumnCountAndWidth): Ditto.
  • rendering/RootInlineBox.cpp: Ditto.(WebCore::RootInlineBox::detachEllipsisBox): Ditto.
5:23 PM Changeset in webkit [27384] by antti
  • 7 edits in trunk

WebCore:

Reviewed by Darin.

Enable video composition.

  • WebCore.base.exp:
  • platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::createQTMovieView):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Darin.


Add method to enable video composition.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
5:20 PM Changeset in webkit [27383] by Darin Adler
  • 4 edits in trunk

SunSpider:

  • sunspider: Changed "--base" to "--set-baseline".

WebKitTools:

  • Scripts/run-sunspider: Changed "--base" to "--set-baseline".
5:15 PM Changeset in webkit [27382] by Darin Adler
  • 6 edits in trunk

SunSpider:

Reviewed by Maciej.

  • sunspider: Added a "--base" option that records the current test as a baseline. Moved the code to find the newest .mshark file into a function (since I needed to use it in the other script and I prefer to copy/paste a function).
  • sunspider-compare-results: Added logic to compare the baseline with the last run when you don't pass any parameters.

WebKitTools:

Reviewed by Maciej.

  • Scripts/run-sunspider: Pass the "--base" option through.
  • Scripts/sunspider-compare-results: Don't check the number of parameters; let the real script do that. Default configuration to Release to match run-sunspider so we don't end up building Debug just to compare results.
4:16 PM Changeset in webkit [27381] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix compiler warning "warning: suggest parentheses around && within
"

​http://bugs.webkit.org/show_bug.cgi?id=15764

  • kjs/value.h: (KJS::JSValue::isNumber): Add parentheses.
4:13 PM Changeset in webkit [27380] by Darin Adler
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.

Test: fast/forms/remove-radio-button-assert.html

  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removeFromForm): Added protected function to be used by derived classes that need to do the same sort of removal from form that's automatically done by the base class in certain circumstances.
  • html/HTMLGenericFormElement.h: Added removeFromForm.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): Call removeFromForm here so the element is removed before we destroy the HTMLInputElement part of this object. By the time we get to the base class's destructor it's too late. The problem is specific to radio buttons so we don't have to worry about other classes derived from HTMLGenericFormElement.

LayoutTests:

Reviewed by Mitz.

  • fast/forms/remove-radio-button-assert-expected.txt: Added.
  • fast/forms/remove-radio-button-assert.html: Added.
4:11 PM Changeset in webkit [27379] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent): Instead of asserting the frame loader is non-0, return false if it is 0.
4:08 PM Changeset in webkit [27378] by Darin Adler
  • 10 edits in trunk

WebCore:

Reviewed by Mitz.

  • fix <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted

Already covered by existing tests (that had incorrect results).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Return false to indicate failure when both URL and MIME type are empty. The old code would not attempt a load, but it would indicate success.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Remove non-helpful early exit for the case where there is no URL and no type. Returning early prevents the fallback code from running.

WebKit:

Reviewed by Mitz.

  • fix problem I ran into while doing some testing on Mac for <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted

I don't know how to reproduce this failure in DumpRenderTree, so there is no
regression test.

  • Plugins/WebNullPluginView.h: Removed some unneeded declarations, including the didSendError local variable. Instead we just set the error to nil once we've sent it.
  • Plugins/WebNullPluginView.mm: (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that the null plug-in image code is separate from the rest of the function and so that the whole thing is not inside an if statement. Also don't hold a reference to the DOM element if there is no error to report. (-[WebNullPluginView reportFailure]): Added. Does the actual delegate callback. Happens back at the top level of the run loop so it doesn't fire deep inside layout. Also wrote this so that it is guaranteed not to reenter and so that it can handle the case where the delegate destroys the world (including this object). NOTE: This is not a real, general solution to the problem of plug-ins that do work inside layout. We will need a more general fix that works for other plug-ins, and we'll track that with a separate bug report. (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code; changed so it just does a performSelector:afterDelay:0.

LayoutTests:

Reviewed by Mitz.

  • update tests affected by fix for <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted
  • dom/html/level2/html/AppletsCollection-expected.txt: The text "Nothing here!" renders now.
  • fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Some blank space renders now.
  • platform/mac/fast/invalid/residual-style-expected.txt: A font element renders now.
2:51 PM Changeset in webkit [27377] by alp
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Include Cairo headers properly

7:07 AM Changeset in webkit [27376] by mrowe@apple.com
  • 2 edits in trunk/WebKit

2007-11-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15780
Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates in the page coordinate system rather than the client area coordinate system.
Note: See TracTimeline for information about the timeline view.