⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 4, 2007:

10:38 PM Changeset in webkit [27434] by ddkilzer
  • 2 edits in trunk/WebKitTools

bisect-builds doesn't work with nightly build r19992 or newer on Leopard
<​http://bugs.webkit.org/show_bug.cgi?id=15830>

Reviewed by Timothy.

Restrict the range of nightly builds used by the bisect-builds script
based on the version of Safari and the version of Mac OS X being used.

Mac OS X 10.4: Safari 2.0: r11976 or newer
Mac OS X 10.4: Safari 3.0: r19992 or newer

Mac OS X 10.5: Safari 2.0: r19594 or newer
Mac OS X 10.5: Safari 3.0: r25124 or newer

  • Scripts/bisect-builds: (findMacOSXVersion): Added. (makeNightlyList): Added argument to provide version of Mac OS X. Restrict range of nightly builds based on Safari and Mac OS X versions.
5:37 PM Changeset in webkit [27433] by weinig@apple.com
  • 4 edits in trunk/WebCore

Rubber-stamped by Adam Roben.

Rename SecurityOrigin::allowsAccessFrom to SecurityOrigin::canAccess to
clear up ambiguity.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
  • platform/SecurityOrigin.h:
4:20 PM Changeset in webkit [27432] by timothy@apple.com
  • 1 edit
    29 adds in trunk/WebKitSite

Land the HTML Editing Toolbar demo from WWDC 2007.

  • demos: Added.
  • demos/editingToolbar: Added.
  • demos/editingToolbar/FancyToolbar.css: Added.
  • demos/editingToolbar/FancyToolbar.js: Added.
  • demos/editingToolbar/FancyToolbarImages: Added.
  • demos/editingToolbar/FancyToolbarImages/button.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/camera.png: Added.
  • demos/editingToolbar/FancyToolbarImages/link.png: Added.
  • demos/editingToolbar/FancyToolbarImages/textAlign.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Added.
  • demos/editingToolbar/content.html: Added.
  • demos/editingToolbar/images: Added.
  • demos/editingToolbar/images/safari.png: Added.
  • demos/editingToolbar/index.html: Added.
4:09 PM Changeset in webkit [27431] by timothy@apple.com
  • 7 edits
    3 adds in trunk/WebCore

Reviewed by Adam.

Bug 15834: There are many subtle bugs in the Styles pane of the Web Inspector
​http://bugs.webkit.org/show_bug.cgi?id=15834

  • Broke up DocumentPanel and added three SidebarPane sub-classes.
  • Fixed many Style pane bugs, including:
    • Poor handling of duplicate properties in the same rule. Some of this can't be fixed since we can't only get the "winning" value for duplicate properties. So we should only show one entry per unique property name.
    • Computed style does not show font shorthand sub-properties if 'font' was used.
    • Property priority was broken, the wrong properties were crossed out.
    • The 'border' shorthand shows null for the shorthand value.
    • Shorthands didn't show their priority (e.g. !important).
    • HSL and HTML hex colors didn't have preview swatch blocks.
    • Code refactoring, making it easier to reuse for console.log later.
  • page/inspector/DocumentPanel.js: Move sidebar pane code to three seperate classes in new files.
  • page/inspector/MetricsSidebarPane.js: Added.
  • page/inspector/Panel.js: Remove an InspectorController.log() call.
  • page/inspector/PropertiesSection.js: Add the section to the TreeOutline. So TreeElements can access properties on their section.
  • page/inspector/PropertiesSidebarPane.js: Added.
  • page/inspector/SidebarPane.js: Remove the explicit asignment of the onexpand and oncollapse to null. These were hiding prototypes.
  • page/inspector/StylesSidebarPane.js: Added.
  • page/inspector/inspector.html: Include the new script files.
  • page/inspector/treeoutline.js: If a null representedObject is passed in just use a empty object.
2:36 PM Changeset in webkit [27430] by kmccullo
  • 9 edits in trunk/WebKitTools

Reviewed by Maciej.

  • This patch involves several changes, all of them were noticed that they were needed by the work being done in WebKit to get Drosera and WebKit working together on Windows.
  • The changes are: 1) Added a debugger console for output messages. 2) Drosera now listens for the WebKit server (before, the server would have to be running before Drosera was started.) 3) Fixed a bug where the WebView started out as 0x0 pixels. 4) Fixed a bug when there is no scope. 5) Added the HTML, JS, and CSS to the project file to make them easy to find. 6) Made the ServerConnection functions virtual.
  • Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens for the WebKit server. (DebuggerClient::DebuggerClient): (DebuggerClient::~DebuggerClient): (DebuggerClient::didFinishLoadForFrame): (DebuggerClient::serverConnected): (DebuggerClient::attemptToCreateServerConnection):
  • Drosera/win/DebuggerClient.h: Ditto.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no scope. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
  • Drosera/win/Drosera.cpp: (_tWinMain): Added a console in debug for output messages. (Drosera::Drosera): Listen for server. (Drosera::initUI): The server now Initializes COM. (Drosera::serverConnected): Part of the listening for the server. (Drosera::attemptToCreateServerConnection): Ditto.
  • Drosera/win/Drosera.h: New interface for listening for the server.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS files to the VS project.
  • Drosera/win/ServerConnection.cpp: Part of listening for the server connection. (ServerConnection::ServerConnection): (ServerConnection::attemptToCreateServerConnection):
  • Drosera/win/ServerConnection.h: Ditto and virtualized the Interface methods. (ServerConnection::serverConnected):
2:30 PM Changeset in webkit [27429] by weinig
  • 1 edit in trunk/WebKitTools/FindSafari

Add svn:ignore for vcproj temp files under FindSafari.

12:27 PM Changeset in webkit [27428] by ap
  • 4 edits in trunk/WebKitTools

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15832
fast/dom/gc-10.html crashes when run alone

Check for !done before using objects that can be already deallocated.

  • DumpRenderTree/mac/EditingDelegate.mm: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
8:46 AM Changeset in webkit [27427] by ddkilzer
  • 2 edits in trunk/WebCore

Fix build when spaces appear in the WebKit source path.

Reviewed by Mark Rowe.

  • bindings/scripts/IDLParser.pm: Use safer open() method which lists arguments individually and prevents the need to work around spaces in the path.
8:13 AM Changeset in webkit [27426] by ddkilzer
  • 2 edits in trunk/WebKitSite

CIA has changed its hostname from cia.navi.cx to cia.vc
<​http://bugs.webkit.org/show_bug.cgi?id=15829>

Reviewed by Mitz.

  • contact.html: Updated links to CIA.
7:03 AM Changeset in webkit [27425] by alp
  • 2 edits in trunk/WebCore

2007-11-04 Alp Toker <​alp@atoker.com>

Reviewed by Alexey Proskuryakov.

Fix a crash when no clipboard text is available

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::plainText):
1:48 AM Changeset in webkit [27424] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-11-04 Mark Rowe <​mrowe@apple.com>

Build fix. Don't use Carbon.h as the prefix header as it triggers
warnings that would otherwise be suppressed due to it being a system header.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Nov 4, 2007:

1:58 AM Changeset in webkit [27423] by Darin Adler
  • 3 edits in trunk/SunSpider
  • hosted/sunspider.html: Tweaked formatting a bit.
1:28 AM Changeset in webkit [27422] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

SunSpider says it's 2.6% faster overall, 32.5% in the regular expression tests.

  • pcre/pcre_internal.h: Added OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
  • pcre/pcre_compile.c: (find_fixedlength): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC. Also added OP_NOT since there was no reason it should not be in here. (could_be_empty_branch): Ditto. (compile_branch): Streamlined all the single-character cases; there was a bit of duplicate code. Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC as needed. But in particular, compile to those opcodes when the single character match is ASCII. (find_firstassertedchar): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
  • pcre/pcre_exec.c: (match): Removed the "min", "minimize", and "op" fields from the matchframe, after I discovered that none of them needed to be saved and restored across recursive match calls. Also eliminated the ignored result field from the matchframe, since I discovered that rrc ("recursive result code") was already the exact same thing. Moved the handling of opcodes higher than OP_BRA into the default statement of the switch instead of doing them before the switch. This removes a branch from each iteration of the opcode interpreter, just as removal of "op" removed at least one store from each iteration. Last, but not least, add the OP_ASCII_CHAR and OP_ASCII_LETTER_NC functions. Neither can ever match a surrogate pair and the letter case can be handled efficiently.
12:54 AM Changeset in webkit [27421] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • pcre/pcre_exec.c: (match): Try to fix the Windows build by removing unreachable code.

Nov 3, 2007:

11:18 PM Changeset in webkit [27420] by Darin Adler
  • 7 edits
    4 deletes in trunk/JavaScriptCore
  • fix non-Mac builds; remove some more unused PCRE stuff
  • pcre/pcre_compile.c: (compile_branch): Removed branch chain and some unused ESC values. (compile_regex): Ditto. (jsRegExpCompile): Ditto.
  • pcre/pcre_exec.c: (match): Removed unused branch targets. Don't use macros any more. (jsRegExpExecute): More of the same.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update for removed files.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • pcre/pcre.pri: Ditto.
  • pcre/MERGING: Removed.
  • pcre/pcre_fullinfo.c: Removed.
  • pcre/pcre_get.c: Removed.
  • pcre/pcre_internal.h:
  • pcre/ucp.h: Removed.
10:22 PM Changeset in webkit [27419] by Darin Adler
  • 24 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

A first step toward removing the PCRE features we don't use.
This gives a 0.8% speedup on SunSpider, and a 6.5% speedup on
the SunSpider regular expression test.

Replaced the public interface with one that doesn't use the
name PCRE. Removed code we don't need for JavaScript and various
configurations we don't use. This is in preparation for still
more changes in the future. We'll probably switch to C++ and
make some even more significant changes to the regexp engine
to get some additional speed.

There's probably additional unused stuff that I haven't
deleted yet.

This does mean that our PCRE is now a fork, but I think that's
not really a big deal.

  • JavaScriptCore.exp: Remove the 5 old entry points and add the 3 new entry points for WebCore's direct use of the regular expression engine.
  • kjs/config.h: Remove the USE(PCRE16) define. I decided to flip its sense and now there's a USE(POSIX_REGEX) instead, which should probably not be set by anyone. Maybe later we'll just get rid of it altogether.
  • kjs/regexp.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Switch to new jsRegExp function names and defines. Cut down on the number of functions used. (KJS::RegExp::~RegExp): Ditto. (KJS::RegExp::match): Ditto.
  • pcre/dftables.c: (main): Get rid of ctype_letter and ctype_meta, which are unused.
  • pcre/pcre-config.h: Get rid of EBCIDIC, PCRE_DATA_SCOPE, const, size_t, HAVE_STRERROR, HAVE_MEMMOVE, HAVE_BCOPY, NEWLINE, POSIX_MALLOC_THRESHOLD, NO_RECURSE, SUPPORT_UCP, SUPPORT_UTF8, and JAVASCRIPT. These are all no longer configurable in our copy of the library.
  • pcre/pcre.h: Remove the macro-based kjs prefix hack, the PCRE version macros, PCRE_UTF16, the code to set up PCRE_DATA_SCOPE, the include of <stdlib.h>, and most of the constants and functions defined in this header. Changed the naming scheme to use a JSRegExp prefix rather than a pcre prefix. In the future, we'll probably change this to be a C++ header.
  • pcre/pcre_compile.c: Removed all unused code branches, including many whole functions and various byte codes. Kept changes outside of removal to a minimum. (check_escape): (first_significant_code): (find_fixedlength): (find_recurse): (could_be_empty_branch): (compile_branch): (compile_regex): (is_anchored): (is_startline): (find_firstassertedchar): (jsRegExpCompile): Renamed from pcre_compile2 and changed the parameters around a bit. (jsRegExpFree): Added.
  • pcre/pcre_exec.c: Removed many unused opcodes and variables. Also started tearing down the NO_RECURSE mechanism since it's now the default. In some cases there were things in the explicit frame that could be turned into plain old local variables and other small like optimizations. (pchars): (match_ref): (match): Changed parameters quite a bit since it's now not used recursively. (jsRegExpExecute): Renamed from pcre_exec.
  • pcre/pcre_internal.h: Get rid of PCRE_DEFINITION, PCRE_SPTR, PCRE_IMS, PCRE_ICHANGED, PCRE_NOPARTIAL, PCRE_STUDY_MAPPED, PUBLIC_OPTIONS, PUBLIC_EXEC_OPTIONS, PUBLIC_DFA_EXEC_OPTIONS, PUBLIC_STUDY_OPTIONS, MAGIC_NUMBER, 16 of the opcodes, _pcre_utt, _pcre_utt_size, _pcre_try_flipped, _pcre_ucp_findprop, and _pcre_valid_utf8. Also moved pcre_malloc and pcre_free here.
  • pcre/pcre_maketables.c: Changed to only compile in dftables. Also got rid of many of the tables that we don't use.
  • pcre/pcre_tables.c: Removed the unused Unicode property tables.
  • pcre/pcre_ucp_searchfuncs.c: Removed everything except for _pcre_ucp_othercase.
  • pcre/pcre_xclass.c: (_pcre_xclass): Removed uneeded support for classes based on Unicode properties.
  • wtf/FastMallocPCRE.cpp: Removed unused bits. It would be good to eliminate this completely, but we need the regular expression code to be C++ first.
  • pcre/pcre_fullinfo.c:
  • pcre/pcre_get.c:
  • pcre/ucp.h: Files that are no longer needed. I didn't remove them with this check-in, because I didn't want to modify all the project files.

WebCore:

Reviewed by Maciej.

  • page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
  • page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement): Remove use of ":digit:" syntax. This hasn't worked for some time. Use "\d" instead.
  • platform/RegularExpression.h: Remove the unused cap function. We can add it back later if we find we need it.
  • platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Update for JavaScriptCore regular expression entry point changes. (WebCore::RegularExpression::Private::~Private): Ditto. (WebCore::RegularExpression::match): Remove the code to set PCRE_NOTBOL. This means that regular expressions with metacharactesr like in them won't work any more with non-whole-string searches, but we don't use any regular expressions like that.
10:15 PM Changeset in webkit [27418] by kevino
  • 2 edits in trunk/WebCore

Update the link stubs to match the current build, and fix coding style issues.

Reviewed by Mark Rowe.

9:17 PM Changeset in webkit [27417] by weinig@apple.com
  • 2 edits in trunk/JavaScriptGlue

Build-fix.

  • UserObjectImp.cpp:
8:37 PM Changeset in webkit [27416] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.


  • remove NaN check from JSImmediate::fromDouble for 0.5% SunSpider speedup

It turns out that doing this check costs more than it saves.


  • kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble):
7:21 PM Changeset in webkit [27415] by kevino
  • 1 edit
    3 adds in trunk/WebCore

wx <-> WebKit conversions for IntPoint, IntRect and FloatRect

Reviewed by Mark Rowe.

7:05 PM Changeset in webkit [27414] by kevino
  • 1 edit
    3 adds in trunk/WebCore

wx <-> WebKit data type conversions for Pen and Color.

Reviewed by Darin Adler.

6:08 PM Changeset in webkit [27413] by weinig@apple.com
  • 31 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.

  • API/JSCallbackConstructor.cpp: (KJS::):
  • API/JSCallbackFunction.cpp: (KJS::):
  • API/JSCallbackObject.cpp: (KJS::):
  • bindings/objc/objc_runtime.mm:
  • bindings/runtime_array.cpp:
  • bindings/runtime_object.cpp:
  • kjs/array_instance.cpp: (KJS::):
  • kjs/array_object.cpp: (KJS::):
  • kjs/bool_object.cpp:
  • kjs/date_object.cpp: (KJS::):
  • kjs/error_object.cpp:
  • kjs/function.cpp: (KJS::):
  • kjs/internal.cpp: (KJS::):
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/number_object.cpp:
  • kjs/object.h:
  • kjs/regexp_object.cpp:
  • kjs/string_object.cpp: (KJS::):

WebCore:

Reviewed by Oliver.

Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.

  • bindings/js/JSDOMExceptionConstructor.cpp: (WebCore::):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::):
  • bindings/js/JSXSLTProcessor.cpp: (KJS::):
  • bindings/js/kjs_css.cpp: (WebCore::):
  • bindings/js/kjs_events.cpp: (WebCore::):
  • bindings/js/kjs_navigator.cpp: (KJS::):
  • bindings/js/kjs_window.cpp: (KJS::):
  • bindings/scripts/CodeGeneratorJS.pm:
4:52 PM Changeset in webkit [27412] by kmccullo
  • 2 edits in trunk/JavaScriptCore
  • Updated testkjs results to make the build bots green until we can fix the tests that are failing. The new failures are in DST.
  • tests/mozilla/expected.html:
3:58 PM Changeset in webkit [27411] by mjs
  • 6 edits
    1 add in trunk/SunSpider

Reviewed by Darin.

  • Add compare mode and a description of the benchmark to the hosted version.
  • hosted/sunspider-results.html: Add compare mode - you can just paste in another results URL.
  • hosted/sunspider.html: Added intro text.
  • make-hosted: Copy new file.
  • resources/sunspider-compare-results.js: Made more reusable by putting the implementation in a function.
  • resources/sunspider-standalone-compare.js: Added. Calls the function in the way standalone mode expects.
  • sunspider-compare-results: Use sunspider-standalone-compare.js.
2:13 PM Changeset in webkit [27410] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • don't print the var twice for ForInNodes with a var declaration
  • kjs/nodes2string.cpp: (KJS::ForInNode::streamTo):
1:54 PM Changeset in webkit [27409] by mjs
  • 2 edits in trunk/WebKitTools

Rubber stamped by Adam.


  • Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:44 AM Changeset in webkit [27408] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of C-incompatible declaration.
9:42 AM Changeset in webkit [27407] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-03 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/nodes.cpp: Add missing include.
9:40 AM Changeset in webkit [27406] by Darin Adler
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

These changes cause us to match the JavaScript specification and pass the
fast/js/kde/encode_decode_uri.html test.

  • kjs/function.cpp: (KJS::encode): Call the UTF-8 string conversion in its new strict mode, throwing an exception if there are malformed UTF-16 surrogate pairs in the text.
  • kjs/ustring.h: Added a strict version of the UTF-8 string conversion.
  • kjs/ustring.cpp: (KJS::decodeUTF8Sequence): Removed code to disallow U+FFFE and U+FFFF; while those might be illegal in some sense, they aren't supposed to get any special handling in the place where this function is currently used. (KJS::UString::UTF8String): Added the strictness.

LayoutTests:

Reviewed by Maciej.

  • fast/js/kde/resources/encode_decode_uri.js: Rewrote the test to cover edges better, and use the should functions in a way that makes failures easier to understand.
  • fast/js/kde/encode_decode_uri-expected.txt: Updated.
9:28 AM Changeset in webkit [27405] by Darin Adler
  • 9 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Two or three fixes get 7 more of the Mozilla tests passing.
This gets us down from 61 failing tests to 54.

  • kjs/interpreter.h: (KJS::Interpreter::builtinRegExp): Made this inline and gave it a more specific type. Some day we should probably do that for all of these -- might even get a bit of a speed boost from it.
  • kjs/interpreter.cpp: Removed Interpreter::builtinRegExp now that it's inline in the header.
  • kjs/regexp_object.h:
  • kjs/regexp_object.cpp: (KJS::RegExpProtoFunc::callAsFunction): Moved test and exec out of the switch statement into the RegExpImp object, so they can be shared with RegExpImp::callAsFunction. (KJS::RegExpImp::match): Added. Common code used by both test and exec. (KJS::RegExpImp::test): Added. (KJS::RegExpImp::exec): Added. (KJS::RegExpImp::implementsCall): Added. (KJS::RegExpImp::callAsFunction): Added. (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): Initialize lastInput to null rather than empty string -- we take advantage of the difference in RegExpImp::match. (KJS::RegExpObjectImp::input): Added. No reason to go through hash tables just to get at a field like this.
  • pcre/pcre_compile.c: (check_escape): Changed the \u handling to match the JavaScript specification. If there are not 4 hex digits after the \u, then it's processed as if it wasn't an escape sequence at all.
  • pcre/pcre_internal.h: Added IS_NEWLINE, with the appropriate definition for JavaScript (4 specific Unicode values).
  • pcre/pcre_exec.c: (match): Changed all call sites to use IS_NEWLINE. (pcre_exec): Ditto.
  • tests/mozilla/expected.html: Updated to expect 7 more successful tests.
8:52 AM Changeset in webkit [27404] by alp
  • 2 edits in trunk/WebKit/gtk

Reviewed by Mark Rowe.

Restore correct double and triple click behaviour

We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
recent refactoring.

8:26 AM Changeset in webkit [27403] by kevino
  • 8 edits in trunk/WebCore

Build fixes to get wx impls. building on trunk.

Reviewed by Mark Rowe.

8:10 AM Changeset in webkit [27402] by ddkilzer
  • 14 edits in trunk

JavaScriptCore:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

JavaScriptGlue:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • WebCore.xcodeproj/project.pbxproj:
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:

WebKit:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • WebKit.xcodeproj/project.pbxproj:

WebKitTools:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
7:57 AM Changeset in webkit [27401] by kevino
  • 4 edits in trunk/WebCore

Coding style fixes for platform/wx files.

Reviewed by Mark Rowe.

7:33 AM Changeset in webkit [27400] by alp
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

Implement platform scrollbar static width/height getters

7:33 AM Changeset in webkit [27399] by alp
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Cast function pointers to gpointer.

7:33 AM Changeset in webkit [27398] by alp
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Adam Roben.

RenderThemeGtk implementation based on Mozilla's GTK+ style code

There is still work needed to complete this feature.

7:33 AM Changeset in webkit [27397] by alp
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Do not allow scrollbars to handle wheel events

We bubble the wheel event up so the parent can handle it instead.

7:32 AM Changeset in webkit [27396] by alp
  • 7 edits in trunk

Reviewed by Mark Rowe.

Frame scrolling and invalidation fixes

Make upward scroll events have a positive delta to match other ports.

Fix the invalidation rect offset for frames so that scrolling works properly.

Avoid allocating negative sizes to widgets to avoid GTK+ warnings.

Allow tabbing to all widgets and links.

Fix event returns, improving the focus situation and correcting scroll wheel
behavior.

6:35 AM Changeset in webkit [27395] by ddkilzer
  • 27 edits in trunk

WebCore:

LGPL'ed files contain incorrect FSF address
<​http://bugs.webkit.org/show_bug.cgi?id=14885>

Reviewed by NOBODY (follow-up fix).

  • bindings/js/JSSVGTransformListCustom.cpp:
  • ksvg2/svg/SVGException.idl:
  • ksvg2/svg/SVGTextPathElement.cpp:
  • ksvg2/svg/SVGTextPathElement.h:
  • ksvg2/svg/SVGViewSpec.cpp:
  • ksvg2/svg/SVGViewSpec.h:
  • platform/mac/FontCustomPlatformData.cpp:
  • platform/mac/FontCustomPlatformData.h:
  • platform/mac/FontPlatformDataMac.mm:
  • platform/win/FontCustomPlatformData.cpp:
  • platform/win/FontCustomPlatformData.h:
  • rendering/RenderSVGRoot.cpp:
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTextPath.cpp:
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderSVGTransformableContainer.h:
  • rendering/RenderSVGViewportContainer.cpp:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGCharacterLayoutInfo.cpp:
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGRenderSupport.cpp:
  • rendering/SVGRenderSupport.h:

WebKitSite:

LGPL'ed files contain incorrect FSF address
<​http://bugs.webkit.org/show_bug.cgi?id=14885>

Reviewed by NOBODY (follow-up fix).

  • blog/wp-includes/class-snoopy.php:
  • blog/wp-includes/gettext.php:
  • blog/wp-includes/streams.php:
3:09 AM Changeset in webkit [27394] by mjs
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • remove VarDeclListNode and simplify VarDeclNode evaluation for 0.4% SunSpider speedup
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::VarDeclNode::optimizeVariableAccess): (KJS::VarDeclNode::getDeclarations): (KJS::VarDeclNode::handleSlowCase): (KJS::VarDeclNode::evaluateSingle): (KJS::VarDeclNode::evaluate): (KJS::VarStatementNode::execute):
  • kjs/nodes.h: (KJS::VarDeclNode::): (KJS::VarStatementNode::):
  • kjs/nodes2string.cpp: (KJS::VarDeclNode::streamTo):
1:36 AM Changeset in webkit [27393] by ap
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15800
REGRESSION (r27303): RegExp leaks

  • kjs/regexp_object.h: (KJS::RegExpImp::setRegExp): (KJS::RegExpImp::regExp): (KJS::RegExpImp::classInfo):
  • kjs/regexp_object.cpp: (RegExpImp::RegExpImp): (RegExpImp::~RegExpImp): Renamed reg member variable to m_regExp, changed it to use OwnPtr.
12:27 AM Changeset in webkit [27392] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

Note: See TracTimeline for information about the timeline view.