⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 5, 2007:

11:47 PM Changeset in webkit [27475] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Mac build fix.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::writeHelper):
11:30 PM Changeset in webkit [27474] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Mac build fix.

  • kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction):
11:20 PM Changeset in webkit [27473] by aroben
  • 3 edits in trunk/WebCore

Don't crash if SafariTheme can't be loaded

PlatformScrollBarSafari and RenderThemeSafari were not checking
whether SafariTheme was successfully loaded. All other uses of
SafariTheme already check this.

Reviewed by Steve.

  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paintButton): (WebCore::PlatformScrollbar::paintTrack): (WebCore::PlatformScrollbar::paintThumb):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::isControlStyled): (WebCore::RenderThemeSafari::paintCheckbox): (WebCore::RenderThemeSafari::paintRadio): (WebCore::RenderThemeSafari::paintButton): (WebCore::RenderThemeSafari::paintTextField): (WebCore::RenderThemeSafari::paintCapsLockIndicator): (WebCore::RenderThemeSafari::paintTextArea): (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintSliderThumb): (WebCore::RenderThemeSafari::paintSearchField): (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
11:20 PM Changeset in webkit [27472] by aroben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • kjs/list.h:
11:09 PM Changeset in webkit [27471] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Build fix. Add missing #include.

  • kjs/operations.cpp:
10:48 PM Changeset in webkit [27470] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Eric Seidel <​eric@webkit.org>

Reviewed by mjs.


Remove another call to toString(exec)


SunSpider claims this is a 0.5% speedup.

  • kjs/operations.cpp: (KJS::equal): remove another toString
10:39 PM Changeset in webkit [27469] by kevino
  • 1 edit
    6 adds in trunk/WebCore

Adding the rest of wx port's graphics impl.

Rubber-stamped by Maciej Stachowiak.

10:24 PM Changeset in webkit [27468] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Eric Seidel <​eric@webkit.org>

  • kjs/operations.cpp: (KJS::equal): correct broken change.
10:17 PM Changeset in webkit [27467] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Eric Seidel <​eric@webkit.org>

Reviewed by mjs.

Remove one more call to toString(exec).


SunSpider claims this is a 0.7% speedup.

  • kjs/operations.cpp: (KJS::equal): remove a call to toString()
9:52 PM Changeset in webkit [27466] by kevino
  • 11 edits
    4 adds in trunk/WebCore

wx port bug fixes and new files to get platform/wx building on trunk.

Rubber-stamped by Maciej Stachowiak.

9:43 PM Changeset in webkit [27465] by adele
  • 12 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5579999> Add poster attribute for video element

  • html/HTMLAttributeNames.in: Added poster attribute.
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Calls imageSourceAttributeName instead of having special cases for the different kinds of elements.
  • dom/Element.cpp: (WebCore::Element::imageSourceAttributeName): Added.
  • dom/Element.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::imageSourceAttributeName): Added.
  • html/HTMLObjectElement.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieNetworkStateChanged): Calls updatePosterImage when the network state is empty and when the first frame has been loaded.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::rendererIsNeeded): Made this inline. HTMLVideoElement now also implements this.
  • html/HTMLVideoElement.idl: Added case for poster attribute.
  • html/HTMLVideoElement.h: Added image loader and flag to keep track of whether or not the poster image should be shown.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): Initialize m_imageLoader and m_shouldShowPosterImage. (WebCore::HTMLVideoElement::rendererIsNeeded): Calls HTMLElement::rendererIsNeeded since HTMLMediaElements have renderer by default. (WebCore::HTMLVideoElement::createRenderer): Create a RenderImage or RenderVideo depending on whether or not the poster image should be shown. (WebCore::HTMLVideoElement::attach): Set up image loader and RenderImage if necessary. (WebCore::HTMLVideoElement::detach): Delete image loader if its no longer needed. (WebCore::HTMLVideoElement::parseMappedAttribute): Added case to process poster attribute. (WebCore::HTMLVideoElement::poster): Added getter for poster attribute. (WebCore::HTMLVideoElement::setPoster): Added setter for poster attribute. (WebCore::HTMLVideoElement::isURLAttribute): Added. (WebCore::HTMLVideoElement::imageSourceAttributeName): Added. (WebCore::HTMLVideoElement::updatePosterImage): Added. Updates m_shouldShowPosterImage and if its changed, detaches and attaches so the renderer is correct.
9:39 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
9:25 PM Changeset in webkit [27464] by aroben
  • 5 edits in trunk

Fix <rdar://5563572> SVG image support is turned off

WebCore:

Fix <rdar://5563572> SVG image support is turned off

Turned on SVG images for all platforms.

Reviewed by Eric.

  • WebCore.vcproj/WebCore.vcproj: Added SVGImage.{cpp,h}
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Removed platform checks for SVGImage.

LayoutTests:

Remove a now-passing test from the Windows Skipped file

Reviewed by Eric.

  • platform/win/Skipped:
8:55 PM Changeset in webkit [27463] by eseidel
  • 2 edits in trunk/WebCore

Fix spelling errors in ChangeLogs, no review

8:43 PM Changeset in webkit [27462] by antti
  • 2 edits in trunk/WebCore

Reviewed by Darin.

QTMovieView can generate callbacks during paint. This can lead to crashes.


Delay callbacks so they get handled after painting is completed. No test case,
I don't know how to reliably reproduce this.

  • platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::paint): (-[WebCoreMovieObserver initWithCallback:WebCore::]): (-[WebCoreMovieObserver disconnect]): (-[WebCoreMovieObserver loadStateChanged:]): (-[WebCoreMovieObserver rateChanged:]): (-[WebCoreMovieObserver sizeChanged:]): (-[WebCoreMovieObserver timeChanged:]): (-[WebCoreMovieObserver volumeChanged:]): (-[WebCoreMovieObserver didEnd:]): (-[WebCoreMovieObserver setDelayCallbacks:]):
8:12 PM Changeset in webkit [27461] by antti
  • 4 edits in trunk/WebCore

Reviewed by Adam.

Add some missing WebCore* prefixes to ObjC classes

  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createNSData): (WebCore::SharedBuffer::createCFData):
  • platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime):
6:53 PM Changeset in webkit [27460] by alp
  • 3 edits in trunk/WebKit/gtk

2007-11-05 Christian Dywan <​christian@twotoasts.de>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15409
FrameLoaderClientGtk hardcodes data, including platform to Linux i686

Compute a proper user agent string.

Patch includes fixes by Alp.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::agentPlatform): (WebKit::agentOS): (WebKit::composeUserAgent): (WebKit::FrameLoaderClient::userAgent):
  • WebCoreSupport/FrameLoaderClientGtk.h:
6:10 PM Changeset in webkit [27459] by adachan
  • 6 edits in trunk

<rdar://problem/5579772> Regression: AltGr does not work
Testing whether alt-key is down is not the right test for system key event.
Added a m_isSystemKey flag in PlatformKeyboardEvent to keep track of whether
this is a system key event, check that flag instead in handleEditingKeyboardEvent().

Reviewed by Oliver.


4:35 PM Changeset in webkit [27458] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • pcre/pcre.pri:
4:02 PM Changeset in webkit [27457] by adachan
  • 2 edits in trunk/WebKit/win

Build fix.

Reviewed by Tristan.

  • WebChromeClient.h:
3:56 PM Changeset in webkit [27456] by antti
  • 3 edits in trunk/WebKitLibraries

Reviewed by Sam.


Update WKQTMovieViewSetDrawSynchronously.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:21 PM Changeset in webkit [27455] by sullivan@apple.com
  • 2 edits in trunk/WebKit
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):

Teeny style tweak to test svn access on other machine

3:12 PM Changeset in webkit [27454] by sullivan@apple.com
  • 2 edits in trunk/WebKit
  • WebView/WebView.mm: (-[WebView computedStyleForElement:pseudoElement:]):


Teeny style tweak to test svn access

3:05 PM Changeset in webkit [27453] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/list.cpp:
2:43 PM Changeset in webkit [27452] by tristan
  • 23 edits in trunk

qt:

Reviewed by Darin Adler.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow):
  • WebCoreSupport/ChromeClientQt.h: Revised to use new WebCore ChromeClient createWindow API.

WebCore:

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Set WindowFeatures.h as a Private header.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Revised to use a single createWindow function instead of two createWindow functions and one createModalDialog function. The logic for this is now addressed in WebKit in an effort to make this easier to follow.


  • page/Chrome.cpp: (WebCore::Chrome::createWindow):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/ContextMenuController.cpp: (WebCore::openNewWindow):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::createWindow): Revised to take new additional windowFeatures parameter.

WebKit:

Reviewed by Darin Adler.

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]): Forward the UI delegate to call webView:createWebViewWithRequest: if this method doesn't exist.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]):
  • WebView/WebView.mm: (-[WebView _openNewWindowWithRequest:]): Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome. Removed createModalDialog to use new createWindow function.


  • WebView/WebUIDelegatePrivate.h: Added new webView:createWebViewWithRequest:windowFeatures: method.

win:

Reviewed by Darin Adler.


Part of the WebKit/WebCore API changes for
<rdar://problem/5368188>

  • WebChromeClient.cpp: (WebChromeClient::createWindow): Removed usage of createModalDialog and revised to use new createWindow ChromeClient API.
2:02 PM Changeset in webkit [27451] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Touched a file to test my new HTTP access.

  • kjs/scope_chain.cpp:
1:56 PM Changeset in webkit [27450] by ggaren
  • 1 edit
    1 add in trunk/JavaScriptGlue

Build fix.

  • ForwardingHeaders/kjs/value.h: Added.
1:35 PM Changeset in webkit [27449] by alp
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Alp Toker <​alp@atoker.com>

Unreviewed build fix for qmake-based ports.

Someone with a better understanding of qmake still needs to sort out
the INCLUDEPATH/DEPENDPATH mess.

1:27 PM Changeset in webkit [27448] by ggaren
  • 15 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Darin Adler.


​http://bugs.webkit.org/show_bug.cgi?id=15835

Switched List implementation from a custom heap allocator to an inline
Vector, for a disappointing .5% SunSpider speedup.


Also renamed List::slice to List::getSlice because "get" is the
conventional prefix for functions returning a value through an out
parameter.

  • kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Removed some redundant function calls and memory accesses.
  • kjs/bool_object.cpp: (BooleanObjectImp::construct): Removed questionable use of iterator.
  • kjs/list.cpp:
  • kjs/list.h: New List class, implemented in terms of Vector. Two interesting differences:
    1. The inline capacity is 8, not 5. Many of the Lists constructed during a SunSpider run are larger than 5; almost none are larger than 8.
  1. The growth factor is 4, not 2. Since we can guarantee that Lists aren't long-lived, we can grow them more aggressively, to avoid excessive copying.
  • kjs/regexp_object.cpp: (RegExpObjectImp::construct): Removed redundant function calls.
  • kjs/string_object.cpp: (KJS::StringObjectImp::construct): Removed questionable use of iterator.
  • wtf/Vector.h: (WTF::::uncheckedAppend): Added a fast, unchecked version of append.

WebCore:

Reviewed by Darin Adler.


​http://bugs.webkit.org/show_bug.cgi?id=15835

Small adaptations to new KJS::List class.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::ScheduledAction):

WebKit:

Reviewed by Darin Adler.


​http://bugs.webkit.org/show_bug.cgi?id=15835

Small adaptations to new KJS::List class.

  • ForwardingHeaders/kjs/value.h: Added.
1:09 PM Changeset in webkit [27447] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Add DEPENDPATH to JavaScriptCore and pcre to help qmake with dependencies.

10:57 AM Changeset in webkit [27446] by aroben
  • 3 edits in trunk/WebKitTools

Add support on Windows for WEBKIT_TESTFONTS

This environment variable lets you specify where the fonts to be used
by DumpRenderTree reside. The Qt port is already using this, so I'm
just following their lead.

Reviewed by Darin.

  • DumpRenderTree/win/DumpRenderTree.cpp: (exePath): Refactored code out of initialize(). (fontsPath): Returns either $WEBKIT_TESTFONTS or DumpRenderTree.resources. (initialize): Use the new fontsPath function. (main): Use the new exePath function.
  • Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment variable to DRT, like Qt does.
10:57 AM Changeset in webkit [27445] by aroben
  • 4 edits in trunk/WebKit/win

Add IWebCache::disabled

This matches the Mac WebCache class.

Reviewed by Sam.

  • Interfaces/IWebCache.idl:
  • WebCache.cpp: (WebCache::disabled):
  • WebCache.h:
10:57 AM Changeset in webkit [27444] by aroben
  • 9 edits
    3 adds in trunk

Add IWebInspector and a way to get one from a WebView

WebCore:

Allow passing a base class pointer to COMPtr::copyRefTo

Reviewed by Sam.

  • platform/win/COMPtr.h:

WebKit/win:

Add IWebInspector and a way to get one from a WebView

This API matches the Mac one added in r27266.

Reviewed by Sam.

  • Interfaces/IWebInspector.idl: Added.
  • Interfaces/IWebViewPrivate.idl: Added a new inspector method to match Mac.
  • WebInspector.cpp: Added. (WebInspector::createInstance): (WebInspector::WebInspector): (WebInspector::~WebInspector): (WebInspector::webViewClosed): (WebInspector::QueryInterface): (WebInspector::AddRef): (WebInspector::Release): (WebInspector::show): (WebInspector::showConsole): (WebInspector::showTimeline): (WebInspector::close): (WebInspector::attach): (WebInspector::detach):
  • WebInspector.h: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebInspector.idl.
  • WebKit.vcproj/WebKit.vcproj: Added WebInspector.{cpp,h}.
  • WebKit.vcproj/WebKitGUID.vcproj: Added IWebInspector_i.c.
  • WebView.cpp: (WebView::close): Notify the WebInspector that we're closing. (WebView::inspector): Added.
  • WebView.h:
10:56 AM Changeset in webkit [27443] by aroben
  • 2 edits in trunk/WebKit/win

Cache strings that come directly from WebLocalizedString

Reviewed by Steve.

  • WebLocalizableStrings.cpp: (copyLocalizedStringFromBundle): This used to be WebLocalizedString, but is now just a static helper function. (findCachedStringInMap): Added static helper. (findCachedString): Refactored and cleaned up code from WebLocalizedLPCTSTR. (cacheString): Ditto. (WebLocalizedString): Rewrote to use the new helper functions. (WebLocalizedLPCTSTR): Changed to use the new helper functions.
10:55 AM Changeset in webkit [27442] by aroben
  • 2 edits in trunk/WebKit/win

Only override the default user agent string if we're actually given a custom one

Reviewed by Sam.

  • WebView.cpp: (WebView::setCustomUserAgent):
10:52 AM Changeset in webkit [27441] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

  • fix ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when a class attribute is all-whitespace

Test: fast/dom/class-all-whitespace.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Check if there is any non-whitespace character in the class attribute.

LayoutTests:

Reviewed by Oliver Hunt.

  • test that an all-whitespace class attribute does not cause an assertion failure
  • fast/dom/class-all-whitespace-expected.txt: Added.
  • fast/dom/class-all-whitespace.html: Added.
10:23 AM Changeset in webkit [27440] by beidson@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam

Add transaction blocking to the DatabaseAuthorizer in preparation for the new version
of the sql storage API

  • storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::allowTransaction):
  • storage/DatabaseAuthorizer.h:
8:34 AM Changeset in webkit [27439] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Have getMIMETypeForExtension return a null string when no MIME type is known
for the extension rather than returning "text/plain". This prevents plugin data
being dumped into object elements when plugins are disabled.

  • platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
7:01 AM Changeset in webkit [27438] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-11-05 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Alp Toker.

Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.

  • GtkLauncher/main.cpp: (goToURLBarText): (main):
6:39 AM Changeset in webkit [27437] by mrowe@apple.com
  • 3 edits in trunk/WebKit/gtk

2007-11-05 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Alp Toker.

Remove unused m_firstData member from FrameLoaderClientGtk.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:
6:39 AM Changeset in webkit [27436] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2007-11-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15842
Bug 15842: [Gtk] about:blank doesn't work

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading): Set the encoding on the frame loader to get work done that is normally done when the first bit of data is received, even in the case of a document with no data (like about:blank).
6:30 AM Changeset in webkit [27435] by ap
  • 2 edits in trunk/LayoutTests

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15841
fast/dom/Document/early-document-access.html crashes under GuardMalloc

  • fast/dom/Document/early-document-access.html: Don't check for open() timeout; wait for popup window to close as long as it takes.

Nov 4, 2007:

10:38 PM Changeset in webkit [27434] by ddkilzer
  • 2 edits in trunk/WebKitTools

bisect-builds doesn't work with nightly build r19992 or newer on Leopard
<​http://bugs.webkit.org/show_bug.cgi?id=15830>

Reviewed by Timothy.

Restrict the range of nightly builds used by the bisect-builds script
based on the version of Safari and the version of Mac OS X being used.

Mac OS X 10.4: Safari 2.0: r11976 or newer
Mac OS X 10.4: Safari 3.0: r19992 or newer

Mac OS X 10.5: Safari 2.0: r19594 or newer
Mac OS X 10.5: Safari 3.0: r25124 or newer

  • Scripts/bisect-builds: (findMacOSXVersion): Added. (makeNightlyList): Added argument to provide version of Mac OS X. Restrict range of nightly builds based on Safari and Mac OS X versions.
5:37 PM Changeset in webkit [27433] by weinig@apple.com
  • 4 edits in trunk/WebCore

Rubber-stamped by Adam Roben.

Rename SecurityOrigin::allowsAccessFrom to SecurityOrigin::canAccess to
clear up ambiguity.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
  • platform/SecurityOrigin.h:
4:20 PM Changeset in webkit [27432] by timothy@apple.com
  • 1 edit
    29 adds in trunk/WebKitSite

Land the HTML Editing Toolbar demo from WWDC 2007.

  • demos: Added.
  • demos/editingToolbar: Added.
  • demos/editingToolbar/FancyToolbar.css: Added.
  • demos/editingToolbar/FancyToolbar.js: Added.
  • demos/editingToolbar/FancyToolbarImages: Added.
  • demos/editingToolbar/FancyToolbarImages/button.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/camera.png: Added.
  • demos/editingToolbar/FancyToolbarImages/link.png: Added.
  • demos/editingToolbar/FancyToolbarImages/textAlign.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Added.
  • demos/editingToolbar/content.html: Added.
  • demos/editingToolbar/images: Added.
  • demos/editingToolbar/images/safari.png: Added.
  • demos/editingToolbar/index.html: Added.
4:09 PM Changeset in webkit [27431] by timothy@apple.com
  • 7 edits
    3 adds in trunk/WebCore

Reviewed by Adam.

Bug 15834: There are many subtle bugs in the Styles pane of the Web Inspector
​http://bugs.webkit.org/show_bug.cgi?id=15834

  • Broke up DocumentPanel and added three SidebarPane sub-classes.
  • Fixed many Style pane bugs, including:
    • Poor handling of duplicate properties in the same rule. Some of this can't be fixed since we can't only get the "winning" value for duplicate properties. So we should only show one entry per unique property name.
    • Computed style does not show font shorthand sub-properties if 'font' was used.
    • Property priority was broken, the wrong properties were crossed out.
    • The 'border' shorthand shows null for the shorthand value.
    • Shorthands didn't show their priority (e.g. !important).
    • HSL and HTML hex colors didn't have preview swatch blocks.
    • Code refactoring, making it easier to reuse for console.log later.
  • page/inspector/DocumentPanel.js: Move sidebar pane code to three seperate classes in new files.
  • page/inspector/MetricsSidebarPane.js: Added.
  • page/inspector/Panel.js: Remove an InspectorController.log() call.
  • page/inspector/PropertiesSection.js: Add the section to the TreeOutline. So TreeElements can access properties on their section.
  • page/inspector/PropertiesSidebarPane.js: Added.
  • page/inspector/SidebarPane.js: Remove the explicit asignment of the onexpand and oncollapse to null. These were hiding prototypes.
  • page/inspector/StylesSidebarPane.js: Added.
  • page/inspector/inspector.html: Include the new script files.
  • page/inspector/treeoutline.js: If a null representedObject is passed in just use a empty object.
2:36 PM Changeset in webkit [27430] by kmccullo
  • 9 edits in trunk/WebKitTools

Reviewed by Maciej.

  • This patch involves several changes, all of them were noticed that they were needed by the work being done in WebKit to get Drosera and WebKit working together on Windows.
  • The changes are: 1) Added a debugger console for output messages. 2) Drosera now listens for the WebKit server (before, the server would have to be running before Drosera was started.) 3) Fixed a bug where the WebView started out as 0x0 pixels. 4) Fixed a bug when there is no scope. 5) Added the HTML, JS, and CSS to the project file to make them easy to find. 6) Made the ServerConnection functions virtual.
  • Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens for the WebKit server. (DebuggerClient::DebuggerClient): (DebuggerClient::~DebuggerClient): (DebuggerClient::didFinishLoadForFrame): (DebuggerClient::serverConnected): (DebuggerClient::attemptToCreateServerConnection):
  • Drosera/win/DebuggerClient.h: Ditto.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no scope. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
  • Drosera/win/Drosera.cpp: (_tWinMain): Added a console in debug for output messages. (Drosera::Drosera): Listen for server. (Drosera::initUI): The server now Initializes COM. (Drosera::serverConnected): Part of the listening for the server. (Drosera::attemptToCreateServerConnection): Ditto.
  • Drosera/win/Drosera.h: New interface for listening for the server.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS files to the VS project.
  • Drosera/win/ServerConnection.cpp: Part of listening for the server connection. (ServerConnection::ServerConnection): (ServerConnection::attemptToCreateServerConnection):
  • Drosera/win/ServerConnection.h: Ditto and virtualized the Interface methods. (ServerConnection::serverConnected):
2:30 PM Changeset in webkit [27429] by weinig
  • 1 edit in trunk/WebKitTools/FindSafari

Add svn:ignore for vcproj temp files under FindSafari.

12:27 PM Changeset in webkit [27428] by ap
  • 4 edits in trunk/WebKitTools

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15832
fast/dom/gc-10.html crashes when run alone

Check for !done before using objects that can be already deallocated.

  • DumpRenderTree/mac/EditingDelegate.mm: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
8:46 AM Changeset in webkit [27427] by ddkilzer
  • 2 edits in trunk/WebCore

Fix build when spaces appear in the WebKit source path.

Reviewed by Mark Rowe.

  • bindings/scripts/IDLParser.pm: Use safer open() method which lists arguments individually and prevents the need to work around spaces in the path.
8:13 AM Changeset in webkit [27426] by ddkilzer
  • 2 edits in trunk/WebKitSite

CIA has changed its hostname from cia.navi.cx to cia.vc
<​http://bugs.webkit.org/show_bug.cgi?id=15829>

Reviewed by Mitz.

  • contact.html: Updated links to CIA.
7:03 AM Changeset in webkit [27425] by alp
  • 2 edits in trunk/WebCore

2007-11-04 Alp Toker <​alp@atoker.com>

Reviewed by Alexey Proskuryakov.

Fix a crash when no clipboard text is available

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::plainText):
1:48 AM Changeset in webkit [27424] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-11-04 Mark Rowe <​mrowe@apple.com>

Build fix. Don't use Carbon.h as the prefix header as it triggers
warnings that would otherwise be suppressed due to it being a system header.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Nov 4, 2007:

1:58 AM Changeset in webkit [27423] by Darin Adler
  • 3 edits in trunk/SunSpider
  • hosted/sunspider.html: Tweaked formatting a bit.
1:28 AM Changeset in webkit [27422] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

SunSpider says it's 2.6% faster overall, 32.5% in the regular expression tests.

  • pcre/pcre_internal.h: Added OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
  • pcre/pcre_compile.c: (find_fixedlength): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC. Also added OP_NOT since there was no reason it should not be in here. (could_be_empty_branch): Ditto. (compile_branch): Streamlined all the single-character cases; there was a bit of duplicate code. Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC as needed. But in particular, compile to those opcodes when the single character match is ASCII. (find_firstassertedchar): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
  • pcre/pcre_exec.c: (match): Removed the "min", "minimize", and "op" fields from the matchframe, after I discovered that none of them needed to be saved and restored across recursive match calls. Also eliminated the ignored result field from the matchframe, since I discovered that rrc ("recursive result code") was already the exact same thing. Moved the handling of opcodes higher than OP_BRA into the default statement of the switch instead of doing them before the switch. This removes a branch from each iteration of the opcode interpreter, just as removal of "op" removed at least one store from each iteration. Last, but not least, add the OP_ASCII_CHAR and OP_ASCII_LETTER_NC functions. Neither can ever match a surrogate pair and the letter case can be handled efficiently.
12:54 AM Changeset in webkit [27421] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • pcre/pcre_exec.c: (match): Try to fix the Windows build by removing unreachable code.
Note: See TracTimeline for information about the timeline view.