⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 7, 2007:

11:58 PM Changeset in webkit [27589] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2007-11-07 Eric Seidel <​eric@webkit.org>

Reviewed by Darin and Oliver.


Add evaluateToNumber parallel evaluation tree to speed up number operations.
Make ImmediateNumberNode a subclass of NumberNode.
Share evaluate logic between evaluate and evaluateToNumber using inline functions
There is still a lot of improvement to be made here.


SunSpider claims this is a 1.0% speedup overall (nbody 7.9%), base64 slowing 2.0%
Given the huge win that this prepares us for with simple type inferencing I see the small
regression in base64 being worth the substantial overall improvement.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::Node::evaluateToNumber): (KJS::NumberNode::evaluate): (KJS::NumberNode::evaluateToNumber): (KJS::StringNode::evaluateToNumber): (KJS::LocalVarAccessNode::inlineEvaluate): (KJS::LocalVarAccessNode::evaluate): (KJS::LocalVarAccessNode::evaluateToNumber): (KJS::BracketAccessorNode::inlineEvaluate): (KJS::BracketAccessorNode::evaluate): (KJS::BracketAccessorNode::evaluateToNumber): (KJS::NegateNode::evaluate): (KJS::NegateNode::evaluateToNumber): (KJS::MultNode::inlineEvaluateToNumber): (KJS::MultNode::evaluate): (KJS::MultNode::evaluateToNumber): (KJS::DivNode::inlineEvaluateToNumber): (KJS::DivNode::evaluate): (KJS::DivNode::evaluateToNumber): (KJS::ModNode::inlineEvaluateToNumber): (KJS::ModNode::evaluate): (KJS::ModNode::evaluateToNumber): (KJS::throwOutOfMemoryErrorToNumber): (KJS::addSlowCaseToNumber): (KJS::add): (KJS::addToNumber): (KJS::AddNode::evaluateToNumber): (KJS::SubNode::inlineEvaluateToNumber): (KJS::SubNode::evaluate): (KJS::SubNode::evaluateToNumber): (KJS::valueForReadModifyAssignment): (KJS::ReadModifyLocalVarNode::evaluate): (KJS::ReadModifyResolveNode::evaluate): (KJS::ReadModifyDotNode::evaluate): (KJS::ReadModifyBracketNode::evaluate):
  • kjs/nodes.h: (KJS::Node::): (KJS::NumberNode::): (KJS::ImmediateNumberNode::): (KJS::AddNode::precedence):
  • kjs/nodes2string.cpp: (KJS::NumberNode::streamTo):
11:40 PM Changeset in webkit [27588] by sfalken
  • 3 edits in trunk/WebKit/win

Added IWebDocumentText available via QI from WebFrame.


Reviewed by Sam.

  • WebFrame.cpp: (WebFrame::QueryInterface): Added IID_IWebDocumentText. (WebFrame::supportsTextEncoding): Stubbed out. (WebFrame::selectedString): Implemented. (WebFrame::selectAll): Stubbed out. (WebFrame::deselectAll): Stubbed out.
  • WebFrame.h:
10:13 PM Changeset in webkit [27587] by antti
  • 2 edits in trunk/WebCore

Reviewed by Ollie.

Ensure video renderer has correct size if video has already been loaded
when it is constructed.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo):
8:24 PM Changeset in webkit [27586] by antti
  • 2 edits in trunk/WebCore

Reviewed by Ollie.

Ensure video is visible when it should be.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updateMovie):
5:54 PM Changeset in webkit [27585] by mitz@apple.com
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/5523503> Safari crashes clicking scroll bar in FaceBook 'Trips'

Layers and listboxes are two kinds of ScrollBarClient that can be
removed while the scrollbar is tracking the mouse. The scrollbar is not
destroyed until later, and meanwhile it can try to call the client,
which results in a crash.

  • manual-tests/stale-scrollbar-client-crash.html: Added.
  • platform/ScrollBar.h: (WebCore::Scrollbar::setClient): Added.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar): Call Scrollbar::setClient().
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): Ditto.
5:45 PM Changeset in webkit [27584] by mitz@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • add an option to run-webkit-tests to ignore pixel test failures where all pixels differ by no more than a specified threshold
  • DumpRenderTree/mac/ImageDiff.m: (main): (compareImages): (computePercentageDifferent):
  • Scripts/run-webkit-tests:
3:45 PM Changeset in webkit [27583] by aroben
  • 4 edits in trunk

Fix <rdar://5569268> Crash when opening any FTP site in second tab/window

WebCore:

Fix <rdar://5569268> Crash when opening any FTP site in second tab/window

Reviewed by Sam.

No test possible.

  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Bail if we get an empty path, because _wfopen_s will crash if we pass it a null pointer.

WebKit/win:

Fix <rdar://5569268> Crash when opening any FTP site in second tab/window

Reviewed by Sam.

  • WebView.cpp: (WebView::initWithFrame): Set the ftpDirectoryTemplatePath for every Page, not just the first one.
3:09 PM Changeset in webkit [27582] by mrowe@apple.com
  • 1 edit
    1 add in trunk/WebKit

2007-11-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Kevin Decker.

Fix 64-bit Mac build.

  • WebKit.xcodeproj/project.pbxproj: Change paths specified relative to SRCROOT to be relative to PROJECT_DIR. PROJECT_DIR takes into account the projectDirPath setting of the project, which in this instance includes the necessary "mac" subdirectory.
1:54 PM Changeset in webkit [27581] by ddkilzer
  • 3 edits
    7 adds in trunk

WebCore:

WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
<​http://bugs.webkit.org/show_bug.cgi?id=14893>
<rdar://problem/5380295>

Reviewed by Darin.

Tests: fast/css/device-aspect-ratio.html

fast/css/max-device-aspect-ratio.html
fast/css/min-device-aspect-ratio.html

  • css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio): Renamed method parameters from a/b to h/v. (WebCore::device_aspect_ratioMediaFeatureEval): Renamed local variables from a/b to h/v. Switched first two arguments of the call to cmpvalue() to fix the bug.

LayoutTests:

WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
<​http://bugs.webkit.org/show_bug.cgi?id=14893>
<rdar://problem/5380295>

Reviewed by Darin.

Each of the following tests creates a <link> element and dynamically sets its
media query based on the aspect ratio (width/height) of the current screen.
When the <link> element is attached to the <head> node, the test expects the
stylesheet to be loaded for the test to pass.

  • fast/css/device-aspect-ratio-expected.txt: Added.
  • fast/css/device-aspect-ratio.html: Added.

This test sets the device-aspect-ratio to the current size of the screen.
NOTE: This test passed before the fix.

  • fast/css/max-device-aspect-ratio-expected.txt: Added.
  • fast/css/max-device-aspect-ratio.html: Added.

This test sets the max-device-aspect ratio to 100/1 for landscape monitors or
1/1 for portrait (or square) monitors.
NOTE: This test failed before the fix.

  • fast/css/min-device-aspect-ratio-expected.txt: Added.
  • fast/css/min-device-aspect-ratio.html: Added.

This test sets the min-device-aspect ratio to 1/1 for landscape monitors or
1/100 for portrait (or square) monitors.
NOTE: This test failed before the fix.

  • fast/css/resources/device-aspect-ratio.css: Added.
1:44 PM Changeset in webkit [27580] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Roll out r27578 as it is not necessary.

12:59 PM Changeset in webkit [27579] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/css/display-none-inline-style-change-crash.html

  • dom/Element.cpp: (WebCore::Element::recalcStyle): Fixed the crash by null-checking the current style and removed other checks that are not strictly necessary.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/css/display-none-inline-style-change-crash-expected.txt: Added.
  • fast/css/display-none-inline-style-change-crash.html: Added.
12:11 PM Changeset in webkit [27578] by tristan
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker.

Build fix for Leopard. Cast a size() as int to unsigned for proper
comparison.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::writeHelper): Casted an int to unsigned for an unsigned to unsigned comparison.
11:31 AM Changeset in webkit [27577] by beidson@apple.com
  • 2 edits in trunk/WebCore

Rubberstamped by Sam

Remove FrameLoaderClient methods from SVG that were pruned awhile ago

  • platform/graphics/svg/SVGImageEmptyClients.h:
10:52 AM Changeset in webkit [27576] by mitz@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix a bug where CSS rules with :hover in the ancestor chain stopped working after changing the inline style declaration of the ancestor

Test: fast/css/affected-by-hover-after-style-change.html

  • dom/Element.cpp: (WebCore::Element::recalcStyle): If we are not forcing style recalculation for all descendants, preserve any "affected by {hover|active|drag} bits that we may have acquired from them. Also renamed _style to currentStyle.

WebKitSite:

Reviewed by Darin Adler.

  • removed a workaround for the bug fixed in the WebCore part of this patch
  • misc/DatabaseExample.html:

LayoutTests:

Reviewed by Darin Adler.

  • test that CSS rules with :hover in the ancestor chain continue to work after changing the inline style declaration of the ancestor
  • fast/css/affected-by-hover-after-style-change.html: Added.
  • platform/mac/fast/css/affected-by-hover-after-style-change-expected.checksum: Added.
  • platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Added.
  • platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Added.
9:56 AM Changeset in webkit [27575] by timothy@apple.com
  • 10 edits in trunk/WebCore

Reviewed by Adam.

Bug 11920: Web Inspector should have Firebug-like CSS editing
​http://bugs.webkit.org/show_bug.cgi?id=11920

  • css/CSSComputedStyleDeclaration.h: (WebCore::CSSComputedStyleDeclaration::isPropertyImplicit): Return false. I'm not sure why this was true, but computed style has no concept of implicit. So false makes more sense and makes the code simpler in the inspector. This function was added for the inspector, so this isn't a compatibility change.
  • page/inspector/PropertiesSection.js: Add a getter/setter to reset populated status.
  • page/inspector/StylesSidebarPane.js: Some refactoring along with the main support for style editing.
  • page/inspector/inspector.css: Style changes for propery editing and focus correctness.
  • page/inspector/inspector.js: Look for a handleKeyEvent function of the focus element before trying to call a function based on the element's id. Call focused and blurred on the focused element when currentFocusElement is changed. Use the new listItemElement getter instead of the private property.
  • page/inspector/treeoutline.js: No longer expand on double click if ondblclick is implemented. Shrink the toggle zone to 10px to better match the size of the arrow. Add an onattach call to allow generation of the title using the DOM element. Add listItemElement and childrenListElement getters.
  • page/inspector/utilities.js: Add new helper prototype methods on CSSStyleDeclaration.
  • page/inspector/DocumentPanel.js: Use the new listItemElement getter instead of the private property. Also expand the DOM node on double click now that the TreeOutline dosen't do it.
  • page/inspector/Resource.js: Use the new listItemElement and childrenListElement getters instead of the private properties.
9:54 AM Changeset in webkit [27574] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric.

Fix up initialization after being mangled in r27572, and remove the
ternary expression as extraCost will always be zero for the numeric
heap.

  • kjs/collector.cpp: (KJS::Collector::heapAllocate):
9:54 AM Changeset in webkit [27573] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-07 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/regexp_object.cpp:
9:52 AM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
9:32 AM Changeset in webkit [27572] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.


Eliminated a bogus (though compiled-out) branch in the collector.

  • kjs/collector.cpp: (KJS::Collector::heapAllocate):
9:18 AM Changeset in webkit [27571] by ggaren@apple.com
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Darin Adler.


Fixed part of ​http://bugs.webkit.org/show_bug.cgi?id=15861
15% of string-validate-input.js is spent compiling the same regular expression.

Put RegExpImp properties into a static hashtable to avoid a slew of
PropertyMap churn when creating a RegExpImp.


Factored important bits of regular expression implementation out of
RegExpImp (the JS object) and into RegExp (the PCRE wrapper class),
making RegExp a ref-counted class. (This will help later.)

Removed PCRE_POSIX support because I didn't quite know how to test it
and keep it working with these changes.


1.1% SunSpider speedup. 5.8% speedup on string-validate-input.js.

  • kjs/regexp.h: A few interface changes:
  1. Renamed "subpatterns()" => "numSubpatterns()"
  2. Made flag enumeration private and replaced it with public getters for specific flags.
  3. Made RegExp ref-counted so RegExps can be shared by RegExpImps.
  4. Made RegExp take a string of flags instead of an int, eliminating duplicated flag parsing code elsewhere.
  • kjs/regexp_object.cpp: (KJS::RegExpProtoFunc::callAsFunction): For RegExp.compile:
  • Fixed a bug where compile(undefined) would throw an exception.
  • Removed some now-redundant code.
  • Used RegExp sharing to eliminate an allocation and a bunch of PropertyMap thrash. (Not a big win since compile is a deprecated function. I mainly did this to test the plubming.)

LayoutTests:

Reviewed by Darin Adler.


Beefed up the RegExp.compile testcase to cover a mistake in the
original check-in and a mistake I made while developing my new patch.

  • fast/js/resources/regexp-compile.js:
8:36 AM Changeset in webkit [27570] by hausmann
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore.pri expects OBJECTS_DIR to be set, so set it in
testkjs.pro, too, where it's included from.

8:14 AM Changeset in webkit [27569] by hausmann
  • 2 edits in trunk/WebCore

Coding style fix.

7:52 AM Changeset in webkit [27568] by hausmann
  • 2 edits in trunk/WebCore

For safety provide a default constructor for WindowFeatures().
ContextMenuController.cpp: createNewWindow as well as QWebPage need to
create a default initialized WindowFeatures object on the fly.

7:35 AM Changeset in webkit [27567] by hausmann
  • 2 edits in trunk/WebKit/qt

Fix the Qt build.

6:45 AM Changeset in webkit [27566] by hausmann
  • 5 edits in trunk

Fix "nmake clean" for the Qt/Windows build by replacing tmp/ with a variable that ends with the correct type of slash/backslash depending on the choice of compiler/make tool.

6:32 AM Changeset in webkit [27565] by hausmann
  • 7 edits in trunk

Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.

6:32 AM Changeset in webkit [27564] by hausmann
  • 3 edits in trunk/WebKit/qt

Changed QWebPageHistory::goToItem to take a value instead of a pointer.

6:32 AM Changeset in webkit [27563] by hausmann
  • 2 edits in trunk/WebKit/qt

Removed unimplemented QWebHistoryItem::children() function

6:32 AM Changeset in webkit [27562] by hausmann
  • 2 edits in trunk/WebKit/qt

Changed the getter functions in QWebSettings to transparently resolve against the default settings.

6:31 AM Changeset in webkit [27561] by hausmann
  • 3 edits in trunk/WebKit/qt

Added explicit functions for resetting the font sizes and font families.

6:31 AM Changeset in webkit [27560] by hausmann
  • 3 edits in trunk/WebKit/qt

Combined the font sizes accessors/setters under one setter/getter with an enum.

6:31 AM Changeset in webkit [27559] by hausmann
  • 4 edits in trunk/WebKit/qt

Renamed QWebPage::userAgentStringForUrl(url) to QWebPage::userAgentFor(url);

6:31 AM Changeset in webkit [27558] by hausmann
  • 3 edits in trunk/WebKit/qt

Renamed QWebPage::webActionTriggered to QWebPage::triggerAction

6:31 AM Changeset in webkit [27557] by hausmann
  • 4 edits in trunk/WebKit/qt

Changed the virtual QWebPage::setWindowGeometry to be a geometryChangeRequest signal instead.

6:31 AM Changeset in webkit [27556] by hausmann
  • 4 edits in trunk/WebKit/qt

Renamed QWebPage::webAction() to QWebPage::action()

6:31 AM Changeset in webkit [27555] by hausmann
  • 3 edits in trunk/WebKit/qt

Removed a bunch of slots/functions that are now available through the new actions API.

6:31 AM Changeset in webkit [27554] by hausmann
  • 2 edits in trunk/WebKit/qt

Added some more comments to the API after another round of API review with Lars.

6:31 AM Changeset in webkit [27553] by hausmann
  • 5 edits in trunk/WebKit/qt

Moved QWebFrame::selectedText() to QWebPage::selectedText().

The currently selected text is a property of the page as a whole.

6:31 AM Changeset in webkit [27552] by hausmann
  • 3 edits in trunk/WebKit/qt

Implemented support for settings propagation.

If an individual setting is not set in a page's QWebSettings then it is inherited from the default settings.

6:31 AM Changeset in webkit [27551] by hausmann
  • 9 edits in trunk

Reworked the QWebSettings API.
QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().

6:30 AM Changeset in webkit [27550] by hausmann
  • 5 edits in trunk

Made the QWebSettings::webGraphic functions static. The implementation was using QWebSettings::global() anyway.

6:30 AM Changeset in webkit [27549] by hausmann
  • 4 edits in trunk

Moved the WebCore::Image specific function loadResourcePixmap from qwebsettings.cpp to ImageQt.cpp and made it static.

6:30 AM Changeset in webkit [27548] by hausmann
  • 3 edits in trunk/WebKit/qt

Changed the icondatabase accessor to be a static function because it doesn't change the QWebSettings object.

6:30 AM Changeset in webkit [27547] by hausmann
  • 2 edits in trunk/WebKit/qt

Changed the webAction() accessor to not be a slot but just a public function.

6:30 AM Changeset in webkit [27546] by hausmann
  • 2 edits in trunk/WebKit/qt

Implemented createWindow() in QtLauncher.

6:30 AM Changeset in webkit [27545] by hausmann
  • 2 edits in trunk/WebKit/qt

Implemented opening links in new windows

6:30 AM Changeset in webkit [27544] by hausmann
  • 3 edits in trunk/WebKit/qt

Added and implemented the "OpenLink" action.

6:30 AM Changeset in webkit [27543] by hausmann
  • 2 edits in trunk/WebKit/qt

Adjust the state of the reload action correctly.

6:30 AM Changeset in webkit [27542] by hausmann
  • 3 edits in trunk/WebKit/qt

Initialize the undo/redo actions from QUndoStack. That automatically takes care of enabling/disabling them as well as the activation/trigger.

6:30 AM Changeset in webkit [27541] by hausmann
  • 2 edits in trunk/WebKit/qt

Added undo/redo toolbar buttons, moved the location line edit into a separate toolbar.

6:30 AM Changeset in webkit [27540] by hausmann
  • 4 edits in trunk/WebKit/qt

Update the editor actions when the selection changes.

6:29 AM Changeset in webkit [27539] by hausmann
  • 2 edits in trunk/WebKit/qt

Added cut/copy/paste actions to the toolbar of QtLauncher

6:29 AM Changeset in webkit [27538] by hausmann
  • 4 edits in trunk/WebKit/qt

Started working on keeping the state of the navigation actions up-to-date.

6:29 AM Changeset in webkit [27537] by hausmann
  • 2 edits in trunk/WebKit/qt

Use the navigational web actions in the toolbar

6:29 AM Changeset in webkit [27536] by hausmann
  • 4 edits in trunk/WebKit/qt

Store a bunch of QActions in QWebPagePrivate, corresponding to QWebPage::WebAction.
Added QWebPageContext to hold context sensitive information (for example used by the context menu).

6:29 AM Changeset in webkit [27535] by hausmann
  • 3 edits in trunk/WebKit/qt

Moved the editing actions implemented in keyPressEvent into webActionTriggered.

6:29 AM Changeset in webkit [27534] by hausmann
  • 3 edits in trunk/WebKit/qt

Introduced a central virtual void webActionTriggered(WebAction action) method that is called from various
convenience methods such as cut()/copy()/paste().

6:29 AM Changeset in webkit [27533] by hausmann
  • 9 edits in trunk

Restructure the context menu classes for the Qt port. ContextMenu and ContextMenuItem don't store
QActions/QMenus anymore but just store the action type, tag, title and optionally submenu as created
in ContextMenu::populate().
For the actual Qt context menu we traverse this structure after sendContextMenuEvent and create a QMenu
out of it. That menu is currently not functional anymore though.

6:29 AM Changeset in webkit [27532] by hausmann
  • 5 edits in trunk

Changed ContextMenu::setPlatformDescription for the Qt port to not show the qmenu right away
but instead just behave as a normal setter that takes ownership of the platform menu description (the qmenu).
Instead now QWebPage::contextMenuEvent() retrieves the QMenu after calling sendContextMenuEvent and calls exec()
on it.

6:29 AM Changeset in webkit [27531] by hausmann
  • 6 edits in trunk

Changed to PlatformMouseEvent constructor to allow construction from a QContextMenuEvent.
Call sendContextMenuEvent on the event handler from a QWidget::contextMenuEvent re-implementation instead of in mousePressEvent.

6:28 AM Changeset in webkit [27530] by hausmann
  • 4 edits in trunk/WebKit/qt

Turned onLoadProgressChanged into a real private slot.

6:28 AM Changeset in webkit [27529] by hausmann
  • 8 edits in trunk

Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().

6:23 AM Changeset in webkit [27528] by hausmann
  • 2 edits in trunk/WebKit/qt

comments on API changes that we'd like to do.

6:21 AM Changeset in webkit [27527] by hausmann
  • 7 edits in trunk

Add a QWebPage::frameCreated() signal and fix DRT

The removal of createFrame in QWebPage broke the re-implementation
in DumpRenderTree. Instead emit a frameCreated() signal and
connect to it in DumpRenderTree.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

6:19 AM Changeset in webkit [27526] by hausmann
  • 4 edits in trunk/WebKit/qt

Remove QWebPage::createFrame()

now that QWebFrame doesn't have virtual methods anymore, there
is no need for a createFrame() factory method in QWebpage.

6:17 AM Changeset in webkit [27525] by hausmann
  • 8 edits in trunk

Moved all the event handlers from QWebFrame into QWebPage.

This cleans up the public API and allows us to remove the
HackWebFrame hack in DumpRenderTree.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

6:01 AM Changeset in webkit [27524] by hausmann
  • 5 edits
    1 add in trunk

don't put nbsp's into the plan text paste

Fix both ClipboardQt and PasteboardQt to replace
nbsp's with spaces before putting the text onto the
native clipboard. This is consistent with Mac and Win
and fixes at least editing/pasteboard/4076267-3.html

6:01 AM Changeset in webkit [27523] by hausmann
  • 1 edit
    110 adds in trunk/LayoutTests/platform/qt

Add now passing tests

The fix of umemcasecmp in UnicodeQt4.h fixed quite a lot
of test falures. Add these to our regression tests.

6:01 AM Changeset in webkit [27522] by hausmann
  • 32 edits in trunk/LayoutTests

update test results after the last commit.

6:01 AM Changeset in webkit [27521] by hausmann
  • 2 edits in trunk/JavaScriptCore

fix umemcasecmp

Pretty embarrassing bug. Has the potential to fix quite a few test failures.

6:00 AM Changeset in webkit [27520] by hausmann
  • 2 edits in trunk/LayoutTests

Update the list of skipped tests.

Three more tests are passing.

5:45 AM Changeset in webkit [27519] by hausmann
  • 2 edits in trunk/WebCore

Implement Pasteboard::writeImage()

  • Pasteboard is now fully implemented. Copying of Images into the Clipboard is now supported.
  • As with URLs we only copy into the Clipboard (and not additionally to the Selection)

Signed-off-by: Lars Knoll <​lars@trolltech.com>

5:45 AM Changeset in webkit [27518] by hausmann
  • 2 edits in trunk/WebCore

Apple CodingStyle fixes

Signed-off-by: Lars Knoll <​lars@trolltech.com>

5:45 AM Changeset in webkit [27517] by hausmann
  • 2 edits in trunk/WebCore

Implement Pasteboard::writeURL()

  • The URL currently gets written as text/plain and text/uri-list. The win and mac port have some more types which we currently do not support. When supporting them we can use the 'titleString' as well.
  • As with writeSelection we only copy into the Clipboard. We could consider copying into the Selection as well.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

5:45 AM Changeset in webkit [27516] by hausmann
  • 2 edits in trunk/WebCore

Kill whitespace

Signed-off-by: Lars Knoll <​lars@trolltech.com>

5:45 AM Changeset in webkit [27515] by hausmann
  • 2 edits in trunk/WebKit/qt

Use correct UserAgent string.

  • Only have one User Agent String and this place is QWebPage
  • QWebPage::open -> QWebNetworkRequest -> QWebPage::open -> ResourceRequest -> FrameLoader::load -> QWebNetworkRequest
  • ResourceRequest is != 0 when getting called from WebCore, we will only do requests when coming from WebCore and then we can use the User-Agent set with the help of the FrameLoaderClient
  • We might want to change QWebNetworkRequest a bit

Signed-off-by: Lars Knoll <​lars@trolltech.com>

5:18 AM Changeset in webkit [27514] by hausmann
  • 2 edits in trunk/WebKitTools

Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
to prevent the default implementation from popping up messageboxes.

4:47 AM Changeset in webkit [27513] by hausmann
  • 2 edits
    131 adds in trunk/LayoutTests

add more passing test cases.

4:47 AM Changeset in webkit [27512] by hausmann
  • 3 edits in trunk/WebCore

Use the correct function calls to convert a selection to
HTML or plain text.

4:47 AM Changeset in webkit [27511] by hausmann
  • 2 edits in trunk/WebKit/qt

remove two notImplemented() warnings, as I believe we don't
have to implement these methods. Add some (commented out)
debug code in one place.

4:44 AM Changeset in webkit [27510] by hausmann
  • 2 edits in trunk

Add WebKit/qt/Api to the dependency path when building QtLauncher and DumpRenderTree.
That means that changes to the public API of the Qt port also trigger a rebuild of the tools.

4:33 AM Changeset in webkit [27509] by hausmann
  • 2 edits in trunk/WebCore

Some more clipboard fixes.

We have to set things immediately on the QClipBoard if the
Clipboard object is not for dragging.

This is due to the fact that the Clipboard object might be
rather long lived if accessed through javascript (it'll only
get deleted by JS garbage collection). We have to transfer
the data over to the QClipboard before that to make things work.

Fixes editing/execCommand/copy-without-selection.html

2:32 AM Changeset in webkit [27508] by hausmann
  • 2 edits in trunk/WebCore

Fix compilation on Windows with non-cygwin perl.

2:14 AM Changeset in webkit [27507] by mrowe@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Remove conflict marker.

1:53 AM Changeset in webkit [27506] by ap@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Corrected ChangeLog grammar.

1:52 AM Changeset in webkit [27505] by ap@webkit.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Finished moving editing/pasteboard/5583362.html to platform/mac (this test was crashing in ObjC test plugin,
because it couldn't find its resources.

  • editing/resources/plaintext-pasteboard-data.dat: Removed.
  • platform/mac/editing/resources: Added.
  • platform/mac/editing/resources/plaintext-pasteboard-data.dat: Copied from editing/resources/plaintext-pasteboard-data.dat.
12:11 AM Changeset in webkit [27504] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Brady Eidson.

Test: fast/block/float/overhanging-after-height-decrease-offsets.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):

LayoutTests:

Reviewed by Brady Eidson.

  • fast/block/float/overhanging-after-height-decrease-offsets.html: Added.
  • platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Added.
  • platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Added.

Nov 6, 2007:

11:23 PM Changeset in webkit [27503] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.


  • only collect when the heap is full, unless we have lots of extra cost garbage


1.1% SunSpider speedup.


This shouldn't hit memory use much since the extra space in those
blocks hangs around either way.

  • kjs/collector.cpp: (KJS::Collector::heapAllocate): (KJS::Collector::collect): Fix logic error that reversed the sense of collect's return value.
11:00 PM Changeset in webkit [27502] by aroben
  • 1 edit
    1 move in trunk/LayoutTests

Move a Mac-specific test to platform/mac

  • editing/pasteboard/5583362.html: Removed.
  • platform/mac/editing/pasteboard/5583362.html: Added.
10:03 PM Changeset in webkit [27501] by oliver
  • 3 edits in trunk/JavaScriptCore

Avoid unnecessarily boxing the result from post inc/decrement for 0.3% gain in sunspider

Reviewed by Maciej

We now convert the common 'for (...; ...; <var>++) ...' to the semantically identical
'for (...; ...; ++<var>) ...'.

9:44 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
9:41 PM Changeset in webkit [27500] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2007-11-06 Eric Seidel <​eric@webkit.org>

  • Scripts/build-testkjs: build fix... too many $$
9:31 PM Changeset in webkit [27499] by bdakin
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5575812> REGRESSION:When using absolute positioning
with overflow:auto div, WebKit seems to add an additional 15px

  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned): We need to subtract off the vertical scrollbar width too.

LayoutTests:

Reviewed by Sam.

New test for <rdar://problem/5575812> REGRESSION:When using
absolute positioning with overflow:auto div, WebKit seems to add an
additional 15px

  • fast/overflow/overflow-auto-position-absolute.html: Added.
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.txt: Added.


Test with changed results. The measurements in the rtl example now
more closely mirror the ltr example.

  • platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
9:29 PM Changeset in webkit [27498] by aroben
  • 5 edits in trunk/WebKit/win

Change WebLocalizableStrings to take UTF-8 C strings

This matches the way things work on the Mac, and will allow source
files containing localizable strings to be shared between Mac and
Windows. The old functions have not been removed for compatibility
reasons, but are now just wrappers around the new UTF-8 functions.

Reviewed by Ada.

  • WebKit.vcproj/WebKit.def: Added new functions.
  • WebKit.vcproj/WebKit_debug.def: Ditto.
  • WebLocalizableStrings.cpp: (copyLocalizedStringFromBundle): Changed to take a WebCore::String representing the key. (localizedString): Refactored from WebLocalizedString. Takes a WebCore::String representing the key. (localizedLPCTSTR): Ditto for WebLocalizedLPCTSTR. (WebLocalizedStringUTF8): Added. Takes a UTF-8 C string as the key. (WebLocalizedLPCTSTRUTF8): Ditto. (WebLocalizedString): Changed to call localizedString. (WebLocalizedLPCTSTR): Changed to call localizedLPCTSTR.
  • WebLocalizableStrings.h: Changed macros to use the new UTF-8 functions.
9:24 PM Changeset in webkit [27497] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2007-11-06 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

  • Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
9:00 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
7:01 PM Changeset in webkit [27496] by mrowe@apple.com
  • 2 edits
    24 moves
    1 add in trunk/WebKit

Move Mac files from WebKit into WebKit/mac.

5:13 PM Changeset in webkit [27495] by justing
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Dan Bernstein.


<rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
<rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail

  • editing/markup.cpp: (WebCore::createFragmentFromText): Put paragraphs of text into clones of the block that encloses the input context, unless that block is the body, which shouldn't be cloned. In that case, use regular divs, as we did before r27369.

LayoutTests:

Reviewed by Dan Bernstein.

<rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
<rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail

  • editing/pasteboard/5583362.html: Added.
  • editing/resources/plaintext-pasteboard-data.dat: Added.
  • platform/mac/editing/pasteboard/5583362-expected.checksum: Added.
  • platform/mac/editing/pasteboard/5583362-expected.png: Added.
  • platform/mac/editing/pasteboard/5583362-expected.txt: Added.
5:03 PM Changeset in webkit [27494] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-06 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

This fixes a regressed layout test for string + object


SunSpider claims this was an overall 0.3% speedup, although some individual tests were slower.

  • kjs/nodes.cpp: (KJS::add): remove erroneous "fast path" for string + *
4:17 PM JavaScript performance improvement ideas edited by Darin Adler
(diff)
4:12 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
4:11 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
4:06 PM Changeset in webkit [27493] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.


Added toJSNumber, a fast path for converting a JSValue to a JS number,
and deployed it in postfix expressions. In the fast case this
eliminates a call to jsNumber.


0.4% speedup on SunSpider.

  • ChangeLog:
  • kjs/nodes.cpp: (KJS::PostIncResolveNode::evaluate): (KJS::PostIncLocalVarNode::evaluate): (KJS::PostDecResolveNode::evaluate): (KJS::PostDecLocalVarNode::evaluate): (KJS::PostIncBracketNode::evaluate): (KJS::PostDecBracketNode::evaluate): (KJS::PostIncDotNode::evaluate): (KJS::PostDecDotNode::evaluate): (KJS::UnaryPlusNode::evaluate):
  • kjs/value.h: (KJS::JSValue::toJSNumber):
4:04 PM Changeset in webkit [27492] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-06 Christian Dywan <​christian@twotoasts.de>

Reviewed by Darin.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15828
Bug 15828: WebKit GTK include and lib directory is installed in qt4-named directory

  • WebCore.pro: Use sane default install paths for the gtk port.
4:02 PM Changeset in webkit [27491] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2007-11-06 Rodney Dawes <​dobey@wayofthemonkey.com>

Fix ​http://bugs.webkit.org/attachment.cgi?id=17043&action=view
Bug 15766: [GTK] WebKit sometimes spews binary data as text/plain into iframes

FrameLoaderClient::objectContentType needs to check with the MIMETypeRegistry
to determine whether the given MIME type is displayable as an image or non-image.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (FrameLoaderClient::objectContentType): Change logic to match that in the Windows and Mac ports.
3:19 PM Changeset in webkit [27490] by antti
  • 2 edits in trunk/LayoutTests

Correct test results.

  • platform/mac/fast/layers/layer-visibility-expected.txt:
3:00 PM Changeset in webkit [27489] by antti
  • 5 edits in trunk/LayoutTests

Reviewed by Hyatt.


Update test to cover
<rdar://problem/5521068>
Visibility not propagated correctly for children of a layer with z-index


The fix for this was (accidentally) already checked in with r27277,
with retroactive r=hyatt.

  • fast/layers/layer-visibility.html:
  • platform/mac/fast/layers/layer-visibility-expected.checksum:
  • platform/mac/fast/layers/layer-visibility-expected.png:
  • platform/mac/fast/layers/layer-visibility-expected.txt:
2:28 PM Changeset in webkit [27488] by justing
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.


<rdar://problem/5576619>
REGRESSION: Caret disappears after deleting the last character in inline hole (15714)

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Like the other TypingCommands, including both of the other deletion commands, call typingAddedToOpenCommand(), which takes the command's endingSelection and sets it as selection.

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/5576619> REGRESSION: Caret disappears after deleting the last character in inline hole (15714)

  • platform/mac/editing/input/5576619-expected.checksum: Added.
  • platform/mac/editing/input/5576619-expected.png: Added.
  • platform/mac/editing/input/5576619-expected.txt: Added.
  • platform/mac/editing/input/5576619.html: Added.
  • platform/mac/editing/input/text-input-controller-expected.txt:
1:37 PM Changeset in webkit [27487] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

There was a mistake in the algorithm used to find an empty slot in the property
map entries vector; when we were putting in a new property value and not overwriting
an existing deleted sentinel, we would enlarge the entries vector, but would not
overwrite the stale data that's in the new part. It was easy to pin this down by
turning on property map consistency checks -- I never would have landed with this
bug if I had run the regression tests once with consistency checks on!

  • kjs/property_map.cpp: (KJS::PropertyMap::put): Changed logic for the case where foundDeletedElement is false to always use the item at the end of the entries vector. Also allowed me to merge with the logic for the "no deleted sentinels at all" case.
1:03 PM Changeset in webkit [27486] by mitz@apple.com
  • 4 edits
    6 adds in trunk

WebCore:

Reviewed by Antti Koivisto and Dave Hyatt.

  • fix <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height

Test: fast/block/float/overhanging-after-height-decrease.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): If after calculating the height it turns out that there are overhanging floats that were not overhanging before, rescan children with overhanging floats and add them. (WebCore::RenderBlock::layoutBlockChildren): Added a parameter that returns the lowest float bottom of any of the children. (WebCore::RenderBlock::addOverhangingFloats): Changed to return the lowest float bottom.
  • rendering/RenderBlock.h:

LayoutTests:

Reviewed by Antti Koivisto and Dave Hyatt.

  • test for <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height
  • fast/block/float/overhanging-after-height-decrease.html: Added.
  • platform/mac-leopard/fast/block: Added.
  • platform/mac-leopard/fast/block/float: Added.
  • platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.checksum: Added.
  • platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-after-height-decrease-expected.txt: Added.
11:53 AM Changeset in webkit [27485] by adele
  • 8 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Switched all uses of HTMLImageLoader to use OwnPtrs.

  • html/HTMLInputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach):
  • html/HTMLObjectElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): (WebCore::HTMLVideoElement::attach): (WebCore::HTMLVideoElement::detach): (WebCore::HTMLVideoElement::parseMappedAttribute):

LayoutTests:

Reviewed by Darin.

Added test for poster attribute.

  • media/content/abe.png: Added.
  • media/content/greenbox.png: Added.
  • media/video-poster-expected.txt: Added.
  • media/video-poster.html: Added.
11:49 AM Changeset in webkit [27484] by oliver
  • 2 edits in trunk/JavaScriptCore

Fix previous patch to use a 3 bit shift, a 16 bit shift causes a regression in sunspider.

RS=Darin

11:34 AM Changeset in webkit [27483] by oliver
  • 2 edits in trunk/JavaScriptCore

Replace boolean comparisons in AddNode with mask comparisons for a 0.2% improvement in sunspider.

Reviewed by Darin

10:56 AM Changeset in webkit [27482] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-06 Eric Seidel <​eric@webkit.org>

Reviewed by darin.


SunSpider claims this is a 1.1% speedup.

  • kjs/nodes.cpp: (KJS::throwOutOfMemoryError): Added, non inline. (KJS::addSlowCase): renamed from add(), non inline. (KJS::add): add fast path for String + String, Number + Number and String + *
10:43 AM Changeset in webkit [27481] by Darin Adler
  • 4 edits in trunk/WebKit/win

Reviewed by Adam and Steve.

  • added hooks needed to implement showModalDialog on Windows
  • Interfaces/IWebUIDelegate.idl: Added canRunModal, createModalDialog, and runModal functions to the end of IWebUIDelegate3.
  • WebChromeClient.h: Added uiDelegate and uiDelegate2 helper functions, so it's easier to write client functions.
  • WebChromeClient.cpp: (WebChromeClient::createWindow): Implemented dialog case. Calls IWebUIDelegate3. (WebChromeClient::canRunModal): Implemented. Calls IWebUIDelegate3. (WebChromeClient::runModal): Ditto. (WebChromeClient::uiDelegate): Added. (WebChromeClient::uiDelegate2): Added. (WebChromeClient::uiDelegate3): Added.
10:11 AM Changeset in webkit [27480] by antti
  • 5 edits
    6 adds in trunk

WebCore:

Reviewed by Darin.


Trigger media load on on src attribute changes as specified in new HTML5 draft.

Tests: media/video-src-change.html

media/video-src-remove.html
media/video-src-set.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged):
  • html/HTMLMediaElement.h:

LayoutTests:

Reviewed by Darin.


Tests for media src attribute changes.

  • media/video-src-change-expected.txt: Added.
  • media/video-src-change.html: Added.
  • media/video-src-remove-expected.txt: Added.
  • media/video-src-remove.html: Added.
  • media/video-src-set-expected.txt: Added.
  • media/video-src-set.html: Added.
  • media/video-test.js:
10:10 AM Changeset in webkit [27479] by ap
  • 2 edits in trunk/WebKit/win

Rubber-stamped by Adam Roben.

Windows build fix.

  • WebFrame.cpp: (WebFrame::string): plainText() returns a String now.
9:48 AM Changeset in webkit [27478] by mitz@apple.com
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/repaint/make-children-non-inline.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): Repaint the block. This is needed because the inline children may be repositioned as they move into new anonymous blocks, but those blocks have no knowledge of where their children used to be, so they cannot invalidate those areas.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/make-children-non-inline.html: Added.
  • platform/mac/fast/repaint/make-children-non-inline-expected.txt: Added.
  • platform/mac-leopard/fast/repaint: Added.
  • platform/mac-leopard/fast/repaint/make-children-non-inline-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/make-children-non-inline-expected.png: Added.
8:07 AM Changeset in webkit [27477] by ap
  • 10 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15847
Some editing cleanup

No change in functionality.

WebCore:

  • editing/TextIterator.cpp: (WebCore::plainText):
  • editing/TextIterator.h: Made WebCore::plainText() return String instead of DeprecatedString.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textUnderElement]): (-[WebCoreAXObject value]): (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]): (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): Updated for the above change. There is no need to explicitly convert to NSString now.
  • editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): m_startingSelection and m_endingSelection are actually initialized in constructor body, so the work done in initializer list was wasted.

(WebCore::EditCommand::apply): Moved some stars.
(WebCore::EditCommand::unapply): Ditto.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::EditCommand::setStartingSelection): The loop exit condition was evaluated twice,
removed one of the checks.

  • editing/SelectionController.cpp: (WebCore::SelectionController::toString): plainText() result type now matches what we need here.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Removed unused -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] and -[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:].

WebKit:

  • WebView/WebHTMLView.mm: (-[WebHTMLView deleteToEndOfLine:]): (-[WebHTMLView deleteToEndOfParagraph:]): WebCore had a duplicate of the same logic already. We are passing a boundary value to a function that expects granularity, this may need to be straightened out in the future.
1:08 AM Changeset in webkit [27476] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-06 Eric Seidel <​eric@webkit.org>

Reviewed by mjs.


Avoid more UString creation.


SunSpider claims this is a 0.4% speedup.

  • kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): use UString::find(UChar)
Note: See TracTimeline for information about the timeline view.