⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 9, 2007:

11:50 PM Changeset in webkit [27662] by ap@webkit.org
  • 2 edits in trunk/SunSpider

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15925
SunSpider should check for Shark being installed

  • sunspider: Explicitly test that shark command line tool is installed.
6:28 PM Changeset in webkit [27661] by honeycutt
  • 2 edits in trunk/WebKit/win

2007-11-09 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Sam.

<rdar://5585900>: Safari crashes when selected in context menu to open
audio format files (au, aif) with QT 7.3

The crash occurred on a machine where QT 7.3 was failing to initialize.
The fix is to avoid sending streams to full-page plugins that've failed
to load

  • WebFrame.cpp: (WebFrame::finishedLoading): Check plugin status before calling manual stream methods (WebFrame::setMainDocumentError): Same (WebFrame::committedLoad): Same
5:53 PM Changeset in webkit [27660] by antti
  • 1 edit
    2 adds in trunk/WebKitSite

Rubber stamped by bdash.


Add directory for blog resources (and one image).

  • blog-files: Added.
  • blog-files/touch-poster.png: Added.
4:59 PM Changeset in webkit [27659] by antti
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fix occasional blank video with poster attribute.

  • ChangeLog:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::didRestoreFromCache): Just calling updateFromElement() does the right thing for both poster image and video.
4:29 PM Changeset in webkit [27658] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-09 Xan Lopez <​xan@gnome.org>

Reviewed by Alp.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15926
[GTK] WebKitPage map handler is redundant.

  • Api/webkitgtkpage.cpp: The map handler for WebKitPage is redundant, GtkContainer does the same (and more correctly).
3:51 PM Changeset in webkit [27657] by tristan
  • 1 edit
    1 move in trunk/LayoutTests

Reviewed by Sam Weinig.

  • fast/dom/Window/window-resize-nan.html: Removed.
  • fast/dom/Window/window-resize-nan.html-disabled: Copied from fast/dom/Window/window-resize-nan.html.


Disabled nan test until window resize issues can be resolved.

3:34 PM Changeset in webkit [27656] by weinig
  • 2 edits in trunk/WebKit/win

Rubber stamped by Oliver.

Make WebCore a dependency of Interfaces.

  • WebKit.vcproj/WebKit.sln:
3:04 PM Changeset in webkit [27655] by weinig
  • 8 edits
    11 adds in trunk

WebCore:

Reviewed by Adam Roben.

<rdar://problem/5435940>
The COM bindings for the DOM should be autogenerated like the other DOM bindings

Initial commit of the autogeneration of the COM DOM Bindings. No behavior change
is being introduced in this patch and to insure that no conflicts arise, a temporary
prefix of "GEN_" has been used for all the new classes.

The build architecture for these bindings differs slightly from the other autogenerated
bindings. Instead of building in WebCore and migrating the resuting code to WebKit (as
is done for the Objective-C bindigs currently), the IDLs and generation scripts are
migrated to WebKit and built there. This is done with a series of scripts and Makefiles.

This commit includes:

  • Hand rolled root class/Interface GEN_DOMObject used to facilated object creation and ref-counting.
  • Generating all of the Core DOM and most of HTML and CSS
  • Generating Event, EventTarget, and EventListener
  • WebCore.vcproj/MigrateIDLAndScripts.make: Added.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/migrate-idls.sh: Added.
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCOM.pm: Added.
  • dom/EventListener.h: Make the isWindowEvent parameter default to false to allow autogeneration based on the IDL.

WebKit/win:

Reviewed by Adam Roben.

<rdar://problem/5435940>
The COM bindings for the DOM should be autogenerated like the other DOM bindings

Initial commit of the autogeneration of the COM DOM Bindings. No behavior change
is being introduced in this patch and to insure that no conflicts arise, a temporary
prefix of "GEN_" has been used for all the new classes.

The build architecture for these bindings differs slightly from the other autogenerated
bindings. Instead of building in WebCore and migrating the resuting code to WebKit (as
is done for the Objective-C bindigs currently), the IDLs and generation scripts are
migrated to WebKit and built there. This is done with a series of scripts and Makefiles.

This commit includes:

  • Hand rolled root class/Interface GEN_DOMObject used to facilated object creation and ref-counting.
  • Generating all of the Core DOM and most of HTML and CSS
  • Generating Event, EventTarget, and EventListener
  • DOMCreateInstance.cpp: Added. (domWrapperCache): (getDOMWrapper): (setDOMWrapper): (removeDOMWrapper): (GEN_DOMNode::createInstance): (GEN_DOMImplementation::createInstance): (GEN_DOMCSSRule::createInstance): (GEN_DOMStyleSheet::createInstance): (GEN_DOMCSSValue::createInstance):
  • DOMCreateInstance.h: Added. Temporary location for createInstance/object caching methods. This will be broken up into seperate files in the near future.
  • GEN_DOMObject.cpp: Added. (GEN_DOMObject::GEN_DOMObject): (GEN_DOMObject::~GEN_DOMObject): (GEN_DOMObject::QueryInterface): (GEN_DOMObject::AddRef): (GEN_DOMObject::Release):
  • GEN_DOMObject.h: Added. Hand rolled base class.
  • Interfaces/IGEN_DOMObject.idl: Added. Hand rolled base interface.
  • WebKit.vcproj/DerivedSources.make: Added.
  • WebKit.vcproj/FixMIDLHeaders.pl: Added. This script is required because MIDL is producing un-buildable code due to circular dependencies.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/build-generated-files.sh: Added.
2:54 PM Changeset in webkit [27654] by tristan
  • 5 edits in trunk

mac:

Reviewed by Timothy Hatcher.


This patch is for the WebKit side of <rdar://problem/5591115>.
We need a way to tell context menu navigations, such as "Open in New Window"
to override any sort of browser preference for tab based navigation.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Pass up the new preferredType parameter as a string.

WebCore:

Reviewed by Timothy Hatcher.


This patch is for the WebKit side of <rdar://problem/5591115>.
We need a way to tell context menu navigations, such as "Open in New Window"
to override any sort of browser preference for tab based navigation.

  • bridge/WindowFeatures.h: (WebCore::WindowFeatures::WindowFeatures): Added a new struct member var, preferredType and an accompanying enum type PreferredType to send a window type recommendation up to the Chrome.


  • page/ContextMenuController.cpp: (WebCore::openNewWindow): Set the window features to recommend a new Window for "Open in New Window" context menu action.
2:25 PM Changeset in webkit [27653] by timothy@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by John.

<rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used

Extend the linked on or after check to every application when a script passed to
stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
was limited to VitalSource Bookshelf, but other developers are running into this.

  • Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
  • WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.
1:43 PM SpecSupport edited by mjs@apple.com
(diff)
1:39 PM SpecSupport edited by mjs@apple.com
(diff)
1:36 PM SpecSupport edited by mjs@apple.com
(diff)
1:31 PM SpecSupport edited by mjs@apple.com
(diff)
1:31 PM SpecSupport edited by mjs@apple.com
(diff)
1:27 PM SpecSupport edited by mjs@apple.com
(diff)
1:23 PM SpecSupport edited by mjs@apple.com
(diff)
1:11 PM SpecSupport edited by mjs@apple.com
(diff)
12:04 PM Changeset in webkit [27652] by Adam Roben
  • 4 edits
    2 adds in trunk

Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick

LayoutTests:

Add a test for <rdar://5483519> Pressing Enter on selected buttons should fire onclick

Reviewed by Adele.

  • fast/forms/enter-clicks-buttons-expected.txt: Added.
  • fast/forms/enter-clicks-buttons.html: Added.

WebCore:

Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick

We now match the behavior of Firefox and IE, which is to always just
send a click event to the focused button when the Enter key is pressed
(previously we were submitting forms directly in some cases).

Reviewed by Adele.

Test: fast/forms/enter-clicks-buttons.html

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't do anything fancy when Enter is pressed on a <button type=button> -- just send a click event like we do for other button types.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Treat type=button the same way we treat type=submit and type=reset: just send a click event when Enter is pressed.
12:03 PM Changeset in webkit [27651] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Antti Koivisto.

  • fix a bug in invisible layer culling: dynamically changing a descendant of an invisible layer to be visible did not work

Test: fast/layers/layer-content-visibility-change.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): If we got visible content, make sure that our stacking context rebuilds its z-order lists to include us.

LayoutTests:

Reviewed by Antti Koivisto.

  • test that dynamically changing a descendant of an invisible layer to be visible works
  • fast/layers/layer-content-visibility-change.html: Added.
  • platform/mac/fast/layers/layer-content-visibility-change-expected.checksum: Added.
  • platform/mac/fast/layers/layer-content-visibility-change-expected.png: Added.
  • platform/mac/fast/layers/layer-content-visibility-change-expected.txt: Added.
11:57 AM Changeset in webkit [27650] by hyatt
  • 3 edits in trunk/WebCore

Clean up matrix() parsing. Make sure the first four arguments can be lengths or numbers. The last two
args can be lengths or numbers or percents.

Reviewed by Beth

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp: (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::CSSParser::parseTransform):
  • rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply):
11:05 AM Changeset in webkit [27649] by Beth Dakin
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5586370> CSS Transform - incorrect matrix
math leads to crazy problems

Transform matrices accept the first four parameters as CSS lengths.
CSS lengths get mapped into WebCore::Lengths as percents by
WebCore::convertToLength(). Percent lengths cannot call value(). It
does not yield a correct result and it asserts on Debug builds.

  • rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply): Instead of calling value() on the lengths, call calcValue. This fixes the assert and the bad rendering.

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5586370> CSS Transform - incorrect matrix
math leads to crazy problems

  • fast/transforms/identity-matrix.html: Added.
  • platform/mac/fast/transforms/identity-matrix-expected.checksum: Added.
  • platform/mac/fast/transforms/identity-matrix-expected.png: Added.
  • platform/mac/fast/transforms/identity-matrix-expected.txt: Added.
9:56 AM Changeset in webkit [27648] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

Reviewed by Darin.

  • kjs/value.h: (KJS::jsNumber): Add some explicit casts.
9:16 AM Changeset in webkit [27647] by sfalken
  • 2 edits in trunk/WebCore

Roll out r27641 since the same bug was already fixed by r27568.

7:35 AM SpecSupport edited by philippe.kalaf@collabora.co.uk
(diff)
7:26 AM SpecSupport edited by mrowe@apple.com
(diff)
6:44 AM WikiStart edited by philippe.kalaf@collabora.co.uk
(diff)
6:41 AM SpecSupport edited by philippe.kalaf@collabora.co.uk
(diff)
6:40 AM SpecSupport edited by philippe.kalaf@collabora.co.uk
(diff)
6:36 AM SpecSupport created by philippe.kalaf@collabora.co.uk
6:33 AM Changeset in webkit [27646] by hausmann
  • 2 edits in trunk/WebCore

userIdleTime() is stubbed in win/SystemTimeWin.cpp, so don't
define it twice for the Qt/Windows build.

5:09 AM Changeset in webkit [27645] by hausmann
  • 3 edits in trunk/WebKit/qt

Implemented the webcore actions for changing the text direction.

Signed-off-by: Holger

5:09 AM Changeset in webkit [27644] by hausmann
  • 9 edits in trunk

Fix ContextMenu allocation in the Qt port.

Store all items and submenus value based in ContextMenu and ContextMenuItem.
That fixes the crashes when the context menu was populated with sub-menus because
of the use of temporary ContextMenu objects like this:

ContextMenu subMenu(...);
subMenu.appendItem(...);
subMenu.appendItem(...);

subMenuItem.setSubMenu(&subMenu); temporary pointer, need to _copy_ contents

Signed-off-by: Holger

5:09 AM Changeset in webkit [27643] by hausmann
  • 3 edits in trunk/WebKit/qt

Renamed QWebPage::NumWebActions to QWebPage::WebActionCount (for consistency) and fixed its value.

Signed-off-by: Holger

4:51 AM Changeset in webkit [27642] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-09 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15909
Malformed GIFs should not result in memory corruption.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
1:01 AM Changeset in webkit [27641] by sfalken
  • 2 edits in trunk/WebCore

Initialize WindowFeatures struct before using it.


Reviewed by Oliver.

  • page/ContextMenuController.cpp: (WebCore::openNewWindow):
12:29 AM Changeset in webkit [27640] by kmccullo
  • 5 edits in trunk/WebKit/win

Reviewed by Adam.

  • This patch does two main things. 1) It adds pragma warning guards around WebCore includes in WebKit files that were previously overlooked. 2) It implements almost the entireity of WebScriptDebugger. Only one function remains and that implementation is dependent on finishing the implementation of WebScriptScope.
  • WebScriptCallFrame.h:
  • WebScriptDebugServer.h:
  • WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): (WebScriptDebugger::enterFrame): (WebScriptDebugger::leaveFrame):
  • WebScriptDebugger.h:
12:26 AM Changeset in webkit [27639] by kmccullo
  • 4 edits
    5 adds in trunk/WebKitTools

Reviewed by Adam.

  • Changed the vcproj file to use Drosera's ForwardingHeaders and not WebCore's!
  • Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
  • Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
  • Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
  • Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
  • Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
  • Drosera/win/Drosera.cpp:
  • Drosera/win/Drosera.vcproj/Drosera.vcproj:

Nov 8, 2007:

11:06 PM Changeset in webkit [27638] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-08 Timothy Hatcher <​timothy@apple.com>

Reviewed by Sam Weinig.

Some Web Inspector CSS editing changes.

  • Only delete the property if all the text is delete or the new user input correctly parses. This prevents deleting the existing property if the new text is invalid.
  • Intercept the Escape key and cancel editing, not saving any changes.
  • page/inspector/StylesSidebarPane.js:
9:57 PM Changeset in webkit [27637] by Darin Adler
  • 4 edits in trunk/JavaScriptCore
  • fix build
  • kjs/grammar.y:
  • kjs/nodes.h:
  • kjs/property_map.cpp:
9:56 PM Changeset in webkit [27636] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • roll out accidentally-checked in changes
  • kjs/nodes.cpp: Back to previous version.
  • kjs/nodes.h: Ditto.
  • kjs/grammar.y: Ditto.
9:55 PM Changeset in webkit [27635] by Darin Adler
  • 3 edits in trunk/JavaScriptCore
  • roll out accidentally-checked in changes
  • kjs/nodes.cpp: Back to previous version.
  • kjs/nodes.h: Ditto.
9:51 PM Changeset in webkit [27634] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/property_map.cpp: (KJS::PropertyMap::getEnumerablePropertyNames): Use insertion sort instead of qsort for small sets of property names. We can probably do some even-better speedups of for/in, but this nets 0.6% overall and 6.7% on fasta.
9:50 PM Changeset in webkit [27633] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

This fixes one source of the slowness -- the conversion to an unused
Identifier as we call the get function from the slot -- but doesn't
fix others, such as the fact that we have to allocate a new UString::Rep
for every single character.

Speeds up string-base64 30%, and at least 0.5% overall.
But does slow down access-fannkuch quite a bit. Might be worth
revisiting in the future to see what we can do about that (although
I did look at a profile for a while).

  • kjs/property_slot.h: Add a new marker for "numeric" property slots; slots where we don't need to pass the identifier to the get function. (KJS::PropertySlot::getValue): Added code to call the numeric get function. (KJS::PropertySlot::setCustomNumeric): Added.
  • kjs/string_object.cpp: (KJS::StringInstance::indexGetter): Changed to use substr() instead of constructing a wholly new UString each time. (KJS::stringInstanceNumericPropertyGetter): Added. Like indexGetter, but takes advantage of setCustomNumeric to avoid creating an Identifier. (KJS::StringInstance::getOwnPropertySlot): Changed to use setCustomNumeric.
9:48 PM Changeset in webkit [27632] by Darin Adler
  • 6 edits in trunk/JavaScriptCore

Reviewed by Oliver.

1% improvement of SunSpider

  • kjs/JSImmediate.h: Eliminate the now-unneeded FPBitValues struct template. (KJS::JSImmediate::from): Overload for most numeric types; many types can do fewer branches and checks. (KJS::JSImmediate::getUInt32): Removed unneeded check for undefined. (KJS::JSImmediate::getTruncatedInt32): Ditto. (KJS::JSImmediate::getTruncatedUInt32): Ditto. There's no difference any more between getUInt32 and getTruncatedUInt32, so that's worth a rename and merge later.
  • kjs/grammar.y: Update since fromDouble is now just from.
  • kjs/nodes.h: Ditto.
  • kjs/value.h: (KJS::jsNumber): Overload for most numeric types.
9:38 PM Changeset in webkit [27631] by kevino@webkit.org
  • 3 edits
    37 adds in trunk

Adding Bakefiles for JSCore, WebCore, and WebKit, and adding wxWebKit implementation.

Reviewed by Mark Rowe

8:32 PM Changeset in webkit [27630] by oliver
  • 3 edits
    2 adds in trunk

Fix regression caused by earlier bitwise and optimisation. 1 & undefined != 1.

Reviewed by Maciej.

The implementation of JSImmediate::areBothImmediateNumbers relies on
(JSImmediate::getTag(immediate1) & JSImmediate::getTag(immediate2)) having
a unique result when both immediate values are numbers.

The regression was due to UndefinedType & NumberType returning NumberType (3 & 1).
By swapping the value of NumberType and UndefinedType this ceases to be a problem.

7:13 PM Changeset in webkit [27629] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-11-08 Justin Haygood <​jhaygood@reaktix.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15905

Fix builds with HTML 5 Storage support disabled.
ENABLE(DATABASE) needs to be added in a few places.

  • page/InspectorController.cpp:
  • storage/Database.h:
6:03 PM Changeset in webkit [27628] by sfalken
  • 3 edits in trunk/WebKit/win

Bump versions for submit

5:48 PM Changeset in webkit [27627] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

5:39 PM Changeset in webkit [27626] by sfalken
  • 1 edit in trunk/WebKit/win/ChangeLog

Fix typo in ChangeLog.

5:32 PM Changeset in webkit [27625] by sfalken
  • 2 edits in trunk/WebKit/win

<rdar://problem/5491463> Wrong dates shown in History menu.


Fix off-by-one error in Windows epoch.


For the Windows DATE type, 1/1/1900 should be 2.0, not 1.0.
DATE is the number of dates since 12/30/1899.


Reviewed by Ada.

  • MarshallingHelpers.cpp: (MarshallingHelpers::windowsEpochAbsoluteTime):
5:13 PM Changeset in webkit [27624] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-08 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15653
[GTK] Text editor does not handle common keystrokes

Handle more keystrokes in EditorClientGtk. Note that this is a
temporary measure pending a proper solution using GtkBindingSet (see
​http://bugs.webkit.org/show_bug.cgi?id=15911).

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):
5:04 PM Changeset in webkit [27623] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • fix build
  • kjs/nodes.h: Add missing parameter name.
4:43 PM Changeset in webkit [27622] by eseidel
  • 4 edits in trunk/JavaScriptCore

2007-11-08 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

Add ExpressionNode subclass of Node, use it.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::ForInNode::ForInNode):
  • kjs/nodes.h: (KJS::ExpressionNode::): (KJS::NullNode::): (KJS::NullNode::precedence): (KJS::BooleanNode::): (KJS::BooleanNode::precedence): (KJS::RegExpNode::): (KJS::RegExpNode::precedence): (KJS::ThisNode::): (KJS::ThisNode::precedence): (KJS::ResolveNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNode::): (KJS::PropertyNode::precedence): (KJS::PropertyNode::name): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::ObjectLiteralNode::precedence): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::DotAccessorNode::precedence): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::NewExprNode::precedence): (KJS::FunctionCallValueNode::): (KJS::FunctionCallValueNode::precedence): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallBracketNode::precedence): (KJS::FunctionCallDotNode::): (KJS::FunctionCallDotNode::precedence): (KJS::PrePostResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixBracketNode::precedence): (KJS::PostIncBracketNode::): (KJS::PostIncBracketNode::isIncrement): (KJS::PostDecBracketNode::): (KJS::PostDecBracketNode::isIncrement): (KJS::PostfixDotNode::): (KJS::PostfixDotNode::precedence): (KJS::PostIncDotNode::): (KJS::PostIncDotNode::isIncrement): (KJS::PostDecDotNode::): (KJS::PostDecDotNode::isIncrement): (KJS::PostfixErrorNode::): (KJS::PostfixErrorNode::precedence): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteBracketNode::precedence): (KJS::DeleteDotNode::): (KJS::DeleteDotNode::precedence): (KJS::DeleteValueNode::): (KJS::DeleteValueNode::precedence): (KJS::VoidNode::): (KJS::VoidNode::precedence): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixBracketNode::): (KJS::PrefixBracketNode::precedence): (KJS::PreIncBracketNode::): (KJS::PreIncBracketNode::isIncrement): (KJS::PreDecBracketNode::): (KJS::PreDecBracketNode::isIncrement): (KJS::PrefixDotNode::): (KJS::PrefixDotNode::precedence): (KJS::PreIncDotNode::): (KJS::PreIncDotNode::isIncrement): (KJS::PreDecDotNode::): (KJS::PreDecDotNode::isIncrement): (KJS::PrefixErrorNode::): (KJS::PrefixErrorNode::precedence): (KJS::UnaryPlusNode::): (KJS::UnaryPlusNode::precedence): (KJS::NegateNode::): (KJS::NegateNode::precedence): (KJS::BitwiseNotNode::): (KJS::BitwiseNotNode::precedence): (KJS::LogicalNotNode::): (KJS::LogicalNotNode::precedence): (KJS::AddNode::): (KJS::AddNode::precedence): (KJS::LeftShiftNode::): (KJS::LeftShiftNode::precedence): (KJS::RightShiftNode::): (KJS::RightShiftNode::precedence): (KJS::UnsignedRightShiftNode::): (KJS::UnsignedRightShiftNode::precedence): (KJS::LessNode::): (KJS::LessNode::precedence): (KJS::GreaterNode::): (KJS::GreaterNode::precedence): (KJS::LessEqNode::): (KJS::LessEqNode::precedence): (KJS::GreaterEqNode::): (KJS::GreaterEqNode::precedence): (KJS::InstanceOfNode::): (KJS::InstanceOfNode::precedence): (KJS::InNode::): (KJS::InNode::precedence): (KJS::EqualNode::): (KJS::EqualNode::precedence): (KJS::NotEqualNode::): (KJS::NotEqualNode::precedence): (KJS::StrictEqualNode::): (KJS::StrictEqualNode::precedence): (KJS::NotStrictEqualNode::): (KJS::NotStrictEqualNode::precedence): (KJS::BitAndNode::): (KJS::BitAndNode::precedence): (KJS::BitOrNode::): (KJS::BitOrNode::precedence): (KJS::BitXOrNode::): (KJS::BitXOrNode::precedence): (KJS::LogicalAndNode::): (KJS::LogicalAndNode::precedence): (KJS::LogicalOrNode::): (KJS::LogicalOrNode::precedence): (KJS::ConditionalNode::): (KJS::ConditionalNode::precedence): (KJS::ReadModifyResolveNode::): (KJS::ReadModifyResolveNode::precedence): (KJS::AssignResolveNode::): (KJS::AssignResolveNode::precedence): (KJS::ReadModifyBracketNode::): (KJS::ReadModifyBracketNode::precedence): (KJS::AssignBracketNode::): (KJS::AssignBracketNode::precedence): (KJS::AssignDotNode::): (KJS::AssignDotNode::precedence): (KJS::ReadModifyDotNode::): (KJS::ReadModifyDotNode::precedence): (KJS::AssignErrorNode::): (KJS::AssignErrorNode::precedence): (KJS::CommaNode::): (KJS::CommaNode::precedence): (KJS::AssignExprNode::): (KJS::AssignExprNode::precedence): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::ThrowNode::): (KJS::ParameterNode::): (KJS::CaseClauseNode::): (KJS::CaseClauseNode::precedence): (KJS::ClauseListNode::): (KJS::SwitchNode::):
4:09 PM Changeset in webkit [27621] by weinig@apple.com
  • 2 edits in trunk

Correct ChangeLogs to reflect that the speedup was 1% not .5%. Turns out you are not supposed to test in Debug builds.

3:51 PM Changeset in webkit [27620] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed bug title in old check-in.

3:49 PM Changeset in webkit [27619] by sfalken
  • 2 edits in trunk/WebCore

<rdar://problem/5524082> Allow images to be dragged out directly into other apps


We weren't including CF_HDROP in our image drops. This broke drag of
images out of the browser window directly into other apps (examples
include notepad, mspaint, msword).


Reviewed by Oliver, Ada.

  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileContent): Removed unused variable. (WebCore::createGlobalHDropContent): Added (WebCore::writeFileToDataObject): Write HDROP data if available. (WebCore::writeImageToDataObject): Write HDROP for dragged images. (WebCore::ClipboardWin::writeURL): Don't write HDROP for dragged URLs.
3:31 PM Changeset in webkit [27618] by alp@webkit.org
  • 3 edits in trunk/WebCore

2007-11-08 Xan Lopez <​xan@gnome.org>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15908
Use g_object_ref_sink when available

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
2:59 PM Changeset in webkit [27617] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Beth Dakin.

  • fix <rdar://problem/5491922> REGRESSION (Safari 2-3): Flash-based "Cash Optimizer" on etrade.com does not draw completely

Test: fast/dom/length-attribute-mapping.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSLength): Changed the garbage-stripping logic to stop after the first "%" or "*" in the string. This allows for "100%25" to be mapped to "100%" like it is in Firefox and WinIE.

LayoutTests:

Reviewed by Beth Dakin.

  • test for <rdar://problem/5491922> REGRESSION (Safari 2-3): Flash-based "Cash Optimizer" on etrade.com does not draw completely
  • fast/dom/length-attribute-mapping-expected.txt: Added.
  • fast/dom/length-attribute-mapping.html: Added.
2:26 PM Changeset in webkit [27616] by kmccullo
  • 4 edits in trunk

WebCore:

  • Build fix.
  • loader/FrameLoaderClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::windowObjectCleared):

WebKit/mac:

Build Fix.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::windowObjectCleared):
2:23 PM Changeset in webkit [27615] by oliver
  • 4 edits in trunk/JavaScriptCore

Add a fast path for bitwise-and of two immediate numbers for a 0.7% improvement in SunSpider (4% bitop improvement).

Reviewed by Sam.

This only improves bitwise-and performance, as the additional logic required
for similar code paths on or, xor, and shifting requires additional operations
and branches that negate (and in certain cases, regress) any advantage we might
otherwise receive.

This improves performance on all bitop tests, the cryptography tests, as well as
the string-base64 and string-unpack-code tests. No significant degradation on
any other tests.

1:49 PM Changeset in webkit [27614] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Stop using KJS inside of MathExtras.h

Reviewed by Darin.

  • wtf/MathExtras.h: Removed an unused header, and a now-unused forward-declaration. (wtf_atan2): Use std::numeric_limits intead of KJS.
1:45 PM Changeset in webkit [27613] by kmccullo
  • 3 edits in trunk/WebKitTools

Reviewed by Sam.

  • Use the new IWebFrame [local] function signature and get the shared server correctly.
  • Drosera/win/DebuggerClient.cpp: (DebuggerClient::didFinishLoadForFrame):
  • Drosera/win/ServerConnection.cpp: (ServerConnection::attemptToCreateServerConnection):
1:43 PM Changeset in webkit [27612] by kmccullo
  • 24 edits
    2 adds in trunk

WebCore:

Reviewed by Sam.

  • windowObjectCleared() is no longer const. It needs to setup the script debugger and cannot be const to do so.
  • loader/FrameLoaderClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::windowObjectCleared):

WebKit/gtk:

Reviewed by Sam.

  • windowObjectCleared() is no longer const. It needs to setup the script debugger and cannot be const to do so.
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::windowObjectCleared):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/qt:

Reviewed by Sam.

  • windowObjectCleared() is no longer const. It needs to setup the script debugger and cannot be const to do so.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::windowObjectCleared):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam.

  • With this change Drosera can now get the source of a website and the listings of the sources it gets. This also lays the foundation for letting Drosera show the scope chain of the JavaScript stack.
  • Interfaces/IWebFrame.idl: Changed the signature of the local function, globalContext(), because COM was unable to marshal this object with the other signature.
  • Interfaces/IWebScriptDebugServer.idl: Of course adding and removing a listener cannot be done in a const function.
  • WebChromeClient.h: Added accessor to the WebView for the new added kit() function in WebFrame. (WebChromeClient::webView):
  • WebFrame.cpp: Added a script debugger object and the necessary functions to attach and communicate with it. Also needed to change the local function, globalContext(), because of a COM issue. (kit): (WebFrame::WebFrame): (WebFrame::globalContext): (WebFrame::loadData): (WebFrame::attachScriptDebugger): (WebFrame::detachScriptDebugger): (WebFrame::dispatchDidLoadMainResource): (WebFrame::windowObjectCleared):
  • WebFrame.h: Ditto.
  • WebHTMLRepresentation.cpp: Implemented documentSource so Drosera has some source code to display. (WebHTMLRepresentation::WebHTMLRepresentation): (WebHTMLRepresentation::documentSource):
  • WebKit.vcproj/WebKit.vcproj: Added the new WebScriptDebugger class.
  • WebScriptCallFrame.cpp: Implemented much of this class' functionality. (EnumScopes::EnumScopes): Made an EnumScopes class to create an IEnumVARIANT to wrap a ScopeChain for Drosera. (EnumScopes::QueryInterface): (EnumScopes::AddRef): (EnumScopes::Release): (EnumScopes::Next): (EnumScopes::Skip): (EnumScopes::Reset): (EnumScopes::Clone): (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
  • WebScriptCallFrame.h: Added member data needed for the above functions
  • WebScriptDebugServer.cpp: Began implementing. (WebScriptDebugServer::listenerCount): (EnumViews::QueryInterface): (EnumViews::AddRef): (EnumViews::Release): (EnumViews::Next): (EnumViews::Skip): (EnumViews::Reset): (EnumViews::Clone): (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::createInstance): (WebScriptDebugServer::sharedWebScriptDebugServer): (WebScriptDebugServer::AddRef): (WebScriptDebugServer::Release): (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused): (WebScriptDebugServer::suspendProcessIfPaused): (WebScriptDebugServer::didLoadMainResourceForDataSource): (WebScriptDebugServer::didParseSource): (WebScriptDebugServer::failedToParseSource): (WebScriptDebugServer::didEnterCallFrame): (WebScriptDebugServer::willExecuteStatement): (WebScriptDebugServer::willLeaveCallFrame): (WebScriptDebugServer::exceptionWasRaised):
  • WebScriptDebugServer.h: Began implementing.
  • WebScriptDebugger.cpp: Added. (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed):
  • WebScriptDebugger.h: Added.
  • WebScriptScope.cpp: Make this class use createInstance which is more in line with our guidelines. (WebScriptScope::WebScriptScope): (WebScriptScope::createInstance):
  • WebScriptScope.h:
1:27 PM Changeset in webkit [27611] by Adam Roben
  • 2 edits in trunk/WebCore

Hopeful Windows build fix

  • rendering/RenderObject.cpp: Touch this file to make it recompile.
1:26 PM Changeset in webkit [27610] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/date_object.cpp: (KJS::DateProtoFuncToLocaleString::callAsFunction): Fix unused arg warning. (KJS::DateProtoFuncToLocaleDateString::callAsFunction): ditto (KJS::DateProtoFuncToLocaleTimeString::callAsFunction): ditto
1:03 PM Changeset in webkit [27609] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-08 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/lookup.h: Add missing include.
12:31 PM Changeset in webkit [27608] by weinig@apple.com
  • 29 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Convert JavaScript internal function objects to use one class per
function. This avoids a switch statement inside what used to be
the shared function classes and will allow Shark to better analyze
the code.

To make this switch, the value property of the HashEntry was changed
to a union of an intptr_t (which is used to continue handle valueGetters)
and function pointer which points to a static constructor for the
individual new function objects.

SunSpider claims this is a 0.5% speedup.

  • kjs/array_object.cpp: (KJS::ArrayPrototype::getOwnPropertySlot): (KJS::getProperty): (KJS::ArrayProtoFuncToString::callAsFunction): (KJS::ArrayProtoFuncToLocaleString::callAsFunction): (KJS::ArrayProtoFuncJoin::callAsFunction): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncPop::callAsFunction): (KJS::ArrayProtoFuncPush::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction): (KJS::ArrayProtoFuncForEach::callAsFunction): (KJS::ArrayProtoFuncSome::callAsFunction): (KJS::ArrayProtoFuncIndexOf::callAsFunction): (KJS::ArrayProtoFuncLastIndexOf::callAsFunction):
  • kjs/array_object.h: (KJS::ArrayPrototype::classInfo):
  • kjs/create_hash_table:
  • kjs/date_object.cpp: (KJS::DatePrototype::getOwnPropertySlot): (KJS::DateProtoFuncToString::callAsFunction): (KJS::DateProtoFuncToUTCString::callAsFunction): (KJS::DateProtoFuncToDateString::callAsFunction): (KJS::DateProtoFuncToTimeString::callAsFunction): (KJS::DateProtoFuncToLocaleString::callAsFunction): (KJS::DateProtoFuncToLocaleDateString::callAsFunction): (KJS::DateProtoFuncToLocaleTimeString::callAsFunction): (KJS::DateProtoFuncValueOf::callAsFunction): (KJS::DateProtoFuncGetTime::callAsFunction): (KJS::DateProtoFuncGetFullYear::callAsFunction): (KJS::DateProtoFuncGetUTCFullYear::callAsFunction): (KJS::DateProtoFuncToGMTString::callAsFunction): (KJS::DateProtoFuncGetMonth::callAsFunction): (KJS::DateProtoFuncGetUTCMonth::callAsFunction): (KJS::DateProtoFuncGetDate::callAsFunction): (KJS::DateProtoFuncGetUTCDate::callAsFunction): (KJS::DateProtoFuncGetDay::callAsFunction): (KJS::DateProtoFuncGetUTCDay::callAsFunction): (KJS::DateProtoFuncGetHours::callAsFunction): (KJS::DateProtoFuncGetUTCHours::callAsFunction): (KJS::DateProtoFuncGetMinutes::callAsFunction): (KJS::DateProtoFuncGetUTCMinutes::callAsFunction): (KJS::DateProtoFuncGetSeconds::callAsFunction): (KJS::DateProtoFuncGetUTCSeconds::callAsFunction): (KJS::DateProtoFuncGetMilliSeconds::callAsFunction): (KJS::DateProtoFuncGetUTCMilliseconds::callAsFunction): (KJS::DateProtoFuncGetTimezoneOffset::callAsFunction): (KJS::DateProtoFuncSetTime::callAsFunction): (KJS::DateProtoFuncSetMilliSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCMilliseconds::callAsFunction): (KJS::DateProtoFuncSetSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCSeconds::callAsFunction): (KJS::DateProtoFuncSetMinutes::callAsFunction): (KJS::DateProtoFuncSetUTCMinutes::callAsFunction): (KJS::DateProtoFuncSetHours::callAsFunction): (KJS::DateProtoFuncSetUTCHours::callAsFunction): (KJS::DateProtoFuncSetDate::callAsFunction): (KJS::DateProtoFuncSetUTCDate::callAsFunction): (KJS::DateProtoFuncSetMonth::callAsFunction): (KJS::DateProtoFuncSetUTCMonth::callAsFunction): (KJS::DateProtoFuncSetFullYear::callAsFunction): (KJS::DateProtoFuncSetUTCFullYear::callAsFunction): (KJS::DateProtoFuncSetYear::callAsFunction): (KJS::DateProtoFuncGetYear::callAsFunction):
  • kjs/date_object.h:
  • kjs/lookup.cpp: (KJS::Lookup::find):
  • kjs/lookup.h: (KJS::HashEntry::): (KJS::staticFunctionGetter): (KJS::staticValueGetter): (KJS::getStaticPropertySlot): (KJS::getStaticFunctionSlot): (KJS::lookupPut):
  • kjs/math_object.cpp: (KJS::MathObjectImp::getOwnPropertySlot): (KJS::MathProtoFuncAbs::callAsFunction): (KJS::MathProtoFuncACos::callAsFunction): (KJS::MathProtoFuncASin::callAsFunction): (KJS::MathProtoFuncATan::callAsFunction): (KJS::MathProtoFuncATan2::callAsFunction): (KJS::MathProtoFuncCeil::callAsFunction): (KJS::MathProtoFuncCos::callAsFunction): (KJS::MathProtoFuncExp::callAsFunction): (KJS::MathProtoFuncFloor::callAsFunction): (KJS::MathProtoFuncLog::callAsFunction): (KJS::MathProtoFuncMax::callAsFunction): (KJS::MathProtoFuncMin::callAsFunction): (KJS::MathProtoFuncPow::callAsFunction): (KJS::MathProtoFuncRandom::callAsFunction): (KJS::MathProtoFuncRound::callAsFunction): (KJS::MathProtoFuncSin::callAsFunction): (KJS::MathProtoFuncSqrt::callAsFunction): (KJS::MathProtoFuncTan::callAsFunction):
  • kjs/math_object.h: (KJS::MathObjectImp::classInfo): (KJS::MathObjectImp::):
  • kjs/string_object.cpp: (KJS::StringPrototype::getOwnPropertySlot): (KJS::StringProtoFuncToString::callAsFunction): (KJS::StringProtoFuncValueOf::callAsFunction): (KJS::StringProtoFuncCharAt::callAsFunction): (KJS::StringProtoFuncCharCodeAt::callAsFunction): (KJS::StringProtoFuncConcat::callAsFunction): (KJS::StringProtoFuncIndexOf::callAsFunction): (KJS::StringProtoFuncLastIndexOf::callAsFunction): (KJS::StringProtoFuncMatch::callAsFunction): (KJS::StringProtoFuncSearch::callAsFunction): (KJS::StringProtoFuncReplace::callAsFunction): (KJS::StringProtoFuncSlice::callAsFunction): (KJS::StringProtoFuncSplit::callAsFunction): (KJS::StringProtoFuncSubstr::callAsFunction): (KJS::StringProtoFuncSubstring::callAsFunction): (KJS::StringProtoFuncToLowerCase::callAsFunction): (KJS::StringProtoFuncToUpperCase::callAsFunction): (KJS::StringProtoFuncToLocaleLowerCase::callAsFunction): (KJS::StringProtoFuncToLocaleUpperCase::callAsFunction): (KJS::StringProtoFuncLocaleCompare::callAsFunction): (KJS::StringProtoFuncBig::callAsFunction): (KJS::StringProtoFuncSmall::callAsFunction): (KJS::StringProtoFuncBlink::callAsFunction): (KJS::StringProtoFuncBold::callAsFunction): (KJS::StringProtoFuncFixed::callAsFunction): (KJS::StringProtoFuncItalics::callAsFunction): (KJS::StringProtoFuncStrike::callAsFunction): (KJS::StringProtoFuncSub::callAsFunction): (KJS::StringProtoFuncSup::callAsFunction): (KJS::StringProtoFuncFontcolor::callAsFunction): (KJS::StringProtoFuncFontsize::callAsFunction): (KJS::StringProtoFuncAnchor::callAsFunction): (KJS::StringProtoFuncLink::callAsFunction):
  • kjs/string_object.h:

WebCore:

Reviewed by Darin.

Convert JavaScript internal function objects to use one class per
function. This avoids a switch statement inside what used to be
the shared function classes and will allow Shark to better analyze
the code.

To make this switch, the value property of the HashEntry was changed
to a union of an intptr_t (which is used to continue handle valueGetters)
and function pointer which points to a static constructor for the
individual new function objects.

SunSpider claims this is a 0.5% speedup.

  • On the WebCore side, I updated CodeGeneratorJS.pm to generate the new classes and hand updated the remain non-generated (groan) classes.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNodePrototypeFunctionAddEventListener::callAsFunction): (WebCore::JSEventTargetNodePrototypeFunctionRemoveEventListener::callAsFunction): (WebCore::JSEventTargetNodePrototypeFunctionDispatchEvent::callAsFunction):
  • bindings/js/JSEventTargetNode.h:
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBaseFunctionSetSelectionRange::callAsFunction): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
  • bindings/js/JSHTMLInputElementBase.h: (WebCore::JSHTMLInputElementBase::):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunctionAbort::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionGetAllResponseHeaders::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionGetResponseHeader::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionOpen::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionSend::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionSetRequestHeader::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionOverrideMIMEType::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionAddEventListener::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionRemoveEventListener::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionDispatchEvent::callAsFunction):
  • bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::impl):
  • bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessorPrototypeFunctionImportStylesheet::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionTransformToFragment::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionTransformToDocument::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionSetParameter::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionGetParameter::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionRemoveParameter::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionClearParameters::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionReset::callAsFunction):
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_events.cpp: (WebCore::JSClipboardPrototypeFunctionClearData::callAsFunction): (WebCore::JSClipboardPrototypeFunctionGetData::callAsFunction): (WebCore::JSClipboardPrototypeFunctionSetData::callAsFunction): (WebCore::JSClipboardPrototypeFunctionSetDragImage::callAsFunction):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_navigator.cpp: (KJS::Plugins::): (KJS::Navigator::getOwnPropertySlot): (KJS::Plugins::getOwnPropertySlot): (KJS::PluginsFunctionRefresh::callAsFunction): (KJS::NavigatorProtoFuncJavaEnabled::callAsFunction):
  • bindings/js/kjs_navigator.h: (KJS::Navigator::):
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncBToA::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncScrollBy::callAsFunction): (KJS::WindowProtoFuncScrollTo::callAsFunction): (KJS::WindowProtoFuncMoveBy::callAsFunction): (KJS::WindowProtoFuncMoveTo::callAsFunction): (KJS::WindowProtoFuncResizeBy::callAsFunction): (KJS::WindowProtoFuncResizeTo::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncShowModalDialog::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction): (KJS::LocationProtoFuncToString::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm:
12:22 PM Changeset in webkit [27607] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

Reviewed by Sam and Ada.

  • wtf/MathExtras.h: Get rid of a circular #include dependency to fix the build.
11:58 AM Changeset in webkit [27606] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Fix a precedence warning on Windows

  • kjs/JSImmediate.h: (KJS::JSImmediate::toBoolean):
11:49 AM Changeset in webkit [27605] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-08 Mark Rowe <​mrowe@apple.com>

Build fix for JavaScriptGlue.

  • wtf/MathExtras.h: Include stdlib.h for srand and RAND_MAX.
11:45 AM Changeset in webkit [27604] by mrowe@apple.com
  • 1 edit
    1 add in trunk/JavaScriptGlue

2007-11-08 Mark Rowe <​mrowe@apple.com>

Build fix.

  • ForwardingHeaders/wtf/MathExtras.h: Copied from WebCore/ForwardingHeaders/wtf/MathExtras.h.
11:38 AM Changeset in webkit [27603] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • Windows build fix
  • kjs/JSImmediate.h: Include MathExtras.h rather than math.h since this file uses "signbit".
10:27 AM Changeset in webkit [27602] by oliver
  • 3 edits in trunk/JavaScriptCore

Replace the use of floats for immediate values with the use of integers for a 4.5% improvement in SunSpider.

Reviewed by Darin.

Unfortunately this change results in NaN, +Inf, -Inf, and -0 being heap allocated now, but
we should now have faster array access, faster immediate to double conversion, and the
potential to further improve bitwise operators in future.

This also removes the need for unions to avoid strict aliasing problems when extracting
a value from immediates.

  • kjs/JSImmediate.h:

(KJS::):
(KJS::JSImmediate::trueImmediate):
(KJS::JSImmediate::falseImmediate):
(KJS::JSImmediate::undefinedImmediate):
(KJS::JSImmediate::nullImmediate):
(KJS::JSImmediate::toBoolean):

  • kjs/value.h:

(KJS::jsNaN):

9:18 AM Changeset in webkit [27601] by mrowe@apple.com
  • 4 edits in trunk/WebCore

2007-11-08 Mark Rowe <​mrowe@apple.com>

Fix the Gtk, Qt and Wx builds.

  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
8:50 AM Changeset in webkit [27600] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-11-08 Mark Rowe <​mrowe@apple.com>

Not reviewed. Fix two instances of includes using the wrong case in the filename.

  • platform/graphics/mac/MoviePrivateQTKit.mm:
  • platform/wx/MimeTypeRegistryWx.cpp:
7:42 AM Changeset in webkit [27599] by Darin Adler
  • 5 edits in trunk

WebCore:

Reviewed by Adam.

  • fix <rdar://problem/5552943> accesskey does not focus <button> elements

Test: fast/forms/access-key.html

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): Added a call to focus.

LayoutTests:

Reviewed by Adam.

  • test changes for <rdar://problem/5552943> accesskey does not focus <button> elements
  • fast/forms/access-key.html: Check for both focus and click events on all elements, but resisted the urge to switch to the American spelling for "focused".
  • fast/forms/access-key-expected.txt: Updated to reflect the bug fix ("1 button focussed"), the fact that <input type=button>, <input type=checkbox>, <input type=submit>, and <input type=reset> are all both focused and clicked ("2 input type button clicked", "3 input type checkbox clicked", "5 input type submit focussed", and "6 input type reset focussed"). Unfortunately this now also demonstrates that we don't send a click to <input type=text> and Gecko does. And there are still quite a few types that are not covered.
7:40 AM Changeset in webkit [27598] by Darin Adler
  • 31 edits
    3 deletes in trunk

WebCore:

Reviewed by Steve.

  • cut down on notImplemented() functions on Windows
  • bridge/AXObjectCache.h: Put #if around the accessibility global.
  • bridge/win/FrameWin.cpp: (WebCore::Frame::setNeedsReapplyStyles): Moved here from TemporaryLinkStubs.
  • dom/Document.cpp: (WebCore::Document::lastModified): Re-implemented using the ResourceResponse that's now available from the DocumentLoader.
  • editing/JSEditor.cpp: (execTranspose): Changed to call transpose() on the Editor instead of the obsolete one on the Frame.
  • loader/DocumentLoader.h: Removed getResponseModifiedHeader.
  • loader/FrameLoader.h: Removed overrideMediaType.
  • loader/gtk/DocumentLoaderGtk.cpp: Removed.
  • loader/mac/DocumentLoaderMac.mm: Removed.
  • loader/qt/DocumentLoaderQt.cpp: Removed.
  • page/Frame.cpp: Removed transpose.
  • page/Frame.h: Ditto.
  • page/FrameView.h: Removed updateBorder.
  • page/gtk/FrameGtk.cpp: Removed issueTransposeCommand.
  • page/mac/FrameMac.mm: Ditto.
  • page/mac/WebCoreFrameBridge.h: Removed issueTransposeCommand and overrideMediaType.
  • page/qt/FrameQt.cpp: Removed issueTransposeCommand.
  • platform/gtk/TemporaryLinkStubs.cpp: Removed gAccessibilityEnabled.
  • platform/qt/TemporaryLinkStubs.cpp: Ditto.
  • platform/win/TemporaryLinkStubs.cpp: Removed or moved all but 3 of the stubs.
  • platform/wx/TemporaryLinkStubs.cpp: Removed gAccessibilityEnabled, issueTransposeCommand, and overrideMediaType.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loadsBlocked): Moved here from TemporaryLinkStubs. (WebCore::ResourceHandle::willLoadFromCache): Ditto.
  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::clip): Ditto.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::inWindow): Ditto.
  • platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime): Ditto.
  • platform/win/WidgetWin.cpp: (WebCore::Widget::setIsSelected): Ditto.
  • WebCore.pro: Updated for removed files.
  • WebCore.xcodeproj/project.pbxproj: Updated for removed file.

WebKit/mac:

Reviewed by Steve.

  • removed some unused WebCore bridge methods
  • WebCoreSupport/WebFrameBridge.mm: Removed issueTransposeCommand and overrideMediaType.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::overrideMediaType): Changed to call WebView directly instead of using the bridge object.

WebKit/win:

Reviewed by Steve.

  • Interfaces/IWebUIDelegate.idl: Added the functions needed below.
  • WebChromeClient.cpp: (WebChromeClient::setMenubarVisible): Eliminated the notImplemented() here by calling through the UI delegate. (WebChromeClient::menubarVisible): Ditto. (WebChromeClient::runDatabaseSizeLimitPrompt): Ditto.
7:12 AM Changeset in webkit [27597] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-11-08 Mark Rowe <​mrowe@apple.com>

Build fix for case-sensitive file systems. Fix case of file names
in #include's.

  • html/HTMLMediaElement.cpp:
  • platform/graphics/Movie.cpp:
6:18 AM Changeset in webkit [27596] by hausmann
  • 2 edits in trunk/WebKit/qt

Build fix for Qt 4.3.

12:20 AM Changeset in webkit [27595] by hausmann
  • 2 edits in trunk/WebCore

Remove some warnings about not implemented methods.

  • ResourceHandle::loadsBlocked and ResourceHandle::supportsBufferedData are specific to the NS API and won't be implemented on Qt.
  • ResourceHandle::bufferedData can not be reached as we return false in ResourceHandle::supportsBufferedData.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

12:20 AM Changeset in webkit [27594] by hausmann
  • 4 edits in trunk

Cleanup checking for the request method.

  • Check the request method only in QWebNetworkManager::add.
  • Currently HEAD, GET, POST are allowed and for everything else QWebNetworkManager::add returns false.
  • Returning false is compatible with ResourceHandle::start and it can be used in ResourceHandle::loadResourceSynchronously to generate a ResourceError

Signed-off-by: Lars Knoll <​lars@trolltech.com>

12:20 AM Changeset in webkit [27593] by hausmann
  • 2 edits in trunk/WebCore

Implement WebCore::callOnMainThread

Implemented using a global QObject, that is moved to the main thread
and then sending a custom event to it.
Picked a number below QEvent::User but above any other documented value.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

12:20 AM Changeset in webkit [27592] by hausmann
  • 3 edits in trunk/WebKit/qt

Fix bug in the implementation of synchronous network jobs.

  • George (pmax) reviewed the networking patches and found the following bug (thanks for reviewing)
  • if (jobMode == AsynchronousJob) {

+ if (jobMode == SynchronousJob) {

add job to synchronous list/hash

  • Just applying the above change will lead to crashes because we can finish jobs before we started them.
  • Avoid these issues by saving all work (starting a job, sending data and finishing it) inside one list. JobWork will contain any of the above three work types and doWork will just work on this list (m_pendingWork). As foreach takes a copy of the list calling started, data and finished will not add new work and we gurantee that if we have JobStarted it will be in the list before JobData and JobFinished.
  • Observation: We might just kill the code to handle sync jobs.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

12:20 AM Changeset in webkit [27591] by hausmann
  • 2 edits in trunk/WebCore

Avoid problems with calling QPainter::begin() on an already active paintdevice

  • Partial pick from 6200e04c3e0a77873c3b3f3969b65bc701020326 to avoid getting crashes on Qt/Mac 4.4 with QPainter::begin to fail because we already draw.
  • If we are in a layout or need one do not paint. This can happen for the PlatformScrollBar used by the ScrollView on a layout triggered by QWebPage::paintEvent.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

12:03 AM Changeset in webkit [27590] by eric@webkit.org
  • 2 edits in trunk/WebCore

2007-11-08 Eric Seidel <​eric@webkit.org>

No review.

  • ksvg2/svg/SVGPathElement.h: remove old comment
Note: See TracTimeline for information about the timeline view.