Context Navigation

Add glyph-orientation-* support for text & textPath. (90/180/270 and 'auto')
Also fix all vertical text handling - for text & textPath! (especially latin1 characters auto orientation in vertical writing modes)

5:38 PM Changeset in webkit [27679] by Nikolas Zimmermann

9 edits in trunk/LayoutTests

Rubberstamped by Eric.
Update some SVG pixel test results - which show changes lately -> repainting fixes.

5:07 PM Changeset in webkit [27678] by Darin Adler

4 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Sam.

fix http://bugs.webkit.org/show_bug.cgi?id=15927 REGRESSION(r27487): delete a.c followed by defineGetter("c", ...) incorrectly deletes another property and <rdar://problem/5586384> REGRESSION (r27487): Can't switch out of Edit HTML Source mode on Leopard Wiki

Test: fast/js/delete-then-put.html

kjs/property_map.cpp: (KJS::PropertyMap::put): Added a missing "- 1"; code to find an empty slot was not working. (KJS::PropertyMap::checkConsistency): Added a missing range check that would have caught this problem before.

roll out a last-minute change to my evaluateToBoolean patch that was incorrect.

kjs/nodes.h: (KJS::ExprStatementNode::ExprStatementNode): Take out call to optimizeForUnnecessaryResult, since the result is used in some cases.

LayoutTests:

Reviewed by Sam.

test for http://bugs.webkit.org/show_bug.cgi?id=15927 delete a.c followed by defineGetter("c", ...) incorrectly deletes another property

fast/js/delete-then-put-expected.txt: Added.
fast/js/delete-then-put.html: Added.
fast/js/resources/delete-then-put.js: Added.

4:49 PM Changeset in webkit [27677] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Sam Weinig.

page/inspector/StylesSidebarPane.js: Fix the wording of a comment and switch over to use getUniqueProperties in another place.

4:30 PM Changeset in webkit [27676] by weinig@apple.com

8 edits
2 adds in trunk

WebKitTools:

Reviewed by Tim Hatcher.

Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
is turned on)

Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)

Added test: http/tests/security/cross-frame-access-private-browsing.html

DumpRenderTree/LayoutTestController.cpp: (setPrivateBrowsingEnabledCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Default to private browsing disabled.
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPrivateBrowsingEnabled):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPrivateBrowsingEnabled):

LayoutTests:

Reviewed by Tim Hatcher.

Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
is turned on)

Test using the new LayoutTestController.setPrivateBrowsingEnabled(bool)

http/tests/security/cross-frame-access-private-browsing-expected.txt: Added.
http/tests/security/cross-frame-access-private-browsing.html: Added.
platform/win/Skipped: Add new test to windows skip list until we have an implementation of LayoutTestController.setPrivateBrowsingEnabled(bool) for it.

3:38 PM Changeset in webkit [27675] by sullivan@apple.com

2 edits in trunk/WebCore

Reviewed by Sam Weinig

Rest of fix for 5394877

bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Don't log unsafe JavaScript attempts in the other version of isSafeScript() if in private browsing mode either.

3:16 PM Changeset in webkit [27674] by Nikolas Zimmermann

2 edits in trunk/WebCore

Reviewed by Oliver.

Fix function name difference - header said 'unicodeRangeForCharacter', actually
implemented function is 'findCharUnicodeRange'. They are not compiled yet.

2:24 PM Changeset in webkit [27673] by hausmann

2 edits in trunk/WebKit/qt

When populating the context menu with sub-menus don't add sub-menus if they're empty.

Signed-off-by: Nikolas

2:24 PM Changeset in webkit [27672] by hausmann

3 edits in trunk/WebKit/qt

Added support for the Bold/Italic/Underline toggle actions.

Signed-off-by: Nikolas

2:24 PM Changeset in webkit [27671] by hausmann

3 edits in trunk/WebKit/qt

Before adding an action to the context menu call checkOrEnableIfNeeded for each action
to update the enable/checked state correctly.

Signed-off-by: Nikolas

2:24 PM Changeset in webkit [27670] by hausmann

2 edits in trunk/WebKit/qt

Mark the text direction actions as checkable actions.

Signed-off-by: Nikolas

2:18 PM Changeset in webkit [27669] by Adam Roben

2 edits in trunk/JavaScriptCore

Windows build fix

Roll out some changes that were (seemingly accidentally) checked in
with r27664.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

1:12 PM Changeset in webkit [27668] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by Darin Adler.

fix <rdar://problem/5450655> Control-clicking text in a link can surprisingly select only part of the link, should select entire link

No test because context menu events cannot be tested in DumpRenderTree.

page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Added. If the click occurred in an active link, selects the entire link element. Otherwise selects the closest word. (WebCore::EventHandler::sendContextMenuEvent): Call selectClosestWordOrLinkFromMouseEvent().
page/EventHandler.h:

1:08 PM Changeset in webkit [27667] by sullivan@apple.com

2 edits in trunk/WebCore

Reviewed by Tim Hatcher

fixed <rdar://problem/5394877> Safari should not log unsafe JavaScript attempts when in private browsing mode (only an issue if Log JavaScript Exceptions is turned on)

bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Don't log unsafe JavaScript attempts to console or chromeClient if in private browsing mode

12:29 PM Changeset in webkit [27666] by ap@webkit.org

8 edits
8 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15922
Implement more of Mozilla Selection API

Tests: editing/selection/containsNode.html

editing/selection/deleteFromDocument.html
editing/selection/extend.html
editing/selection/selectAllChildren.html

editing/SelectionController.cpp: (WebCore::SelectionController::deleteFromDocument): (WebCore::SelectionController::containsNode): (WebCore::SelectionController::selectAllChildren): (WebCore::SelectionController::extend):
editing/SelectionController.h: Added deleteFromDocument(), containsNode(), and selectAllChildren(). Reimplemented extend(), which existed, but didn't match Firefox behavior and wasn't exposed via bindings. Removed a comment mentioning removeRange(), as this method makes no sense without multiple selection range support.

page/DOMSelection.cpp: (WebCore::DOMSelection::extend): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::selectAllChildren):
page/DOMSelection.h:
page/DOMSelection.idl: Exposed the new methods.

12:24 PM Changeset in webkit [27665] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15892
DOM Range operations are not implemented for ProcessingInstruction nodes

Test: fast/dom/Range/range-processing-instructions.html

dom/Range.cpp: (WebCore::Range::processContents): Implemented ProcessingInstruction cases. (WebCore::Range::checkNodeWOffset): Removed a FIXME - yes, I think that we are supposed to use ProcessingInstruction.data.

10:29 AM Changeset in webkit [27664] by Darin Adler

7 edits
3 adds in trunk/JavaScriptCore

Reviewed by Sam.

http://bugs.webkit.org/show_bug.cgi?id=15915 add an evaluation path for booleans like the one we have for numbers

Gives 1.1% on SunSpider.

kjs/grammar.y: Create TrueNode and FalseNode instead of BooleanNode.

kjs/nodes.h: Changed to use Noncopyable. Moved optimizeForUnnecessaryResult down from Node to ExpressionNode. Changed some classes to not inherit from ExpressionNode where not necessary, and removed unnneeded evaluate functions as well as evaluate functions that need not be virtual. Call the optimizeForUnnecessaryResult function on the start of a for loop too.
kjs/nodes.cpp: (KJS::ExpressionNode::evaluateToBoolean): Added. (KJS::FalseNode::evaluate): Added. (KJS::TrueNode::evaluate): Added. (KJS::NumberNode::evaluateToBoolean): Added. (KJS::StringNode::evaluateToBoolean): Added. (KJS::LocalVarAccessNode::evaluateToBoolean): Added. (KJS::BracketAccessorNode::evaluateToBoolean): Added. (KJS::LogicalNotNode::evaluate): Changed to call evaluateToBoolean. (KJS::LogicalNotNode::evaluateToBoolean): Added. (KJS::lessThan): Changed to return bool. (KJS::lessThanEq): Ditto. (KJS::LessNode::evaluate): Changed since lessThan returns bool. (KJS::LessNode::evaluateToBoolean): Added. (KJS::GreaterNode::evaluate): Changed since lessThanEq returns bool. (KJS::GreaterNode::evaluateToBoolean): Added. (KJS::LessEqNode::evaluate): Changed since lessThanEq returns bool. (KJS::LessEqNode::evaluateToBoolean): Added. (KJS::GreaterEqNode::evaluate): Changed since lessThan returns bool. (KJS::GreaterEqNode::evaluateToBoolean): Added. (KJS::InstanceOfNode::evaluateToBoolean): Added. (KJS::InNode::evaluateToBoolean): Added. (KJS::EqualNode::evaluateToBoolean): Added. (KJS::NotEqualNode::evaluateToBoolean): Added. (KJS::StrictEqualNode::evaluateToBoolean): Added. (KJS::NotStrictEqualNode::evaluateToBoolean): Added. (KJS::ConditionalNode::evaluate): Changed to call evaluateToBoolean. (KJS::IfNode::execute): Ditto. (KJS::DoWhileNode::execute): Ditto. (KJS::WhileNode::execute): Ditto. (KJS::ForNode::execute): Ditto.

kjs/nodes2string.cpp: (KJS::FalseNode::streamTo): Added. (KJS::TrueNode::streamTo): Added.

5:01 AM Applications using WebKit edited by joe@funkeemonk.com

(diff)

12:02 AM Changeset in webkit [27663] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Mark Rowe.

Bug 12054: Ability to serialize an element subtree (into clipboard?) from the DOM inspector
http://bugs.webkit.org/show_bug.cgi?id=12054

Add support code for routing copy events to the focused element.
Implement copying the currently selected DOM node. The node and it's subtree is copied to the clipboard. If the node has no outerHTML, the nodeValue is copied (text nodes, etc.)
Implement copy for the resource sidebar. The URL is copied for the currently selected resource.

page/inspector/DocumentPanel.js:
page/inspector/inspector.js:

Nov 9, 2007:

11:50 PM Changeset in webkit [27662] by ap@webkit.org

2 edits in trunk/SunSpider

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15925
SunSpider should check for Shark being installed

sunspider: Explicitly test that shark command line tool is installed.

6:28 PM Changeset in webkit [27661] by honeycutt

2 edits in trunk/WebKit/win

2007-11-09 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Sam.

<rdar://5585900>: Safari crashes when selected in context menu to open
audio format files (au, aif) with QT 7.3

The crash occurred on a machine where QT 7.3 was failing to initialize.
The fix is to avoid sending streams to full-page plugins that've failed
to load

WebFrame.cpp: (WebFrame::finishedLoading): Check plugin status before calling manual stream methods (WebFrame::setMainDocumentError): Same (WebFrame::committedLoad): Same

5:53 PM Changeset in webkit [27660] by antti

1 edit
2 adds in trunk/WebKitSite

Rubber stamped by bdash.

Add directory for blog resources (and one image).

blog-files: Added.
blog-files/touch-poster.png: Added.

4:59 PM Changeset in webkit [27659] by antti

2 edits in trunk/WebCore

Reviewed by Adele.

Fix occasional blank video with poster attribute.

ChangeLog:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::didRestoreFromCache): Just calling updateFromElement() does the right thing for both poster image and video.

4:29 PM Changeset in webkit [27658] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2007-11-09 Xan Lopez <xan@gnome.org>

Reviewed by Alp.

Fix http://bugs.webkit.org/show_bug.cgi?id=15926
[GTK] WebKitPage map handler is redundant.

Api/webkitgtkpage.cpp: The map handler for WebKitPage is redundant, GtkContainer does the same (and more correctly).

3:51 PM Changeset in webkit [27657] by tristan

1 edit
1 move in trunk/LayoutTests

Reviewed by Sam Weinig.

fast/dom/Window/window-resize-nan.html: Removed.
fast/dom/Window/window-resize-nan.html-disabled: Copied from fast/dom/Window/window-resize-nan.html.

Disabled nan test until window resize issues can be resolved.

3:34 PM Changeset in webkit [27656] by weinig

2 edits in trunk/WebKit/win

Rubber stamped by Oliver.

Make WebCore a dependency of Interfaces.

WebKit.vcproj/WebKit.sln:

3:04 PM Changeset in webkit [27655] by weinig

8 edits
11 adds in trunk

WebCore:

Reviewed by Adam Roben.

<rdar://problem/5435940>
The COM bindings for the DOM should be autogenerated like the other DOM bindings

Initial commit of the autogeneration of the COM DOM Bindings. No behavior change
is being introduced in this patch and to insure that no conflicts arise, a temporary
prefix of "GEN_" has been used for all the new classes.

The build architecture for these bindings differs slightly from the other autogenerated
bindings. Instead of building in WebCore and migrating the resuting code to WebKit (as
is done for the Objective-C bindigs currently), the IDLs and generation scripts are
migrated to WebKit and built there. This is done with a series of scripts and Makefiles.

This commit includes:

Hand rolled root class/Interface GEN_DOMObject used to facilated object creation and ref-counting.
Generating all of the Core DOM and most of HTML and CSS
Generating Event, EventTarget, and EventListener

WebCore.vcproj/MigrateIDLAndScripts.make: Added.
WebCore.vcproj/WebCore.vcproj:
WebCore.vcproj/migrate-idls.sh: Added.
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorCOM.pm: Added.
dom/EventListener.h: Make the isWindowEvent parameter default to false to allow autogeneration based on the IDL.

WebKit/win:

Reviewed by Adam Roben.

<rdar://problem/5435940>
The COM bindings for the DOM should be autogenerated like the other DOM bindings

Initial commit of the autogeneration of the COM DOM Bindings. No behavior change
is being introduced in this patch and to insure that no conflicts arise, a temporary
prefix of "GEN_" has been used for all the new classes.

The build architecture for these bindings differs slightly from the other autogenerated
bindings. Instead of building in WebCore and migrating the resuting code to WebKit (as
is done for the Objective-C bindigs currently), the IDLs and generation scripts are
migrated to WebKit and built there. This is done with a series of scripts and Makefiles.

This commit includes:

Hand rolled root class/Interface GEN_DOMObject used to facilated object creation and ref-counting.
Generating all of the Core DOM and most of HTML and CSS
Generating Event, EventTarget, and EventListener

DOMCreateInstance.cpp: Added. (domWrapperCache): (getDOMWrapper): (setDOMWrapper): (removeDOMWrapper): (GEN_DOMNode::createInstance): (GEN_DOMImplementation::createInstance): (GEN_DOMCSSRule::createInstance): (GEN_DOMStyleSheet::createInstance): (GEN_DOMCSSValue::createInstance):
DOMCreateInstance.h: Added. Temporary location for createInstance/object caching methods. This will be broken up into seperate files in the near future.

GEN_DOMObject.cpp: Added. (GEN_DOMObject::GEN_DOMObject): (GEN_DOMObject::~GEN_DOMObject): (GEN_DOMObject::QueryInterface): (GEN_DOMObject::AddRef): (GEN_DOMObject::Release):
GEN_DOMObject.h: Added. Hand rolled base class.

Interfaces/IGEN_DOMObject.idl: Added. Hand rolled base interface.

WebKit.vcproj/DerivedSources.make: Added.
WebKit.vcproj/FixMIDLHeaders.pl: Added. This script is required because MIDL is producing un-buildable code due to circular dependencies.

WebKit.vcproj/Interfaces.vcproj:
WebKit.vcproj/WebKit.vcproj:
WebKit.vcproj/WebKitGUID.vcproj:
WebKit.vcproj/build-generated-files.sh: Added.

2:54 PM Changeset in webkit [27654] by tristan

5 edits in trunk

mac:

Reviewed by Timothy Hatcher.

This patch is for the WebKit side of <rdar://problem/5591115>.
We need a way to tell context menu navigations, such as "Open in New Window"
to override any sort of browser preference for tab based navigation.

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Pass up the new preferredType parameter as a string.

WebCore:

Reviewed by Timothy Hatcher.

This patch is for the WebKit side of <rdar://problem/5591115>.
We need a way to tell context menu navigations, such as "Open in New Window"
to override any sort of browser preference for tab based navigation.

bridge/WindowFeatures.h: (WebCore::WindowFeatures::WindowFeatures): Added a new struct member var, preferredType and an accompanying enum type PreferredType to send a window type recommendation up to the Chrome.

page/ContextMenuController.cpp: (WebCore::openNewWindow): Set the window features to recommend a new Window for "Open in New Window" context menu action.

2:25 PM Changeset in webkit [27653] by timothy@apple.com

4 edits in trunk/WebKit/mac

Reviewed by John.

<rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used

Extend the linked on or after check to every application when a script passed to
stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
was limited to VitalSource Bookshelf, but other developers are running into this.

Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.

1:43 PM SpecSupport edited by mjs@apple.com

(diff)

1:39 PM SpecSupport edited by mjs@apple.com

(diff)

1:36 PM SpecSupport edited by mjs@apple.com

(diff)

1:31 PM SpecSupport edited by mjs@apple.com

(diff)

1:31 PM SpecSupport edited by mjs@apple.com

(diff)

1:27 PM SpecSupport edited by mjs@apple.com

(diff)

1:23 PM SpecSupport edited by mjs@apple.com

(diff)

1:11 PM SpecSupport edited by mjs@apple.com

(diff)

12:04 PM Changeset in webkit [27652] by Adam Roben

4 edits
2 adds in trunk

Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick

LayoutTests:

Add a test for <rdar://5483519> Pressing Enter on selected buttons should fire onclick

Reviewed by Adele.

fast/forms/enter-clicks-buttons-expected.txt: Added.
fast/forms/enter-clicks-buttons.html: Added.

WebCore:

Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick

We now match the behavior of Firefox and IE, which is to always just
send a click event to the focused button when the Enter key is pressed
(previously we were submitting forms directly in some cases).

Reviewed by Adele.

Test: fast/forms/enter-clicks-buttons.html

html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't do anything fancy when Enter is pressed on a <button type=button> -- just send a click event like we do for other button types.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Treat type=button the same way we treat type=submit and type=reset: just send a click event when Enter is pressed.

12:03 PM Changeset in webkit [27651] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Antti Koivisto.

fix a bug in invisible layer culling: dynamically changing a descendant of an invisible layer to be visible did not work

Test: fast/layers/layer-content-visibility-change.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): If we got visible content, make sure that our stacking context rebuilds its z-order lists to include us.

LayoutTests:

Reviewed by Antti Koivisto.

test that dynamically changing a descendant of an invisible layer to be visible works

fast/layers/layer-content-visibility-change.html: Added.
platform/mac/fast/layers/layer-content-visibility-change-expected.checksum: Added.
platform/mac/fast/layers/layer-content-visibility-change-expected.png: Added.
platform/mac/fast/layers/layer-content-visibility-change-expected.txt: Added.

11:57 AM Changeset in webkit [27650] by hyatt

3 edits in trunk/WebCore

Clean up matrix() parsing. Make sure the first four arguments can be lengths or numbers. The last two
args can be lengths or numbers or percents.

Reviewed by Beth

WebCore.xcodeproj/project.pbxproj:
css/CSSParser.cpp: (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::CSSParser::parseTransform):
rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply):

11:05 AM Changeset in webkit [27649] by Beth Dakin

3 edits
4 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5586370> CSS Transform - incorrect matrix
math leads to crazy problems

Transform matrices accept the first four parameters as CSS lengths.
CSS lengths get mapped into WebCore::Lengths as percents by
WebCore::convertToLength(). Percent lengths cannot call value(). It
does not yield a correct result and it asserts on Debug builds.

rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply): Instead of calling value() on the lengths, call calcValue. This fixes the assert and the bad rendering.

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5586370> CSS Transform - incorrect matrix
math leads to crazy problems

fast/transforms/identity-matrix.html: Added.
platform/mac/fast/transforms/identity-matrix-expected.checksum: Added.
platform/mac/fast/transforms/identity-matrix-expected.png: Added.
platform/mac/fast/transforms/identity-matrix-expected.txt: Added.

9:56 AM Changeset in webkit [27648] by Adam Roben

2 edits in trunk/JavaScriptCore

Windows build fix

Reviewed by Darin.

kjs/value.h: (KJS::jsNumber): Add some explicit casts.

9:16 AM Changeset in webkit [27647] by sfalken

2 edits in trunk/WebCore

Roll out r27641 since the same bug was already fixed by r27568.

7:35 AM SpecSupport edited by philippe.kalaf@collabora.co.uk

(diff)

7:26 AM SpecSupport edited by mrowe@apple.com

(diff)

6:44 AM WikiStart edited by philippe.kalaf@collabora.co.uk

(diff)

6:41 AM SpecSupport edited by philippe.kalaf@collabora.co.uk

(diff)

6:40 AM SpecSupport edited by philippe.kalaf@collabora.co.uk

(diff)

6:36 AM SpecSupport created by philippe.kalaf@collabora.co.uk

6:33 AM Changeset in webkit [27646] by hausmann

2 edits in trunk/WebCore

userIdleTime() is stubbed in win/SystemTimeWin.cpp, so don't
define it twice for the Qt/Windows build.

5:09 AM Changeset in webkit [27645] by hausmann

3 edits in trunk/WebKit/qt

Implemented the webcore actions for changing the text direction.

Signed-off-by: Holger

5:09 AM Changeset in webkit [27644] by hausmann

9 edits in trunk

Fix ContextMenu allocation in the Qt port.

Store all items and submenus value based in ContextMenu and ContextMenuItem.
That fixes the crashes when the context menu was populated with sub-menus because
of the use of temporary ContextMenu objects like this:

ContextMenu subMenu(...);
subMenu.appendItem(...);
subMenu.appendItem(...);

subMenuItem.setSubMenu(&subMenu); temporary pointer, need to _copy_ contents

Signed-off-by: Holger

5:09 AM Changeset in webkit [27643] by hausmann

3 edits in trunk/WebKit/qt

Renamed QWebPage::NumWebActions to QWebPage::WebActionCount (for consistency) and fixed its value.

Signed-off-by: Holger

4:51 AM Changeset in webkit [27642] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-09 Peter Kasting <zerodpx@gmail.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=15909
Malformed GIFs should not result in memory corruption.

platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):

1:01 AM Changeset in webkit [27641] by sfalken

2 edits in trunk/WebCore

Initialize WindowFeatures struct before using it.

Reviewed by Oliver.

page/ContextMenuController.cpp: (WebCore::openNewWindow):

12:29 AM Changeset in webkit [27640] by kmccullo

5 edits in trunk/WebKit/win

Reviewed by Adam.

This patch does two main things. 1) It adds pragma warning guards around WebCore includes in WebKit files that were previously overlooked. 2) It implements almost the entireity of WebScriptDebugger. Only one function remains and that implementation is dependent on finishing the implementation of WebScriptScope.

WebScriptCallFrame.h:
WebScriptDebugServer.h:
WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): (WebScriptDebugger::enterFrame): (WebScriptDebugger::leaveFrame):
WebScriptDebugger.h:

12:26 AM Changeset in webkit [27639] by kmccullo

4 edits
5 adds in trunk/WebKitTools

Reviewed by Adam.

Changed the vcproj file to use Drosera's ForwardingHeaders and not WebCore's!

Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
Drosera/win/Drosera.cpp:
Drosera/win/Drosera.vcproj/Drosera.vcproj:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed