⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 12, 2007:

11:12 PM Changeset in webkit [27746] by ap@webkit.org
  • 11 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15953
Add UTF-8 encoding/decoding to WTF

  • kjs/ustring.h: Moved UTF8SequenceLength() and decodeUTF8Sequence() to wtf/unicode.
  • kjs/ustring.cpp: (KJS::UString::UTF8String): Changed this function to take a strict/lenient parameter. Callers are not interested in getting decoding results in strict mode, so this allows for bailing out as soon as an error is seen.
  • kjs/function.cpp: (KJS::encode): Updated for new UString::UTF8String() signature.
  • API/JSStringRef.cpp: (JSStringCreateWithCharacters): Disambiguate UChar. (JSStringCreateWithUTF8CString): Actually use UTF-8 when creating the string!
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Use ConvertUTF8ToUTF16().
  • wtf/unicode/UTF8.cpp: Added. (WTF::Unicode::inlineUTF8SequenceLengthNonASCII): (WTF::Unicode::inlineUTF8SequenceLength): (WTF::Unicode::UTF8SequenceLength): (WTF::Unicode::decodeUTF8Sequence): (WTF::Unicode::): (WTF::Unicode::ConvertUTF16ToUTF8): (WTF::Unicode::isLegalUTF8): (WTF::Unicode::ConvertUTF8ToUTF16):
  • wtf/unicode/UTF8.h: Added. (WTF::Unicode::): Some code moved from ustring.h, some adapted from unicode.org sources.
10:48 PM Changeset in webkit [27745] by weinig@apple.com
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • bindings/npapi.h:

WebKit/mac:

Reviewed by Darin.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setVariable:value:]):
10:21 PM Changeset in webkit [27744] by ap@webkit.org
  • 11 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15954
Move DOM Selection operations out of SelectionController

No change in functionality.

WebCore:

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectedRange):
  • editing/SelectionController.h:
  • page/DOMSelection.cpp: (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset): (WebCore::DOMSelection::isCollapsed): (WebCore::DOMSelection::type): (WebCore::DOMSelection::rangeCount): (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::collapseToEnd): (WebCore::DOMSelection::collapseToStart): (WebCore::DOMSelection::empty): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::extend): (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::removeAllRanges): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::selectAllChildren): (WebCore::DOMSelection::toString):
  • page/DOMSelection.h: Moved all DOM API methods to DOMSelection; changed SelectionController::setSelectedRange() to return its result directly instead of via an ExceptionCode that no caller wanted.
  • editing/Editor.cpp: (WebCore::Editor::deleteRange): (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::selectComposition): (WebCore::Editor::setComposition):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Adapted for SelectionController::setSelectedRange() now returning a bool. SelectionController::toString() is no longer avasilable, use plainText() explicitly.
  • WebCore.base.exp: Changed SelectionController::setSelectedRange() signature.

WebKit:

  • WebView/WebHTMLView.mm: (-[WebHTMLView _expandSelectionToGranularity:]): (-[WebHTMLView selectToMark:]): (-[WebHTMLView swapWithMark:]):
  • WebView/WebView.mm: (-[WebView setSelectedDOMRange:affinity:]): Adapted for SelectionController::setSelectedRange() now returning a bool.
8:53 PM Changeset in webkit [27743] by mitz@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/repaint/invisible-objects.html

Avoid repainting invisible blocks if they are enclosed in a layer that
contains no visible objects.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteClippedOverflowRect):

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/invisible-objects.html: Added.
  • platform/mac/fast/repaint/invisible-objects-expected.checksum: Added.
  • platform/mac/fast/repaint/invisible-objects-expected.png: Added.
  • platform/mac/fast/repaint/invisible-objects-expected.txt: Added.
7:57 PM Changeset in webkit [27742] by oliver@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/5537289> REGRESSION: Dragging a link or an image from an IFrame causes the page to not respond to clicks afterwards (15460)

Reviewed by John S.

EventHandler needs to reset these fields when a drag terminates, otherwise
EventHandler is left in an inconsistent state when a drag is initiated on a
page with multiple frames.

6:33 PM Changeset in webkit [27741] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitSite/test.txt
6:23 PM Changeset in webkit [27740] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitSite/test.txt

test 4

6:10 PM Changeset in webkit [27739] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitSite/test.txt

3

6:04 PM Changeset in webkit [27738] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitSite/test.txt

2++

5:58 PM Changeset in webkit [27737] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitSite/test.txt

take 2

5:53 PM Changeset in webkit [27736] by wsiegrist@apple.com
  • 1 add in trunk/WebKitSite/test.txt

testing post-commit.

5:39 PM Changeset in webkit [27735] by timothy@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

Prevent selecting a word in the breadcrumb or the styles section when double
clicking on a DOM node in the outline tree.

  • page/inspector/DocumentPanel.js: Call preventDefault() when a mousedown event with a detail of 2 or higher comes in. This prevents the selection.
  • page/inspector/inspector.css: Mark the breadcrumb as user-select: none.
5:33 PM Changeset in webkit [27734] by weinig@apple.com
  • 5 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.

  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPrivateBrowsingEnabled):

LayoutTests:

Reviewed by Adam Roben.

  • platform/win/Skipped: Remove http/tests/security/cross-frame-acdcess-private-browsing.html from the windows skipped list now that LayoutTestController.setPrivateBrowsingEnabled has been implmented.
4:22 PM Changeset in webkit [27733] by Darin Adler
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Sam.

Test: fast/js/regexp-many-brackets.html

  • pcre/pcre_exec.cpp: (match): Added back accidentally-removed case for the BRANUMBER opcode.

LayoutTests:

Reviewed by Sam.

  • fast/js/regexp-many-brackets-expected.txt: Added.
  • fast/js/regexp-many-brackets.html: Added.
  • fast/js/resources/regexp-many-brackets.js: Added.
3:53 PM Changeset in webkit [27732] by oliver@apple.com
  • 2 edits in trunk/WebCore

Return behaviour for 0 sized pattern back to what it was prior to r27704

Reviewed by Darin and Antti.

This change in behaviour broke two layout tests in DRT, so correcting it
corrects existing tests.

3:27 PM Changeset in webkit [27731] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/5268311> REGRESSION (Safari 2-3): Exception thrown when calling -[WebDataSource subresources]

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): If the SharedBuffer is null insert an empty NSData instead of nil.
3:04 PM Changeset in webkit [27730] by Darin Adler
  • 17 edits
    1 delete in trunk/JavaScriptCore

Reviewed by Geoff.

  • fix use of prefix and config.h, got rid of a few unneeded things in the PCRE code; no behavior changes
  • API/JSBase.cpp: Added include of config.h.
  • API/JSCallbackConstructor.cpp: Ditto.
  • API/JSCallbackFunction.cpp: Ditto.
  • API/JSCallbackObject.cpp: Ditto.
  • API/JSClassRef.cpp: Ditto.
  • API/JSContextRef.cpp: Ditto.
  • API/JSObjectRef.cpp: Ditto.
  • API/JSStringRef.cpp: Ditto.
  • API/JSValueRef.cpp: Ditto.
  • JavaScriptCorePrefix.h: Removed obsolete <ctype.h> workaround. Moved new/delete macros after includes, as they are in WebCore's prefix. Removed "config.h".
  • pcre/dftables.cpp: (main): Changed back to not use a separate maketables function. This is needed for PCRE, but not helpful for our use. Also changed the tables to all be 128 entries long instead of 256, since only the first 128 are ever used.
  • pcre/pcre_compile.cpp: Added include of config.h. Eliminated digitab, which was only being used to check hex digits. Changed all uses of TRUE and FALSE to use the C++ true and false instead. (check_escape): Just the TRUE/FALSE thing. (is_counted_repeat): Ditto. (could_be_empty_branch): Ditto. (get_othercase_range): Ditto. (compile_branch): Ditto. (compile_regex): Ditto. (is_anchored): Ditto. (is_startline): Ditto. (find_firstassertedchar): Ditto. (jsRegExpCompile): Ditto.
  • pcre/pcre_exec.cpp: Added include of config.h. Changed all uses of TRUE and FALSE to use the C++ true and false instead. (match_ref): Just the TRUE/FALSE thing. (match): Ditto. Removed some unneeded braces. (jsRegExpExecute): Just the TRUE/FALSE thing.
  • pcre/pcre_internal.h: Moved the constants needed by dftables.cpp to the top of the file instead of the bottom, so they can be used. Also changed the table sizes to 128 instead of 256. Removed macro definitions of FALSE and TRUE. Set array sizes for all the const arrays. Changed _pcre_utf8_table1_size to be a macro instead of a extern int.
  • pcre/pcre_maketables.cpp: Removed. It's all in dftables.cpp now.
  • pcre/pcre_tables.cpp: Made table sizes explicit.
  • pcre/pcre_xclass.cpp: Just the TRUE/FALSE thing.
2:28 PM Changeset in webkit [27729] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Tim.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isLocationChange): Factored out the slow case of isScheduledLocationChangePending into this.
  • loader/FrameLoader.h: (WebCore::FrameLoader::isScheduledLocationChangePending): Added an inline check of the far and away most common case, where m_scheduledRedirection is 0; the rest is in the isLocationChange function.
2:11 PM Changeset in webkit [27728] by oliver@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Appease geoff :D

2:06 PM Changeset in webkit [27727] by ggaren@apple.com
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.


Landing a few layout tests from ​http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

  • fast/js/kde/completion-expected.txt:
  • fast/js/kde/resources/completion.js:
2:04 PM Changeset in webkit [27726] by oliver@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/5522011> The content of the password field of Safari is displayed by reconversion.

Reviewed by Darin.

Some input methods (notably Kotoeri) can incorrectly provide
access to the raw text of a password field. To work around
this we forcefully override the inputContext whenever a password
field is active.

1:59 PM Changeset in webkit [27725] by ggaren@apple.com
  • 3 edits
    3 adds in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.


Landing a few layout tests from ​http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

  • fast/js/kde/lval-exceptions-expected.txt: Added.
  • fast/js/kde/lval-exceptions.html: Added.
  • fast/js/kde/operators-expected.txt:
  • fast/js/kde/resources/lval-exceptions.js: Added.
  • fast/js/kde/resources/operators.js:
1:57 PM Changeset in webkit [27724] by ggaren@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.


Landing a few layout tests from ​http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

  • fast/js/kde/func-decl-expected.txt: Added.
  • fast/js/kde/func-decl.html: Added.
  • fast/js/kde/resources/func-decl.js: Added.
1:55 PM Changeset in webkit [27723] by ggaren@apple.com
  • 1 edit
    6 adds in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.


Landing a few layout tests from ​http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

  • fast/js/rehash-assign-expected.txt: Added.
  • fast/js/rehash-assign.html: Added.
  • fast/js/resize-array-assign-expected.txt: Added.
  • fast/js/resize-array-assign.html: Added.
  • fast/js/resources/rehash-assign.js: Added.
  • fast/js/resources/resize-array-assign.js: Added.
1:48 PM Changeset in webkit [27722] by ggaren@apple.com
  • 3 edits
    3 adds in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.


Landing a few layout tests from ​http://bugs.webkit.org/show_bug.cgi?id=14868
Import variable lookup optimizations from KJS

  • fast/js/kde/arguments-scope-expected.txt: Added.
  • fast/js/kde/arguments-scope.html: Added.
  • fast/js/kde/resources/arguments-scope.js: Added.
  • fast/js/kde/resources/scope.js:
  • fast/js/kde/scope-expected.txt:
12:11 PM Changeset in webkit [27721] by staikos@webkit.org
  • 4 edits in trunk/WebCore

2007-11-12 George Staikos <​staikos@kde.org>

Reviewed by Tim.

Extract the text match marker highlight color into RenderTheme instead
of the hardcoded yellow.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformTextSearchHighlightColor):
  • rendering/RenderTheme.h:
11:49 AM Changeset in webkit [27720] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2007-11-12 Mark Rowe <​mrowe@apple.com>

  • building/tools.html: Remove extra >.
11:45 AM Changeset in webkit [27719] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-12 Mark Rowe <​mrowe@apple.com>

Fix deadlock on launch on the Mac.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Restore unlock that was mistakenly removed in r27717.
10:51 AM Changeset in webkit [27718] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Tim Hatcher


  • speculative fix for <rdar://problem/5509989> CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit: -[WebPDFView(FileInternal) _updatePreferencesSoon] + 56


The crash is probably due to messaging a dealloc'ed dataSource ivar. The dataSource ivar isn't retained
by this class, but should be. (It is retained by WebHTMLView, e.g.).

  • WebView/WebPDFView.mm: (-[WebPDFView dealloc]): release dataSource ivar (-[WebPDFView setDataSource:]): retain dataSource ivar
10:34 AM Changeset in webkit [27717] by mrowe@apple.com
  • 5 edits in trunk/WebCore

2007-11-12 Justin Haygood <​jhaygood@reaktix.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=15955
Reimplement threading functions in IconDatabase and SQLiteDatabase in terms of the threading abstractions

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): (WebCore::IconDatabase::close):
  • loader/icon/IconDatabase.h:
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::open): (WebCore::SQLiteDatabase::close):
  • platform/sql/SQLiteDatabase.h:
8:31 AM TracStandalone edited by trac
(diff)
8:31 AM TracModPython edited by trac
(diff)
8:31 AM InterTrac created by trac
8:31 AM TracSearch edited by trac
(diff)
8:31 AM TracSupport edited by trac
(diff)
8:31 AM TracPlugins edited by trac
(diff)
8:31 AM TracChangeset edited by trac
(diff)
8:31 AM TracRevisionLog created by trac
8:31 AM TracUnicode edited by trac
(diff)
8:31 AM TracUpgrade edited by trac
(diff)
8:31 AM TracTimeline edited by trac
(diff)
8:31 AM TracRoadmap edited by trac
(diff)
8:31 AM TracReports edited by trac
(diff)
8:31 AM TracQuery edited by trac
(diff)
8:31 AM WikiRestructuredTextLinks edited by trac
(diff)
8:31 AM TracAccessibility edited by trac
(diff)
8:31 AM TracEnvironment edited by trac
(diff)
8:31 AM CamelCase edited by trac
(diff)
8:31 AM InterMapTxt created by trac
8:31 AM TracSyntaxColoring edited by trac
(diff)
8:31 AM WikiFormatting edited by trac
(diff)
8:31 AM TracTicketsCustomFields edited by trac
(diff)
8:31 AM TracNotification edited by trac
(diff)
8:31 AM WikiDeletePage edited by trac
(diff)
8:31 AM InterWiki created by trac
8:31 AM WikiHtml edited by trac
(diff)
8:31 AM TracWiki edited by trac
(diff)
8:31 AM TracIni edited by trac
(diff)
8:31 AM TracCgi edited by trac
(diff)
8:31 AM TracRss edited by trac
(diff)
8:31 AM WikiProcessors edited by trac
(diff)
8:31 AM TracPermissions edited by trac
(diff)
8:31 AM TracLinks edited by trac
(diff)
8:31 AM TracInterfaceCustomization edited by trac
(diff)
8:31 AM TracBrowser edited by trac
(diff)
8:31 AM WikiMacros edited by trac
(diff)
8:31 AM TracImport edited by trac
(diff)
8:31 AM TracInstall edited by trac
(diff)
8:31 AM TracFastCgi edited by trac
(diff)
8:31 AM TracGuide edited by trac
(diff)
8:31 AM TracBackup edited by trac
(diff)
8:31 AM WikiRestructuredText edited by trac
(diff)
8:31 AM TracAdmin edited by trac
(diff)
8:31 AM WikiPageNames edited by trac
(diff)
8:31 AM TracTickets edited by trac
(diff)
3:02 AM Changeset in webkit [27716] by Adam Roben
  • 3 edits in trunk/WebCore

Windows build fix

  • config.h: Touch because VS apparently can't figure out which files depend on ResourceResponse.h.
  • WebCore.vcproj/WebCore.vcproj: Add ResourceResponseBase files to project and remove old ResourceResponse files.
2:39 AM Changeset in webkit [27715] by Adam Roben
  • 4 edits in trunk

Change update-webkit-localizable-strings to only scan mac and win directories

WebKit:

  • StringsNotToBeLocalized.txt: Updated.

WebKitTools:

  • Scripts/update-webkit-localizable-strings: Changed to only scan the mac and win subdirectories.
2:33 AM Changeset in webkit [27714] by mrowe@apple.com
  • 4 edits
    2 moves
    4 adds in trunk/WebCore

2007-11-12 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15334
Split ResourceResponse into platform specific files

  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceResponse.cpp: Removed.
  • platform/network/ResourceResponse.h: Removed.
  • platform/network/ResourceResponseBase.cpp: Copied from platform/network/ResourceResponse.cpp. (WebCore::ResourceResponseBase::asResourceResponse): (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setUrl): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setExpirationDate): (WebCore::ResourceResponseBase::expirationDate): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::updateResourceResponse):
  • platform/network/ResourceResponseBase.h: Copied from platform/network/ResourceResponse.h. (WebCore::ResourceResponseBase::ResourceResponseBase):
  • platform/network/cf/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/curl/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):
  • platform/network/mac/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/qt/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):
2:27 AM Changeset in webkit [27713] by Adam Roben
  • 3 edits in trunk/WebKit/win

Windows build fix

  • WebKit.vcproj/WebKit.def: Export fastZeroedMalloc.
  • WebKit.vcproj/WebKit_debug.def: Ditto.
1:59 AM Changeset in webkit [27712] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Build fix

  • wtf/FastMalloc.h: Add missing using statement.
12:00 AM Changeset in webkit [27711] by oliver
  • 7 edits in trunk/JavaScriptCore

Add special fastZeroedMalloc function to replace a
number of fastCalloc calls where one argument was 1.

Reviewed by Darin.

This results in a 0.4% progression in SunSpider, more
than making up for the earlier regression caused by
additional overflow checks.

Nov 11, 2007:

10:44 PM Changeset in webkit [27710] by Adam Roben
  • 4 edits in trunk/JavaScriptCore

Fix <rdar://5578982> ASSERT in HashTable::checkTableConsistencyExceptSize beneath WebNotificationCenter

The bug was due to a mismatch between HashMap::remove and
HashTable::checkTableConsistency. HashMap::remove can delete the value
stored in the HashTable (by derefing it), which is not normally
allowed by HashTable. It's OK in this case because the value is about
to be removed from the table, but HashTable wasn't aware of this.

HashMap::remove now performs the consistency check itself before
derefing the value.

Darin noticed that the same bug would occur in HashSet, so I've fixed
it there as well.

Reviewed by Darin.

  • wtf/HashMap.h: (WTF::HashMap::remove): Perform the HashTable consistency check manually before calling deref.
  • wtf/HashSet.h: (WTF::HashSet::remove): Ditto.
  • wtf/HashTable.h: Made checkTableConsistency public so that HashMap and HashSet can call it. (WTF::HashTable::removeAndInvalidateWithoutEntryConsistencyCheck): Added. (WTF::HashTable::removeAndInvalidate): Added. (WTF::HashTable::remove): (WTF::HashTable::removeWithoutEntryConsistencyCheck): Added.
10:16 PM Changeset in webkit [27709] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r27708 as it breaks the Mac PowerPC build.

10:00 PM Changeset in webkit [27708] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-11 Mike Hommey <​mh+webkit@glandium.org>

Reviewed by Maciej.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14521
Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2

  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock): Change constraint from o to m.
9:54 PM Changeset in webkit [27707] by mrowe@apple.com
  • 5 edits in trunk/WebCore

2007-11-11 Justin Haygood <​jhaygood@reaktix.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=15939
Adds a currentThread API for use by SQLiteDatabase, etc.

  • platform/Threading.h:
  • platform/ThreadingNone.cpp: (WebCore::currentThread):
  • platform/gtk/ThreadingGtk.cpp: (WebCore::identifierByGthreadHandle): (WebCore::):
  • platform/pthreads/ThreadingPthreads.cpp: (WebCore::identifierByPthreadHandle): (WebCore::currentThread):
9:40 PM Changeset in webkit [27706] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Adam Roben.

Test: editing/selection/cleared-by-relayout.html

  • editing/Selection.cpp: (WebCore::Selection::toRange): Check if the selection has been cleared by updating layout.

LayoutTests:

Reviewed by Adam Roben.

  • editing/selection/cleared-by-relayout-expected.txt: Added.
  • editing/selection/cleared-by-relayout.html: Added.
8:51 PM Changeset in webkit [27705] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix line numbers that were off since my recent patch
  • platform/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): Reversed the sense of m_excludeLineNumbers and rename it to m_doNotExcludeLineNumbers. (WebCore::SegmentedSubstring::excludeLineNumbers): Updated. (WebCore::SegmentedSubstring::doNotExcludeLineNumbers): Added. (WebCore::SegmentedSubstring::setExcludeLineNumbers): Updated. (WebCore::SegmentedString::advance): Use doNotExcludeLineNumbers to reverse the sense and fix the regression, but keep the speediness. I accidentally had removed a ! here.
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::advanceSlowCase): Use doNotExcludeLineNumbers.
8:48 PM Changeset in webkit [27704] by oliver
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5585334>

Reviewed by Darin.

Fix for <rdar://problem/5585334> numfuzz: integer overflows opening
malformed SVG file in WebCore::ImageBuffer::create. Add protection
against a potential overflow.

8:37 PM Changeset in webkit [27703] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-11 Mark Rowe <​mrowe@apple.com>

Build fix. Use the correct filename case.

  • kjs/nodes.h:
8:27 PM Changeset in webkit [27702] by ggaren@apple.com
  • 8 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15902
15% of string-validate-input.js is spent compiling the same regular expression


Store a compiled representation of the regular expression in the AST.


Only a .2% SunSpider speedup overall, but a 10.6% speedup on
string-validate-input.js.

  • kjs/nodes.cpp: (KJS::RegExpNode::evaluate):
  • kjs/nodes.h: (KJS::RegExpNode::):
  • kjs/nodes2string.cpp: (KJS::RegExpNode::streamTo):
  • kjs/regexp.cpp: (KJS::RegExp::flags):
  • kjs/regexp.h: (KJS::RegExp::pattern):
  • kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): (KJS::RegExpObjectImp::createRegExpImp):
  • kjs/regexp_object.h:
8:26 PM Changeset in webkit [27701] by Antti Koivisto
  • 11 edits in trunk/WebCore

Reviewed by Darin.

Fix a bunch of cases where the exception code is checked by the function but is not zeroed first.

  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):
  • dom/Attr.cpp: (WebCore::Attr::setPrefix):
  • dom/Document.cpp: (WebCore::Document::createElement):
  • dom/Element.cpp: (WebCore::Element::setPrefix):
  • dom/Range.cpp: (WebCore::Range::setStart): (WebCore::Range::setEnd): (WebCore::Range::isPointInRange): (WebCore::Range::comparePoint): (WebCore::Range::compareBoundaryPoints): (WebCore::Range::deleteContents): (WebCore::Range::processContents): (WebCore::Range::extractContents): (WebCore::Range::insertNode): (WebCore::Range::setStartAfter): (WebCore::Range::setEndBefore): (WebCore::Range::setEndAfter): (WebCore::Range::selectNode): (WebCore::Range::surroundContents): (WebCore::Range::setStartBefore):
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::setOption):
  • xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::evaluate):
8:14 PM Changeset in webkit [27700] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::restorePlatformState): Clear the flag since we no longer know if the transform is identity or not. (WebCore::GraphicsContext::strokeArc): Removed an extra set of redundant CGContextSave/RestoreGState. (WebCore::GraphicsContext::beginTransparencyLayer): Clear the flag since we no longer know if the transform is identity or not. (WebCore::GraphicsContext::endTransparencyLayer): Ditto. (WebCore::GraphicsContext::scale): Ditto. (WebCore::GraphicsContext::rotate): Ditto. (WebCore::GraphicsContext::translate): Ditto. (WebCore::GraphicsContext::concatCTM): Ditto. (WebCore::GraphicsContext::roundToDevicePixels): Return quickly if the transform is known to be identity, and record that fact when we discover it otherwise.
  • platform/graphics/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Added a m_userToDeviceTransformKnownToBeIdentity flag, initialized to false.
8:09 PM Changeset in webkit [27699] by Darin Adler
  • 7 edits in trunk/WebCore

Reviewed by Mitz.

I measured a speed-up of the page load test while developing this patch. I don't
have a precise figure, though.

  • html/HTMLTokenizer.h: Removed unneeded lineNumberPtr() function. Also renamed lineno to m_lineNumber.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processListing): Don't pass 0 to the advance function since we don't want to update a line number. (WebCore::HTMLTokenizer::parseSpecial): Ditto. (WebCore::HTMLTokenizer::parseComment): Pass the line number data member directly instead of lineNumberPtr() since the advance function now takes a reference. (WebCore::HTMLTokenizer::parseServer): Ditto. (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto. (WebCore::HTMLTokenizer::parseText): Ditto. (WebCore::HTMLTokenizer::parseEntity): Ditto. (WebCore::HTMLTokenizer::parseTag): Ditto. (WebCore::HTMLTokenizer::write): Ditto.
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::write):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write): Don't pass 0 to the advance function.
  • platform/SegmentedString.h: (WebCore::SegmentedString::advance): Streamlined the most common case, and pushed less common cases into a separate function that is not inlined. Also got rid of a branch by separating the case with a line number from the case without one.
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::advanceSlowCase): Added. The aforementioned less common cases are here.
7:36 PM Changeset in webkit [27698] by oliver
  • 2 edits in trunk/JavaScriptCore

Partial fix for <rdar://problem/5585334> numfuzz: integer overflows opening malformed SVG file in WebCore::ImageBuffer::create

Reviewed By Eric.

Unfortunately this is a very slight regression, but is unavoidable.

6:02 PM Changeset in webkit [27697] by Antti Koivisto
  • 2 edits in trunk/WebCore

Forgot to do this review change (and test HTTP commit).

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::play):
5:54 PM Changeset in webkit [27696] by antti
  • 7 edits
    8 adds in trunk

WebCore:

Reviewed by Darin.


  • Update play() and pause() to match current HTML5 draft
    • send events asynchronously
    • add timeupdate event to pause
    • rethrow load() exception, not others
  • Use list for async events to get ordering right

Tests: media/video-pause-empty-events.html

media/video-play-empty-events.html
media/video-play-pause-events.html
media/video-play-pause-exception.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::dispatchEventAsync): (WebCore::HTMLMediaElement::asyncEventTimerFired): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause):
  • html/HTMLMediaElement.h:

LayoutTests:

Reviewed by Darin.


Add tests for play() and pause() events.
Update one test to match new behavior.

  • media/video-currentTime-expected.txt:
  • media/video-currentTime.html:
  • media/video-pause-empty-events-expected.txt: Added.
  • media/video-pause-empty-events.html: Added.
  • media/video-play-empty-events-expected.txt: Added.
  • media/video-play-empty-events.html: Added.
  • media/video-play-pause-events-expected.txt: Added.
  • media/video-play-pause-events.html: Added.
  • media/video-play-pause-exception-expected.txt: Added
  • media/video-play-pause-exception.html: Added
  • media/video-test.js:
4:34 PM Changeset in webkit [27695] by eseidel
  • 13 edits in trunk

2007-11-10 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

Add simple type inferencing to the parser, and create custom
AddNode and LessNode subclasses based on inferred types.
​http://bugs.webkit.org/show_bug.cgi?id=15884

SunSpider claims this is at least a 0.5% speedup.

  • JavaScriptCore.exp:
  • kjs/grammar.y:
  • kjs/internal.cpp: (KJS::NumberImp::getPrimitiveNumber): (KJS::GetterSetterImp::getPrimitiveNumber):
  • kjs/internal.h:
  • kjs/lexer.cpp: (KJS::Lexer::lex):
  • kjs/nodes.cpp: (KJS::Node::Node): (KJS::StringNode::evaluate): (KJS::StringNode::evaluateToNumber): (KJS::StringNode::evaluateToBoolean): (KJS::RegExpNode::evaluate): (KJS::UnaryPlusNode::optimizeVariableAccess): (KJS::AddNode::evaluate): (KJS::AddNode::evaluateToNumber): (KJS::AddNumbersNode::inlineEvaluateToNumber): (KJS::AddNumbersNode::evaluate): (KJS::AddNumbersNode::evaluateToNumber): (KJS::AddStringsNode::evaluate): (KJS::AddStringLeftNode::evaluate): (KJS::AddStringRightNode::evaluate): (KJS::lessThan): (KJS::lessThanEq): (KJS::LessNumbersNode::evaluate): (KJS::LessStringsNode::evaluate):
  • kjs/nodes.h: (KJS::ExpressionNode::): (KJS::RegExpNode::): (KJS::RegExpNode::precedence): (KJS::TypeOfResolveNode::): (KJS::LocalVarTypeOfNode::): (KJS::UnaryPlusNode::): (KJS::UnaryPlusNode::precedence): (KJS::AddNode::): (KJS::AddNode::precedence): (KJS::AddNumbersNode::): (KJS::AddStringLeftNode::): (KJS::AddStringRightNode::): (KJS::AddStringsNode::): (KJS::LessNode::): (KJS::LessNode::precedence): (KJS::LessNumbersNode::): (KJS::LessStringsNode::):
  • kjs/nodes2string.cpp: (KJS::StringNode::streamTo):
  • kjs/object.cpp:
  • kjs/object.h:
  • kjs/value.h: (KJS::JSValue::getPrimitiveNumber):
4:25 PM Changeset in webkit [27694] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-11 Alp Toker <​alp@atoker.com>

Reviewed by Anders.

Initialize m_userAgent.

Fix typos in GDK_WINDOWING conditionals.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::agentPlatform):
2:36 PM Changeset in webkit [27693] by Nikolas Zimmermann
  • 1 edit in trunk/WebCore/ChangeLog

Forgot to commit ChangeLog, in my last commit.

2:33 PM Changeset in webkit [27692] by Nikolas Zimmermann
  • 2 edits
    9 adds in trunk

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=6424 (<text>, <tspan> dominant-baseline attribute is not respected)

Add (basic) support for dominant-baseline / alignment-baseline text properties.
Note: there are no official testcases, and no-one implemented it before. Only ASV3

supported dominant-baseline, but not correct it seems.

12:51 PM Changeset in webkit [27691] by Adam Roben
  • 7 edits in trunk

Fix <rdar://5133816> keepWebHistory is not implemented

WebCore:

Add wrappers around CoCreateInstance to COMPtr

I followed the example of the Query constructor and query method by
adding a Create constructor and create method.

Reviewed by Darin.

  • platform/win/COMPtr.h: (COMPtr::COMPtr): Added a new constructor that calls CoCreateInstance. (COMPtr::create): Added. (COMPtr::createInstance): Added.

WebKitTools:

Fix <rdar://5133816> keepWebHistory is not implemented

Fixes fast/history/clicked-link-is-visited.html.

Reviewed by Darin.

  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Clear the optionalSharedHistory.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.

LayoutTests:

Remove a now-passing test from the Windows Skipped file

Reviewed by Darin.

  • platform/win/Skipped:
12:28 PM Changeset in webkit [27690] by ap@webkit.org
  • 32 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15896
More editing cleanup

No functionality changes.

  • dom/Node.h: Moved several editing-related methods elsewhere.
  • dom/Node.cpp: (WebCore::Node::maxCharacterOffset): Renamed from maxOffset() to highlight that it is a match to offsetInCharacters(), and much different from other offset-related methods. Added ASSERT_NOT_REACHED(), as callers are supposed to check offsetInCharacters() before calling this.
  • dom/CharacterData.cpp: (WebCore::CharacterData::maxCharacterOffset):
  • dom/CharacterData.h: (WebCore::CharacterData::isCharacterDataNode): Updated for above renamings.
  • dom/Comment.{h,cpp}: Removed an override for offsetInCharacters(), which is already present in CharacterData.
  • dom/Document.{h,cpp}: Folded updateSelection() into Frame::selectionLayoutChanged().
  • dom/Position.h:
  • dom/Position.cpp: (WebCore::Position::uncheckedPreviousOffset): Moved from Node::previousOffset(). (WebCore::Position::uncheckedNextOffset): Moved from Node::NextOffset(). (WebCore::Position::previous): Adapted to the above move. (WebCore::Position::next): Ditto. (WebCore::Position::upstream): Removed an isBR() check, since a non-BR element cannot have a BR renderer (I think), and BR elements are covered by editingIgnoresContent(). (WebCore::Position::downstream): Ditto. (WebCore::caretMaxRenderedOffset): Moved from Node::caretMaxRenderedOffset(). (WebCore::Position::rendersInDifferentPosition): Updated for the above moves.
  • dom/PositionIterator.h: Added a comment describing this class from the original check-in.
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::increment): Updated for the above moves. (WebCore::PositionIterator::decrement): Ditto.
  • dom/ProcessingInstruction.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::maxCharacterOffset): ProcessingInstruction was already returning true from offsetInCharacters(), but didn't override maxCharacterOffset(). I think that implementing it has no actual effect, as PIs are not rendered, but it looks cleaner this way.
  • dom/Range.cpp: (WebCore::Range::selectNodeContents):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyle): (WebCore::maxRangeOffset): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::positionOutsideTabSpan):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::insertTab):
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition): Updated for the above moves.
  • editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): Added a missing rangeCompliantEquivalent() call.
  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Changed the condition to obviously match a maxCharacterOffset() call made after it; hopefully, this doesn't break any border cases. (WebCore::SimplifiedBackwardsTextIterator::advance): Updated for the above moves.
  • editing/htmlediting.h:
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Removed a bogus comment: I don't thin BRs have a special ability to accept child nodes, other than via DOM manipulation, which is not specific to BRs. (WebCore::rangeCompliantEquivalent): Removed a check for BR, which is already covered by editingIgnoresContent(). (WebCore::maxDeepOffset): Ditto. (WebCore::caretMinOffset): Moved from Node. Changed some runtime checks that seemingly cannot fail into assertions. (WebCore::caretMaxOffset): Ditto.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): Pass 0 to VisiblePosition constructor instead of caretMinOffset. I didn't want to include htmlediting.h here, and I think that VisiblePosition constructor will take care of adjusting the offset.
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Folded Document::updateSelection() here.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): Added missing rangeCompliantEquivalent() calls.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForRenderer): Changed to not round-trip via editing. Changed some runtime checks that seemingly cannot fail into assertions.
11:24 AM Changeset in webkit [27689] by Darin Adler
  • 6 edits in trunk/JavaScriptCore
  • try another way of fixing dftables builds -- refactor pcre_internal.h a bit
  • pcre/pcre_internal.h: Make most of this header do nothing when DFTABLES is set. Later we can break it into two files.
  • JavaScriptCore.vcproj/dftables/dftables.vcproj: Take out now-unneeded include paths.
  • pcre/dftables.cpp: Set DFTABLES. Use delete instead of free.
  • pcre/dftables.pro: Take out now-unneeded include paths.
  • pcre/pcre_maketables.cpp: Use new instead of malloc.
11:05 AM Changeset in webkit [27688] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • pcre/dftables.pro: Try fixing Qt builds (I looked at qt-win) by adding another include path.
11:03 AM Changeset in webkit [27687] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • JavaScriptCore.xcodeproj/project.pbxproj: Try fixing Mac Tiger builds by adding another include path.
10:56 AM Changeset in webkit [27686] by Darin Adler
  • 22 edits
    9 moves
    4 deletes in trunk

JavaScriptCore:

Reviewed by Sam.

This is a combination of converting to C++, tweaking the API, and adding
some additional optimizations.

Future steps will involve getting rid of the use of UTF-8 completely
(we'll use UTF-16 exclusively instead), eliminating more source files,
and some more speed-ups.

SunSpider says the current round is an 0.9% speed-up overall, and a
5.3% speed-up for regexp.

  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Changed to use the error message without calling strdup on it and to pass the new types and options. (KJS::RegExp::~RegExp): Removed the now-unneeded free of the error message. (KJS::RegExp::match): Pass the new types and options.
  • kjs/regexp.h: Update type of m_constructionError.
  • pcre/AUTHORS: Update to reflect the status of the project -- we don't include the Google parts, and this isn't the PCRE library, per se.
  • pcre/COPYING: Ditto.
  • pcre/dftables.cpp: Copied from JavaScriptCore/pcre/dftables.c. (main): Removed unneeded ctype_digit.
  • pcre/pcre.h: Convert to C++, tweak API a bit. Use UChar instead of JSRegExpChar.
  • pcre/pcre_compile.cpp: Copied from JavaScriptCore/pcre/pcre_compile.c. Moved a lot of private stuff used only within this file here from pcre_internal.h. Renumbered the error codes. (error_text): Use a single string with embedded nulls for the error text (I got this idea from newer versions of PCRE). (check_escape): Changed return type to be enum instead of int. Replaced ctype_digit uses with isASCIIDigit. (is_counted_repeat): Ditto. (read_repeat_counts): Ditto. (first_significant_code): Ditto. (find_fixedlength): Ditto. (could_be_empty_branch): Ditto. (compile_branch): Ditto. Also removed some code that handles changing options. JavaScript doesn't have any of the features that allow options to change. (compile_regex): Updated for change to options parameter. (is_anchored): Ditto. (find_firstassertedchar): Ditto. (jsRegExpCompile): Changed to take separate flags instead of an options int. Also changed to call new/delete instead of pcre_malloc/free. (jsRegExpFree): Ditto.
  • pcre/pcre_exec.cpp: Copied from JavaScriptCore/pcre/pcre_exec.c. Added a case that uses computed goto for the opcode loop, but did not turn it on. Changed the RMATCH macro to handle returns more efficiently by putting the where pointer in the new frame instead of the old one, allowing us to branch to the return with a single statement. Switched to new/delete from pcre_malloc/free. Changed many RRETURN callers to not set the return value since it's already set correctly. Replaced the rrc variable with an is_match variable. Values other than "match" and "no match" are now handled differently. This allows us to remove the code to check for those cases in various rules. (match): All the case statements use a macro BEGIN_OPCODE instead. And all the continue statements, or break statements that break out of the outer case use a macro NEXT_OPCODE instead. Replaced a few if statements with assertions. (jsRegExpExecute): Use new/delete instead of pcre_malloc/free. Removed unused start_match field from the match block.
  • pcre/pcre_internal.h: Moved the last few configuration macros from pcre-config.h in here. Removed various unused types. Converted from JSRegExpChar to UChar. Eliminated pcre_malloc/free. Replaced the opcode enum with a macro that can be used in multiple places. Unfortunately we lose the comments for each opcode; we should find a place to put those back. Removed ctype_digit.
  • pcre/pcre_maketables.cpp: Copied from JavaScriptCore/pcre/pcre_maketables.c. (pcre_maketables): Got rid of the conditional code that allows this to be compiled in -- it's only used for dftables now (and soon may be obsolete entirely). Changed code for cbit_digit to not use isdigit, and took the "_" case out of the loop. Removed ctype_digit.
  • pcre/pcre_ord2utf8.cpp: Copied from JavaScriptCore/pcre/pcre_ord2utf8.c.
  • pcre/pcre_tables.cpp: Copied from JavaScriptCore/pcre/pcre_tables.c. Moved _pcre_OP_lengths out of here into pcre_exec.cpp.
  • pcre/pcre_ucp_searchfuncs.cpp: Copied from JavaScriptCore/pcre/pcre_ucp_searchfuncs.c. Updated for other file name changes.
  • pcre/ucpinternal.h: Updated header.
  • wtf/ASCIICType.h: (WTF::isASCIIDigit): Removed a branch by changing from && to & for this operation. Also added an overload that takes an int because that's useful for PCRE. Later we could optimize for int and overload other functions in this file; stuck to this simple one for now.
  • wtf/unicode/icu/UnicodeIcu.h: Removed unused isUpper.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.
  • pcre/LICENCE: Removed.
  • pcre/pcre-config.h: Removed.
  • wtf/FastMallocPCRE.cpp: Removed.
  • pcre/dftables.c: Renamed to cpp.
  • pcre/pcre_compile.c: Ditto.
  • pcre/pcre_exec.c: Ditto.
  • pcre/pcre_maketables.c: Ditto.
  • pcre/pcre_ord2utf8.c: Ditto.
  • pcre/pcre_tables.c: Ditto.
  • pcre/pcre_ucp_searchfuncs.c: Ditto.
  • pcre/pcre_xclass.c: Ditto.
  • pcre/ucptable.c: Ditto.

WebCore:

Reviewed by Sam.

  • updated for JSRegExp function changes
  • platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::match):
1:32 AM Changeset in webkit [27685] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-11 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Mention Safari in the UserAgent string to improve site compatibility.

Also bump the hard-coded AppleWebKit version number.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::composeUserAgent):
12:34 AM Changeset in webkit [27684] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-11 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.

Add KJS_CHECKEXCEPTIONBOOLEAN to match rest of nodes.cpp

  • kjs/nodes.cpp: (KJS::ExpressionNode::evaluateToBoolean): (KJS::LessNode::evaluateToBoolean): (KJS::GreaterNode::evaluateToBoolean): (KJS::LessEqNode::evaluateToBoolean): (KJS::GreaterEqNode::evaluateToBoolean): (KJS::InstanceOfNode::evaluateToBoolean): (KJS::InNode::evaluateToBoolean): (KJS::EqualNode::evaluateToBoolean): (KJS::NotEqualNode::evaluateToBoolean): (KJS::StrictEqualNode::evaluateToBoolean): (KJS::NotStrictEqualNode::evaluateToBoolean): (KJS::LogicalAndNode::evaluateToBoolean): (KJS::LogicalOrNode::evaluateToBoolean): (KJS::ConditionalNode::evaluateToBoolean):
Note: See TracTimeline for information about the timeline view.