⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 14, 2007:

9:59 PM Changeset in webkit [27810] by ap@webkit.org
  • 7 edits in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15982
Improve JSString UTF-8 decoding

  • API/JSStringRef.cpp: (JSStringCreateWithUTF8CString): Use strict decoding, return 0 on error.
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::convertUTF16ToUTF8): (WTF::Unicode::convertUTF8ToUTF16):
  • wtf/unicode/UTF8.h: Made these function names start with a lower case letter.
  • kjs/ustring.cpp: (KJS::UString::UTF8String): Updated for the above renaming.
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback): Renamed to highlight the difference from convertUTF8ToUTF16 in wtf/unicode. (KJS::Bindings::convertNPStringToUTF16): Updated for the above renaming. (KJS::Bindings::identifierFromNPIdentifier): Ditto.
  • bindings/c/c_utility.h: Made convertUTF8ToUTF16WithLatin1Fallback() a file static.
9:49 PM Changeset in webkit [27809] by ap@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Justin Garcia.

​http://bugs.webkit.org/show_bug.cgi?id=15781
REGRESSION: Ligatures fail to form when typing in Devanagari (because WebKit can't handle
a marked range that covers half of a composed character sequence)

Test: platform/mac/editing/input/devanagari-ligature.html

This fix is somewhat of a hack, as it asks editing commands to work with invalid selections.
However, this is not entirely new for them, as Roman accents are typed in a similar manner.

In the future, we probably want to make commands work with ranges (or Positions explicitly).

  • editing/Editor.cpp: (WebCore::Editor::selectComposition): Force selection to composition range.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Force ending selection to inserted text range.
9:17 PM Changeset in webkit [27808] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Anders.

Fix the Xcode project file after it was messed up in r27402.

7:52 PM Applications using WebKit edited by info@erikjohansson.com
Added Coda to "Web Development Applications" (diff)
6:40 PM Changeset in webkit [27807] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-11-14 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.

More PCRE style cleanup.

  • pcre/pcre_compile.cpp: (compile_regex):
6:02 PM Changeset in webkit [27806] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Clean up the bison conflict checking script

Reviewed by Geoff.

  • DerivedSources.make:
6:00 PM Changeset in webkit [27805] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2007-11-14 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

Another round of PCRE cleanups: inlines

SunSpider claims that this, combined with my previous PCRE cleanup were a 0.7% speedup, go figure.

  • pcre/pcre_compile.cpp: (jsRegExpCompile):
  • pcre/pcre_exec.cpp: (match): (jsRegExpExecute):
  • pcre/pcre_internal.h: (PUT): (GET): (PUT2): (GET2): (isNewline):
5:55 PM Changeset in webkit [27804] by beidson@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

For future use

  • images/DroseraPic.png: Added.
5:34 PM Changeset in webkit [27803] by Adam Roben
  • 3 edits in trunk/WebKitTools

Updates to Safari launching now that 3.0.4 is released

Reviewed by Sam.

  • FindSafari/FindSafari.cpp: (getWebViewCLSID): Use version-independent ProgID.
  • Scripts/run-safari: Use run-webkit-nightly.cmd.
5:17 PM Changeset in webkit [27802] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2007-11-14 Eric Seidel <​eric@webkit.org>

Reviewed by Sam.

Give PCRE a (small) bath.
Fix some formating and break things off into separate functions
​http://bugs.webkit.org/show_bug.cgi?id=15993

  • pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): (printCompiledRegExp): (returnError): (jsRegExpCompile):
  • pcre/pcre_internal.h: (compile_data::compile_data):
5:04 PM Changeset in webkit [27801] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Try to make this test less timing dependent.

  • http/tests/media/video-play-stall.html:
3:48 PM Changeset in webkit [27800] by Beth Dakin
  • 7 edits
    5 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5540855> REGRESSION: Combination of client-
side image map and <a> tag is not working properly (15522)

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD): Allow <map> to have both block and inline children rather than just block children. This matches Firefox.

LayoutTests:

Reviewed by Hyatt.

Tests for <rdar://problem/5540855> REGRESSION: Combination of
client-side image map and <a> tag is not working properly (15522)

New test:

  • fast/images/image-map-anchor-children.html: Added.
  • fast/images/resources/boston.gif: Added.
  • platform/mac/fast/images/image-map-anchor-children- expected.checksum: Added.
  • platform/mac/fast/images/image-map-anchor-children-expected.png: Added.
  • platform/mac/fast/images/image-map-anchor-children-expected.txt: Added.


This test was broken and is fixed now! I had to edit the test
itself because it was written in the html that the two <map>
examples were failing, but now they succeed.

  • fast/invalid/residual-style.html:
  • platform/mac/fast/invalid/residual-style-expected.checksum:
  • platform/mac/fast/invalid/residual-style-expected.png:
  • platform/mac/fast/invalid/residual-style-expected.txt:
2:59 PM Changeset in webkit [27799] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.


Cleaned up the JavaScript grammar a bit.


  1. Changed BlockNode to always hold a child vector (which may be empty), eliminating a few NULL-check branches in the common execution case.


  1. Changed the Block production to correctly report its starting and ending line numbers to the debugger. (It used to report its ending line as its starting line.) Also, removed duplicate line-reporting code inside the BlockNode constructor.


  1. Moved curly braces up from FunctionBody production into parent productions. (I had to move the line number reporting code, too, since it depends on the location of the curly braces.) This matches the ECMA spec more closely, and makes some future changes I plan easier.


  1. Fixed statementList* convenience functions to deal appropriately with empty Vectors.

SunSpider reports a small and statistically insignificant speedup.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::statementListPushFIFO): (KJS::statementListGetDeclarations): (KJS::statementListInitializeDeclarationStack): (KJS::statementListInitializeVariableAccessStack): (KJS::BlockNode::BlockNode): (KJS::BlockNode::optimizeVariableAccess): (KJS::BlockNode::getDeclarations): (KJS::BlockNode::execute): (KJS::FunctionBodyNode::initializeDeclarationStacks): (KJS::FunctionBodyNode::optimizeVariableAccess):
2:57 PM Changeset in webkit [27798] by Adam Roben
  • 2 edits in trunk/WebKit/win

Change Interfaces to be a "Static Library" project

Being a Utility project meant that Interfaces was rebuilding every
time (Utility projects are supposed to handle their own dependencies).
Interfaces isn't really a static library, but it means that VS will
handle dependencies for us (and not complain about missing manifests
like it did when the project was an Application).

  • WebKit.vcproj/Interfaces.vcproj:
2:56 PM Changeset in webkit [27797] by Adam Roben
  • 2 edits in trunk/WebKit/win

Shut up FixMIDLHeaders.pl

  • WebKit.vcproj/FixMIDLHeaders.pl:
2:33 PM Changeset in webkit [27796] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

<rdar://problem/5546763> CrashTracer: [USER] 362 crashes at WebCore::DeleteSelectionCommand::mergeParagraphs

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Removed an irrelevant FIXME. (WebCore::DeleteSelectionCommand::mergeParagraphs): If the block that contained the end of the selection hasn't been removed but has been emptied by deletion, we would to try and fail to create a VisiblePosition inside that block, which could lead to a crash. If that happens, there's no content in the block to move, so just remove the block and return. Preserve m_needPlaceholder during the call to moveParagraphs, since it may change it and since it does its own placeholder insertion when necessary. (WebCore::DeleteSelectionCommand::doApply): No need to check m_needPlaceholder before calling mergeParagraphs, because it handles preserving m_needPlaceholder when it calls moveParagraphs.

LayoutTests:

Reviewed by Alexey Proskuryakov.


<rdar://problem/5546763> CrashTracer: [USER] 362 crashes at WebCore::DeleteSelectionCommand::mergeParagraphs

  • editing/deleting/5546763-expected.txt: Added.
  • editing/deleting/5546763.html: Added.
2:30 PM Changeset in webkit [27795] by andersca@apple.com
  • 4 edits in trunk

WebKitTools:

Reviewed by Adam.

<rdar://problem/5309081>
In DRT, "plugin.logDestroy = true" not working on Windows.


  • DumpRenderTree/win/TestNetscapePlugin/main.c: (NPP_Destroy):

LayoutTests:

Reviewed by Adam.

<rdar://problem/5309081>
In DRT, "plugin.logDestroy = true" not working on Windows.

Remove now succeeding test from the skipped list.


  • platform/win/Skipped:
2:09 PM Changeset in webkit [27794] by timothy@apple.com
  • 2 edits in trunk/WebKitLibraries

Remove the WebKit dependancy from WebKitSystemInterface.

2:08 PM Changeset in webkit [27793] by Adam Roben
  • 1 edit in trunk/WebKit/win/ChangeLog

Fix ChangeLog order

2:07 PM Changeset in webkit [27792] by Adam Roben
  • 2 edits in trunk/WebKit/win

Change Interfaces to use a Utility configuration

It had previously been marked as an "Application (.exe)", which is
wrong but worked with most versions of Visual Studio.

Rubberstamped by Steve.

  • WebKit.vcproj/Interfaces.vcproj:
1:44 PM Changeset in webkit [27791] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Try to make this test less timing dependent.

  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set.html:
12:36 PM Changeset in webkit [27790] by eric@webkit.org
  • 4 edits in trunk

2007-11-14 Eric Seidel <​eric@webkit.org>

Reviewed by Sam.

  • sunspider: add --shark-cache for L2 Cache Miss profiling
11:19 AM Changeset in webkit [27789] by timothy@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Bug 14380: Long DOM ancestry breadcrumb lists get cut off
​http://bugs.webkit.org/show_bug.cgi?id=14380

The breadcumbs will now be compacted and collapsed if there isn't enough room
to show everything. The collapsing algorithm always affects the crumbs that
are farthest away from the selected or hovered crumb first.

  • page/inspector/DocumentPanel.js:
  • page/inspector/inspector.css:
11:10 AM Changeset in webkit [27788] by andersca@apple.com
  • 6 edits in trunk

WebKit/win:

Reviewed by Adam.

Get the new focus window from the wParam instead of calling GetFocus().
Also, send blur even if there is no focused frame.


  • WebView.cpp: (WebViewWndProc):

WebKitTools:

Reviewed by Adam.

<rdar://problem/5141186>
window.layoutTestController.setWindowIsKey is not implemented in DRT.


Implement setWindowIsKey.


  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setWindowIsKey):

LayoutTests:

Reviewed by Adam.

  • platform/win/Skipped: Remove fast/dom/Window/window-onFocus.html since it succeeds now.
10:53 AM Changeset in webkit [27787] by Adam Roben
  • 2 edits in trunk/WebKit/win

Another build fix for systems without Cygwin in their PATH

  • WebKit.vcproj/Interfaces.vcproj: Add Cygwin to the PATH in the Post-Build Event.
10:36 AM Changeset in webkit [27786] by andersca@apple.com
  • 4 edits in trunk/WebCore

Use the correct include path.


  • platform/Cursor.h:
  • plugins/win/PluginPackageWin.h:
  • plugins/win/PluginStreamWin.h:
10:11 AM Applications using WebKit edited by tristan@apple.com
(diff)
10:10 AM Applications using WebKit edited by tristan@apple.com
(diff)
8:33 AM BuildingGtk edited by zecke2@selfish.org
(diff)
8:32 AM BuildingGtk edited by zecke2@selfish.org
(diff)

Nov 13, 2007:

10:59 PM Changeset in webkit [27785] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2007-11-13 Mark Rowe <​mrowe@apple.com>

Gtk build fix. Replace incorrect use of the LOG macro with g_print.

  • Api/webkitgtkpage.cpp:
10:46 PM Changeset in webkit [27784] by beidson@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Adam

​http://bugs.webkit.org/show_bug.cgi?id=15976 - ASSERT/crash when SQLTransactionCallback throws an exception

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::deliverTransactionCallback): Make a transaction error for the case where the SQLTransactionCallback fails (WebCore::SQLTransaction::deliverTransactionErrorCallback): Don't assert on the error callback, but null check it and make the commit/rollback decision accordingly

LayoutTests:

Reviewed by Adam

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15976

  • storage: Added - There will soon be an entire suite in here!
  • storage/transaction_callback_exception_crash-expected.txt: Added.
  • storage/transaction_callback_exception_crash.html: Added.
10:25 PM Changeset in webkit [27783] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add the http/tests/media directory to the Windows Skipped file

  • platform/win/Skipped:
9:40 PM Changeset in webkit [27782] by alp@webkit.org
  • 5 edits in trunk/WebKit/gtk

2007-11-13 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented

Implement signals for script dialogs and console messages.

  • Api/webkitgtk-marshal.list:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole): (WebKit::ChromeClient::runJavaScriptAlert): (WebKit::ChromeClient::runJavaScriptConfirm): (WebKit::ChromeClient::runJavaScriptPrompt):
7:48 PM Changeset in webkit [27781] by oliver@apple.com
  • 4 edits in trunk/WebCore

Fix <rdar://problem/5365030> calling dataWithPDFInsideRect on an SVG with a gradient crashes (14780)

Reviewed by Anders.

When drawing directly to PDF CG may delay the use of the gradient function until outside our
standard drawing path, which in turn could let us invalidate the caches before they were used.

To work around this we now store the cached stops in a RefCounted object, so that we can ensure
that cache exists as long as required.

7:04 PM Changeset in webkit [27780] by ggaren@apple.com
  • 6 edits in trunk/WebKit/qt

Build fix: changed Shared to RefCounted.

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/ContextMenuClientQt.cpp:
  • WebCoreSupport/ContextMenuClientQt.h:
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.h:
6:33 PM Changeset in webkit [27779] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix Windows build.


  • platform/Cursor.h:
  • plugins/win/PluginPackageWin.h:
  • plugins/win/PluginStreamWin.h:
6:20 PM Changeset in webkit [27778] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Add RefCounted.h (And remove Shared.h)


6:19 PM Changeset in webkit [27777] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • kjs/regexp.h:
6:05 PM Changeset in webkit [27776] by ggaren@apple.com
  • 108 edits
    4 moves in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

Renamed Shared to RefCounted.

  • API/JSClassRef.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/interpreter.h:
  • kjs/regexp.h:
  • wtf/RefCounted.h: Copied from JavaScriptCore/wtf/Shared.h. (WTF::RefCounted::RefCounted):
  • wtf/Shared.h: Removed.

JavaScriptGlue:

Reviewed by Anders Carlsson.

Renamed Shared to RefCounted.

  • ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/Shared.h.
  • ForwardingHeaders/wtf/Shared.h: Removed.

WebCore:

Reviewed by Anders Carlsson.

Renamed Shared to RefCounted.

  • ForwardingHeaders/wtf/RefCounted.h: Copied from WebCore/ForwardingHeaders/wtf/Shared.h.
  • ForwardingHeaders/wtf/Shared.h: Removed.
  • bindings/js/JSSVGPODTypeWrapper.h:
  • css/CSSFontFace.h:
  • css/CSSRuleList.h:
  • css/Counter.h:
  • css/Pair.h:
  • css/Rect.h:
  • css/StyleBase.h:
  • css/StyleSheetList.h:
  • dom/Attribute.h:
  • dom/Clipboard.h:
  • dom/DOMImplementation.h:
  • dom/Event.h:
  • dom/EventListener.h:
  • dom/NamedNodeMap.h:
  • dom/NodeFilter.h:
  • dom/NodeFilterCondition.h:
  • dom/NodeList.h:
  • dom/QualifiedName.h:
  • dom/Range.h:
  • dom/RangeException.h:
  • dom/RegisteredEventListener.h:
  • dom/Traversal.h:
  • editing/EditCommand.h:
  • history/BackForwardList.h:
  • history/CachedPage.h:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h:
  • html/CanvasGradient.h:
  • html/CanvasPattern.h:
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.h:
  • html/HTMLCollection.h:
  • html/MediaError.h:
  • html/TimeRanges.h:
  • html/VoidCallback.h:
  • ksvg2/css/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::SVGAngle):
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGException.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRenderingIntent.h:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGUnitTypes.h:
  • loader/DocumentLoader.h:
  • loader/FormState.h:
  • loader/ResourceLoader.h:
  • loader/TextResourceDecoder.h:
  • loader/icon/IconRecord.h:
  • page/BarInfo.h:
  • page/Console.h:
  • page/DOMSelection.h:
  • page/DOMWindow.h:
  • page/Frame.h:
  • page/History.h:
  • page/InspectorController.cpp:
  • page/Plugin.h:
  • page/Screen.h:
  • platform/ArrayImpl.h:
  • platform/CString.h:
  • platform/Cursor.h:
  • platform/DeprecatedValueListImpl.cpp: (WebCore::DeprecatedValueListImpl::Private::Private):
  • platform/FileChooser.h:
  • platform/FontFallbackList.h:
  • platform/FontFamily.cpp: (WebCore::FontFamily::FontFamily):
  • platform/FontFamily.h:
  • platform/FontSelector.h:
  • platform/GlyphPageTreeNode.h:
  • platform/PopupMenu.h:
  • platform/RegularExpression.cpp:
  • platform/ScrollBar.h:
  • platform/SharedBuffer.h:
  • platform/StringImpl.h:
  • platform/graphics/Icon.h:
  • platform/graphics/svg/SVGResource.h:
  • platform/network/FormData.cpp: (WebCore::FormData::FormData):
  • platform/network/FormData.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
  • rendering/RenderStyle.h:
  • rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGCharOnPath::SVGCharOnPath):
  • storage/SQLResultSetRowList.h:
  • xml/DOMParser.h:
  • xml/XMLHttpRequest.h:
  • xml/XMLSerializer.h:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.h:
  • xml/XPathNSResolver.h:
  • xml/XPathResult.h:
  • xml/XPathValue.h:
  • xml/XSLTProcessor.h:

WebKit/mac:

Reviewed by Anders Carlsson.


Renamed Shared to RefCounted.

  • ForwardingHeaders/wtf/RefCounted.h: Copied from WebKit/mac/ForwardingHeaders/wtf/Shared.h.
  • ForwardingHeaders/wtf/Shared.h: Removed.
  • WebCoreSupport/WebContextMenuClient.h:
5:54 PM Changeset in webkit [27775] by beidson@apple.com
  • 2 edits
    4 deletes in trunk/WebCore

Reviewed by Mark Rowe

Remove errantly added files, and fix the idl (for reference's sake)

  • storage/JSCustomSQLStatementCallback.h: Removed.
  • storage/JSCustomSQLStatementErrorCallback.h: Removed.
  • storage/JSCustomSQLTransactionCallback.h: Removed.
  • storage/JSCustomSQLTransactionErrorCallback.h: Removed.
  • storage/SQLStatementCallback.idl:
5:41 PM Changeset in webkit [27774] by Adam Roben
  • 3 edits in trunk/WebCore

Fix a bug and improve upon Brady's fix

Reviewed by Anders.

  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql): Made the code a little clearer and more correct.
  • loader/icon/IconDatabase.cpp: Put parentheses around the expansion of IS_ICON_SYNC_THREAD() so that ASSERT_NOT_SYNC_THREAD() does the comparison it meant to.
5:39 PM Changeset in webkit [27773] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Qt and Gtk builds.

  • WebCore.pro: Remove non-generated idl files.
5:36 PM Changeset in webkit [27772] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-13 Mark Rowe <​mrowe@apple.com>

Remove removed file from the project.

  • WebCore.pro:
5:30 PM Changeset in webkit [27771] by weinig@apple.com
  • 5 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

Fix for <rdar://problem/5382579>
http/tests/security/cross-frame-access-put.html reports large
negative numbers for screenLeft and screenTop (Mac reports "0")

  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::UIDelegate): Initialize the RECT. (UIDelegate::setFrame): copy the contents of the rect, not the pointer. (UIDelegate::webViewFrame): ditto.
  • DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*

LayoutTests:

Reviewed by Adam Roben.

Fix for <rdar://problem/5382579>
http/tests/security/cross-frame-access-put.html reports large
negative numbers for screenLeft and screenTop (Mac reports "0")

  • platform/win/Skipped: remove http/tests/security/cross-frame-access-put.html
5:29 PM Changeset in webkit [27770] by beidson@apple.com
  • 2 edits in trunk/WebCore

Release build fix

  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
5:05 PM Changeset in webkit [27769] by kmccullough@apple.com
  • 17 edits in trunk

WebKit/win:

Reviewed by Adam.

  • Make Drosera show source, source URLs, and function stack on Windows and some minor fixes.
  • WebScriptCallFrame.cpp: Fixed a bug where the callFrame was not reffed properly before being returned, and changed functionName() to check for Null or if the name is empty. (EnumScopes::Clone): (WebScriptCallFrame::WebScriptCallFrame): (WebScriptCallFrame::createInstance): (WebScriptCallFrame::caller): (WebScriptCallFrame::functionName):
  • WebScriptCallFrame.h: Ditto
  • WebScriptDebugServer.cpp: Made the listenerSet static since we were already treating it as if it were. Removed the EnumViews stuff. This was added by Steve to demonstrate DCOM and he thought it would be needed by Drosera, but I don't believe it will be. Implemented suspendProcessIfPaused() also added calls to it at the end of several functions to ensure we pause if Drosera has told WebKit to. (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::sharedWebScriptDebugServer): (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::suspendProcessIfPaused): (WebScriptDebugServer::didLoadMainResourceForDataSource): (WebScriptDebugServer::didParseSource): (WebScriptDebugServer::failedToParseSource): (WebScriptDebugServer::didEnterCallFrame): (WebScriptDebugServer::willExecuteStatement): (WebScriptDebugServer::willLeaveCallFrame): (WebScriptDebugServer::exceptionWasRaised):
  • WebScriptDebugServer.h: Ditto.
  • WebScriptDebugger.cpp: The important change here is that leaveFrame() is called before willLeaveCallFrame(). I think there is some EOL stuff going on too.
  • It was the implementing of these functions that allows source, the source URLs and function stack to be displayed. (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): (WebScriptDebugger::enterFrame): (WebScriptDebugger::leaveFrame):
  • WebView.cpp: Removed the EnumView functions. (WebView::WebView): (WebView::~WebView):

WebKitTools:

Reviewed by Adam.

  • Make Drosera show source, source URLs, and function stack on Windows, and some minor fixes.
  • Drosera/DebuggerDocument.cpp: Force source to always update display. (DebuggerDocument::updateFileSource):
  • Drosera/debugger.js: Force source to always update display.
  • Drosera/win/DebuggerClient.cpp: Create the needed functions for the menu controls. (DebuggerClient::resume): (DebuggerClient::pause): (DebuggerClient::stepInto): (DebuggerClient::stepOver): (DebuggerClient::stepOut): (DebuggerClient::showConsole): (DebuggerClient::closeCurrentFile):
  • Drosera/win/DebuggerClient.h: Ditto.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Changed getPlatformCurrentFunctionStack to not use an unecessary HRESULT and removed two bugs. 1) caller could be in a bad state when asked to assign into it. 2) BSTRs were not created correctly. (DebuggerDocument::getPlatformCurrentFunctionStack):
  • Drosera/win/Drosera.cpp: Hook up the menu controls. (droseraWndProc): (handleCommand): (Drosera::resume): (Drosera::pause): (Drosera::stepInto): (Drosera::stepOver): (Drosera::stepOut): (Drosera::showConsole): (Drosera::closeCurrentFile):
  • Drosera/win/Drosera.h: Hook up the menu controls.
  • Drosera/win/ServerConnection.cpp: Removed unncessary server connection functions, added a null check, and fixed another bug where caller could be in a bad state when asked to assign into it. (ServerConnection::didLoadMainResourceForDataSource): (ServerConnection::getCallerFrame):
  • Drosera/win/ServerConnection.h: Safety first.
4:58 PM Changeset in webkit [27768] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Build fix

Reviewed by Geoff.

  • kjs/regexp.h: Added a missing #include.
4:51 PM Changeset in webkit [27767] by andersca@apple.com
  • 2 edits
    1 add
    3 deletes in trunk/LayoutTests

Reviewed by Adam.


Make this a text-only test.


  • fast/dom/Window/window-onFocus-expected.txt: Added.
  • fast/dom/Window/window-onFocus.html:
  • platform/mac/fast/dom/Window/window-onFocus-expected.checksum: Removed.
  • platform/mac/fast/dom/Window/window-onFocus-expected.png: Removed.
  • platform/mac/fast/dom/Window/window-onFocus-expected.txt: Removed.
4:49 PM Changeset in webkit [27766] by mitz@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed the --paint option because the painting code is always exercised as a result of -[FrameLoadDelegate webView:didFinishLoadFromFrame:] calling -displayIfNeeded. (dump): Changed to always grab the image from the window since the view is always displayed. (runTest): (displayWebView):
  • Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree because it always paints.
4:44 PM Changeset in webkit [27765] by Adam Roben
  • 5 edits
    2 copies
    1 add in trunk

Fix <rdar://5346832> Infinite recursion when opening Web Inspector on more than one tab

WebCore:

Add WindowMessageBroadcaster

This class is used to listen in on messages sent to HWNDs. Multiple
WindowMessageListeners can be notified about messages sent to a single
HWND, and one WindowMessageListener can listen to messages from
multiple HWNDs.

Reviewed by Ada.

  • WebCore.vcproj/WebCore.vcproj: Added new files to project.
  • platform/win/WindowMessageBroadcaster.cpp: Added. (WebCore::instancesMap): Static helper. (WebCore::WindowMessageBroadcaster::addListener): Registers a listener for a particular HWND. (WebCore::WindowMessageBroadcaster::removeListener): Removes a listener for a particular HWND. (WebCore::WindowMessageBroadcaster::WindowMessageBroadcaster): (WebCore::WindowMessageBroadcaster::~WindowMessageBroadcaster): (WebCore::WindowMessageBroadcaster::destroy): Removes this broadcaster from the instancesMap, removes all of its listeners, unsubclasses the window, and deletes the broadcaster. (WebCore::WindowMessageBroadcaster::unsubclassWindow): Unsubclasses the window (which means that SubclassedWndProc won't be called again for this window). (WebCore::WindowMessageBroadcaster::SubclassedWndProc): Notifies all the listeners about every message sent to the HWND
  • platform/win/WindowMessageBroadcaster.h: Added. (WebCore::WindowMessageBroadcaster::listeners): (WebCore::WindowMessageBroadcaster::originalWndProc):
  • platform/win/WindowMessageListener.h: Added.

WebKit/win:

Fix <rdar://5346832> Infinite recursion when opening Web Inspector on more than one tab

The bug was that multiple WebNodeHighlights would subclass the same
browser window, leading to infinite recursion within
SubclassedWndProc.

WebNodeHighlight is now a WindowMessageListener, and lets
WindowMessageBroadcaster handle subclassing the window.

Reviewed by Ada.

  • WebNodeHighlight.cpp: (WebNodeHighlight::WebNodeHighlight): Initialize m_observedWindow member. (WebNodeHighlight::~WebNodeHighlight): Unregister as a listener for m_observedWindow. (WebNodeHighlight::highlight): Register as a listener. (WebNodeHighlight::windowReceivedMessage): Do the work that used to be done in SubclassedWndProc.
  • WebNodeHighlight.h: Made WebNodeHighlight a WindowMessageListener, and renamed m_subclassedWindow to m_observedWindow.
4:44 PM Changeset in webkit [27764] by Adam Roben
  • 2 edits in trunk/WebKit/win

Build fix for systems that don't have Cygwin in their PATH

  • WebKit.vcproj/Interfaces.vcproj: Put Cygwin in the PATH before trying to run bash.
4:30 PM Changeset in webkit [27763] by ggaren@apple.com
  • 92 edits
    1 copy
    1 move
    3 adds in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

Moved Shared.h into wtf so it could be used in more places. Deployed
Shared in places where JSCore previously had hand-rolled ref-counting
classes.

  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass):
  • API/JSClassRef.h:
  • API/JSObjectRef.cpp: (JSClassRetain): (JSClassRelease):
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/interpreter.cpp: (KJS::Interpreter::init):
  • kjs/interpreter.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp):
  • kjs/regexp.h:
  • wtf/Shared.h: Copied from WebCore/platform/Shared.h.

JavaScriptGlue:

Reviewed by Sam Weinig.

Moved Shared.h into wtf so it could be used in more places.

  • ForwardingHeaders/wtf/Shared.h: Added.

WebCore:

Reviewed by Sam Weinig.

Moved Shared.h into wtf so it could be used in more places. Retained
TreeShared, but moved it to its own file, TreeShared.h.

  • ForwardingHeaders/wtf/Shared.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSVGPODTypeWrapper.h:
  • css/CSSFontFace.h:
  • css/CSSRuleList.h:
  • css/Counter.h:
  • css/Pair.h:
  • css/Rect.h:
  • css/StyleBase.h:
  • css/StyleSheetList.h:
  • dom/Clipboard.h:
  • dom/DOMImplementation.h:
  • dom/Event.h:
  • dom/EventListener.h:
  • dom/NamedNodeMap.h:
  • dom/NodeFilterCondition.h:
  • dom/NodeList.h:
  • dom/Range.h:
  • dom/RangeException.h:
  • dom/RegisteredEventListener.h:
  • dom/Traversal.h:
  • history/BackForwardList.h:
  • history/CachedPage.h:
  • history/HistoryItem.h:
  • html/CanvasGradient.h:
  • html/CanvasPattern.h:
  • html/HTMLCollection.h:
  • html/MediaError.h:
  • html/TimeRanges.h:
  • html/VoidCallback.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRenderingIntent.h:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGUnitTypes.h:
  • loader/DocumentLoader.h:
  • loader/FormState.h:
  • loader/ResourceLoader.h:
  • loader/TextResourceDecoder.h:
  • loader/icon/IconRecord.h:
  • page/BarInfo.h:
  • page/Console.h:
  • page/DOMSelection.h:
  • page/DOMWindow.h:
  • page/History.h:
  • page/InspectorController.cpp:
  • page/Plugin.h:
  • page/Screen.h:
  • platform/ArrayImpl.h:
  • platform/CString.h:
  • platform/DeprecatedValueListImpl.cpp:
  • platform/FontFallbackList.h:
  • platform/FontFamily.h:
  • platform/FontSelector.h:
  • platform/GlyphPageTreeNode.h:
  • platform/PopupMenu.h:
  • platform/RegularExpression.cpp:
  • platform/ScrollBar.h:
  • platform/Shared.h: Removed.
  • platform/SharedBuffer.h:
  • platform/StringImpl.h:
  • platform/graphics/Icon.h:
  • platform/graphics/svg/SVGResource.h:
  • platform/network/FormData.h:
  • platform/network/ResourceHandleClient.h:
  • rendering/RenderStyle.h:
  • rendering/SVGCharacterLayoutInfo.h:
  • storage/SQLResultSetRowList.h:
  • xml/DOMParser.h:
  • xml/XMLSerializer.h:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.h:
  • xml/XPathNSResolver.h:
  • xml/XPathResult.h:

WebKit/mac:

Reviewed by Sam Weinig.

Moved Shared.h into wtf so it could be used in more places.

  • ChangeLog:
  • WebCoreSupport/WebContextMenuClient.h:
4:26 PM Changeset in webkit [27762] by beidson@apple.com
  • 24 edits
    2 copies
    2 moves
    2 adds
    8 deletes in trunk

Squashed commit of the following:

commit 3e6cb737b3b823b4bf177b9e0c2fcfcc38baf46d
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Nov 13 16:22:36 2007 -0800

Changelog for commit

commit 4be13a5ef17685368e68a76292b785c99da1d7f2
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Nov 13 16:19:34 2007 -0800

Make inspector work with new API

commit c500ed90c32b31fbc37a183c8ae5427f36b9ccc2
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Nov 13 14:37:16 2007 -0800

Woops!

commit c61b147f35a2801c340f82054d177914da6ccde5
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Nov 13 11:45:40 2007 -0800

Ander's review comments

commit f3dc2683acc5730cbab8758226adae3e35f7263b
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 12 18:05:21 2007 -0800

Initial vcproj changes after the rebase

commit c8cf9be275479ff1fb39b911e5165f07fcd5ae34
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 12 18:02:30 2007 -0800

Fixed Changelog a bit

commit c9790cde9b79e25690f1c0b34b9c1e77d2f4449f
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 12 16:53:48 2007 -0800

Finish the rebase/trunk merge

commit 663ad85619ec677eb5c52bed3c59b8b3f50de624
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Nov 6 11:54:26 2007 -0800

VCProj changes for new SQL api + blind attempt at keeping qt/gtk going

commit 2aceeb3bdfa6894bb4e93c0b129867059e9cdad7
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 15:27:55 2007 -0800

Changelog edit cleanup

commit a05f11fa4fa0ba935eb28df6d9628f29a4074d7a
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 15:25:27 2007 -0800

Changelog entries and small style cleanup

commit a2d34a78d06f446f4bdb6ea1797dfb91cfc336fe
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 13:37:10 2007 -0800

Minor edit

commit eaf0aa9c07cfeb54df312c130677ecbc60728c5f
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 13:32:20 2007 -0800

Do version check at time of executeSql

commit 3bac84615badcc810f44ebf14d1679bffd4cc8fb
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 13:04:14 2007 -0800

Newline = t3h gone

commit de7cfcf737b1a6143b74f1cc60955c317877ca27
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 13:02:11 2007 -0800

Example + inspector fixes

commit 536b119c219de72c97fe6756e226a36bef5e6880
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 11:47:30 2007 -0800

DatabaseExample works

commit fff79aa99dbf47955bc37ca325928460fc41a59e
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 10:36:59 2007 -0800

Remove the old, now unused DatabaseCallback

commit 06bc8e16ad346b755f767ce8e7849da819ccf96f
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 09:57:36 2007 -0800

Sort project file

commit 741084d108ec994ff513e18c3d7a3153f6dd6bb5
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Nov 5 09:30:37 2007 -0800

Sort the project file

commit 2e77cec4337db174f56269b7fb406d81ebb1de7d
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Nov 1 16:01:03 2007 -0700

Yay! Change version even works!

commit 05c2ed1f22e3b689dd453ea300154492937f46db
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Nov 1 15:19:56 2007 -0700

Nuke some DRT changes

commit 9b5b9b25c45d7d4720e4ddf4a31f163fb4f7faf2
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Nov 1 15:05:59 2007 -0700

Nuke some printfs

commit 8503eecdefa95278a15246bb4eed2dccb69af12a
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Nov 1 13:44:32 2007 -0700

Added "current transaction" to Database and reworked how scheduling goes

commit f70354c9a84d654d28894ab3c6b13679ce494fc3
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Nov 1 11:49:26 2007 -0700

Things are largely working. Still need to clean up loose ends in the sticky notes demo and do further testing

commit 417665cd15f020c22af5691577e5c8a072630839
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Nov 1 00:00:47 2007 -0700

Transaction steps are almost locked up completely. Still need the SQLError for the transaction error callback and actually implementing ::execute() on the SQLStatement

commit 752d572acd4d1d9832976b4869284e554845205a
Author: Anders Carlsson <​andersca@apple.com>
Date: Wed Oct 31 18:52:55 2007 -0700

Forgot this.

commit 2c8f2689d212296961a841c579a2f93609858862
Author: Anders Carlsson <​andersca@apple.com>
Date: Wed Oct 31 18:31:05 2007 -0700

Merge.

commit 7540d4fa7ef858400d9f834cba976a439394412d
Author: Brady Eidson <​beidson@apple.com>
Date: Wed Oct 31 17:14:30 2007 -0700

Even closer!

commit 143a70a5d026ab9fab1b5de91f826effcd481527
Author: Brady Eidson <​beidson@apple.com>
Date: Wed Oct 31 16:43:31 2007 -0700

Merge project file correctly

commit 11207e7b6e391a4052fc41f6db42ce30449c7e3e
Author: Anders Carlsson <​andersca@apple.com>
Date: Wed Oct 31 11:04:35 2007 -0700

Remove more unused methods.

commit 9a0d306d467eb9aa8c19825da03b7abe318c609c
Author: Anders Carlsson <​andersca@apple.com>
Date: Wed Oct 31 11:01:35 2007 -0700

Add SQLTransactionCallback.idl

commit 12e2fa2858145e3895320293462ec441c35a7e3d
Author: Anders Carlsson <​andersca@apple.com>
Date: Wed Oct 31 10:47:17 2007 -0700

Fix build.

commit 02f4631705b0f6e0bd3c715c64f4938ea53f4670
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Oct 30 23:36:24 2007 -0700

All steps now take place in the right order, following the right rules - only thing missing is the actual SQL executing!

commit 6a8c0d7d2beb745c070c55b14beac9a47d373fc4
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Oct 30 18:20:35 2007 -0700

Closer and closer we roll

commit f945446453ae48a28d6e2f3dcce4660feae0da79
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Oct 30 17:59:25 2007 -0700

Things are really rolling - transaction steps 1-5 are called as expected. Downhill from here

commit 138b49b62bc8f3d05b1171e280d403e8b15ef9c4
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Oct 30 14:50:14 2007 -0700

Use pointer-to-member functions for the transaction steps... !!!

commit 3eb4f794861827f5c88cd8c36efb144cdc537bd5
Author: Anders Carlsson <​andersca@apple.com>
Date: Tue Oct 30 14:45:59 2007 -0700

Remove more old cruft.

commit f18835f0709b4aff00903738974dbebb11a224f0
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Oct 30 13:55:05 2007 -0700

Restore that comment

commit 35b2eac5ac3ec338cc2a8a4fe611f85e62c72dd6
Author: Brady Eidson <​beidson@apple.com>
Date: Tue Oct 30 12:08:29 2007 -0700

Closer, still, to the new model working. Lotsa little tweaks

commit a8476702a7d9bb38b8e15966e837ceca5858e9b2
Author: Anders Carlsson <​andersca@apple.com>
Date: Tue Oct 30 11:23:02 2007 -0700

Wrap changeVersion.

commit aa0d8cc6aaaf674de341996555306eb9f122de3c
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Oct 29 22:35:16 2007 -0700

Dummy callback as part of transaction steps acheived! And other architectural changes

commit 01c0a92daf764375be79753bc7bc417aa0205168
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Oct 29 18:23:00 2007 -0700

Have a the first chunk of transaction steps occuring asynchronously with stubs and printf()s - should be downhill from here. Also updated the DatabaseExample.html for the portion of the new API that works so far.

commit 6b6e9e7a064424cd6b70489de80c79e7ae950b38
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Oct 29 17:32:30 2007 -0700

Made DatabaseTasks create mutex/conditions on demand, and renamed the internal sqlitedatabase

commit 99d06513090c2b4e04edda82d82108cf97da245a
Author: Anders Carlsson <​andersca@apple.com>
Date: Mon Oct 29 16:30:52 2007 -0700

Fix bug.

commit 83def2ce73fa001f5bda3e152ca60e58c563dbed
Author: Anders Carlsson <​andersca@apple.com>
Date: Mon Oct 29 15:17:45 2007 -0700

Remove some cruft.

commit 9f2c8c21d06d6b379426449357f1ee00a25faeee
Author: Anders Carlsson <​andersca@apple.com>
Date: Mon Oct 29 14:45:54 2007 -0700

More bindings.

commit 9eae9135ed17179b7bcd225648272d24b76de8b9
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Oct 29 14:19:34 2007 -0700

Adapt to new openDatabase() method

commit 2e1dad857b190634f4394475e925d2dc518ae1fe
Author: Brady Eidson <​beidson@apple.com>
Date: Mon Oct 29 12:05:53 2007 -0700

More infrastructure changes for the new spec, getting really close now!

commit b0d8ca9dc7ffe1a424070d5f8587346eca56b76b
Author: Brady Eidson <​beidson@apple.com>
Date: Fri Oct 26 17:25:41 2007 -0700

More stubbing of infrastructure

commit bb8c6528208a24f129af9a8c09763989e5723157
Author: Anders Carlsson <​andersca@apple.com>
Date: Fri Oct 26 15:38:16 2007 -0700

Remove SQLVersionChangeCallback.h

commit c77ec8b1d2a7c8cb7a6a0bc42b089c34541cdf83
Author: Brady Eidson <​beidson@apple.com>
Date: Fri Oct 26 15:28:08 2007 -0700

Make it build (removed the old changeVersion)

commit e205fd2d6cb0cd4e6dd47cf4b6609196d0d8e87d
Author: Brady Eidson <​beidson@apple.com>
Date: Fri Oct 26 14:53:15 2007 -0700

Even more progress in the architecture change

commit 322f576e2ed8c584244335f918302169c81ea39f
Author: Anders Carlsson <​andersca@apple.com>
Date: Fri Oct 26 14:52:22 2007 -0700

Add JSSQLTransactionCustom.cpp.

commit 22d0b184e1d5d92574b5caf2b73eb6c7faae84be
Author: Anders Carlsson <​andersca@apple.com>
Date: Fri Oct 26 13:21:55 2007 -0700

Add new API to Database.

commit 910660c7668f2728850990f8984045de9e41423f
Author: Anders Carlsson <​andersca@apple.com>
Date: Fri Oct 26 11:48:33 2007 -0700

Add more .IDL files

commit 4d0cbb5b3e8c57076ce0cb743f8a52a5e31c0219
Author: Brady Eidson <​beidson@apple.com>
Date: Fri Oct 26 11:20:54 2007 -0700

Further groundwork for new API (does not build)

commit d6420aacd1bf610ca53eced12e61ecd074f31bd7
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Oct 25 18:02:23 2007 -0700

Further stubs and adaptations to the new API

commit ea80b0c14037cfbdccf322146b26b62df2aa8211
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Oct 25 15:51:43 2007 -0700

Remove closeTransaction()

commit 4e701837674e07111da80a476135f5b73e25210f
Author: Brady Eidson <​beidson@apple.com>
Date: Thu Oct 25 14:05:40 2007 -0700

Further stubbing and API-matching cleanup

commit f667cf3c7847069a6720296710876394954611bd
Author: Anders Carlsson <​andersca@apple.com>
Date: Wed Oct 24 16:32:58 2007 -0700

Add extra arguments to Window.openDatabase.

commit efbbe3016a31a9c4a717de25d831406288f8126d
Author: Anders Carlsson <​andersca@apple.com>
Date: Wed Oct 24 14:21:22 2007 -0700

cleanup.

commit b70a8252a588eee36d06835bad5793361ced35c5
Author: Anders Carlsson <​andersca@apple.com>
Date: Wed Oct 24 12:31:06 2007 -0700

Stub out a couple of new classes.

2:14 PM Changeset in webkit [27761] by mitz@apple.com
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Beth Dakin.

  • fix <rdar://problem/5551163> REGRESSION: Cursor does not change to arrow on "X" button in google maps, making it hard to click
  • css/html4.css: Added a 'cursor: auto' rule for links.
  • manual-tests/link-cursor-auto.html: Added.
1:59 PM Changeset in webkit [27760] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

  • fix <rdar://problem/5516272> Reproducible crash in RenderObject::setStyle involving going Back from a non-HTML document (Bookmarks view, PDF view)

The root cause for the crash is that when a non-HTML view enters the
frame, the frame's document pointer keeps pointing at the last HTML-type
document it contained. This patch does not address the root cause, but
makes changes to account for that condition.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedMainResourceError): Do not change the frame's current document's page cache state here. (WebCore::FrameLoader::invalidateCurrentItemCachedPage): If the frame's current document is in fact the history item being invalidated, then set its page cache state here.
12:37 PM Changeset in webkit [27759] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2007-11-13 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Add an ASSERT to getTruncatedInt32 to enforce proper usage.
Best part about this patch? It doesn't break the web!

  • kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::getUInt32):
12:08 PM Changeset in webkit [27758] by Antti Koivisto
  • 10 edits
    4 adds in trunk

WebCore:

Reviewed by Adele.

Fix that 'timeupdate' and 'waiting' events were never dispatched.


Add explicit m_paused attribute instead of trying to derive paused state from
underlying media. Call updatePlayState() to start/stop media playback
when any attribute that affects active playback state changes. This matches
specification text.


Test: http/tests/media/video-play-stall.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::paused): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::movieDidEnd): (WebCore::HTMLMediaElement::updatePlayState):
  • html/HTMLMediaElement.h:

LayoutTests:

Reviewed by Adele.


  • add HTTP media test for stalling load
  • update tests that don't specifically test autoplay feature to not use autoplay attribute since playback may start before event listeners are registered
  • http/tests/media: Added.
  • http/tests/media/video-load-and-stall.cgi: Added.
  • http/tests/media/video-play-stall-expected.txt: Added.
  • http/tests/media/video-play-stall.html: Added.
  • media/video-autoplay.html:
  • media/video-dom-loopstart.html:
  • media/video-end.html:
  • media/video-loopcount.html:
  • media/video-loopend.html:
  • media/video-loopstart.html:
12:05 PM Changeset in webkit [27757] by Antti Koivisto
  • 2 edits in trunk/WebKitTools

Reviewed by Adele.


Add support for http media tests

  • Scripts/run-webkit-tests:
11:54 AM Changeset in webkit [27756] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

Windows build fix.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
  • kjs/ustring.cpp: (KJS::UString::UTF8String):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::ConvertUTF8ToUTF16):
11:29 AM Changeset in webkit [27755] by sfalken@apple.com
  • 4 edits in trunk/WebKit/win

Add IDOMElementPrivate::font() to get an element's font
as a WebFontDescription.


Reviewed by Darin.

  • DOMCoreClasses.cpp: (DOMElement::font):
  • DOMCoreClasses.h:
  • Interfaces/DOMPrivate.idl:
10:15 AM Changeset in webkit [27754] by sullivan@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

removed recently-added PreferredType concept; we found a better way to do what
ths was accomplishing

  • bridge/WindowFeatures.h: (WebCore::WindowFeatures::WindowFeatures): removed definition of PreferredType


  • page/ContextMenuController.cpp: (WebCore::openNewWindow): removed use of PreferredType

WebKit/mac:

Reviewed by Darin.

removed recently-added PreferredType concept; we found a better way to do what
ths was accomplishing

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): removed use of PreferredType
9:35 AM Changeset in webkit [27753] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Dan Bernstein.


  • fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in form fields other than the one you're typing into
  • WebCoreSupport/WebEditorClient.mm: (selectorForKeyEvent): correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445 but didn't get updated here.
9:25 AM Changeset in webkit [27752] by Darin Adler
  • 5 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

+ single-digit sequences like \4 should be treated as octal

character constants, unless there is a sufficient number
of brackets for them to be treated as backreferences

+ \8 turns into the character "8", not a binary zero character

followed by "8" (same for 9)

+ only the first 3 digits should be considered part of an

octal character constant (the old behavior was to decode
an arbitrarily long sequence and then mask with 0xFF)

+ if \x is followed by anything other than two valid hex digits,

then it should simply be treated a the letter "x"; that includes
not supporting the \x{41} syntax

+ if \u is followed by anything less than four valid hex digits,

then it should simply be treated a the letter "u"

+ an extra "+" should be a syntax error, rather than being treated

as the "possessive quantifier"

+ if a "]" character appears immediately after a "[" character that

starts a character class, then that's an empty character class,
rather than being the start of a character class that includes a
"]" character

+ a "$" should not match a terminating newline; we could have gotten

PCRE to handle this the way we wanted by passing an appropriate option

Test: fast/js/regexp-no-extensions.html

  • pcre/pcre_compile.cpp: (check_escape): Check backreferences against bracount to catch both overflows and things that should be treated as octal. Rewrite octal loop to not go on indefinitely. Rewrite both hex loops to match and remove \x{} support. (compile_branch): Restructure loops so that we don't special-case a "]" at the beginning of a character class. Remove code that treated "+" as the possessive quantifier. (jsRegExpCompile): Change the "]" handling here too.
  • pcre/pcre_exec.cpp: (match): Changed CIRC to match the DOLL implementation. Changed DOLL to remove handling of "terminating newline", a Perl concept which we don't need.
  • tests/mozilla/expected.html: Two tests are fixed now: ecma_3/RegExp/regress-100199.js and ecma_3/RegExp/regress-188206.js. One test fails now: ecma_3/RegExp/perlstress-002.js -- our success before was due to a bug (we treated all 1-character numeric escapes as backreferences). The date tests also now both expect success -- whatever was making them fail before was probably due to the time being close to a DST shift; maybe we need to get rid of those tests.

LayoutTests:

Reviewed by Geoff.

  • fast/js/regexp-no-extensions-expected.txt: Added.
  • fast/js/regexp-no-extensions.html: Added.
  • fast/js/resources/regexp-no-extensions.js: Added.
9:22 AM Changeset in webkit [27751] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): Remove too-strong assert that was firing constantly and preventing even basic web browsing from working in a debug build. This function is used in many cases where the immediate value is not a number; the assertion could perhaps be added back later with a bit of reorganization.
1:49 AM Changeset in webkit [27750] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-11-13 Alp Toker <​alp@atoker.com>

Build fix for breakage to non-Mac builds introduced in r27746.

  • kjs/ustring.cpp:
12:34 AM Changeset in webkit [27749] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2007-11-13 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Clean up evaluateToBoolean functions to use inlines instead of copy/paste code

  • kjs/JSImmediate.h:
  • kjs/nodes.cpp: (KJS::GreaterNode::inlineEvaluateToBoolean): (KJS::GreaterNode::evaluate): (KJS::LessEqNode::inlineEvaluateToBoolean): (KJS::LessEqNode::evaluate): (KJS::GreaterEqNode::inlineEvaluateToBoolean): (KJS::GreaterEqNode::evaluate): (KJS::InNode::evaluateToBoolean): (KJS::EqualNode::inlineEvaluateToBoolean): (KJS::EqualNode::evaluate): (KJS::NotEqualNode::inlineEvaluateToBoolean): (KJS::NotEqualNode::evaluate): (KJS::StrictEqualNode::inlineEvaluateToBoolean): (KJS::StrictEqualNode::evaluate): (KJS::NotStrictEqualNode::inlineEvaluateToBoolean): (KJS::NotStrictEqualNode::evaluate):
  • kjs/nodes.h:
12:05 AM Changeset in webkit [27748] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15958
base64 spends 1.1% of total time checking for special Infinity case


Use a fast character test instead of calling strncmp.


1.1% speedup on string-base64. SunSpider reports a .4% speedup overall;
Sharks reports only .1%. Who are you going to believe? Huh?

  • kjs/ustring.cpp: (KJS::UString::toDouble):
12:02 AM Changeset in webkit [27747] by eric@webkit.org
  • 6 edits in trunk/JavaScriptCore

2007-11-12 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.

Add evaluateToInt32 and evaluateUInt32 methods and deploy them.
Fix a few missing evaluateToBoolean methods
Deploy all evaluateTo* functions to more nodes to avoid slowdowns
​http://bugs.webkit.org/show_bug.cgi?id=15950

SunSpider claims this is at least a 1.4% speedup.

  • kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::getUInt32):
  • kjs/nodes.cpp: (KJS::ExpressionNode::evaluateToNumber): (KJS::ExpressionNode::evaluateToInt32): (KJS::ExpressionNode::evaluateToUInt32): (KJS::NumberNode::evaluateToInt32): (KJS::NumberNode::evaluateToUInt32): (KJS::ImmediateNumberNode::evaluateToInt32): (KJS::ImmediateNumberNode::evaluateToUInt32): (KJS::ResolveNode::evaluate): (KJS::ResolveNode::evaluateToNumber): (KJS::ResolveNode::evaluateToBoolean): (KJS::ResolveNode::evaluateToInt32): (KJS::ResolveNode::evaluateToUInt32): (KJS::LocalVarAccessNode::evaluateToInt32): (KJS::LocalVarAccessNode::evaluateToUInt32): (KJS::BracketAccessorNode::evaluateToNumber): (KJS::BracketAccessorNode::evaluateToBoolean): (KJS::BracketAccessorNode::evaluateToInt32): (KJS::BracketAccessorNode::evaluateToUInt32): (KJS::DotAccessorNode::inlineEvaluate): (KJS::DotAccessorNode::evaluate): (KJS::DotAccessorNode::evaluateToNumber): (KJS::DotAccessorNode::evaluateToBoolean): (KJS::DotAccessorNode::evaluateToInt32): (KJS::DotAccessorNode::evaluateToUInt32): (KJS::NewExprNode::inlineEvaluate): (KJS::NewExprNode::evaluate): (KJS::NewExprNode::evaluateToNumber): (KJS::NewExprNode::evaluateToBoolean): (KJS::NewExprNode::evaluateToInt32): (KJS::NewExprNode::evaluateToUInt32): (KJS::FunctionCallResolveNode::inlineEvaluate): (KJS::FunctionCallResolveNode::evaluate): (KJS::FunctionCallResolveNode::evaluateToNumber): (KJS::FunctionCallResolveNode::evaluateToBoolean): (KJS::FunctionCallResolveNode::evaluateToInt32): (KJS::FunctionCallResolveNode::evaluateToUInt32): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluateToNumber): (KJS::LocalVarFunctionCallNode::evaluateToBoolean): (KJS::LocalVarFunctionCallNode::evaluateToInt32): (KJS::LocalVarFunctionCallNode::evaluateToUInt32): (KJS::FunctionCallDotNode::evaluate): (KJS::FunctionCallDotNode::evaluateToNumber): (KJS::FunctionCallDotNode::evaluateToBoolean): (KJS::FunctionCallDotNode::evaluateToInt32): (KJS::FunctionCallDotNode::evaluateToUInt32): (KJS::PostDecLocalVarNode::inlineEvaluateToNumber): (KJS::PostDecLocalVarNode::evaluateToNumber): (KJS::PostDecLocalVarNode::evaluateToBoolean): (KJS::PostDecLocalVarNode::evaluateToInt32): (KJS::PostDecLocalVarNode::evaluateToUInt32): (KJS::typeStringForValue): (KJS::UnaryPlusNode::evaluate): (KJS::UnaryPlusNode::evaluateToBoolean): (KJS::UnaryPlusNode::evaluateToNumber): (KJS::UnaryPlusNode::evaluateToInt32): (KJS::BitwiseNotNode::inlineEvaluateToInt32): (KJS::BitwiseNotNode::evaluate): (KJS::BitwiseNotNode::evaluateToNumber): (KJS::BitwiseNotNode::evaluateToBoolean): (KJS::BitwiseNotNode::evaluateToInt32): (KJS::MultNode::evaluateToBoolean): (KJS::MultNode::evaluateToInt32): (KJS::MultNode::evaluateToUInt32): (KJS::DivNode::evaluateToInt32): (KJS::DivNode::evaluateToUInt32): (KJS::ModNode::evaluateToBoolean): (KJS::ModNode::evaluateToInt32): (KJS::ModNode::evaluateToUInt32): (KJS::AddNode::evaluateToNumber): (KJS::AddNode::evaluateToInt32): (KJS::AddNode::evaluateToUInt32): (KJS::AddNumbersNode::evaluateToInt32): (KJS::AddNumbersNode::evaluateToUInt32): (KJS::SubNode::evaluateToInt32): (KJS::SubNode::evaluateToUInt32): (KJS::LeftShiftNode::inlineEvaluateToInt32): (KJS::LeftShiftNode::evaluate): (KJS::LeftShiftNode::evaluateToNumber): (KJS::LeftShiftNode::evaluateToInt32): (KJS::RightShiftNode::inlineEvaluateToInt32): (KJS::RightShiftNode::evaluate): (KJS::RightShiftNode::evaluateToNumber): (KJS::RightShiftNode::evaluateToInt32): (KJS::UnsignedRightShiftNode::inlineEvaluateToUInt32): (KJS::UnsignedRightShiftNode::evaluate): (KJS::UnsignedRightShiftNode::evaluateToNumber): (KJS::UnsignedRightShiftNode::evaluateToInt32): (KJS::LessNode::inlineEvaluateToBoolean): (KJS::LessNode::evaluate): (KJS::LessNode::evaluateToBoolean): (KJS::LessNumbersNode::inlineEvaluateToBoolean): (KJS::LessNumbersNode::evaluate): (KJS::LessNumbersNode::evaluateToBoolean): (KJS::LessStringsNode::inlineEvaluateToBoolean): (KJS::LessStringsNode::evaluate): (KJS::BitAndNode::evaluate): (KJS::BitAndNode::inlineEvaluateToInt32): (KJS::BitAndNode::evaluateToNumber): (KJS::BitAndNode::evaluateToBoolean): (KJS::BitAndNode::evaluateToInt32): (KJS::BitXOrNode::inlineEvaluateToInt32): (KJS::BitXOrNode::evaluate): (KJS::BitXOrNode::evaluateToNumber): (KJS::BitXOrNode::evaluateToBoolean): (KJS::BitXOrNode::evaluateToInt32): (KJS::BitOrNode::inlineEvaluateToInt32): (KJS::BitOrNode::evaluate): (KJS::BitOrNode::evaluateToNumber): (KJS::BitOrNode::evaluateToBoolean): (KJS::BitOrNode::evaluateToInt32): (KJS::ConditionalNode::evaluateToNumber): (KJS::ConditionalNode::evaluateToInt32): (KJS::ConditionalNode::evaluateToUInt32): (KJS::valueForReadModifyAssignment): (KJS::AssignExprNode::evaluate): (KJS::AssignExprNode::evaluateToBoolean): (KJS::AssignExprNode::evaluateToNumber): (KJS::AssignExprNode::evaluateToInt32): (KJS::VarDeclNode::handleSlowCase):
  • kjs/nodes.h: (KJS::FunctionCallResolveNode::precedence): (KJS::AddNode::precedence): (KJS::AddNode::): (KJS::LessNumbersNode::): (KJS::LessStringsNode::):
  • kjs/value.cpp: (KJS::JSValue::toInt32SlowCase): (KJS::JSValue::toUInt32SlowCase):
  • kjs/value.h: (KJS::JSValue::asCell): (KJS::JSValue::toInt32): (KJS::JSValue::toUInt32):
Note: See TracTimeline for information about the timeline view.