Context Navigation

rename loopCount of HTMLMediaElement to playCount
add explicit seeking attribute to HTMLMediaElement to get semantics right
implement the specification behavior that currentTime must immediately return seeked position in HTMLMediaElement instead of MoviePrivateQTKit
fix broken behavior when seeking past end of the media, add tests
replace Movie didEnd callback with broader timeChanged callback (which gets called in didEnd case too)
use setDelayCallbacks: in various MoviePrivateQTKit methods to avoid bug prone synchronous callbacks from QT, make HTMLMediaElement not depend on synchronous callbacks
do some cleanups and simplifications in MoviePrivateQTKit, get rid of m_rateBeforeSeek and m_blockStateUpdate variables

Tests: http/tests/media/video-seekable-stall.html

media/video-seeking.html
media/video-seek-past-end-paused.html
media/video-seek-past-end-playing.html

html/HTMLAttributeNames.in:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::movieNetworkStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::seeking): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::ended): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::playCount): (WebCore::HTMLMediaElement::setPlayCount): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::movieTimeChanged): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::updateMovie):
html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:
platform/graphics/Movie.cpp: (WebCore::Movie::timeChanged):
platform/graphics/Movie.h: (WebCore::MovieClient::movieTimeChanged):
platform/graphics/mac/MoviePrivateQTKit.h:
platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::doSeek): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seekTimerFired): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::didEnd):

LayoutTests:

Reviewed by Adele.

Seeking related test updates

update to match specificiation
- rename loopCount to playCount everywhere
- timeupdate events during seek
fix that some tests (like audio ones) depended on timing sensitive ordering of play and load events
add text about what is being tested

Add new tests for seeking past end, seeking past loaded position and 'seeking' DOM attribute.

http/tests/media/video-seekable-stall-expected.txt: Added.
http/tests/media/video-seekable-stall.html: Added.
media/audio-constructor-expected.txt:
media/audio-constructor-src-expected.txt:
media/audio-constructor-src.html:
media/audio-constructor.html:
media/video-dom-loopcount-expected.txt:
media/video-dom-loopcount.html:
media/video-dom-loopend-expected.txt:
media/video-dom-loopend.html:
media/video-dom-loopstart-expected.txt:
media/video-dom-loopstart.html:
media/video-dom-start-expected.txt:
media/video-dom-start.html:
media/video-loopcount-expected.txt:
media/video-loopcount.html:
media/video-loopend-expected.txt:
media/video-loopend.html:
media/video-loopstart-expected.txt:
media/video-loopstart.html:
media/video-seek-past-end-paused-expected.txt: Added.
media/video-seek-past-end-paused.html: Added.
media/video-seek-past-end-playing-expected.txt: Added.
media/video-seek-past-end-playing.html: Added.
media/video-seeking-expected.txt: Added.
media/video-seeking.html: Added.
media/video-test.js:

5:32 PM Changeset in webkit [27865] by andersca@apple.com

5 edits in trunk

WebCore:

Reviewed by Adam.

<rdar://problem/5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Add new parameter which controls whether content sniffing should be turned off.

(WebCore::ResourceHandle::loadResourceSynchronously):
Always content sniff sync loads.

platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): If the ResourceRequest already has a backing CFURLRequest, make a copy of it. This preserves any properties set on the CFURLRequest.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.

Remove http/tests/xmlhttprequest/small-chunks-response-text.html from the Skipped list.

platform/win/Skipped:

5:25 PM Changeset in webkit [27864] by mitz@apple.com

1 edit in trunk/WebKitTools/ChangeLog

Fix ChangeLog

5:24 PM Changeset in webkit [27863] by mitz@apple.com

4 edits in trunk

WebKitTools:

Reviewed by Darin Adler and Sam Weinig.

fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on boomer

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): For characters that cannot be entered on the active keyboard layout, send a WM_CHAR message with the character along with a WM_KEYDOWN message with a virtual key code of 255.

LayoutTests:

Reviewed by Darin Adler and Sam Weinig.

remove fast/forms/select-type-ahead-non-latin.html after fixing <rdar://problem/5134075>

platform/win/Skipped:

5:16 PM Changeset in webkit [27862] by jhoneycutt@apple.com

2 edits in trunk/WebCore

2007-11-16 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

<rdar://problem/5605175> Crash closing or leaving window with ViewPoint
Media player plugin

ViewPoint plugin requires that we pass a valid NPSavedData* to
NPP_Destroy.

plugins/win/PluginViewWin.cpp: Pass a valid NPSavedData* to NPP_Destroy. If the plugin allocates data, discard it

4:52 PM Changeset in webkit [27861] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix.

3:50 PM Changeset in webkit [27860] by mrowe@apple.com

10 edits in trunk

Build WebCore as a sub-framework of WebKit in all configurations.

2:43 PM Changeset in webkit [27859] by mrowe@apple.com

5 edits in trunk/JavaScriptCore

2007-11-16 Mark Rowe <mrowe@apple.com>

Reviewed by Eric.

Replace strings, identifier, buffer8 and buffer16 members of Lexer with vectors.
SunSpider claims this is a 0.7% speedup.

kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::lex): (KJS::Lexer::record8): (KJS::Lexer::record16): (KJS::Lexer::scanRegExp): (KJS::Lexer::clear): (KJS::Lexer::makeIdentifier): (KJS::Lexer::makeUString):
kjs/lexer.h:
kjs/ustring.cpp: (KJS::UString::UString): Add a convenience constructor that takes a const Vector<UChar>&.
kjs/ustring.h:

2:27 PM Changeset in webkit [27858] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-16 Doug Turner <dougt@meer.net>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=16018
build bustage when building on debian 4.0

Fix build bustage on GTK+ with older versions of Pango.

Don't cache the return value since the docs say it can change.

platform/gtk/Language.cpp: (WebCore::defaultLanguage):

2:26 PM BuildingGtk edited by dougt@meer.net

Note about using qmake-qt4 (diff)

1:55 PM Changeset in webkit [27857] by Adam Roben

2 edits in trunk/JavaScriptCore

Windows build fix

JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add a new include path and ignore the int -> bool conversion warning.

11:21 AM Changeset in webkit [27856] by sullivan@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Brady

WebKit.exp: Exported some new database-related symbols

11:06 AM Changeset in webkit [27855] by beidson@apple.com

2 edits in trunk/WebKit

WebKit.xcodeproj/project.pbxproj: WebDatabaseManagerPrivate.h, also!

10:59 AM Changeset in webkit [27854] by beidson@apple.com

2 edits in trunk/WebKit

WebKit.xcodeproj/project.pbxproj: Mark WebSecurityOriginPrivate.h private so it is exported

9:34 AM Changeset in webkit [27853] by beidson@apple.com

5 edits
3 moves in trunk/WebKit

WebKit/mac:

Reviewed by John

Database management API tweaks

Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself

Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
the WebKit tree?

Misc/WebSecurityOrigin.mm: Removed.
Misc/WebSecurityOriginInternal.h: Removed.
Misc/WebSecurityOriginPrivate.h: Removed.

Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
Storage/WebDatabaseManagerPrivate.h:

Storage/WebSecurityOrigin.mm: Added. (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]): (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]): (-[WebSecurityOriginPrivate finalize]): (-[WebSecurityOriginPrivate dealloc]): (-[WebSecurityOrigin initWithProtocol:domain:]): (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
Storage/WebSecurityOriginInternal.h: Added.
Storage/WebSecurityOriginPrivate.h: Added.

WebKit:

Reviewed by John

Database management API tweaks

WebKit.xcodeproj/project.pbxproj:

9:25 AM Changeset in webkit [27852] by beidson@apple.com

2 edits in trunk/WebCore

Build fix

platform/SecurityOriginData.h: (WebCore::operator!=): Whoops!

9:13 AM Changeset in webkit [27851] by beidson@apple.com

8 edits
1 copy in trunk/WebCore

Reviewed by Sam

Further purify DatabaseTracker to use SecurityOriginData instead of "a String"

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:
WebCore.vcproj/WebCore.vcproj
WebCore.pro

platform/SecurityOriginData.cpp: Added. (WebCore::SecurityOriginData::SecurityOriginData): Add a constructor that takes a "stringIdentifier"-style string, since that form is what will be stored in the Databases.db on disk (WebCore::SecurityOriginData::stringIdentifier):
platform/SecurityOriginData.h: (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port):

storage/DatabaseTracker.cpp: (WebCore::SecurityOriginDataHash::hash): Follow the pattern Darin set in FontCache.cpp to make a decent hash for a SecurityOriginData object (WebCore::SecurityOriginDataHash::equal): (WebCore::SecurityOriginDataTraits::deletedValue): "file::1" will never exist in normal operation (WebCore::SecurityOriginDataTraits::emptyValue): "file::2" will never exist in normal operation (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::addDatabase):
storage/DatabaseTracker.h:

8:30 AM BuildingGtk edited by zecke2@selfish.org

(diff)

4:22 AM Changeset in webkit [27850] by Nikolas Zimmermann

980 edits in trunk/LayoutTests

Rubberstamped by Eric.

Full update of the SVG pixel tests - all files containing text show rendering improvements.
Text looks more 'bold' as it's supposed to be according to the W3C reference rendering, not
sure what commit actually caused it - but it's better now.

4:20 AM Changeset in webkit [27849] by ap@webkit.org

2 edits in trunk/WebCore

Windows build fix.

WebCore.vcproj/WebCore.vcproj: Removed VoidCallback.cpp, added JSCustomVoidCallback.{h,cpp}.

3:20 AM Changeset in webkit [27848] by Nikolas Zimmermann

11 edits
4 adds in trunk

Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12290

Implement all SVGTextContentElement DOM methods.
This is the last missing SVG text feature. SVG fonts is next.

Added testcase: svg/custom/text-dom-01-f.svg (tests all new methods)

2:49 AM Changeset in webkit [27847] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Fix Windows debug build.
Rubber-stamped by Eric

pcre/pcre_exec.cpp: (match): Removed ASSERT_NOT_REACHED assertions that were making MSVC complain about unreachable code.

Nov 15, 2007:

11:47 PM Changeset in webkit [27846] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-11-15 Mark Rowe <mrowe@apple.com>

Gtk build fix.

kjs/Parser.cpp:

11:44 PM Changeset in webkit [27845] by mrowe@apple.com

4 edits in trunk/JavaScriptCore

Mac build and header search path sanity fix.

Reviewed by Sam Weinig and Tim Hatcher.

Move base setting for HEADER_SEARCH_PATHS into Base.xcconfig, and extend
it in JavaScriptCore.xcconfig. This removes the need to override it on a
per-target basis inside the .xcodeproj file.

Configurations/Base.xcconfig:
Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:

11:08 PM Changeset in webkit [27844] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2007-11-15 Mark Rowe <mrowe@apple.com>

Qt build fix.

kjs/Parser.h:

11:00 PM Changeset in webkit [27843] by adele@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

Test: fast/forms/menulist-no-renderer-onmousedown.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Nil check the renderer here. None of the default behavior makes sense if there's no renderer. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Moved the nil check to the main defaultEventHandler.

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

fast/forms/menulist-no-renderer-onmousedown-expected.txt: Added.
fast/forms/menulist-no-renderer-onmousedown.html: Added.

10:54 PM Changeset in webkit [27842] by ggaren@apple.com

16 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

Another round of grammar / parsing cleanup.

Created distinct parser calls for parsing function bodies vs programs. This will help later with optimizing global variable access.

Turned Parser into a singleton. Cleaned up Lexer's singleton interface.

Modified Lexer to free a little more memory when done lexing. (Added FIXMEs for similar issues that I didn't fix.)

Changed Lexer::makeIdentifier and Lexer::makeUString to start respecting the arguments passed to them. (No behavior change, but this problem could have caused serious problems for an unsuspecting user of these functions.)

Removed KJS_DEBUG_MEM because it was bit-rotted.

Removed Parser::prettyPrint because the same work was simpler to do at the call site.

Some renames:

"Parser::accept" => "Parser::didFinishParsing"
"Parser::sid" => "Parser::m_sourceID"
"Lexer::doneParsing" => "Lexer::clear"
"sid" => "sourceId"
"lineno" => "lineNo"

JavaScriptCore.exp:
kjs/Parser.cpp: (KJS::Parser::Parser): (KJS::Parser::parseProgram): (KJS::Parser::parseFunctionBody): (KJS::Parser::parse): (KJS::Parser::didFinishParsing): (KJS::parser):
kjs/Parser.h: (KJS::Parser::sourceId):
kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
kjs/function_object.cpp: (FunctionObjectImp::construct):
kjs/grammar.y:
kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate):
kjs/interpreter.h:
kjs/lexer.cpp: (kjsyylex): (KJS::lexer): (KJS::Lexer::Lexer): (KJS::Lexer::~Lexer): (KJS::Lexer::scanRegExp): (KJS::Lexer::doneParsing): (KJS::Lexer::makeIdentifier): (KJS::Lexer::makeUString):
kjs/lexer.h: (KJS::Lexer::pattern): (KJS::Lexer::flags): (KJS::Lexer::sawError):
kjs/nodes.cpp: (KJS::Node::Node): (KJS::FunctionBodyNode::FunctionBodyNode):
kjs/nodes.h:
kjs/testkjs.cpp: (prettyPrintScript): (kjsmain):
kjs/ustring.cpp:
kjs/ustring.h:

10:25 PM Changeset in webkit [27841] by Antti Koivisto

2 edits in trunk/WebCore

Reviewed by Adele.

Fix <rdar://problem/5601598>
The movie tag should do initialization on need and not during startup.

Initialize Movie MIME type hash on demand

platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMovieMIMETypes): (WebCore::initialiseMIMETypeRegistry): (WebCore::MIMETypeRegistry::isSupportedMovieMIMEType): (WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):

10:18 PM Changeset in webkit [27840] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-15 Mark Rowe <mrowe@apple.com>

Build fix for Qt on Windows.

xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis):

10:15 PM Changeset in webkit [27839] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Bug 14761: Web Inspector leaks JS objects and DOM nodes
http://bugs.webkit.org/show_bug.cgi?id=14761

page/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): Change the tear down order so that inspectorDestroyed() is called before InspectorController private data is set to Zero. The inspectorDestroyed() call ends up closing the WebView and triggering InspectorController::close() which unprotects m_scriptObject. This didn't happen when the private data was cleared before calling inspectorDestroyed().

10:10 PM Changeset in webkit [27838] by mrowe@apple.com

2 edits in trunk/WebCore

2007-11-15 Mark Rowe <mrowe@apple.com>

Gtk build fix.

WebCore.pro:

10:04 PM Changeset in webkit [27837] by ap@webkit.org

4 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15989
XPath queries with predicates incorrectly retains the current node across unions

Test: fast/xpath/union-context-node.xhtml

xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Restore context after evaluation.
xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): Do not backup context, as we can easily re-create it.

10:02 PM Changeset in webkit [27836] by ap@webkit.org

1 edit
2 adds in trunk/LayoutTests

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15448
Import XPath test suite from amachang.art-code.org

Test by Hitoshi Amano <seijro@gmail.com>.

fast/xpath/xpath-functional-test-expected.txt: Added.
fast/xpath/xpath-functional-test.html: Added.

10:00 PM Changeset in webkit [27835] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15988
REGRESSION: XPath preceding-axis query misses nested elements

Test: fast/xpath/preceding-axis.xhtml

xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Hopefully correct this time.

5:21 PM Changeset in webkit [27834] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Mark Rowe and Sam.

This corrects a couple of issues in the Web Inspector where selected search results
would not have the right text color when the window is inactive or the results are focused.

page/inspector/inspector.css:

5:04 PM Changeset in webkit [27833] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Sam.

Bug 16007: REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels
http://bugs.webkit.org/show_bug.cgi?id=16007

Makes the click width an option on TreeElement and make ResourceCategoryTreeElement
a true subclass of TreeElement. The click width for ResourceCategoryTreeElement is
20 pixels, and the default is 10 pixels.

page/inspector/ResourceCategory.js:
page/inspector/treeoutline.js:

4:42 PM Changeset in webkit [27832] by andersca@apple.com

5 edits in trunk/WebCore

Reviewed by Brady.

Pass a VoidCallback to Database::transaction and Database::changeVersion.
This is not yet hooked up to the database machinery.

WebCore.vcproj/WebCore.vcproj:
bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
storage/Database.cpp: (WebCore::Database::changeVersion): (WebCore::Database::transaction):
storage/Database.h:

4:40 PM Changeset in webkit [27831] by oliver@apple.com

3 edits in trunk/JavaScriptCore

<rdar://problem/5601548> REGRESSION: All SourceElements and their children leak after a syntax error

Reviewed by Darin.

Add a stub node to maintain the Vector of SourceElements until assignment.

4:17 PM Changeset in webkit [27830] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Abstract most of RMATCH into MatchStack functions.

SunSpider claims this, combined with the last 2 patches was a 1% speedup, 10% for dna-regexp.

pcre/pcre_exec.cpp: (MatchStack::canUseStackBufferForNextFrame): (MatchStack::allocateNextFrame): (MatchStack::pushNewFrame): (MatchStack::frameIsStackAllocated): (MatchStack::popCurrentFrame): (MatchStack::unrollAnyHeapAllocatedFrames): (match):

4:16 PM Changeset in webkit [27829] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Remove RETURN_ERROR, add MatchStack

pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::unrollAnyHeapAllocatedFrames): (matchError): (match):

4:14 PM Changeset in webkit [27828] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Clean up match function to match WebKit style

JavaScriptCore.xcodeproj/project.pbxproj:
pcre/pcre_exec.cpp: (match):

4:07 PM Changeset in webkit [27827] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam.

Bug 16005: Hovering in the breadcrumbs causes jumpy behavior
http://bugs.webkit.org/show_bug.cgi?id=16005

Hovering over cumbs no longer exposes new crumbs. Clicking on a collapsed
crumb will expose as many hidden crumbs as possible to the user. Also crumbs
that have ID attributes will compact to the ID over the tag name.

page/inspector/DocumentPanel.js:

3:53 PM Changeset in webkit [27826] by andersca@apple.com

5 edits
2 adds
1 delete in trunk/WebCore

Reviewed by Sam.

Make the VoidCallback DOM interface behave more like our other DOM interfaces.

bindings/js/JSCustomVoidCallback.h: Added.
bindings/js/JSCustomVoidCallback.cpp: Added. (WebCore::JSCustomVoidCallback::JSCustomVoidCallback): (WebCore::JSCustomVoidCallback::handleEvent): VoidCallback implementation that wraps a JS object.

(WebCore::toVoidCallback):
New method that creates a VoidCallback implementation given a JS object.

bindings/scripts/CodeGeneratorJS.pm: Specify that VoidCallback can fail conversion and add a custom conversion function.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieCuePointReached): Call handleEvent on the callback.

(WebCore::HTMLMediaElement::removeCuePoint):
Comment out parts of this method, it has already been removed in the HTML5 spec and it relies
on overriding VoidCallback equality.

html/VoidCallback.cpp: Removed.

html/VoidCallback.h: (WebCore::VoidCallback::VoidCallback): (WebCore::VoidCallback::~VoidCallback): Make this an abstract class with a pure virtual handleEvent method.

3:42 PM Changeset in webkit [27825] by Adam Roben

2 edits in trunk/WebCore

Fix <rdar://5485108> Type-select while a <select> menu is open doesn't work

There were two things broken here:

WebView now requires a WM_CHAR message to be sent before it will create a keyboard event with a charCode, but we were only sending a WM_KEYDOWN event.
The popup menu was not updating its focused index when the <select> element's selectedIndex changed.

Reviewed by Adele.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::updateFromElement): Update the focused index from the client's selected index. (WebCore::PopupWndProc): When we receive a WM_CHAR message for a printable character, manufacture a WM_KEYDOWN message for it and post both that and the current WM_CHAR message to the WebView.

3:23 PM Changeset in webkit [27824] by beidson@apple.com

2 edits in trunk/WebCore

Build fix

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin):

2:54 PM Changeset in webkit [27823] by justin.garcia@apple.com

1 edit in trunk/LayoutTests/platform/mac/fast/events/5056619-expected.txt

Forgot this new expected result in my previous check-in.

2:29 PM Changeset in webkit [27822] by beidson@apple.com

1 edit in trunk/WebCore/ChangeLog

Reviewed by John and Sam

Stubbing out everything required for a WebKit API for databases

Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:

platform/SecurityOrigin.cpp:
platform/SecurityOrigin.h:
platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3 pieces of data in the SecurityOrigin tuple (WebCore::SecurityOriginData::SecurityOriginData): (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port): (WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components, colon separated

storage/Database.cpp: (WebCore::Database::Database): Use SecurityOriginData instead

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase):
storage/DatabaseTracker.h:

storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit (WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>

2:27 PM Changeset in webkit [27821] by beidson@apple.com

12 edits
5 copies
3 moves
3 adds in trunk

WebCore:

Reviewed by John and Sam

Stubbing out everything required for a WebKit API for databases

Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:

platform/SecurityOrigin.cpp:
platform/SecurityOrigin.h:
platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3 pieces of data in the SecurityOrigin tuple (WebCore::SecurityOriginData::SecurityOriginData): (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port): (WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components, colon separated

storage/Database.cpp: (WebCore::Database::Database): Use SecurityOriginData instead

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase):
storage/DatabaseTracker.h:

storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit (WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):

WebKit:

Reviewed by John

Stubbing out everything required for a WebKit API for databases

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Reviewed by John

Stubbing out everything required for a WebKit API for databases

These interfaces seem to provide everything we need for UI and management at the browser level

Misc/WebDatabaseManager.h: Removed.
Misc/WebDatabaseManager.mm: Removed.
Misc/WebDatabaseManagerPrivate.h: Removed.

Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple" (protocol, domain, and port) (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]): (-[WebSecurityOriginPrivate dealloc]): (-[WebSecurityOrigin initWithProtocol:domain:]): (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
Misc/WebSecurityOriginInternal.h: Added.
Misc/WebSecurityOriginPrivate.h: Added.

Storage/WebDatabaseManager.mm: Added. (+[WebDatabaseManager sharedWebDatabaseManager]): (-[WebDatabaseManager origins]): Get a list of all origins currently tracked (-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin (-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database (-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota (-[WebDatabaseManager deleteAllDatabases]): (-[WebDatabaseManager deleteAllDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
Storage/WebDatabaseManagerPrivate.h: Added.
Storage/WebDatabaseManagerInternal.h: Added. (WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things

Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
Storage/WebDatabaseTrackerClient.mm: Added. (WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient): (WebDatabaseTrackerClient::WebDatabaseTrackerClient): (WebDatabaseTrackerClient::~WebDatabaseTrackerClient): (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):

WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of Database-related things here

2:23 PM Changeset in webkit [27820] by jhoneycutt@apple.com

2 edits in trunk/WebCore

2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

NP_ASFILEONLY streams should not buffer data in m_deliveryData.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):

2:02 PM Changeset in webkit [27819] by andersca@apple.com

1 edit in trunk/LayoutTests/fast/dom/Window/window-onFocus.html

Revert accidental change. andersca--

1:52 PM Changeset in webkit [27818] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Adele Peterson.

<rdar://problem/5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode

A textarea that contained the selection was removed but the selection wasn't cleared,
and we'd crash in code that assumed a valid, in-document selection.

editing/SelectionController.cpp: (WebCore::removingNodeRemovesPosition): Clear the selection if the node being removed is the shadowAncestorNode of the node that contains the position, not just if the node being removed contains that shadowAncestorNode.

LayoutTests:

Reviewed by Adele Peterson.

<rdar://problem/5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode

editing/selection/5497643-expected.txt: Added.
editing/selection/5497643.html: Added.

1:35 PM Changeset in webkit [27817] by Adam Roben

2 edits in trunk/WebKitTools

Make run-safari actually work on Windows

Scripts/run-safari: Fixed the order of arguments to cp, and added a chdir call.

1:22 PM Changeset in webkit [27816] by Nikolas Zimmermann

2 edits in trunk/WebCore

Reviewed by Maciej.
Fix logic error: calculateGlyphBoundaries takes RTL text into account itself, no need to adjust offsets before.

12:27 PM Changeset in webkit [27815] by andersca@apple.com

4 edits
2 adds in trunk

WebCore:

Reviewed by Brady.

<rdar://problem/5562470>
openDatabase does not work when the version string is empty

If the string is empty, pass a real empty string to sqlite3_bind_text16.

platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::bindText):

LayoutTests:

Reviewed by Brady.

<rdar://problem/5562470>
openDatabase does not work when the version string is empty

storage/open-database-empty-version-expected.txt: Added.
storage/open-database-empty-version.html: Added.

12:00 PM Changeset in webkit [27814] by sfalken@apple.com

1 copy in tags/Safari-525.1b

New tag.

11:49 AM Changeset in webkit [27813] by andersca@apple.com

6 edits in trunk/WebCore

Reviewed by Brady.

Get rid of SQLiteStatement::bindText and rename bindText16 to bindText.
Remove the copy parameter from bindText and bindBlob and always copy passed in data instead.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase): (WebCore::IconDatabase::removePageURLFromSQLDatabase): (WebCore::IconDatabase::getIconIDForIconURLFromSQLDatabase): (WebCore::IconDatabase::addIconURLToSQLDatabase): (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase): (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase):
platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):
platform/sql/SQLiteStatement.h:
storage/Database.cpp: (WebCore::setTextValueInDatabase):
storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addDatabase):

10:39 AM Changeset in webkit [27812] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore.make:

12:01 AM Changeset in webkit [27811] by beidson@apple.com

2 edits in trunk/WebCore

WebCore:

Rubberstamped by Sam

platform/SecurityOrigin.h: Lets make this an unsigned short and *not* rule out half the possible ports?

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed