Timeline
Nov 18, 2007:
- 11:14 PM Changeset in webkit [27895] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric
Fix a crash hashing a default SecurityOriginData object
- storage/DatabaseTracker.cpp: (WebCore::SecurityOriginDataHash::hash): The default object has some default strings with NULL StringImpls - don't try to hash those!
- 4:40 PM Changeset in webkit [27894] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-18 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
- tests/mozilla/jsDriver.pl: exit non-0 when user aborts test run
- 3:04 PM Changeset in webkit [27893] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam Weinig.
Bug 16043: Remove InspectorController.log now that console.log works
http://bugs.webkit.org/show_bug.cgi?id=16043
Remove the last uses of InspectorController.log. Once use was no longer needed,
checking an erro case that can't happen anymore. The other case now uses console.error.
- page/InspectorController.cpp: Remove the log function. (WebCore::InspectorController::windowScriptObjectAvailable): Remove the log function from InspectorController script class.
- page/inspector/DocumentPanel.js: Remove a use of InspectorController.log that isn't needed.
- page/inspector/Panel.js: Change InspectorController.log to console.log and early return.
- 3:01 PM Changeset in webkit [27892] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady.
Bug 16041: REGRESSION: the Database panel in the Inspector stopped showing errors
http://bugs.webkit.org/show_bug.cgi?id=16041
- page/inspector/DatabasePanel.js: Implement error callbacks to pass to executeSql() and transaction(). Refactored some code for the success and error callbacks to use.
- 2:18 PM Changeset in webkit [27891] by
-
- 2 edits in trunk/WebKitTools
2007-11-18 Eric Seidel <eric@webkit.org>
Reviewed by Anders.
Make run-javascriptcore-tests report failures on exit (to support git bisect)
- Scripts/run-javascriptcore-tests:
- 9:54 AM Changeset in webkit [27890] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Adam Roben.
Make run-webkit-tests work with Windows debug build.
- DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
- DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT, as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically, and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
- 9:15 AM Changeset in webkit [27889] by
-
- 3 edits5 adds in trunk/WebKitTools
Add wxWebKit sample and build script, and integrate it with build-webkit. Also make build-webkit --clean work for all ports.
Reviewed by Darin Adler.
- 7:44 AM QtWebKitTodo edited by
- Updates (diff)
- 3:31 AM Changeset in webkit [27888] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-18 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented
Correct script-prompt to return NULL when cancelled.
Small changes to avoid compiler warnings.
- Api/webkitgtkpage.cpp:
- 1:49 AM Changeset in webkit [27887] by
-
- 1 edit in trunk/LayoutTests/fast/parser/html-whitespace.html
Restoring a binary svn:mime-type on the test.
- 1:46 AM Changeset in webkit [27886] by
-
- 3 edits2 adds in trunk
Reviewed by Maciej.
<rdar://problem/5546393> Whitespace handling doesn't match HTML5.
HTML5 definition is the same as MSIE's, with the exception that the latter strips null
characters. Firefox also treats U+0008 as whitespace, but not U+000B or U+000C.
Test: fast/parser/html-whitespace.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseTag): Use isASCIISpace, which matches HTML5 definition of whitespace, and also what we use to check for whitespace almost everywhere.
- 1:09 AM Changeset in webkit [27885] by
-
- 20 edits in trunk
Fix: <rdar://problem/5607032> (REGRESSION: testapi exits with assertion failure in debug build) and <rdar://problem/5440659> (JSGlobalContextCreate throws away globalObjectClass's prototype)
Split Interpreter's initialization into two distinct steps: the creation of the global prototypes
and constructors, and storing them on the global object. This allows JSClassRef's passed to
JSGlobalContextCreate to be instantiated with the correct prototype.
Reviewed by Darin Adler.
Nov 17, 2007:
- 10:58 PM Changeset in webkit [27884] by
-
- 3 edits in trunk/WebKit
Attempt to fix port builds.
'
- 10:40 PM Changeset in webkit [27883] by
-
- 41 edits2 adds in trunk
WebCore:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Add support for localization to the Web Inspector. Clients need to
implement localizedStringsURL() to return the URL of the
InspectorLocalizedStrings.js that best matches the user's language.
- English.lproj: Added.
- English.lproj/InspectorLocalizedStrings.js: Added.
- WebCore.xcodeproj/project.pbxproj: Add InspectorLocalizedStrings.js.
- page/InspectorClient.h: Add localizedStringsURL.
- page/InspectorController.cpp: Add localizedStringsURL that calls the client. Also added a version exposed to JavaScript.
- page/InspectorController.h: Add localizedStringsURL.
- page/inspector/ConsolePanel.js: Call WebInspector.UIString for user visible strings.
- page/inspector/DatabasePanel.js: Ditto.
- page/inspector/DocumentPanel.js: Ditto.
- page/inspector/ImagePanel.js: Ditto.
- page/inspector/MetricsSidebarPane.js: Ditto.
- page/inspector/NetworkPanel.js: Ditto.
- page/inspector/Panel.js: Ditto.
- page/inspector/PropertiesSidebarPane.js: Ditto.
- page/inspector/Resource.js: Ditto.
- page/inspector/ResourceCategory.js: Ditto.
- page/inspector/SourcePanel.js: Ditto.
- page/inspector/StylesSidebarPane.js: Ditto.
- page/inspector/inspector.css: Use pre-wrap so database errors can use \n.
- page/inspector/inspector.html: Remove some user visible strings.
- page/inspector/inspector.js: Added WebInspector.UIString and call WebInspector.UIString for user visible strings. Some code needed to be moved to WebInspector.loaded to use UIString after the localized strings get loaded.
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::redirectDataToPlugin): Remove WebCore:: prefix. (WebCore::SVGEmptyInspectorClient::createPage): Ditto. (WebCore::SVGEmptyInspectorClient::localizedStringsURL): Add empty stub. (WebCore::SVGEmptyInspectorClient::highlight): Remove WebCore:: prefix. (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.
WebKit:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Update the localized strings and the file encoding of WebInspectorClient.mm.
- English.lproj/Localizable.strings:
- StringsNotToBeLocalized.txt:
- WebKit.xcodeproj/project.pbxproj:
WebKit/gtk:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::localizedStringsURL): Empty stub.
- WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL.
WebKit/mac:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Implement the localizedStringsURL() client method to return the
localized URL of InspectorLocalizedStrings.js in WebCore.
- WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::localizedStringsURL): Added. (WebInspectorClient::updateWindowTitle): Localized the window title. (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore. (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
WebKit/qt:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::localizedStringsURL): Empty stub.
- WebCoreSupport/InspectorClientQt.h: Added localizedStringsURL.
WebKit/win:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
- English.lproj/Localizable.strings: Updated.
- WebInspectorClient.cpp: (WebInspectorClient::localizedStringsURL): Empty stub.
- WebInspectorClient.h: Added localizedStringsURL.
WebKit/wx:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
- WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::localizedStringsURL): Empty stub.
- WebKitSupport/InspectorClientWx.h: Added localizedStringsURL.
- 9:36 PM Changeset in webkit [27882] by
-
- 2 edits in trunk/JavaScriptCore
Prevent testapi from reporting false leaks.
Clear out local variables pointing at JSObjectRefs to allow their values to be collected.
Reviewed by Sam Weinig.
- 9:36 PM Changeset in webkit [27881] by
-
- 2 edits in trunk/JavaScriptCore
Prevent testapi from crashing if testapi.js can not be found by nil-checking the result of createStringWithContentsOfFile.
Reviewed by Sam Weinig.
- 5:14 PM Changeset in webkit [27880] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Remove IDL files from the WebCore.framework Resources.
- 3:14 PM Changeset in webkit [27879] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-17 Alp Toker <alp@atoker.com>
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=16032
JS minidom is not portable
Use a plain UTF-8 string instead of a CFString.
Print to stdout, not stderr like CFShow() would have done, since that
behaviour seems unintentional.
- API/minidom.c: (main):
- 12:49 PM Changeset in webkit [27878] by
-
- 7 edits1 copy in trunk
Make it easy to run Safari in the debugger on Windows
WebKitSite:
Update Windows debugging instructions
Reviewed by Mark Rowe.
- building/debug.html:
WebKitTools:
Make it easy to run Safari in the debugger on Windows
I've added a new script, debug-safari, which launches Safari in the
debugger. On OS X it just calls gdb-safari.
Reviewed by Mark Rowe.
- FindSafari/FindSafari.cpp: (_tmain): Added a /debugger flag, which in combination with /printSafariLauncher will print a script that launches Safari in the debugger.
- Scripts/debug-safari: Added.
- Scripts/run-safari: Changed to call runSafari().
- Scripts/run-webkit-nightly.cmd: Prepends the launcher script with vsvars32.bat, which will let us find VS/VC++ Express, and passes the first argument along to FindSafari.
- Scripts/webkitdirs.pm: (sub runSafari): Added.
- 12:02 PM Changeset in webkit [27877] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
Reworte String.sprintf to fix many bad bugs and to not use RegExp. Also added
String.vsprintf so it can be used later for the localization function.
This version only supports argument reordering, precision for floats, and these
format characters: d, f, s and @. Any unsupported format characters are logged
and substituted like strings.
- page/inspector/utilities.js:
- 9:06 AM Changeset in webkit [27876] by
-
- 1 copy in tags/Safari-525.1.1b
New tag.
- 8:53 AM Changeset in webkit [27875] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 2:39 AM Changeset in webkit [27874] by
-
- 4 edits in trunk
Windows build fix
WebKit:
- WebView.cpp: (WebView::deleteSelection): Use canSmartCopyOrDelete() directly.
WebCore:
- editing/Editor.h: Made canSmartCopyOrDelete public, as Windows WebView still needs it.
- 12:58 AM Changeset in webkit [27873] by
-
- 10 edits in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15969
Eliminate Editor::deleteRange()
No change in functionality.
WebCore:
- editing/CompositeEditCommand.h: Removed unimplemented deleteKeyPressed().
- editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::cut): (WebCore::Editor::performDelete):
- editing/Editor.h: Moved relevant Editor::deleteRange() functionality to its callers. Removed deleteSelectionWithSmartDelete(void), which was more confusing than helpful in my opinion.
- editing/mac/EditorMac.mm: (WebCore::initializeKillRingIfNeeded): (WebCore::Editor::addToKillRing): (WebCore::Editor::yank): (WebCore::Editor::yankAndSelect): (WebCore::Editor::setMark): (WebCore::unionDOMRanges): (WebCore::Editor::deleteToMark): (WebCore::Editor::selectToMark): (WebCore::Editor::swapWithMark): Pushed kill ring handling down from WebCore.
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm: Removed setMarkDOMRange (the corresponding getter is still needed).
- WebCore.base.exp: No longer need to export Editor::deleteRange() and Editor::insertTextWithoutSendingTextEvent(). Export the new kill ring functions.
WebKit:
- WebView/WebHTMLView.mm: (+[WebHTMLView initialize]): (-[WebHTMLView yank:]): (-[WebHTMLView yankAndSelect:]): (-[WebHTMLView setMark:]): (-[WebHTMLView deleteToMark:]): (-[WebHTMLView selectToMark:]): (-[WebHTMLView swapWithMark:]): Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
- 12:28 AM Changeset in webkit [27872] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam Roben.
- Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
